@embeddable.com/sdk-core 3.7.4 → 3.8.0-next.1

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@embeddable.com/sdk-core",
-  "version": "3.7.4",
+  "version": "3.8.0-next.1",
   "description": "Core Embeddable SDK module responsible for web-components bundling and publishing.",
   "keywords": [
     "embeddable",
@@ -34,13 +34,13 @@
     "embeddable": "bin/embeddable"
   },
   "engines": {
-    "node": ">=18.0.0"
+    "node": ">=20.0.0"
   },
   "license": "MIT",
   "dependencies": {
     "@embeddable.com/sdk-utils": "*",
-    "@inquirer/select": "^1.3.0",
-    "@stencil/core": "^4.18.2",
+    "@inquirer/select": "^4.0.0",
+    "@stencil/core": "^4.22.0",
     "@swc-node/register": "^1.9.0",
     "archiver": "^5.3.1",
     "axios": "^1.7.2",
@@ -52,7 +52,7 @@
     "ora": "^8.0.1",
     "serve-static": "^1.15.0",
     "sorcery": "^0.11.0",
-    "vite": "^5.3.2",
+    "vite": "^5.4.8",
     "ws": "^8.17.0",
     "yaml": "^2.3.3"
   },

package/src/dev.ts

@@ -102,7 +102,9 @@ export default async () => {
   try {
     previewWorkspace = await getPreviewWorkspace(workspacePreparation, config);
   } catch (e: any) {
-    workspacePreparation.fail(e.response.data?.errorMessage);
+    workspacePreparation.fail(
+      e.response?.data?.errorMessage || "Unknown error: " + e.message,
+    );
     process.exit(1);
   }
 

package/src/push.test.ts

@@ -74,8 +74,8 @@ const config = {
     buildDir: "buildDir",
     archiveFile: "embeddable-build.zip",
   },
-  pushBaseUrl: "pushBaseUrl",
-  previewBaseUrl: "previewBaseUrl",
+  pushBaseUrl: "http://localhost:3000",
+  previewBaseUrl: "http://localhost:3000",
 };
 
 describe("push", () => {
@@ -130,10 +130,10 @@ describe("push", () => {
     expect(fs.rm).toHaveBeenCalledWith(config.client.archiveFile);
 
     expect(infoMock.info).toHaveBeenCalledWith(
-      "Publishing to mocked-workspace-name using previewBaseUrl/workspace/mocked-workspace-id...",
+      "Publishing to mocked-workspace-name using http://localhost:3000/workspace/mocked-workspace-id...",
     );
     expect(infoMock.succeed).toHaveBeenCalledWith(
-      "Published to mocked-workspace-name using previewBaseUrl/workspace/mocked-workspace-id",
+      "Published to mocked-workspace-name using http://localhost:3000/workspace/mocked-workspace-id",
     );
   });
 

package/src/workspaceUtils.test.ts

@@ -1,7 +1,7 @@
 import { describe, it, expect, vi } from "vitest";
 import axios from "axios";
 import { getWorkspaces, selectWorkspace } from "./workspaceUtils";
-const inquirerSelect = import("@inquirer/select");
+import select from "@inquirer/select";
 
 vi.mock("axios");
 
@@ -62,6 +62,14 @@ describe("workspaceUtils", () => {
   });
 
   describe("selectWorkspace", () => {
+    beforeEach(() => {
+      vi.mocked(select).mockResolvedValue({
+        name: "Workspace 2",
+        workspaceId: "2",
+        devWorkspace: false,
+      });
+    });
+
     it("should select a workspace when only one is available", async () => {
       const ora = vi.fn().mockReturnValue({
         start: vi.fn().mockReturnThis(),
@@ -102,10 +110,6 @@ describe("workspaceUtils", () => {
 
       (axios.get as any).mockResolvedValue({ data: workspaces });
 
-      vi.mocked((await inquirerSelect).default).mockResolvedValue(
-        workspaces[1],
-      );
-
       const selectedWorkspace = await selectWorkspace(ora, ctx, token);
 
       expect(selectedWorkspace).toEqual(workspaces[1]);

package/src/workspaceUtils.ts

@@ -1,4 +1,4 @@
-const inquirerSelect = import("@inquirer/select");
+import select from "@inquirer/select";
 import axios from "axios";
 
 export async function getWorkspaces(
@@ -15,7 +15,7 @@ export async function getWorkspaces(
 
     return response.data?.filter((w: any) => !w.devWorkspace);
   } catch (e: any) {
-    if (e.response.status === 401) {
+    if (e.response?.status === 401) {
       workspaceSpinner.fail(
         'Unauthorized. Please login using "embeddable login" command.',
       );
@@ -47,7 +47,6 @@ export async function selectWorkspace(ora: any, ctx: any, token: string) {
   if (availableWorkspaces.length === 1) {
     selectedWorkspace = availableWorkspaces[0];
   } else {
-    const select = (await inquirerSelect).default;
     selectedWorkspace = await select({
       message: "Select workspace to push changes",
       choices: availableWorkspaces.map((workspace: any) => ({