@embeddable.com/sdk-core 3.14.6 → 3.14.7-next.1

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@embeddable.com/sdk-core",
-  "version": "3.14.6",
+  "version": "3.14.7-next.1",
   "description": "Core Embeddable SDK module responsible for web-components bundling and publishing.",
   "keywords": [
     "embeddable",
@@ -41,7 +41,7 @@
   "license": "MIT",
   "dependencies": {
     "@embeddable.com/core": "2.10.4",
-    "@embeddable.com/sdk-utils": "0.8.0",
+    "@embeddable.com/sdk-utils": "0.8.1-next.0",
     "@inquirer/prompts": "^7.2.1",
     "@stencil/core": "^4.23.0",
     "@swc-node/register": "^1.10.9",

package/src/buildTypes.test.ts

@@ -101,6 +101,9 @@ describe("buildTypes", () => {
     expect(build).toHaveBeenCalledWith({
       build: {
         emptyOutDir: false,
+        sourcemap: true,
+        minify: true,
+        rollupOptions: undefined,
         lib: {
           entry: "resolvedPath",
           fileName: "embeddable-types",
@@ -134,6 +137,49 @@ import '../relativePath';`,
     expect(getContentHash).not.toHaveBeenCalled();
     expect(fs.rename).not.toHaveBeenCalled();
   });
+
+  it("should use dev optimizations when watch mode is enabled", async () => {
+    await buildTypes({
+      ...config,
+      dev: { watch: true, logger: undefined, sys: undefined },
+    } as unknown as ResolvedEmbeddableConfig);
+
+    expect(build).toHaveBeenCalledWith({
+      build: {
+        emptyOutDir: false,
+        sourcemap: false,
+        minify: false,
+        rollupOptions: { treeshake: false },
+        lib: {
+          entry: "resolvedPath",
+          fileName: "embeddable-types",
+          formats: ["es"],
+        },
+        outDir: "build",
+      },
+      logLevel: "error",
+    });
+  });
+
+  it("should rename the built file with hash when not in watch mode", async () => {
+    // Reset the mock to control it better
+    vi.mocked(path.resolve).mockReset();
+    
+    // Mock the calls in order they happen
+    vi.mocked(path.resolve)
+      .mockReturnValueOnce("resolvedPath") // typesFilePath in build()
+      .mockReturnValueOnce("resolvedPath") // typesFilePath for readFile
+      .mockReturnValueOnce("build/embeddable-types.js") // source file for rename
+      .mockReturnValueOnce("build/embeddable-types-somehash.js"); // target file for rename
+
+    await buildTypes(config as unknown as ResolvedEmbeddableConfig);
+
+    expect(fs.rename).toHaveBeenCalledWith(
+      "build/embeddable-types.js",
+      "build/embeddable-types-somehash.js"
+    );
+  });
+
   it("should import types from installed libraries if present", async () => {
     const configWithLibrary = {
       ...config,

package/src/buildTypes.ts

@@ -66,6 +66,9 @@ async function build(ctx: ResolvedEmbeddableConfig) {
     logLevel: "error",
     build: {
       emptyOutDir: false,
+      sourcemap: ctx.dev?.watch ? (false as const) : true, // No sourcemaps for types in dev
+      minify: !ctx.dev?.watch, // No minification in dev
+      rollupOptions: ctx.dev?.watch ? { treeshake: false } : undefined,
       lib: {
         entry: typesFilePath,
         formats: ["es"],

package/src/defineConfig.test.ts

@@ -55,9 +55,9 @@ describe("defineConfig", () => {
           "bundleHash": undefined,
           "componentDir": "/embeddable-sdk/packages/core-sdk",
           "componentLibraries": [],
+          "customCanvasCss": "/embeddable-sdk/packages/core-sdk",
           "customizationFile": "/embeddable-sdk/packages/core-sdk",
           "errorFallbackComponent": "/embeddable-sdk/packages/core-sdk",
-          "globalCss": "/embeddable-sdk/packages/core-sdk",
           "lifecycleHooksFile": "/embeddable-sdk/packages/core-sdk",
           "modelsSrc": "/embeddable-sdk/packages/core-sdk",
           "presetsSrc": "/embeddable-sdk/packages/core-sdk",

package/src/defineConfig.ts

@@ -30,7 +30,7 @@ export type EmbeddableConfig = {
   componentsSrc?: string;
   modelsSrc?: string;
   presetsSrc?: string;
-  globalCss?: string;
+  customCanvasCss?: string;
   viteConfig?: {
     resolve?: {
       alias?: Record<string, string>;
@@ -59,7 +59,7 @@ export type ResolvedEmbeddableConfig = {
     presetsSrc: string;
     buildDir: string;
     tmpDir: string;
-    globalCss: string;
+    customCanvasCss: string;
     componentDir: string;
     stencilBuild: string;
     archiveFile: string;
@@ -155,7 +155,7 @@ export const embeddableConfigSchema = z
     modelsSrc: z.string().optional(),
     presetsSrc: z.string().optional(),
     componentsSrc: z.string().optional(),
-    globalCss: z.string().optional(),
+    customCanvasCss: z.string().optional(),
     customizationFile: z.string().optional(),
     lifecycleHooksFile: z.string().optional(),
     componentLibraries: z
@@ -204,7 +204,7 @@ export default (config: EmbeddableConfig) => {
     modelsSrc = "src",
     presetsSrc = "src",
     componentsSrc = "src",
-    globalCss = "src/global.css",
+    customCanvasCss = "src/custom-canvas.css",
     viteConfig = {},
     rollupOptions = {},
     componentLibraries = [],
@@ -257,7 +257,7 @@ export default (config: EmbeddableConfig) => {
       presetsSrc: presetsSrc ? path.resolve(clientRoot, presetsSrc) : undefined,
       buildDir: path.resolve(clientRoot, ".embeddable-build"),
       tmpDir: path.resolve(clientRoot, ".embeddable-tmp"),
-      globalCss: path.resolve(clientRoot, globalCss),
+      customCanvasCss: path.resolve(clientRoot, customCanvasCss),
       componentDir: path.resolve(clientRoot, ".embeddable-build", "component"),
       stencilBuild: path.resolve(
         clientRoot,