@embeddable.com/sdk-core 3.14.2-next.0 → 3.14.2-next.2

package/lib/push.d.ts

@@ -12,13 +12,15 @@ export declare function archive(args: {
     isDev: boolean;
 }): Promise<void>;
 export declare function createFormData(filePath: string, metadata: Record<string, any>): Promise<import("formdata-node").FormData>;
-export declare function sendBuildByApiKey(ctx: ResolvedEmbeddableConfig, { apiKey, email, message, }: {
+export declare function sendBuildByApiKey(ctx: ResolvedEmbeddableConfig, { apiKey, email, message, cubeVersion, }: {
     apiKey: string;
     email: string;
     message?: string;
+    cubeVersion?: string;
 }): Promise<any>;
-export declare function sendBuild(ctx: ResolvedEmbeddableConfig, { workspaceId, token, message, }: {
+export declare function sendBuild(ctx: ResolvedEmbeddableConfig, { workspaceId, token, message, cubeVersion, }: {
     workspaceId: string;
     token: string;
     message?: string;
+    cubeVersion?: string;
 }): Promise<void>;

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@embeddable.com/sdk-core",
-  "version": "3.14.2-next.0",
+  "version": "3.14.2-next.2",
   "description": "Core Embeddable SDK module responsible for web-components bundling and publishing.",
   "keywords": [
     "embeddable",
@@ -40,7 +40,7 @@
   },
   "license": "MIT",
   "dependencies": {
-    "@embeddable.com/core": "2.10.1",
+    "@embeddable.com/core": "2.10.2-next.0",
     "@embeddable.com/sdk-utils": "0.8.0",
     "@inquirer/prompts": "^7.2.1",
     "@stencil/core": "^4.23.0",

package/src/buildGlobalHooks.int.test.ts

@@ -15,6 +15,7 @@ import path from "node:path";
 
 const rootDir = path.resolve("fake", "root");
 const buildDir = path.resolve("fake", "build");
+const tmpDir = path.resolve("fake", "tmp");
 const srcDir = path.resolve("fake", "src");
 const lifecycleFile = path.resolve("fake", "root", "embeddable.lifecycle.ts");
 const themFile = path.resolve("fake", "root", "embeddable.theme.ts");
@@ -91,6 +92,7 @@ describe("buildGlobalHooks (Integration Tests)", () => {
       client: {
         srcDir,
         buildDir,
+        tmpDir,
         rootDir,
         lifecycleHooksFile: lifecycleFile,
         customizationFile: themFile,
@@ -188,6 +190,7 @@ describe("buildGlobalHooks (Integration Tests)", () => {
       client: {
         srcDir,
         buildDir,
+        tmpDir,
         rootDir,
         lifecycleHooksFile: lifecycleFile,
         customizationFile: themFile,

package/src/buildGlobalHooks.ts

@@ -23,6 +23,7 @@ export default async (ctx: ResolvedEmbeddableConfig) => {
   const progress = watch ? undefined : ora("Building global hooks...").start();
 
   try {
+    await fs.mkdir(ctx.client.tmpDir, { recursive: true });
     const { fileName: themeProvider, watcher: themeWatcher } =
       await buildThemeHook(ctx);
     const { lifecycleHooks, watcher: lifecycleWatcher } =
@@ -232,7 +233,7 @@ async function cleanupTemporaryHookFile(ctx: ResolvedEmbeddableConfig) {
  * Get the path to the temporary hook file in the build directory.
  */
 function getTempHookFilePath(ctx: ResolvedEmbeddableConfig): string {
-  return path.resolve(ctx.client.buildDir, TEMP_JS_HOOK_FILE);
+  return path.resolve(ctx.client.tmpDir, TEMP_JS_HOOK_FILE);
 }
 
 function waitForInitialBuild(watcher: RollupWatcher): Promise<void> {

package/src/buildGlobalHooks.unit.test.ts

@@ -70,6 +70,7 @@ describe("buildGlobalHooks (Unit Tests)", () => {
       client: {
         srcDir: path.resolve(process.cwd(), "fake", "src"),
         buildDir: path.resolve(process.cwd(), "fake", "build"),
+        tmpDir: path.resolve(process.cwd(), "fake", "tmp"),
         rootDir: path.resolve(process.cwd(), "fake", "root"),
         lifecycleHooksFile: lifecyclePath,
         componentLibraries: [],
@@ -113,6 +114,7 @@ describe("buildGlobalHooks (Unit Tests)", () => {
       client: {
         srcDir: path.resolve(process.cwd(), "fake", "src"),
         buildDir: path.resolve(process.cwd(), "fake", "build"),
+        tmpDir: path.resolve(process.cwd(), "fake", "tmp"),
         rootDir: path.resolve(process.cwd(), "fake", "root"),
         lifecycleHooksFile: lifecyclePath,
         customizationFile: themePath,
@@ -190,6 +192,7 @@ describe("buildGlobalHooks (Unit Tests)", () => {
       client: {
         srcDir: path.resolve(process.cwd(), "fake", "src"),
         buildDir: path.resolve(process.cwd(), "fake", "build"),
+        tmpDir: path.resolve(process.cwd(), "fake", "tmp"),
         rootDir: path.resolve(process.cwd(), "fake", "root"),
         lifecycleHooksFile: lifecyclePath,
         customizationFile: themePath,
@@ -242,6 +245,7 @@ describe("buildGlobalHooks (Unit Tests)", () => {
       client: {
         srcDir: path.resolve(process.cwd(), "fake", "src"),
         buildDir: path.resolve(process.cwd(), "fake", "build"),
+        tmpDir: path.resolve(process.cwd(), "fake", "tmp"),
         rootDir: path.resolve(process.cwd(), "fake", "root"),
         lifecycleHooksFile: lifecyclePath,
         customizationFile: themePath,

package/src/cleanup.ts

@@ -75,6 +75,11 @@ export async function createManifest({
 }
 
 async function extractBuild(ctx: ResolvedEmbeddableConfig) {
+  // Ensure tmpDir is removed before attempting to rename a directory to it.
+  // This helps prevent EPERM errors on Windows if tmpDir already exists and is non-empty
+  // from a previous failed run or other reasons.
+  await fs.rm(ctx.client.tmpDir, { recursive: true, force: true });
+
   const stencilBuildFiles = await findFiles(
     ctx.client.stencilBuild,
     /embeddable-wrapper.esm-[a-z0-9]+\.js/,

package/src/push.test.ts

@@ -320,13 +320,20 @@ describe("push", () => {
             "valid@email.com",
             "--message",
             "test message",
+            "--cube-version",
+            "v1.34",
           ],
         },
       });
       vi.mocked(getArgumentByKey)
-        .mockReturnValueOnce("some-key") // API key
-        .mockReturnValueOnce("valid@email.com") // Email
-        .mockReturnValueOnce("test message"); // Message
+        .mockImplementation((keysArg) => {
+          const key = Array.isArray(keysArg) ? keysArg[0] : keysArg;
+          if (key === '--api-key') return 'some-key';
+          if (key === '--email') return 'valid@email.com';
+          if (key === '--message') return 'test message';
+          if (key === '--cube-version') return 'v1.34';
+          return undefined;
+        });
 
       await push();
 

package/src/push.ts

@@ -32,6 +32,7 @@ export default async () => {
     breadcrumbs.push("checkNodeVersion");
     const isBuildSuccess = await checkBuildSuccess();
     const config = await provideConfig();
+    const cubeVersion = getArgumentByKey(["--cube-version"]);
 
     if (!isBuildSuccess && config.pushComponents) {
       console.error(
@@ -44,7 +45,7 @@ export default async () => {
       spinnerPushing = ora("Using API key...").start();
       breadcrumbs.push("push by api key");
       try {
-        await pushByApiKey(config, spinnerPushing);
+        await pushByApiKey(config, spinnerPushing, cubeVersion);
       } catch (error: any) {
         if (error.response?.data?.errorCode === "BUILDER-998") {
           spinnerPushing.fail(
@@ -88,7 +89,7 @@ Read more about deployment regions at https://docs.embeddable.com/deployment/dep
     );
 
     breadcrumbs.push("send build");
-    await sendBuild(config, { workspaceId, token, message });
+    await sendBuild(config, { workspaceId, token, message, cubeVersion });
 
     publishedSectionFeedback(config, spinnerPushing);
     spinnerPushing.succeed(
@@ -111,7 +112,7 @@ const publishedSectionFeedback = (
   config.pushComponents && spinnerPushing.succeed("Components published");
 };
 
-async function pushByApiKey(config: ResolvedEmbeddableConfig, spinner: any) {
+async function pushByApiKey(config: ResolvedEmbeddableConfig, spinner: any, cubeVersion?: string) {
   const apiKey = getArgumentByKey(["--api-key", "-k"]);
 
   if (!apiKey) {
@@ -137,6 +138,7 @@ async function pushByApiKey(config: ResolvedEmbeddableConfig, spinner: any) {
     apiKey,
     email,
     message,
+    cubeVersion,
   });
 }
 
@@ -277,13 +279,15 @@ export async function sendBuildByApiKey(
     apiKey,
     email,
     message,
-  }: { apiKey: string; email: string; message?: string },
+    cubeVersion,
+  }: { apiKey: string; email: string; message?: string; cubeVersion?: string },
 ) {
   const form = await createFormData(ctx.client.archiveFile, {
     pushModels: ctx.pushModels,
     pushComponents: ctx.pushComponents,
     authorEmail: email,
     description: message,
+    ...(cubeVersion ? { cubeVersion } : {}),
   });
 
   const response = await uploadFile(
@@ -293,7 +297,7 @@ export async function sendBuildByApiKey(
   );
   await fs.rm(ctx.client.archiveFile);
 
-  return { ...response.data, message };
+  return { ...response.data, message, cubeVersion };
 }
 
 export async function sendBuild(
@@ -302,13 +306,15 @@ export async function sendBuild(
     workspaceId,
     token,
     message,
-  }: { workspaceId: string; token: string; message?: string },
+    cubeVersion,
+  }: { workspaceId: string; token: string; message?: string; cubeVersion?: string },
 ) {
   const form = await createFormData(ctx.client.archiveFile, {
     pushModels: ctx.pushModels,
     pushComponents: ctx.pushComponents,
     authorEmail: "",
     description: message,
+    ...(cubeVersion ? { cubeVersion } : {}),
   });
 
   await uploadFile(

package/src/validate.ts

@@ -1,6 +1,7 @@
 import * as fs from "node:fs/promises";
 import * as YAML from "yaml";
 import { errorFormatter, findFiles } from "@embeddable.com/sdk-utils";
+import { DIMENSION_TYPES, MEASURE_TYPES } from "@embeddable.com/core";
 import { z } from "zod";
 import ora from "ora";
 import { checkNodeVersion } from "./utils";
@@ -170,28 +171,6 @@ export async function clientContextValidation(filesList: [string, string][]) {
   return errors;
 }
 
-enum MeasureTypeEnum {
-  string = "string",
-  time = "time",
-  boolean = "boolean",
-  number = "number",
-  count = "count",
-  count_distinct = "count_distinct",
-  count_distinct_approx = "count_distinct_approx",
-  sum = "sum",
-  avg = "avg",
-  min = "min",
-  max = "max",
-}
-
-enum DimensionTypeEnum {
-  string = "string",
-  time = "time",
-  boolean = "boolean",
-  number = "number",
-  geo = "geo",
-}
-
 const cubeModelSchema = z
   .object({
     cubes: z
@@ -200,14 +179,14 @@ const cubeModelSchema = z
         dimensions: z
           .object({
             name: z.string(),
-            type: z.nativeEnum(DimensionTypeEnum),
+            type: z.enum(DIMENSION_TYPES),
           })
           .array()
           .optional(),
         measures: z
           .object({
             name: z.string(),
-            type: z.nativeEnum(MeasureTypeEnum),
+            type: z.enum(MEASURE_TYPES),
           })
           .array()
           .optional(),