@embeddable.com/sdk-core 3.13.1 → 3.13.2

package/lib/utils.d.ts

@@ -20,5 +20,5 @@ export declare const removeBuildSuccessFlag: () => Promise<void>;
  * Check if the build was successful
  */
 export declare const checkBuildSuccess: () => Promise<boolean>;
-export declare const getSDKVersions: () => Record<string, string>;
+export declare const getSDKVersions: () => Promise<Record<string, string>>;
 export declare const hrtimeToISO8601: (hrtime: number[] | null | undefined) => String;

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@embeddable.com/sdk-core",
-  "version": "3.13.1",
+  "version": "3.13.2",
   "description": "Core Embeddable SDK module responsible for web-components bundling and publishing.",
   "keywords": [
     "embeddable",

package/src/cleanup.ts

@@ -26,7 +26,7 @@ export async function createManifest({
   editorsMetaFileName,
   stencilWrapperFileName,
 }: ManifestArgs) {
-  const sdkVersions = getSDKVersions();
+  const sdkVersions = await getSDKVersions();
   // identify user's package manager and its version
   let packageManager = "npm";
   if (process.env.npm_config_user_agent?.includes("yarn")) {

package/src/defineConfig.test.ts

@@ -35,7 +35,7 @@ describe("defineConfig", () => {
     vi.mocked(path.resolve).mockReturnValue(coreRoot);
 
     vi.spyOn(process, "cwd").mockReturnValue(
-      "/embeddable-sdk/packages/core-sdk"
+      "/embeddable-sdk/packages/core-sdk",
     );
   });
 
@@ -84,17 +84,17 @@ describe("defineConfig", () => {
 
   it("throws error for invalid property", () => {
     expect(() =>
-      defineConfig({ plugins: [], invalidProp: "INVALID" as any } as any)
+      defineConfig({ plugins: [], invalidProp: "INVALID" as any } as any),
     ).toThrow(
-      `Invalid Embeddable Configuration: "": Unrecognized key(s) in object: 'invalidProp'}`
+      `Invalid Embeddable Configuration: "": Unrecognized key(s) in object: 'invalidProp'}`,
     );
   });
 
   it("throws error for invalid property value", () => {
     expect(() =>
-      defineConfig({ plugins: [], pushBaseUrl: 123 as any } as any)
+      defineConfig({ plugins: [], pushBaseUrl: 123 as any } as any),
     ).toThrow(
-      `Invalid Embeddable Configuration: "pushBaseUrl": Expected string, received number}`
+      `Invalid Embeddable Configuration: "pushBaseUrl": Expected string, received number}`,
     );
   });
 
@@ -147,9 +147,9 @@ describe("defineConfig", () => {
 
     it("throws error for invalid region", () => {
       expect(() =>
-        defineConfig({ plugins: [], region: "INVALID" as any })
+        defineConfig({ plugins: [], region: "INVALID" as any }),
       ).toThrow(
-        `Invalid Embeddable Configuration: "region": Invalid literal value, expected "legacy-US"}`
+        `Invalid Embeddable Configuration: "region": Invalid literal value, expected "legacy-US"}`,
       );
     });
   });

package/src/utils.ts

@@ -98,22 +98,24 @@ export const checkBuildSuccess = async () => {
   }
 };
 
-const getPackageVersion = (packageName: string) => {
+const getPackageVersion = async (packageName: string) => {
   const packageJsonPath = path.join(
     process.cwd(),
     "node_modules",
     packageName,
     "package.json",
   );
+
+  let packageJson;
   try {
-    const packageJson = require(packageJsonPath);
+    packageJson = JSON.parse(await fs.readFile(packageJsonPath, "utf-8"));
     return packageJson.version;
   } catch (e) {
     return undefined;
   }
 };
 
-export const getSDKVersions = () => {
+export const getSDKVersions = async () => {
   const packageNames = [
     "@embeddable.com/core",
     "@embeddable.com/react",
@@ -122,15 +124,18 @@ export const getSDKVersions = () => {
     "@embeddable.com/sdk-utils",
   ];
 
-  const sdkVersions = packageNames.reduce<Record<string, string>>(
-    (acc, packageName) => {
-      const version = getPackageVersion(packageName);
+  const sdkVersions = await packageNames.reduce<
+    Promise<Record<string, string>>
+  >(
+    async (accPromise, packageName) => {
+      const acc = await accPromise; // Wait for the previous accumulator to resolve
+      const version = await getPackageVersion(packageName);
       if (version) {
         acc[packageName] = version;
       }
       return acc;
     },
-    {},
+    Promise.resolve({}), // Start with a resolved promise containing an empty object
   );
 
   return sdkVersions;