@emartech/aggregate-metric-logger 4.0.0 → 5.0.0

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@emartech/aggregate-metric-logger",
-  "version": "4.0.0",
+  "version": "5.0.0",
   "description": "aggregate metrics in memory for logging",
   "main": "src/index.js",
   "scripts": {
@@ -30,20 +30,20 @@
   },
   "dependencies": {
     "@emartech/json-logger": "^8.0.2",
-    "@google-cloud/monitoring": "^3.0.2",
-    "date-fns": "^2.3.0",
+    "@google-cloud/monitoring": "^4.0.0",
+    "date-fns": "2.30.0",
     "json-stable-stringify": "^1.0.1",
     "lodash": "^4.17.15",
     "ms": "^2.1.3"
   },
   "devDependencies": {
-    "@sinonjs/fake-timers": "^10.0.0",
-    "@types/jest": "^29.2.3",
+    "@sinonjs/fake-timers": "11.1.0",
+    "@types/jest": "29.5.5",
     "dotenv-haphap": "^3.1.2",
-    "eslint": "^8.12.0",
+    "eslint": "8.50.0",
     "eslint-config-emarsys": "^5.1.0",
-    "eslint-plugin-jest": "^27.1.5",
-    "jest": "^29.2.2",
+    "eslint-plugin-jest": "27.4.2",
+    "jest": "29.7.0",
     "semantic-release": "^19.0.2"
   }
 }

package/src/gcp-metric-collector/gcp-metric-collector.js

@@ -5,13 +5,23 @@ const { publishTimeSeries } = require('../gcp-time-series-publisher/gcp-time-ser
 const { buildTimeSeries } = require('../gcp-time-series-builder/gcp-time-series-builder');
 const { createCounter } = require('../metric-types/counter/counter');
 const { createDistribution } = require('../metric-types/distribution/distribution');
+const { isNumber, isPlainObject } = require('lodash');
 
 let metrics = {};
 let initialized = false;
 let timeoutId = null;
 
-exports.count = (metricName, labels = {}, value = 1) =>
+exports.count = (metricName, labels = {}, value = 1) => {
+  if (!isNumber(value)) {
+    throw new Error(`${ value } is not a number`);
+  }
+
+  if (!isPlainObject(labels)) {
+    throw new Error('labels is not a plain object');
+  }
+
   addToMetric(metricName, labels, 'counter', value);
+};
 
 exports.measure = (metricName, labels = {}, value = 1) =>
   addToMetric(metricName, labels, 'distribution', value);

package/src/gcp-metric-collector/gcp-metric-collector.spec.js

@@ -98,6 +98,22 @@ describe('gcpMetricCollector', () => {
 
       expect(getPublishedMetrics()).toEqual([]);
     });
+
+    it('should validate labels parameter whether it is an object', async () => {
+      process.env.METRIC_LOGGER_ENABLED = 'false';
+
+      expect(() => {
+        gcpMetricCollector.count('irrelevant', new Error('not a plain object'), 88);
+      }).toThrow(new Error('labels is not a plain object'));
+    });
+
+    it('should validate value parameter whether it is a number', async () => {
+      process.env.METRIC_LOGGER_ENABLED = 'false';
+
+      expect(() => {
+        gcpMetricCollector.count('irrelevant', {}, '88');
+      }).toThrow(new Error('88 is not a number'));
+    });
   });
 
   describe('measure', () => {