@emartech/aggregate-metric-logger 3.0.0 → 3.0.1

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@emartech/aggregate-metric-logger",
-  "version": "3.0.0",
+  "version": "3.0.1",
   "description": "aggregate metrics in memory for logging",
   "main": "src/index.js",
   "scripts": {

package/src/gcp-time-series-publisher/gcp-time-series-publisher.js

@@ -2,14 +2,20 @@
 
 const logger = require('@emartech/json-logger')('aggregate-metric-logger');
 const monitoring = require('@google-cloud/monitoring');
+const { chunk } = require('lodash');
+
+const MAX_TIME_SERIES_COUNT = 200;
 
 exports.publishTimeSeries = async timeSeries => {
   try {
     const client = getMonitoringClient();
-    await client.createTimeSeries({
-      name: client.projectPath(process.env.MONITORING_PROJECT_ID),
-      timeSeries
-    });
+
+    for (const timeSeriesChunk of chunk(timeSeries, MAX_TIME_SERIES_COUNT)) {
+      await client.createTimeSeries({
+        name: client.projectPath(process.env.MONITORING_PROJECT_ID),
+        timeSeries: timeSeriesChunk
+      });
+    }
   } catch (error) {
     logger.warnFromError('pushing-metrics-failed', error, { do_not_alert: true });
   }

package/src/gcp-time-series-publisher/gcp-time-series-publisher.spec.js

@@ -1,6 +1,7 @@
 'use strict';
 
 const { MetricServiceClient } = require('@google-cloud/monitoring');
+const { range } = require('lodash');
 const { publishTimeSeries } = require('./gcp-time-series-publisher');
 const { stubCreateTimeSeries } = require('../../test-helpers/test-helpers');
 
@@ -8,7 +9,7 @@ jest.mock('@google-cloud/monitoring');
 
 describe('gcpMetricPublisher', () => {
   describe('publishTimeSeries', () => {
-    it('should push a metrics to gcp in the correct format', async () => {
+    it('should push metrics to gcp to the correct project', async () => {
       stubCreateTimeSeries();
       process.env.HOSTNAME = 'test-host';
       process.env.MONITORING_PROJECT_ID = 'test-project';
@@ -21,5 +22,23 @@ describe('gcpMetricPublisher', () => {
         timeSeries
       });
     });
+
+    it('should push metrics to gcp in batches', async () => {
+      stubCreateTimeSeries();
+      process.env.HOSTNAME = 'test-host';
+      process.env.MONITORING_PROJECT_ID = 'test-project';
+
+      await publishTimeSeries(range(1, 300));
+
+      expect(MetricServiceClient.prototype.createTimeSeries).toHaveBeenCalledWith({
+        name: 'projects/test-project',
+        timeSeries: range(1, 201)
+      });
+      expect(MetricServiceClient.prototype.createTimeSeries).toHaveBeenCalledWith({
+        name: 'projects/test-project',
+        timeSeries: range(201, 300)
+      });
+    });
+
   });
 });