@elyra/canvas 13.44.0 → 13.45.1

package/src/common-properties/controls/textfield/textfield.jsx

@@ -97,6 +97,12 @@ class TextfieldControl extends React.Component {
 			</div>);
 		} else {
 			const validationProps = ControlUtils.getValidationProps(this.props.messageInfo, this.props.tableControl);
+			// Determine if counter should be shown
+			// Show counter only if NOT in a table AND (showCharacterCounter is true OR limit is reached)
+			const showCharacterCounter = this.props.controller.getShowCharacterCounter();
+			const isAtLimit = this.charLimit !== -1 && value.length >= this.charLimit;
+			const shouldShowCounter = !this.props.tableControl && this.charLimit !== -1 && (showCharacterCounter || isAtLimit);
+
 			textInput = (
 				<TextInput
 					{...validationProps}
@@ -113,7 +119,7 @@ class TextfieldControl extends React.Component {
 					aria-label={this.props.control.labelVisible ? null : this.props.control?.label?.text}
 					ref={this.textInputRef}
 					readOnly={this.props.readOnly}
-					enableCounter={this.charLimit !== -1}
+					enableCounter={shouldShowCounter}
 					maxCount={this.charLimit}
 				/>
 			);

package/src/common-properties/properties-controller.js

@@ -1931,6 +1931,18 @@ export default class PropertiesController {
 		return maxLengthForSingleLineControls;
 	}
 
+	/**
+	* Returns whether to show the character counter for textfield and textarea controls
+	* Default value is true
+	* When false, counter is hidden until character limit is reached
+	*/
+	getShowCharacterCounter() {
+		const showCharacterCounter = (typeof this.getPropertiesConfig().showCharacterCounter !== "undefined")
+			? this.getPropertiesConfig().showCharacterCounter
+			: true;
+		return showCharacterCounter;
+	}
+
 	/**
 	* Set the initial values of addRemoveRows for all structure controls
 	*/

package/src/common-properties/properties-main/properties-main.jsx

@@ -696,6 +696,7 @@ PropertiesMain.propTypes = {
 		conditionDisabledPropertyHandling: PropTypes.oneOf(["null", "undefined", "value"]),
 		maxLengthForMultiLineControls: PropTypes.number,
 		maxLengthForSingleLineControls: PropTypes.number,
+		showCharacterCounter: PropTypes.bool,
 		convertValueDataTypes: PropTypes.bool,
 		showRequiredIndicator: PropTypes.bool,
 		showAlertsTab: PropTypes.bool,

package/src/toolbar/toolbar-sub-menu.jsx

@@ -53,7 +53,7 @@ class ToolbarSubMenu extends React.Component {
 
 	componentDidUpdate() {
 		if (this.state.focusAction !== "subarea") {
-			const actionObj = this.props.subMenuActions?.find((sma) => sma.action === this.state.focusAction);
+			const actionObj = this.props.subMenuActions?.find((sma) => sma?.action === this.state.focusAction);
 			if (!actionObj?.enable) {
 				const actionToSet = this.getClosestEnabledAction(this.state.focusAction);
 				if (actionToSet !== null) {

package/src/toolbar/toolbar.jsx

@@ -668,7 +668,10 @@ class Toolbar extends React.Component {
 }
 
 Toolbar.propTypes = {
-	config: PropTypes.object.isRequired,
+	config: PropTypes.shape({
+		leftBar: PropTypes.arrayOf(PropTypes.object.isRequired).isRequired,
+		rightBar: PropTypes.arrayOf(PropTypes.object.isRequired)
+	}).isRequired,
 	instanceId: PropTypes.number.isRequired,
 	containingDivId: PropTypes.string,
 	toolbarActionHandler: PropTypes.func,