@elvis1513/auto-coding-skill 4.3.7 → 5.0.0
This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
- package/README.md +26 -761
- package/cli/assets/managed-install.json +38 -1
- package/cli/assets/skill/SKILL.md +15 -100
- package/cli/assets/skill/data/templates/ENVIRONMENT.md +30 -0
- package/cli/assets/skill/data/templates/architecture/.gitkeep +1 -0
- package/cli/assets/skill/data/templates/bridges/AGENTS.md +39 -145
- package/cli/assets/skill/data/templates/deployment/.gitkeep +1 -0
- package/cli/assets/skill/data/templates/design/.gitkeep +1 -0
- package/cli/assets/skill/data/templates/interfaces/.gitkeep +1 -0
- package/cli/assets/skill/data/templates/product/.gitkeep +1 -0
- package/cli/src/index.js +127 -2589
- package/cli/src/sync-assets.js +38 -95
- package/package.json +9 -17
- package/cli/assets/agents/browser-debugger.toml +0 -27
- package/cli/assets/agents/docs-researcher.toml +0 -18
- package/cli/assets/agents/explorer.toml +0 -26
- package/cli/assets/agents/fixer.toml +0 -29
- package/cli/assets/agents/reviewer.toml +0 -50
- package/cli/assets/skill/data/contracts/orchestration-v1.schema.json +0 -567
- package/cli/assets/skill/data/policies/feedback-resolutions-v1.json +0 -68
- package/cli/assets/skill/data/policies/workflow-migrations-v1.json +0 -657
- package/cli/assets/skill/data/templates/ENGINEERING.md +0 -115
- package/cli/assets/skill/data/templates/tools/ap.py +0 -16
- package/cli/assets/skill/requirements.txt +0 -1
- package/cli/assets/skill/scripts/ap.py +0 -17791
- package/cli/assets/skill/scripts/core.py +0 -510
- package/cli/assets/skill/scripts/http_checks.py +0 -92
- package/cli/assets/skill/scripts/install_integrity.py +0 -427
- package/cli/assets/skill/scripts/scaffold_templates.py +0 -325
- package/cli/tests/ap_concurrency_test.py +0 -3602
- package/cli/tests/ap_profiles_test.py +0 -3272
- package/cli/tests/core_shell_test.py +0 -345
- package/cli/tests/index.test.js +0 -2967
|
@@ -1,345 +0,0 @@
|
|
|
1
|
-
#!/usr/bin/env python3
|
|
2
|
-
from __future__ import annotations
|
|
3
|
-
|
|
4
|
-
import os
|
|
5
|
-
import signal
|
|
6
|
-
import subprocess
|
|
7
|
-
import sys
|
|
8
|
-
import tempfile
|
|
9
|
-
import unittest
|
|
10
|
-
from pathlib import Path
|
|
11
|
-
from unittest import mock
|
|
12
|
-
|
|
13
|
-
|
|
14
|
-
REPO_ROOT = Path(__file__).resolve().parents[2]
|
|
15
|
-
SCRIPT_DIR = REPO_ROOT / "src" / "auto-coding-skill" / "scripts"
|
|
16
|
-
sys.path.insert(0, str(SCRIPT_DIR))
|
|
17
|
-
|
|
18
|
-
import core # noqa: E402
|
|
19
|
-
|
|
20
|
-
|
|
21
|
-
class RunShellTests(unittest.TestCase):
|
|
22
|
-
def test_run_shell_uses_non_login_bash_and_inherits_environment(self) -> None:
|
|
23
|
-
process = mock.Mock()
|
|
24
|
-
process.wait.return_value = 0
|
|
25
|
-
cwd = Path("/tmp/run-shell-test")
|
|
26
|
-
with mock.patch.object(core.subprocess, "Popen", return_value=process) as popen:
|
|
27
|
-
core.run_shell("sentinel", cwd=cwd)
|
|
28
|
-
|
|
29
|
-
popen.assert_called_once_with(
|
|
30
|
-
["bash", "-c", "sentinel"],
|
|
31
|
-
cwd=str(cwd),
|
|
32
|
-
text=True,
|
|
33
|
-
start_new_session=True,
|
|
34
|
-
)
|
|
35
|
-
|
|
36
|
-
def test_run_shell_preserves_caller_path(self) -> None:
|
|
37
|
-
with tempfile.TemporaryDirectory(prefix="autocoding-shell-") as temp_name:
|
|
38
|
-
root = Path(temp_name)
|
|
39
|
-
bin_dir = root / "bin"
|
|
40
|
-
bin_dir.mkdir()
|
|
41
|
-
sentinel = bin_dir / "path-sentinel"
|
|
42
|
-
sentinel.write_text("#!/bin/sh\nprintf inherited > \"$1\"\n", encoding="utf-8")
|
|
43
|
-
sentinel.chmod(0o755)
|
|
44
|
-
result = root / "result.txt"
|
|
45
|
-
profile_marker = root / "login-profile-ran"
|
|
46
|
-
(root / ".bash_profile").write_text(
|
|
47
|
-
f"export PATH=/usr/bin:/bin\n/usr/bin/touch '{profile_marker}'\n",
|
|
48
|
-
encoding="utf-8",
|
|
49
|
-
)
|
|
50
|
-
inherited_path = f"{bin_dir}{os.pathsep}{os.environ.get('PATH', '')}"
|
|
51
|
-
with mock.patch.dict(
|
|
52
|
-
os.environ,
|
|
53
|
-
{"HOME": str(root), "PATH": inherited_path},
|
|
54
|
-
clear=False,
|
|
55
|
-
):
|
|
56
|
-
core.run_shell(f"path-sentinel '{result}'", cwd=root, timeout_s=5)
|
|
57
|
-
|
|
58
|
-
self.assertEqual("inherited", result.read_text(encoding="utf-8"))
|
|
59
|
-
self.assertFalse(profile_marker.exists())
|
|
60
|
-
|
|
61
|
-
def test_run_shell_timeout_terminates_then_kills_process_group(self) -> None:
|
|
62
|
-
process = mock.Mock(pid=4321)
|
|
63
|
-
process.wait.side_effect = [
|
|
64
|
-
subprocess.TimeoutExpired(cmd="slow", timeout=1),
|
|
65
|
-
subprocess.TimeoutExpired(cmd="slow", timeout=2),
|
|
66
|
-
0,
|
|
67
|
-
]
|
|
68
|
-
with (
|
|
69
|
-
mock.patch.object(core.subprocess, "Popen", return_value=process),
|
|
70
|
-
mock.patch.object(core.os, "killpg") as killpg,
|
|
71
|
-
):
|
|
72
|
-
with self.assertRaises(core.APError) as context:
|
|
73
|
-
core.run_shell("slow", timeout_s=1)
|
|
74
|
-
|
|
75
|
-
self.assertIn("timed out after 1.0s", str(context.exception))
|
|
76
|
-
self.assertEqual(
|
|
77
|
-
[mock.call(4321, signal.SIGTERM), mock.call(4321, signal.SIGKILL)],
|
|
78
|
-
killpg.call_args_list,
|
|
79
|
-
)
|
|
80
|
-
self.assertEqual(3, process.wait.call_count)
|
|
81
|
-
|
|
82
|
-
|
|
83
|
-
class ProjectConfigResolverTests(unittest.TestCase):
|
|
84
|
-
def setUp(self) -> None:
|
|
85
|
-
self.temporary = tempfile.TemporaryDirectory(prefix="autocoding-config-")
|
|
86
|
-
self.repo = Path(self.temporary.name)
|
|
87
|
-
(self.repo / "docs" / "project").mkdir(parents=True)
|
|
88
|
-
self.write_managed(
|
|
89
|
-
"""workflow:
|
|
90
|
-
skill_version: "4.3.7"
|
|
91
|
-
mode: dev
|
|
92
|
-
profile: auto
|
|
93
|
-
completion: push
|
|
94
|
-
project:
|
|
95
|
-
name: sample
|
|
96
|
-
commands:
|
|
97
|
-
project_fast: npm test
|
|
98
|
-
validation:
|
|
99
|
-
enabled: true
|
|
100
|
-
retries: 3
|
|
101
|
-
routes:
|
|
102
|
-
- paths: [src/**]
|
|
103
|
-
access:
|
|
104
|
-
project:
|
|
105
|
-
password: managed-secret
|
|
106
|
-
"""
|
|
107
|
-
)
|
|
108
|
-
|
|
109
|
-
def tearDown(self) -> None:
|
|
110
|
-
self.temporary.cleanup()
|
|
111
|
-
|
|
112
|
-
def write_managed(self, frontmatter: str, body: str = "# Managed\n") -> None:
|
|
113
|
-
(self.repo / core.MANAGED_CONFIG_RELATIVE_PATH).write_text(
|
|
114
|
-
f"---\n{frontmatter.rstrip()}\n---\n{body}",
|
|
115
|
-
encoding="utf-8",
|
|
116
|
-
)
|
|
117
|
-
|
|
118
|
-
def write_overlay(self, overrides: str, schema: str = core.PROJECT_CONFIG_SCHEMA) -> None:
|
|
119
|
-
(self.repo / core.PROJECT_CONFIG_OVERLAY_RELATIVE_PATH).write_text(
|
|
120
|
-
f"schema: {schema}\noverrides:\n{overrides}",
|
|
121
|
-
encoding="utf-8",
|
|
122
|
-
)
|
|
123
|
-
|
|
124
|
-
def assert_overlay_error(self, expected: str) -> None:
|
|
125
|
-
with self.assertRaises(core.APError) as context:
|
|
126
|
-
core.load_effective_config(self.repo)
|
|
127
|
-
self.assertIn(expected, str(context.exception))
|
|
128
|
-
|
|
129
|
-
def test_missing_overlay_keeps_managed_config_and_find_config_compatibility(self) -> None:
|
|
130
|
-
effective = core.load_effective_config(self.repo)
|
|
131
|
-
|
|
132
|
-
self.assertEqual("sample", effective["project"]["name"])
|
|
133
|
-
self.assertEqual("4.3.7", effective["workflow"]["skill_version"])
|
|
134
|
-
self.assertEqual(self.repo / "docs" / "ENGINEERING.md", core.find_config(self.repo))
|
|
135
|
-
self.assertEqual({}, core.load_project_overrides(self.repo))
|
|
136
|
-
|
|
137
|
-
def test_recursive_merge_treats_falsy_scalars_and_empty_lists_as_authoritative(self) -> None:
|
|
138
|
-
self.write_overlay(
|
|
139
|
-
""" workflow:
|
|
140
|
-
profile: project-profile
|
|
141
|
-
project:
|
|
142
|
-
name: project-owned
|
|
143
|
-
commands:
|
|
144
|
-
project_fast: ''
|
|
145
|
-
validation:
|
|
146
|
-
enabled: false
|
|
147
|
-
retries: 0
|
|
148
|
-
routes: []
|
|
149
|
-
added:
|
|
150
|
-
nested: value
|
|
151
|
-
"""
|
|
152
|
-
)
|
|
153
|
-
|
|
154
|
-
effective = core.load_effective_config(self.repo)
|
|
155
|
-
|
|
156
|
-
self.assertEqual("4.3.7", effective["workflow"]["skill_version"])
|
|
157
|
-
self.assertEqual("dev", effective["workflow"]["mode"])
|
|
158
|
-
self.assertEqual("project-profile", effective["workflow"]["profile"])
|
|
159
|
-
self.assertEqual("push", effective["workflow"]["completion"])
|
|
160
|
-
self.assertEqual("project-owned", effective["project"]["name"])
|
|
161
|
-
self.assertEqual("", effective["commands"]["project_fast"])
|
|
162
|
-
self.assertIs(effective["validation"]["enabled"], False)
|
|
163
|
-
self.assertEqual(0, effective["validation"]["retries"])
|
|
164
|
-
self.assertEqual([], effective["validation"]["routes"])
|
|
165
|
-
self.assertEqual({"nested": "value"}, effective["added"])
|
|
166
|
-
|
|
167
|
-
def test_overlay_payload_parser_matches_file_loader(self) -> None:
|
|
168
|
-
self.write_overlay(" project:\n name: project-owned\n validation:\n routes: []\n")
|
|
169
|
-
payload = (self.repo / core.PROJECT_CONFIG_OVERLAY_RELATIVE_PATH).read_bytes()
|
|
170
|
-
|
|
171
|
-
self.assertEqual(
|
|
172
|
-
core.load_project_overrides(self.repo),
|
|
173
|
-
core.parse_project_overrides_payload(payload),
|
|
174
|
-
)
|
|
175
|
-
|
|
176
|
-
def test_overlay_payload_parser_and_loader_both_reject_invalid_wrapper(self) -> None:
|
|
177
|
-
payload = (
|
|
178
|
-
f"schema: {core.PROJECT_CONFIG_SCHEMA}\n"
|
|
179
|
-
"overrides: {}\n"
|
|
180
|
-
"project: {}\n"
|
|
181
|
-
).encode("utf-8")
|
|
182
|
-
(self.repo / core.PROJECT_CONFIG_OVERLAY_RELATIVE_PATH).write_bytes(payload)
|
|
183
|
-
|
|
184
|
-
for label, load in (
|
|
185
|
-
("payload", lambda: core.parse_project_overrides_payload(payload)),
|
|
186
|
-
("file", lambda: core.load_project_overrides(self.repo)),
|
|
187
|
-
):
|
|
188
|
-
with self.subTest(source=label):
|
|
189
|
-
with self.assertRaisesRegex(core.APError, "unsupported top-level wrapper"):
|
|
190
|
-
load()
|
|
191
|
-
|
|
192
|
-
def test_merge_does_not_mutate_either_layer(self) -> None:
|
|
193
|
-
defaults = {"nested": {"managed": True}, "items": ["managed"]}
|
|
194
|
-
overrides = {"nested": {"project": True}, "items": []}
|
|
195
|
-
|
|
196
|
-
effective = core.merge_project_config(defaults, overrides)
|
|
197
|
-
effective["nested"]["managed"] = False
|
|
198
|
-
|
|
199
|
-
self.assertEqual({"nested": {"managed": True}, "items": ["managed"]}, defaults)
|
|
200
|
-
self.assertEqual({"nested": {"project": True}, "items": []}, overrides)
|
|
201
|
-
|
|
202
|
-
def test_rejects_null_values_in_both_layers(self) -> None:
|
|
203
|
-
self.write_overlay(" commands:\n project_fast:\n")
|
|
204
|
-
self.assert_overlay_error("must not contain null")
|
|
205
|
-
|
|
206
|
-
(self.repo / core.PROJECT_CONFIG_OVERLAY_RELATIVE_PATH).unlink()
|
|
207
|
-
self.write_managed("workflow:\n skill_version:\n")
|
|
208
|
-
self.assert_overlay_error("must not contain null")
|
|
209
|
-
|
|
210
|
-
def test_rejects_duplicate_keys_in_both_layers(self) -> None:
|
|
211
|
-
self.write_overlay(" project:\n name: one\n name: two\n")
|
|
212
|
-
self.assert_overlay_error("duplicate YAML keys")
|
|
213
|
-
|
|
214
|
-
(self.repo / core.PROJECT_CONFIG_OVERLAY_RELATIVE_PATH).unlink()
|
|
215
|
-
self.write_managed("project:\n name: one\n name: two\n")
|
|
216
|
-
self.assert_overlay_error("duplicate YAML keys")
|
|
217
|
-
|
|
218
|
-
def test_rejects_yaml_anchors_aliases_and_merge_keys(self) -> None:
|
|
219
|
-
self.write_overlay(" project: &project\n name: sample\n copy: *project\n")
|
|
220
|
-
self.assert_overlay_error("anchors or aliases")
|
|
221
|
-
|
|
222
|
-
self.write_overlay(" project:\n <<: {name: sample}\n")
|
|
223
|
-
self.assert_overlay_error("merge keys")
|
|
224
|
-
|
|
225
|
-
def test_rejects_unknown_wrapper_or_schema(self) -> None:
|
|
226
|
-
overlay = self.repo / core.PROJECT_CONFIG_OVERLAY_RELATIVE_PATH
|
|
227
|
-
overlay.write_text(
|
|
228
|
-
f"schema: {core.PROJECT_CONFIG_SCHEMA}\noverrides: {{}}\nproject: {{}}\n",
|
|
229
|
-
encoding="utf-8",
|
|
230
|
-
)
|
|
231
|
-
self.assert_overlay_error("unsupported top-level wrapper")
|
|
232
|
-
|
|
233
|
-
self.write_overlay(" project: {}\n", schema="unexpected/v1")
|
|
234
|
-
self.assert_overlay_error("schema is unsupported")
|
|
235
|
-
|
|
236
|
-
def test_rejects_managed_workflow_fields_and_whole_workflow_replacement(self) -> None:
|
|
237
|
-
for field, value in (
|
|
238
|
-
("skill_version", '"99.0.0"'),
|
|
239
|
-
("mode", "custom"),
|
|
240
|
-
("completion", "local-only"),
|
|
241
|
-
):
|
|
242
|
-
with self.subTest(field=field):
|
|
243
|
-
self.write_overlay(f" workflow:\n {field}: {value}\n")
|
|
244
|
-
self.assert_overlay_error("cannot override managed workflow fields")
|
|
245
|
-
|
|
246
|
-
self.write_overlay(" workflow: disabled\n")
|
|
247
|
-
self.assert_overlay_error("cannot override managed workflow fields")
|
|
248
|
-
|
|
249
|
-
@unittest.skipIf(os.name == "nt", "symlink setup is platform-dependent")
|
|
250
|
-
def test_rejects_overlay_file_and_parent_symlinks(self) -> None:
|
|
251
|
-
overlay = self.repo / core.PROJECT_CONFIG_OVERLAY_RELATIVE_PATH
|
|
252
|
-
outside = self.repo / "outside.yaml"
|
|
253
|
-
outside.write_text(
|
|
254
|
-
f"schema: {core.PROJECT_CONFIG_SCHEMA}\noverrides: {{}}\n",
|
|
255
|
-
encoding="utf-8",
|
|
256
|
-
)
|
|
257
|
-
overlay.symlink_to(outside)
|
|
258
|
-
self.assert_overlay_error("regular non-symlink file")
|
|
259
|
-
|
|
260
|
-
overlay.unlink()
|
|
261
|
-
project_dir = self.repo / "docs" / "project"
|
|
262
|
-
project_dir.rmdir()
|
|
263
|
-
outside_dir = self.repo / "outside-project"
|
|
264
|
-
outside_dir.mkdir()
|
|
265
|
-
(outside_dir / "auto-coding-skill.yaml").write_text(
|
|
266
|
-
f"schema: {core.PROJECT_CONFIG_SCHEMA}\noverrides: {{}}\n",
|
|
267
|
-
encoding="utf-8",
|
|
268
|
-
)
|
|
269
|
-
project_dir.symlink_to(outside_dir, target_is_directory=True)
|
|
270
|
-
self.assert_overlay_error("parent must be a real directory")
|
|
271
|
-
|
|
272
|
-
def test_bounds_overlay_and_frontmatter_reads(self) -> None:
|
|
273
|
-
overlay = self.repo / core.PROJECT_CONFIG_OVERLAY_RELATIVE_PATH
|
|
274
|
-
overlay.write_bytes(b"x" * (core.PROJECT_CONFIG_OVERLAY_MAX_BYTES + 1))
|
|
275
|
-
self.assert_overlay_error("exceeds its size limit")
|
|
276
|
-
|
|
277
|
-
overlay.unlink()
|
|
278
|
-
huge = "x" * core.MANAGED_CONFIG_FRONTMATTER_MAX_BYTES
|
|
279
|
-
self.write_managed(f"project:\n name: {huge}\n")
|
|
280
|
-
self.assert_overlay_error("bounded YAML frontmatter")
|
|
281
|
-
|
|
282
|
-
def test_rejects_excessive_yaml_nesting(self) -> None:
|
|
283
|
-
indent = " "
|
|
284
|
-
lines = []
|
|
285
|
-
for index in range(core.PROJECT_CONFIG_MAX_YAML_DEPTH + 1):
|
|
286
|
-
lines.append(f"{indent}level{index}:")
|
|
287
|
-
indent += " "
|
|
288
|
-
lines.append(f"{indent}value: bounded")
|
|
289
|
-
self.write_overlay("\n".join(lines) + "\n")
|
|
290
|
-
|
|
291
|
-
self.assert_overlay_error("YAML complexity limit")
|
|
292
|
-
|
|
293
|
-
def test_large_managed_body_is_not_part_of_frontmatter_bound(self) -> None:
|
|
294
|
-
self.write_managed(
|
|
295
|
-
'workflow:\n skill_version: "4.3.7"\n',
|
|
296
|
-
body="x" * (core.MANAGED_CONFIG_FRONTMATTER_MAX_BYTES + 1),
|
|
297
|
-
)
|
|
298
|
-
|
|
299
|
-
self.assertEqual("4.3.7", core.load_effective_config(self.repo)["workflow"]["skill_version"])
|
|
300
|
-
|
|
301
|
-
def test_yaml_failure_does_not_echo_content_or_absolute_path(self) -> None:
|
|
302
|
-
secret = "NEVER_ECHO_THIS_SECRET"
|
|
303
|
-
overlay = self.repo / core.PROJECT_CONFIG_OVERLAY_RELATIVE_PATH
|
|
304
|
-
overlay.write_text(
|
|
305
|
-
f"schema: {core.PROJECT_CONFIG_SCHEMA}\noverrides:\n access: [{secret}\n",
|
|
306
|
-
encoding="utf-8",
|
|
307
|
-
)
|
|
308
|
-
|
|
309
|
-
with self.assertRaises(core.APError) as context:
|
|
310
|
-
core.load_effective_config(self.repo)
|
|
311
|
-
|
|
312
|
-
message = str(context.exception)
|
|
313
|
-
self.assertNotIn(secret, message)
|
|
314
|
-
self.assertNotIn(str(self.repo), message)
|
|
315
|
-
|
|
316
|
-
def test_yaml_constructor_failures_are_sanitized_as_aperror(self) -> None:
|
|
317
|
-
cases = (
|
|
318
|
-
("bool", "!!bool BOOL_SECRET_SENTINEL", "BOOL_SECRET_SENTINEL"),
|
|
319
|
-
("int", "!!int INT_SECRET_SENTINEL", "INT_SECRET_SENTINEL"),
|
|
320
|
-
("huge-int", "9" * 5000, "9" * 64),
|
|
321
|
-
)
|
|
322
|
-
for label, value, forbidden in cases:
|
|
323
|
-
with self.subTest(case=label):
|
|
324
|
-
self.write_overlay(f" value: {value}\n")
|
|
325
|
-
with self.assertRaises(core.APError) as context:
|
|
326
|
-
core.load_effective_config(self.repo)
|
|
327
|
-
|
|
328
|
-
message = str(context.exception)
|
|
329
|
-
self.assertIn("contains invalid YAML", message)
|
|
330
|
-
self.assertNotIn(forbidden, message)
|
|
331
|
-
|
|
332
|
-
def test_rejects_surrogate_nul_and_escape_strings(self) -> None:
|
|
333
|
-
cases = (
|
|
334
|
-
("surrogate", '"\\uD800"', "invalid Unicode string"),
|
|
335
|
-
("nul", '"\\0"', "unsupported control character"),
|
|
336
|
-
("escape", '"\\u001b[31m"', "unsupported control character"),
|
|
337
|
-
)
|
|
338
|
-
for label, value, expected in cases:
|
|
339
|
-
with self.subTest(case=label):
|
|
340
|
-
self.write_overlay(f" value: {value}\n")
|
|
341
|
-
self.assert_overlay_error(expected)
|
|
342
|
-
|
|
343
|
-
|
|
344
|
-
if __name__ == "__main__":
|
|
345
|
-
unittest.main()
|