@elvis1513/auto-coding-skill 4.3.6 → 4.3.7
This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
- package/README.md +19 -6
- package/cli/assets/agents/reviewer.toml +1 -1
- package/cli/assets/managed-install.json +1 -1
- package/cli/assets/skill/SKILL.md +4 -2
- package/cli/assets/skill/data/policies/workflow-migrations-v1.json +2 -2
- package/cli/assets/skill/data/templates/ENGINEERING.md +2 -2
- package/cli/assets/skill/data/templates/bridges/AGENTS.md +6 -4
- package/cli/assets/skill/scripts/ap.py +185 -24
- package/cli/tests/ap_concurrency_test.py +89 -7
- package/cli/tests/ap_profiles_test.py +11 -0
- package/cli/tests/core_shell_test.py +5 -5
- package/cli/tests/index.test.js +31 -31
- package/package.json +1 -1
package/README.md
CHANGED
|
@@ -9,7 +9,8 @@ The Skill is a selectable guardrail, not a command sequence that must run for
|
|
|
9
9
|
every task. The model skips machinery whose expected benefit does not exceed its
|
|
10
10
|
cost; read-only work and obvious small clean-checkout changes normally stay direct.
|
|
11
11
|
|
|
12
|
-
Version 4.3.
|
|
12
|
+
Version 4.3.7 binds the supervisor's effective retry deadline into the Reviewer
|
|
13
|
+
prompt and repairs the exact 4.3.6 stale-deadline block once. Version 4.3.6 accepts the exact equivalent artifact-access wording observed in
|
|
13
14
|
real 4.3.4 Reviewer evidence without broadening retry eligibility. Version 4.3.5 keeps retry artifact reads mutation-free and can repair the exact
|
|
14
15
|
untouched or procedurally blocked 4.3.4 retry once without rewriting evidence.
|
|
15
16
|
Version 4.3.4 adds one fail-closed, immutable-evidence retry for tasks whose
|
|
@@ -387,25 +388,27 @@ rerun and needs no force flag.
|
|
|
387
388
|
|
|
388
389
|
The only migration exception is an active 4.2.8-4.3.2 task whose completed
|
|
389
390
|
Reviewer result contains no findings and is blocked solely by the fixed
|
|
390
|
-
`review-artifact` Git-local permission error. Run the managed 4.3.
|
|
391
|
+
`review-artifact` Git-local permission error. Run the managed 4.3.7 runtime from
|
|
391
392
|
outside the project install to authorize one audited retry, then immediately run
|
|
392
393
|
the original Reviewer identity:
|
|
393
394
|
|
|
394
395
|
```bash
|
|
395
|
-
python3 /absolute/managed/4.3.
|
|
396
|
+
python3 /absolute/managed/4.3.7/ap.py --repo /path/project \
|
|
396
397
|
review-runtime-retry T0001 --diff-fingerprint <SHA256> \
|
|
397
398
|
--reason-code managed-review-artifact-access \
|
|
398
399
|
--confirm-managed-runtime-retry
|
|
399
|
-
python3 /absolute/managed/4.3.
|
|
400
|
+
python3 /absolute/managed/4.3.7/ap.py --repo /path/project \
|
|
400
401
|
review-run T0001 --reviewer <ORIGINAL_REVIEWER> --json
|
|
401
402
|
```
|
|
402
403
|
|
|
403
404
|
The command preserves the original assignment, patch, result, receipt, and event
|
|
404
405
|
log byte-for-byte. It refuses substantive findings, changed scope or fingerprint,
|
|
405
406
|
tampered evidence, user overrides, duplicate retries, and unmanaged runtimes.
|
|
406
|
-
If 4.3.4 already authorized the same retry,
|
|
407
|
+
If 4.3.4 already authorized the same retry, a fixed runtime may supersede only an untouched
|
|
407
408
|
pending attempt or its exact non-substantive artifact-access block; both audit
|
|
408
|
-
chains and any prior runtime files remain immutable.
|
|
409
|
+
chains and any prior runtime files remain immutable. Version 4.3.7 may also
|
|
410
|
+
supersede the exact 4.3.6 block that used the immutable assignment's old deadline
|
|
411
|
+
after successfully reading the artifact; ordinary timeouts remain terminal.
|
|
409
412
|
|
|
410
413
|
```bash
|
|
411
414
|
cd /path/a && autocoding init
|
|
@@ -419,6 +422,16 @@ model overrides, complete project `risk.rules`, supported project/access/
|
|
|
419
422
|
concurrency/route/structure values, and an existing project-owned structure
|
|
420
423
|
standard byte-for-byte. Removed content is archived outside active docs.
|
|
421
424
|
|
|
425
|
+
## What changed in 4.3.7
|
|
426
|
+
|
|
427
|
+
- Passed the supervisor-authorized effective deadline in both the Reviewer prompt
|
|
428
|
+
and environment, explicitly superseding the immutable assignment deadline only
|
|
429
|
+
for an audit-bound retry.
|
|
430
|
+
- Added one fail-closed repair for the exact 4.3.6 stale-deadline block. It requires
|
|
431
|
+
successful artifact verification, no findings or changed paths, an observed time
|
|
432
|
+
between the original and retry deadlines, and immutable evidence from every
|
|
433
|
+
prior generation.
|
|
434
|
+
|
|
422
435
|
## What changed in 4.3.6
|
|
423
436
|
|
|
424
437
|
- Added the exact `review-artifact exited with:` evidence, summary, and risk
|
|
@@ -24,7 +24,7 @@ developer_instructions = """
|
|
|
24
24
|
11. 发现测试不足时,指出应补哪些测试或验证路径。
|
|
25
25
|
12. 实质结论必须是 approved、changes-requested 或 blocked;changes-requested 只返回 owning_fixer,修改后必须绑定新的 diff fingerprint。代码、配置或行为语义变化需要重新审查;仅链接、归档索引、状态措辞等机械文档修正,可由同一 reviewer 只做 targeted recheck,不必重跑完整审计。
|
|
26
26
|
13. 不修改代码,不提交、不推送、不集成、不清理分支;审查不扩展本地门禁。
|
|
27
|
-
14. 使用 `review-run` 在提示和 `AUTOCODING_REVIEW_ASSIGNMENT` 环境变量中传入的 assignment JSON;`AUTOCODING_REVIEW_DIFF_ARTIFACT` 和 `AUTOCODING_REVIEW_DIFF_ARTIFACT_SHA256` 必须与 assignment
|
|
27
|
+
14. 使用 `review-run` 在提示和 `AUTOCODING_REVIEW_ASSIGNMENT` 环境变量中传入的 assignment JSON;`AUTOCODING_REVIEW_DIFF_ARTIFACT` 和 `AUTOCODING_REVIEW_DIFF_ARTIFACT_SHA256` 必须与 assignment 一致。以提示和 `AUTOCODING_REVIEW_DEADLINE` 给出的 supervisor 有效截止时间为准;仅在受审计 retry 中,它可以晚于不可变 assignment 的原始 `deadline_at`。输出前运行 `python3 docs/tools/autopipeline/ap.py agent-result-template --file <assignment.json> --verdict <approved|changes-requested|blocked>`,从已验证 assignment 生成包含全部 16 个必填字段的骨架,然后填入本次分析的 summary、evidence、findings 和 risks。最终只返回该 JSON 对象,不要 Markdown 或代码围栏。最小完整形状为:
|
|
28
28
|
{
|
|
29
29
|
"contract_version": 1,
|
|
30
30
|
"node_id": "<assignment.node_id>",
|
|
@@ -1 +1 @@
|
|
|
1
|
-
{"schema_version":1,"skill_version":"4.3.
|
|
1
|
+
{"schema_version":1,"skill_version":"4.3.7","manifest_path":".agents/managed-install.json","entries":[{"path":".agents/agents/browser-debugger.toml","source":"agents/browser-debugger.toml","ownership":"normalized-agent","sha256":"40727952944917eb0b573bb96dca2906c27bc794737f3b6b392b56df7b4208aa","executable":false,"scope":"shared","version":"4.3.7"},{"path":".agents/agents/docs-researcher.toml","source":"agents/docs-researcher.toml","ownership":"normalized-agent","sha256":"aa1fed6a6a1cde282fc152c7a88b8e097a6c53bcf447d35978607d594e3cb3e4","executable":false,"scope":"shared","version":"4.3.7"},{"path":".agents/agents/explorer.toml","source":"agents/explorer.toml","ownership":"normalized-agent","sha256":"4cd89888acf7c0c04fbbcd0b9a0f346c6efed42fb723ec2037af9331a84a1cac","executable":false,"scope":"shared","version":"4.3.7"},{"path":".agents/agents/fixer.toml","source":"agents/fixer.toml","ownership":"normalized-agent","sha256":"7bc00a45b9d1bcc90b8b0f06d773556eba1d52effff664472c3cb81073f6abfb","executable":false,"scope":"shared","version":"4.3.7"},{"path":".agents/agents/reviewer.toml","source":"agents/reviewer.toml","ownership":"normalized-agent","sha256":"53380c3f3dbb27080c13b02a24cf3f686315b8811e31baa9ba619250e202d55b","executable":false,"scope":"shared","version":"4.3.7"},{"path":".agents/skills/auto-coding-skill/SKILL.md","source":"skill/SKILL.md","ownership":"exact","sha256":"1282cc30d00c27957c4e98797589d4a030f975c9516994f63a0740aa2a523c67","executable":false,"scope":"shared","version":"4.3.7"},{"path":".agents/skills/auto-coding-skill/data/contracts/orchestration-v1.schema.json","source":"skill/data/contracts/orchestration-v1.schema.json","ownership":"exact","sha256":"65a8c0d222b26f224794ec106101f903f0e3a357b249c2df22c5908a476a6835","executable":false,"scope":"shared","version":"4.3.7"},{"path":".agents/skills/auto-coding-skill/data/policies/feedback-resolutions-v1.json","source":"skill/data/policies/feedback-resolutions-v1.json","ownership":"exact","sha256":"6305c1ea8d1f4f137e606bb0277e041d6ad6792dc63be6eba642df7269d75bf7","executable":false,"scope":"shared","version":"4.3.7"},{"path":".agents/skills/auto-coding-skill/data/policies/workflow-migrations-v1.json","source":"skill/data/policies/workflow-migrations-v1.json","ownership":"exact","sha256":"fc6b78a5376e3085c6e4353d2a6925bbeefdae7a5a608819031e55a6aba69645","executable":false,"scope":"shared","version":"4.3.7"},{"path":".agents/skills/auto-coding-skill/data/templates/ENGINEERING.md","source":"skill/data/templates/ENGINEERING.md","ownership":"exact","sha256":"2c7db31f45749a9d70d761b0172f70770117f5831eba64135c7cafc5f3c5a9bd","executable":false,"scope":"shared","version":"4.3.7"},{"path":".agents/skills/auto-coding-skill/data/templates/bridges/AGENTS.md","source":"skill/data/templates/bridges/AGENTS.md","ownership":"exact","sha256":"24fde66b8f057ab5fb0b2eae739d370a5912dc991f33b8af6992877a457484cf","executable":false,"scope":"shared","version":"4.3.7"},{"path":".agents/skills/auto-coding-skill/data/templates/tools/ap.py","source":"skill/data/templates/tools/ap.py","ownership":"exact","sha256":"c352fbf2cbcb9692a34fd952d8541b1cbe6d475c6e11e64500a1f6b5283a00be","executable":false,"scope":"shared","version":"4.3.7"},{"path":".agents/skills/auto-coding-skill/requirements.txt","source":"skill/requirements.txt","ownership":"exact","sha256":"0969da99a0bc2a1b71ed50584560f4588a37567ac63af3ddbaf3c4617ca5621a","executable":false,"scope":"shared","version":"4.3.7"},{"path":".agents/skills/auto-coding-skill/scripts/ap.py","source":"skill/scripts/ap.py","ownership":"exact","sha256":"0d15084c266493f7fae414efedb7afe655d4304e7220505c3d760a61c6aa0fc1","executable":false,"scope":"shared","version":"4.3.7"},{"path":".agents/skills/auto-coding-skill/scripts/core.py","source":"skill/scripts/core.py","ownership":"exact","sha256":"caefca925929bad840c3471b86332d4be48b5e19ad0ff79fde1dcedef0297c16","executable":true,"scope":"shared","version":"4.3.7"},{"path":".agents/skills/auto-coding-skill/scripts/http_checks.py","source":"skill/scripts/http_checks.py","ownership":"exact","sha256":"5620e187a0129f135621425a84b3a4e8f31137263c7e549a36a801fc36ff54ea","executable":false,"scope":"shared","version":"4.3.7"},{"path":".agents/skills/auto-coding-skill/scripts/install_integrity.py","source":"skill/scripts/install_integrity.py","ownership":"exact","sha256":"41a2df7935027fb43cfcb3d18e57a7f33adc4861420ff43c8828743ad71cc429","executable":false,"scope":"shared","version":"4.3.7"},{"path":".agents/skills/auto-coding-skill/scripts/scaffold_templates.py","source":"skill/scripts/scaffold_templates.py","ownership":"exact","sha256":"7f25761cc065bb8c2875c8c99bea9077d339dedae81aeeddfab1c35f4cf054b3","executable":false,"scope":"shared","version":"4.3.7"},{"path":"AGENTS.md","source":"skill/data/templates/bridges/AGENTS.md","ownership":"exact","sha256":"24fde66b8f057ab5fb0b2eae739d370a5912dc991f33b8af6992877a457484cf","executable":false,"scope":"project","version":"4.3.7"},{"path":"docs/ENGINEERING.md","source":"skill/data/templates/ENGINEERING.md","ownership":"exact","sha256":"2c7db31f45749a9d70d761b0172f70770117f5831eba64135c7cafc5f3c5a9bd","executable":false,"scope":"project","version":"4.3.7"},{"path":"docs/architecture/adr/_TEMPLATE-ADR.md","source":"generated:scaffold_templates:docs/architecture/adr/_TEMPLATE-ADR.md","ownership":"exact","sha256":"88c89065ae0f8555412dbe096c05342152efc7becae8d8981e6442cdfee8e672","executable":false,"scope":"project","version":"4.3.7"},{"path":"docs/deployment/deploy-records/_TEMPLATE-DEPLOY-RECORD.md","source":"generated:scaffold_templates:docs/deployment/deploy-records/_TEMPLATE-DEPLOY-RECORD.md","ownership":"exact","sha256":"f2c17c0febc322b0ad50fb9d6f7e64e6c0cfb15c8a3e445a99da40f0a0dd1901","executable":false,"scope":"project","version":"4.3.7"},{"path":"docs/design/_TEMPLATE-DD.md","source":"generated:scaffold_templates:docs/design/_TEMPLATE-DD.md","ownership":"exact","sha256":"6ca022d127bfff68521f466b60bace4f1206baf0913daa855b9f751e74198db3","executable":false,"scope":"project","version":"4.3.7"},{"path":"docs/reviews/_TEMPLATE-REVIEW.md","source":"generated:scaffold_templates:docs/reviews/_TEMPLATE-REVIEW.md","ownership":"exact","sha256":"134f0d1bd3c7a317ef3cf4c2aea9f0539f3d53dccd5bcdabf6915b3629ef8802","executable":false,"scope":"project","version":"4.3.7"},{"path":"docs/skill-feedback/README.md","source":"generated:scaffold_templates:docs/skill-feedback/README.md","ownership":"exact","sha256":"3b146e1b7e7a1d4af57635307b825b38ce7bc58d1ee5f98871c877a64936edab","executable":false,"scope":"project","version":"4.3.7"},{"path":"docs/skill-feedback/_TEMPLATE-SKILL-FEEDBACK.md","source":"generated:scaffold_templates:docs/skill-feedback/_TEMPLATE-SKILL-FEEDBACK.md","ownership":"exact","sha256":"90ff26074305f8da537892060ffbc3a0206841702ed0483545e4ebe84e3ff357","executable":false,"scope":"project","version":"4.3.7"},{"path":"docs/tools/autopipeline/ap.py","source":"skill/data/templates/tools/ap.py","ownership":"exact","sha256":"c352fbf2cbcb9692a34fd952d8541b1cbe6d475c6e11e64500a1f6b5283a00be","executable":false,"scope":"project","version":"4.3.7"}],"managed_namespaces":[{"path":".agents/skills/auto-coding-skill","scope":"shared"},{"path":"docs/tools/autopipeline","scope":"project"}],"preserved":[".agents/archive/**",".agents/agents/* (except paths listed in entries)","docs/project/auto-coding-skill.yaml","docs/architecture/structure-standard.md","docs/architecture/** (except exact-managed entries)","docs/bugs/** (except exact-managed entries)","docs/deployment/** (except exact-managed entries)","docs/design/** (except exact-managed entries)","docs/interfaces/** (except exact-managed entries)","docs/project/** (except exact-managed entries)","docs/reviews/** (except exact-managed entries)","docs/testing/** (except exact-managed entries)","docs/skill-feedback/reports/*.md"]}
|
|
@@ -64,8 +64,10 @@ permission defect with no findings. The lifecycle owner must supply the unchange
|
|
|
64
64
|
fingerprint and fixed reason code from a strictly newer managed runtime; the
|
|
65
65
|
original Reviewer identity then runs once against a create-only audit and fresh
|
|
66
66
|
fixed deadline. This migration never renews an ordinary timeout or substantive
|
|
67
|
-
review result. A
|
|
68
|
-
exact non-substantive artifact-access block
|
|
67
|
+
review result. A fixed managed runtime may repair only an untouched
|
|
68
|
+
`retry-v4.3.4` or its exact non-substantive artifact-access block. A 4.3.7
|
|
69
|
+
runtime may additionally repair only the exact 4.3.6 stale-deadline block;
|
|
70
|
+
ordinary timeouts and substantive results remain terminal.
|
|
69
71
|
|
|
70
72
|
## Close with the bounded routed gate
|
|
71
73
|
|
|
@@ -1,6 +1,6 @@
|
|
|
1
1
|
---
|
|
2
2
|
workflow:
|
|
3
|
-
skill_version: "4.3.
|
|
3
|
+
skill_version: "4.3.7"
|
|
4
4
|
mode: "dev"
|
|
5
5
|
profile: "auto"
|
|
6
6
|
completion: "push"
|
|
@@ -83,7 +83,7 @@ docs:
|
|
|
83
83
|
api_change_log: "docs/interfaces/api-change-log.md"
|
|
84
84
|
---
|
|
85
85
|
# Engineering Configuration and Project Facts
|
|
86
|
-
<!-- auto-coding-skill:managed-workflow:start version=4.3.
|
|
86
|
+
<!-- auto-coding-skill:managed-workflow:start version=4.3.7 -->
|
|
87
87
|
Root `AGENTS.md` is the single shared behavioral protocol. The installed
|
|
88
88
|
`SKILL.md` contains invocation guidance. This whole file is the managed default
|
|
89
89
|
configuration contract. Project-owned values live only in
|
|
@@ -1,4 +1,4 @@
|
|
|
1
|
-
<!-- auto-coding-skill:managed-agents:start version=4.3.
|
|
1
|
+
<!-- auto-coding-skill:managed-agents:start version=4.3.7 -->
|
|
2
2
|
# Shared Engineering Protocol
|
|
3
3
|
|
|
4
4
|
This file is fully managed by `auto-coding-skill`. Keep project-specific facts in
|
|
@@ -94,10 +94,12 @@ failure may continue in the same conversation/task without a second lifecycle.
|
|
|
94
94
|
consumed solely by the fixed Git-local artifact permission defect. It requires
|
|
95
95
|
the lifecycle owner, unchanged fingerprint, original Reviewer, a strictly newer
|
|
96
96
|
managed runtime, and the fixed reason code; it preserves all old evidence and
|
|
97
|
-
permits one audited attempt. A
|
|
97
|
+
permits one audited attempt. A fixed managed runtime may repair only an untouched
|
|
98
98
|
`retry-v4.3.4` or its exact non-substantive artifact-access block, with both
|
|
99
|
-
audit generations retained.
|
|
100
|
-
|
|
99
|
+
audit generations retained. A 4.3.7 runtime may additionally repair only the
|
|
100
|
+
exact 4.3.6 block caused by reading the immutable assignment's old deadline
|
|
101
|
+
instead of the supervised retry deadline. Never use it for ordinary timeouts,
|
|
102
|
+
findings, changed scope, user overrides, or general Reviewer failures.
|
|
101
103
|
- Block only new or worsened in-scope P0/P1 defects. Adjacent debt is a follow-up;
|
|
102
104
|
semantic changes invalidate approval, while mechanical docs may get a targeted recheck.
|
|
103
105
|
|
|
@@ -109,6 +109,7 @@ _REVIEW_RUNTIME_RETRY_AFFECTED_MIN = (4, 2, 8)
|
|
|
109
109
|
_REVIEW_RUNTIME_RETRY_AFFECTED_MAX = (4, 3, 2)
|
|
110
110
|
_REVIEW_RUNTIME_RETRY_FIXED_IN = (4, 3, 4)
|
|
111
111
|
_REVIEW_RUNTIME_RETRY_REPAIRED_IN = (4, 3, 5)
|
|
112
|
+
_REVIEW_RUNTIME_RETRY_DEADLINE_FIXED_IN = (4, 3, 7)
|
|
112
113
|
_REVIEW_OUTPUT_MAX_BYTES = 1024 * 1024
|
|
113
114
|
_REVIEW_DIFF_ARTIFACT_FORMAT = "git-binary-patch-v1"
|
|
114
115
|
_REVIEW_DIFF_ARTIFACT_MAX_BYTES = 64 * 1024 * 1024
|
|
@@ -300,7 +301,7 @@ _FINAL_GATE_CACHE_ALGORITHM = "final-gate-v1"
|
|
|
300
301
|
_WORKFLOW_MIGRATION_POLICY = Path("data/policies/workflow-migrations-v1.json")
|
|
301
302
|
_FALLBACK_WORKFLOW_MIGRATION_POLICY = {
|
|
302
303
|
"schema_version": 1,
|
|
303
|
-
"managed_versions": {"agents": "4.3.
|
|
304
|
+
"managed_versions": {"agents": "4.3.7", "engineering": "4.3.7"},
|
|
304
305
|
"known_official_engineering_body_sha256": [
|
|
305
306
|
"d1306cc626e8baf8c83c953b760fd771066de2bf125168eca3a7b7d6ff2b87a2",
|
|
306
307
|
"305931c6edef770033a4f1970b00e5fb1c1728351856a173dbfa497daf563021",
|
|
@@ -9801,6 +9802,7 @@ def _codex_reviewer_command(
|
|
|
9801
9802
|
result_path: Path,
|
|
9802
9803
|
*,
|
|
9803
9804
|
review_depth: str = "deep",
|
|
9805
|
+
effective_deadline: Optional[_dt.datetime] = None,
|
|
9804
9806
|
) -> list[str]:
|
|
9805
9807
|
codex = shutil.which("codex")
|
|
9806
9808
|
if not codex:
|
|
@@ -9835,12 +9837,22 @@ def _codex_reviewer_command(
|
|
|
9835
9837
|
str(assignment_path),
|
|
9836
9838
|
]
|
|
9837
9839
|
)
|
|
9840
|
+
deadline_instruction = (
|
|
9841
|
+
"Stay inside its identity and deadline. "
|
|
9842
|
+
if effective_deadline is None
|
|
9843
|
+
else (
|
|
9844
|
+
"The supervisor-authorized effective deadline for this attempt is "
|
|
9845
|
+
f"{effective_deadline.astimezone(_dt.timezone.utc).isoformat()}; it is also "
|
|
9846
|
+
"bound in AUTOCODING_REVIEW_DEADLINE and supersedes the immutable "
|
|
9847
|
+
"assignment deadline_at only for this audited retry. "
|
|
9848
|
+
)
|
|
9849
|
+
)
|
|
9838
9850
|
prompt = (
|
|
9839
9851
|
f"Review the exact assignment at {assignment_path}. "
|
|
9840
9852
|
f"Before analysis, run `{artifact_command}`; it verifies diff_artifact_path, "
|
|
9841
9853
|
"mode 0600, and diff_artifact_sha256, then emits the immutable patch. "
|
|
9842
9854
|
"Review that emitted patch and never substitute a live git diff or diff_base..diff_head. "
|
|
9843
|
-
"
|
|
9855
|
+
f"{deadline_instruction}Use "
|
|
9844
9856
|
f"`{template_command} --verdict approved` when useful, replacing `approved` "
|
|
9845
9857
|
"with `changes-requested` or `blocked` when appropriate. "
|
|
9846
9858
|
"Return only one JSON object as the final response; do not modify files."
|
|
@@ -14369,8 +14381,9 @@ def _load_review_runtime_retry_audit(
|
|
|
14369
14381
|
_read_verified_private_review_file(path, _text(audit.get(f"{field}_sha256")), label)
|
|
14370
14382
|
superseded_token = _text(audit.get("superseded_retry_token"))
|
|
14371
14383
|
if superseded_token:
|
|
14372
|
-
if superseded_token
|
|
14373
|
-
raise APError("Reviewer runtime repair
|
|
14384
|
+
if superseded_token not in {"retry-v4.3.4", "retry-v4.3.6"}:
|
|
14385
|
+
raise APError("Reviewer runtime repair has an unsupported superseded retry.")
|
|
14386
|
+
superseded_version = superseded_token.removeprefix("retry-v")
|
|
14374
14387
|
superseded_audit_path = _review_runtime_retry_audit_path(
|
|
14375
14388
|
control_repo,
|
|
14376
14389
|
task_id,
|
|
@@ -14426,7 +14439,7 @@ def _load_review_runtime_retry_audit(
|
|
|
14426
14439
|
),
|
|
14427
14440
|
"diff_artifact_sha256": _text(review.get("diff_artifact_sha256")),
|
|
14428
14441
|
"original_deadline_at": _text(assignment.get("deadline_at")),
|
|
14429
|
-
"managed_runtime_version":
|
|
14442
|
+
"managed_runtime_version": superseded_version,
|
|
14430
14443
|
"retry_result_path": str(superseded_result_path.resolve()),
|
|
14431
14444
|
"retry_receipt_path": str(superseded_receipt_path.resolve()),
|
|
14432
14445
|
"retry_event_log_path": str(superseded_event_path.resolve()),
|
|
@@ -14441,6 +14454,74 @@ def _load_review_runtime_retry_audit(
|
|
|
14441
14454
|
"Superseded Reviewer runtime retry audit does not match task state: "
|
|
14442
14455
|
+ ", ".join(superseded_mismatched)
|
|
14443
14456
|
)
|
|
14457
|
+
if superseded_token == "retry-v4.3.6":
|
|
14458
|
+
nested_token = _text(superseded_audit.get("superseded_retry_token"))
|
|
14459
|
+
nested_audit_path = _review_runtime_retry_audit_path(
|
|
14460
|
+
control_repo,
|
|
14461
|
+
task_id,
|
|
14462
|
+
fingerprint,
|
|
14463
|
+
nested_token,
|
|
14464
|
+
create=False,
|
|
14465
|
+
).resolve()
|
|
14466
|
+
if (
|
|
14467
|
+
nested_token != "retry-v4.3.4"
|
|
14468
|
+
or Path(_text(superseded_audit.get("superseded_retry_audit_path"))).resolve()
|
|
14469
|
+
!= nested_audit_path
|
|
14470
|
+
):
|
|
14471
|
+
raise APError("Nested Reviewer runtime retry audit path is invalid.")
|
|
14472
|
+
nested_payload = _read_verified_private_review_file(
|
|
14473
|
+
nested_audit_path,
|
|
14474
|
+
_text(superseded_audit.get("superseded_retry_audit_sha256")),
|
|
14475
|
+
"nested runtime retry audit",
|
|
14476
|
+
)
|
|
14477
|
+
try:
|
|
14478
|
+
nested_audit = json.loads(nested_payload.decode("utf-8"))
|
|
14479
|
+
except (UnicodeDecodeError, json.JSONDecodeError) as exc:
|
|
14480
|
+
raise APError("Nested Reviewer runtime retry audit is invalid JSON.") from exc
|
|
14481
|
+
if (
|
|
14482
|
+
not isinstance(nested_audit, dict)
|
|
14483
|
+
or nested_audit.get("retry_token") != nested_token
|
|
14484
|
+
or nested_audit.get("managed_runtime_version") != "4.3.4"
|
|
14485
|
+
or nested_audit.get("task_id") != task_id
|
|
14486
|
+
or nested_audit.get("diff_fingerprint") != fingerprint
|
|
14487
|
+
):
|
|
14488
|
+
raise APError("Nested Reviewer runtime retry audit identity is invalid.")
|
|
14489
|
+
nested_result_path, nested_receipt_path = _review_runtime_paths(
|
|
14490
|
+
control_repo,
|
|
14491
|
+
task_id,
|
|
14492
|
+
fingerprint,
|
|
14493
|
+
nested_token,
|
|
14494
|
+
create=False,
|
|
14495
|
+
)
|
|
14496
|
+
nested_event_path = _review_runtime_event_log_path(
|
|
14497
|
+
control_repo,
|
|
14498
|
+
task_id,
|
|
14499
|
+
fingerprint,
|
|
14500
|
+
nested_token,
|
|
14501
|
+
create=False,
|
|
14502
|
+
)
|
|
14503
|
+
nested_state = _text(superseded_audit.get("superseded_retry_state"))
|
|
14504
|
+
if nested_state == "pending":
|
|
14505
|
+
if any(
|
|
14506
|
+
path.exists() or path.is_symlink()
|
|
14507
|
+
for path in (nested_result_path, nested_receipt_path, nested_event_path)
|
|
14508
|
+
):
|
|
14509
|
+
raise APError("Nested pending Reviewer retry unexpectedly has runtime evidence.")
|
|
14510
|
+
elif nested_state == "blocked":
|
|
14511
|
+
for field, path, label in (
|
|
14512
|
+
("superseded_retry_result", nested_result_path, "nested retry result"),
|
|
14513
|
+
("superseded_retry_receipt", nested_receipt_path, "nested retry receipt"),
|
|
14514
|
+
("superseded_retry_event_log", nested_event_path, "nested retry event log"),
|
|
14515
|
+
):
|
|
14516
|
+
if Path(_text(superseded_audit.get(f"{field}_path"))).resolve() != path.resolve():
|
|
14517
|
+
raise APError(f"Reviewer runtime repair {label} path is not canonical.")
|
|
14518
|
+
_read_verified_private_review_file(
|
|
14519
|
+
path,
|
|
14520
|
+
_text(superseded_audit.get(f"{field}_sha256")),
|
|
14521
|
+
label,
|
|
14522
|
+
)
|
|
14523
|
+
else:
|
|
14524
|
+
raise APError("Nested Reviewer runtime retry state is invalid.")
|
|
14444
14525
|
superseded_state = _text(audit.get("superseded_retry_state"))
|
|
14445
14526
|
if superseded_state == "pending":
|
|
14446
14527
|
if any(
|
|
@@ -14899,6 +14980,63 @@ def _known_review_artifact_access_failure(
|
|
|
14899
14980
|
return True
|
|
14900
14981
|
|
|
14901
14982
|
|
|
14983
|
+
def _known_review_retry_deadline_misread(
|
|
14984
|
+
result: dict,
|
|
14985
|
+
assignment: dict,
|
|
14986
|
+
retry_audit: dict,
|
|
14987
|
+
) -> bool:
|
|
14988
|
+
if (
|
|
14989
|
+
_text(result.get("verdict")) != "blocked"
|
|
14990
|
+
or _text(result.get("status")) != "blocked"
|
|
14991
|
+
or list(result.get("findings") or [])
|
|
14992
|
+
or list(result.get("changed_paths") or [])
|
|
14993
|
+
or list(result.get("owned_paths") or [])
|
|
14994
|
+
or _text(result.get("summary"))
|
|
14995
|
+
!= (
|
|
14996
|
+
"The immutable artifact passed mode-0600 and SHA-256 verification, "
|
|
14997
|
+
"but the assignment deadline expired before the deep review could be completed."
|
|
14998
|
+
)
|
|
14999
|
+
):
|
|
15000
|
+
return False
|
|
15001
|
+
evidence = result.get("evidence")
|
|
15002
|
+
if not isinstance(evidence, list) or len(evidence) != 2:
|
|
15003
|
+
return False
|
|
15004
|
+
if evidence[0] != (
|
|
15005
|
+
"review-artifact completed successfully for diff_artifact_sha256 "
|
|
15006
|
+
f"{_text(assignment.get('diff_artifact_sha256'))}."
|
|
15007
|
+
):
|
|
15008
|
+
return False
|
|
15009
|
+
deadline_pattern = re.compile(
|
|
15010
|
+
r"^Assignment deadline_at was "
|
|
15011
|
+
+ re.escape(_text(assignment.get("deadline_at")))
|
|
15012
|
+
+ r"; observed UTC time before completion was (.+)\.$"
|
|
15013
|
+
)
|
|
15014
|
+
match = deadline_pattern.fullmatch(_text(evidence[1]))
|
|
15015
|
+
if not match:
|
|
15016
|
+
return False
|
|
15017
|
+
try:
|
|
15018
|
+
original_deadline = _parse_iso_timestamp(assignment.get("deadline_at"), "deadline_at")
|
|
15019
|
+
observed = _parse_iso_timestamp(match.group(1), "observed reviewer time")
|
|
15020
|
+
retry_deadline = _parse_iso_timestamp(
|
|
15021
|
+
retry_audit.get("retry_deadline_at"),
|
|
15022
|
+
"retry_deadline_at",
|
|
15023
|
+
)
|
|
15024
|
+
except APError:
|
|
15025
|
+
return False
|
|
15026
|
+
if not original_deadline < observed < retry_deadline:
|
|
15027
|
+
return False
|
|
15028
|
+
risks = result.get("risks")
|
|
15029
|
+
return bool(
|
|
15030
|
+
isinstance(risks, list)
|
|
15031
|
+
and len(risks) == 1
|
|
15032
|
+
and re.fullmatch(
|
|
15033
|
+
r"The [1-9][0-9]*-line cross-module patch did not receive a complete "
|
|
15034
|
+
r"substantive deep review within its bound deadline; no approval should be inferred\.",
|
|
15035
|
+
_text(risks[0]),
|
|
15036
|
+
)
|
|
15037
|
+
)
|
|
15038
|
+
|
|
15039
|
+
|
|
14902
15040
|
def cmd_review_runtime_retry(args: argparse.Namespace) -> None:
|
|
14903
15041
|
repo = Path(args.repo).resolve()
|
|
14904
15042
|
ensure_git_repo(repo)
|
|
@@ -14942,10 +15080,16 @@ def cmd_review_runtime_retry(args: argparse.Namespace) -> None:
|
|
|
14942
15080
|
raise APError("Managed Reviewer retry runtime must be newer than the task runtime.")
|
|
14943
15081
|
review = dict(manifest.get("review") or {})
|
|
14944
15082
|
existing_token = _review_attempt_token(review)
|
|
14945
|
-
|
|
14946
|
-
|
|
14947
|
-
|
|
14948
|
-
)
|
|
15083
|
+
repairing_artifact_retry = (
|
|
15084
|
+
existing_token == "retry-v4.3.4"
|
|
15085
|
+
and runtime_version_tuple >= _REVIEW_RUNTIME_RETRY_REPAIRED_IN
|
|
15086
|
+
)
|
|
15087
|
+
repairing_deadline_retry = (
|
|
15088
|
+
existing_token == "retry-v4.3.6"
|
|
15089
|
+
and runtime_version_tuple >= _REVIEW_RUNTIME_RETRY_DEADLINE_FIXED_IN
|
|
15090
|
+
)
|
|
15091
|
+
repairing_retry = repairing_artifact_retry or repairing_deadline_retry
|
|
15092
|
+
if existing_token and not repairing_retry:
|
|
14949
15093
|
raise APError("A Reviewer runtime retry is already authorized for this diff fingerprint.")
|
|
14950
15094
|
if not existing_token and any(
|
|
14951
15095
|
_text(review.get(field)) for field in _REVIEW_RETRY_FIELDS
|
|
@@ -14991,9 +15135,10 @@ def cmd_review_runtime_retry(args: argparse.Namespace) -> None:
|
|
|
14991
15135
|
)
|
|
14992
15136
|
if (
|
|
14993
15137
|
not superseded_audit
|
|
14994
|
-
or _text(superseded_audit.get("managed_runtime_version"))
|
|
15138
|
+
or _text(superseded_audit.get("managed_runtime_version"))
|
|
15139
|
+
!= existing_token.removeprefix("retry-v")
|
|
14995
15140
|
):
|
|
14996
|
-
raise APError("Only
|
|
15141
|
+
raise APError("Only an exact managed retry generation may be repaired.")
|
|
14997
15142
|
retry_paths = (*_review_runtime_paths(
|
|
14998
15143
|
control_repo,
|
|
14999
15144
|
task_id,
|
|
@@ -15008,7 +15153,8 @@ def cmd_review_runtime_retry(args: argparse.Namespace) -> None:
|
|
|
15008
15153
|
create=False,
|
|
15009
15154
|
))
|
|
15010
15155
|
if (
|
|
15011
|
-
|
|
15156
|
+
repairing_artifact_retry
|
|
15157
|
+
and _text(review.get("verdict")) == "pending"
|
|
15012
15158
|
and _text(review.get("reason")) == "bounded managed runtime retry authorized"
|
|
15013
15159
|
and not any(field in review for field in _REVIEW_RUNTIME_FIELDS)
|
|
15014
15160
|
and not any(path.exists() or path.is_symlink() for path in retry_paths)
|
|
@@ -15024,7 +15170,7 @@ def cmd_review_runtime_retry(args: argparse.Namespace) -> None:
|
|
|
15024
15170
|
superseded_state = "blocked"
|
|
15025
15171
|
else:
|
|
15026
15172
|
raise APError(
|
|
15027
|
-
"The
|
|
15173
|
+
"The Reviewer retry is not an untouched eligible attempt or the exact procedural block."
|
|
15028
15174
|
)
|
|
15029
15175
|
elif (
|
|
15030
15176
|
_text(review.get("verdict")) != "blocked"
|
|
@@ -15088,12 +15234,18 @@ def cmd_review_runtime_retry(args: argparse.Namespace) -> None:
|
|
|
15088
15234
|
if not isinstance(result_payload, dict):
|
|
15089
15235
|
raise APError("Prior Reviewer result must contain one JSON object.")
|
|
15090
15236
|
normalized_result = _normalize_reviewer_runtime_result(assignment, result_payload)
|
|
15091
|
-
|
|
15092
|
-
control_repo,
|
|
15093
|
-
|
|
15094
|
-
|
|
15237
|
+
known_procedural_failure = (
|
|
15238
|
+
_known_review_artifact_access_failure(control_repo, normalized_result)
|
|
15239
|
+
if not repairing_deadline_retry
|
|
15240
|
+
else _known_review_retry_deadline_misread(
|
|
15241
|
+
normalized_result,
|
|
15242
|
+
assignment,
|
|
15243
|
+
superseded_audit or {},
|
|
15244
|
+
)
|
|
15245
|
+
)
|
|
15246
|
+
if result_payload != normalized_result or not known_procedural_failure:
|
|
15095
15247
|
raise APError(
|
|
15096
|
-
"Prior Reviewer result is not the exact non-substantive
|
|
15248
|
+
"Prior Reviewer result is not the exact eligible non-substantive failure."
|
|
15097
15249
|
)
|
|
15098
15250
|
|
|
15099
15251
|
if superseded_audit:
|
|
@@ -15331,6 +15483,18 @@ def cmd_review_run(args: argparse.Namespace) -> None:
|
|
|
15331
15483
|
fingerprint,
|
|
15332
15484
|
attempt_token,
|
|
15333
15485
|
)
|
|
15486
|
+
retry_audit = _load_review_runtime_retry_audit(
|
|
15487
|
+
control_repo,
|
|
15488
|
+
manifest,
|
|
15489
|
+
assignment,
|
|
15490
|
+
require_same_runtime=bool(attempt_token),
|
|
15491
|
+
)
|
|
15492
|
+
command_deadline = _effective_review_deadline(
|
|
15493
|
+
control_repo,
|
|
15494
|
+
manifest,
|
|
15495
|
+
assignment,
|
|
15496
|
+
require_same_runtime=bool(attempt_token),
|
|
15497
|
+
)
|
|
15334
15498
|
|
|
15335
15499
|
command_override = _text(getattr(args, "runner_command_json", ""))
|
|
15336
15500
|
if command_override:
|
|
@@ -15355,6 +15519,7 @@ def cmd_review_run(args: argparse.Namespace) -> None:
|
|
|
15355
15519
|
assignment_path,
|
|
15356
15520
|
result_path,
|
|
15357
15521
|
review_depth=_text(assignment.get("review_depth")) or "focused",
|
|
15522
|
+
effective_deadline=command_deadline if attempt_token else None,
|
|
15358
15523
|
)
|
|
15359
15524
|
runner_kind = "codex"
|
|
15360
15525
|
command_sha256 = _review_command_sha256(command)
|
|
@@ -15387,12 +15552,6 @@ def cmd_review_run(args: argparse.Namespace) -> None:
|
|
|
15387
15552
|
"finished_at": "",
|
|
15388
15553
|
"exit_code": None,
|
|
15389
15554
|
}
|
|
15390
|
-
retry_audit = _load_review_runtime_retry_audit(
|
|
15391
|
-
control_repo,
|
|
15392
|
-
manifest,
|
|
15393
|
-
assignment,
|
|
15394
|
-
require_same_runtime=bool(attempt_token),
|
|
15395
|
-
)
|
|
15396
15555
|
if retry_audit is not None:
|
|
15397
15556
|
receipt.update(
|
|
15398
15557
|
{
|
|
@@ -15429,6 +15588,8 @@ def cmd_review_run(args: argparse.Namespace) -> None:
|
|
|
15429
15588
|
assignment,
|
|
15430
15589
|
require_same_runtime=bool(attempt_token),
|
|
15431
15590
|
)
|
|
15591
|
+
if deadline != command_deadline:
|
|
15592
|
+
raise APError("Reviewer effective deadline changed before runtime start.")
|
|
15432
15593
|
if _dt.datetime.now(_dt.timezone.utc) >= deadline:
|
|
15433
15594
|
raise APError("Review assignment deadline expired before Reviewer runtime start.")
|
|
15434
15595
|
if result_path.exists() or result_path.is_symlink():
|
|
@@ -198,7 +198,7 @@ class AutoCodingConcurrencyTests(unittest.TestCase):
|
|
|
198
198
|
check=check,
|
|
199
199
|
)
|
|
200
200
|
|
|
201
|
-
def managed_runtime(self, root: Path, version: str = "4.3.
|
|
201
|
+
def managed_runtime(self, root: Path, version: str = "4.3.7") -> Path:
|
|
202
202
|
install_root = root / "managed-runtime"
|
|
203
203
|
skill = install_root / ".agents" / "skills" / "auto-coding-skill"
|
|
204
204
|
shutil.copytree(REPO_ROOT / "src" / "auto-coding-skill", skill)
|
|
@@ -1666,7 +1666,7 @@ class AutoCodingConcurrencyTests(unittest.TestCase):
|
|
|
1666
1666
|
).stdout
|
|
1667
1667
|
)
|
|
1668
1668
|
self.assertEqual("retry-authorized", authorized["status"])
|
|
1669
|
-
self.assertEqual("retry-v4.3.
|
|
1669
|
+
self.assertEqual("retry-v4.3.7", authorized["retry_token"])
|
|
1670
1670
|
audit_path = Path(authorized["audit_path"])
|
|
1671
1671
|
self.assertEqual(0o600, audit_path.stat().st_mode & 0o777)
|
|
1672
1672
|
audit = json.loads(audit_path.read_text(encoding="utf-8"))
|
|
@@ -1705,9 +1705,9 @@ class AutoCodingConcurrencyTests(unittest.TestCase):
|
|
|
1705
1705
|
)["tasks"][0]
|
|
1706
1706
|
retry_review = status["review"]
|
|
1707
1707
|
self.assertEqual("approved", retry_review["verdict"])
|
|
1708
|
-
self.assertIn(".retry-v4.3.
|
|
1708
|
+
self.assertIn(".retry-v4.3.7.result.json", retry_review["runtime_result_path"])
|
|
1709
1709
|
retry_receipt = json.loads(Path(retry_review["runtime_receipt_path"]).read_text())
|
|
1710
|
-
self.assertEqual("retry-v4.3.
|
|
1710
|
+
self.assertEqual("retry-v4.3.7", retry_receipt["runtime_retry_token"])
|
|
1711
1711
|
self.assertEqual(authorized["audit_sha256"], retry_receipt["runtime_retry_audit_sha256"])
|
|
1712
1712
|
|
|
1713
1713
|
repeated = self.ap_script(
|
|
@@ -1728,6 +1728,7 @@ class AutoCodingConcurrencyTests(unittest.TestCase):
|
|
|
1728
1728
|
root, repo, _ = self.make_repo()
|
|
1729
1729
|
managed_434 = self.managed_runtime(root / "runtime-434", "4.3.4")
|
|
1730
1730
|
managed_fixed = self.managed_runtime(root / "runtime-fixed", "4.3.6")
|
|
1731
|
+
managed_final = self.managed_runtime(root / "runtime-final", "4.3.7")
|
|
1731
1732
|
worktree = self.start_task(repo, "REVIEW-RETRY-REPAIR", "shared.txt")
|
|
1732
1733
|
(worktree / "shared.txt").write_text("repair retry payload\n", encoding="utf-8")
|
|
1733
1734
|
common_dir = Path(git_output(repo, "rev-parse", "--git-common-dir"))
|
|
@@ -1746,6 +1747,22 @@ class AutoCodingConcurrencyTests(unittest.TestCase):
|
|
|
1746
1747
|
encoding="utf-8",
|
|
1747
1748
|
)
|
|
1748
1749
|
blocked_runner = json.dumps([sys.executable, str(blocked_reviewer)])
|
|
1750
|
+
issued = json.loads(
|
|
1751
|
+
self.ap(
|
|
1752
|
+
worktree,
|
|
1753
|
+
"review-assignment",
|
|
1754
|
+
"REVIEW-RETRY-REPAIR",
|
|
1755
|
+
"--reviewer",
|
|
1756
|
+
"repair-reviewer",
|
|
1757
|
+
"--json",
|
|
1758
|
+
).stdout
|
|
1759
|
+
)
|
|
1760
|
+
self.shorten_review_deadline(
|
|
1761
|
+
repo,
|
|
1762
|
+
"REVIEW-RETRY-REPAIR",
|
|
1763
|
+
issued,
|
|
1764
|
+
seconds=30,
|
|
1765
|
+
)
|
|
1749
1766
|
self.ap(
|
|
1750
1767
|
worktree,
|
|
1751
1768
|
"review-run",
|
|
@@ -1823,10 +1840,72 @@ class AutoCodingConcurrencyTests(unittest.TestCase):
|
|
|
1823
1840
|
repair_audit = json.loads(Path(repaired["audit_path"]).read_text(encoding="utf-8"))
|
|
1824
1841
|
self.assertEqual("retry-v4.3.4", repair_audit["superseded_retry_token"])
|
|
1825
1842
|
self.assertEqual("blocked", repair_audit["superseded_retry_state"])
|
|
1826
|
-
|
|
1843
|
+
assignment = json.loads(
|
|
1844
|
+
Path(old_review["assignment_path"]).read_text(encoding="utf-8")
|
|
1845
|
+
)
|
|
1846
|
+
observed = (
|
|
1847
|
+
datetime.fromisoformat(assignment["deadline_at"]) + timedelta(seconds=1)
|
|
1848
|
+
).isoformat()
|
|
1849
|
+
deadline_reviewer = root / "stale-deadline-block.py"
|
|
1850
|
+
deadline_reviewer.write_text(
|
|
1851
|
+
"import json\n"
|
|
1852
|
+
"print(json.dumps({"
|
|
1853
|
+
"'verdict': 'blocked', "
|
|
1854
|
+
"'summary': 'The immutable artifact passed mode-0600 and SHA-256 verification, but the assignment deadline expired before the deep review could be completed.', "
|
|
1855
|
+
f"'evidence': ['review-artifact completed successfully for diff_artifact_sha256 {assignment['diff_artifact_sha256']}.', "
|
|
1856
|
+
f"'Assignment deadline_at was {assignment['deadline_at']}; observed UTC time before completion was {observed}.'], "
|
|
1857
|
+
"'risks': ['The 1701-line cross-module patch did not receive a complete substantive deep review within its bound deadline; no approval should be inferred.']}))\n",
|
|
1858
|
+
encoding="utf-8",
|
|
1859
|
+
)
|
|
1860
|
+
self.ap_script(
|
|
1861
|
+
worktree,
|
|
1862
|
+
managed_fixed,
|
|
1863
|
+
"review-run",
|
|
1864
|
+
"REVIEW-RETRY-REPAIR",
|
|
1865
|
+
"--reviewer",
|
|
1866
|
+
"repair-reviewer",
|
|
1867
|
+
"--runner-command-json",
|
|
1868
|
+
json.dumps([sys.executable, str(deadline_reviewer)]),
|
|
1869
|
+
check=False,
|
|
1870
|
+
)
|
|
1871
|
+
deadline_status = json.loads(
|
|
1827
1872
|
self.ap_script(
|
|
1828
1873
|
worktree,
|
|
1829
1874
|
managed_fixed,
|
|
1875
|
+
"task-status",
|
|
1876
|
+
"REVIEW-RETRY-REPAIR",
|
|
1877
|
+
"--json",
|
|
1878
|
+
).stdout
|
|
1879
|
+
)["tasks"][0]
|
|
1880
|
+
deadline_review = deadline_status["review"]
|
|
1881
|
+
deadline_evidence_paths = [
|
|
1882
|
+
Path(deadline_review["runtime_retry_audit_path"]),
|
|
1883
|
+
Path(deadline_review["runtime_result_path"]),
|
|
1884
|
+
Path(deadline_review["runtime_receipt_path"]),
|
|
1885
|
+
Path(deadline_review["runtime_event_log_path"]),
|
|
1886
|
+
]
|
|
1887
|
+
old_evidence.update({path: path.read_bytes() for path in deadline_evidence_paths})
|
|
1888
|
+
final_retry = json.loads(
|
|
1889
|
+
self.ap_script(
|
|
1890
|
+
worktree,
|
|
1891
|
+
managed_final,
|
|
1892
|
+
"review-runtime-retry",
|
|
1893
|
+
"REVIEW-RETRY-REPAIR",
|
|
1894
|
+
"--diff-fingerprint",
|
|
1895
|
+
fingerprint,
|
|
1896
|
+
"--reason-code",
|
|
1897
|
+
"managed-review-artifact-access",
|
|
1898
|
+
"--confirm-managed-runtime-retry",
|
|
1899
|
+
"--json",
|
|
1900
|
+
).stdout
|
|
1901
|
+
)
|
|
1902
|
+
self.assertEqual("retry-v4.3.7", final_retry["retry_token"])
|
|
1903
|
+
final_audit = json.loads(Path(final_retry["audit_path"]).read_text(encoding="utf-8"))
|
|
1904
|
+
self.assertEqual("retry-v4.3.6", final_audit["superseded_retry_token"])
|
|
1905
|
+
reviewed = json.loads(
|
|
1906
|
+
self.ap_script(
|
|
1907
|
+
worktree,
|
|
1908
|
+
managed_final,
|
|
1830
1909
|
"review-run",
|
|
1831
1910
|
"REVIEW-RETRY-REPAIR",
|
|
1832
1911
|
"--reviewer",
|
|
@@ -1835,7 +1914,7 @@ class AutoCodingConcurrencyTests(unittest.TestCase):
|
|
|
1835
1914
|
self.artifact_reviewer_runner(
|
|
1836
1915
|
root,
|
|
1837
1916
|
"repair retry payload",
|
|
1838
|
-
runtime_script=
|
|
1917
|
+
runtime_script=managed_final,
|
|
1839
1918
|
),
|
|
1840
1919
|
"--json",
|
|
1841
1920
|
).stdout
|
|
@@ -1884,7 +1963,10 @@ class AutoCodingConcurrencyTests(unittest.TestCase):
|
|
|
1884
1963
|
check=False,
|
|
1885
1964
|
)
|
|
1886
1965
|
self.assertNotEqual(0, rejected.returncode)
|
|
1887
|
-
self.assertIn(
|
|
1966
|
+
self.assertIn(
|
|
1967
|
+
"not the exact eligible non-substantive",
|
|
1968
|
+
rejected.stdout + rejected.stderr,
|
|
1969
|
+
)
|
|
1888
1970
|
|
|
1889
1971
|
def test_review_run_retries_runtime_unavailable_and_allows_bound_user_override(self) -> None:
|
|
1890
1972
|
root, repo, _ = self.make_repo()
|
|
@@ -818,6 +818,14 @@ class AutoCodingProfileTests(unittest.TestCase):
|
|
|
818
818
|
assignment_path,
|
|
819
819
|
result_path,
|
|
820
820
|
review_depth="focused",
|
|
821
|
+
effective_deadline=ap._dt.datetime(
|
|
822
|
+
2026,
|
|
823
|
+
7,
|
|
824
|
+
19,
|
|
825
|
+
9,
|
|
826
|
+
45,
|
|
827
|
+
tzinfo=ap._dt.timezone.utc,
|
|
828
|
+
),
|
|
821
829
|
)
|
|
822
830
|
deep = ap._codex_reviewer_command(
|
|
823
831
|
repo,
|
|
@@ -861,6 +869,9 @@ class AutoCodingProfileTests(unittest.TestCase):
|
|
|
861
869
|
self.assertNotIn("docs/tools/autopipeline/ap.py", prompt)
|
|
862
870
|
self.assertIn("diff_artifact_sha256", prompt)
|
|
863
871
|
self.assertIn("never substitute a live git diff", prompt)
|
|
872
|
+
self.assertIn("2026-07-19T09:45:00+00:00", prompt)
|
|
873
|
+
self.assertIn("AUTOCODING_REVIEW_DEADLINE", prompt)
|
|
874
|
+
self.assertIn("supersedes the immutable assignment deadline_at", prompt)
|
|
864
875
|
developer_override = next(
|
|
865
876
|
item for item in focused if item.startswith("developer_instructions=")
|
|
866
877
|
)
|
|
@@ -87,7 +87,7 @@ class ProjectConfigResolverTests(unittest.TestCase):
|
|
|
87
87
|
(self.repo / "docs" / "project").mkdir(parents=True)
|
|
88
88
|
self.write_managed(
|
|
89
89
|
"""workflow:
|
|
90
|
-
skill_version: "4.3.
|
|
90
|
+
skill_version: "4.3.7"
|
|
91
91
|
mode: dev
|
|
92
92
|
profile: auto
|
|
93
93
|
completion: push
|
|
@@ -130,7 +130,7 @@ access:
|
|
|
130
130
|
effective = core.load_effective_config(self.repo)
|
|
131
131
|
|
|
132
132
|
self.assertEqual("sample", effective["project"]["name"])
|
|
133
|
-
self.assertEqual("4.3.
|
|
133
|
+
self.assertEqual("4.3.7", effective["workflow"]["skill_version"])
|
|
134
134
|
self.assertEqual(self.repo / "docs" / "ENGINEERING.md", core.find_config(self.repo))
|
|
135
135
|
self.assertEqual({}, core.load_project_overrides(self.repo))
|
|
136
136
|
|
|
@@ -153,7 +153,7 @@ access:
|
|
|
153
153
|
|
|
154
154
|
effective = core.load_effective_config(self.repo)
|
|
155
155
|
|
|
156
|
-
self.assertEqual("4.3.
|
|
156
|
+
self.assertEqual("4.3.7", effective["workflow"]["skill_version"])
|
|
157
157
|
self.assertEqual("dev", effective["workflow"]["mode"])
|
|
158
158
|
self.assertEqual("project-profile", effective["workflow"]["profile"])
|
|
159
159
|
self.assertEqual("push", effective["workflow"]["completion"])
|
|
@@ -292,11 +292,11 @@ access:
|
|
|
292
292
|
|
|
293
293
|
def test_large_managed_body_is_not_part_of_frontmatter_bound(self) -> None:
|
|
294
294
|
self.write_managed(
|
|
295
|
-
'workflow:\n skill_version: "4.3.
|
|
295
|
+
'workflow:\n skill_version: "4.3.7"\n',
|
|
296
296
|
body="x" * (core.MANAGED_CONFIG_FRONTMATTER_MAX_BYTES + 1),
|
|
297
297
|
)
|
|
298
298
|
|
|
299
|
-
self.assertEqual("4.3.
|
|
299
|
+
self.assertEqual("4.3.7", core.load_effective_config(self.repo)["workflow"]["skill_version"])
|
|
300
300
|
|
|
301
301
|
def test_yaml_failure_does_not_echo_content_or_absolute_path(self) -> None:
|
|
302
302
|
secret = "NEVER_ECHO_THIS_SECRET"
|
package/cli/tests/index.test.js
CHANGED
|
@@ -422,8 +422,8 @@ function testInitFullyConvergesExistingProject() {
|
|
|
422
422
|
}
|
|
423
423
|
assert(exists(path.join(repo, ".agents", "agents", "custom.toml")), "project-owned custom agents must survive init");
|
|
424
424
|
assert(!exists(path.join(repo, ".agents", "skills", "auto-coding-skill", "obsolete.txt")), "extra Skill files must be removed");
|
|
425
|
-
assert(exists(path.join(repo, ".agents", "archive", "auto-coding-skill", "4.3.
|
|
426
|
-
assert(exists(path.join(repo, ".agents", "archive", "auto-coding-skill", "4.3.
|
|
425
|
+
assert(exists(path.join(repo, ".agents", "archive", "auto-coding-skill", "4.3.7", "docs", "legacy", "old-taskbook.md")), "removed docs must be archived outside active docs");
|
|
426
|
+
assert(exists(path.join(repo, ".agents", "archive", "auto-coding-skill", "4.3.7", "docs", "legacy", "orphan.bin")), "unowned legacy binary assets must still be archived");
|
|
427
427
|
assert(fs.readFileSync(structureStandard, "utf8") === customStructureStandard, "init must preserve a project-owned structure standard");
|
|
428
428
|
assert(fs.readFileSync(path.join(repo, "docs", "architecture", "adr", "0042-project-choice.md"), "utf8").includes("Keep me"), "numbered ADR artifacts must survive init");
|
|
429
429
|
assert(fs.readFileSync(path.join(repo, "docs", "architecture", "system-context.md"), "utf8").includes("Keep me"), "architecture artifacts must survive init");
|
|
@@ -538,12 +538,12 @@ function testManagedPolicySummaryPreservesProjectConfiguration() {
|
|
|
538
538
|
const legacySummary = "- `structure` and `optimization`: advisory architecture and no-new-debt policy.";
|
|
539
539
|
const installedOldDefault = current
|
|
540
540
|
.replace(/^ skill_version:.*$/m, " skill_version: 4.2.5")
|
|
541
|
-
.replace("managed-workflow:start version=4.3.
|
|
541
|
+
.replace("managed-workflow:start version=4.3.7", "managed-workflow:start version=4.2.5")
|
|
542
542
|
.replace(neutralSummary, legacySummary);
|
|
543
543
|
installTrustedEngineeringDefault(repo, installedOldDefault, "4.2.5");
|
|
544
544
|
const customized = current
|
|
545
545
|
.replace(/^ skill_version:.*$/m, " skill_version: 4.2.5")
|
|
546
|
-
.replace("managed-workflow:start version=4.3.
|
|
546
|
+
.replace("managed-workflow:start version=4.3.7", "managed-workflow:start version=4.2.5")
|
|
547
547
|
.replace(neutralSummary, legacySummary)
|
|
548
548
|
.replace(/^ enforcement:.*$/m, " enforcement: blocking")
|
|
549
549
|
.replace(" block_warnings: false", " block_warnings: true")
|
|
@@ -562,7 +562,7 @@ function testManagedPolicySummaryPreservesProjectConfiguration() {
|
|
|
562
562
|
const upgraded = fs.readFileSync(engineering, "utf8");
|
|
563
563
|
const managedAfterUpgrade = readEngineeringConfig(engineering);
|
|
564
564
|
const afterUpgrade = readEffectiveConfig(repo);
|
|
565
|
-
assert(managedAfterUpgrade.workflow?.skill_version === "4.3.
|
|
565
|
+
assert(managedAfterUpgrade.workflow?.skill_version === "4.3.7", "init must upgrade the managed workflow version");
|
|
566
566
|
assert(canonicalJson(afterUpgrade.structure) === canonicalJson(beforeUpgrade.structure), "init must preserve the complete project structure policy");
|
|
567
567
|
assert(canonicalJson(afterUpgrade.optimization) === canonicalJson(beforeUpgrade.optimization), "init must preserve the complete project optimization policy");
|
|
568
568
|
assert(upgraded.includes(neutralSummary), "upgraded managed text must defer to frontmatter policy");
|
|
@@ -1214,7 +1214,7 @@ function testTamperedInstalledDefaultRejectsInitAndSyncWithoutWrites() {
|
|
|
1214
1214
|
const skill = path.join(repo, ".agents", "skills", "auto-coding-skill", "SKILL.md");
|
|
1215
1215
|
const oldDefault = fs.readFileSync(engineering, "utf8")
|
|
1216
1216
|
.replace(/^ skill_version:.*$/m, ' skill_version: "4.2.7"')
|
|
1217
|
-
.replace("managed-workflow:start version=4.3.
|
|
1217
|
+
.replace("managed-workflow:start version=4.3.7", "managed-workflow:start version=4.2.7");
|
|
1218
1218
|
installTrustedEngineeringDefault(repo, oldDefault, "4.2.7");
|
|
1219
1219
|
writeFile(engineering, oldDefault);
|
|
1220
1220
|
fs.unlinkSync(overlay);
|
|
@@ -1503,7 +1503,7 @@ function testArchiveFallbackCollisionsNeverLosePreviousContent() {
|
|
|
1503
1503
|
const engineering = path.join(repo, "docs", "ENGINEERING.md");
|
|
1504
1504
|
fs.appendFileSync(engineering, "\n## Archive collision sentinel\n\nPreserve these ENGINEERING bytes.\n");
|
|
1505
1505
|
const previous = fs.readFileSync(engineering);
|
|
1506
|
-
const archiveDir = path.join(repo, ".agents", "archive", "auto-coding-skill", "4.3.
|
|
1506
|
+
const archiveDir = path.join(repo, ".agents", "archive", "auto-coding-skill", "4.3.7", "docs");
|
|
1507
1507
|
const preferred = path.join(archiveDir, "ENGINEERING.md");
|
|
1508
1508
|
const legacyDigest = path.join(archiveDir, `ENGINEERING-${digest12(previous)}.md`);
|
|
1509
1509
|
const occupiedPreferred = Buffer.from("occupied-engineering-default\n");
|
|
@@ -1533,7 +1533,7 @@ function testArchiveFallbackCollisionsNeverLosePreviousContent() {
|
|
|
1533
1533
|
".agents",
|
|
1534
1534
|
"archive",
|
|
1535
1535
|
"auto-coding-skill",
|
|
1536
|
-
"4.3.
|
|
1536
|
+
"4.3.7",
|
|
1537
1537
|
"docs",
|
|
1538
1538
|
"design",
|
|
1539
1539
|
);
|
|
@@ -1558,7 +1558,7 @@ function testArchiveFallbackCollisionsNeverLosePreviousContent() {
|
|
|
1558
1558
|
const agents = path.join(repo, "AGENTS.md");
|
|
1559
1559
|
const previous = Buffer.from("# Project AGENTS before sync\n\nPreserve this sync history.\n");
|
|
1560
1560
|
fs.writeFileSync(agents, previous);
|
|
1561
|
-
const archiveDir = path.join(repo, ".agents", "archive", "auto-coding-skill", "4.3.
|
|
1561
|
+
const archiveDir = path.join(repo, ".agents", "archive", "auto-coding-skill", "4.3.7");
|
|
1562
1562
|
const preferred = path.join(archiveDir, "AGENTS.md");
|
|
1563
1563
|
const legacyDigest = path.join(archiveDir, `AGENTS-${digest12(previous)}.md`);
|
|
1564
1564
|
const occupiedPreferred = Buffer.from("occupied-sync-default\n");
|
|
@@ -1580,7 +1580,7 @@ function testArchiveFallbackCollisionsNeverLosePreviousContent() {
|
|
|
1580
1580
|
const agents = path.join(repo, "AGENTS.md");
|
|
1581
1581
|
const previous = Buffer.from("# Project AGENTS before init\n\nPreserve this init history.\n");
|
|
1582
1582
|
fs.writeFileSync(agents, previous);
|
|
1583
|
-
const archiveDir = path.join(repo, ".agents", "archive", "auto-coding-skill", "4.3.
|
|
1583
|
+
const archiveDir = path.join(repo, ".agents", "archive", "auto-coding-skill", "4.3.7");
|
|
1584
1584
|
const preferred = path.join(archiveDir, "AGENTS.md");
|
|
1585
1585
|
const legacyDigest = path.join(archiveDir, `AGENTS-${digest12(previous)}.md`);
|
|
1586
1586
|
const occupiedPreferred = Buffer.from("occupied-init-default\n");
|
|
@@ -2210,7 +2210,7 @@ function testCliInstallArchivesFeedbackTemplatesAndPreservesReports() {
|
|
|
2210
2210
|
writeFile(report, reportContent);
|
|
2211
2211
|
|
|
2212
2212
|
run("node", [cli, "init"], { cwd: repo });
|
|
2213
|
-
const archive = path.join(repo, ".agents", "archive", "auto-coding-skill", "4.3.
|
|
2213
|
+
const archive = path.join(repo, ".agents", "archive", "auto-coding-skill", "4.3.7", "docs", "skill-feedback", "README.md");
|
|
2214
2214
|
assert(fs.readFileSync(feedbackReadme, "utf8").includes("Auto Coding Skill Feedback"), "transactional init must install the managed feedback README");
|
|
2215
2215
|
assert(fs.readFileSync(archive, "utf8") === previousReadme, "transactional init must archive a pre-existing feedback README before replacement");
|
|
2216
2216
|
assert(fs.readFileSync(report, "utf8") === reportContent, "transactional init must preserve project feedback reports byte-for-byte");
|
|
@@ -2319,21 +2319,21 @@ function testManagedEngineeringInitIsAuthoritativeAndIdempotent() {
|
|
|
2319
2319
|
const dryRun = run("node", [cli, "sync", "--projects", repo, "--dry-run", "--json"]);
|
|
2320
2320
|
const dryResult = JSON.parse(dryRun.stdout).results[0];
|
|
2321
2321
|
assert(dryResult.managedWorkflow.state === "stale", `dry-run should expose stale workflow state: ${dryRun.stdout}`);
|
|
2322
|
-
assert(dryResult.managedWorkflow.version === "4.3.
|
|
2322
|
+
assert(dryResult.managedWorkflow.version === "4.3.7", "dry-run should expose the target workflow version");
|
|
2323
2323
|
assert(dryResult.actions.some(item => item.action === "would-replace" && item.path === "docs/ENGINEERING.md"), "dry-run should plan exact replacement of the managed default document");
|
|
2324
2324
|
assert(fs.readFileSync(engineering, "utf8") === customized, "dry-run must not write ENGINEERING.md");
|
|
2325
2325
|
|
|
2326
2326
|
run("node", [cli, "init"], { cwd: repo });
|
|
2327
2327
|
const updated = fs.readFileSync(engineering, "utf8");
|
|
2328
2328
|
assert(!updated.includes("project note before") && !updated.includes("project note after"), "init must remove text outside the canonical ENGINEERING body");
|
|
2329
|
-
assert(updated.includes("version=4.3.
|
|
2329
|
+
assert(updated.includes("version=4.3.7"), "init should install the current managed workflow version");
|
|
2330
2330
|
assert(updated.includes("The frontmatter contract is:"), "init should refresh stale managed workflow content");
|
|
2331
2331
|
|
|
2332
2332
|
fillRequiredAccess(repo);
|
|
2333
2333
|
const status = run("node", [cli, "status", "--projects", repo, "--json"]);
|
|
2334
2334
|
const statusResult = JSON.parse(status.stdout).results[0];
|
|
2335
2335
|
assert(statusResult.managedWorkflow.state === "current", `status should expose current managed workflow state: ${status.stdout}`);
|
|
2336
|
-
assert(statusResult.managedWorkflow.version === "4.3.
|
|
2336
|
+
assert(statusResult.managedWorkflow.version === "4.3.7", "status should expose the installed managed workflow version");
|
|
2337
2337
|
|
|
2338
2338
|
const beforeSecondInit = fs.readFileSync(engineering, "utf8");
|
|
2339
2339
|
run("node", [cli, "init"], { cwd: repo });
|
|
@@ -2361,9 +2361,9 @@ function testLegacyEngineeringMigrationPreservesExistingBody() {
|
|
|
2361
2361
|
assert(dryResult.actions.some(item => item.action === "would-archive" && item.path.endsWith("/docs/ENGINEERING.md")), "custom legacy migration must plan archival before replacement");
|
|
2362
2362
|
run("node", [cli, "sync", "--projects", repo]);
|
|
2363
2363
|
const migrated = fs.readFileSync(engineering, "utf8");
|
|
2364
|
-
assert(migrated.includes("version=4.3.
|
|
2364
|
+
assert(migrated.includes("version=4.3.7"), "legacy migration should insert the current managed workflow");
|
|
2365
2365
|
assert(!migrated.includes(legacyNote), "legacy project text must not remain in the exact managed default document");
|
|
2366
|
-
const archive = path.join(repo, ".agents", "archive", "auto-coding-skill", "4.3.
|
|
2366
|
+
const archive = path.join(repo, ".agents", "archive", "auto-coding-skill", "4.3.7", "docs", "ENGINEERING.md");
|
|
2367
2367
|
assert(fs.readFileSync(archive, "utf8").includes(legacyNote), "legacy migration must preserve the complete previous body in history");
|
|
2368
2368
|
const stable = fs.readFileSync(engineering, "utf8");
|
|
2369
2369
|
run("node", [cli, "sync", "--projects", repo]);
|
|
@@ -2391,7 +2391,7 @@ function testOfficialLegacyEngineeringBodyIsReplacedWithoutDuplication() {
|
|
|
2391
2391
|
assert(migrated === canonicalEngineering, "official legacy migration must install the exact managed default document");
|
|
2392
2392
|
assert((migrated.match(/auto-coding-skill:managed-workflow:start/g) || []).length === 1, "official legacy migration should install exactly one managed workflow");
|
|
2393
2393
|
assert((migrated.match(/^## Execution profiles$/gm) || []).length === 0, "official legacy migration must remove the old duplicated workflow body");
|
|
2394
|
-
const archive = path.join(repo, ".agents", "archive", "auto-coding-skill", "4.3.
|
|
2394
|
+
const archive = path.join(repo, ".agents", "archive", "auto-coding-skill", "4.3.7", "docs", "ENGINEERING.md");
|
|
2395
2395
|
assert(fs.readFileSync(archive, "utf8").includes("## Execution profiles"), "official legacy body must remain available in the historical archive");
|
|
2396
2396
|
|
|
2397
2397
|
const stable = fs.readFileSync(engineering, "utf8");
|
|
@@ -2466,7 +2466,7 @@ function testManagedAgentsMigrationReplacesWholeFileAndArchivesPreviousRules() {
|
|
|
2466
2466
|
run("node", [cli, "sync", "--projects", repo]);
|
|
2467
2467
|
const agents = path.join(repo, "AGENTS.md");
|
|
2468
2468
|
const initial = fs.readFileSync(agents, "utf8");
|
|
2469
|
-
assert(initial.includes("managed-agents:start version=4.3.
|
|
2469
|
+
assert(initial.includes("managed-agents:start version=4.3.7"), "new projects should receive the versioned root AGENTS block");
|
|
2470
2470
|
|
|
2471
2471
|
const custom = [
|
|
2472
2472
|
"# Project rules",
|
|
@@ -2488,15 +2488,15 @@ function testManagedAgentsMigrationReplacesWholeFileAndArchivesPreviousRules() {
|
|
|
2488
2488
|
|
|
2489
2489
|
run("node", [cli, "sync", "--projects", repo]);
|
|
2490
2490
|
const migrated = fs.readFileSync(agents, "utf8");
|
|
2491
|
-
assert(migrated.includes("managed-agents:start version=4.3.
|
|
2491
|
+
assert(migrated.includes("managed-agents:start version=4.3.7"), "AGENTS migration should install the current managed block");
|
|
2492
2492
|
assert(!migrated.includes("Preserve this repository-specific rule exactly."), "root AGENTS must contain no project-specific tail");
|
|
2493
2493
|
assert(!migrated.includes("must execute `commands.gate_full`"), "known official conflicting rule should be removed");
|
|
2494
2494
|
const canonical = fs.readFileSync(path.join(repoRoot, "cli", "assets", "skill", "data", "templates", "bridges", "AGENTS.md"), "utf8");
|
|
2495
2495
|
assert(migrated === canonical, "root AGENTS must be byte-identical to the packaged canonical file");
|
|
2496
|
-
const archive = path.join(repo, ".agents", "archive", "auto-coding-skill", "4.3.
|
|
2496
|
+
const archive = path.join(repo, ".agents", "archive", "auto-coding-skill", "4.3.7", "AGENTS.md");
|
|
2497
2497
|
assert(fs.readFileSync(archive, "utf8").includes("Preserve this repository-specific rule exactly."), "previous AGENTS content must be archived once");
|
|
2498
2498
|
assert(!exists(legacyActiveArchive), "legacy active-doc AGENTS archives must leave docs/archive during upgrade");
|
|
2499
|
-
const migratedLegacyArchiveDir = path.join(repo, ".agents", "archive", "auto-coding-skill", "4.3.
|
|
2499
|
+
const migratedLegacyArchiveDir = path.join(repo, ".agents", "archive", "auto-coding-skill", "4.3.7", "docs", "archive", "workflow");
|
|
2500
2500
|
assert(
|
|
2501
2501
|
listProjectFiles(migratedLegacyArchiveDir).some(file => fs.readFileSync(file).equals(legacyActiveArchiveBytes)),
|
|
2502
2502
|
"legacy active-doc AGENTS archive bytes must survive under the managed archive root",
|
|
@@ -2554,7 +2554,7 @@ function testEngineeringMarkerBoundaryIsNormalized() {
|
|
|
2554
2554
|
const normalized = fs.readFileSync(engineering, "utf8");
|
|
2555
2555
|
assert(normalized === current, "sync should restore the exact managed document when text is glued to its end marker");
|
|
2556
2556
|
assert(!normalized.includes("# Project-specific workflow"), "project workflow text must not remain in the managed default document");
|
|
2557
|
-
const archive = path.join(repo, ".agents", "archive", "auto-coding-skill", "4.3.
|
|
2557
|
+
const archive = path.join(repo, ".agents", "archive", "auto-coding-skill", "4.3.7", "docs", "ENGINEERING.md");
|
|
2558
2558
|
assert(fs.readFileSync(archive, "utf8").includes(`${marker}# Project-specific workflow`), "the malformed previous document must remain available in history");
|
|
2559
2559
|
}
|
|
2560
2560
|
|
|
@@ -2571,7 +2571,7 @@ function testEngineeringFrameworkRejectsAnyNonCanonicalWorkflowText() {
|
|
|
2571
2571
|
|
|
2572
2572
|
run("node", [cli, "init"], { cwd: repo });
|
|
2573
2573
|
assert(!fs.readFileSync(engineering, "utf8").includes("backend owns APIs"), "init must restore the canonical ENGINEERING body");
|
|
2574
|
-
const archived = path.join(repo, ".agents", "archive", "auto-coding-skill", "4.3.
|
|
2574
|
+
const archived = path.join(repo, ".agents", "archive", "auto-coding-skill", "4.3.7", "docs", "ENGINEERING.md");
|
|
2575
2575
|
assert(fs.readFileSync(archived, "utf8").includes("backend owns APIs"), "removed project text should remain in non-authoritative history");
|
|
2576
2576
|
}
|
|
2577
2577
|
|
|
@@ -2583,12 +2583,12 @@ function testManagedInstallIntegrityIsBoundedAndRepairable() {
|
|
|
2583
2583
|
|
|
2584
2584
|
const manifestPath = path.join(repo, ".agents", "managed-install.json");
|
|
2585
2585
|
const manifest = JSON.parse(fs.readFileSync(manifestPath, "utf8"));
|
|
2586
|
-
assert(manifest.schema_version === 1 && manifest.skill_version === "4.3.
|
|
2586
|
+
assert(manifest.schema_version === 1 && manifest.skill_version === "4.3.7", "installed manifest must identify the release");
|
|
2587
2587
|
assert(manifest.entries.length > 0, "installed manifest must list managed files");
|
|
2588
2588
|
for (const entry of manifest.entries) {
|
|
2589
2589
|
assert(typeof entry.path === "string" && !path.isAbsolute(entry.path) && !entry.path.includes(".."), "manifest paths must be safe relative paths");
|
|
2590
2590
|
assert(/^[0-9a-f]{64}$/.test(entry.sha256), `${entry.path}: manifest hash must be sha256`);
|
|
2591
|
-
assert(entry.version === "4.3.
|
|
2591
|
+
assert(entry.version === "4.3.7" && typeof entry.executable === "boolean", `${entry.path}: version/executable metadata missing`);
|
|
2592
2592
|
}
|
|
2593
2593
|
assert(!manifest.managed_namespaces.some(item => item.path === ".agents" || item.path === "docs"), "manifest must not mirror entire project-owned trees");
|
|
2594
2594
|
|
|
@@ -2668,7 +2668,7 @@ function testSkillFeedbackCollectionIsBoundedReadOnlyAndMetadataOnly() {
|
|
|
2668
2668
|
run("node", [cli, "status", "--projects", third, "--json"], { check: false }).stdout,
|
|
2669
2669
|
).results[0];
|
|
2670
2670
|
assert(emptyStatus.feedback.available === true, "status must expose feedback before the first report");
|
|
2671
|
-
assert(emptyStatus.feedback.skillVersion === "4.3.
|
|
2671
|
+
assert(emptyStatus.feedback.skillVersion === "4.3.7", "empty feedback status must expose the installed Skill version");
|
|
2672
2672
|
const signature = `sha256:${"a".repeat(64)}`;
|
|
2673
2673
|
const marker = path.join(os.tmpdir(), `autocoding-feedback-must-not-execute-${crypto.randomUUID()}`);
|
|
2674
2674
|
const render = (project, reportId, privateMarker) => [
|
|
@@ -2678,7 +2678,7 @@ function testSkillFeedbackCollectionIsBoundedReadOnlyAndMetadataOnly() {
|
|
|
2678
2678
|
"status: open",
|
|
2679
2679
|
'created_at: "2026-07-18T10:00:00+08:00"',
|
|
2680
2680
|
`project: ${project}`,
|
|
2681
|
-
"observed_skill_version: 4.3.
|
|
2681
|
+
"observed_skill_version: 4.3.7",
|
|
2682
2682
|
"component: reviewer-runtime",
|
|
2683
2683
|
"kind: defect",
|
|
2684
2684
|
"impact: blocking",
|
|
@@ -2712,7 +2712,7 @@ function testSkillFeedbackCollectionIsBoundedReadOnlyAndMetadataOnly() {
|
|
|
2712
2712
|
.replace("schema: auto-coding-skill-feedback/v1", "schema: auto-coding-skill-feedback/v2")
|
|
2713
2713
|
.replace("status: open", `status: ${options.status ?? "open"}`)
|
|
2714
2714
|
.replace('created_at: "2026-07-18T10:00:00+08:00"', 'created_at: "2026-07-18T10:00:00+08:00"\nupdated_at: "2026-07-19T10:00:00+08:00"')
|
|
2715
|
-
.replace("observed_skill_version: 4.3.
|
|
2715
|
+
.replace("observed_skill_version: 4.3.7", `observed_skill_version: ${options.observed ?? "4.3.7"}\nlast_verified_skill_version: ${options.lastVerified ?? options.observed ?? "4.3.7"}`)
|
|
2716
2716
|
.replace(signature, options.signature)
|
|
2717
2717
|
.replace("export: metadata-only", `resolution: ${options.resolution ?? "pending"}\nexport: metadata-only`);
|
|
2718
2718
|
const firstReport = path.join(first, "docs", "skill-feedback", "reports", "2026-07-18-review-timeout-a13f82c1.md");
|
|
@@ -2776,7 +2776,7 @@ function testSkillFeedbackCollectionIsBoundedReadOnlyAndMetadataOnly() {
|
|
|
2776
2776
|
assert(lifecycleCheck.metadata.find(item => item.report_id === "ACSF-assets-20260718-fd5748e4")?.lifecycle === "regression-current", "a fixed signature reproduced on the fixed release must re-enter active triage as a regression");
|
|
2777
2777
|
writeFile(fixedReport, fixedContent);
|
|
2778
2778
|
|
|
2779
|
-
writeFile(firstOtherReport, firstOtherContent.replace("observed_skill_version: 4.3.
|
|
2779
|
+
writeFile(firstOtherReport, firstOtherContent.replace("observed_skill_version: 4.3.7", "observed_skill_version: 4.2.8"));
|
|
2780
2780
|
lifecycleCheck = JSON.parse(run("node", [cli, "feedback", "--projects", first, "--json"]).stdout);
|
|
2781
2781
|
assert(lifecycleCheck.metadata.find(item => item.report_id === "ACSF-geesight-20260718-c35fa4e3")?.lifecycle === "recheck-due", "an unresolved v1 report from an older Skill version must require recheck");
|
|
2782
2782
|
writeFile(firstOtherReport, firstOtherContent);
|
|
@@ -2826,14 +2826,14 @@ function testSkillFeedbackCollectionIsBoundedReadOnlyAndMetadataOnly() {
|
|
|
2826
2826
|
}
|
|
2827
2827
|
|
|
2828
2828
|
function testReleaseVersionMarkersStayInSync() {
|
|
2829
|
-
const expected = "4.3.
|
|
2829
|
+
const expected = "4.3.7";
|
|
2830
2830
|
const pkg = JSON.parse(fs.readFileSync(path.join(repoRoot, "package.json"), "utf8"));
|
|
2831
2831
|
const lock = JSON.parse(fs.readFileSync(path.join(repoRoot, "package-lock.json"), "utf8"));
|
|
2832
2832
|
const policy = JSON.parse(fs.readFileSync(
|
|
2833
2833
|
path.join(repoRoot, "src", "auto-coding-skill", "data", "policies", "workflow-migrations-v1.json"),
|
|
2834
2834
|
"utf8",
|
|
2835
2835
|
));
|
|
2836
|
-
assert(pkg.version === expected, "package version must match the 4.3.
|
|
2836
|
+
assert(pkg.version === expected, "package version must match the 4.3.7 release");
|
|
2837
2837
|
assert(lock.version === expected && lock.packages[""].version === expected, "package-lock versions must match");
|
|
2838
2838
|
assert(policy.managed_versions.engineering === expected && policy.managed_versions.agents === expected, "managed workflow versions must match");
|
|
2839
2839
|
const manifest = JSON.parse(fs.readFileSync(path.join(repoRoot, "cli", "assets", "managed-install.json"), "utf8"));
|
package/package.json
CHANGED
|
@@ -1,6 +1,6 @@
|
|
|
1
1
|
{
|
|
2
2
|
"name": "@elvis1513/auto-coding-skill",
|
|
3
|
-
"version": "4.3.
|
|
3
|
+
"version": "4.3.7",
|
|
4
4
|
"description": "CLI installer for a delivery-first .agents workflow with adaptive Git isolation, routed changed-scope validation, risk-based review, push completion, and safe cleanup.",
|
|
5
5
|
"type": "module",
|
|
6
6
|
"bin": {
|