@elvis1513/auto-coding-skill 4.3.4 → 4.3.6
This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
- package/README.md +25 -3
- package/cli/assets/managed-install.json +1 -1
- package/cli/assets/skill/SKILL.md +2 -1
- package/cli/assets/skill/data/policies/workflow-migrations-v1.json +2 -2
- package/cli/assets/skill/data/templates/ENGINEERING.md +2 -2
- package/cli/assets/skill/data/templates/bridges/AGENTS.md +4 -2
- package/cli/assets/skill/scripts/ap.py +293 -72
- package/cli/tests/ap_concurrency_test.py +126 -6
- package/cli/tests/core_shell_test.py +5 -5
- package/cli/tests/index.test.js +31 -31
- package/package.json +1 -1
package/README.md
CHANGED
|
@@ -9,6 +9,9 @@ The Skill is a selectable guardrail, not a command sequence that must run for
|
|
|
9
9
|
every task. The model skips machinery whose expected benefit does not exceed its
|
|
10
10
|
cost; read-only work and obvious small clean-checkout changes normally stay direct.
|
|
11
11
|
|
|
12
|
+
Version 4.3.6 accepts the exact equivalent artifact-access wording observed in
|
|
13
|
+
real 4.3.4 Reviewer evidence without broadening retry eligibility. Version 4.3.5 keeps retry artifact reads mutation-free and can repair the exact
|
|
14
|
+
untouched or procedurally blocked 4.3.4 retry once without rewriting evidence.
|
|
12
15
|
Version 4.3.4 adds one fail-closed, immutable-evidence retry for tasks whose
|
|
13
16
|
4.2.8-4.3.2 Reviewer was consumed solely by the fixed Git-local artifact access
|
|
14
17
|
defect. Version 4.3.3 resolves the first multi-project feedback batch: read-only
|
|
@@ -384,22 +387,25 @@ rerun and needs no force flag.
|
|
|
384
387
|
|
|
385
388
|
The only migration exception is an active 4.2.8-4.3.2 task whose completed
|
|
386
389
|
Reviewer result contains no findings and is blocked solely by the fixed
|
|
387
|
-
`review-artifact` Git-local permission error. Run the managed 4.3.
|
|
390
|
+
`review-artifact` Git-local permission error. Run the managed 4.3.6 runtime from
|
|
388
391
|
outside the project install to authorize one audited retry, then immediately run
|
|
389
392
|
the original Reviewer identity:
|
|
390
393
|
|
|
391
394
|
```bash
|
|
392
|
-
python3 /absolute/managed/4.3.
|
|
395
|
+
python3 /absolute/managed/4.3.6/ap.py --repo /path/project \
|
|
393
396
|
review-runtime-retry T0001 --diff-fingerprint <SHA256> \
|
|
394
397
|
--reason-code managed-review-artifact-access \
|
|
395
398
|
--confirm-managed-runtime-retry
|
|
396
|
-
python3 /absolute/managed/4.3.
|
|
399
|
+
python3 /absolute/managed/4.3.6/ap.py --repo /path/project \
|
|
397
400
|
review-run T0001 --reviewer <ORIGINAL_REVIEWER> --json
|
|
398
401
|
```
|
|
399
402
|
|
|
400
403
|
The command preserves the original assignment, patch, result, receipt, and event
|
|
401
404
|
log byte-for-byte. It refuses substantive findings, changed scope or fingerprint,
|
|
402
405
|
tampered evidence, user overrides, duplicate retries, and unmanaged runtimes.
|
|
406
|
+
If 4.3.4 already authorized the same retry, 4.3.5+ may supersede only an untouched
|
|
407
|
+
pending attempt or its exact non-substantive artifact-access block; both audit
|
|
408
|
+
chains and any prior runtime files remain immutable.
|
|
403
409
|
|
|
404
410
|
```bash
|
|
405
411
|
cd /path/a && autocoding init
|
|
@@ -413,6 +419,22 @@ model overrides, complete project `risk.rules`, supported project/access/
|
|
|
413
419
|
concurrency/route/structure values, and an existing project-owned structure
|
|
414
420
|
standard byte-for-byte. Removed content is archived outside active docs.
|
|
415
421
|
|
|
422
|
+
## What changed in 4.3.6
|
|
423
|
+
|
|
424
|
+
- Added the exact `review-artifact exited with:` evidence, summary, and risk
|
|
425
|
+
wording emitted by a real 4.3.4 Reviewer. Findings, changed paths, timeouts,
|
|
426
|
+
overrides, and every unrelated failure remain ineligible for migration.
|
|
427
|
+
|
|
428
|
+
## What changed in 4.3.5
|
|
429
|
+
|
|
430
|
+
- Stopped read-only `review-artifact` from recomputing the live task snapshot;
|
|
431
|
+
the writable supervisor remains responsible for the immediately pre-launch
|
|
432
|
+
HEAD, scope, and fingerprint check.
|
|
433
|
+
- Added one fail-closed repair for `retry-v4.3.4` when it is still untouched or
|
|
434
|
+
ended only in the known Git-local permission block. The repair publishes a new
|
|
435
|
+
audit and tokenized evidence while retaining and revalidating the full 4.3.4
|
|
436
|
+
audit chain.
|
|
437
|
+
|
|
416
438
|
## What changed in 4.3.4
|
|
417
439
|
|
|
418
440
|
- Added `review-runtime-retry`, a one-attempt migration for the exact
|
|
@@ -1 +1 @@
|
|
|
1
|
-
{"schema_version":1,"skill_version":"4.3.
|
|
1
|
+
{"schema_version":1,"skill_version":"4.3.6","manifest_path":".agents/managed-install.json","entries":[{"path":".agents/agents/browser-debugger.toml","source":"agents/browser-debugger.toml","ownership":"normalized-agent","sha256":"40727952944917eb0b573bb96dca2906c27bc794737f3b6b392b56df7b4208aa","executable":false,"scope":"shared","version":"4.3.6"},{"path":".agents/agents/docs-researcher.toml","source":"agents/docs-researcher.toml","ownership":"normalized-agent","sha256":"aa1fed6a6a1cde282fc152c7a88b8e097a6c53bcf447d35978607d594e3cb3e4","executable":false,"scope":"shared","version":"4.3.6"},{"path":".agents/agents/explorer.toml","source":"agents/explorer.toml","ownership":"normalized-agent","sha256":"4cd89888acf7c0c04fbbcd0b9a0f346c6efed42fb723ec2037af9331a84a1cac","executable":false,"scope":"shared","version":"4.3.6"},{"path":".agents/agents/fixer.toml","source":"agents/fixer.toml","ownership":"normalized-agent","sha256":"7bc00a45b9d1bcc90b8b0f06d773556eba1d52effff664472c3cb81073f6abfb","executable":false,"scope":"shared","version":"4.3.6"},{"path":".agents/agents/reviewer.toml","source":"agents/reviewer.toml","ownership":"normalized-agent","sha256":"e1ad676e608ffee04d782571fb9bfbc787f69c100941b1811d955ef80439db36","executable":false,"scope":"shared","version":"4.3.6"},{"path":".agents/skills/auto-coding-skill/SKILL.md","source":"skill/SKILL.md","ownership":"exact","sha256":"840ecfc86c9697ebcaa2d4295ae6140e4f510a06ed50e694b0f757d83149c3ac","executable":false,"scope":"shared","version":"4.3.6"},{"path":".agents/skills/auto-coding-skill/data/contracts/orchestration-v1.schema.json","source":"skill/data/contracts/orchestration-v1.schema.json","ownership":"exact","sha256":"65a8c0d222b26f224794ec106101f903f0e3a357b249c2df22c5908a476a6835","executable":false,"scope":"shared","version":"4.3.6"},{"path":".agents/skills/auto-coding-skill/data/policies/feedback-resolutions-v1.json","source":"skill/data/policies/feedback-resolutions-v1.json","ownership":"exact","sha256":"6305c1ea8d1f4f137e606bb0277e041d6ad6792dc63be6eba642df7269d75bf7","executable":false,"scope":"shared","version":"4.3.6"},{"path":".agents/skills/auto-coding-skill/data/policies/workflow-migrations-v1.json","source":"skill/data/policies/workflow-migrations-v1.json","ownership":"exact","sha256":"250a44e09d68ff536afc74c584f7db8b5b75ebbbaccc945d36cbcfe0bd2a00d3","executable":false,"scope":"shared","version":"4.3.6"},{"path":".agents/skills/auto-coding-skill/data/templates/ENGINEERING.md","source":"skill/data/templates/ENGINEERING.md","ownership":"exact","sha256":"fadd43723aa4b311e8f52da5d641189ee59cda7cb58a4184dafd61548d4d616c","executable":false,"scope":"shared","version":"4.3.6"},{"path":".agents/skills/auto-coding-skill/data/templates/bridges/AGENTS.md","source":"skill/data/templates/bridges/AGENTS.md","ownership":"exact","sha256":"ccca34127a19d38a069d1c6e1586bdaee30f1a49c29f52a909dda5c745302dbf","executable":false,"scope":"shared","version":"4.3.6"},{"path":".agents/skills/auto-coding-skill/data/templates/tools/ap.py","source":"skill/data/templates/tools/ap.py","ownership":"exact","sha256":"c352fbf2cbcb9692a34fd952d8541b1cbe6d475c6e11e64500a1f6b5283a00be","executable":false,"scope":"shared","version":"4.3.6"},{"path":".agents/skills/auto-coding-skill/requirements.txt","source":"skill/requirements.txt","ownership":"exact","sha256":"0969da99a0bc2a1b71ed50584560f4588a37567ac63af3ddbaf3c4617ca5621a","executable":false,"scope":"shared","version":"4.3.6"},{"path":".agents/skills/auto-coding-skill/scripts/ap.py","source":"skill/scripts/ap.py","ownership":"exact","sha256":"542acba692d82ebf767d44fac3aff1eb526dde1bf98074eb3e8da1fbd3bc9c80","executable":false,"scope":"shared","version":"4.3.6"},{"path":".agents/skills/auto-coding-skill/scripts/core.py","source":"skill/scripts/core.py","ownership":"exact","sha256":"caefca925929bad840c3471b86332d4be48b5e19ad0ff79fde1dcedef0297c16","executable":true,"scope":"shared","version":"4.3.6"},{"path":".agents/skills/auto-coding-skill/scripts/http_checks.py","source":"skill/scripts/http_checks.py","ownership":"exact","sha256":"5620e187a0129f135621425a84b3a4e8f31137263c7e549a36a801fc36ff54ea","executable":false,"scope":"shared","version":"4.3.6"},{"path":".agents/skills/auto-coding-skill/scripts/install_integrity.py","source":"skill/scripts/install_integrity.py","ownership":"exact","sha256":"41a2df7935027fb43cfcb3d18e57a7f33adc4861420ff43c8828743ad71cc429","executable":false,"scope":"shared","version":"4.3.6"},{"path":".agents/skills/auto-coding-skill/scripts/scaffold_templates.py","source":"skill/scripts/scaffold_templates.py","ownership":"exact","sha256":"7f25761cc065bb8c2875c8c99bea9077d339dedae81aeeddfab1c35f4cf054b3","executable":false,"scope":"shared","version":"4.3.6"},{"path":"AGENTS.md","source":"skill/data/templates/bridges/AGENTS.md","ownership":"exact","sha256":"ccca34127a19d38a069d1c6e1586bdaee30f1a49c29f52a909dda5c745302dbf","executable":false,"scope":"project","version":"4.3.6"},{"path":"docs/ENGINEERING.md","source":"skill/data/templates/ENGINEERING.md","ownership":"exact","sha256":"fadd43723aa4b311e8f52da5d641189ee59cda7cb58a4184dafd61548d4d616c","executable":false,"scope":"project","version":"4.3.6"},{"path":"docs/architecture/adr/_TEMPLATE-ADR.md","source":"generated:scaffold_templates:docs/architecture/adr/_TEMPLATE-ADR.md","ownership":"exact","sha256":"88c89065ae0f8555412dbe096c05342152efc7becae8d8981e6442cdfee8e672","executable":false,"scope":"project","version":"4.3.6"},{"path":"docs/deployment/deploy-records/_TEMPLATE-DEPLOY-RECORD.md","source":"generated:scaffold_templates:docs/deployment/deploy-records/_TEMPLATE-DEPLOY-RECORD.md","ownership":"exact","sha256":"f2c17c0febc322b0ad50fb9d6f7e64e6c0cfb15c8a3e445a99da40f0a0dd1901","executable":false,"scope":"project","version":"4.3.6"},{"path":"docs/design/_TEMPLATE-DD.md","source":"generated:scaffold_templates:docs/design/_TEMPLATE-DD.md","ownership":"exact","sha256":"6ca022d127bfff68521f466b60bace4f1206baf0913daa855b9f751e74198db3","executable":false,"scope":"project","version":"4.3.6"},{"path":"docs/reviews/_TEMPLATE-REVIEW.md","source":"generated:scaffold_templates:docs/reviews/_TEMPLATE-REVIEW.md","ownership":"exact","sha256":"134f0d1bd3c7a317ef3cf4c2aea9f0539f3d53dccd5bcdabf6915b3629ef8802","executable":false,"scope":"project","version":"4.3.6"},{"path":"docs/skill-feedback/README.md","source":"generated:scaffold_templates:docs/skill-feedback/README.md","ownership":"exact","sha256":"3b146e1b7e7a1d4af57635307b825b38ce7bc58d1ee5f98871c877a64936edab","executable":false,"scope":"project","version":"4.3.6"},{"path":"docs/skill-feedback/_TEMPLATE-SKILL-FEEDBACK.md","source":"generated:scaffold_templates:docs/skill-feedback/_TEMPLATE-SKILL-FEEDBACK.md","ownership":"exact","sha256":"90ff26074305f8da537892060ffbc3a0206841702ed0483545e4ebe84e3ff357","executable":false,"scope":"project","version":"4.3.6"},{"path":"docs/tools/autopipeline/ap.py","source":"skill/data/templates/tools/ap.py","ownership":"exact","sha256":"c352fbf2cbcb9692a34fd952d8541b1cbe6d475c6e11e64500a1f6b5283a00be","executable":false,"scope":"project","version":"4.3.6"}],"managed_namespaces":[{"path":".agents/skills/auto-coding-skill","scope":"shared"},{"path":"docs/tools/autopipeline","scope":"project"}],"preserved":[".agents/archive/**",".agents/agents/* (except paths listed in entries)","docs/project/auto-coding-skill.yaml","docs/architecture/structure-standard.md","docs/architecture/** (except exact-managed entries)","docs/bugs/** (except exact-managed entries)","docs/deployment/** (except exact-managed entries)","docs/design/** (except exact-managed entries)","docs/interfaces/** (except exact-managed entries)","docs/project/** (except exact-managed entries)","docs/reviews/** (except exact-managed entries)","docs/testing/** (except exact-managed entries)","docs/skill-feedback/reports/*.md"]}
|
|
@@ -64,7 +64,8 @@ permission defect with no findings. The lifecycle owner must supply the unchange
|
|
|
64
64
|
fingerprint and fixed reason code from a strictly newer managed runtime; the
|
|
65
65
|
original Reviewer identity then runs once against a create-only audit and fresh
|
|
66
66
|
fixed deadline. This migration never renews an ordinary timeout or substantive
|
|
67
|
-
review result.
|
|
67
|
+
review result. A 4.3.5+ runtime may repair only an untouched `retry-v4.3.4` or its
|
|
68
|
+
exact non-substantive artifact-access block, preserving both audit generations.
|
|
68
69
|
|
|
69
70
|
## Close with the bounded routed gate
|
|
70
71
|
|
|
@@ -1,6 +1,6 @@
|
|
|
1
1
|
---
|
|
2
2
|
workflow:
|
|
3
|
-
skill_version: "4.3.
|
|
3
|
+
skill_version: "4.3.6"
|
|
4
4
|
mode: "dev"
|
|
5
5
|
profile: "auto"
|
|
6
6
|
completion: "push"
|
|
@@ -83,7 +83,7 @@ docs:
|
|
|
83
83
|
api_change_log: "docs/interfaces/api-change-log.md"
|
|
84
84
|
---
|
|
85
85
|
# Engineering Configuration and Project Facts
|
|
86
|
-
<!-- auto-coding-skill:managed-workflow:start version=4.3.
|
|
86
|
+
<!-- auto-coding-skill:managed-workflow:start version=4.3.6 -->
|
|
87
87
|
Root `AGENTS.md` is the single shared behavioral protocol. The installed
|
|
88
88
|
`SKILL.md` contains invocation guidance. This whole file is the managed default
|
|
89
89
|
configuration contract. Project-owned values live only in
|
|
@@ -1,4 +1,4 @@
|
|
|
1
|
-
<!-- auto-coding-skill:managed-agents:start version=4.3.
|
|
1
|
+
<!-- auto-coding-skill:managed-agents:start version=4.3.6 -->
|
|
2
2
|
# Shared Engineering Protocol
|
|
3
3
|
|
|
4
4
|
This file is fully managed by `auto-coding-skill`. Keep project-specific facts in
|
|
@@ -94,7 +94,9 @@ failure may continue in the same conversation/task without a second lifecycle.
|
|
|
94
94
|
consumed solely by the fixed Git-local artifact permission defect. It requires
|
|
95
95
|
the lifecycle owner, unchanged fingerprint, original Reviewer, a strictly newer
|
|
96
96
|
managed runtime, and the fixed reason code; it preserves all old evidence and
|
|
97
|
-
permits one audited attempt.
|
|
97
|
+
permits one audited attempt. A 4.3.5+ runtime may repair only an untouched
|
|
98
|
+
`retry-v4.3.4` or its exact non-substantive artifact-access block, with both
|
|
99
|
+
audit generations retained. Never use it for timeouts, findings, changed scope,
|
|
98
100
|
user overrides, or general Reviewer failures.
|
|
99
101
|
- Block only new or worsened in-scope P0/P1 defects. Adjacent debt is a follow-up;
|
|
100
102
|
semantic changes invalidate approval, while mechanical docs may get a targeted recheck.
|
|
@@ -108,6 +108,7 @@ _REVIEW_RUNTIME_RETRY_REASON = "managed-review-artifact-access"
|
|
|
108
108
|
_REVIEW_RUNTIME_RETRY_AFFECTED_MIN = (4, 2, 8)
|
|
109
109
|
_REVIEW_RUNTIME_RETRY_AFFECTED_MAX = (4, 3, 2)
|
|
110
110
|
_REVIEW_RUNTIME_RETRY_FIXED_IN = (4, 3, 4)
|
|
111
|
+
_REVIEW_RUNTIME_RETRY_REPAIRED_IN = (4, 3, 5)
|
|
111
112
|
_REVIEW_OUTPUT_MAX_BYTES = 1024 * 1024
|
|
112
113
|
_REVIEW_DIFF_ARTIFACT_FORMAT = "git-binary-patch-v1"
|
|
113
114
|
_REVIEW_DIFF_ARTIFACT_MAX_BYTES = 64 * 1024 * 1024
|
|
@@ -299,7 +300,7 @@ _FINAL_GATE_CACHE_ALGORITHM = "final-gate-v1"
|
|
|
299
300
|
_WORKFLOW_MIGRATION_POLICY = Path("data/policies/workflow-migrations-v1.json")
|
|
300
301
|
_FALLBACK_WORKFLOW_MIGRATION_POLICY = {
|
|
301
302
|
"schema_version": 1,
|
|
302
|
-
"managed_versions": {"agents": "4.3.
|
|
303
|
+
"managed_versions": {"agents": "4.3.6", "engineering": "4.3.6"},
|
|
303
304
|
"known_official_engineering_body_sha256": [
|
|
304
305
|
"d1306cc626e8baf8c83c953b760fd771066de2bf125168eca3a7b7d6ff2b87a2",
|
|
305
306
|
"305931c6edef770033a4f1970b00e5fb1c1728351856a173dbfa497daf563021",
|
|
@@ -14066,6 +14067,7 @@ def cmd_review_artifact(args: argparse.Namespace) -> None:
|
|
|
14066
14067
|
assignment,
|
|
14067
14068
|
require_environment=bool(_review_attempt_token(manifest.get("review") or {})),
|
|
14068
14069
|
require_same_runtime=bool(_review_attempt_token(manifest.get("review") or {})),
|
|
14070
|
+
verify_worktree_snapshot=False,
|
|
14069
14071
|
)
|
|
14070
14072
|
if _dt.datetime.now(_dt.timezone.utc) >= deadline:
|
|
14071
14073
|
raise APError("Review assignment deadline expired before diff artifact access.")
|
|
@@ -14255,6 +14257,7 @@ def _load_review_runtime_retry_audit(
|
|
|
14255
14257
|
*,
|
|
14256
14258
|
require_environment: bool = False,
|
|
14257
14259
|
require_same_runtime: bool = False,
|
|
14260
|
+
verify_worktree_snapshot: bool = True,
|
|
14258
14261
|
) -> Optional[dict]:
|
|
14259
14262
|
review = manifest.get("review") or {}
|
|
14260
14263
|
token = _review_attempt_token(review)
|
|
@@ -14312,11 +14315,14 @@ def _load_review_runtime_retry_audit(
|
|
|
14312
14315
|
raise APError(
|
|
14313
14316
|
"Reviewer runtime retry audit does not match task state: " + ", ".join(mismatched)
|
|
14314
14317
|
)
|
|
14315
|
-
|
|
14316
|
-
|
|
14317
|
-
|
|
14318
|
-
|
|
14319
|
-
|
|
14318
|
+
if verify_worktree_snapshot:
|
|
14319
|
+
worktree = Path(_text(manifest.get("worktree_path"))).resolve()
|
|
14320
|
+
if not worktree.exists() or _resolve_commit(worktree, "HEAD") != _text(
|
|
14321
|
+
assignment.get("diff_head")
|
|
14322
|
+
):
|
|
14323
|
+
raise APError("Reviewer runtime retry task HEAD changed after authorization.")
|
|
14324
|
+
if _task_review_fingerprint(worktree, manifest, _load_cfg(worktree)) != fingerprint:
|
|
14325
|
+
raise APError("Reviewer runtime retry diff changed after authorization.")
|
|
14320
14326
|
retry_result_path, retry_receipt_path = _review_runtime_paths(
|
|
14321
14327
|
control_repo,
|
|
14322
14328
|
task_id,
|
|
@@ -14361,6 +14367,106 @@ def _load_review_runtime_retry_audit(
|
|
|
14361
14367
|
if path != expected_path:
|
|
14362
14368
|
raise APError(f"Reviewer runtime retry {label} path is not canonical.")
|
|
14363
14369
|
_read_verified_private_review_file(path, _text(audit.get(f"{field}_sha256")), label)
|
|
14370
|
+
superseded_token = _text(audit.get("superseded_retry_token"))
|
|
14371
|
+
if superseded_token:
|
|
14372
|
+
if superseded_token != "retry-v4.3.4":
|
|
14373
|
+
raise APError("Reviewer runtime repair may supersede only retry-v4.3.4.")
|
|
14374
|
+
superseded_audit_path = _review_runtime_retry_audit_path(
|
|
14375
|
+
control_repo,
|
|
14376
|
+
task_id,
|
|
14377
|
+
fingerprint,
|
|
14378
|
+
superseded_token,
|
|
14379
|
+
create=False,
|
|
14380
|
+
).resolve()
|
|
14381
|
+
if Path(_text(audit.get("superseded_retry_audit_path"))).resolve() != superseded_audit_path:
|
|
14382
|
+
raise APError("Superseded Reviewer retry audit path is not canonical.")
|
|
14383
|
+
superseded_payload = _read_verified_private_review_file(
|
|
14384
|
+
superseded_audit_path,
|
|
14385
|
+
_text(audit.get("superseded_retry_audit_sha256")),
|
|
14386
|
+
"superseded runtime retry audit",
|
|
14387
|
+
)
|
|
14388
|
+
try:
|
|
14389
|
+
superseded_audit = json.loads(superseded_payload.decode("utf-8"))
|
|
14390
|
+
except (UnicodeDecodeError, json.JSONDecodeError) as exc:
|
|
14391
|
+
raise APError("Superseded Reviewer runtime retry audit is invalid JSON.") from exc
|
|
14392
|
+
superseded_result_path, superseded_receipt_path = _review_runtime_paths(
|
|
14393
|
+
control_repo,
|
|
14394
|
+
task_id,
|
|
14395
|
+
fingerprint,
|
|
14396
|
+
superseded_token,
|
|
14397
|
+
create=False,
|
|
14398
|
+
)
|
|
14399
|
+
superseded_event_path = _review_runtime_event_log_path(
|
|
14400
|
+
control_repo,
|
|
14401
|
+
task_id,
|
|
14402
|
+
fingerprint,
|
|
14403
|
+
superseded_token,
|
|
14404
|
+
create=False,
|
|
14405
|
+
)
|
|
14406
|
+
superseded_expected = {
|
|
14407
|
+
"schema": 1,
|
|
14408
|
+
"reason_code": _REVIEW_RUNTIME_RETRY_REASON,
|
|
14409
|
+
"task_id": task_id,
|
|
14410
|
+
"task_uuid": _text(manifest.get("task_uuid")),
|
|
14411
|
+
"owner": _text(manifest.get("owner")),
|
|
14412
|
+
"reviewer": _text(review.get("reviewer")),
|
|
14413
|
+
"task_skill_version": _text(manifest.get("skill_version")),
|
|
14414
|
+
"base_sha": _text(manifest.get("base_sha")),
|
|
14415
|
+
"diff_head": _text(assignment.get("diff_head")),
|
|
14416
|
+
"diff_fingerprint": fingerprint,
|
|
14417
|
+
"scope_revision": int(manifest.get("scope_revision") or 1),
|
|
14418
|
+
"owned_paths": list(manifest.get("owned_paths") or []),
|
|
14419
|
+
"retry_token": superseded_token,
|
|
14420
|
+
"assignment_path": str(
|
|
14421
|
+
_review_assignment_path(control_repo, task_id, fingerprint).resolve()
|
|
14422
|
+
),
|
|
14423
|
+
"assignment_sha256": _text(review.get("assignment_sha256")),
|
|
14424
|
+
"diff_artifact_path": str(
|
|
14425
|
+
_review_diff_artifact_path(control_repo, task_id, fingerprint).resolve()
|
|
14426
|
+
),
|
|
14427
|
+
"diff_artifact_sha256": _text(review.get("diff_artifact_sha256")),
|
|
14428
|
+
"original_deadline_at": _text(assignment.get("deadline_at")),
|
|
14429
|
+
"managed_runtime_version": "4.3.4",
|
|
14430
|
+
"retry_result_path": str(superseded_result_path.resolve()),
|
|
14431
|
+
"retry_receipt_path": str(superseded_receipt_path.resolve()),
|
|
14432
|
+
"retry_event_log_path": str(superseded_event_path.resolve()),
|
|
14433
|
+
}
|
|
14434
|
+
superseded_mismatched = [
|
|
14435
|
+
field
|
|
14436
|
+
for field, value in superseded_expected.items()
|
|
14437
|
+
if not isinstance(superseded_audit, dict) or superseded_audit.get(field) != value
|
|
14438
|
+
]
|
|
14439
|
+
if superseded_mismatched:
|
|
14440
|
+
raise APError(
|
|
14441
|
+
"Superseded Reviewer runtime retry audit does not match task state: "
|
|
14442
|
+
+ ", ".join(superseded_mismatched)
|
|
14443
|
+
)
|
|
14444
|
+
superseded_state = _text(audit.get("superseded_retry_state"))
|
|
14445
|
+
if superseded_state == "pending":
|
|
14446
|
+
if any(
|
|
14447
|
+
path.exists() or path.is_symlink()
|
|
14448
|
+
for path in (
|
|
14449
|
+
superseded_result_path,
|
|
14450
|
+
superseded_receipt_path,
|
|
14451
|
+
superseded_event_path,
|
|
14452
|
+
)
|
|
14453
|
+
):
|
|
14454
|
+
raise APError("Superseded pending Reviewer retry unexpectedly has runtime evidence.")
|
|
14455
|
+
elif superseded_state == "blocked":
|
|
14456
|
+
for field, path, label in (
|
|
14457
|
+
("superseded_retry_result", superseded_result_path, "superseded retry result"),
|
|
14458
|
+
("superseded_retry_receipt", superseded_receipt_path, "superseded retry receipt"),
|
|
14459
|
+
("superseded_retry_event_log", superseded_event_path, "superseded retry event log"),
|
|
14460
|
+
):
|
|
14461
|
+
if Path(_text(audit.get(f"{field}_path"))).resolve() != path.resolve():
|
|
14462
|
+
raise APError(f"Reviewer runtime repair {label} path is not canonical.")
|
|
14463
|
+
_read_verified_private_review_file(
|
|
14464
|
+
path,
|
|
14465
|
+
_text(audit.get(f"{field}_sha256")),
|
|
14466
|
+
label,
|
|
14467
|
+
)
|
|
14468
|
+
else:
|
|
14469
|
+
raise APError("Reviewer runtime repair has an invalid superseded retry state.")
|
|
14364
14470
|
issued = _parse_iso_timestamp(audit.get("retry_issued_at"), "retry_issued_at")
|
|
14365
14471
|
deadline = _parse_iso_timestamp(audit.get("retry_deadline_at"), "retry_deadline_at")
|
|
14366
14472
|
timeout_seconds = int(audit.get("retry_timeout_seconds") or 0)
|
|
@@ -14408,6 +14514,7 @@ def _effective_review_deadline(
|
|
|
14408
14514
|
*,
|
|
14409
14515
|
require_environment: bool = False,
|
|
14410
14516
|
require_same_runtime: bool = False,
|
|
14517
|
+
verify_worktree_snapshot: bool = True,
|
|
14411
14518
|
) -> _dt.datetime:
|
|
14412
14519
|
audit = _load_review_runtime_retry_audit(
|
|
14413
14520
|
control_repo,
|
|
@@ -14415,6 +14522,7 @@ def _effective_review_deadline(
|
|
|
14415
14522
|
assignment,
|
|
14416
14523
|
require_environment=require_environment,
|
|
14417
14524
|
require_same_runtime=require_same_runtime,
|
|
14525
|
+
verify_worktree_snapshot=verify_worktree_snapshot,
|
|
14418
14526
|
)
|
|
14419
14527
|
if audit is None:
|
|
14420
14528
|
return _parse_iso_timestamp(assignment.get("deadline_at"), "deadline_at")
|
|
@@ -14760,7 +14868,7 @@ def _known_review_artifact_access_failure(
|
|
|
14760
14868
|
return False
|
|
14761
14869
|
state_root = re.escape(str(_task_state_root(control_repo).resolve()))
|
|
14762
14870
|
pattern = re.compile(
|
|
14763
|
-
r"^review-artifact exited(?: with code)? 2: Cannot protect Git-local review storage"
|
|
14871
|
+
r"^review-artifact exited(?:(?: with code)? 2:| with:) Cannot protect Git-local review storage"
|
|
14764
14872
|
rf"(?: at |: ){state_root}: (?:\[Errno 1\] )?Operation not permitted\.?$"
|
|
14765
14873
|
)
|
|
14766
14874
|
if not pattern.fullmatch(evidence[0]):
|
|
@@ -14772,6 +14880,7 @@ def _known_review_artifact_access_failure(
|
|
|
14772
14880
|
"Review could not begin because review-artifact failed before emitting the verified immutable patch: the read-only sandbox denied protection of Git-local review storage.",
|
|
14773
14881
|
"Review could not begin because the mandatory frozen artifact verification failed under the read-only filesystem.",
|
|
14774
14882
|
"Review could not begin because review-artifact failed before emitting the immutable patch.",
|
|
14883
|
+
"Review could not begin because review-artifact failed to verify and emit the immutable patch.",
|
|
14775
14884
|
}
|
|
14776
14885
|
if _text(result.get("summary")) not in summaries:
|
|
14777
14886
|
return False
|
|
@@ -14783,6 +14892,7 @@ def _known_review_artifact_access_failure(
|
|
|
14783
14892
|
"The frozen diff was not emitted or substantively reviewed; no correctness or security conclusion is available.",
|
|
14784
14893
|
"The immutable patch was neither verified nor analyzed; no substantive correctness or security conclusion is available.",
|
|
14785
14894
|
"The immutable patch was not emitted or substantively reviewed.",
|
|
14895
|
+
"The SHA-256-bound frozen diff was not emitted or reviewed, so no substantive correctness or security conclusion is available.",
|
|
14786
14896
|
}
|
|
14787
14897
|
if not isinstance(risks, list) or len(risks) != 1 or risks[0] not in allowed_risks:
|
|
14788
14898
|
return False
|
|
@@ -14831,8 +14941,16 @@ def cmd_review_runtime_retry(args: argparse.Namespace) -> None:
|
|
|
14831
14941
|
if runtime_version_tuple <= task_version_tuple:
|
|
14832
14942
|
raise APError("Managed Reviewer retry runtime must be newer than the task runtime.")
|
|
14833
14943
|
review = dict(manifest.get("review") or {})
|
|
14834
|
-
|
|
14944
|
+
existing_token = _review_attempt_token(review)
|
|
14945
|
+
repairing_retry = existing_token == "retry-v4.3.4"
|
|
14946
|
+
if existing_token and (
|
|
14947
|
+
not repairing_retry or runtime_version_tuple < _REVIEW_RUNTIME_RETRY_REPAIRED_IN
|
|
14948
|
+
):
|
|
14835
14949
|
raise APError("A Reviewer runtime retry is already authorized for this diff fingerprint.")
|
|
14950
|
+
if not existing_token and any(
|
|
14951
|
+
_text(review.get(field)) for field in _REVIEW_RETRY_FIELDS
|
|
14952
|
+
):
|
|
14953
|
+
raise APError("Reviewer runtime retry state is incomplete.")
|
|
14836
14954
|
if _text(review.get("runtime_override_path")) or _text(review.get("runtime_override_sha256")):
|
|
14837
14955
|
raise APError("Reviewer runtime retry cannot follow a user-authorized runtime override.")
|
|
14838
14956
|
fingerprint = _task_review_fingerprint(worktree, manifest, _load_cfg(worktree))
|
|
@@ -14842,14 +14960,6 @@ def cmd_review_runtime_retry(args: argparse.Namespace) -> None:
|
|
|
14842
14960
|
f"Reviewer runtime retry fingerprint mismatch: supplied={supplied or '(missing)'}, "
|
|
14843
14961
|
f"current={fingerprint}."
|
|
14844
14962
|
)
|
|
14845
|
-
if (
|
|
14846
|
-
_text(review.get("verdict")) != "blocked"
|
|
14847
|
-
or _text(review.get("runtime_state")) != "blocked"
|
|
14848
|
-
or review.get("runtime_exit_code") != 0
|
|
14849
|
-
or _text(review.get("runtime_failure_kind"))
|
|
14850
|
-
or int(review.get("runtime_attempt_count") or 0) != 1
|
|
14851
|
-
):
|
|
14852
|
-
raise APError("Prior Reviewer state is not the exact completed procedural block eligible for retry.")
|
|
14853
14963
|
assignment_path = Path(_text(review.get("assignment_path"))).resolve()
|
|
14854
14964
|
assignment = _load_bound_review_assignment(control_repo, manifest, assignment_path)
|
|
14855
14965
|
_validate_review_diff_artifact(control_repo, assignment)
|
|
@@ -14871,55 +14981,139 @@ def cmd_review_runtime_retry(args: argparse.Namespace) -> None:
|
|
|
14871
14981
|
"Prior Reviewer assignment no longer matches task state: "
|
|
14872
14982
|
+ ", ".join(assignment_mismatches)
|
|
14873
14983
|
)
|
|
14874
|
-
|
|
14875
|
-
|
|
14876
|
-
|
|
14877
|
-
|
|
14878
|
-
|
|
14879
|
-
|
|
14880
|
-
|
|
14881
|
-
|
|
14882
|
-
|
|
14883
|
-
|
|
14884
|
-
|
|
14885
|
-
|
|
14886
|
-
|
|
14887
|
-
|
|
14888
|
-
|
|
14889
|
-
|
|
14890
|
-
|
|
14891
|
-
|
|
14892
|
-
|
|
14893
|
-
|
|
14894
|
-
|
|
14895
|
-
|
|
14896
|
-
|
|
14897
|
-
|
|
14898
|
-
|
|
14899
|
-
|
|
14900
|
-
|
|
14901
|
-
|
|
14902
|
-
|
|
14903
|
-
|
|
14904
|
-
|
|
14905
|
-
|
|
14906
|
-
|
|
14907
|
-
|
|
14908
|
-
|
|
14909
|
-
|
|
14910
|
-
|
|
14911
|
-
|
|
14912
|
-
|
|
14913
|
-
|
|
14914
|
-
|
|
14915
|
-
|
|
14916
|
-
|
|
14917
|
-
|
|
14918
|
-
|
|
14919
|
-
|
|
14984
|
+
superseded_audit: Optional[dict] = None
|
|
14985
|
+
superseded_state = ""
|
|
14986
|
+
if repairing_retry:
|
|
14987
|
+
superseded_audit = _load_review_runtime_retry_audit(
|
|
14988
|
+
control_repo,
|
|
14989
|
+
manifest,
|
|
14990
|
+
assignment,
|
|
14991
|
+
)
|
|
14992
|
+
if (
|
|
14993
|
+
not superseded_audit
|
|
14994
|
+
or _text(superseded_audit.get("managed_runtime_version")) != "4.3.4"
|
|
14995
|
+
):
|
|
14996
|
+
raise APError("Only the exact 4.3.4 managed retry may be repaired.")
|
|
14997
|
+
retry_paths = (*_review_runtime_paths(
|
|
14998
|
+
control_repo,
|
|
14999
|
+
task_id,
|
|
15000
|
+
fingerprint,
|
|
15001
|
+
existing_token,
|
|
15002
|
+
create=False,
|
|
15003
|
+
), _review_runtime_event_log_path(
|
|
15004
|
+
control_repo,
|
|
15005
|
+
task_id,
|
|
15006
|
+
fingerprint,
|
|
15007
|
+
existing_token,
|
|
15008
|
+
create=False,
|
|
15009
|
+
))
|
|
15010
|
+
if (
|
|
15011
|
+
_text(review.get("verdict")) == "pending"
|
|
15012
|
+
and _text(review.get("reason")) == "bounded managed runtime retry authorized"
|
|
15013
|
+
and not any(field in review for field in _REVIEW_RUNTIME_FIELDS)
|
|
15014
|
+
and not any(path.exists() or path.is_symlink() for path in retry_paths)
|
|
15015
|
+
):
|
|
15016
|
+
superseded_state = "pending"
|
|
15017
|
+
elif (
|
|
15018
|
+
_text(review.get("verdict")) == "blocked"
|
|
15019
|
+
and _text(review.get("runtime_state")) == "blocked"
|
|
15020
|
+
and review.get("runtime_exit_code") == 0
|
|
15021
|
+
and not _text(review.get("runtime_failure_kind"))
|
|
15022
|
+
and int(review.get("runtime_attempt_count") or 0) == 1
|
|
15023
|
+
):
|
|
15024
|
+
superseded_state = "blocked"
|
|
15025
|
+
else:
|
|
15026
|
+
raise APError(
|
|
15027
|
+
"The 4.3.4 Reviewer retry is not an untouched pending attempt or the exact procedural block."
|
|
15028
|
+
)
|
|
15029
|
+
elif (
|
|
15030
|
+
_text(review.get("verdict")) != "blocked"
|
|
15031
|
+
or _text(review.get("runtime_state")) != "blocked"
|
|
15032
|
+
or review.get("runtime_exit_code") != 0
|
|
15033
|
+
or _text(review.get("runtime_failure_kind"))
|
|
15034
|
+
or int(review.get("runtime_attempt_count") or 0) != 1
|
|
14920
15035
|
):
|
|
14921
15036
|
raise APError(
|
|
14922
|
-
"Prior Reviewer
|
|
15037
|
+
"Prior Reviewer state is not the exact completed procedural block eligible for retry."
|
|
15038
|
+
)
|
|
15039
|
+
|
|
15040
|
+
blocked_result_path: Optional[Path] = None
|
|
15041
|
+
blocked_receipt_path: Optional[Path] = None
|
|
15042
|
+
blocked_event_path: Optional[Path] = None
|
|
15043
|
+
if not repairing_retry or superseded_state == "blocked":
|
|
15044
|
+
blocked_result_path, blocked_receipt_path = _review_runtime_paths(
|
|
15045
|
+
control_repo,
|
|
15046
|
+
task_id,
|
|
15047
|
+
fingerprint,
|
|
15048
|
+
existing_token,
|
|
15049
|
+
create=False,
|
|
15050
|
+
)
|
|
15051
|
+
blocked_event_path = _review_runtime_event_log_path(
|
|
15052
|
+
control_repo,
|
|
15053
|
+
task_id,
|
|
15054
|
+
fingerprint,
|
|
15055
|
+
existing_token,
|
|
15056
|
+
create=False,
|
|
15057
|
+
)
|
|
15058
|
+
if Path(_text(review.get("runtime_result_path"))).resolve() != blocked_result_path.resolve():
|
|
15059
|
+
raise APError("Prior Reviewer result path is not canonical.")
|
|
15060
|
+
if Path(_text(review.get("runtime_receipt_path"))).resolve() != blocked_receipt_path.resolve():
|
|
15061
|
+
raise APError("Prior Reviewer receipt path is not canonical.")
|
|
15062
|
+
if Path(_text(review.get("runtime_event_log_path"))).resolve() != blocked_event_path.resolve():
|
|
15063
|
+
raise APError("Prior Reviewer event log path is not canonical.")
|
|
15064
|
+
receipt = _validate_bound_review_runtime_receipt(
|
|
15065
|
+
control_repo,
|
|
15066
|
+
manifest,
|
|
15067
|
+
assignment,
|
|
15068
|
+
blocked_receipt_path,
|
|
15069
|
+
"blocked",
|
|
15070
|
+
)
|
|
15071
|
+
attempts = receipt.get("attempts") or []
|
|
15072
|
+
if (
|
|
15073
|
+
int(receipt.get("schema") or 0) != 2
|
|
15074
|
+
or _text(receipt.get("verdict")) != "blocked"
|
|
15075
|
+
or receipt.get("exit_code") != 0
|
|
15076
|
+
or _text(receipt.get("failure_kind"))
|
|
15077
|
+
or len(attempts) != 1
|
|
15078
|
+
or _text(attempts[0].get("status")) != "completed"
|
|
15079
|
+
or attempts[0].get("exit_code") != 0
|
|
15080
|
+
):
|
|
15081
|
+
raise APError(
|
|
15082
|
+
"Prior Reviewer receipt is not the exact completed procedural block eligible for retry."
|
|
15083
|
+
)
|
|
15084
|
+
try:
|
|
15085
|
+
result_payload = json.loads(_read_bounded_reviewer_output(blocked_result_path))
|
|
15086
|
+
except (json.JSONDecodeError, UnicodeDecodeError) as exc:
|
|
15087
|
+
raise APError("Prior Reviewer result is invalid JSON.") from exc
|
|
15088
|
+
if not isinstance(result_payload, dict):
|
|
15089
|
+
raise APError("Prior Reviewer result must contain one JSON object.")
|
|
15090
|
+
normalized_result = _normalize_reviewer_runtime_result(assignment, result_payload)
|
|
15091
|
+
if result_payload != normalized_result or not _known_review_artifact_access_failure(
|
|
15092
|
+
control_repo,
|
|
15093
|
+
normalized_result,
|
|
15094
|
+
):
|
|
15095
|
+
raise APError(
|
|
15096
|
+
"Prior Reviewer result is not the exact non-substantive Git-local access failure."
|
|
15097
|
+
)
|
|
15098
|
+
|
|
15099
|
+
if superseded_audit:
|
|
15100
|
+
prior_result_path = Path(_text(superseded_audit.get("prior_result_path"))).resolve()
|
|
15101
|
+
prior_receipt_path = Path(_text(superseded_audit.get("prior_receipt_path"))).resolve()
|
|
15102
|
+
prior_event_path = Path(_text(superseded_audit.get("prior_event_log_path"))).resolve()
|
|
15103
|
+
prior_result_sha256 = _text(superseded_audit.get("prior_result_sha256"))
|
|
15104
|
+
prior_receipt_sha256 = _text(superseded_audit.get("prior_receipt_sha256"))
|
|
15105
|
+
prior_event_sha256 = _text(superseded_audit.get("prior_event_log_sha256"))
|
|
15106
|
+
else:
|
|
15107
|
+
assert blocked_result_path and blocked_receipt_path and blocked_event_path
|
|
15108
|
+
prior_result_path = blocked_result_path
|
|
15109
|
+
prior_receipt_path = blocked_receipt_path
|
|
15110
|
+
prior_event_path = blocked_event_path
|
|
15111
|
+
prior_result_sha256 = _private_review_file_sha256(prior_result_path, "prior result")
|
|
15112
|
+
prior_receipt_sha256 = _private_review_file_sha256(
|
|
15113
|
+
prior_receipt_path, "prior runtime receipt"
|
|
15114
|
+
)
|
|
15115
|
+
prior_event_sha256 = _private_review_file_sha256(
|
|
15116
|
+
prior_event_path, "prior event log"
|
|
14923
15117
|
)
|
|
14924
15118
|
|
|
14925
15119
|
token = f"retry-v{runtime_version}"
|
|
@@ -14975,22 +15169,18 @@ def cmd_review_runtime_retry(args: argparse.Namespace) -> None:
|
|
|
14975
15169
|
"diff_artifact_path": _text(review.get("diff_artifact_path")),
|
|
14976
15170
|
"diff_artifact_sha256": _text(review.get("diff_artifact_sha256")),
|
|
14977
15171
|
"prior_result_path": str(prior_result_path),
|
|
14978
|
-
"prior_result_sha256":
|
|
15172
|
+
"prior_result_sha256": prior_result_sha256,
|
|
14979
15173
|
"prior_receipt_path": str(prior_receipt_path),
|
|
14980
|
-
"prior_receipt_sha256":
|
|
14981
|
-
prior_receipt_path, "prior runtime receipt"
|
|
14982
|
-
),
|
|
15174
|
+
"prior_receipt_sha256": prior_receipt_sha256,
|
|
14983
15175
|
"prior_event_log_path": str(prior_event_path),
|
|
14984
|
-
"prior_event_log_sha256":
|
|
14985
|
-
prior_event_path, "prior event log"
|
|
14986
|
-
),
|
|
15176
|
+
"prior_event_log_sha256": prior_event_sha256,
|
|
14987
15177
|
"prior_review_state_sha256": hashlib.sha256(
|
|
14988
15178
|
json.dumps(review, ensure_ascii=False, sort_keys=True, separators=(",", ":")).encode(
|
|
14989
15179
|
"utf-8"
|
|
14990
15180
|
)
|
|
14991
15181
|
).hexdigest(),
|
|
14992
|
-
"prior_verdict": "
|
|
14993
|
-
"prior_runtime_state": "
|
|
15182
|
+
"prior_verdict": _text(review.get("verdict")),
|
|
15183
|
+
"prior_runtime_state": _text(review.get("runtime_state")) or "pending",
|
|
14994
15184
|
"managed_runtime_version": runtime_version,
|
|
14995
15185
|
"managed_runtime_script_path": identity["script_path"],
|
|
14996
15186
|
"managed_runtime_script_sha256": identity["script_sha256"],
|
|
@@ -15000,6 +15190,37 @@ def cmd_review_runtime_retry(args: argparse.Namespace) -> None:
|
|
|
15000
15190
|
"retry_receipt_path": str(retry_receipt_path),
|
|
15001
15191
|
"retry_event_log_path": str(retry_event_path),
|
|
15002
15192
|
}
|
|
15193
|
+
if superseded_audit:
|
|
15194
|
+
audit.update(
|
|
15195
|
+
{
|
|
15196
|
+
"superseded_retry_token": existing_token,
|
|
15197
|
+
"superseded_retry_audit_path": _text(
|
|
15198
|
+
review.get("runtime_retry_audit_path")
|
|
15199
|
+
),
|
|
15200
|
+
"superseded_retry_audit_sha256": _text(
|
|
15201
|
+
review.get("runtime_retry_audit_sha256")
|
|
15202
|
+
),
|
|
15203
|
+
"superseded_retry_state": superseded_state,
|
|
15204
|
+
}
|
|
15205
|
+
)
|
|
15206
|
+
if superseded_state == "blocked":
|
|
15207
|
+
assert blocked_result_path and blocked_receipt_path and blocked_event_path
|
|
15208
|
+
audit.update(
|
|
15209
|
+
{
|
|
15210
|
+
"superseded_retry_result_path": str(blocked_result_path),
|
|
15211
|
+
"superseded_retry_result_sha256": _private_review_file_sha256(
|
|
15212
|
+
blocked_result_path, "superseded retry result"
|
|
15213
|
+
),
|
|
15214
|
+
"superseded_retry_receipt_path": str(blocked_receipt_path),
|
|
15215
|
+
"superseded_retry_receipt_sha256": _private_review_file_sha256(
|
|
15216
|
+
blocked_receipt_path, "superseded retry receipt"
|
|
15217
|
+
),
|
|
15218
|
+
"superseded_retry_event_log_path": str(blocked_event_path),
|
|
15219
|
+
"superseded_retry_event_log_sha256": _private_review_file_sha256(
|
|
15220
|
+
blocked_event_path, "superseded retry event log"
|
|
15221
|
+
),
|
|
15222
|
+
}
|
|
15223
|
+
)
|
|
15003
15224
|
_create_private_json(audit_path, audit, "runtime retry audit")
|
|
15004
15225
|
audit_sha256 = _private_review_file_sha256(audit_path, "runtime retry audit")
|
|
15005
15226
|
next_review = {
|
|
@@ -198,7 +198,7 @@ class AutoCodingConcurrencyTests(unittest.TestCase):
|
|
|
198
198
|
check=check,
|
|
199
199
|
)
|
|
200
200
|
|
|
201
|
-
def managed_runtime(self, root: Path) -> Path:
|
|
201
|
+
def managed_runtime(self, root: Path, version: str = "4.3.6") -> Path:
|
|
202
202
|
install_root = root / "managed-runtime"
|
|
203
203
|
skill = install_root / ".agents" / "skills" / "auto-coding-skill"
|
|
204
204
|
shutil.copytree(REPO_ROOT / "src" / "auto-coding-skill", skill)
|
|
@@ -206,7 +206,7 @@ class AutoCodingConcurrencyTests(unittest.TestCase):
|
|
|
206
206
|
relative = ".agents/skills/auto-coding-skill/scripts/ap.py"
|
|
207
207
|
manifest = {
|
|
208
208
|
"schema_version": 1,
|
|
209
|
-
"skill_version":
|
|
209
|
+
"skill_version": version,
|
|
210
210
|
"manifest_path": ".agents/managed-install.json",
|
|
211
211
|
"entries": [
|
|
212
212
|
{
|
|
@@ -216,7 +216,7 @@ class AutoCodingConcurrencyTests(unittest.TestCase):
|
|
|
216
216
|
"sha256": hashlib.sha256(script.read_bytes()).hexdigest(),
|
|
217
217
|
"executable": bool(script.stat().st_mode & 0o111),
|
|
218
218
|
"scope": "shared",
|
|
219
|
-
"version":
|
|
219
|
+
"version": version,
|
|
220
220
|
}
|
|
221
221
|
],
|
|
222
222
|
"managed_namespaces": [],
|
|
@@ -1666,7 +1666,7 @@ class AutoCodingConcurrencyTests(unittest.TestCase):
|
|
|
1666
1666
|
).stdout
|
|
1667
1667
|
)
|
|
1668
1668
|
self.assertEqual("retry-authorized", authorized["status"])
|
|
1669
|
-
self.assertEqual("retry-v4.3.
|
|
1669
|
+
self.assertEqual("retry-v4.3.6", authorized["retry_token"])
|
|
1670
1670
|
audit_path = Path(authorized["audit_path"])
|
|
1671
1671
|
self.assertEqual(0o600, audit_path.stat().st_mode & 0o777)
|
|
1672
1672
|
audit = json.loads(audit_path.read_text(encoding="utf-8"))
|
|
@@ -1705,9 +1705,9 @@ class AutoCodingConcurrencyTests(unittest.TestCase):
|
|
|
1705
1705
|
)["tasks"][0]
|
|
1706
1706
|
retry_review = status["review"]
|
|
1707
1707
|
self.assertEqual("approved", retry_review["verdict"])
|
|
1708
|
-
self.assertIn(".retry-v4.3.
|
|
1708
|
+
self.assertIn(".retry-v4.3.6.result.json", retry_review["runtime_result_path"])
|
|
1709
1709
|
retry_receipt = json.loads(Path(retry_review["runtime_receipt_path"]).read_text())
|
|
1710
|
-
self.assertEqual("retry-v4.3.
|
|
1710
|
+
self.assertEqual("retry-v4.3.6", retry_receipt["runtime_retry_token"])
|
|
1711
1711
|
self.assertEqual(authorized["audit_sha256"], retry_receipt["runtime_retry_audit_sha256"])
|
|
1712
1712
|
|
|
1713
1713
|
repeated = self.ap_script(
|
|
@@ -1724,6 +1724,126 @@ class AutoCodingConcurrencyTests(unittest.TestCase):
|
|
|
1724
1724
|
)
|
|
1725
1725
|
self.assertNotEqual(0, repeated.returncode)
|
|
1726
1726
|
|
|
1727
|
+
def test_434_retry_artifact_access_block_gets_one_fixed_runtime_repair(self) -> None:
|
|
1728
|
+
root, repo, _ = self.make_repo()
|
|
1729
|
+
managed_434 = self.managed_runtime(root / "runtime-434", "4.3.4")
|
|
1730
|
+
managed_fixed = self.managed_runtime(root / "runtime-fixed", "4.3.6")
|
|
1731
|
+
worktree = self.start_task(repo, "REVIEW-RETRY-REPAIR", "shared.txt")
|
|
1732
|
+
(worktree / "shared.txt").write_text("repair retry payload\n", encoding="utf-8")
|
|
1733
|
+
common_dir = Path(git_output(repo, "rev-parse", "--git-common-dir"))
|
|
1734
|
+
if not common_dir.is_absolute():
|
|
1735
|
+
common_dir = (repo / common_dir).resolve()
|
|
1736
|
+
state_root = common_dir / "auto-coding-skill"
|
|
1737
|
+
blocked_reviewer = root / "repair-artifact-access-block.py"
|
|
1738
|
+
blocked_reviewer.write_text(
|
|
1739
|
+
"import json\n"
|
|
1740
|
+
f"state_root = {str(state_root)!r}\n"
|
|
1741
|
+
"print(json.dumps({"
|
|
1742
|
+
"'verdict': 'blocked', "
|
|
1743
|
+
"'summary': 'Review could not begin because review-artifact failed to verify and emit the immutable patch.', "
|
|
1744
|
+
"'evidence': ['review-artifact exited with: Cannot protect Git-local review storage: ' + state_root + ': [Errno 1] Operation not permitted'], "
|
|
1745
|
+
"'risks': ['The SHA-256-bound frozen diff was not emitted or reviewed, so no substantive correctness or security conclusion is available.']}))\n",
|
|
1746
|
+
encoding="utf-8",
|
|
1747
|
+
)
|
|
1748
|
+
blocked_runner = json.dumps([sys.executable, str(blocked_reviewer)])
|
|
1749
|
+
self.ap(
|
|
1750
|
+
worktree,
|
|
1751
|
+
"review-run",
|
|
1752
|
+
"REVIEW-RETRY-REPAIR",
|
|
1753
|
+
"--reviewer",
|
|
1754
|
+
"repair-reviewer",
|
|
1755
|
+
"--runner-command-json",
|
|
1756
|
+
blocked_runner,
|
|
1757
|
+
check=False,
|
|
1758
|
+
)
|
|
1759
|
+
manifest_path = self.registry_manifest_path(repo, "REVIEW-RETRY-REPAIR")
|
|
1760
|
+
manifest = json.loads(manifest_path.read_text(encoding="utf-8"))
|
|
1761
|
+
manifest["skill_version"] = "4.3.2"
|
|
1762
|
+
manifest_path.write_text(json.dumps(manifest, indent=2) + "\n", encoding="utf-8")
|
|
1763
|
+
fingerprint = manifest["review"]["diff_fingerprint"]
|
|
1764
|
+
first_retry = json.loads(
|
|
1765
|
+
self.ap_script(
|
|
1766
|
+
worktree,
|
|
1767
|
+
managed_434,
|
|
1768
|
+
"review-runtime-retry",
|
|
1769
|
+
"REVIEW-RETRY-REPAIR",
|
|
1770
|
+
"--diff-fingerprint",
|
|
1771
|
+
fingerprint,
|
|
1772
|
+
"--reason-code",
|
|
1773
|
+
"managed-review-artifact-access",
|
|
1774
|
+
"--confirm-managed-runtime-retry",
|
|
1775
|
+
"--json",
|
|
1776
|
+
).stdout
|
|
1777
|
+
)
|
|
1778
|
+
self.assertEqual("retry-v4.3.4", first_retry["retry_token"])
|
|
1779
|
+
self.ap_script(
|
|
1780
|
+
worktree,
|
|
1781
|
+
managed_434,
|
|
1782
|
+
"review-run",
|
|
1783
|
+
"REVIEW-RETRY-REPAIR",
|
|
1784
|
+
"--reviewer",
|
|
1785
|
+
"repair-reviewer",
|
|
1786
|
+
"--runner-command-json",
|
|
1787
|
+
blocked_runner,
|
|
1788
|
+
check=False,
|
|
1789
|
+
)
|
|
1790
|
+
blocked_status = json.loads(
|
|
1791
|
+
self.ap_script(
|
|
1792
|
+
worktree,
|
|
1793
|
+
managed_434,
|
|
1794
|
+
"task-status",
|
|
1795
|
+
"REVIEW-RETRY-REPAIR",
|
|
1796
|
+
"--json",
|
|
1797
|
+
).stdout
|
|
1798
|
+
)["tasks"][0]
|
|
1799
|
+
old_review = blocked_status["review"]
|
|
1800
|
+
old_evidence_paths = [
|
|
1801
|
+
Path(old_review["runtime_retry_audit_path"]),
|
|
1802
|
+
Path(old_review["runtime_result_path"]),
|
|
1803
|
+
Path(old_review["runtime_receipt_path"]),
|
|
1804
|
+
Path(old_review["runtime_event_log_path"]),
|
|
1805
|
+
]
|
|
1806
|
+
old_evidence = {path: path.read_bytes() for path in old_evidence_paths}
|
|
1807
|
+
|
|
1808
|
+
repaired = json.loads(
|
|
1809
|
+
self.ap_script(
|
|
1810
|
+
worktree,
|
|
1811
|
+
managed_fixed,
|
|
1812
|
+
"review-runtime-retry",
|
|
1813
|
+
"REVIEW-RETRY-REPAIR",
|
|
1814
|
+
"--diff-fingerprint",
|
|
1815
|
+
fingerprint,
|
|
1816
|
+
"--reason-code",
|
|
1817
|
+
"managed-review-artifact-access",
|
|
1818
|
+
"--confirm-managed-runtime-retry",
|
|
1819
|
+
"--json",
|
|
1820
|
+
).stdout
|
|
1821
|
+
)
|
|
1822
|
+
self.assertEqual("retry-v4.3.6", repaired["retry_token"])
|
|
1823
|
+
repair_audit = json.loads(Path(repaired["audit_path"]).read_text(encoding="utf-8"))
|
|
1824
|
+
self.assertEqual("retry-v4.3.4", repair_audit["superseded_retry_token"])
|
|
1825
|
+
self.assertEqual("blocked", repair_audit["superseded_retry_state"])
|
|
1826
|
+
reviewed = json.loads(
|
|
1827
|
+
self.ap_script(
|
|
1828
|
+
worktree,
|
|
1829
|
+
managed_fixed,
|
|
1830
|
+
"review-run",
|
|
1831
|
+
"REVIEW-RETRY-REPAIR",
|
|
1832
|
+
"--reviewer",
|
|
1833
|
+
"repair-reviewer",
|
|
1834
|
+
"--runner-command-json",
|
|
1835
|
+
self.artifact_reviewer_runner(
|
|
1836
|
+
root,
|
|
1837
|
+
"repair retry payload",
|
|
1838
|
+
runtime_script=managed_fixed,
|
|
1839
|
+
),
|
|
1840
|
+
"--json",
|
|
1841
|
+
).stdout
|
|
1842
|
+
)
|
|
1843
|
+
self.assertEqual("approved", reviewed["verdict"])
|
|
1844
|
+
for path, original in old_evidence.items():
|
|
1845
|
+
self.assertEqual(original, path.read_bytes(), str(path))
|
|
1846
|
+
|
|
1727
1847
|
def test_managed_retry_rejects_a_substantive_blocked_result(self) -> None:
|
|
1728
1848
|
root, repo, _ = self.make_repo()
|
|
1729
1849
|
managed_script = self.managed_runtime(root)
|
|
@@ -87,7 +87,7 @@ class ProjectConfigResolverTests(unittest.TestCase):
|
|
|
87
87
|
(self.repo / "docs" / "project").mkdir(parents=True)
|
|
88
88
|
self.write_managed(
|
|
89
89
|
"""workflow:
|
|
90
|
-
skill_version: "4.3.
|
|
90
|
+
skill_version: "4.3.6"
|
|
91
91
|
mode: dev
|
|
92
92
|
profile: auto
|
|
93
93
|
completion: push
|
|
@@ -130,7 +130,7 @@ access:
|
|
|
130
130
|
effective = core.load_effective_config(self.repo)
|
|
131
131
|
|
|
132
132
|
self.assertEqual("sample", effective["project"]["name"])
|
|
133
|
-
self.assertEqual("4.3.
|
|
133
|
+
self.assertEqual("4.3.6", effective["workflow"]["skill_version"])
|
|
134
134
|
self.assertEqual(self.repo / "docs" / "ENGINEERING.md", core.find_config(self.repo))
|
|
135
135
|
self.assertEqual({}, core.load_project_overrides(self.repo))
|
|
136
136
|
|
|
@@ -153,7 +153,7 @@ access:
|
|
|
153
153
|
|
|
154
154
|
effective = core.load_effective_config(self.repo)
|
|
155
155
|
|
|
156
|
-
self.assertEqual("4.3.
|
|
156
|
+
self.assertEqual("4.3.6", effective["workflow"]["skill_version"])
|
|
157
157
|
self.assertEqual("dev", effective["workflow"]["mode"])
|
|
158
158
|
self.assertEqual("project-profile", effective["workflow"]["profile"])
|
|
159
159
|
self.assertEqual("push", effective["workflow"]["completion"])
|
|
@@ -292,11 +292,11 @@ access:
|
|
|
292
292
|
|
|
293
293
|
def test_large_managed_body_is_not_part_of_frontmatter_bound(self) -> None:
|
|
294
294
|
self.write_managed(
|
|
295
|
-
'workflow:\n skill_version: "4.3.
|
|
295
|
+
'workflow:\n skill_version: "4.3.6"\n',
|
|
296
296
|
body="x" * (core.MANAGED_CONFIG_FRONTMATTER_MAX_BYTES + 1),
|
|
297
297
|
)
|
|
298
298
|
|
|
299
|
-
self.assertEqual("4.3.
|
|
299
|
+
self.assertEqual("4.3.6", core.load_effective_config(self.repo)["workflow"]["skill_version"])
|
|
300
300
|
|
|
301
301
|
def test_yaml_failure_does_not_echo_content_or_absolute_path(self) -> None:
|
|
302
302
|
secret = "NEVER_ECHO_THIS_SECRET"
|
package/cli/tests/index.test.js
CHANGED
|
@@ -422,8 +422,8 @@ function testInitFullyConvergesExistingProject() {
|
|
|
422
422
|
}
|
|
423
423
|
assert(exists(path.join(repo, ".agents", "agents", "custom.toml")), "project-owned custom agents must survive init");
|
|
424
424
|
assert(!exists(path.join(repo, ".agents", "skills", "auto-coding-skill", "obsolete.txt")), "extra Skill files must be removed");
|
|
425
|
-
assert(exists(path.join(repo, ".agents", "archive", "auto-coding-skill", "4.3.
|
|
426
|
-
assert(exists(path.join(repo, ".agents", "archive", "auto-coding-skill", "4.3.
|
|
425
|
+
assert(exists(path.join(repo, ".agents", "archive", "auto-coding-skill", "4.3.6", "docs", "legacy", "old-taskbook.md")), "removed docs must be archived outside active docs");
|
|
426
|
+
assert(exists(path.join(repo, ".agents", "archive", "auto-coding-skill", "4.3.6", "docs", "legacy", "orphan.bin")), "unowned legacy binary assets must still be archived");
|
|
427
427
|
assert(fs.readFileSync(structureStandard, "utf8") === customStructureStandard, "init must preserve a project-owned structure standard");
|
|
428
428
|
assert(fs.readFileSync(path.join(repo, "docs", "architecture", "adr", "0042-project-choice.md"), "utf8").includes("Keep me"), "numbered ADR artifacts must survive init");
|
|
429
429
|
assert(fs.readFileSync(path.join(repo, "docs", "architecture", "system-context.md"), "utf8").includes("Keep me"), "architecture artifacts must survive init");
|
|
@@ -538,12 +538,12 @@ function testManagedPolicySummaryPreservesProjectConfiguration() {
|
|
|
538
538
|
const legacySummary = "- `structure` and `optimization`: advisory architecture and no-new-debt policy.";
|
|
539
539
|
const installedOldDefault = current
|
|
540
540
|
.replace(/^ skill_version:.*$/m, " skill_version: 4.2.5")
|
|
541
|
-
.replace("managed-workflow:start version=4.3.
|
|
541
|
+
.replace("managed-workflow:start version=4.3.6", "managed-workflow:start version=4.2.5")
|
|
542
542
|
.replace(neutralSummary, legacySummary);
|
|
543
543
|
installTrustedEngineeringDefault(repo, installedOldDefault, "4.2.5");
|
|
544
544
|
const customized = current
|
|
545
545
|
.replace(/^ skill_version:.*$/m, " skill_version: 4.2.5")
|
|
546
|
-
.replace("managed-workflow:start version=4.3.
|
|
546
|
+
.replace("managed-workflow:start version=4.3.6", "managed-workflow:start version=4.2.5")
|
|
547
547
|
.replace(neutralSummary, legacySummary)
|
|
548
548
|
.replace(/^ enforcement:.*$/m, " enforcement: blocking")
|
|
549
549
|
.replace(" block_warnings: false", " block_warnings: true")
|
|
@@ -562,7 +562,7 @@ function testManagedPolicySummaryPreservesProjectConfiguration() {
|
|
|
562
562
|
const upgraded = fs.readFileSync(engineering, "utf8");
|
|
563
563
|
const managedAfterUpgrade = readEngineeringConfig(engineering);
|
|
564
564
|
const afterUpgrade = readEffectiveConfig(repo);
|
|
565
|
-
assert(managedAfterUpgrade.workflow?.skill_version === "4.3.
|
|
565
|
+
assert(managedAfterUpgrade.workflow?.skill_version === "4.3.6", "init must upgrade the managed workflow version");
|
|
566
566
|
assert(canonicalJson(afterUpgrade.structure) === canonicalJson(beforeUpgrade.structure), "init must preserve the complete project structure policy");
|
|
567
567
|
assert(canonicalJson(afterUpgrade.optimization) === canonicalJson(beforeUpgrade.optimization), "init must preserve the complete project optimization policy");
|
|
568
568
|
assert(upgraded.includes(neutralSummary), "upgraded managed text must defer to frontmatter policy");
|
|
@@ -1214,7 +1214,7 @@ function testTamperedInstalledDefaultRejectsInitAndSyncWithoutWrites() {
|
|
|
1214
1214
|
const skill = path.join(repo, ".agents", "skills", "auto-coding-skill", "SKILL.md");
|
|
1215
1215
|
const oldDefault = fs.readFileSync(engineering, "utf8")
|
|
1216
1216
|
.replace(/^ skill_version:.*$/m, ' skill_version: "4.2.7"')
|
|
1217
|
-
.replace("managed-workflow:start version=4.3.
|
|
1217
|
+
.replace("managed-workflow:start version=4.3.6", "managed-workflow:start version=4.2.7");
|
|
1218
1218
|
installTrustedEngineeringDefault(repo, oldDefault, "4.2.7");
|
|
1219
1219
|
writeFile(engineering, oldDefault);
|
|
1220
1220
|
fs.unlinkSync(overlay);
|
|
@@ -1503,7 +1503,7 @@ function testArchiveFallbackCollisionsNeverLosePreviousContent() {
|
|
|
1503
1503
|
const engineering = path.join(repo, "docs", "ENGINEERING.md");
|
|
1504
1504
|
fs.appendFileSync(engineering, "\n## Archive collision sentinel\n\nPreserve these ENGINEERING bytes.\n");
|
|
1505
1505
|
const previous = fs.readFileSync(engineering);
|
|
1506
|
-
const archiveDir = path.join(repo, ".agents", "archive", "auto-coding-skill", "4.3.
|
|
1506
|
+
const archiveDir = path.join(repo, ".agents", "archive", "auto-coding-skill", "4.3.6", "docs");
|
|
1507
1507
|
const preferred = path.join(archiveDir, "ENGINEERING.md");
|
|
1508
1508
|
const legacyDigest = path.join(archiveDir, `ENGINEERING-${digest12(previous)}.md`);
|
|
1509
1509
|
const occupiedPreferred = Buffer.from("occupied-engineering-default\n");
|
|
@@ -1533,7 +1533,7 @@ function testArchiveFallbackCollisionsNeverLosePreviousContent() {
|
|
|
1533
1533
|
".agents",
|
|
1534
1534
|
"archive",
|
|
1535
1535
|
"auto-coding-skill",
|
|
1536
|
-
"4.3.
|
|
1536
|
+
"4.3.6",
|
|
1537
1537
|
"docs",
|
|
1538
1538
|
"design",
|
|
1539
1539
|
);
|
|
@@ -1558,7 +1558,7 @@ function testArchiveFallbackCollisionsNeverLosePreviousContent() {
|
|
|
1558
1558
|
const agents = path.join(repo, "AGENTS.md");
|
|
1559
1559
|
const previous = Buffer.from("# Project AGENTS before sync\n\nPreserve this sync history.\n");
|
|
1560
1560
|
fs.writeFileSync(agents, previous);
|
|
1561
|
-
const archiveDir = path.join(repo, ".agents", "archive", "auto-coding-skill", "4.3.
|
|
1561
|
+
const archiveDir = path.join(repo, ".agents", "archive", "auto-coding-skill", "4.3.6");
|
|
1562
1562
|
const preferred = path.join(archiveDir, "AGENTS.md");
|
|
1563
1563
|
const legacyDigest = path.join(archiveDir, `AGENTS-${digest12(previous)}.md`);
|
|
1564
1564
|
const occupiedPreferred = Buffer.from("occupied-sync-default\n");
|
|
@@ -1580,7 +1580,7 @@ function testArchiveFallbackCollisionsNeverLosePreviousContent() {
|
|
|
1580
1580
|
const agents = path.join(repo, "AGENTS.md");
|
|
1581
1581
|
const previous = Buffer.from("# Project AGENTS before init\n\nPreserve this init history.\n");
|
|
1582
1582
|
fs.writeFileSync(agents, previous);
|
|
1583
|
-
const archiveDir = path.join(repo, ".agents", "archive", "auto-coding-skill", "4.3.
|
|
1583
|
+
const archiveDir = path.join(repo, ".agents", "archive", "auto-coding-skill", "4.3.6");
|
|
1584
1584
|
const preferred = path.join(archiveDir, "AGENTS.md");
|
|
1585
1585
|
const legacyDigest = path.join(archiveDir, `AGENTS-${digest12(previous)}.md`);
|
|
1586
1586
|
const occupiedPreferred = Buffer.from("occupied-init-default\n");
|
|
@@ -2210,7 +2210,7 @@ function testCliInstallArchivesFeedbackTemplatesAndPreservesReports() {
|
|
|
2210
2210
|
writeFile(report, reportContent);
|
|
2211
2211
|
|
|
2212
2212
|
run("node", [cli, "init"], { cwd: repo });
|
|
2213
|
-
const archive = path.join(repo, ".agents", "archive", "auto-coding-skill", "4.3.
|
|
2213
|
+
const archive = path.join(repo, ".agents", "archive", "auto-coding-skill", "4.3.6", "docs", "skill-feedback", "README.md");
|
|
2214
2214
|
assert(fs.readFileSync(feedbackReadme, "utf8").includes("Auto Coding Skill Feedback"), "transactional init must install the managed feedback README");
|
|
2215
2215
|
assert(fs.readFileSync(archive, "utf8") === previousReadme, "transactional init must archive a pre-existing feedback README before replacement");
|
|
2216
2216
|
assert(fs.readFileSync(report, "utf8") === reportContent, "transactional init must preserve project feedback reports byte-for-byte");
|
|
@@ -2319,21 +2319,21 @@ function testManagedEngineeringInitIsAuthoritativeAndIdempotent() {
|
|
|
2319
2319
|
const dryRun = run("node", [cli, "sync", "--projects", repo, "--dry-run", "--json"]);
|
|
2320
2320
|
const dryResult = JSON.parse(dryRun.stdout).results[0];
|
|
2321
2321
|
assert(dryResult.managedWorkflow.state === "stale", `dry-run should expose stale workflow state: ${dryRun.stdout}`);
|
|
2322
|
-
assert(dryResult.managedWorkflow.version === "4.3.
|
|
2322
|
+
assert(dryResult.managedWorkflow.version === "4.3.6", "dry-run should expose the target workflow version");
|
|
2323
2323
|
assert(dryResult.actions.some(item => item.action === "would-replace" && item.path === "docs/ENGINEERING.md"), "dry-run should plan exact replacement of the managed default document");
|
|
2324
2324
|
assert(fs.readFileSync(engineering, "utf8") === customized, "dry-run must not write ENGINEERING.md");
|
|
2325
2325
|
|
|
2326
2326
|
run("node", [cli, "init"], { cwd: repo });
|
|
2327
2327
|
const updated = fs.readFileSync(engineering, "utf8");
|
|
2328
2328
|
assert(!updated.includes("project note before") && !updated.includes("project note after"), "init must remove text outside the canonical ENGINEERING body");
|
|
2329
|
-
assert(updated.includes("version=4.3.
|
|
2329
|
+
assert(updated.includes("version=4.3.6"), "init should install the current managed workflow version");
|
|
2330
2330
|
assert(updated.includes("The frontmatter contract is:"), "init should refresh stale managed workflow content");
|
|
2331
2331
|
|
|
2332
2332
|
fillRequiredAccess(repo);
|
|
2333
2333
|
const status = run("node", [cli, "status", "--projects", repo, "--json"]);
|
|
2334
2334
|
const statusResult = JSON.parse(status.stdout).results[0];
|
|
2335
2335
|
assert(statusResult.managedWorkflow.state === "current", `status should expose current managed workflow state: ${status.stdout}`);
|
|
2336
|
-
assert(statusResult.managedWorkflow.version === "4.3.
|
|
2336
|
+
assert(statusResult.managedWorkflow.version === "4.3.6", "status should expose the installed managed workflow version");
|
|
2337
2337
|
|
|
2338
2338
|
const beforeSecondInit = fs.readFileSync(engineering, "utf8");
|
|
2339
2339
|
run("node", [cli, "init"], { cwd: repo });
|
|
@@ -2361,9 +2361,9 @@ function testLegacyEngineeringMigrationPreservesExistingBody() {
|
|
|
2361
2361
|
assert(dryResult.actions.some(item => item.action === "would-archive" && item.path.endsWith("/docs/ENGINEERING.md")), "custom legacy migration must plan archival before replacement");
|
|
2362
2362
|
run("node", [cli, "sync", "--projects", repo]);
|
|
2363
2363
|
const migrated = fs.readFileSync(engineering, "utf8");
|
|
2364
|
-
assert(migrated.includes("version=4.3.
|
|
2364
|
+
assert(migrated.includes("version=4.3.6"), "legacy migration should insert the current managed workflow");
|
|
2365
2365
|
assert(!migrated.includes(legacyNote), "legacy project text must not remain in the exact managed default document");
|
|
2366
|
-
const archive = path.join(repo, ".agents", "archive", "auto-coding-skill", "4.3.
|
|
2366
|
+
const archive = path.join(repo, ".agents", "archive", "auto-coding-skill", "4.3.6", "docs", "ENGINEERING.md");
|
|
2367
2367
|
assert(fs.readFileSync(archive, "utf8").includes(legacyNote), "legacy migration must preserve the complete previous body in history");
|
|
2368
2368
|
const stable = fs.readFileSync(engineering, "utf8");
|
|
2369
2369
|
run("node", [cli, "sync", "--projects", repo]);
|
|
@@ -2391,7 +2391,7 @@ function testOfficialLegacyEngineeringBodyIsReplacedWithoutDuplication() {
|
|
|
2391
2391
|
assert(migrated === canonicalEngineering, "official legacy migration must install the exact managed default document");
|
|
2392
2392
|
assert((migrated.match(/auto-coding-skill:managed-workflow:start/g) || []).length === 1, "official legacy migration should install exactly one managed workflow");
|
|
2393
2393
|
assert((migrated.match(/^## Execution profiles$/gm) || []).length === 0, "official legacy migration must remove the old duplicated workflow body");
|
|
2394
|
-
const archive = path.join(repo, ".agents", "archive", "auto-coding-skill", "4.3.
|
|
2394
|
+
const archive = path.join(repo, ".agents", "archive", "auto-coding-skill", "4.3.6", "docs", "ENGINEERING.md");
|
|
2395
2395
|
assert(fs.readFileSync(archive, "utf8").includes("## Execution profiles"), "official legacy body must remain available in the historical archive");
|
|
2396
2396
|
|
|
2397
2397
|
const stable = fs.readFileSync(engineering, "utf8");
|
|
@@ -2466,7 +2466,7 @@ function testManagedAgentsMigrationReplacesWholeFileAndArchivesPreviousRules() {
|
|
|
2466
2466
|
run("node", [cli, "sync", "--projects", repo]);
|
|
2467
2467
|
const agents = path.join(repo, "AGENTS.md");
|
|
2468
2468
|
const initial = fs.readFileSync(agents, "utf8");
|
|
2469
|
-
assert(initial.includes("managed-agents:start version=4.3.
|
|
2469
|
+
assert(initial.includes("managed-agents:start version=4.3.6"), "new projects should receive the versioned root AGENTS block");
|
|
2470
2470
|
|
|
2471
2471
|
const custom = [
|
|
2472
2472
|
"# Project rules",
|
|
@@ -2488,15 +2488,15 @@ function testManagedAgentsMigrationReplacesWholeFileAndArchivesPreviousRules() {
|
|
|
2488
2488
|
|
|
2489
2489
|
run("node", [cli, "sync", "--projects", repo]);
|
|
2490
2490
|
const migrated = fs.readFileSync(agents, "utf8");
|
|
2491
|
-
assert(migrated.includes("managed-agents:start version=4.3.
|
|
2491
|
+
assert(migrated.includes("managed-agents:start version=4.3.6"), "AGENTS migration should install the current managed block");
|
|
2492
2492
|
assert(!migrated.includes("Preserve this repository-specific rule exactly."), "root AGENTS must contain no project-specific tail");
|
|
2493
2493
|
assert(!migrated.includes("must execute `commands.gate_full`"), "known official conflicting rule should be removed");
|
|
2494
2494
|
const canonical = fs.readFileSync(path.join(repoRoot, "cli", "assets", "skill", "data", "templates", "bridges", "AGENTS.md"), "utf8");
|
|
2495
2495
|
assert(migrated === canonical, "root AGENTS must be byte-identical to the packaged canonical file");
|
|
2496
|
-
const archive = path.join(repo, ".agents", "archive", "auto-coding-skill", "4.3.
|
|
2496
|
+
const archive = path.join(repo, ".agents", "archive", "auto-coding-skill", "4.3.6", "AGENTS.md");
|
|
2497
2497
|
assert(fs.readFileSync(archive, "utf8").includes("Preserve this repository-specific rule exactly."), "previous AGENTS content must be archived once");
|
|
2498
2498
|
assert(!exists(legacyActiveArchive), "legacy active-doc AGENTS archives must leave docs/archive during upgrade");
|
|
2499
|
-
const migratedLegacyArchiveDir = path.join(repo, ".agents", "archive", "auto-coding-skill", "4.3.
|
|
2499
|
+
const migratedLegacyArchiveDir = path.join(repo, ".agents", "archive", "auto-coding-skill", "4.3.6", "docs", "archive", "workflow");
|
|
2500
2500
|
assert(
|
|
2501
2501
|
listProjectFiles(migratedLegacyArchiveDir).some(file => fs.readFileSync(file).equals(legacyActiveArchiveBytes)),
|
|
2502
2502
|
"legacy active-doc AGENTS archive bytes must survive under the managed archive root",
|
|
@@ -2554,7 +2554,7 @@ function testEngineeringMarkerBoundaryIsNormalized() {
|
|
|
2554
2554
|
const normalized = fs.readFileSync(engineering, "utf8");
|
|
2555
2555
|
assert(normalized === current, "sync should restore the exact managed document when text is glued to its end marker");
|
|
2556
2556
|
assert(!normalized.includes("# Project-specific workflow"), "project workflow text must not remain in the managed default document");
|
|
2557
|
-
const archive = path.join(repo, ".agents", "archive", "auto-coding-skill", "4.3.
|
|
2557
|
+
const archive = path.join(repo, ".agents", "archive", "auto-coding-skill", "4.3.6", "docs", "ENGINEERING.md");
|
|
2558
2558
|
assert(fs.readFileSync(archive, "utf8").includes(`${marker}# Project-specific workflow`), "the malformed previous document must remain available in history");
|
|
2559
2559
|
}
|
|
2560
2560
|
|
|
@@ -2571,7 +2571,7 @@ function testEngineeringFrameworkRejectsAnyNonCanonicalWorkflowText() {
|
|
|
2571
2571
|
|
|
2572
2572
|
run("node", [cli, "init"], { cwd: repo });
|
|
2573
2573
|
assert(!fs.readFileSync(engineering, "utf8").includes("backend owns APIs"), "init must restore the canonical ENGINEERING body");
|
|
2574
|
-
const archived = path.join(repo, ".agents", "archive", "auto-coding-skill", "4.3.
|
|
2574
|
+
const archived = path.join(repo, ".agents", "archive", "auto-coding-skill", "4.3.6", "docs", "ENGINEERING.md");
|
|
2575
2575
|
assert(fs.readFileSync(archived, "utf8").includes("backend owns APIs"), "removed project text should remain in non-authoritative history");
|
|
2576
2576
|
}
|
|
2577
2577
|
|
|
@@ -2583,12 +2583,12 @@ function testManagedInstallIntegrityIsBoundedAndRepairable() {
|
|
|
2583
2583
|
|
|
2584
2584
|
const manifestPath = path.join(repo, ".agents", "managed-install.json");
|
|
2585
2585
|
const manifest = JSON.parse(fs.readFileSync(manifestPath, "utf8"));
|
|
2586
|
-
assert(manifest.schema_version === 1 && manifest.skill_version === "4.3.
|
|
2586
|
+
assert(manifest.schema_version === 1 && manifest.skill_version === "4.3.6", "installed manifest must identify the release");
|
|
2587
2587
|
assert(manifest.entries.length > 0, "installed manifest must list managed files");
|
|
2588
2588
|
for (const entry of manifest.entries) {
|
|
2589
2589
|
assert(typeof entry.path === "string" && !path.isAbsolute(entry.path) && !entry.path.includes(".."), "manifest paths must be safe relative paths");
|
|
2590
2590
|
assert(/^[0-9a-f]{64}$/.test(entry.sha256), `${entry.path}: manifest hash must be sha256`);
|
|
2591
|
-
assert(entry.version === "4.3.
|
|
2591
|
+
assert(entry.version === "4.3.6" && typeof entry.executable === "boolean", `${entry.path}: version/executable metadata missing`);
|
|
2592
2592
|
}
|
|
2593
2593
|
assert(!manifest.managed_namespaces.some(item => item.path === ".agents" || item.path === "docs"), "manifest must not mirror entire project-owned trees");
|
|
2594
2594
|
|
|
@@ -2668,7 +2668,7 @@ function testSkillFeedbackCollectionIsBoundedReadOnlyAndMetadataOnly() {
|
|
|
2668
2668
|
run("node", [cli, "status", "--projects", third, "--json"], { check: false }).stdout,
|
|
2669
2669
|
).results[0];
|
|
2670
2670
|
assert(emptyStatus.feedback.available === true, "status must expose feedback before the first report");
|
|
2671
|
-
assert(emptyStatus.feedback.skillVersion === "4.3.
|
|
2671
|
+
assert(emptyStatus.feedback.skillVersion === "4.3.6", "empty feedback status must expose the installed Skill version");
|
|
2672
2672
|
const signature = `sha256:${"a".repeat(64)}`;
|
|
2673
2673
|
const marker = path.join(os.tmpdir(), `autocoding-feedback-must-not-execute-${crypto.randomUUID()}`);
|
|
2674
2674
|
const render = (project, reportId, privateMarker) => [
|
|
@@ -2678,7 +2678,7 @@ function testSkillFeedbackCollectionIsBoundedReadOnlyAndMetadataOnly() {
|
|
|
2678
2678
|
"status: open",
|
|
2679
2679
|
'created_at: "2026-07-18T10:00:00+08:00"',
|
|
2680
2680
|
`project: ${project}`,
|
|
2681
|
-
"observed_skill_version: 4.3.
|
|
2681
|
+
"observed_skill_version: 4.3.6",
|
|
2682
2682
|
"component: reviewer-runtime",
|
|
2683
2683
|
"kind: defect",
|
|
2684
2684
|
"impact: blocking",
|
|
@@ -2712,7 +2712,7 @@ function testSkillFeedbackCollectionIsBoundedReadOnlyAndMetadataOnly() {
|
|
|
2712
2712
|
.replace("schema: auto-coding-skill-feedback/v1", "schema: auto-coding-skill-feedback/v2")
|
|
2713
2713
|
.replace("status: open", `status: ${options.status ?? "open"}`)
|
|
2714
2714
|
.replace('created_at: "2026-07-18T10:00:00+08:00"', 'created_at: "2026-07-18T10:00:00+08:00"\nupdated_at: "2026-07-19T10:00:00+08:00"')
|
|
2715
|
-
.replace("observed_skill_version: 4.3.
|
|
2715
|
+
.replace("observed_skill_version: 4.3.6", `observed_skill_version: ${options.observed ?? "4.3.6"}\nlast_verified_skill_version: ${options.lastVerified ?? options.observed ?? "4.3.6"}`)
|
|
2716
2716
|
.replace(signature, options.signature)
|
|
2717
2717
|
.replace("export: metadata-only", `resolution: ${options.resolution ?? "pending"}\nexport: metadata-only`);
|
|
2718
2718
|
const firstReport = path.join(first, "docs", "skill-feedback", "reports", "2026-07-18-review-timeout-a13f82c1.md");
|
|
@@ -2776,7 +2776,7 @@ function testSkillFeedbackCollectionIsBoundedReadOnlyAndMetadataOnly() {
|
|
|
2776
2776
|
assert(lifecycleCheck.metadata.find(item => item.report_id === "ACSF-assets-20260718-fd5748e4")?.lifecycle === "regression-current", "a fixed signature reproduced on the fixed release must re-enter active triage as a regression");
|
|
2777
2777
|
writeFile(fixedReport, fixedContent);
|
|
2778
2778
|
|
|
2779
|
-
writeFile(firstOtherReport, firstOtherContent.replace("observed_skill_version: 4.3.
|
|
2779
|
+
writeFile(firstOtherReport, firstOtherContent.replace("observed_skill_version: 4.3.6", "observed_skill_version: 4.2.8"));
|
|
2780
2780
|
lifecycleCheck = JSON.parse(run("node", [cli, "feedback", "--projects", first, "--json"]).stdout);
|
|
2781
2781
|
assert(lifecycleCheck.metadata.find(item => item.report_id === "ACSF-geesight-20260718-c35fa4e3")?.lifecycle === "recheck-due", "an unresolved v1 report from an older Skill version must require recheck");
|
|
2782
2782
|
writeFile(firstOtherReport, firstOtherContent);
|
|
@@ -2826,14 +2826,14 @@ function testSkillFeedbackCollectionIsBoundedReadOnlyAndMetadataOnly() {
|
|
|
2826
2826
|
}
|
|
2827
2827
|
|
|
2828
2828
|
function testReleaseVersionMarkersStayInSync() {
|
|
2829
|
-
const expected = "4.3.
|
|
2829
|
+
const expected = "4.3.6";
|
|
2830
2830
|
const pkg = JSON.parse(fs.readFileSync(path.join(repoRoot, "package.json"), "utf8"));
|
|
2831
2831
|
const lock = JSON.parse(fs.readFileSync(path.join(repoRoot, "package-lock.json"), "utf8"));
|
|
2832
2832
|
const policy = JSON.parse(fs.readFileSync(
|
|
2833
2833
|
path.join(repoRoot, "src", "auto-coding-skill", "data", "policies", "workflow-migrations-v1.json"),
|
|
2834
2834
|
"utf8",
|
|
2835
2835
|
));
|
|
2836
|
-
assert(pkg.version === expected, "package version must match the 4.3.
|
|
2836
|
+
assert(pkg.version === expected, "package version must match the 4.3.6 release");
|
|
2837
2837
|
assert(lock.version === expected && lock.packages[""].version === expected, "package-lock versions must match");
|
|
2838
2838
|
assert(policy.managed_versions.engineering === expected && policy.managed_versions.agents === expected, "managed workflow versions must match");
|
|
2839
2839
|
const manifest = JSON.parse(fs.readFileSync(path.join(repoRoot, "cli", "assets", "managed-install.json"), "utf8"));
|
package/package.json
CHANGED
|
@@ -1,6 +1,6 @@
|
|
|
1
1
|
{
|
|
2
2
|
"name": "@elvis1513/auto-coding-skill",
|
|
3
|
-
"version": "4.3.
|
|
3
|
+
"version": "4.3.6",
|
|
4
4
|
"description": "CLI installer for a delivery-first .agents workflow with adaptive Git isolation, routed changed-scope validation, risk-based review, push completion, and safe cleanup.",
|
|
5
5
|
"type": "module",
|
|
6
6
|
"bin": {
|