@elvis1513/auto-coding-skill 4.2.1 → 4.2.2

This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
package/README.md CHANGED
@@ -9,7 +9,12 @@ The Skill is a selectable guardrail, not a command sequence that must run for
9
9
  every task. The model skips machinery whose expected benefit does not exceed its
10
10
  cost; read-only work and obvious small clean-checkout changes normally stay direct.
11
11
 
12
- Version 4.2.1 makes dirty/concurrent classification fail closed, bounds focused
12
+ Version 4.2.2 preserves project-owned risk and structure policy during upgrades,
13
+ restores explicit full and final changed-scope structure enforcement, makes
14
+ Reviewer assignments deadline-bound and directly executable, fixes task merge
15
+ status semantics, and updates Jenkins/target diagnostics for the current
16
+ `access.*` schema while retaining legacy fallback. Version 4.2.1 makes
17
+ dirty/concurrent classification fail closed, bounds focused
13
18
  review latency, provides a complete Reviewer result template, preserves the
14
19
  caller's runtime environment for routed commands, keeps non-authoritative Agent
15
20
  history out of structure findings, and distinguishes UI paths and mechanical
@@ -51,8 +56,9 @@ AGENTS.md (fully managed canonical repository contract)
51
56
 
52
57
  `autocoding init` also installs the exact shared documentation tree under
53
58
  `docs/{architecture,bugs,deployment,design,interfaces,project,reviews,testing}`.
54
- Managed templates are replaced; mutable project docs and valid architecture, ADR,
55
- interface, DD, review, or deploy-record documents are preserved; unrelated
59
+ Managed templates are replaced; the scaffolded project structure standard,
60
+ mutable project docs, and valid architecture, ADR, interface, DD, review, or
61
+ deploy-record documents are preserved; unrelated
56
62
  directories are archived under `.agents/archive/`. Re-running init is the complete upgrade operation;
57
63
  `sync` and project-local `upgrade` are compatibility commands, not required steps.
58
64
 
@@ -131,10 +137,8 @@ Dirty or parallel work receives an isolated task branch/worktree:
131
137
  python3 docs/tools/autopipeline/ap.py task-start T0002 \
132
138
  --owned-path backend --review-required
133
139
  # implement in the printed worktree
134
- python3 docs/tools/autopipeline/ap.py task-status T0002 --json
135
- python3 docs/tools/autopipeline/ap.py task-review T0002 \
136
- --verdict approved --diff-fingerprint "$CURRENT_DIFF_FINGERPRINT" \
137
- --reviewer "$REVIEWER_ID"
140
+ python3 docs/tools/autopipeline/ap.py review-run T0002 \
141
+ --reviewer "$REVIEWER_ID" --json
138
142
  python3 docs/tools/autopipeline/ap.py commit-push T0002 \
139
143
  --msg "T0002: bounded change"
140
144
  python3 docs/tools/autopipeline/ap.py task-integrate T0002
@@ -202,7 +206,9 @@ diagnostics outside normal closure.
202
206
 
203
207
  Registered tasks call `commit-push` directly because it performs or strictly
204
208
  reuses that final gate. Run `light-gate` manually only for unregistered normal Git
205
- closure or when explicitly requesting a fresh diagnostic pass.
209
+ closure or when explicitly requesting a fresh diagnostic pass. When project
210
+ `structure.enabled` is true, the same final gate also runs the changed-scope
211
+ structure check; `structure.enforcement: blocking` makes new violations fail.
206
212
 
207
213
  The recommended final closure defaults are 120 seconds per command and 180
208
214
  seconds total. Projects may raise them for measured affected-scope checks or set
@@ -224,12 +230,25 @@ never triggers a broader fallback.
224
230
  gateway, or production-configuration boundaries use 300-second deep review.
225
231
  Fixing Reviewer JSON formatting reuses the same analysis and never starts
226
232
  another substantive review.
233
+ - `review-assignment` writes the validated assignment under Git-local state with
234
+ the exact fingerprint, HEAD, scope revision, owning fixer, review depth, and
235
+ 90/300-second deadline. Reissuing the same live assignment is idempotent;
236
+ expired or completed attempts cannot be silently renewed, and late results are
237
+ rejected by `task-review`.
238
+ - `review-run` is the default executable path: it creates/reuses that assignment,
239
+ starts a separate `codex exec` session in read-only mode, removes the parent
240
+ lifecycle identity, and supervises the full process group against the original
241
+ remaining deadline. Timeout performs TERM then KILL, records a Git-local blocked
242
+ receipt, and cannot be converted into approval. Plain `review-assignment` remains
243
+ available only when another host can enforce the deadline itself; it does not
244
+ stop an in-app subagent.
227
245
  - DD/ADR is created only for lasting cross-module, API, data, security,
228
246
  deployment, or key user-flow decisions.
229
247
  - Historical debt does not block product work unless the current change worsens it.
230
248
 
231
- Before returning a Reviewer result, generate the complete 16-field skeleton from
232
- the validated assignment, then fill its summary, evidence, findings, and risks:
249
+ Before returning a Reviewer result, use the absolute assignment path printed by
250
+ `review-assignment` to generate the complete 16-field skeleton, then fill its
251
+ summary, evidence, findings, and risks:
233
252
 
234
253
  ```bash
235
254
  python3 docs/tools/autopipeline/ap.py agent-result-template \
@@ -259,8 +278,32 @@ autocoding status --projects /path/a,/path/b
259
278
 
260
279
  Init replaces the managed Skill, root `AGENTS.md`, managed agents, ENGINEERING
261
280
  schema/body, runtime launcher, and documentation framework. It preserves explicit
262
- model overrides and current values at supported project/access/concurrency/route
263
- fields. Removed content is archived outside active docs.
281
+ model overrides, complete project `risk.rules`, supported project/access/
282
+ concurrency/route/structure values, and an existing project-owned structure
283
+ standard byte-for-byte. Removed content is archived outside active docs.
284
+
285
+ ## What changed in 4.2.2
286
+
287
+ - Classified root and nested `package.json` files as `release_or_tooling` high-risk
288
+ changes requiring review, and added upgrade regression coverage that preserves
289
+ complete project `risk.rules` instead of deleting partially overlapping rules.
290
+ - Honored explicit `structure-check --scope full`, included tracked and unignored
291
+ untracked files, and restored the enabled structure check inside the final
292
+ changed-scope gate. Init now preserves supported strict structure settings and
293
+ treats `docs/architecture/structure-standard.md` as scaffold-once project policy.
294
+ - Added `review-run` with a validated Git-local assignment, fixed 90/300-second
295
+ process-group supervision, one attempt per fingerprint, Reviewer identity/HEAD/
296
+ scope binding, safe result normalization, and late-result rejection. The child
297
+ runs as a separate read-only Codex process without the lifecycle-owner identity;
298
+ the documented template command uses the complete
299
+ `python3 docs/tools/autopipeline/ap.py ...` invocation.
300
+ - Added `has_task_commits` and prevented a no-commit task from reporting
301
+ `merged_into_target=true` merely because its baseline equals the target tip.
302
+ - Updated `verify-jenkins`, `verify-jenkins-build`, `verify-target`, and target
303
+ health checks to prefer `access.jenkins.<component>` and
304
+ `access.project.<component>`, fail before network activity on missing or
305
+ ambiguous endpoints, isolate Jenkins crumbs by URL and username, and preserve
306
+ legacy `jenkins.*` / `target_env.*` compatibility.
264
307
 
265
308
  ## What changed in 4.2.1
266
309
 
@@ -8,7 +8,7 @@ developer_instructions = """
8
8
 
9
9
  工作要求:
10
10
  1. 只审查主代理给定的 task_id、base_sha、diff_base、diff_head、diff_fingerprint 和 owning_fixer;确认 diff 稳定后再开始。
11
- 2. 若主代理指定 focused review,只对给定的稳定 diff 和相关 evidence 做一次实质分析,不扩展为全库扫描。90 秒超时即返回 `status=blocked`、`verdict=blocked`;此时不得调用 `task-review`。
11
+ 2. 若主代理指定 focused review,只对给定的稳定 diff 和相关 evidence 做一次实质分析,不扩展为全库扫描。运行器会在 90 秒截止点终止整个 Reviewer 进程组;若你在终止前已发现无法继续,则返回 `status=blocked`、`verdict=blocked`。
12
12
  3. 跨模块、并行 writer,以及 API、鉴权、数据库、支付、文件传输、网关、生产配置边界使用 deep review,预算 300 秒;仍然只审查主代理交付的范围。
13
13
  4. 优先检查:正确性、安全性、边界条件、异常路径、并发风险、事务一致性、缓存一致性、兼容性。
14
14
  5. 结构/优化 review 仅在已有 baseline/backlog 时读取;可选文档缺失不构成 blocker,不重复报告 accepted debt。
@@ -24,7 +24,7 @@ developer_instructions = """
24
24
  11. 发现测试不足时,指出应补哪些测试或验证路径。
25
25
  12. 实质结论必须是 approved、changes-requested 或 blocked;changes-requested 只返回 owning_fixer,修改后必须绑定新的 diff fingerprint。代码、配置或行为语义变化需要重新审查;仅链接、归档索引、状态措辞等机械文档修正,可由同一 reviewer 只做 targeted recheck,不必重跑完整审计。
26
26
  13. 不修改代码,不提交、不推送、不集成、不清理分支;审查不扩展本地门禁。
27
- 14. 输出前运行 `agent-result-template --file <assignment.json> --verdict <approved|changes-requested|blocked>`,从已验证 assignment 生成包含全部 16 个必填字段的骨架,然后填入本次分析的 summary、evidence、findings 和 risks。最终只返回该 JSON 对象,不要 Markdown 或代码围栏。最小完整形状为:
27
+ 14. 使用 `review-run` 在提示和 `AUTOCODING_REVIEW_ASSIGNMENT` 环境变量中传入的 assignment JSON;在其中的 `deadline_at` 前完成实质审查。输出前运行 `python3 docs/tools/autopipeline/ap.py agent-result-template --file <assignment.json> --verdict <approved|changes-requested|blocked>`,从已验证 assignment 生成包含全部 16 个必填字段的骨架,然后填入本次分析的 summary、evidence、findings 和 risks。最终只返回该 JSON 对象,不要 Markdown 或代码围栏。最小完整形状为:
28
28
  {
29
29
  "contract_version": 1,
30
30
  "node_id": "<assignment.node_id>",
@@ -33,7 +33,7 @@ developer_instructions = """
33
33
  "base_sha": "<assignment.base_sha>",
34
34
  "status": "completed",
35
35
  "summary": "<review summary>",
36
- "depends_on": [],
36
+ "depends_on": ["<assignment.owning_fixer>"],
37
37
  "owned_paths": [],
38
38
  "changed_paths": [],
39
39
  "diff_fingerprint": "<assignment.diff_fingerprint>",
@@ -1 +1 @@
1
- {"schema_version":1,"skill_version":"4.2.1","manifest_path":".agents/managed-install.json","entries":[{"path":".agents/agents/browser-debugger.toml","source":"agents/browser-debugger.toml","ownership":"normalized-agent","sha256":"40727952944917eb0b573bb96dca2906c27bc794737f3b6b392b56df7b4208aa","executable":false,"scope":"shared","version":"4.2.1"},{"path":".agents/agents/docs-researcher.toml","source":"agents/docs-researcher.toml","ownership":"normalized-agent","sha256":"aa1fed6a6a1cde282fc152c7a88b8e097a6c53bcf447d35978607d594e3cb3e4","executable":false,"scope":"shared","version":"4.2.1"},{"path":".agents/agents/explorer.toml","source":"agents/explorer.toml","ownership":"normalized-agent","sha256":"4cd89888acf7c0c04fbbcd0b9a0f346c6efed42fb723ec2037af9331a84a1cac","executable":false,"scope":"shared","version":"4.2.1"},{"path":".agents/agents/fixer.toml","source":"agents/fixer.toml","ownership":"normalized-agent","sha256":"7bc00a45b9d1bcc90b8b0f06d773556eba1d52effff664472c3cb81073f6abfb","executable":false,"scope":"shared","version":"4.2.1"},{"path":".agents/agents/reviewer.toml","source":"agents/reviewer.toml","ownership":"normalized-agent","sha256":"3b840eed1c60769f8fc8bff5cac62b1ff0dd1596e33dbb14ae33961289991894","executable":false,"scope":"shared","version":"4.2.1"},{"path":".agents/skills/auto-coding-skill/SKILL.md","source":"skill/SKILL.md","ownership":"exact","sha256":"078e2b8d0b4396ad7788f579c7338bc0bf9aecc717132ee90c745286aa06f128","executable":false,"scope":"shared","version":"4.2.1"},{"path":".agents/skills/auto-coding-skill/data/contracts/orchestration-v1.schema.json","source":"skill/data/contracts/orchestration-v1.schema.json","ownership":"exact","sha256":"3a93c2bfbb236e5bc41b7ab75a67ff56e7ad3535adc229518b45c2f9fd8707e3","executable":false,"scope":"shared","version":"4.2.1"},{"path":".agents/skills/auto-coding-skill/data/policies/workflow-migrations-v1.json","source":"skill/data/policies/workflow-migrations-v1.json","ownership":"exact","sha256":"2db18e040260ff3e7d0108f8f9a9f2c2a39ead2ca16117f5f6b2480cce9d5c16","executable":false,"scope":"shared","version":"4.2.1"},{"path":".agents/skills/auto-coding-skill/data/templates/ENGINEERING.md","source":"skill/data/templates/ENGINEERING.md","ownership":"exact","sha256":"0b493750f90b93fbb86cf3813fcf42b7e23780e93eedaa2416eaa38c1a91b033","executable":false,"scope":"shared","version":"4.2.1"},{"path":".agents/skills/auto-coding-skill/data/templates/bridges/AGENTS.md","source":"skill/data/templates/bridges/AGENTS.md","ownership":"exact","sha256":"ae9912b53d26cdba3b753e00a59184127fe0850d4ce324bdabfd1c7454f9dbb0","executable":false,"scope":"shared","version":"4.2.1"},{"path":".agents/skills/auto-coding-skill/data/templates/tools/ap.py","source":"skill/data/templates/tools/ap.py","ownership":"exact","sha256":"c352fbf2cbcb9692a34fd952d8541b1cbe6d475c6e11e64500a1f6b5283a00be","executable":false,"scope":"shared","version":"4.2.1"},{"path":".agents/skills/auto-coding-skill/requirements.txt","source":"skill/requirements.txt","ownership":"exact","sha256":"0969da99a0bc2a1b71ed50584560f4588a37567ac63af3ddbaf3c4617ca5621a","executable":false,"scope":"shared","version":"4.2.1"},{"path":".agents/skills/auto-coding-skill/scripts/ap.py","source":"skill/scripts/ap.py","ownership":"exact","sha256":"cf61031e542fd2c8f83f9ed48a3dea815b68bdbb5a1edaf79fb5f39178480920","executable":false,"scope":"shared","version":"4.2.1"},{"path":".agents/skills/auto-coding-skill/scripts/core.py","source":"skill/scripts/core.py","ownership":"exact","sha256":"640c37e8b274d90d6b7765d4243e054360d5a5a85b3150fbfe6449527c1cd28f","executable":true,"scope":"shared","version":"4.2.1"},{"path":".agents/skills/auto-coding-skill/scripts/http_checks.py","source":"skill/scripts/http_checks.py","ownership":"exact","sha256":"5620e187a0129f135621425a84b3a4e8f31137263c7e549a36a801fc36ff54ea","executable":false,"scope":"shared","version":"4.2.1"},{"path":".agents/skills/auto-coding-skill/scripts/install_integrity.py","source":"skill/scripts/install_integrity.py","ownership":"exact","sha256":"20b0424152d61b3c067feb9558dd2532ab3abb459fc71a4c7de915e95bd83696","executable":false,"scope":"shared","version":"4.2.1"},{"path":".agents/skills/auto-coding-skill/scripts/scaffold_templates.py","source":"skill/scripts/scaffold_templates.py","ownership":"exact","sha256":"c825f15591b41403b7a97877c17f66cddcbbc5b029d143a7f1252e85388608e1","executable":false,"scope":"shared","version":"4.2.1"},{"path":"AGENTS.md","source":"skill/data/templates/bridges/AGENTS.md","ownership":"exact","sha256":"ae9912b53d26cdba3b753e00a59184127fe0850d4ce324bdabfd1c7454f9dbb0","executable":false,"scope":"project","version":"4.2.1"},{"path":"docs/ENGINEERING.md","source":"skill/data/templates/ENGINEERING.md#managed-workflow","ownership":"managed-workflow","sha256":"c8f768515a6d89145d1ce117d21b01f2e9481819ec2f8d6838a9f8788e1b1249","executable":false,"scope":"project","version":"4.2.1"},{"path":"docs/architecture/adr/_TEMPLATE-ADR.md","source":"generated:scaffold_templates:docs/architecture/adr/_TEMPLATE-ADR.md","ownership":"exact","sha256":"88c89065ae0f8555412dbe096c05342152efc7becae8d8981e6442cdfee8e672","executable":false,"scope":"project","version":"4.2.1"},{"path":"docs/architecture/structure-standard.md","source":"generated:scaffold_templates:docs/architecture/structure-standard.md","ownership":"exact","sha256":"aa2e9bbf1baad0f3a3e0e97aaaefee7282740f09a976b1bb9be7fa0b529a549a","executable":false,"scope":"project","version":"4.2.1"},{"path":"docs/deployment/deploy-records/_TEMPLATE-DEPLOY-RECORD.md","source":"generated:scaffold_templates:docs/deployment/deploy-records/_TEMPLATE-DEPLOY-RECORD.md","ownership":"exact","sha256":"f2c17c0febc322b0ad50fb9d6f7e64e6c0cfb15c8a3e445a99da40f0a0dd1901","executable":false,"scope":"project","version":"4.2.1"},{"path":"docs/design/_TEMPLATE-DD.md","source":"generated:scaffold_templates:docs/design/_TEMPLATE-DD.md","ownership":"exact","sha256":"6ca022d127bfff68521f466b60bace4f1206baf0913daa855b9f751e74198db3","executable":false,"scope":"project","version":"4.2.1"},{"path":"docs/reviews/_TEMPLATE-REVIEW.md","source":"generated:scaffold_templates:docs/reviews/_TEMPLATE-REVIEW.md","ownership":"exact","sha256":"134f0d1bd3c7a317ef3cf4c2aea9f0539f3d53dccd5bcdabf6915b3629ef8802","executable":false,"scope":"project","version":"4.2.1"},{"path":"docs/tools/autopipeline/ap.py","source":"skill/data/templates/tools/ap.py","ownership":"exact","sha256":"c352fbf2cbcb9692a34fd952d8541b1cbe6d475c6e11e64500a1f6b5283a00be","executable":false,"scope":"project","version":"4.2.1"}],"managed_namespaces":[{"path":".agents/skills/auto-coding-skill","scope":"shared"},{"path":"docs/tools/autopipeline","scope":"project"}],"preserved":[".agents/archive/**",".agents/agents/* (except paths listed in entries)","docs/project/**","docs/architecture/adr/[0-9]*.md","docs/design/*.md","docs/interfaces/*.md","docs/deployment/deploy-records/*.md","docs/reviews/*.md"]}
1
+ {"schema_version":1,"skill_version":"4.2.2","manifest_path":".agents/managed-install.json","entries":[{"path":".agents/agents/browser-debugger.toml","source":"agents/browser-debugger.toml","ownership":"normalized-agent","sha256":"40727952944917eb0b573bb96dca2906c27bc794737f3b6b392b56df7b4208aa","executable":false,"scope":"shared","version":"4.2.2"},{"path":".agents/agents/docs-researcher.toml","source":"agents/docs-researcher.toml","ownership":"normalized-agent","sha256":"aa1fed6a6a1cde282fc152c7a88b8e097a6c53bcf447d35978607d594e3cb3e4","executable":false,"scope":"shared","version":"4.2.2"},{"path":".agents/agents/explorer.toml","source":"agents/explorer.toml","ownership":"normalized-agent","sha256":"4cd89888acf7c0c04fbbcd0b9a0f346c6efed42fb723ec2037af9331a84a1cac","executable":false,"scope":"shared","version":"4.2.2"},{"path":".agents/agents/fixer.toml","source":"agents/fixer.toml","ownership":"normalized-agent","sha256":"7bc00a45b9d1bcc90b8b0f06d773556eba1d52effff664472c3cb81073f6abfb","executable":false,"scope":"shared","version":"4.2.2"},{"path":".agents/agents/reviewer.toml","source":"agents/reviewer.toml","ownership":"normalized-agent","sha256":"d68c472fab6aef7679330798d753b3c495515545522b6f0a54cabccc0f523c39","executable":false,"scope":"shared","version":"4.2.2"},{"path":".agents/skills/auto-coding-skill/SKILL.md","source":"skill/SKILL.md","ownership":"exact","sha256":"d32bcb8c79e21403bfdce45ede78719b5c992d1a7b9b0064327212dad7c35691","executable":false,"scope":"shared","version":"4.2.2"},{"path":".agents/skills/auto-coding-skill/data/contracts/orchestration-v1.schema.json","source":"skill/data/contracts/orchestration-v1.schema.json","ownership":"exact","sha256":"0e8d5ebb06b47414be1218a1fc93cdbba94a7300fc7ba1c0e12d9c1ca60aeb43","executable":false,"scope":"shared","version":"4.2.2"},{"path":".agents/skills/auto-coding-skill/data/policies/workflow-migrations-v1.json","source":"skill/data/policies/workflow-migrations-v1.json","ownership":"exact","sha256":"ce3786b60d65e4502c465ad33c2e6e105f996b067a315d382bf524797357644a","executable":false,"scope":"shared","version":"4.2.2"},{"path":".agents/skills/auto-coding-skill/data/templates/ENGINEERING.md","source":"skill/data/templates/ENGINEERING.md","ownership":"exact","sha256":"3cd9dd02232897043ed9ff73e5076817dc4660696c8dfc8b06f4e5bad3158aad","executable":false,"scope":"shared","version":"4.2.2"},{"path":".agents/skills/auto-coding-skill/data/templates/bridges/AGENTS.md","source":"skill/data/templates/bridges/AGENTS.md","ownership":"exact","sha256":"d32e8d147dd5f75cc63915bd0fe18bd4b0dd400abc8765e6986f5aed127dd585","executable":false,"scope":"shared","version":"4.2.2"},{"path":".agents/skills/auto-coding-skill/data/templates/tools/ap.py","source":"skill/data/templates/tools/ap.py","ownership":"exact","sha256":"c352fbf2cbcb9692a34fd952d8541b1cbe6d475c6e11e64500a1f6b5283a00be","executable":false,"scope":"shared","version":"4.2.2"},{"path":".agents/skills/auto-coding-skill/requirements.txt","source":"skill/requirements.txt","ownership":"exact","sha256":"0969da99a0bc2a1b71ed50584560f4588a37567ac63af3ddbaf3c4617ca5621a","executable":false,"scope":"shared","version":"4.2.2"},{"path":".agents/skills/auto-coding-skill/scripts/ap.py","source":"skill/scripts/ap.py","ownership":"exact","sha256":"a8c157b3590dbd7619c1b8e99188b118174cc25d3a2162b598b7db01093f9fb1","executable":false,"scope":"shared","version":"4.2.2"},{"path":".agents/skills/auto-coding-skill/scripts/core.py","source":"skill/scripts/core.py","ownership":"exact","sha256":"640c37e8b274d90d6b7765d4243e054360d5a5a85b3150fbfe6449527c1cd28f","executable":true,"scope":"shared","version":"4.2.2"},{"path":".agents/skills/auto-coding-skill/scripts/http_checks.py","source":"skill/scripts/http_checks.py","ownership":"exact","sha256":"5620e187a0129f135621425a84b3a4e8f31137263c7e549a36a801fc36ff54ea","executable":false,"scope":"shared","version":"4.2.2"},{"path":".agents/skills/auto-coding-skill/scripts/install_integrity.py","source":"skill/scripts/install_integrity.py","ownership":"exact","sha256":"a9ca7bd67893bbd2d7b35ece30a40457f0cbcb9ae01580cfc5daca2cd96fd676","executable":false,"scope":"shared","version":"4.2.2"},{"path":".agents/skills/auto-coding-skill/scripts/scaffold_templates.py","source":"skill/scripts/scaffold_templates.py","ownership":"exact","sha256":"6f0ee92eff2d5db9627a64b332738c9c917a93cc559d5bbacf771c5966215821","executable":false,"scope":"shared","version":"4.2.2"},{"path":"AGENTS.md","source":"skill/data/templates/bridges/AGENTS.md","ownership":"exact","sha256":"d32e8d147dd5f75cc63915bd0fe18bd4b0dd400abc8765e6986f5aed127dd585","executable":false,"scope":"project","version":"4.2.2"},{"path":"docs/ENGINEERING.md","source":"skill/data/templates/ENGINEERING.md#managed-workflow","ownership":"managed-workflow","sha256":"c6bbd049e3939e503238b08a7f933bb371d1f63cf16aaab737925f4208563679","executable":false,"scope":"project","version":"4.2.2"},{"path":"docs/architecture/adr/_TEMPLATE-ADR.md","source":"generated:scaffold_templates:docs/architecture/adr/_TEMPLATE-ADR.md","ownership":"exact","sha256":"88c89065ae0f8555412dbe096c05342152efc7becae8d8981e6442cdfee8e672","executable":false,"scope":"project","version":"4.2.2"},{"path":"docs/deployment/deploy-records/_TEMPLATE-DEPLOY-RECORD.md","source":"generated:scaffold_templates:docs/deployment/deploy-records/_TEMPLATE-DEPLOY-RECORD.md","ownership":"exact","sha256":"f2c17c0febc322b0ad50fb9d6f7e64e6c0cfb15c8a3e445a99da40f0a0dd1901","executable":false,"scope":"project","version":"4.2.2"},{"path":"docs/design/_TEMPLATE-DD.md","source":"generated:scaffold_templates:docs/design/_TEMPLATE-DD.md","ownership":"exact","sha256":"6ca022d127bfff68521f466b60bace4f1206baf0913daa855b9f751e74198db3","executable":false,"scope":"project","version":"4.2.2"},{"path":"docs/reviews/_TEMPLATE-REVIEW.md","source":"generated:scaffold_templates:docs/reviews/_TEMPLATE-REVIEW.md","ownership":"exact","sha256":"134f0d1bd3c7a317ef3cf4c2aea9f0539f3d53dccd5bcdabf6915b3629ef8802","executable":false,"scope":"project","version":"4.2.2"},{"path":"docs/tools/autopipeline/ap.py","source":"skill/data/templates/tools/ap.py","ownership":"exact","sha256":"c352fbf2cbcb9692a34fd952d8541b1cbe6d475c6e11e64500a1f6b5283a00be","executable":false,"scope":"project","version":"4.2.2"}],"managed_namespaces":[{"path":".agents/skills/auto-coding-skill","scope":"shared"},{"path":"docs/tools/autopipeline","scope":"project"}],"preserved":[".agents/archive/**",".agents/agents/* (except paths listed in entries)","docs/project/**","docs/architecture/structure-standard.md","docs/architecture/adr/[0-9]*.md","docs/design/*.md","docs/interfaces/*.md","docs/deployment/deploy-records/*.md","docs/reviews/*.md"]}
@@ -33,18 +33,15 @@ value exceeds coordination cost, and keep `forbidden` off absent user override.
33
33
  `dirty_paths`, and `active_writer`, and reclassify if state changes before writing.
34
34
  Same-owner claims conflict unless continuing the exact ID; `change_nature` never bypasses a rule or review.
35
35
 
36
- Use the registered lifecycle only when classification requires isolation or
37
- fingerprinted review, or when the user explicitly requests it:
36
+ Use the registered lifecycle only when classification requires isolation/fingerprinted review or the user explicitly requests it:
38
37
 
39
38
  ```bash
40
39
  python3 docs/tools/autopipeline/ap.py task-start T0001 \
41
40
  --owned-path src [--isolated] [--review-required] [--continue-direct --direct-claim <ID>]
42
41
  # Before the first commit, expand an active task instead of restarting it:
43
42
  python3 docs/tools/autopipeline/ap.py task-scope-add T0001 --owned-path config/new-scope
44
- # For review-required work, obtain the current fingerprint and approve it:
45
- python3 docs/tools/autopipeline/ap.py task-status T0001 --json
46
- python3 docs/tools/autopipeline/ap.py task-review T0001 \
47
- --verdict approved --diff-fingerprint <CURRENT_DIFF_FINGERPRINT> --reviewer <REVIEWER_ID>
43
+ # Run a read-only Reviewer under its fixed deadline and record the bound result:
44
+ python3 docs/tools/autopipeline/ap.py review-run T0001 --reviewer <REVIEWER_ID> --json
48
45
  python3 docs/tools/autopipeline/ap.py commit-push T0001 --msg "T0001: summary"
49
46
  # Isolated tasks only:
50
47
  python3 docs/tools/autopipeline/ap.py task-integrate T0001
@@ -55,11 +52,13 @@ Each parallel writer uses a task ID, worktree, lease, dependency SHAs, and disti
55
52
  with `agent-contract-check`; parallel fixers require reclassification with
56
53
  `--writers >1`.
57
54
 
58
- Use the existing `reviewer` Agent at `xhigh` and follow the plan: focused means one
59
- 90-second analysis; deep gets 300 seconds for parallel/cross-module or sensitive
60
- boundaries. Timeout is `blocked` and is not sent to `task-review`. Generate all 16
61
- fields with `agent-result-template`; contract checking aggregates errors, and shape
62
- repair must reuse the same analysis.
55
+ Use `reviewer` at `xhigh`: focused gets 90 seconds; parallel/cross-module or sensitive
56
+ boundaries get 300. `review-run` creates the assignment, launches a separate read-only
57
+ Codex process without the lifecycle-owner identity, terminates its process group at the
58
+ deadline, and records only an exact HEAD/scope/fingerprint match. Timeout is `blocked`.
59
+ `review-assignment` alone requires another deadline-capable host and cannot stop an
60
+ in-app subagent. `agent-result-template` supplies all 16 fields; `review-run` safely
61
+ normalizes presentation fields from the same analysis.
63
62
 
64
63
  ## Close with the bounded routed gate
65
64
 
@@ -124,6 +124,28 @@
124
124
  "owning_fixer": {
125
125
  "type": "string",
126
126
  "minLength": 1
127
+ },
128
+ "review_depth": {
129
+ "enum": [
130
+ "focused",
131
+ "deep"
132
+ ]
133
+ },
134
+ "timeout_seconds": {
135
+ "type": "integer",
136
+ "minimum": 1
137
+ },
138
+ "issued_at": {
139
+ "type": "string",
140
+ "minLength": 1
141
+ },
142
+ "deadline_at": {
143
+ "type": "string",
144
+ "minLength": 1
145
+ },
146
+ "scope_revision": {
147
+ "type": "integer",
148
+ "minimum": 1
127
149
  }
128
150
  },
129
151
  "allOf": [
@@ -1,8 +1,8 @@
1
1
  {
2
2
  "schema_version": 1,
3
3
  "managed_versions": {
4
- "agents": "4.2.1",
5
- "engineering": "4.2.1"
4
+ "agents": "4.2.2",
5
+ "engineering": "4.2.2"
6
6
  },
7
7
  "known_official_agents_sha256": [
8
8
  "ebaaadab60327b3a4852948443d7191a4d48cb00bf4910038ab78c9149089373"
@@ -1,6 +1,6 @@
1
1
  ---
2
2
  workflow:
3
- skill_version: "4.2.1"
3
+ skill_version: "4.2.2"
4
4
  mode: "dev"
5
5
  profile: "auto"
6
6
  completion: "push"
@@ -82,7 +82,7 @@ docs:
82
82
  api_change_log: "docs/interfaces/api-change-log.md"
83
83
  ---
84
84
  # Engineering Configuration and Project Facts
85
- <!-- auto-coding-skill:managed-workflow:start version=4.2.1 -->
85
+ <!-- auto-coding-skill:managed-workflow:start version=4.2.2 -->
86
86
  Root `AGENTS.md` is the single shared behavioral protocol. The installed
87
87
  `SKILL.md` contains invocation guidance. This file is the exact-schema source for
88
88
  project workflow configuration and access values that neither file can infer.
@@ -1,4 +1,4 @@
1
- <!-- auto-coding-skill:managed-agents:start version=4.2.1 -->
1
+ <!-- auto-coding-skill:managed-agents:start version=4.2.2 -->
2
2
  # Shared Engineering Protocol
3
3
 
4
4
  This file is fully managed by `auto-coding-skill`. Keep project-specific facts,
@@ -82,8 +82,13 @@ failure may continue in the same conversation/task without a second lifecycle.
82
82
  - Keep `reviewer` at `xhigh`: focused is one 90-second analysis; deep gets 300
83
83
  seconds for parallel/cross-module or sensitive boundaries. Timeout is `blocked`
84
84
  and is not sent to `task-review`.
85
- - Generate all 16 fields with `agent-result-template`; contract checking aggregates
86
- errors, and JSON shape repair reuses the same analysis.
85
+ - Run `python3 docs/tools/autopipeline/ap.py review-run <TASK> --reviewer <ID> --json`.
86
+ It launches a separate read-only Codex process without the lifecycle-owner identity,
87
+ stops its process group at the fixed deadline, and records only the assigned HEAD,
88
+ scope, identity, and fingerprint. `review-assignment` alone requires a different
89
+ deadline-capable host and cannot stop an in-app subagent.
90
+ - `agent-result-template` supplies all 16 fields; contract checking aggregates errors,
91
+ and `review-run` safely normalizes presentation fields from the same analysis.
87
92
  - Review blocks only defects introduced or worsened in the promised scope.
88
93
  Adjacent existing issues are non-blocking follow-ups.
89
94
  - Semantic changes invalidate approval. Mechanical documentation-only corrections