@elvis1513/auto-coding-skill 2.2.1 → 3.0.1
This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
- package/README.md +178 -46
- package/cli/assets/agents/browser-debugger.toml +5 -7
- package/cli/assets/agents/docs-researcher.toml +3 -5
- package/cli/assets/agents/explorer.toml +5 -10
- package/cli/assets/agents/fixer.toml +19 -17
- package/cli/assets/agents/reviewer.toml +14 -10
- package/cli/assets/skill/SKILL.md +152 -37
- package/cli/assets/skill/data/contracts/orchestration-v1.schema.json +475 -0
- package/cli/assets/skill/data/templates/ENGINEERING.md +226 -74
- package/cli/assets/skill/data/templates/bridges/AGENTS.md +4 -4
- package/cli/assets/skill/data/templates/docs/tasks/closure-log.md +7 -6
- package/cli/assets/skill/data/templates/docs/tasks/taskbook.md +11 -4
- package/cli/assets/skill/scripts/ap.py +3296 -545
- package/cli/src/index.js +411 -51
- package/cli/tests/ap_concurrency_test.py +1578 -0
- package/cli/tests/ap_profiles_test.py +242 -98
- package/cli/tests/index.test.js +410 -15
- package/package.json +4 -4
|
@@ -13,7 +13,7 @@ import yaml
|
|
|
13
13
|
|
|
14
14
|
|
|
15
15
|
REPO_ROOT = Path(__file__).resolve().parents[2]
|
|
16
|
-
SCRIPT_DIR = REPO_ROOT / "
|
|
16
|
+
SCRIPT_DIR = REPO_ROOT / "src" / "auto-coding-skill" / "scripts"
|
|
17
17
|
sys.path.insert(0, str(SCRIPT_DIR))
|
|
18
18
|
|
|
19
19
|
import ap # noqa: E402
|
|
@@ -26,8 +26,23 @@ def run(repo: Path, *args: str) -> None:
|
|
|
26
26
|
|
|
27
27
|
def base_config() -> dict:
|
|
28
28
|
return {
|
|
29
|
-
"workflow": {"mode": "dev", "profile": "auto"},
|
|
29
|
+
"workflow": {"mode": "dev", "profile": "auto", "completion": "push"},
|
|
30
|
+
"concurrency": {"isolation": "worktree"},
|
|
30
31
|
"project": {"name": "profile-test"},
|
|
32
|
+
"access": {
|
|
33
|
+
"project": {
|
|
34
|
+
"frontend": {"url": "https://project-front.test", "username": "front", "password": "front-pass"},
|
|
35
|
+
"backend": {"url": "https://project-back.test", "username": "back", "password": "back-pass"},
|
|
36
|
+
},
|
|
37
|
+
"jenkins": {
|
|
38
|
+
"frontend": {"url": "https://jenkins-front.test", "username": "front", "password": "front-pass"},
|
|
39
|
+
"backend": {"url": "https://jenkins-back.test", "username": "back", "password": "back-pass"},
|
|
40
|
+
},
|
|
41
|
+
"gitlab": {"url": "https://gitlab.test", "username": "git", "password": "git-pass"},
|
|
42
|
+
"nexus": {
|
|
43
|
+
"frontend": {"url": "https://nexus.test", "username": "nexus", "password": "nexus-pass"},
|
|
44
|
+
},
|
|
45
|
+
},
|
|
31
46
|
"commands": {
|
|
32
47
|
"gate_changed": "true",
|
|
33
48
|
"gate_standard": "true",
|
|
@@ -154,6 +169,12 @@ class AutoCodingProfileTests(unittest.TestCase):
|
|
|
154
169
|
fix_commit=None,
|
|
155
170
|
)
|
|
156
171
|
|
|
172
|
+
@staticmethod
|
|
173
|
+
def record_closure(repo: Path, args: argparse.Namespace) -> Path:
|
|
174
|
+
with mock.patch.object(ap, "_require_task_context", return_value={"task_id": args.task_id}):
|
|
175
|
+
ap.cmd_record_closure(args)
|
|
176
|
+
return repo / "docs" / "tasks" / "closures" / f"{args.task_id}.md"
|
|
177
|
+
|
|
157
178
|
def test_docs_only_resolves_micro(self) -> None:
|
|
158
179
|
repo, cfg = self.make_repo("docs/security-auth-notes.md")
|
|
159
180
|
plan = self.plan(repo, cfg)
|
|
@@ -161,15 +182,69 @@ class AutoCodingProfileTests(unittest.TestCase):
|
|
|
161
182
|
self.assertEqual("changed", plan["selected_scope"])
|
|
162
183
|
self.assertEqual("dev", plan["effective_mode"])
|
|
163
184
|
self.assertEqual([], plan["recommended_agents"])
|
|
185
|
+
self.assertEqual("main-only", plan["agent_plan"]["strategy"])
|
|
186
|
+
self.assertEqual(1, plan["contract_version"])
|
|
187
|
+
self.assertEqual("data/contracts/orchestration-v1.schema.json", plan["contract_schema"])
|
|
188
|
+
for field in [
|
|
189
|
+
"contract_version",
|
|
190
|
+
"contract_schema",
|
|
191
|
+
"policies",
|
|
192
|
+
"assignment_contract",
|
|
193
|
+
"result_contract",
|
|
194
|
+
"stages",
|
|
195
|
+
"constraints",
|
|
196
|
+
]:
|
|
197
|
+
self.assertIn(field, plan["agent_plan"])
|
|
198
|
+
|
|
199
|
+
def test_planned_files_and_intent_drive_classification_without_polluting_changed_files(self) -> None:
|
|
200
|
+
repo, cfg = self.make_repo()
|
|
201
|
+
plan = self.plan(
|
|
202
|
+
repo,
|
|
203
|
+
cfg,
|
|
204
|
+
planned_paths=["src/frontend/LoginPage.tsx"],
|
|
205
|
+
intent="新增登录鉴权页面并发布",
|
|
206
|
+
)
|
|
207
|
+
self.assertEqual([], plan["changed_files"])
|
|
208
|
+
self.assertEqual(["src/frontend/LoginPage.tsx"], plan["planned_files"])
|
|
209
|
+
self.assertEqual(["src/frontend/LoginPage.tsx"], plan["classification_files"])
|
|
210
|
+
self.assertTrue(plan["intent_provided"])
|
|
211
|
+
self.assertEqual(["auth", "release_or_tooling", "ui"], plan["intent_categories"])
|
|
212
|
+
self.assertIn("browser_debugger", plan["recommended_agents"])
|
|
213
|
+
self.assertNotIn("新增登录鉴权页面并发布", str(plan))
|
|
164
214
|
|
|
165
215
|
def test_ordinary_code_resolves_standard(self) -> None:
|
|
166
216
|
repo, cfg = self.make_repo("src/widget.py")
|
|
167
217
|
(repo / "docs" / "tasks" / "evidence.jsonl").write_text("{}\n", encoding="utf-8")
|
|
168
218
|
plan = self.plan(repo, cfg)
|
|
169
219
|
self.assertEqual("standard", plan["profile"])
|
|
170
|
-
self.assertEqual("
|
|
220
|
+
self.assertEqual("changed", plan["selected_scope"])
|
|
171
221
|
self.assertEqual("dev", plan["effective_mode"])
|
|
172
|
-
self.assertEqual(["explorer", "fixer"], plan["recommended_agents"])
|
|
222
|
+
self.assertEqual(["explorer", "fixer", "reviewer"], plan["recommended_agents"])
|
|
223
|
+
agent_plan = plan["agent_plan"]
|
|
224
|
+
self.assertEqual("orchestrated-subagents", agent_plan["strategy"])
|
|
225
|
+
self.assertEqual(
|
|
226
|
+
["decomposition", "discovery", "design", "delivery", "closure"],
|
|
227
|
+
[stage["id"] for stage in agent_plan["stages"]],
|
|
228
|
+
)
|
|
229
|
+
self.assertTrue(agent_plan["policies"]["one_writer_per_worktree"])
|
|
230
|
+
self.assertEqual("explicit-non-overlapping", agent_plan["policies"]["path_ownership"])
|
|
231
|
+
self.assertEqual(
|
|
232
|
+
"integrate-before-dependent-start",
|
|
233
|
+
agent_plan["policies"]["dependency_policy"],
|
|
234
|
+
)
|
|
235
|
+
self.assertEqual("owning-fixer", agent_plan["policies"]["review_feedback_owner"])
|
|
236
|
+
self.assertEqual("diff-fingerprint", agent_plan["policies"]["review_binding"])
|
|
237
|
+
self.assertEqual("main", agent_plan["policies"]["lifecycle_owner"])
|
|
238
|
+
self.assertIn("owned_paths", agent_plan["assignment_contract"]["writer"])
|
|
239
|
+
self.assertIn("diff_fingerprint", agent_plan["assignment_contract"]["reviewer"])
|
|
240
|
+
self.assertIn("diff_fingerprint", agent_plan["result_contract"])
|
|
241
|
+
delivery = next(stage for stage in agent_plan["stages"] if stage["id"] == "delivery")
|
|
242
|
+
self.assertEqual("dependency-waves", delivery["mode"])
|
|
243
|
+
self.assertEqual(
|
|
244
|
+
["implementation", "review", "gate-integrate"],
|
|
245
|
+
[phase["id"] for phase in delivery["wave_phases"]],
|
|
246
|
+
)
|
|
247
|
+
self.assertIn("integrated", delivery["next_wave"])
|
|
173
248
|
|
|
174
249
|
def test_test_only_change_resolves_micro(self) -> None:
|
|
175
250
|
repo, cfg = self.make_repo("tests/widget_test.py")
|
|
@@ -187,43 +262,59 @@ class AutoCodingProfileTests(unittest.TestCase):
|
|
|
187
262
|
self.assertEqual("changed", plan["selected_scope"])
|
|
188
263
|
self.assertEqual("dev", plan["effective_mode"])
|
|
189
264
|
|
|
190
|
-
def
|
|
265
|
+
def test_high_risk_changes_keep_fast_dev_gate(self) -> None:
|
|
191
266
|
repo, cfg = self.make_repo("migrations/001.sql")
|
|
192
267
|
plan = self.plan(repo, cfg, requested_profile="micro", requested_mode="dev")
|
|
193
268
|
self.assertEqual("high-risk", plan["profile"])
|
|
194
|
-
self.assertEqual("
|
|
195
|
-
self.assertEqual("
|
|
269
|
+
self.assertEqual("changed", plan["selected_scope"])
|
|
270
|
+
self.assertEqual("dev", plan["effective_mode"])
|
|
196
271
|
self.assertTrue(plan["needs_dd"])
|
|
197
272
|
self.assertIn("reviewer", plan["recommended_agents"])
|
|
273
|
+
self.assertFalse(plan["needs_jenkins"])
|
|
274
|
+
self.assertFalse(plan["needs_target"])
|
|
198
275
|
|
|
199
|
-
def
|
|
276
|
+
def test_ui_api_discovery_roles_run_in_one_parallel_stage(self) -> None:
|
|
277
|
+
repo, cfg = self.make_repo("src/api/settings-page.tsx")
|
|
278
|
+
plan = self.plan(repo, cfg)
|
|
279
|
+
discovery = next(stage for stage in plan["agent_plan"]["stages"] if stage["id"] == "discovery")
|
|
280
|
+
self.assertEqual("parallel", discovery["mode"])
|
|
281
|
+
self.assertEqual(
|
|
282
|
+
["explorer", "docs_researcher", "browser_debugger"],
|
|
283
|
+
discovery["roles"],
|
|
284
|
+
)
|
|
285
|
+
flattened = [
|
|
286
|
+
role
|
|
287
|
+
for stage in plan["agent_plan"]["stages"]
|
|
288
|
+
for role in stage["roles"]
|
|
289
|
+
if role != "main"
|
|
290
|
+
]
|
|
291
|
+
self.assertEqual(list(dict.fromkeys(flattened)), plan["recommended_agents"])
|
|
292
|
+
|
|
293
|
+
def test_requested_verify_mode_is_rejected(self) -> None:
|
|
200
294
|
repo, cfg = self.make_repo("src/widget.py")
|
|
201
|
-
|
|
202
|
-
|
|
203
|
-
self.assertEqual("full", plan["selected_scope"])
|
|
204
|
-
self.assertEqual("verify", plan["effective_mode"])
|
|
295
|
+
with self.assertRaises(APError):
|
|
296
|
+
self.plan(repo, cfg, requested_mode="verify")
|
|
205
297
|
|
|
206
298
|
def test_configured_high_risk_profile_cannot_be_downgraded_by_cli(self) -> None:
|
|
207
299
|
cfg = base_config()
|
|
208
|
-
cfg["workflow"] = {"mode": "dev", "profile": "high-risk"}
|
|
300
|
+
cfg["workflow"] = {"mode": "dev", "profile": "high-risk", "completion": "push"}
|
|
209
301
|
repo, cfg = self.make_repo("src/widget.py", cfg)
|
|
210
302
|
plan = self.plan(repo, cfg, requested_profile="micro", requested_mode="dev")
|
|
211
303
|
self.assertEqual("high-risk", plan["profile"])
|
|
212
|
-
self.assertEqual("
|
|
213
|
-
self.assertEqual("
|
|
304
|
+
self.assertEqual("changed", plan["selected_scope"])
|
|
305
|
+
self.assertEqual("dev", plan["effective_mode"])
|
|
214
306
|
|
|
215
|
-
def
|
|
307
|
+
def test_doctor_rejects_configured_verify_mode(self) -> None:
|
|
216
308
|
cfg = base_config()
|
|
217
|
-
cfg["workflow"] = {"mode": "verify", "profile": "auto"}
|
|
218
|
-
repo,
|
|
219
|
-
|
|
220
|
-
|
|
221
|
-
self.
|
|
222
|
-
self.assertEqual("verify", plan["effective_mode"])
|
|
309
|
+
cfg["workflow"] = {"mode": "verify", "profile": "auto", "completion": "push"}
|
|
310
|
+
repo, _ = self.make_repo("src/widget.py", cfg)
|
|
311
|
+
with self.assertRaises(APError) as context:
|
|
312
|
+
ap.cmd_doctor(argparse.Namespace(repo=str(repo)))
|
|
313
|
+
self.assertIn("workflow.mode", str(context.exception))
|
|
223
314
|
|
|
224
315
|
def test_configured_micro_profile_applies_to_ordinary_code(self) -> None:
|
|
225
316
|
cfg = base_config()
|
|
226
|
-
cfg["workflow"] = {"mode": "dev", "profile": "micro"}
|
|
317
|
+
cfg["workflow"] = {"mode": "dev", "profile": "micro", "completion": "push"}
|
|
227
318
|
repo, cfg = self.make_repo("src/widget.py", cfg)
|
|
228
319
|
plan = self.plan(repo, cfg)
|
|
229
320
|
self.assertEqual("micro", plan["profile"])
|
|
@@ -238,23 +329,77 @@ class AutoCodingProfileTests(unittest.TestCase):
|
|
|
238
329
|
self.assertEqual("high-risk", plan["profile"])
|
|
239
330
|
self.assertIn("matched gate rule with profile=high-risk", plan["profile_reasons"])
|
|
240
331
|
|
|
241
|
-
def
|
|
332
|
+
def test_full_scope_rule_does_not_expand_local_gate(self) -> None:
|
|
242
333
|
cfg = base_config()
|
|
243
334
|
cfg["gate"]["rules"] = [{"name": "sensitive", "paths": ["src/sensitive/**"], "scope": "full"}]
|
|
244
335
|
repo, cfg = self.make_repo("src/sensitive/value.py", cfg)
|
|
245
336
|
plan = self.plan(repo, cfg, requested_scope="changed", requested_profile="micro", requested_mode="dev")
|
|
246
|
-
self.assertEqual("
|
|
247
|
-
self.assertEqual("
|
|
248
|
-
self.assertEqual("
|
|
337
|
+
self.assertEqual("micro", plan["profile"])
|
|
338
|
+
self.assertEqual("changed", plan["selected_scope"])
|
|
339
|
+
self.assertEqual("dev", plan["effective_mode"])
|
|
249
340
|
|
|
250
|
-
def
|
|
341
|
+
def test_legacy_rule_commands_never_run_in_automatic_gate(self) -> None:
|
|
342
|
+
cfg = base_config()
|
|
343
|
+
repo, cfg = self.make_repo("src/sensitive/value.py", cfg)
|
|
344
|
+
quick_marker = repo / "quick-ran"
|
|
345
|
+
full_marker = repo / "full-ran"
|
|
346
|
+
build_marker = repo / "build-ran"
|
|
347
|
+
cfg["commands"] = {
|
|
348
|
+
"gate_changed": f"touch {quick_marker}",
|
|
349
|
+
"gate_full": f"touch {full_marker}",
|
|
350
|
+
"build": f"touch {build_marker}",
|
|
351
|
+
}
|
|
352
|
+
cfg["gate"]["rules"] = [
|
|
353
|
+
{
|
|
354
|
+
"name": "legacy-heavy-rule",
|
|
355
|
+
"paths": ["src/sensitive/**"],
|
|
356
|
+
"scope": "full",
|
|
357
|
+
"commands": ["gate_full", "build"],
|
|
358
|
+
}
|
|
359
|
+
]
|
|
360
|
+
self.write_config(repo, cfg)
|
|
361
|
+
|
|
362
|
+
ap.cmd_light_gate(
|
|
363
|
+
argparse.Namespace(
|
|
364
|
+
repo=str(repo),
|
|
365
|
+
scope="changed",
|
|
366
|
+
profile="",
|
|
367
|
+
mode="dev",
|
|
368
|
+
base="",
|
|
369
|
+
explain=False,
|
|
370
|
+
)
|
|
371
|
+
)
|
|
372
|
+
|
|
373
|
+
self.assertTrue(quick_marker.exists())
|
|
374
|
+
self.assertFalse(full_marker.exists())
|
|
375
|
+
self.assertFalse(build_marker.exists())
|
|
376
|
+
|
|
377
|
+
def test_classify_never_recommends_a_second_gate_or_structure_scan(self) -> None:
|
|
378
|
+
repo, _ = self.make_repo("src/widget.py")
|
|
379
|
+
with mock.patch.object(ap, "_record_evidence"):
|
|
380
|
+
with mock.patch("builtins.print") as printed:
|
|
381
|
+
ap.cmd_classify(
|
|
382
|
+
argparse.Namespace(
|
|
383
|
+
repo=str(repo),
|
|
384
|
+
scope="auto",
|
|
385
|
+
profile="",
|
|
386
|
+
mode="dev",
|
|
387
|
+
base="",
|
|
388
|
+
json=False,
|
|
389
|
+
)
|
|
390
|
+
)
|
|
391
|
+
rendered = "\n".join(" ".join(map(str, call.args)) for call in printed.call_args_list)
|
|
392
|
+
self.assertNotIn("light-gate", rendered)
|
|
393
|
+
self.assertNotIn("structure-check", rendered)
|
|
394
|
+
|
|
395
|
+
def test_custom_full_on_path_does_not_expand_local_gate(self) -> None:
|
|
251
396
|
cfg = base_config()
|
|
252
397
|
cfg["gate"]["full_on"] = {"paths": ["src/sensitive/**"]}
|
|
253
398
|
repo, cfg = self.make_repo("src/sensitive/value.py", cfg)
|
|
254
399
|
plan = self.plan(repo, cfg, requested_scope="changed", requested_profile="micro", requested_mode="dev")
|
|
255
|
-
self.assertEqual("
|
|
256
|
-
self.assertEqual("
|
|
257
|
-
self.assertEqual("
|
|
400
|
+
self.assertEqual("micro", plan["profile"])
|
|
401
|
+
self.assertEqual("changed", plan["selected_scope"])
|
|
402
|
+
self.assertEqual("dev", plan["effective_mode"])
|
|
258
403
|
|
|
259
404
|
def test_full_gate_never_falls_back_to_light(self) -> None:
|
|
260
405
|
repo, _ = self.make_repo()
|
|
@@ -308,32 +453,61 @@ class AutoCodingProfileTests(unittest.TestCase):
|
|
|
308
453
|
ap.cmd_doctor(argparse.Namespace(repo=str(repo)))
|
|
309
454
|
self.assertIn("gate.rules[0].scope", str(context.exception))
|
|
310
455
|
|
|
311
|
-
def
|
|
312
|
-
|
|
313
|
-
|
|
314
|
-
|
|
315
|
-
|
|
316
|
-
|
|
317
|
-
|
|
456
|
+
def test_doctor_rejects_legacy_isolation(self) -> None:
|
|
457
|
+
cfg = base_config()
|
|
458
|
+
cfg["concurrency"]["isolation"] = "legacy"
|
|
459
|
+
repo, _ = self.make_repo(config=cfg)
|
|
460
|
+
with self.assertRaises(APError) as context:
|
|
461
|
+
ap.cmd_doctor(argparse.Namespace(repo=str(repo)))
|
|
462
|
+
self.assertIn("must be worktree", str(context.exception))
|
|
463
|
+
|
|
464
|
+
def test_doctor_requires_one_fast_gate_for_every_profile(self) -> None:
|
|
465
|
+
for profile in ["micro", "standard", "high-risk", "auto"]:
|
|
318
466
|
with self.subTest(profile=profile):
|
|
319
467
|
cfg = base_config()
|
|
320
468
|
cfg["workflow"]["profile"] = profile
|
|
321
|
-
cfg["commands"] =
|
|
322
|
-
|
|
323
|
-
repo, _ = self.make_repo(change_path, config=cfg)
|
|
469
|
+
cfg["commands"] = {"gate_standard": "true", "gate_full": "true"}
|
|
470
|
+
repo, _ = self.make_repo(config=cfg)
|
|
324
471
|
with self.assertRaises(APError) as context:
|
|
325
472
|
ap.cmd_doctor(argparse.Namespace(repo=str(repo)))
|
|
326
|
-
self.assertIn(
|
|
473
|
+
self.assertIn("fast gate command", str(context.exception))
|
|
327
474
|
|
|
328
|
-
def
|
|
475
|
+
def test_doctor_requires_direct_access_password_even_with_env_reference(self) -> None:
|
|
329
476
|
cfg = base_config()
|
|
330
|
-
cfg["
|
|
331
|
-
cfg["
|
|
332
|
-
"health_base_url": "https://example.test",
|
|
333
|
-
"health_path": "/health",
|
|
334
|
-
}
|
|
477
|
+
cfg["access"]["gitlab"]["password"] = ""
|
|
478
|
+
cfg["access"]["gitlab"]["password_env"] = "GITLAB_PASSWORD"
|
|
335
479
|
repo, _ = self.make_repo(config=cfg)
|
|
336
|
-
|
|
480
|
+
with self.assertRaises(APError) as context:
|
|
481
|
+
ap.cmd_doctor(argparse.Namespace(repo=str(repo)))
|
|
482
|
+
self.assertIn("access.gitlab.password", str(context.exception))
|
|
483
|
+
|
|
484
|
+
def test_doctor_rejects_quoted_nullish_access_placeholders(self) -> None:
|
|
485
|
+
for placeholder in ["NULL", "~"]:
|
|
486
|
+
with self.subTest(placeholder=placeholder):
|
|
487
|
+
cfg = base_config()
|
|
488
|
+
cfg["access"]["gitlab"]["password"] = placeholder
|
|
489
|
+
repo, _ = self.make_repo(config=cfg)
|
|
490
|
+
with self.assertRaises(APError) as context:
|
|
491
|
+
ap.cmd_doctor(argparse.Namespace(repo=str(repo)))
|
|
492
|
+
self.assertIn("access.gitlab.password", str(context.exception))
|
|
493
|
+
|
|
494
|
+
def test_doctor_rejects_non_string_access_values(self) -> None:
|
|
495
|
+
for value in [False, 0]:
|
|
496
|
+
with self.subTest(value=value):
|
|
497
|
+
cfg = base_config()
|
|
498
|
+
cfg["access"]["gitlab"]["password"] = value
|
|
499
|
+
repo, _ = self.make_repo(config=cfg)
|
|
500
|
+
with self.assertRaises(APError) as context:
|
|
501
|
+
ap.cmd_doctor(argparse.Namespace(repo=str(repo)))
|
|
502
|
+
self.assertIn("access.gitlab.password", str(context.exception))
|
|
503
|
+
|
|
504
|
+
def test_doctor_validates_access_url_shape_without_network(self) -> None:
|
|
505
|
+
cfg = base_config()
|
|
506
|
+
cfg["access"]["nexus"]["frontend"]["url"] = "nexus.local"
|
|
507
|
+
repo, _ = self.make_repo(config=cfg)
|
|
508
|
+
with self.assertRaises(APError) as context:
|
|
509
|
+
ap.cmd_doctor(argparse.Namespace(repo=str(repo)))
|
|
510
|
+
self.assertIn("valid http/https URL", str(context.exception))
|
|
337
511
|
|
|
338
512
|
def test_api_docs_required_false_is_an_authoritative_opt_out(self) -> None:
|
|
339
513
|
cfg = base_config()
|
|
@@ -351,76 +525,46 @@ class AutoCodingProfileTests(unittest.TestCase):
|
|
|
351
525
|
ap.cmd_doctor(argparse.Namespace(repo=str(repo)))
|
|
352
526
|
ap.cmd_verify_api_docs(argparse.Namespace(repo=str(repo)))
|
|
353
527
|
|
|
354
|
-
def
|
|
355
|
-
|
|
356
|
-
("
|
|
357
|
-
("high-risk", "verify", "DEV-CLOSED"),
|
|
358
|
-
]
|
|
359
|
-
for profile, mode, result in cases:
|
|
360
|
-
with self.subTest(profile=profile, mode=mode, result=result):
|
|
361
|
-
repo, cfg = self.make_repo("src/widget.py")
|
|
362
|
-
plan = {
|
|
363
|
-
"profile": profile,
|
|
364
|
-
"effective_mode": mode,
|
|
365
|
-
"selected_scope": "full" if mode == "verify" else "changed",
|
|
366
|
-
}
|
|
367
|
-
fake_run_result = subprocess.CompletedProcess([], 0, stdout="changed\n", stderr="")
|
|
368
|
-
with (
|
|
369
|
-
mock.patch.object(ap, "ensure_git_repo"),
|
|
370
|
-
mock.patch.object(ap, "cmd_doctor"),
|
|
371
|
-
mock.patch.object(ap, "_load_cfg", return_value=cfg),
|
|
372
|
-
mock.patch.object(ap, "_resolve_execution_plan", return_value=plan),
|
|
373
|
-
mock.patch.object(ap, "cmd_light_gate"),
|
|
374
|
-
mock.patch.object(ap, "_cleanup_generated_noise"),
|
|
375
|
-
mock.patch.object(ap, "run", return_value=fake_run_result),
|
|
376
|
-
):
|
|
377
|
-
with self.assertRaises(APError):
|
|
378
|
-
ap.cmd_commit_push(
|
|
379
|
-
self.commit_args(repo, profile=profile, mode=mode, result=result)
|
|
380
|
-
)
|
|
528
|
+
def test_dev_closure_rejects_owner_acceptance_pass(self) -> None:
|
|
529
|
+
with self.assertRaises(APError):
|
|
530
|
+
ap._validate_closure_result("dev", "PASS")
|
|
381
531
|
|
|
382
532
|
def test_manual_closure_infers_one_of_the_three_effective_profiles(self) -> None:
|
|
383
533
|
repo, _ = self.make_repo("src/widget.py")
|
|
384
|
-
|
|
385
|
-
closure =
|
|
534
|
+
closure_path = self.record_closure(repo, self.closure_args(repo, result="DEV-CLOSED"))
|
|
535
|
+
closure = closure_path.read_text(encoding="utf-8")
|
|
386
536
|
self.assertIn("- Effective Profile: standard", closure)
|
|
387
537
|
self.assertNotIn("(not recorded)", closure)
|
|
388
538
|
|
|
389
|
-
def
|
|
390
|
-
|
|
391
|
-
|
|
392
|
-
|
|
393
|
-
|
|
394
|
-
for path, result in cases:
|
|
395
|
-
with self.subTest(path=path, result=result):
|
|
396
|
-
repo, _ = self.make_repo(path)
|
|
397
|
-
with self.assertRaises(APError):
|
|
398
|
-
ap.cmd_record_closure(self.closure_args(repo, result=result))
|
|
539
|
+
def test_manual_closure_uses_dev_closed_for_high_risk_work(self) -> None:
|
|
540
|
+
repo, _ = self.make_repo("migrations/001.sql")
|
|
541
|
+
closure_path = self.record_closure(repo, self.closure_args(repo, result="DEV-CLOSED"))
|
|
542
|
+
closure = closure_path.read_text(encoding="utf-8")
|
|
543
|
+
self.assertIn("- Effective Profile: high-risk", closure)
|
|
399
544
|
|
|
400
|
-
def
|
|
545
|
+
def test_manual_pass_is_outside_automatic_coding_closure(self) -> None:
|
|
401
546
|
repo, _ = self.make_repo("src/widget.py")
|
|
402
547
|
with self.assertRaises(APError) as context:
|
|
403
|
-
|
|
548
|
+
self.record_closure(
|
|
549
|
+
repo,
|
|
404
550
|
self.closure_args(repo, result="PASS", profile="high-risk", verification=[])
|
|
405
551
|
)
|
|
406
|
-
self.assertIn("
|
|
552
|
+
self.assertIn("owner acceptance", str(context.exception))
|
|
407
553
|
|
|
408
554
|
def test_manual_closure_uses_commit_diff_after_high_risk_change_is_committed(self) -> None:
|
|
409
555
|
repo, _ = self.make_repo("migrations/001.sql")
|
|
410
556
|
run(repo, "git", "add", "-A")
|
|
411
557
|
run(repo, "git", "commit", "-qm", "database migration")
|
|
412
558
|
|
|
413
|
-
|
|
414
|
-
|
|
415
|
-
|
|
416
|
-
ap.cmd_record_closure(
|
|
559
|
+
closure_path = self.record_closure(
|
|
560
|
+
repo,
|
|
417
561
|
self.closure_args(
|
|
418
562
|
repo,
|
|
419
|
-
result="
|
|
420
|
-
verification=["
|
|
563
|
+
result="DEV-CLOSED",
|
|
564
|
+
verification=["fast changed gate passed"],
|
|
421
565
|
)
|
|
422
566
|
)
|
|
423
|
-
closure =
|
|
567
|
+
closure = closure_path.read_text(encoding="utf-8")
|
|
424
568
|
self.assertIn("- Effective Profile: high-risk", closure)
|
|
425
569
|
|
|
426
570
|
|