@elvis1513/auto-coding-skill 2.1.3 → 2.2.0
This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
- package/README.md +154 -548
- package/cli/assets/agents/browser-debugger.toml +0 -1
- package/cli/assets/agents/docs-researcher.toml +0 -1
- package/cli/assets/agents/explorer.toml +1 -2
- package/cli/assets/agents/fixer.toml +2 -3
- package/cli/assets/agents/reviewer.toml +1 -2
- package/cli/assets/skill/SKILL.md +98 -207
- package/cli/assets/skill/data/templates/ENGINEERING.md +113 -468
- package/cli/assets/skill/data/templates/docs/tasks/closure-log.md +11 -22
- package/cli/assets/skill/data/templates/docs/tasks/taskbook.md +16 -39
- package/cli/assets/skill/data/templates/tools/ap.py +16 -0
- package/cli/assets/skill/scripts/ap.py +666 -129
- package/cli/assets/skill/scripts/scaffold_templates.py +136 -0
- package/cli/src/index.js +317 -42
- package/cli/tests/ap_profiles_test.py +428 -0
- package/cli/tests/index.test.js +373 -62
- package/package.json +3 -3
- package/cli/assets/skill/data/templates/docs/architecture/adr/_TEMPLATE-ADR.md +0 -38
- package/cli/assets/skill/data/templates/docs/architecture/structure-standard.md +0 -92
- package/cli/assets/skill/data/templates/docs/bugs/bug-list.md +0 -5
- package/cli/assets/skill/data/templates/docs/deployment/deploy-records/_TEMPLATE-DEPLOY-RECORD.md +0 -19
- package/cli/assets/skill/data/templates/docs/deployment/deploy-runbook.md +0 -11
- package/cli/assets/skill/data/templates/docs/design/_TEMPLATE-DD.md +0 -49
- package/cli/assets/skill/data/templates/docs/interfaces/api-change-log.md +0 -11
- package/cli/assets/skill/data/templates/docs/interfaces/api.md +0 -36
- package/cli/assets/skill/data/templates/docs/reviews/_TEMPLATE-REVIEW.md +0 -36
- package/cli/assets/skill/data/templates/docs/reviews/optimization-backlog.md +0 -25
- package/cli/assets/skill/data/templates/docs/reviews/project-health-baseline.md +0 -66
- package/cli/assets/skill/data/templates/docs/tasks/summaries/_TEMPLATE-TASK-SUMMARY.md +0 -35
- package/cli/assets/skill/data/templates/docs/testing/regression-matrix.md +0 -11
|
@@ -0,0 +1,428 @@
|
|
|
1
|
+
#!/usr/bin/env python3
|
|
2
|
+
from __future__ import annotations
|
|
3
|
+
|
|
4
|
+
import argparse
|
|
5
|
+
import subprocess
|
|
6
|
+
import sys
|
|
7
|
+
import tempfile
|
|
8
|
+
import unittest
|
|
9
|
+
from pathlib import Path
|
|
10
|
+
from unittest import mock
|
|
11
|
+
|
|
12
|
+
import yaml
|
|
13
|
+
|
|
14
|
+
|
|
15
|
+
REPO_ROOT = Path(__file__).resolve().parents[2]
|
|
16
|
+
SCRIPT_DIR = REPO_ROOT / "cli" / "assets" / "skill" / "scripts"
|
|
17
|
+
sys.path.insert(0, str(SCRIPT_DIR))
|
|
18
|
+
|
|
19
|
+
import ap # noqa: E402
|
|
20
|
+
from core import APError # noqa: E402
|
|
21
|
+
|
|
22
|
+
|
|
23
|
+
def run(repo: Path, *args: str) -> None:
|
|
24
|
+
subprocess.run(list(args), cwd=repo, check=True, text=True, capture_output=True)
|
|
25
|
+
|
|
26
|
+
|
|
27
|
+
def base_config() -> dict:
|
|
28
|
+
return {
|
|
29
|
+
"workflow": {"mode": "dev", "profile": "auto"},
|
|
30
|
+
"project": {"name": "profile-test"},
|
|
31
|
+
"commands": {
|
|
32
|
+
"gate_changed": "true",
|
|
33
|
+
"gate_standard": "true",
|
|
34
|
+
"gate_full": "true",
|
|
35
|
+
},
|
|
36
|
+
"gate": {
|
|
37
|
+
"default_scope": "auto",
|
|
38
|
+
"fallback_scope": "standard",
|
|
39
|
+
"full_on_unknown": True,
|
|
40
|
+
"no_change_scope": "standard",
|
|
41
|
+
"rules": [],
|
|
42
|
+
},
|
|
43
|
+
"structure": {"enabled": False, "enforcement": "advisory"},
|
|
44
|
+
"verification": {"target_env_required": False, "jenkins_required": False},
|
|
45
|
+
"docs": {
|
|
46
|
+
"taskbook": "docs/tasks/taskbook.md",
|
|
47
|
+
"closure_log": "docs/tasks/closure-log.md",
|
|
48
|
+
"evidence_log": "docs/tasks/evidence.jsonl",
|
|
49
|
+
"design_dir": "docs/design",
|
|
50
|
+
"ledger_check_enabled": True,
|
|
51
|
+
},
|
|
52
|
+
}
|
|
53
|
+
|
|
54
|
+
|
|
55
|
+
class AutoCodingProfileTests(unittest.TestCase):
|
|
56
|
+
def make_repo(self, change_path: str | None = None, config: dict | None = None) -> tuple[Path, dict]:
|
|
57
|
+
temp = tempfile.TemporaryDirectory(prefix="autocoding-profile-")
|
|
58
|
+
self.addCleanup(temp.cleanup)
|
|
59
|
+
repo = Path(temp.name)
|
|
60
|
+
cfg = config or base_config()
|
|
61
|
+
run(repo, "git", "init", "-q")
|
|
62
|
+
run(repo, "git", "config", "user.email", "test@example.com")
|
|
63
|
+
run(repo, "git", "config", "user.name", "Auto Coding Test")
|
|
64
|
+
self.write_config(repo, cfg)
|
|
65
|
+
(repo / "docs" / "tasks").mkdir(parents=True, exist_ok=True)
|
|
66
|
+
(repo / "docs" / "tasks" / "taskbook.md").write_text("# Taskbook\n", encoding="utf-8")
|
|
67
|
+
(repo / "docs" / "tasks" / "closure-log.md").write_text("# Closure Log\n", encoding="utf-8")
|
|
68
|
+
run(repo, "git", "add", "-A")
|
|
69
|
+
run(repo, "git", "commit", "-qm", "baseline")
|
|
70
|
+
if change_path:
|
|
71
|
+
target = repo / change_path
|
|
72
|
+
target.parent.mkdir(parents=True, exist_ok=True)
|
|
73
|
+
target.write_text("change\n", encoding="utf-8")
|
|
74
|
+
return repo, cfg
|
|
75
|
+
|
|
76
|
+
@staticmethod
|
|
77
|
+
def write_config(repo: Path, cfg: dict) -> None:
|
|
78
|
+
path = repo / "docs" / "ENGINEERING.md"
|
|
79
|
+
path.parent.mkdir(parents=True, exist_ok=True)
|
|
80
|
+
path.write_text(
|
|
81
|
+
"---\n" + yaml.safe_dump(cfg, allow_unicode=True, sort_keys=False) + "---\n# Engineering\n",
|
|
82
|
+
encoding="utf-8",
|
|
83
|
+
)
|
|
84
|
+
|
|
85
|
+
def plan(self, repo: Path, cfg: dict, **kwargs: str) -> dict:
|
|
86
|
+
return ap._resolve_execution_plan(cfg, repo, **kwargs)
|
|
87
|
+
|
|
88
|
+
@staticmethod
|
|
89
|
+
def commit_args(
|
|
90
|
+
repo: Path,
|
|
91
|
+
*,
|
|
92
|
+
profile: str,
|
|
93
|
+
mode: str,
|
|
94
|
+
result: str,
|
|
95
|
+
) -> argparse.Namespace:
|
|
96
|
+
return argparse.Namespace(
|
|
97
|
+
repo=str(repo),
|
|
98
|
+
task_id="T001",
|
|
99
|
+
title="profile closure",
|
|
100
|
+
msg="T001: profile closure",
|
|
101
|
+
mode=mode,
|
|
102
|
+
profile=profile,
|
|
103
|
+
require_light_gate=False,
|
|
104
|
+
require_runtime_health=False,
|
|
105
|
+
require_jenkins=False,
|
|
106
|
+
require_matrix=False,
|
|
107
|
+
record_closure=False,
|
|
108
|
+
job_name=None,
|
|
109
|
+
job_url=None,
|
|
110
|
+
multibranch_root_job=None,
|
|
111
|
+
branch_name=None,
|
|
112
|
+
build_number=None,
|
|
113
|
+
max_builds=20,
|
|
114
|
+
timeout_sec=1,
|
|
115
|
+
poll_sec=1,
|
|
116
|
+
allow_no_deploy=False,
|
|
117
|
+
backend_path=None,
|
|
118
|
+
frontend_path=None,
|
|
119
|
+
backend_basic_auth=False,
|
|
120
|
+
frontend_basic_auth=False,
|
|
121
|
+
jenkins_build=None,
|
|
122
|
+
target_env=None,
|
|
123
|
+
verification=None,
|
|
124
|
+
structure_check=None,
|
|
125
|
+
result=result,
|
|
126
|
+
follow_up=None,
|
|
127
|
+
initial_commit=None,
|
|
128
|
+
jenkins_failure=None,
|
|
129
|
+
fix_commit=None,
|
|
130
|
+
)
|
|
131
|
+
|
|
132
|
+
@staticmethod
|
|
133
|
+
def closure_args(
|
|
134
|
+
repo: Path,
|
|
135
|
+
*,
|
|
136
|
+
result: str,
|
|
137
|
+
profile: str = "",
|
|
138
|
+
verification: list[str] | None = None,
|
|
139
|
+
) -> argparse.Namespace:
|
|
140
|
+
return argparse.Namespace(
|
|
141
|
+
repo=str(repo),
|
|
142
|
+
task_id="T001",
|
|
143
|
+
title="manual closure",
|
|
144
|
+
commit="HEAD",
|
|
145
|
+
jenkins=None,
|
|
146
|
+
target_env=None,
|
|
147
|
+
verification=["manual evidence"] if verification is None else verification,
|
|
148
|
+
profile=profile,
|
|
149
|
+
structure_check="passed",
|
|
150
|
+
result=result,
|
|
151
|
+
follow_up=None,
|
|
152
|
+
initial_commit=None,
|
|
153
|
+
jenkins_failure=None,
|
|
154
|
+
fix_commit=None,
|
|
155
|
+
)
|
|
156
|
+
|
|
157
|
+
def test_docs_only_resolves_micro(self) -> None:
|
|
158
|
+
repo, cfg = self.make_repo("docs/security-auth-notes.md")
|
|
159
|
+
plan = self.plan(repo, cfg)
|
|
160
|
+
self.assertEqual("micro", plan["profile"])
|
|
161
|
+
self.assertEqual("changed", plan["selected_scope"])
|
|
162
|
+
self.assertEqual("dev", plan["effective_mode"])
|
|
163
|
+
self.assertEqual([], plan["recommended_agents"])
|
|
164
|
+
|
|
165
|
+
def test_ordinary_code_resolves_standard(self) -> None:
|
|
166
|
+
repo, cfg = self.make_repo("src/widget.py")
|
|
167
|
+
(repo / "docs" / "tasks" / "evidence.jsonl").write_text("{}\n", encoding="utf-8")
|
|
168
|
+
plan = self.plan(repo, cfg)
|
|
169
|
+
self.assertEqual("standard", plan["profile"])
|
|
170
|
+
self.assertEqual("standard", plan["selected_scope"])
|
|
171
|
+
self.assertEqual("dev", plan["effective_mode"])
|
|
172
|
+
self.assertEqual(["explorer", "fixer"], plan["recommended_agents"])
|
|
173
|
+
|
|
174
|
+
def test_test_only_change_resolves_micro(self) -> None:
|
|
175
|
+
repo, cfg = self.make_repo("tests/widget_test.py")
|
|
176
|
+
(repo / "docs" / "tasks" / "evidence.jsonl").write_text("{}\n", encoding="utf-8")
|
|
177
|
+
plan = self.plan(repo, cfg)
|
|
178
|
+
self.assertEqual("micro", plan["profile"])
|
|
179
|
+
self.assertEqual("changed", plan["selected_scope"])
|
|
180
|
+
|
|
181
|
+
def test_sensitive_named_test_only_changes_stay_micro(self) -> None:
|
|
182
|
+
for path in ["tests/auth_test.py", "tests/payment_spec.ts", "tests/upload_test.py"]:
|
|
183
|
+
with self.subTest(path=path):
|
|
184
|
+
repo, cfg = self.make_repo(path)
|
|
185
|
+
plan = self.plan(repo, cfg)
|
|
186
|
+
self.assertEqual("micro", plan["profile"])
|
|
187
|
+
self.assertEqual("changed", plan["selected_scope"])
|
|
188
|
+
self.assertEqual("dev", plan["effective_mode"])
|
|
189
|
+
|
|
190
|
+
def test_high_risk_is_full_verify_and_cannot_be_downgraded(self) -> None:
|
|
191
|
+
repo, cfg = self.make_repo("migrations/001.sql")
|
|
192
|
+
plan = self.plan(repo, cfg, requested_profile="micro", requested_mode="dev")
|
|
193
|
+
self.assertEqual("high-risk", plan["profile"])
|
|
194
|
+
self.assertEqual("full", plan["selected_scope"])
|
|
195
|
+
self.assertEqual("verify", plan["effective_mode"])
|
|
196
|
+
self.assertTrue(plan["needs_dd"])
|
|
197
|
+
self.assertIn("reviewer", plan["recommended_agents"])
|
|
198
|
+
|
|
199
|
+
def test_verify_mode_forces_high_risk_full(self) -> None:
|
|
200
|
+
repo, cfg = self.make_repo("src/widget.py")
|
|
201
|
+
plan = self.plan(repo, cfg, requested_mode="verify")
|
|
202
|
+
self.assertEqual("high-risk", plan["profile"])
|
|
203
|
+
self.assertEqual("full", plan["selected_scope"])
|
|
204
|
+
self.assertEqual("verify", plan["effective_mode"])
|
|
205
|
+
|
|
206
|
+
def test_configured_high_risk_profile_cannot_be_downgraded_by_cli(self) -> None:
|
|
207
|
+
cfg = base_config()
|
|
208
|
+
cfg["workflow"] = {"mode": "dev", "profile": "high-risk"}
|
|
209
|
+
repo, cfg = self.make_repo("src/widget.py", cfg)
|
|
210
|
+
plan = self.plan(repo, cfg, requested_profile="micro", requested_mode="dev")
|
|
211
|
+
self.assertEqual("high-risk", plan["profile"])
|
|
212
|
+
self.assertEqual("full", plan["selected_scope"])
|
|
213
|
+
self.assertEqual("verify", plan["effective_mode"])
|
|
214
|
+
|
|
215
|
+
def test_configured_verify_mode_cannot_be_downgraded_by_cli(self) -> None:
|
|
216
|
+
cfg = base_config()
|
|
217
|
+
cfg["workflow"] = {"mode": "verify", "profile": "auto"}
|
|
218
|
+
repo, cfg = self.make_repo("src/widget.py", cfg)
|
|
219
|
+
plan = self.plan(repo, cfg, requested_profile="micro", requested_mode="dev")
|
|
220
|
+
self.assertEqual("high-risk", plan["profile"])
|
|
221
|
+
self.assertEqual("full", plan["selected_scope"])
|
|
222
|
+
self.assertEqual("verify", plan["effective_mode"])
|
|
223
|
+
|
|
224
|
+
def test_configured_micro_profile_applies_to_ordinary_code(self) -> None:
|
|
225
|
+
cfg = base_config()
|
|
226
|
+
cfg["workflow"] = {"mode": "dev", "profile": "micro"}
|
|
227
|
+
repo, cfg = self.make_repo("src/widget.py", cfg)
|
|
228
|
+
plan = self.plan(repo, cfg)
|
|
229
|
+
self.assertEqual("micro", plan["profile"])
|
|
230
|
+
self.assertEqual("changed", plan["selected_scope"])
|
|
231
|
+
self.assertEqual("dev", plan["effective_mode"])
|
|
232
|
+
|
|
233
|
+
def test_rule_can_raise_profile(self) -> None:
|
|
234
|
+
cfg = base_config()
|
|
235
|
+
cfg["gate"]["rules"] = [{"name": "sensitive", "paths": ["src/special/**"], "profile": "high-risk"}]
|
|
236
|
+
repo, cfg = self.make_repo("src/special/value.py", cfg)
|
|
237
|
+
plan = self.plan(repo, cfg)
|
|
238
|
+
self.assertEqual("high-risk", plan["profile"])
|
|
239
|
+
self.assertIn("matched gate rule with profile=high-risk", plan["profile_reasons"])
|
|
240
|
+
|
|
241
|
+
def test_full_scope_rule_cannot_be_bypassed_by_explicit_scope(self) -> None:
|
|
242
|
+
cfg = base_config()
|
|
243
|
+
cfg["gate"]["rules"] = [{"name": "sensitive", "paths": ["src/sensitive/**"], "scope": "full"}]
|
|
244
|
+
repo, cfg = self.make_repo("src/sensitive/value.py", cfg)
|
|
245
|
+
plan = self.plan(repo, cfg, requested_scope="changed", requested_profile="micro", requested_mode="dev")
|
|
246
|
+
self.assertEqual("high-risk", plan["profile"])
|
|
247
|
+
self.assertEqual("full", plan["selected_scope"])
|
|
248
|
+
self.assertEqual("verify", plan["effective_mode"])
|
|
249
|
+
|
|
250
|
+
def test_custom_full_on_path_cannot_be_bypassed_by_explicit_scope(self) -> None:
|
|
251
|
+
cfg = base_config()
|
|
252
|
+
cfg["gate"]["full_on"] = {"paths": ["src/sensitive/**"]}
|
|
253
|
+
repo, cfg = self.make_repo("src/sensitive/value.py", cfg)
|
|
254
|
+
plan = self.plan(repo, cfg, requested_scope="changed", requested_profile="micro", requested_mode="dev")
|
|
255
|
+
self.assertEqual("high-risk", plan["profile"])
|
|
256
|
+
self.assertEqual("full", plan["selected_scope"])
|
|
257
|
+
self.assertEqual("verify", plan["effective_mode"])
|
|
258
|
+
|
|
259
|
+
def test_full_gate_never_falls_back_to_light(self) -> None:
|
|
260
|
+
repo, _ = self.make_repo()
|
|
261
|
+
marker = repo / "light-ran"
|
|
262
|
+
cfg = {"commands": {"light_gate": f"touch {marker}"}}
|
|
263
|
+
with self.assertRaises(APError):
|
|
264
|
+
ap._run_full_gate(repo, cfg)
|
|
265
|
+
self.assertFalse(marker.exists())
|
|
266
|
+
|
|
267
|
+
cfg = {"commands": {"gate_full": f"touch {marker}"}}
|
|
268
|
+
self.assertEqual(["gate_full"], ap._run_full_gate(repo, cfg))
|
|
269
|
+
self.assertTrue(marker.exists())
|
|
270
|
+
|
|
271
|
+
def test_structure_defaults_to_advisory_until_explicitly_blocking(self) -> None:
|
|
272
|
+
cfg = base_config()
|
|
273
|
+
cfg["structure"] = {
|
|
274
|
+
"enabled": True,
|
|
275
|
+
"max_file_lines_warn": 3,
|
|
276
|
+
"max_file_lines_block": 5,
|
|
277
|
+
"max_function_lines_warn": 0,
|
|
278
|
+
"max_added_lines_to_large_file": 2,
|
|
279
|
+
"layer_rules": {"enabled": False},
|
|
280
|
+
}
|
|
281
|
+
repo, cfg = self.make_repo("src/large.py", cfg)
|
|
282
|
+
(repo / "src" / "large.py").write_text("\n".join(f"line {i}" for i in range(10)), encoding="utf-8")
|
|
283
|
+
args = argparse.Namespace(repo=str(repo), scope="changed", base="", json=False)
|
|
284
|
+
ap.cmd_structure_check(args)
|
|
285
|
+
|
|
286
|
+
cfg["structure"]["enforcement"] = "blocking"
|
|
287
|
+
self.write_config(repo, cfg)
|
|
288
|
+
with self.assertRaises(APError):
|
|
289
|
+
ap.cmd_structure_check(args)
|
|
290
|
+
|
|
291
|
+
def test_doctor_validates_profile_values(self) -> None:
|
|
292
|
+
cfg = base_config()
|
|
293
|
+
cfg["workflow"]["profile"] = "extreme"
|
|
294
|
+
cfg["gate"]["rules"] = [{"paths": ["src/**"], "profile": "unsafe"}]
|
|
295
|
+
repo, _ = self.make_repo(config=cfg)
|
|
296
|
+
with self.assertRaises(APError) as context:
|
|
297
|
+
ap.cmd_doctor(argparse.Namespace(repo=str(repo)))
|
|
298
|
+
message = str(context.exception)
|
|
299
|
+
self.assertIn("workflow.profile", message)
|
|
300
|
+
self.assertIn("gate.rules[0].profile", message)
|
|
301
|
+
|
|
302
|
+
def test_doctor_rejects_invalid_rule_scope(self) -> None:
|
|
303
|
+
cfg = base_config()
|
|
304
|
+
cfg["docs"]["ledger_check_enabled"] = False
|
|
305
|
+
cfg["gate"]["rules"] = [{"paths": ["src/**"], "scope": "ful"}]
|
|
306
|
+
repo, _ = self.make_repo(config=cfg)
|
|
307
|
+
with self.assertRaises(APError) as context:
|
|
308
|
+
ap.cmd_doctor(argparse.Namespace(repo=str(repo)))
|
|
309
|
+
self.assertIn("gate.rules[0].scope", str(context.exception))
|
|
310
|
+
|
|
311
|
+
def test_doctor_requires_a_gate_executable_for_the_configured_profile(self) -> None:
|
|
312
|
+
cases = [
|
|
313
|
+
("micro", {"gate_standard": "true"}, "gate_changed", "tests/widget_test.py"),
|
|
314
|
+
("standard", {"gate_changed": "true"}, "gate_standard", None),
|
|
315
|
+
("auto", {"gate_changed": "true"}, "gate_standard", None),
|
|
316
|
+
]
|
|
317
|
+
for profile, commands, expected_field, change_path in cases:
|
|
318
|
+
with self.subTest(profile=profile):
|
|
319
|
+
cfg = base_config()
|
|
320
|
+
cfg["workflow"]["profile"] = profile
|
|
321
|
+
cfg["commands"] = commands
|
|
322
|
+
cfg["docs"]["ledger_check_enabled"] = False
|
|
323
|
+
repo, _ = self.make_repo(change_path, config=cfg)
|
|
324
|
+
with self.assertRaises(APError) as context:
|
|
325
|
+
ap.cmd_doctor(argparse.Namespace(repo=str(repo)))
|
|
326
|
+
self.assertIn(expected_field, str(context.exception))
|
|
327
|
+
|
|
328
|
+
def test_doctor_accepts_health_only_target_verification(self) -> None:
|
|
329
|
+
cfg = base_config()
|
|
330
|
+
cfg["verification"]["target_env_required"] = True
|
|
331
|
+
cfg["target_env"] = {
|
|
332
|
+
"health_base_url": "https://example.test",
|
|
333
|
+
"health_path": "/health",
|
|
334
|
+
}
|
|
335
|
+
repo, _ = self.make_repo(config=cfg)
|
|
336
|
+
ap.cmd_doctor(argparse.Namespace(repo=str(repo)))
|
|
337
|
+
|
|
338
|
+
def test_api_docs_required_false_is_an_authoritative_opt_out(self) -> None:
|
|
339
|
+
cfg = base_config()
|
|
340
|
+
cfg["docs"].update(
|
|
341
|
+
{
|
|
342
|
+
"api_docs_required": False,
|
|
343
|
+
"api_doc": "docs/interfaces/api.md",
|
|
344
|
+
"api_change_log": "docs/interfaces/api-change-log.md",
|
|
345
|
+
}
|
|
346
|
+
)
|
|
347
|
+
repo, _ = self.make_repo(config=cfg)
|
|
348
|
+
api_doc = repo / "docs" / "interfaces" / "api.md"
|
|
349
|
+
api_doc.parent.mkdir(parents=True, exist_ok=True)
|
|
350
|
+
api_doc.write_text("# Existing API\n", encoding="utf-8")
|
|
351
|
+
ap.cmd_doctor(argparse.Namespace(repo=str(repo)))
|
|
352
|
+
ap.cmd_verify_api_docs(argparse.Namespace(repo=str(repo)))
|
|
353
|
+
|
|
354
|
+
def test_commit_push_rejects_result_incompatible_with_effective_mode(self) -> None:
|
|
355
|
+
cases = [
|
|
356
|
+
("micro", "dev", "PASS"),
|
|
357
|
+
("high-risk", "verify", "DEV-CLOSED"),
|
|
358
|
+
]
|
|
359
|
+
for profile, mode, result in cases:
|
|
360
|
+
with self.subTest(profile=profile, mode=mode, result=result):
|
|
361
|
+
repo, cfg = self.make_repo("src/widget.py")
|
|
362
|
+
plan = {
|
|
363
|
+
"profile": profile,
|
|
364
|
+
"effective_mode": mode,
|
|
365
|
+
"selected_scope": "full" if mode == "verify" else "changed",
|
|
366
|
+
}
|
|
367
|
+
fake_run_result = subprocess.CompletedProcess([], 0, stdout="changed\n", stderr="")
|
|
368
|
+
with (
|
|
369
|
+
mock.patch.object(ap, "ensure_git_repo"),
|
|
370
|
+
mock.patch.object(ap, "cmd_doctor"),
|
|
371
|
+
mock.patch.object(ap, "_load_cfg", return_value=cfg),
|
|
372
|
+
mock.patch.object(ap, "_resolve_execution_plan", return_value=plan),
|
|
373
|
+
mock.patch.object(ap, "cmd_light_gate"),
|
|
374
|
+
mock.patch.object(ap, "_cleanup_generated_noise"),
|
|
375
|
+
mock.patch.object(ap, "run", return_value=fake_run_result),
|
|
376
|
+
):
|
|
377
|
+
with self.assertRaises(APError):
|
|
378
|
+
ap.cmd_commit_push(
|
|
379
|
+
self.commit_args(repo, profile=profile, mode=mode, result=result)
|
|
380
|
+
)
|
|
381
|
+
|
|
382
|
+
def test_manual_closure_infers_one_of_the_three_effective_profiles(self) -> None:
|
|
383
|
+
repo, _ = self.make_repo("src/widget.py")
|
|
384
|
+
ap.cmd_record_closure(self.closure_args(repo, result="DEV-CLOSED"))
|
|
385
|
+
closure = (repo / "docs" / "tasks" / "closure-log.md").read_text(encoding="utf-8")
|
|
386
|
+
self.assertIn("- Effective Profile: standard", closure)
|
|
387
|
+
self.assertNotIn("(not recorded)", closure)
|
|
388
|
+
|
|
389
|
+
def test_manual_closure_rejects_result_incompatible_with_inferred_mode(self) -> None:
|
|
390
|
+
cases = [
|
|
391
|
+
("src/widget.py", "PASS"),
|
|
392
|
+
("migrations/001.sql", "DEV-CLOSED"),
|
|
393
|
+
]
|
|
394
|
+
for path, result in cases:
|
|
395
|
+
with self.subTest(path=path, result=result):
|
|
396
|
+
repo, _ = self.make_repo(path)
|
|
397
|
+
with self.assertRaises(APError):
|
|
398
|
+
ap.cmd_record_closure(self.closure_args(repo, result=result))
|
|
399
|
+
|
|
400
|
+
def test_manual_pass_requires_concrete_verification_evidence(self) -> None:
|
|
401
|
+
repo, _ = self.make_repo("src/widget.py")
|
|
402
|
+
with self.assertRaises(APError) as context:
|
|
403
|
+
ap.cmd_record_closure(
|
|
404
|
+
self.closure_args(repo, result="PASS", profile="high-risk", verification=[])
|
|
405
|
+
)
|
|
406
|
+
self.assertIn("--verification", str(context.exception))
|
|
407
|
+
|
|
408
|
+
def test_manual_closure_uses_commit_diff_after_high_risk_change_is_committed(self) -> None:
|
|
409
|
+
repo, _ = self.make_repo("migrations/001.sql")
|
|
410
|
+
run(repo, "git", "add", "-A")
|
|
411
|
+
run(repo, "git", "commit", "-qm", "database migration")
|
|
412
|
+
|
|
413
|
+
with self.assertRaises(APError):
|
|
414
|
+
ap.cmd_record_closure(self.closure_args(repo, result="DEV-CLOSED"))
|
|
415
|
+
|
|
416
|
+
ap.cmd_record_closure(
|
|
417
|
+
self.closure_args(
|
|
418
|
+
repo,
|
|
419
|
+
result="PASS",
|
|
420
|
+
verification=["gate_full: integration suite passed"],
|
|
421
|
+
)
|
|
422
|
+
)
|
|
423
|
+
closure = (repo / "docs" / "tasks" / "closure-log.md").read_text(encoding="utf-8")
|
|
424
|
+
self.assertIn("- Effective Profile: high-risk", closure)
|
|
425
|
+
|
|
426
|
+
|
|
427
|
+
if __name__ == "__main__":
|
|
428
|
+
unittest.main()
|