@elliemae/pui-cli 9.0.0-alpha.8 → 9.0.0-alpha.9

package/lib/lint-config/eslint/flat/compat.mjs

@@ -1,10 +1,8 @@
 /**
  * ESLint 10 removed deprecated context APIs (e.g. getSourceCode, getScope, getFilename).
- * Shim only plugins that still call those APIs until maintainers publish compatible releases.
- *
- * @eslint/compat fixupPluginRules assumes ESLint 9 sourceCode passthroughs that are also
- * unavailable in ESLint 10, so we shim legacy context methods directly on the rule context.
+ * Wrap legacy plugins via @eslint/compat v2 (ESLint 10–aware fixupPluginRules).
  */
+import { fixupConfigRules, fixupPluginRules } from '@eslint/compat';
 import react from 'eslint-plugin-react';
 import reduxSaga from 'eslint-plugin-redux-saga';
 import storybook from 'eslint-plugin-storybook';
@@ -14,139 +12,16 @@ const storybookFlat =
   storybook.configs.recommended ??
   [];
 
-/** @type {WeakMap<import('eslint').ESLint.Plugin, import('eslint').ESLint.Plugin>} */
-const fixedPlugins = new WeakMap();
-
-/**
- * @param {import('eslint').Rule.RuleModule['create']} originalCreate
- */
-function wrapRuleCreateWithLegacyContext(originalCreate) {
-  return function create(context) {
-    if (
-      typeof context.getScope === 'function' &&
-      typeof context.getFilename === 'function'
-    ) {
-      return originalCreate(context);
-    }
-
-    const sourceCode = context.sourceCode;
-    let currentNode = sourceCode.ast;
-
-    const legacyContext = Object.assign(Object.create(context), {
-      getFilename() {
-        return context.filename;
-      },
-      getScope() {
-        return sourceCode.getScope(currentNode);
-      },
-      getAncestors() {
-        return sourceCode.getAncestors(currentNode);
-      },
-      getSourceCode() {
-        return sourceCode;
-      },
-    });
-
-    Object.freeze(legacyContext);
-
-    const visitor = originalCreate(legacyContext);
-
-    if (!visitor || typeof visitor !== 'object') {
-      return visitor;
-    }
-
-    for (const [methodName, method] of Object.entries(visitor)) {
-      if (typeof method !== 'function') {
-        continue;
-      }
-
-      if (methodName.startsWith('on')) {
-        visitor[methodName] = (...args) => {
-          currentNode = args[methodName === 'onCodePathSegmentLoop' ? 2 : 1];
-          return method.call(visitor, ...args);
-        };
-        continue;
-      }
-
-      visitor[methodName] = (node, ...rest) => {
-        currentNode = node;
-        return method.call(visitor, node, ...rest);
-      };
-    }
-
-    return visitor;
-  };
-}
-
-/**
- * @param {import('eslint').ESLint.Plugin} plugin
- * @returns {import('eslint').ESLint.Plugin}
- */
-function fixupLegacyPlugin(plugin) {
-  const cached = fixedPlugins.get(plugin);
-  if (cached) {
-    return cached;
-  }
-
-  if (!plugin.rules) {
-    fixedPlugins.set(plugin, plugin);
-    return plugin;
-  }
-
-  const rules = {};
-
-  for (const [ruleName, ruleDefinition] of Object.entries(plugin.rules)) {
-    if (typeof ruleDefinition === 'function') {
-      rules[ruleName] = wrapRuleCreateWithLegacyContext(ruleDefinition);
-      continue;
-    }
-
-    rules[ruleName] = {
-      ...ruleDefinition,
-      create: wrapRuleCreateWithLegacyContext(
-        ruleDefinition.create.bind(ruleDefinition),
-      ),
-    };
-  }
-
-  const fixed = { ...plugin, rules };
-  fixedPlugins.set(plugin, fixed);
-  return fixed;
-}
-
-/** @type {import('eslint').ESLint.Plugin} */
-const storybookPlugin = fixupLegacyPlugin(storybook);
-
-/**
- * @param {import('eslint').Linter.Config[]} configs
- * @returns {import('eslint').Linter.Config[]}
- */
-function fixupStorybookFlatConfigs(configs) {
-  return configs.map((configItem) => {
-    if (!configItem.plugins?.storybook) {
-      return configItem;
-    }
-
-    return {
-      ...configItem,
-      plugins: {
-        ...configItem.plugins,
-        storybook: storybookPlugin,
-      },
-    };
-  });
-}
-
 /** React — uses context.getFilename / getScope (eslint-plugin-react@7). */
 /** @type {import('eslint').ESLint.Plugin} */
-export const reactPlugin = fixupLegacyPlugin(react);
+export const reactPlugin = fixupPluginRules(react);
 
 /** Redux-saga — uses context.getScope in no-yield-in-race. */
 /** @type {import('eslint').ESLint.Plugin} */
-export const reduxSagaPlugin = fixupLegacyPlugin(reduxSaga);
+export const reduxSagaPlugin = fixupPluginRules(reduxSaga);
 
 /** Storybook flat presets — uses legacy context APIs (eslint-plugin-storybook@0.12). */
 /** @type {import('eslint').Linter.Config[]} */
-export const storybookFlatConfigs = fixupStorybookFlatConfigs(
+export const storybookFlatConfigs = fixupConfigRules(
   Array.isArray(storybookFlat) ? storybookFlat : [storybookFlat],
 );

package/lib/lint-config/stylelint/config.mjs

@@ -0,0 +1,27 @@
+/** @type {import('stylelint').Config} */
+export const stylelintConfig = {
+  ignoreFiles: [
+    '/dist/**/*',
+    '/coverage/**/*',
+    '/build/**/*',
+    '/reports/**/*',
+    '/temp/**/*',
+    '/docs/**/*',
+    '/demo/**/*',
+    '/node_modules/**/*',
+    '/vendor/**/*',
+  ],
+  customSyntax: 'postcss-styled-syntax',
+  extends: ['stylelint-config-recommended'],
+  rules: {
+    'selector-type-no-unknown': null,
+    'function-no-unknown': null,
+    // Formerly from stylelint-config-styled-components (unmaintained; references
+    // removed rules like no-missing-end-of-source-newline in Stylelint 17).
+    'value-no-vendor-prefix': true,
+    'property-no-vendor-prefix': true,
+    'no-empty-source': null,
+  },
+};
+
+export default stylelintConfig;

package/lib/lint-config/stylelint/export.mjs

@@ -0,0 +1 @@
+export { stylelintConfig, default } from './config.mjs';

package/lib/lint-config/stylelint.config.cjs

@@ -1,19 +1,3 @@
-exports.stylelintConfig = {
-  ignoreFiles: [
-    "/dist/**/*",
-    "/coverage/**/*",
-    "/build/**/*",
-    "/reports/**/*",
-    "/temp/**/*",
-    "/docs/**/*",
-    "/demo/**/*",
-    "/node_modules/**/*",
-    "/vendor/**/*",
-  ],
-  customSyntax: "postcss-styled-syntax",
-  extends: [
-    "stylelint-config-recommended",
-    "stylelint-config-styled-components",
-  ],
-  rules: { "selector-type-no-unknown": null, "function-no-unknown": null },
-};
+const { stylelintConfig } = require('./stylelint/export.mjs');
+
+exports.stylelintConfig = stylelintConfig;

package/lib/skills/migrate-to-pui-cli-9/SKILL.md

@@ -1,15 +1,17 @@
 ---
 name: migrate-to-pui-cli-9
 description: >-
-  Migrate a PUI app or library to pui-cli 9 (Node 24, pnpm 11, ESLint 9 flat config).
-  Use when upgrading @elliemae/pui-cli, migrating from .eslintrc.cjs to eslint.config.mjs,
-  fixing ESLint 9 lint failures, or adopting the shared flat config from pui-cli.
+  Migrate a PUI app or library to pui-cli 9 (Node 24, pnpm 11, ESLint 10 flat config, Stylelint 17,
+  Husky 9, Vitest 4). Use when upgrading @elliemae/pui-cli, migrating from .eslintrc.cjs to
+  eslint.config.mjs, upgrading Husky 8 hooks, fixing Vitest 4 / coverage-v8 breakages, or adopting
+  shared configs from pui-cli. App/library production builds stay on Webpack.
 ---
 
 # Migrate to pui-cli 9
 
 Upgrades a PUI repo from pui-cli 8 (ESLint 8 + `.eslintrc.cjs`) to pui-cli 9
-(ESLint 9 + `eslint.config.mjs` + Node 24 + pnpm 11).
+(ESLint 10 + `eslint.config.mjs` + Node 24 + pnpm 11). Production bundling remains Webpack;
+Vitest 4 uses Vite only as the test runner when you run `pui-cli vitest`.
 
 ## Pre-flight: Toolchain
 
@@ -42,7 +44,7 @@ pnpm add -D @elliemae/pui-cli@9
 
 Re-run install and smoke-test build/test without ESLint changes yet if the bump is large.
 
-### Phase 3 — ESLint 9 flat config
+### Phase 3 — ESLint 10 flat config
 
 **React apps and libraries:**
 
@@ -95,13 +97,111 @@ export default [
 
 Remove overrides in a follow-up debt PR. Do not copy Airbnb or legacy `.eslintrc` rules.
 
-### Phase 5 — Verify
+### Phase 5 — Husky 9 (if `.husky/` exists)
+
+Skip this phase if the repo has no git hooks. Most PUI apps/libs copied hooks from pui-cli boilerplate and still use Husky 8.
+
+1. Upgrade and remove deprecated package:
+
+```bash
+pnpm add -D husky@9
+pnpm remove husky-init   # if present
+```
+
+2. Update `package.json` `prepare` script:
+
+```diff
+- "prepare": "[ -n \"$CI\" ] || husky install"
++ "prepare": "[ -n \"$CI\" ] || husky"
+```
+
+3. Simplify each hook in `.husky/` — remove the shebang and `husky.sh` source. Keep only the command(s):
+
+**`.husky/pre-commit`** (typical PUI repo):
+
+```sh
+pnpm -s dlx lint-staged
+```
+
+**`.husky/commit-msg`** (if commitlint is enabled):
+
+```sh
+pnpm exec commitlint --edit $1
+```
+
+```diff
+- #!/bin/sh
+- . "$(dirname "$0")/_/husky.sh"
+-
+  pnpm -s dlx lint-staged
+```
+
+4. Delete `.husky/.gitignore` if present (Husky 9 regenerates `.husky/_` on install).
+
+5. Run `pnpm prepare`, then verify hooks with a test commit.
+
+**Environment variable changes (Husky 9):**
+
+| Husky 8                                   | Husky 9       |
+| ----------------------------------------- | ------------- |
+| `HUSKY_SKIP_HOOKS` / `HUSKY_SKIP_INSTALL` | `HUSKY=0`     |
+| `HUSKY_GIT_PARAMS` in commit-msg hooks    | `$1`, `$2`, … |
+
+Reference hooks: [pui-cli/.husky](https://git.elliemae.io/platform-ui/pui-cli/tree/master/.husky)
+
+### Phase 6 — Stylelint 17 (if CSS / styled-components)
+
+1. Simplify `stylelint.config.cjs` — remove `stylelint-config-styled-components` workarounds.
+2. Optional ESM: `stylelint.config.mjs` importing `@elliemae/pui-cli/stylelint`.
+3. Run `pnpm exec pui-cli lint` (CSS pass).
+
+See [stylelint-migration.md](https://docs.pui.mortgagetech.q1.ice.com/cli/stylelint-migration) in pui-cli docs.
+
+### Phase 7 — Vitest 4 (if using `pui-cli vitest`)
+
+Skip if the repo uses Jest (`pui-cli test`) only.
+
+1. Align devDependencies with pui-cli 9 (Vitest 4 stack):
+
+```bash
+pnpm add -D vitest@4 @vitest/coverage-v8@4 vite@8 @vitejs/plugin-react@6 vite-tsconfig-paths@6
+pnpm remove @vitest/coverage-c8 @types/uuid   # when upgrading uuid to 14+
+```
+
+2. Prefer extending shared config:
+
+```typescript
+import { defineConfig, mergeConfig } from 'vitest/config';
+import { vitestConfig } from '@elliemae/pui-cli/vitest';
+
+export default mergeConfig(
+  vitestConfig,
+  defineConfig({
+    test: {
+      /* overrides */
+    },
+  }),
+);
+```
+
+3. Update custom Vitest 1.x options:
+
+| Old                       | New                          |
+| ------------------------- | ---------------------------- |
+| `test.deps.optimizer.web` | `test.deps.optimizer.client` |
+| `@vitest/coverage-c8`     | `@vitest/coverage-v8`        |
+
+4. If `tsconfig.json` extends `@elliemae/pui-cli/app.tsconfig.json` or `library.tsconfig.json`, ensure pui-cli 9 is installed — shared tsconfigs use `moduleResolution: "bundler"`. Custom tsconfigs importing `vitest/config` may need the same.
+
+5. Smoke-test: `pnpm exec pui-cli vitest --passWithNoTests`
+
+### Phase 8 — Verify
 
 - [ ] `pnpm exec pui-cli lint` — 0 errors
 - [ ] `pnpm exec pui-cli tscheck --files`
-- [ ] `pnpm test`
-- [ ] `pnpm run build` (or `pui-cli build`)
-- [ ] Pre-commit / lint-staged passes
+- [ ] `pnpm test` (or `pui-cli vitest` if applicable)
+- [ ] `pnpm run build` (or `pui-cli build`) — Webpack, unchanged
+- [ ] Pre-commit / lint-staged passes (after Husky 9 migration if applicable)
 - [ ] CI green on the target branch
 
 ## Common lint fixes after upgrade
@@ -114,6 +214,9 @@ Remove overrides in a follow-up debt PR. Do not copy Airbnb or legacy `.eslintrc
 | Stale `eslint-disable` comments      | Remove disables for rules no longer in config                          |
 | Test/fixture files flagged           | Shared config includes `lib/**/tests/**` globs — ensure pui-cli 9.0.0+ |
 | `.d.ts` files                        | pui-cli turns off `no-explicit-any` for `**/*.d.ts`                    |
+| Cannot find module `vite` in tscheck | Set `moduleResolution: "bundler"` or extend pui-cli 9 tsconfig         |
+| Vitest `optimizer.web` unknown       | Rename to `test.deps.optimizer.client` (Vitest 4)                      |
+| Coverage fails after upgrade         | Remove `@vitest/coverage-c8`; use `@vitest/coverage-v8@4`              |
 
 Full rule comparison: [eslint-rules-migration.md](https://docs.pui.mortgagetech.q1.ice.com/cli/eslint-rules-migration) (also at `docs/eslint-rules-migration.md` in pui-cli).
 
@@ -130,11 +233,12 @@ Skills are copied to `.cursor/skills/`, `.claude/skills/`, and `.github/skills/`
 ## What NOT to change
 
 - Application business logic — migration is tooling/config only
-- Webpack/babel config unless pui-cli 9 release notes require it
-- Prettier / Stylelint / commitlint configs unless pui-cli 9 bumps those presets
+- Webpack/babel production build config — pui-cli 9 does not migrate apps to Vite for bundling
+- Prettier / commitlint configs unless pui-cli 9 bumps those presets
 
 ## Additional resources
 
 - [pui-cli 9 migration guide](https://docs.pui.mortgagetech.q1.ice.com/cli/pui-cli-9-migration)
 - [ESLint rules migration guide](https://docs.pui.mortgagetech.q1.ice.com/cli/eslint-rules-migration)
+- [Stylelint migration guide](https://docs.pui.mortgagetech.q1.ice.com/cli/stylelint-migration)
 - Reference one-liner: `pui-react-boilerplate/eslint.config.mjs`

package/library.tsconfig.json

@@ -1,7 +1,7 @@
 {
   "compilerOptions": {
     "lib": ["dom", "dom.iterable", "ES2022"],
-    "moduleResolution": "node",
+    "moduleResolution": "bundler",
     "target": "ES2022",
     "module": "ESNext",
     "allowJs": true,

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@elliemae/pui-cli",
-  "version": "9.0.0-alpha.8",
+  "version": "9.0.0-alpha.9",
   "description": "ICE MT UI Platform CLI",
   "sideEffects": false,
   "main": "./dist/cjs/index.cjs",
@@ -31,6 +31,10 @@
     "./eslint": {
       "import": "./lib/lint-config/eslint/flat/index.mjs",
       "default": "./lib/lint-config/eslint/flat/index.mjs"
+    },
+    "./stylelint": {
+      "import": "./lib/lint-config/stylelint/export.mjs",
+      "default": "./lib/lint-config/stylelint/export.mjs"
     }
   },
   "files": [
@@ -81,7 +85,7 @@
     "@commitlint/cli": "~21.0.1",
     "@commitlint/config-conventional": "~21.0.1",
     "@elliemae/browserslist-config-elliemae-latest-browsers": "~1.14.4",
-    "@eslint/compat": "~1.4.1",
+    "@eslint/compat": "~2.1.0",
     "@eslint/js": "~10.0.1",
     "@faker-js/faker": "~7.6.0",
     "@nrwl/cli": "~15.9.7",
@@ -130,13 +134,11 @@
     "@types/speed-measure-webpack-plugin": "~1.3.6",
     "@types/supertest": "~2.0.16",
     "@types/testing-library__jest-dom": "~5.14.9",
-    "@types/uuid": "~9.0.8",
     "@types/webpack-bundle-analyzer": "~4.7.0",
     "@types/ws": "~8.18.1",
     "@types/yargs": "~17.0.35",
-    "@vitejs/plugin-react": "~4.7.0",
-    "@vitest/coverage-c8": "~0.33.0",
-    "@vitest/coverage-v8": "~0.34.6",
+    "@vitejs/plugin-react": "~6.0.2",
+    "@vitest/coverage-v8": "~4.1.7",
     "autoprefixer": "~10.5.0",
     "axe-core": "~4.11.3",
     "babel-plugin-date-fns": "~2.0.0",
@@ -160,12 +162,12 @@
     "compression-webpack-plugin": "~10.0.0",
     "copy-webpack-plugin": "~11.0.0",
     "cors": "~2.8.6",
-    "cross-env": "~7.0.3",
+    "cross-env": "~10.1.0",
     "css-loader": "~6.11.0",
     "css-minimizer-webpack-plugin": "~5.0.1",
     "depcheck": "~1.4.7",
     "docdash": "~2.0.2",
-    "dotenv": "~16.6.1",
+    "dotenv": "~17.4.2",
     "dotenv-webpack": "~8.1.1",
     "duplicate-package-checker-webpack-plugin": "~3.0.0",
     "enhanced-resolve": "~5.21.0",
@@ -185,23 +187,22 @@
     "eslint-plugin-storybook": "~0.12.0",
     "eslint-plugin-testing-library": "~7.16.2",
     "eslint-plugin-wdio": "~9.27.1",
-    "execa": "~7.2.0",
+    "execa": "~9.6.1",
     "express": "~4.22.1",
     "express-static-gzip": "~2.2.0",
     "fast-glob": "~3.3.3",
     "favicons": "~7.2.0",
     "favicons-webpack-plugin": "~6.0.1",
-    "find-up": "~6.3.0",
-    "find-up-cli": "~5.0.0",
-    "glob": "~11.1.0",
+    "find-up": "~8.0.0",
+    "find-up-cli": "~6.0.0",
+    "glob": "~13.0.6",
     "globals": "~17.6.0",
     "happy-dom": "~12.10.3",
     "helmet": "~8.1.0",
     "html-loader": "~4.2.0",
     "html-webpack-plugin": "~5.6.7",
     "http-server": "~14.1.1",
-    "husky": "~8.0.3",
-    "husky-init": "~8.0.0",
+    "husky": "~9.1.7",
     "imports-loader": "~4.0.1",
     "ip": "~1.1.9",
     "jest-axe": "~7.0.1",
@@ -255,7 +256,6 @@
     "style-loader": "~3.3.4",
     "stylelint": "~17.12.0",
     "stylelint-config-recommended": "~18.0.0",
-    "stylelint-config-styled-components": "~0.1.1",
     "supertest": "~6.3.4",
     "swc-loader": "~0.2.7",
     "ts-node": "~10.9.2",
@@ -265,12 +265,12 @@
     "typedoc": "~0.28.19",
     "typescript": "5.9.3",
     "typescript-eslint": "~8.59.4",
-    "update-notifier": "~6.0.2",
+    "update-notifier": "~7.3.1",
     "url-loader": "~4.1.1",
-    "uuid": "~9.0.1",
-    "vite": "~5.4.21",
-    "vite-tsconfig-paths": "~4.3.2",
-    "vitest": "~1.6.1",
+    "uuid": "~14.0.0",
+    "vite": "~8.0.14",
+    "vite-tsconfig-paths": "~6.1.1",
+    "vitest": "~4.1.7",
     "webpack": "~5.106.2",
     "webpack-bundle-analyzer": "~4.10.2",
     "webpack-cli": "~5.1.4",
@@ -280,7 +280,7 @@
     "whatwg-fetch": "~3.6.20",
     "workbox-webpack-plugin": "~6.6.1",
     "ws": "~8.20.0",
-    "yargs": "~17.7.2"
+    "yargs": "~18.0.0"
   },
   "devDependencies": {
     "@docusaurus/types": "~3.9.2",