@elliemae/pui-cli 9.0.0-alpha.3 → 9.0.0-alpha.5

package/lib/lint-config/eslint/flat/common.mjs

@@ -12,6 +12,7 @@ import {
   jestRecommendedRules,
   sharedCoreRules,
   testFiles,
+  testFixtureFiles,
   testJsxFiles,
   testingLibraryDomRules,
   testingLibraryReactRules,
@@ -24,6 +25,7 @@ import {
   jsRules,
   typescriptRules,
   typescriptStrictRules,
+  testFixtureRelaxedRules,
   typescriptTestRelaxedRules,
 } from './rules.mjs';
 
@@ -113,6 +115,10 @@ export function createBaseFlatConfigs(tsRules) {
         'testing-library/no-node-access': 'off',
       },
     },
+    {
+      files: testFixtureFiles,
+      rules: testFixtureRelaxedRules,
+    },
     {
       files: wdioSpecFiles,
       plugins: { wdio, jest },

package/lib/lint-config/eslint/flat/index.mjs

@@ -16,5 +16,6 @@ export {
 export {
   storybookFiles,
   testFiles,
+  testFixtureFiles,
   testJsxFiles,
 } from './presets.mjs';

package/lib/lint-config/eslint/flat/presets.mjs

@@ -12,11 +12,26 @@ import storybook from 'eslint-plugin-storybook';
 import testingLibrary from 'eslint-plugin-testing-library';
 import wdio from 'eslint-plugin-wdio';
 
+/** Application and integration tests (Jest + relaxed type-checked rules). */
 export const testFiles = [
   '**/*.{test,spec}.{js,jsx,ts,tsx}',
   '**/__tests__/**',
   '**/lib/testing/**',
   '**/mocks/**',
+  // PUI libs/apps co-locate tests under lib/ (e.g. pui-app-sdk, pui-app-loader).
+  'lib/**/tests/**',
+  'app/**/tests/**',
+];
+
+/**
+ * Generated or vendored JS under test trees (checksum bundles, MSW endpoints, pinned assets).
+ * Not maintained source — relax structural rules only.
+ */
+export const testFixtureFiles = [
+  '**/*.checksum*.js',
+  '**/*.endpoint.js',
+  '**/tests/**/latest/*.{js,cjs,mjs}',
+  '**/tests/**/[0-9]*.[0-9]*/*.{js,cjs,mjs}',
 ];
 
 export const testJsxFiles = ['**/*.{test,spec}.{jsx,tsx}'];

package/lib/lint-config/eslint/flat/rules.mjs

@@ -49,6 +49,22 @@ export const typescriptTestRelaxedRules = {
   '@typescript-eslint/no-unsafe-argument': 'off',
   '@typescript-eslint/no-unsafe-return': 'off',
   '@typescript-eslint/unbound-method': 'off',
+  '@typescript-eslint/no-unsafe-declaration-merging': 'off',
+  '@typescript-eslint/no-unsafe-enum-comparison': 'off',
+  '@typescript-eslint/await-thenable': 'off',
+  '@typescript-eslint/prefer-promise-reject-errors': 'off',
+  'no-constant-binary-expression': 'off',
+  'valid-typeof': 'off',
+  'prefer-const': 'off',
+};
+
+/** Relaxed core rules for generated test fixture JS (checksum mocks, etc.). */
+export const testFixtureRelaxedRules = {
+  'no-unused-vars': 'off',
+  'no-console': 'off',
+  'max-lines': 'off',
+  'max-statements': 'off',
+  complexity: 'off',
 };
 
 export const jsRules = {

package/lib/skills/migrate-to-pui-cli-9/SKILL.md

@@ -0,0 +1,140 @@
+---
+name: migrate-to-pui-cli-9
+description: >-
+  Migrate a PUI app or library to pui-cli 9 (Node 24, pnpm 11, ESLint 9 flat config).
+  Use when upgrading @elliemae/pui-cli, migrating from .eslintrc.cjs to eslint.config.mjs,
+  fixing ESLint 9 lint failures, or adopting the shared flat config from pui-cli.
+---
+
+# Migrate to pui-cli 9
+
+Upgrades a PUI repo from pui-cli 8 (ESLint 8 + `.eslintrc.cjs`) to pui-cli 9
+(ESLint 9 + `eslint.config.mjs` + Node 24 + pnpm 11).
+
+## Pre-flight: Toolchain
+
+| Requirement         | Version                           |
+| ------------------- | --------------------------------- |
+| Node.js             | **24** (see repo `.node-version`) |
+| pnpm                | **11**                            |
+| `@elliemae/pui-cli` | **9.x** (alpha/beta until GA)     |
+
+```bash
+fnm use 24   # or nvm/volta equivalent
+corepack enable
+pnpm install
+```
+
+## Migration steps (phased PRs recommended)
+
+### Phase 1 — Toolchain only
+
+1. Update `.node-version` to `24` if needed.
+2. Ensure CI Jenkins/docker images use Node 24.
+3. Upgrade pnpm to 11 (`packageManager` field in root `package.json`).
+4. Run `pnpm install`, `pnpm test`, `pnpm run build` — fix any Node/pnpm breakages only.
+
+### Phase 2 — Bump pui-cli
+
+```bash
+pnpm add -D @elliemae/pui-cli@9
+```
+
+Re-run install and smoke-test build/test without ESLint changes yet if the bump is large.
+
+### Phase 3 — ESLint 9 flat config
+
+**React apps and libraries:**
+
+```js
+// eslint.config.mjs
+import { eslintFlatConfig } from '@elliemae/pui-cli/eslint';
+
+export default eslintFlatConfig;
+```
+
+**Node / TS services (non-React):**
+
+```js
+// eslint.config.mjs
+import { eslintFlatBaseConfig } from '@elliemae/pui-cli/eslint';
+
+export default eslintFlatBaseConfig;
+```
+
+Then:
+
+1. Delete `.eslintrc.cjs` and `.eslintignore` (ignores are in the shared config).
+2. Run `pnpm exec pui-cli lint --fix`.
+3. Run `pnpm exec pui-cli lint` until **zero errors** (warnings may remain).
+
+**Strict mode** (only after default config is clean):
+
+```js
+import { eslintFlatConfigStrict } from '@elliemae/pui-cli/eslint';
+export default eslintFlatConfigStrict;
+```
+
+### Phase 4 — Repo-specific overrides (if needed)
+
+Add overrides **after** importing the shared config only when lint debt blocks the migration:
+
+```js
+import { eslintFlatConfig } from '@elliemae/pui-cli/eslint';
+
+export default [
+  ...eslintFlatConfig,
+  {
+    rules: {
+      // Temporary: legacy had ~100 no-explicit-any warnings via @typescript-eslint v5
+      '@typescript-eslint/no-explicit-any': 'warn',
+    },
+  },
+];
+```
+
+Remove overrides in a follow-up debt PR. Do not copy Airbnb or legacy `.eslintrc` rules.
+
+### Phase 5 — Verify
+
+- [ ] `pnpm exec pui-cli lint` — 0 errors
+- [ ] `pnpm exec pui-cli tscheck --files`
+- [ ] `pnpm test`
+- [ ] `pnpm run build` (or `pui-cli build`)
+- [ ] Pre-commit / lint-staged passes
+- [ ] CI green on the target branch
+
+## Common lint fixes after upgrade
+
+| Symptom                              | Fix                                                                    |
+| ------------------------------------ | ---------------------------------------------------------------------- |
+| `import-x/no-unresolved`             | Use `import type` for type-only imports                                |
+| `@typescript-eslint/no-explicit-any` | Type the value or add targeted override (warn) during transition       |
+| `@typescript-eslint/no-unused-vars`  | Remove or prefix with `_`                                              |
+| Stale `eslint-disable` comments      | Remove disables for rules no longer in config                          |
+| Test/fixture files flagged           | Shared config includes `lib/**/tests/**` globs — ensure pui-cli 9.0.0+ |
+| `.d.ts` files                        | pui-cli turns off `no-explicit-any` for `**/*.d.ts`                    |
+
+Full rule comparison: [eslint-rules-migration.md](https://docs.pui.mortgagetech.q1.ice.com/cli/eslint-rules-migration) (also at `docs/eslint-rules-migration.md` in pui-cli).
+
+## Install this skill in Cursor
+
+From the consumer repo (after `@elliemae/pui-cli` is installed):
+
+```bash
+pnpm exec pui-cli skills install migrate-to-pui-cli-9 --target all
+```
+
+Skills are copied to `.cursor/skills/`, `.claude/skills/`, and `.github/skills/` for Cursor, Claude Code, and GitHub Copilot.
+
+## What NOT to change
+
+- Application business logic — migration is tooling/config only
+- Webpack/babel config unless pui-cli 9 release notes require it
+- Prettier / Stylelint / commitlint configs unless pui-cli 9 bumps those presets
+
+## Additional resources
+
+- [pui-cli 9 migration guide](https://docs.pui.mortgagetech.q1.ice.com/cli/pui-cli-9-migration)
+- [ESLint rules migration guide](https://docs.pui.mortgagetech.q1.ice.com/cli/eslint-rules-migration)
+- Reference one-liner: `pui-react-boilerplate/eslint.config.mjs`

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@elliemae/pui-cli",
-  "version": "9.0.0-alpha.3",
+  "version": "9.0.0-alpha.5",
   "description": "ICE MT UI Platform CLI",
   "sideEffects": false,
   "main": "./dist/cjs/index.cjs",
@@ -37,6 +37,7 @@
     "dist",
     "build",
     "lib/lint-config",
+    "lib/skills",
     "./app.tsconfig.json",
     "./library.tsconfig.json"
   ],