@elliemae/ds-dialog 2.3.0-next.7 → 2.3.0-rc.2

package/cjs/DSDialog.js

@@ -79,7 +79,7 @@ const DSDialog = props => {
 
     const body = document.getElementsByTagName('body')[0];
     const {
-      offsetHeight,
+      clientHeight,
       scrollHeight
     } = body;
     const padding = (_window$getComputedSt = window.getComputedStyle(body, null)) === null || _window$getComputedSt === void 0 ? void 0 : _window$getComputedSt.getPropertyValue('padding-right');
@@ -88,7 +88,7 @@ const DSDialog = props => {
       padding: '0px'
     });
     return setBodyInfo({
-      overflow: offsetHeight < scrollHeight,
+      overflow: scrollHeight > clientHeight,
       padding
     });
   }, [isOpen]);

package/cjs/propTypes.js

@@ -18,14 +18,13 @@ var _defineProperty__default = /*#__PURE__*/_interopDefaultLegacy(_definePropert
 function ownKeys(object, enumerableOnly) { var keys = Object.keys(object); if (Object.getOwnPropertySymbols) { var symbols = Object.getOwnPropertySymbols(object); enumerableOnly && (symbols = symbols.filter(function (sym) { return Object.getOwnPropertyDescriptor(object, sym).enumerable; })), keys.push.apply(keys, symbols); } return keys; }
 
 function _objectSpread(target) { for (var i = 1; i < arguments.length; i++) { var source = null != arguments[i] ? arguments[i] : {}; i % 2 ? ownKeys(Object(source), !0).forEach(function (key) { _defineProperty__default["default"](target, key, source[key]); }) : Object.getOwnPropertyDescriptors ? Object.defineProperties(target, Object.getOwnPropertyDescriptors(source)) : ownKeys(Object(source)).forEach(function (key) { Object.defineProperty(target, key, Object.getOwnPropertyDescriptor(source, key)); }); } return target; }
-const propTypes = _objectSpread(_objectSpread({
+const propTypes = _objectSpread(_objectSpread({}, dsPropsHelpers.globalAttributesPropTypes), {}, {
   isOpen: dsPropsHelpers.PropTypes.bool.description('Whether the Dialog is open or not.').defaultValue(false),
   children: dsPropsHelpers.PropTypes.node.description('Nested components.').isRequired,
   centered: dsPropsHelpers.PropTypes.bool.description('Centers the Dialog.').defaultValue(false),
   removeAutoFocus: dsPropsHelpers.PropTypes.bool.description('Removes focus in the Dialog container when is open. If you want to focus an specific element in the Dialog, it should be set to true.').defaultValue(false),
   onClickOutside: dsPropsHelpers.PropTypes.func.description('Callback that should be used to close the modal when the user clicks outside.').defaultValue(() => {}),
-  onClose: dsPropsHelpers.PropTypes.func.description('Callback triggered with ESC key.').defaultValue(() => {})
-}, dsPropsHelpers.globalAttributesPropTypes), {}, {
+  onClose: dsPropsHelpers.PropTypes.func.description('Callback triggered with ESC key.').defaultValue(() => {}),
   size: dsPropsHelpers.PropTypes.oneOf(utils.DSDialogSizesArrayValues).description("Dialog's width size.").defaultValue(utils.DSDialogSizes.DEFAULT)
 });
 

package/esm/DSDialog.js

@@ -68,7 +68,7 @@ const DSDialog = props => {
 
     const body = document.getElementsByTagName('body')[0];
     const {
-      offsetHeight,
+      clientHeight,
       scrollHeight
     } = body;
     const padding = (_window$getComputedSt = window.getComputedStyle(body, null)) === null || _window$getComputedSt === void 0 ? void 0 : _window$getComputedSt.getPropertyValue('padding-right');
@@ -77,7 +77,7 @@ const DSDialog = props => {
       padding: '0px'
     });
     return setBodyInfo({
-      overflow: offsetHeight < scrollHeight,
+      overflow: scrollHeight > clientHeight,
       padding
     });
   }, [isOpen]);

package/esm/propTypes.js

@@ -10,14 +10,13 @@ import { DSDialogSizesArrayValues, DSDialogSizes } from './utils.js';
 function ownKeys(object, enumerableOnly) { var keys = Object.keys(object); if (Object.getOwnPropertySymbols) { var symbols = Object.getOwnPropertySymbols(object); enumerableOnly && (symbols = symbols.filter(function (sym) { return Object.getOwnPropertyDescriptor(object, sym).enumerable; })), keys.push.apply(keys, symbols); } return keys; }
 
 function _objectSpread(target) { for (var i = 1; i < arguments.length; i++) { var source = null != arguments[i] ? arguments[i] : {}; i % 2 ? ownKeys(Object(source), !0).forEach(function (key) { _defineProperty(target, key, source[key]); }) : Object.getOwnPropertyDescriptors ? Object.defineProperties(target, Object.getOwnPropertyDescriptors(source)) : ownKeys(Object(source)).forEach(function (key) { Object.defineProperty(target, key, Object.getOwnPropertyDescriptor(source, key)); }); } return target; }
-const propTypes = _objectSpread(_objectSpread({
+const propTypes = _objectSpread(_objectSpread({}, globalAttributesPropTypes), {}, {
   isOpen: PropTypes.bool.description('Whether the Dialog is open or not.').defaultValue(false),
   children: PropTypes.node.description('Nested components.').isRequired,
   centered: PropTypes.bool.description('Centers the Dialog.').defaultValue(false),
   removeAutoFocus: PropTypes.bool.description('Removes focus in the Dialog container when is open. If you want to focus an specific element in the Dialog, it should be set to true.').defaultValue(false),
   onClickOutside: PropTypes.func.description('Callback that should be used to close the modal when the user clicks outside.').defaultValue(() => {}),
-  onClose: PropTypes.func.description('Callback triggered with ESC key.').defaultValue(() => {})
-}, globalAttributesPropTypes), {}, {
+  onClose: PropTypes.func.description('Callback triggered with ESC key.').defaultValue(() => {}),
   size: PropTypes.oneOf(DSDialogSizesArrayValues).description("Dialog's width size.").defaultValue(DSDialogSizes.DEFAULT)
 });
 

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@elliemae/ds-dialog",
-  "version": "2.3.0-next.7",
+  "version": "2.3.0-rc.2",
   "license": "MIT",
   "description": "ICE MT - Dimsum - Dialog",
   "module": "./esm/index.js",
@@ -60,8 +60,10 @@
     "build": "node ../../scripts/build/build.js"
   },
   "dependencies": {
-    "@elliemae/ds-props-helpers": "2.3.0-next.7",
-    "@elliemae/ds-system": "2.3.0-next.7",
+    "@elliemae/ds-button": "2.3.0-rc.2",
+    "@elliemae/ds-icons": "2.3.0-rc.2",
+    "@elliemae/ds-props-helpers": "2.3.0-rc.2",
+    "@elliemae/ds-system": "2.3.0-rc.2",
     "@xstyled/styled-components": "~3.1.1",
     "react-desc": "~4.1.3"
   },

package/types/DSDialog.d.ts

@@ -3,6 +3,12 @@ import type { DSDialogT } from './propTypes';
 declare const DSDialog: {
     (props: DSDialogT.Props): React.ReactPortal | null;
     propTypes: {
+        isOpen: import("@elliemae/ds-props-helpers/types/propTypes/types").ReactDescT;
+        children: import("@elliemae/ds-props-helpers/types/propTypes/types").ReactDescT;
+        centered: import("@elliemae/ds-props-helpers/types/propTypes/types").ReactDescT;
+        removeAutoFocus: import("@elliemae/ds-props-helpers/types/propTypes/types").ReactDescT;
+        onClickOutside: import("@elliemae/ds-props-helpers/types/propTypes/types").ReactDescT;
+        onClose: import("@elliemae/ds-props-helpers/types/propTypes/types").ReactDescT;
         size: import("@elliemae/ds-props-helpers/types/propTypes/types").ReactDescT;
         'aria-*': import("@elliemae/ds-props-helpers/types/propTypes/types").ReactDescT;
         'on-*': import("@elliemae/ds-props-helpers/types/propTypes/types").ReactDescT;
@@ -364,12 +370,6 @@ declare const DSDialog: {
         width: import("@elliemae/ds-props-helpers/types/propTypes/types").ReactDescT;
         wmode: import("@elliemae/ds-props-helpers/types/propTypes/types").ReactDescT;
         wrap: import("@elliemae/ds-props-helpers/types/propTypes/types").ReactDescT;
-        isOpen: import("@elliemae/ds-props-helpers/types/propTypes/types").ReactDescT;
-        children: import("@elliemae/ds-props-helpers/types/propTypes/types").ReactDescT;
-        centered: import("@elliemae/ds-props-helpers/types/propTypes/types").ReactDescT;
-        removeAutoFocus: import("@elliemae/ds-props-helpers/types/propTypes/types").ReactDescT;
-        onClickOutside: import("@elliemae/ds-props-helpers/types/propTypes/types").ReactDescT;
-        onClose: import("@elliemae/ds-props-helpers/types/propTypes/types").ReactDescT;
     };
 };
 declare const DSDialogWithSchema: import("@elliemae/ds-props-helpers/types/propTypes/types").DocumentedReactComponent<DSDialogT.Props>;

package/types/propTypes.d.ts

@@ -18,6 +18,12 @@ export declare namespace DSDialogT {
     }
 }
 export declare const propTypes: {
+    isOpen: import("@elliemae/ds-props-helpers/types/propTypes/types").ReactDescT;
+    children: import("@elliemae/ds-props-helpers/types/propTypes/types").ReactDescT;
+    centered: import("@elliemae/ds-props-helpers/types/propTypes/types").ReactDescT;
+    removeAutoFocus: import("@elliemae/ds-props-helpers/types/propTypes/types").ReactDescT;
+    onClickOutside: import("@elliemae/ds-props-helpers/types/propTypes/types").ReactDescT;
+    onClose: import("@elliemae/ds-props-helpers/types/propTypes/types").ReactDescT;
     size: import("@elliemae/ds-props-helpers/types/propTypes/types").ReactDescT;
     'aria-*': import("@elliemae/ds-props-helpers/types/propTypes/types").ReactDescT;
     'on-*': import("@elliemae/ds-props-helpers/types/propTypes/types").ReactDescT;
@@ -379,10 +385,4 @@ export declare const propTypes: {
     width: import("@elliemae/ds-props-helpers/types/propTypes/types").ReactDescT;
     wmode: import("@elliemae/ds-props-helpers/types/propTypes/types").ReactDescT;
     wrap: import("@elliemae/ds-props-helpers/types/propTypes/types").ReactDescT;
-    isOpen: import("@elliemae/ds-props-helpers/types/propTypes/types").ReactDescT;
-    children: import("@elliemae/ds-props-helpers/types/propTypes/types").ReactDescT;
-    centered: import("@elliemae/ds-props-helpers/types/propTypes/types").ReactDescT;
-    removeAutoFocus: import("@elliemae/ds-props-helpers/types/propTypes/types").ReactDescT;
-    onClickOutside: import("@elliemae/ds-props-helpers/types/propTypes/types").ReactDescT;
-    onClose: import("@elliemae/ds-props-helpers/types/propTypes/types").ReactDescT;
 };