@elizaos/plugin-wallet 2.0.0-beta.1 → 2.0.3-beta.6

package/src/analytics/birdeye/providers/portfolio-factory.ts

@@ -1,20 +1,33 @@
-// @ts-nocheck — legacy code from absorbed plugins (lp-manager, lpinfo, dexscreener, defi-news, birdeye); strict types pending cleanup
 import type { IAgentRuntime, Memory, Provider, State } from "@elizaos/core";
+import { sanitizeWalletDisplayLabel } from "../../../security/wallet-context-safety.js";
 import { BIRDEYE_SERVICE_NAME } from "../constants";
-import type { WalletPortfolioResponse } from "../types/api/wallet";
+import type {
+  WalletPortfolioResponse,
+  WalletTransactionHistoryResponse,
+} from "../types/api/wallet";
+import type {
+  BirdeyeSupportedChain,
+  GetCacheTimedOptions,
+} from "../types/shared";
 import { extractChain, formatJsonScalar, formatJsonTable } from "../utils";
 
+type PortfolioData = WalletPortfolioResponse["data"];
+type WalletTransaction =
+  WalletTransactionHistoryResponse["data"][string][number];
+type PortfolioResult = PortfolioData | false;
+type TradesResult = WalletTransaction[] | false | undefined;
+
 type PortfolioService = {
-  fetchWalletTokenList?: (
-    chain: unknown,
+  fetchWalletTokenList: (
+    chain: BirdeyeSupportedChain,
     walletAddr: string,
-    opts: { notOlderThan: number },
-  ) => Promise<unknown>;
+    opts: GetCacheTimedOptions,
+  ) => Promise<PortfolioResult>;
   fetchWalletTxList?: (
-    chain: unknown,
+    chain: BirdeyeSupportedChain,
     walletAddr: string,
-    opts: { notOlderThan: number },
-  ) => Promise<unknown[]>;
+    opts: GetCacheTimedOptions,
+  ) => Promise<WalletTransaction[] | false>;
 };
 
 export interface BirdeyePortfolioProviderOptions {
@@ -32,22 +45,43 @@ function statusJson(name: string, status: string, reason: string): string {
   ].join("\n");
 }
 
-function normalizePortfolioResponse(response: unknown) {
-  if (response?.data?.items) {
-    return response.data;
+function settingAsString(value: unknown): string | undefined {
+  return typeof value === "string" && value.trim().length > 0
+    ? value
+    : undefined;
+}
+
+function isRecord(value: unknown): value is Record<string, unknown> {
+  return typeof value === "object" && value !== null;
+}
+
+function hasPortfolioItems(value: unknown): value is PortfolioData {
+  return isRecord(value) && Array.isArray(value.items);
+}
+
+function normalizePortfolioResponse(
+  response: PortfolioData | WalletPortfolioResponse | false | undefined,
+): PortfolioData {
+  const wrappedData =
+    isRecord(response) && "data" in response ? response.data : undefined;
+  if (hasPortfolioItems(wrappedData)) {
+    return wrappedData;
   }
-  return response ?? {};
+  if (hasPortfolioItems(response)) {
+    return response;
+  }
+  return { items: [] };
 }
 
 export const formatPortfolio = (response: WalletPortfolioResponse) => {
   const portfolio = normalizePortfolioResponse(response);
-  const items = portfolio.items ?? [];
+  const items = portfolio.items;
   if (!items.length) return "holdings[0]: []";
 
   return formatJsonTable(
     "holdings",
     items.map((item) => ({
-      symbol: item.symbol || "unknown",
+      symbol: sanitizeWalletDisplayLabel(item.symbol || "unknown"),
       address: item.address || "unknown",
       amount:
         typeof item.uiAmount === "number"
@@ -75,11 +109,12 @@ function formatPortfolioProviderText({
 }: {
   wallet: string;
   chain: string;
-  portfolio: unknown;
-  trades?: unknown[];
+  portfolio: PortfolioResult;
+  trades?: TradesResult;
 }): string {
   const normalized = normalizePortfolioResponse(portfolio);
-  const holdings = normalized.items ?? [];
+  const holdings = normalized.items;
+  const tradeRows = Array.isArray(trades) ? trades : undefined;
   const lines = [
     "birdeye_wallet_portfolio:",
     "  status: ok",
@@ -89,7 +124,7 @@ function formatPortfolioProviderText({
     formatJsonTable(
       "  holdings",
       holdings.slice(0, 20).map((item) => ({
-        symbol: item.symbol || "unknown",
+        symbol: sanitizeWalletDisplayLabel(item.symbol || "unknown"),
         address: item.address || "unknown",
         amount:
           typeof item.uiAmount === "number"
@@ -109,12 +144,12 @@ function formatPortfolioProviderText({
     ),
   ];
 
-  if (trades) {
-    lines.push(`  tradeCount: ${trades.length}`);
+  if (tradeRows) {
+    lines.push(`  tradeCount: ${tradeRows.length}`);
     lines.push(
       formatJsonTable(
         "  trades",
-        trades.slice(0, 10).map((trade) => ({
+        tradeRows.slice(0, 10).map((trade) => ({
           txHash: trade.txHash ?? "unknown",
           action: trade.mainAction ?? "unknown",
           status: trade.status ?? "unknown",
@@ -135,7 +170,7 @@ function getPortfolioService(
   includeTrades: boolean,
 ): PortfolioService | undefined {
   const beService = runtime.getService(BIRDEYE_SERVICE_NAME) as
-    | PortfolioService
+    | Partial<PortfolioService>
     | undefined;
   if (!beService || typeof beService.fetchWalletTokenList !== "function") {
     return undefined;
@@ -143,7 +178,10 @@ function getPortfolioService(
   if (includeTrades && typeof beService.fetchWalletTxList !== "function") {
     return undefined;
   }
-  return beService;
+  return {
+    fetchWalletTokenList: beService.fetchWalletTokenList,
+    fetchWalletTxList: beService.fetchWalletTxList,
+  };
 }
 
 export function createBirdeyePortfolioProvider(
@@ -160,13 +198,13 @@ export function createBirdeyePortfolioProvider(
     cacheStable: false,
     cacheScope: "turn",
     roleGate: { minRole: "OWNER" },
-    get: async (runtime: IAgentRuntime, _message: Memory, _state?: State) => {
+    get: async (runtime: IAgentRuntime, _message: Memory, _state: State) => {
       try {
-        const walletAddr = runtime.getSetting("BIRDEYE_WALLET_ADDR");
+        const walletAddr = settingAsString(
+          runtime.getSetting("BIRDEYE_WALLET_ADDR"),
+        );
         if (!walletAddr) {
-          runtime.logger?.error(
-            "BIRDEYE_WALLET_ADDR setting is not configured",
-          );
+          runtime.logger.error("BIRDEYE_WALLET_ADDR setting is not configured");
           return {
             values: {},
             text: statusJson(
@@ -178,11 +216,13 @@ export function createBirdeyePortfolioProvider(
           };
         }
 
-        const explicitChain = runtime.getSetting("BIRDEYE_CHAIN");
+        const explicitChain = settingAsString(
+          runtime.getSetting("BIRDEYE_CHAIN"),
+        );
         const chain = extractChain(walletAddr, explicitChain);
         const beService = getPortfolioService(runtime, includeTrades);
         if (!beService) {
-          runtime.logger?.error(
+          runtime.logger.error(
             "Birdeye service is unavailable or missing required portfolio methods",
           );
           return {
@@ -203,18 +243,19 @@ export function createBirdeyePortfolioProvider(
           walletAddr,
           { notOlderThan: 30 * 1000 },
         );
-        const tradesPromise = includeTrades
-          ? beService.fetchWalletTxList(chain, walletAddr, {
-              notOlderThan: 30 * 1000,
-            })
-          : Promise.resolve(undefined);
+        const tradesPromise: Promise<TradesResult> =
+          includeTrades && beService.fetchWalletTxList
+            ? beService.fetchWalletTxList(chain, walletAddr, {
+                notOlderThan: 30 * 1000,
+              })
+            : Promise.resolve(undefined);
         const [portfolio, trades] = await Promise.all([
           portfolioPromise,
           tradesPromise,
         ]);
 
         return {
-          data: includeTrades ? { portfolio, trades } : portfolio,
+          data: includeTrades ? { portfolio, trades } : { portfolio },
           values: {},
           text: formatPortfolioProviderText({
             wallet: walletAddr,
@@ -226,7 +267,7 @@ export function createBirdeyePortfolioProvider(
       } catch (error) {
         const errorMessage =
           error instanceof Error ? error.message : String(error);
-        runtime.logger?.error(
+        runtime.logger.error(
           `Error fetching Birdeye portfolio: ${errorMessage}`,
         );
 

package/src/analytics/birdeye/providers/trending.ts

@@ -1,4 +1,3 @@
-// @ts-nocheck — legacy code from absorbed plugins (lp-manager, lpinfo, dexscreener, defi-news, birdeye); strict types pending cleanup
 import type { IAgentRuntime, Memory, Provider, State } from "@elizaos/core";
 import { formatJsonScalar, formatJsonTable } from "../utils";
 
@@ -13,6 +12,28 @@ interface TrendingToken {
   liquidity: number;
 }
 
+type SupplyMap = Record<
+  string,
+  {
+    human?: {
+      multipliedBy: (n: number) => {
+        toFixed: (p: number) => string;
+      };
+    };
+  }
+>;
+
+type TrendingRow = {
+  chain: string;
+  address: string;
+  symbol: string;
+  priceUsd: string;
+  marketCapUsd: string;
+  volume24hUsd: string;
+  change24hPct: string;
+  liquidityUsd: string;
+};
+
 export async function getCacheTimed<T>(
   runtime: IAgentRuntime,
   key: string,
@@ -35,12 +56,6 @@ export async function getCacheTimed<T>(
 /**
  * Provider for Birdeye trending coins
  *
- * @typedef {import('./Provider').Provider} Provider
- * @typedef {import('./Runtime').IAgentRuntime} IAgentRuntime
- * @typedef {import('./Memory').Memory} Memory
- * @typedef {import('./State').State} State
- * @typedef {import('./Action').Action} Action
- *
  * @type {Provider}
  * @property {string} name - The name of the provider
  * @property {string} description - Description of the provider
@@ -65,7 +80,7 @@ export const trendingProvider: Provider = {
   //position: -1,
   get: async (runtime: IAgentRuntime, _message: Memory, _state: State) => {
     try {
-      runtime.logger?.log("birdeye:provider:trending - get birdeye");
+      runtime.logger.log("birdeye:provider:trending - get birdeye");
       // Get all sentiments
 
       /*
@@ -81,7 +96,7 @@ export const trendingProvider: Provider = {
         setAt: number;
       }>("tokens_v2_solana");
       if (!solanaCache?.data) {
-        runtime.logger?.warn(
+        runtime.logger.warn(
           "birdeye:provider:trending - no birdeye token data found",
         );
         return {
@@ -97,7 +112,7 @@ export const trendingProvider: Provider = {
       const solanaTokens = solanaCache.data;
       //console.log('intel:provider - birdeye data', tokens)
       if (!solanaTokens.length) {
-        runtime.logger?.warn(
+        runtime.logger.warn(
           "birdeye:provider:trending - no birdeye token data found",
         );
         return {
@@ -129,26 +144,15 @@ export const trendingProvider: Provider = {
       price24hChangePercent: 1.17760374,
       */
 
-      const rows = [];
+      const rows: TrendingRow[] = [];
 
       const solanaService = runtime.getService("chain_solana") as
         | {
-            getSupply?: (addresses: string[]) => Promise<
-              Record<
-                string,
-                {
-                  human?: {
-                    multipliedBy: (n: number) => {
-                      toFixed: (p: number) => string;
-                    };
-                  };
-                }
-              >
-            >;
+            getSupply?: (addresses: string[]) => Promise<SupplyMap>;
           }
         | undefined;
       if (!solanaService) {
-        runtime.logger?.warn(
+        runtime.logger.warn(
           "no chain_solana service found - market cap calculation will be skipped for Solana tokens",
         );
       }
@@ -157,20 +161,13 @@ export const trendingProvider: Provider = {
       let tokens = [...topSolanaTokens];
 
       // Try to get supply data if solanaService is available
-      let supplies: Record<
-        string,
-        {
-          human?: {
-            multipliedBy: (n: number) => { toFixed: (p: number) => string };
-          };
-        }
-      > = {};
-      if (solanaService) {
+      let supplies: SupplyMap = {};
+      if (solanaService && typeof solanaService.getSupply === "function") {
         try {
           const CAs = topSolanaTokens.map((t) => t.address);
           supplies = await solanaService.getSupply(CAs);
         } catch (error) {
-          runtime.logger?.warn(
+          runtime.logger.warn(
             `Failed to get supply data from Solana service: ${error instanceof Error ? error.message : String(error)}`,
           );
         }
@@ -187,14 +184,14 @@ export const trendingProvider: Provider = {
 
         // Damnatio memoriae
         if (rugCache && rugCache === "rug") {
-          runtime.logger?.log("omitting", token.address, "because in rugCache");
+          runtime.logger.log("omitting", token.address, "because in rugCache");
           continue;
         }
 
         // Calculate market cap if supply data is available
         let mcapValue = "?";
-        if (supplies[token.address]?.human) {
-          const supply = supplies[token.address].human;
+        const supply = supplies[token.address]?.human;
+        if (supply) {
           const mcap = supply.multipliedBy(token.price);
           mcapValue = mcap.toFixed(0);
           //console.log('Hum supply', supply.toFormat(), 'price', token.price, 'mcap', mcap.toFormat(2))
@@ -238,11 +235,11 @@ export const trendingProvider: Provider = {
             chain: "ethereum",
             address: token.address,
             symbol: token.symbol,
-            priceUsd: token.price?.toFixed(4) || "0",
+            priceUsd: token.price.toFixed(4) || "0",
             marketCapUsd: "unknown",
-            volume24hUsd: token.volume24hUSD?.toFixed(0) || "0",
-            change24hPct: token.price24hChangePercent?.toFixed(2) || "0",
-            liquidityUsd: token.liquidity?.toFixed(2) || "0",
+            volume24hUsd: token.volume24hUSD.toFixed(0) || "0",
+            change24hPct: token.price24hChangePercent.toFixed(2) || "0",
+            liquidityUsd: token.liquidity.toFixed(2) || "0",
           });
         }
       }
@@ -271,11 +268,11 @@ export const trendingProvider: Provider = {
             chain: "base",
             address: token.address,
             symbol: token.symbol,
-            priceUsd: token.price?.toFixed(4) || "0",
+            priceUsd: token.price.toFixed(4) || "0",
             marketCapUsd: "unknown",
-            volume24hUsd: token.volume24hUSD?.toFixed(0) || "0",
-            change24hPct: token.price24hChangePercent?.toFixed(2) || "0",
-            liquidityUsd: token.liquidity?.toFixed(2) || "0",
+            volume24hUsd: token.volume24hUSD.toFixed(0) || "0",
+            change24hPct: token.price24hChangePercent.toFixed(2) || "0",
+            liquidityUsd: token.liquidity.toFixed(2) || "0",
           });
         }
       }
@@ -348,7 +345,7 @@ export const trendingProvider: Provider = {
         text,
       };
     } catch (error) {
-      runtime.logger?.error(
+      runtime.logger.error(
         `Error fetching trending data: ${error instanceof Error ? error.message : String(error)}`,
       );
       return {

package/src/analytics/birdeye/providers/wallet.ts

@@ -1,4 +1,3 @@
-// @ts-nocheck — legacy code from absorbed plugins (lp-manager, lpinfo, dexscreener, defi-news, birdeye); strict types pending cleanup
 import { createBirdeyePortfolioProvider } from "./portfolio-factory";
 
 /**

package/src/analytics/birdeye/search-category.test.ts

@@ -42,7 +42,7 @@ function createRuntime() {
 }
 
 describe("Birdeye search categories", () => {
-  it("registers one unified token intel search category", () => {
+  it("registers one token intel search category", () => {
     const { categories, registerSearchCategory, runtime } = createRuntime();
 
     registerBirdeyeSearchCategories(runtime);

package/src/analytics/birdeye/search-category.ts

@@ -1,7 +1,7 @@
-// @ts-nocheck — legacy code from absorbed plugins (lp-manager, lpinfo, dexscreener, defi-news, birdeye); strict types pending cleanup
 import type { IAgentRuntime, SearchCategoryRegistration } from "@elizaos/core";
 import { BirdeyeProvider } from "./birdeye";
 import { BIRDEYE_SERVICE_NAME } from "./constants";
+import type { TokenMarketSearchParams, TokenResult } from "./types/api/search";
 import type {
   TokenMarketDataResponse,
   TokenOverviewResponse,
@@ -186,7 +186,7 @@ type BirdeyeTokenAddressSearchResult = {
 
 type BirdeyeTokenSymbolSearchResult = {
   symbol: string;
-  tokens: unknown[];
+  tokens: TokenResult[];
 };
 
 type BirdeyeTokenSearchProvider = Pick<
@@ -215,7 +215,7 @@ export function registerBirdeyeSearchCategories(
   options: BirdeyeSearchCategoryOptions = {},
 ): void {
   if (typeof runtime.registerSearchCategory !== "function") {
-    runtime.logger?.warn?.(
+    runtime.logger.warn(
       "Birdeye search category registry is unavailable; token search metadata was not registered",
     );
     return;
@@ -247,6 +247,71 @@ function normalizeLimit(value: unknown): number {
   return Math.max(1, Math.min(25, limit));
 }
 
+function asTokenSearchChain(value: unknown): TokenMarketSearchParams["chain"] {
+  switch (value) {
+    case "all":
+    case "solana":
+    case "ethereum":
+    case "arbitrum":
+    case "avalanche":
+    case "bsc":
+    case "optimism":
+    case "polygon":
+    case "base":
+    case "zksync":
+    case "sui":
+    case "evm":
+      return value;
+    default:
+      return "all";
+  }
+}
+
+function asTokenSearchTarget(
+  value: unknown,
+): TokenMarketSearchParams["target"] {
+  return value === "market" || value === "all" ? value : "token";
+}
+
+function asTokenSearchSortBy(
+  value: unknown,
+): TokenMarketSearchParams["sort_by"] {
+  switch (value) {
+    case "fdv":
+    case "marketcap":
+    case "liquidity":
+    case "price":
+    case "price_change_24h_percent":
+    case "trade_24h":
+    case "trade_24h_change_percent":
+    case "buy_24h":
+    case "buy_24h_change_percent":
+    case "sell_24h":
+    case "sell_24h_change_percent":
+    case "unique_wallet_24h":
+    case "unique_view_24h_change_percent":
+    case "last_trade_unix_time":
+    case "volume_24h_usd":
+    case "volume_24h_change_percent":
+      return value;
+    default:
+      return "volume_24h_usd";
+  }
+}
+
+function asSortType(value: unknown): TokenMarketSearchParams["sort_type"] {
+  return value === "asc" ? "asc" : "desc";
+}
+
+function isTokenResult(token: unknown): token is TokenResult {
+  return (
+    typeof token === "object" &&
+    token !== null &&
+    "symbol" in token &&
+    "address" in token
+  );
+}
+
 function filterBool(
   filters: Record<string, unknown>,
   key: string,
@@ -296,12 +361,10 @@ async function searchTokensBySymbol(
   limit: number,
 ): Promise<BirdeyeTokenSymbolSearchResult[]> {
   const symbols = normalizeSymbolQuery(query);
-  const chain = typeof filters.chain === "string" ? filters.chain : "all";
-  const target = typeof filters.target === "string" ? filters.target : "token";
-  const sortBy =
-    typeof filters.sort_by === "string" ? filters.sort_by : "volume_24h_usd";
-  const sortType =
-    typeof filters.sort_type === "string" ? filters.sort_type : "desc";
+  const chain = asTokenSearchChain(filters.chain);
+  const target = asTokenSearchTarget(filters.target);
+  const sortBy = asTokenSearchSortBy(filters.sort_by);
+  const sortType = asSortType(filters.sort_type);
 
   const results = await Promise.all(
     symbols.map(async (symbol) => {
@@ -319,11 +382,13 @@ async function searchTokensBySymbol(
         markets:
           typeof filters.markets === "string" ? filters.markets : undefined,
       });
-      const tokens = (response?.data?.items ?? [])
+      const tokens = response.data.items
         .filter((item) => item.type === "token" && item.result)
         .flatMap((item) => item.result)
         .filter(
-          (token) => token?.symbol?.toLowerCase?.() === symbol.toLowerCase(),
+          (token): token is TokenResult =>
+            isTokenResult(token) &&
+            token.symbol?.toLowerCase?.() === symbol.toLowerCase(),
         )
         .slice(0, limit);
       return { symbol, tokens };
@@ -464,7 +529,7 @@ export async function searchBirdeyeTokens(
   request: BirdeyeTokenSearchRequest,
   provider: BirdeyeTokenSearchProvider = new BirdeyeProvider(runtime),
 ) {
-  const query = String(request.query ?? "").trim();
+  const query = String(request.query).trim();
   const filters = request.filters ?? {};
   const requestedMode = normalizeMode(request.mode ?? filters.mode);
   const mode = inferMode(query, requestedMode);