@elizaos/plugin-wallet 2.0.0-beta.1 → 2.0.3-beta.5

package/src/analytics/birdeye/types/api/common.ts

@@ -1,4 +1,3 @@
-// @ts-nocheck — legacy code from absorbed plugins (lp-manager, lpinfo, dexscreener, defi-news, birdeye); strict types pending cleanup
 import type {
   BaseQuoteParams,
   DefiHistoryPriceParams,

package/src/analytics/birdeye/types/api/defi.ts

@@ -1,4 +1,3 @@
-// @ts-nocheck — legacy code from absorbed plugins (lp-manager, lpinfo, dexscreener, defi-news, birdeye); strict types pending cleanup
 import type { TimeInterval } from "./common";
 
 // Network Types

package/src/analytics/birdeye/types/api/pair.ts

@@ -1,4 +1,3 @@
-// @ts-nocheck — legacy code from absorbed plugins (lp-manager, lpinfo, dexscreener, defi-news, birdeye); strict types pending cleanup
 import type { TimeInterval } from "./common";
 
 // Pair Trades Types

package/src/analytics/birdeye/types/api/search.ts

@@ -1,4 +1,3 @@
-// @ts-nocheck — legacy code from absorbed plugins (lp-manager, lpinfo, dexscreener, defi-news, birdeye); strict types pending cleanup
 import type { BirdeyeSupportedChain } from "../shared";
 
 // Search Types

package/src/analytics/birdeye/types/api/token.ts

@@ -1,4 +1,3 @@
-// @ts-nocheck — legacy code from absorbed plugins (lp-manager, lpinfo, dexscreener, defi-news, birdeye); strict types pending cleanup
 import type { TimeInterval, TokenTradeData } from "./common";
 
 // Token Trades Types

package/src/analytics/birdeye/types/api/trader.ts

@@ -1,4 +1,3 @@
-// @ts-nocheck — legacy code from absorbed plugins (lp-manager, lpinfo, dexscreener, defi-news, birdeye); strict types pending cleanup
 // Trader Gainers Losers Types
 export interface GainersLosersParams {
   type: "yesterday" | "today" | "1W";

package/src/analytics/birdeye/types/api/wallet.ts

@@ -1,4 +1,3 @@
-// @ts-nocheck — legacy code from absorbed plugins (lp-manager, lpinfo, dexscreener, defi-news, birdeye); strict types pending cleanup
 // Wallet Portfolio Types
 export interface WalletPortfolioParams {
   wallet: string;

package/src/analytics/birdeye/types/shared.ts

@@ -1,4 +1,3 @@
-// @ts-nocheck — legacy code from absorbed plugins (lp-manager, lpinfo, dexscreener, defi-news, birdeye); strict types pending cleanup
 import type { BIRDEYE_SUPPORTED_CHAINS } from "../utils";
 
 // Types
@@ -23,16 +22,6 @@ export interface ContractAddress extends BaseAddress {
   type: "contract";
 }
 
-/**
- * Represents a type that can be one of four values: "solana", "base", "ethereum", or "L1".
- */
-//export type TChain = 'solana' | 'base' | 'ethereum' | 'L1';
-/**
- * Type representing different data providers.
- * Possible values are "birdeye" and "coinmarketcap".
- */
-//export type TDataProvider = 'birdeye' | 'coinmarketcap';
-
 // Shape of what's stored in the cache
 export interface CacheWrapper<T> {
   data: T;

package/src/analytics/birdeye/utils.test.ts

@@ -0,0 +1,69 @@
+import { describe, expect, it } from "vitest";
+import {
+  extractLimit,
+  formatPercentChange,
+  formatPrice,
+  formatValue,
+  shortenAddress,
+} from "./utils.js";
+
+/**
+ * Birdeye analytics formatting + intent extraction. These render financial
+ * figures shown to the user and parse the result limit from free text, so the
+ * suffix thresholds, sign handling, and clamping are pinned.
+ */
+
+describe("formatValue", () => {
+  it("scales to K/M/B with a $ prefix, N/A for falsy", () => {
+    expect(formatValue(undefined)).toBe("N/A");
+    expect(formatValue(0)).toBe("N/A");
+    expect(formatValue(500)).toBe("$500.00");
+    expect(formatValue(1_500)).toBe("$1.50K");
+    expect(formatValue(2_500_000)).toBe("$2.50M");
+    expect(formatValue(3_000_000_000)).toBe("$3.00B");
+  });
+});
+
+describe("formatPercentChange", () => {
+  it("uses ↑/↓ and absolute magnitude", () => {
+    expect(formatPercentChange(undefined)).toBe("N/A");
+    expect(formatPercentChange(5)).toBe("↑ 5.00%");
+    expect(formatPercentChange(-3.2)).toBe("↓ 3.20%");
+    expect(formatPercentChange(0)).toBe("↑ 0.00%");
+  });
+});
+
+describe("shortenAddress", () => {
+  it("keeps short strings, abbreviates long ones", () => {
+    expect(shortenAddress(undefined)).toBe("Unknown");
+    expect(shortenAddress("0x1234")).toBe("0x1234");
+    expect(shortenAddress("0x1234567890abcdef")).toBe("0x1234...cdef");
+  });
+});
+
+describe("formatPrice", () => {
+  it("uses exponential below 0.01, two decimals otherwise", () => {
+    expect(formatPrice(undefined)).toBe("N/A");
+    expect(formatPrice(0)).toBe("N/A");
+    expect(formatPrice(0.005)).toBe("5.00e-3");
+    expect(formatPrice(12.5)).toBe("12.50");
+  });
+});
+
+describe("extractLimit", () => {
+  it("reads explicit limits and clamps to 1..100", () => {
+    expect(extractLimit("show 25 tokens")).toBe(25);
+    expect(extractLimit("show 500")).toBe(100);
+    expect(extractLimit("show 0")).toBe(1);
+  });
+
+  it("falls back to semantic and contextual hints", () => {
+    expect(extractLimit("give me everything")).toBe(100);
+    expect(extractLimit("quick summary")).toBe(5);
+    expect(extractLimit("detailed report")).toBe(50);
+    expect(extractLimit("recent trades")).toBe(10);
+    expect(extractLimit("analyze the trend")).toBe(24);
+    expect(extractLimit("historical data")).toBe(50);
+    expect(extractLimit("hello")).toBe(10);
+  });
+});

package/src/analytics/birdeye/utils.ts

@@ -1,5 +1,5 @@
-// @ts-nocheck — legacy code from absorbed plugins (lp-manager, lpinfo, dexscreener, defi-news, birdeye); strict types pending cleanup
 import { logger } from "@elizaos/core";
+import { sanitizeWalletDisplayLabel } from "../../security/wallet-context-safety.js";
 import type { BirdeyeApiParams } from "./types/api/common";
 import type {
   TokenMarketSearchResponse,
@@ -176,7 +176,7 @@ export const extractChain = (
 };
 
 export const extractAddresses = (text: string): BaseAddress[] => {
-  if (!text?.match) return [];
+  if (!text.match) return [];
   const addresses: BaseAddress[] = [];
 
   // Sui addresses (0x followed by 64 hex chars). Extract first so the EVM
@@ -214,7 +214,7 @@ export const extractAddresses = (text: string): BaseAddress[] => {
   // Solana addresses (base58 strings)
   const solAddresses = Array.from(text.matchAll(/[1-9A-HJ-NP-Za-km-z]{32,44}/g))
     .filter((match) => {
-      const start = match.index ?? 0;
+      const start = match.index;
       const end = start + match[0].length;
       return (
         !/[A-Za-z0-9]/.test(text[start - 1] ?? "") &&
@@ -443,9 +443,9 @@ export async function makeApiRequest<T>(
       headers: {
         "X-API-KEY": apiKey,
         "x-chain": chain,
-        ...(body && { "Content-Type": "application/json" }),
+        ...(body !== undefined ? { "Content-Type": "application/json" } : {}),
       },
-      ...(body && { body: JSON.stringify(body) }),
+      ...(body !== undefined ? { body: JSON.stringify(body) } : {}),
     });
 
     if (!response.ok) {
@@ -510,8 +510,11 @@ export const formatTokenInfo = (
     ? `${Math.floor((Date.now() - new Date(token.creation_time).getTime()) / (1000 * 60 * 60 * 24))}d`
     : "N/A";
 
+  const safeName = sanitizeWalletDisplayLabel(token.name || "unknown");
+  const safeSymbol = sanitizeWalletDisplayLabel(token.symbol || "unknown");
+
   let output =
-    `🪙 ${token.name} @ ${token.symbol}\n` +
+    `🪙 ${safeName} @ ${safeSymbol}\n` +
     `💰 USD: $${priceFormatted} (${priceChange})\n` +
     `💎 FDV: ${fdv}\n` +
     `💦 MCap: ${token.market_cap ? `$${(token.market_cap / 1_000_000).toFixed(2)}M` : "N/A"}\n` +
@@ -552,7 +555,7 @@ export const extractSymbols = (
   // strict mode will only extract symbols that are clearly formatted as a symbol using $SOL format
   mode: "strict" | "loose" = "loose",
 ): string[] => {
-  if (!text?.matchAll) return [];
+  if (!text.matchAll) return [];
   const symbols = new Set<string>();
 
   // Match patterns
@@ -681,7 +684,7 @@ export const waitFor = (ms: number) =>
   new Promise((resolve) => setTimeout(resolve, ms));
 
 export const convertToStringParams = (
-  params: BirdeyeApiParams,
+  params: BirdeyeApiParams | Record<string, unknown>,
 ): Record<string, string> => {
   const result: Record<string, string> = {};
   for (const [key, value] of Object.entries(params || {})) {

package/src/analytics/dexscreener/search-category.ts

@@ -1,4 +1,3 @@
-// @ts-nocheck — legacy code from absorbed plugins (lp-manager, lpinfo, dexscreener, defi-news, birdeye); strict types pending cleanup
 import type { IAgentRuntime, SearchCategoryRegistration } from "@elizaos/core";
 
 export const DEXSCREENER_SEARCH_CATEGORY: SearchCategoryRegistration = {

package/src/analytics/dexscreener/service.ts

@@ -1,5 +1,3 @@
-// @ts-nocheck — legacy code from absorbed plugins (lp-manager, lpinfo, dexscreener, defi-news, birdeye); strict types pending cleanup
-
 import {
   cloudServiceApisBaseUrl,
   toRuntimeSettings,
@@ -84,10 +82,7 @@ export class DexScreenerService extends Service {
     return service;
   }
 
-  async stop(): Promise<void> {
-    // Cleanup if needed
-    console.log("DexScreener service stopped");
-  }
+  async stop(): Promise<void> {}
 
   private async get<T>(
     path: string,
@@ -273,15 +268,15 @@ export class DexScreenerService extends Service {
         pairs.sort((a, b) => {
           switch (params.sortBy) {
             case "volume":
-              return (b.volume?.h24 || 0) - (a.volume?.h24 || 0);
+              return (b.volume.h24 || 0) - (a.volume.h24 || 0);
             case "liquidity":
               return (b.liquidity?.usd || 0) - (a.liquidity?.usd || 0);
             case "priceChange":
-              return (b.priceChange?.h24 || 0) - (a.priceChange?.h24 || 0);
+              return (b.priceChange.h24 || 0) - (a.priceChange.h24 || 0);
             case "txns":
               return (
-                (b.txns?.h24.buys + b.txns?.h24.sells || 0) -
-                (a.txns?.h24.buys + a.txns?.h24.sells || 0)
+                (b.txns.h24.buys + b.txns.h24.sells || 0) -
+                (a.txns.h24.buys + a.txns.h24.sells || 0)
               );
             default:
               return 0;
@@ -328,7 +323,7 @@ export class DexScreenerService extends Service {
       // Filter by chain if specified
       const filteredProfiles = params.chain
         ? profiles.filter(
-            (p) => p.chainId?.toLowerCase() === params.chain?.toLowerCase(),
+            (p) => p.chainId.toLowerCase() === params.chain?.toLowerCase(),
           )
         : profiles;
 
@@ -392,7 +387,7 @@ export class DexScreenerService extends Service {
         : [responseData];
 
       const profile = profiles.find(
-        (p) => p.tokenAddress?.toLowerCase() === tokenAddress.toLowerCase(),
+        (p) => p.tokenAddress.toLowerCase() === tokenAddress.toLowerCase(),
       );
 
       if (!profile) {

package/src/analytics/dexscreener/types.ts

@@ -1,4 +1,3 @@
-// @ts-nocheck — legacy code from absorbed plugins (lp-manager, lpinfo, dexscreener, defi-news, birdeye); strict types pending cleanup
 // DexScreener API Types
 
 export interface DexScreenerTokenInfo {

package/src/analytics/lpinfo/index.ts

@@ -1,5 +1,4 @@
-// @ts-nocheck — legacy code from absorbed plugins (lp-manager, lpinfo, dexscreener, defi-news, birdeye); strict types pending cleanup
-import type { Plugin } from "@elizaos/core";
+import type { IAgentRuntime, Plugin } from "@elizaos/core";
 // Kamino Protocol Plugin
 import { kaminoPlugin } from "./kamino";
 // Steer Finance Plugin
@@ -34,6 +33,10 @@ export const lpinfoPlugin: Plugin = {
   ],
   actions: [...(steerPlugin.actions || []), ...(kaminoPlugin.actions || [])],
   services: [...(steerPlugin.services || []), ...(kaminoPlugin.services || [])],
+  async dispose(runtime: IAgentRuntime) {
+    await steerPlugin.dispose?.(runtime);
+    await kaminoPlugin.dispose?.(runtime);
+  },
 };
 
 export default lpinfoPlugin;

package/src/analytics/lpinfo/kamino/README.md

@@ -91,9 +91,9 @@ The plugin includes comprehensive error handling for:
 - API rate limits
 - Market data unavailability
 
-## Future Enhancements
+## Enhancement Backlog
 
-Potential future features:
+Potential feature additions:
 
 - Position management actions (deposit, withdraw, borrow, repay)
 - Yield optimization recommendations

package/src/analytics/lpinfo/kamino/index.ts

@@ -1,5 +1,4 @@
-// @ts-nocheck — legacy code from absorbed plugins (lp-manager, lpinfo, dexscreener, defi-news, birdeye); strict types pending cleanup
-import type { Plugin } from "@elizaos/core";
+import type { IAgentRuntime, Plugin } from "@elizaos/core";
 import { kaminoLiquidityProvider } from "./providers/kaminoLiquidityProvider";
 import { kaminoPoolProvider } from "./providers/kaminoPoolProvider";
 // Providers
@@ -19,6 +18,14 @@ export const kaminoPlugin: Plugin = {
   providers: [kaminoProvider, kaminoLiquidityProvider, kaminoPoolProvider],
   actions: [],
   services: [KaminoService, KaminoLiquidityService],
+  async dispose(runtime: IAgentRuntime) {
+    const kamino = runtime.getService<KaminoService>(KaminoService.serviceType);
+    await kamino?.stop();
+    const liquidity = runtime.getService<KaminoLiquidityService>(
+      KaminoLiquidityService.serviceType,
+    );
+    await liquidity?.stop();
+  },
 };
 
 export default kaminoPlugin;

package/src/analytics/lpinfo/kamino/providers/kaminoLiquidityProvider.ts

@@ -1,28 +1,12 @@
-// @ts-nocheck — legacy code from absorbed plugins (lp-manager, lpinfo, dexscreener, defi-news, birdeye); strict types pending cleanup
 import type { IAgentRuntime, Memory, Provider, State } from "@elizaos/core";
 import { ModelType } from "@elizaos/core";
-import type { KaminoLiquidityService } from "../services/kaminoLiquidityService";
+import type {
+  KaminoLiquidityService,
+  KaminoStrategy,
+} from "../services/kaminoLiquidityService";
 
 const KAMINO_LIQUIDITY_TEXT_LIMIT = 4000;
 
-// Import the KaminoStrategy type from the service
-interface KaminoStrategy {
-  address: string;
-  dataSize: number;
-  lamports: number;
-  owner: string;
-  strategyType: string;
-  estimatedTvl: number;
-  volume24h: number;
-  apy: number;
-  tokenA: string;
-  tokenB: string;
-  feeTier: string;
-  rebalancing: string;
-  lastRebalance: string;
-  positions: unknown[];
-}
-
 function asPromptRecord(value: unknown): Record<string, unknown> {
   return value && typeof value === "object"
     ? (value as Record<string, unknown>)
@@ -119,8 +103,6 @@ export const kaminoLiquidityProvider: Provider = {
   cacheScope: "turn",
   roleGate: { minRole: "USER" },
   get: async (runtime: IAgentRuntime, message: Memory, _state: State) => {
-    console.log("KAMINO_LIQUIDITY provider called");
-
     let liquidityInfo = "";
 
     try {
@@ -141,8 +123,6 @@ export const kaminoLiquidityProvider: Provider = {
         liquidityInfo += "❌ Kamino liquidity service not available.\n";
       } else {
         if (tokenIdentifier) {
-          console.log(`Token identifier found: ${tokenIdentifier}`);
-
           liquidityInfo += `=== KAMINO LIQUIDITY POOL STATS ===\n\n`;
           liquidityInfo += `Token: ${tokenIdentifier}\n\n`;
 
@@ -217,7 +197,7 @@ export const kaminoLiquidityProvider: Provider = {
 
     return {
       data,
-      values: {} as Record<string, unknown>,
+      values: {},
       text,
     };
   },
@@ -375,7 +355,7 @@ async function generateEnhancedKaminoLiquidityReport(
     const marketStats = await data.kaminoLiquidityService.getMarketStatistics();
 
     // Create a focused prompt for the LLM
-    const liquidityPrompt = `You are a professional DeFi analyst specializing in Kamino Finance liquidity protocols. Generate a comprehensive, well-crafted analysis report for the token ${data.tokenIdentifier}.
+    const liquidityPrompt = `Generate a comprehensive liquidity analysis report for token ${data.tokenIdentifier} on Kamino Finance.
 
 TOKEN INFORMATION:
 ${formatTokenInfoForPrompt(data.tokenInfo)}

package/src/analytics/lpinfo/kamino/providers/kaminoPoolProvider.ts

@@ -1,9 +1,12 @@
-// @ts-nocheck — legacy code from absorbed plugins (lp-manager, lpinfo, dexscreener, defi-news, birdeye); strict types pending cleanup
 import type { IAgentRuntime, Memory, Provider, State } from "@elizaos/core";
 import { ModelType } from "@elizaos/core";
-import type { KaminoLiquidityService } from "../services/kaminoLiquidityService";
+import type {
+  KaminoLiquidityService,
+  KaminoPoolByAddressResult,
+} from "../services/kaminoLiquidityService";
 
 const KAMINO_POOL_TEXT_LIMIT = 4000;
+type KaminoPoolReportData = NonNullable<KaminoPoolByAddressResult>;
 
 /**
  * Kamino Pool-Specific Provider
@@ -22,8 +25,6 @@ export const kaminoPoolProvider: Provider = {
   cacheScope: "turn",
   roleGate: { minRole: "USER" },
   get: async (runtime: IAgentRuntime, message: Memory, _state: State) => {
-    console.log("KAMINO_POOL provider called");
-
     let poolInfo = "";
 
     try {
@@ -44,8 +45,6 @@ export const kaminoPoolProvider: Provider = {
         poolInfo += "❌ Kamino liquidity service not available.\n";
       } else {
         if (poolAddress) {
-          console.log(`Pool address found: ${poolAddress}`);
-
           poolInfo += `=== KAMINO POOL ANALYSIS ===\n\n`;
           poolInfo += `🔍 Pool Address: ${poolAddress}\n\n`;
 
@@ -107,7 +106,7 @@ export const kaminoPoolProvider: Provider = {
 
     return {
       data,
-      values: {} as Record<string, unknown>,
+      values: {},
       text,
     };
   },
@@ -221,7 +220,7 @@ function formatPromptValue(value: unknown): string {
  */
 async function generatePoolReport(
   runtime: IAgentRuntime,
-  poolData: unknown,
+  poolData: KaminoPoolReportData,
   _kaminoLiquidityService: KaminoLiquidityService,
 ): Promise<string> {
   let report = "";
@@ -232,7 +231,7 @@ async function generatePoolReport(
     report += `   📍 Address: ${poolData.address}\n`;
     report += `   📅 Last Updated: ${new Date(poolData.timestamp).toLocaleString()}\n\n`;
 
-    if (poolData.strategy) {
+    if ("strategy" in poolData) {
       const strategy = poolData.strategy;
 
       report += `📊 STRATEGY DETAILS:\n`;
@@ -284,7 +283,7 @@ async function generatePoolReport(
     }
 
     // Metrics summary
-    if (poolData.metrics) {
+    if ("metrics" in poolData) {
       const metrics = poolData.metrics;
       report += `📈 PERFORMANCE METRICS:\n`;
       report += `   💰 Total Value Locked: $${metrics.totalValueLocked.toLocaleString()}\n`;
@@ -323,11 +322,11 @@ async function generatePoolReport(
  */
 async function generateEnhancedPoolAnalysis(
   runtime: IAgentRuntime,
-  poolData: unknown,
+  poolData: KaminoPoolReportData,
 ): Promise<string> {
   try {
     // Create a focused prompt for the LLM
-    const analysisPrompt = `You are a professional DeFi analyst specializing in Kamino Finance liquidity pools. Generate a concise, insightful analysis for the pool with address ${poolData.address}.
+    const analysisPrompt = `Generate a concise pool analysis for Kamino Finance pool at address ${poolData.address}.
 
 POOL DATA:
 ${formatPoolDataForPrompt(poolData)}