@eliware/vyops 2.1.0 → 2.1.1

package/RELEASE_NOTES.md

@@ -1,5 +1,13 @@
 # Release Notes
 
+## 2.1.1
+
+- Fix deployment of `.exe` files in the synchronized `scripts/` tree by
+  applying executable permissions (`0755`).
+- Treat `.exe` files as binaries during preflight instead of applying
+  shell-script shebang and line-ending checks.
+- Add regression coverage for executable `.exe` deployment.
+
 ## 2.1.0
 
 - **Breaking:** Replace the legacy positional deployment and `--dry-run`

package/package.json

@@ -1,6 +1,6 @@
 {
     "name": "@eliware/vyops",
-    "version": "2.1.0",
+    "version": "2.1.1",
     "description": "Preflight, release, and back up native VyOS configuration bundles over SSH.",
     "main": "vyops.mjs",
     "scripts": {

package/src/bundle.mjs

@@ -29,9 +29,11 @@ export async function validateBundle(config, text, { extractTarget = true } = {}
   for (const { file, name } of scripts) {
     const data = await fs.readFile(file);
     const firstLine = data.toString('utf8').split(/\n/, 1)[0].replace(/\r$/, '');
-    const executable = firstLine.startsWith('#!') || /(?:\.sh|\.script)$/.test(name)
+    const binary = /\.exe$/i.test(name);
+    const executable = binary || firstLine.startsWith('#!') || /(?:\.sh|\.script)$/.test(name)
       || /^(?:commit\/post-hooks\.d\/|vyos-(?:pre|post)config-bootup\.script$)/.test(name);
     if (!executable) continue;
+    if (binary) continue;
     if (data.includes(13)) scriptError(name, 'uses CRLF line endings; convert to LF');
     if (!firstLine.startsWith('#!')) scriptError(name, 'is executable but has no shebang');
     const interpreter = firstLine.slice(2).trim().split(/\s+/, 1)[0];

package/src/deploy.mjs

@@ -59,7 +59,7 @@ async function installScripts(client, config, log, runId) {
         /* istanbul ignore next -- missing files are only possible with a mocked directory listing. */
         if (error.code !== 'ENOENT') throw error;
       }
-      const mode = content.toString('utf8').startsWith('#!') || /\.(?:sh|script)$/.test(name)
+      const mode = content.toString('utf8').startsWith('#!') || /\.(?:sh|script|exe)$/i.test(name)
         || /^(?:commit[/\\]post-hooks\.d[/\\])/.test(name)
         ? 0o755
         : (await fs.promises.stat(local)).mode & 0o777;