@eliware/vyops 1.0.7 → 1.0.9

package/RELEASE_NOTES.md

@@ -1,5 +1,32 @@
 # Release Notes
 
+## 1.0.9
+
+- Fix `--password-stdin` to read piped passwords correctly on current Node.js
+  runtimes.
+- Restore password-authenticated backup workflows for VyOS hosts.
+
+Verification:
+
+- `npm test` (100% coverage across statements, branches, functions, and lines)
+- `npm run lint`
+- `npm run audit`
+
+## 1.0.8
+
+- Fail immediately with a redacted VyOS error when confirmed commits reject a
+  configuration after the confirmation prompt.
+- Prevent malformed PKI and other validation failures from appearing to hang
+  at the commit-confirm step.
+- Add regression coverage for post-prompt validation errors and structured
+  failures without detail text.
+
+Verification:
+
+- `npm test` (100% coverage across statements, branches, functions, and lines)
+- `npm run lint`
+- `npm run audit`
+
 ## 1.0.7
 
 - Add password-based SSH bootstrap through the secure `--password-stdin` mode.

package/package.json

@@ -1,6 +1,6 @@
 {
     "name": "@eliware/vyops",
-    "version": "1.0.7",
+    "version": "1.0.9",
     "description": "Deploy native VyOS configuration files over SSH.",
     "main": "vyops.mjs",
     "scripts": {
@@ -48,4 +48,4 @@
         "LICENSE",
         "RELEASE_NOTES.md"
     ]
-}
+}

package/src/main.mjs

@@ -6,7 +6,12 @@ import { readAndValidateConfig } from './validate.mjs';
 import { pushBack, shouldSkip } from './git.mjs';
 import { closeAll } from './ssh.mjs';
 import { log, registerHandlers, registerSignals } from '@eliware/common';
-import { readFile } from 'node:fs/promises';
+
+async function readPasswordStdin() {
+  const chunks = [];
+  for await (const chunk of process.stdin) chunks.push(chunk);
+  return Buffer.concat(chunks).toString('utf8').replace(/\r?\n$/, '');
+}
 
 const errors = registerHandlers({ log });
 const signals = registerSignals({ log, shutdownHook: async () => closeAll() });
@@ -23,7 +28,7 @@ try {
     process.exit(0);
   }
   if (args.passwordStdin) {
-    args.password = (await readFile(0, 'utf8')).replace(/\r?\n$/, '');
+    args.password = await readPasswordStdin();
     if (!args.password) throw new Error('password-stdin received an empty password');
   }
   if (args.backup) {

package/src/ssh.mjs

@@ -167,6 +167,12 @@ export function interactive(client, commands, log = () => {}) {
       const ansi = new RegExp(`${String.fromCharCode(27)}\\[[0-9;?]*[ -/]*[@-~]`, 'g');
       const title = new RegExp(`${String.fromCharCode(27)}\\][^${String.fromCharCode(7)}]*(?:${String.fromCharCode(7)}|${String.fromCharCode(27)}\\\\)`, 'g');
       const clean = value => value.replace(ansi, '').replace(title, '').replace(/\r/g, '');
+      const failureDetail = value => value.split('\n')
+        .map(line => line.trim())
+        .find(line => /(?:failed|failure|invalid|error|aborted|pending)/i.test(line))
+        ?.replace(/(certificate|private key|key)\s+"[^"]+"/ig, '$1 "[redacted]"')
+        .replace(/\s+/g, ' ')
+        .slice(0, 240);
       const prompt = value => /(?:^|\n)[A-Za-z0-9._-]+@[A-Za-z0-9._:-]+(?::~\$|#)\s*$/.test(value);
       const sendNext = () => {
         if (waiting || index >= commands.length) return;
@@ -190,7 +196,8 @@ export function interactive(client, commands, log = () => {}) {
           settled = true;
           clearTimeout(timer);
           stream.close();
-          reject(new Error(`interactive command failed: ${currentItem.command}`));
+          const detail = failureDetail(cleaned);
+          reject(new Error(`interactive command failed: ${currentItem.command}${detail ? ` (${detail})` : ''}`));
           return;
         }
         const pagerReturn = /No next tag\s*\(press RETURN\)/i.test(cleaned);