@eliware/vyops 1.0.4 → 1.0.6

package/README.md

@@ -55,8 +55,13 @@ Console switches:
 ./vyops.mjs --version
 ./vyops.mjs --dry-run vyos@core1 /path/to/config.boot
 ./vyops.mjs --force --debug vyos@core1 /path/to/config.boot
+./vyops.mjs --backup vyos@core1 /path/to/backup
 ```
 
+`--backup` downloads the active `/config/config.boot` and the complete
+`/config/scripts` tree into the destination directory. It does not enter
+configuration mode or modify the router.
+
 `--dry-run` validates the config and skips SSH, commit, save, download, and Git pushback.
 
 The deployment workflow:
@@ -105,7 +110,7 @@ Deployments require existing SSH keys and a reachable VyOS target. The workflow
 
 ## Support
 
-Repository: `git@github.com:eliware/vyops-js.git`
+Repository: `git@github.com:eliware/vyops.git`
 
 Open an issue or provide a focused patch with tests and validation results.
 

package/RELEASE_NOTES.md

@@ -1,5 +1,34 @@
 # Release Notes
 
+## 1.0.6
+
+- Add `--backup` to download the active `config.boot` and complete
+  `/config/scripts` tree into a local backup directory.
+- Fail promptly on VyOS load and commit errors instead of waiting indefinitely
+  for confirmation prompts.
+- Preserve synchronized scripts when post-commit local config download fails.
+- Include staged configuration changes in Git pushback detection.
+- Expand CLI, deployment, backup, Git, and SSH regression coverage.
+
+Verification:
+
+- `npm test` (100% coverage across statements, branches, functions, and lines)
+- `npm run lint`
+- `npm run audit`
+- `npm run validate:package`
+
+## 1.0.5
+
+- Create nested temporary directories before uploading synchronized scripts.
+- Fix deployment of nested files such as systemd units and boot scripts.
+
+Verification:
+
+- `npm test`
+- `npm run lint`
+- `npm run audit`
+- `npm run validate:package`
+
 ## 1.0.4
 
 - Synchronize the complete repository `scripts/` tree to `/config/scripts`.

package/package.json

@@ -1,6 +1,6 @@
 {
     "name": "@eliware/vyops",
-    "version": "1.0.4",
+    "version": "1.0.6",
     "description": "Deploy native VyOS configuration files over SSH.",
     "main": "vyops.mjs",
     "scripts": {
@@ -21,12 +21,12 @@
     ],
     "type": "module",
     "dependencies": {
-        "@eliware/common": "^1.1.7",
+        "@eliware/common": "^1.1.8",
         "ssh2": "^1.17.0"
     },
     "devDependencies": {
         "jest": "^30.4.2",
-        "oxlint": "^1.77.0"
+        "oxlint": "^1.79.0"
     },
     "bin": {
         "vyops": "./bin/vyops"

package/src/args.mjs

@@ -1,5 +1,6 @@
 export const usage = `Usage:
   vyops [--dry-run] [--force] [--debug] <user@hostname-or-ip> <config.boot>
+  vyops --backup [--debug] <user@hostname-or-ip> <destination-directory>
   vyops --help
   vyops --version`;
 
@@ -8,8 +9,8 @@ export function parseArgs(argv) {
   if (argv.length === 1 && argv[0] === '--version') return { version: true };
 
   const options = new Set(argv.filter(value => value.startsWith('--')));
-  if ([...options].some(option => !['--dry-run', '--force', '--debug'].includes(option))) throw new Error(usage);
+  if ([...options].some(option => !['--dry-run', '--force', '--debug', '--backup'].includes(option))) throw new Error(usage);
   const values = argv.filter(value => !value.startsWith('--'));
   if (values.length !== 2) throw new Error(usage);
-  return { target: values[0], config: values[1], ...(options.has('--dry-run') ? { dryRun: true } : {}), ...(options.has('--force') ? { force: true } : {}), ...(options.has('--debug') ? { debug: true } : {}) };
+  return { target: values[0], config: values[1], ...(options.has('--backup') ? { backup: true } : {}), ...(options.has('--dry-run') ? { dryRun: true } : {}), ...(options.has('--force') ? { force: true } : {}), ...(options.has('--debug') ? { debug: true } : {}) };
 }

package/src/backup.mjs

@@ -0,0 +1,29 @@
+import { fs, path, log } from '@eliware/common';
+import { close, connect, download, exec } from './ssh.mjs';
+
+function remoteScriptPath(value) {
+  const name = value.replace(/^\/config\/scripts\/?/, '');
+  if (!name || name.startsWith('/') || name.split('/').includes('..')) throw new Error(`unsafe remote script path: ${value}`);
+  return name;
+}
+
+export async function backup({ target, config }) {
+  const client = await connect(target);
+  try {
+    await fs.promises.mkdir(config, { recursive: true });
+    await fs.promises.mkdir(path(config, 'scripts'), { recursive: true });
+    await download(client, '/config/config.boot', path(config, 'config.boot'));
+    const result = await exec(client, "find /config/scripts -type f -print 2>/dev/null");
+    if (result.code !== 0) throw new Error(`could not list remote scripts: ${result.stderr || result.stdout}`.trim());
+    const files = result.stdout.split(/\r?\n/).map(value => value.trim()).filter(Boolean).map(remoteScriptPath);
+    for (const name of files) {
+      const local = path(config, 'scripts', name);
+      await fs.promises.mkdir(path(local, '..'), { recursive: true });
+      await download(client, `/config/scripts/${name}`, local);
+      log.debug(`[vyops] backed up script: ${name}`);
+    }
+    return 0;
+  } finally {
+    await close(client);
+  }
+}

package/src/deploy.mjs

@@ -53,6 +53,11 @@ async function installScripts(client, config, log, runId) {
       const mode = (await fs.promises.stat(local)).mode & 0o777;
       const backedUp = await exec(client, `if sudo test -e ${JSON.stringify(installed)}; then sudo mkdir -p ${JSON.stringify(`${backupDir}/${parent}`)} && sudo cp -p -- ${JSON.stringify(installed)} ${JSON.stringify(backup)}; fi`);
       if (backedUp.code !== 0) throw new Error(`script backup failed (${name}): ${backedUp.stderr || backedUp.stdout}`.trim());
+      if (parent !== '.') {
+        const remoteParent = `${remoteDir}/${parent}`;
+        const remoteParentResult = await exec(client, `mkdir -p ${JSON.stringify(remoteParent)}`);
+        if (remoteParentResult.code !== 0) throw new Error(`script upload directory setup failed (${name}): ${remoteParentResult.stderr || remoteParentResult.stdout}`.trim());
+      }
       await upload(client, local, remote);
       const installedResult = await exec(client, `sudo mkdir -p ${JSON.stringify(`${installDir}/${parent}`)} && sudo install -m ${mode.toString(8)} ${JSON.stringify(remote)} ${JSON.stringify(installed)}`);
       if (installedResult.code !== 0) throw new Error(`script install failed (${name}): ${installedResult.stderr || installedResult.stdout}`.trim());
@@ -77,6 +82,8 @@ export async function deploy({ target, config }) {
   const client = await connect(target);
   debugLog('SSH connected');
   let finalizeHooks;
+  let hooksFinalized = false;
+  let deploymentCommitted = false;
   const runId = randomUUID();
   const remote = `/home/vyos/.config.deploy.${runId}`;
   try {
@@ -87,25 +94,29 @@ export async function deploy({ target, config }) {
     debugLog('starting interactive deployment sequence');
     const output = await interactive(client, [
       'configure',
-      { command: `load ${remote}`, reject: /(?:load failed|error|invalid)/i },
+      { command: `load ${remote}`, reject: /(?:load failed|commit failed|commit aborted|cannot commit|configuration (?:commit )?failed|invalid configuration|error|invalid)/i },
       "printf '%s\\n' '--- compare ---'",
       'compare',
       "printf '%s\\n' '--- end compare ---'",
-      { command: 'commit-confirm 5', reject: /(?:commit failed|error|invalid)/i },
+      { command: 'commit-confirm 5', reject: /(?:commit failed|commit aborted|cannot commit|configuration (?:commit )?failed|invalid configuration|error|invalid)/i },
       { command: 'confirm', reject: /(?:confirm failed|error|invalid)/i },
       { command: 'save', reject: /(?:save failed|error|invalid)/i },
       'exit',
       'exit',
     ], debugLog);
     debugLog(`interactive sequence returned (${output.length} bytes)`);
+    deploymentCommitted = true;
     const compare = extractCompare(output);
     if (compare) log.info(compare);
-    if (finalizeHooks) await finalizeHooks(true);
     debugLog(`syncing live config: /config/config.boot -> ${config}`);
     await download(client, '/config/config.boot', config);
+    if (finalizeHooks) {
+      hooksFinalized = true;
+      await finalizeHooks(true);
+    }
     return 0;
   } catch (error) {
-    if (finalizeHooks) await finalizeHooks(false);
+    if (finalizeHooks && !hooksFinalized && !deploymentCommitted) await finalizeHooks(false);
     throw error;
   } finally {
     debugLog('cleaning up remote file');

package/src/git.mjs

@@ -75,7 +75,7 @@ export async function pushBack(config, { force = false } = {}) {
   const repo = root.trim();
   return withRepositoryLock(repo, async () => {
     const relative = config.startsWith(`${repo}/`) ? config.slice(repo.length + 1) : config;
-    const { stdout: diff } = await git(['diff', '--', relative], repo);
+    const { stdout: diff } = await git(['diff', 'HEAD', '--', relative], repo);
     if (!diff) return false;
     await git(['add', '--', relative], repo);
     const timestamp = new Date().toISOString().replace('T', ' ').slice(0, 19);

package/src/main.mjs

@@ -1,6 +1,7 @@
 import { parseArgs, usage } from './args.mjs';
 import packageJson from '../package.json' with { type: 'json' };
 import { deploy } from './deploy.mjs';
+import { backup } from './backup.mjs';
 import { readAndValidateConfig } from './validate.mjs';
 import { pushBack, shouldSkip } from './git.mjs';
 import { closeAll } from './ssh.mjs';
@@ -20,6 +21,11 @@ try {
     log.info(packageJson.version);
     process.exit(0);
   }
+  if (args.backup) {
+    await backup(args);
+    log.info(`Backup successful: ${args.config}`);
+    process.exit(0);
+  }
   log.debug(`[vyops] validating config: ${args.config}`);
   await readAndValidateConfig(args.config);
   log.debug('[vyops] config validation complete');

package/src/ssh.mjs

@@ -183,6 +183,13 @@ export function interactive(client, commands, log = () => {}) {
         response += text;
         log(`recv (${text.length} bytes): ${JSON.stringify(text)}`);
         const cleaned = clean(response);
+        if (waiting && typeof currentItem !== 'string' && currentItem.reject?.test(cleaned)) {
+          settled = true;
+          clearTimeout(timer);
+          stream.close();
+          reject(new Error(`interactive command failed: ${currentItem.command}`));
+          return;
+        }
         const pager = /(?:^|\n):\s*$/.test(cleaned) || /--More--\s*$/i.test(cleaned);
         log(`state after data: index=${index}, waiting=${waiting}, answering=${answering}, prompt=${prompt(cleaned)}, pager=${pager}, bytes=${text.length}`);
         if (pager) {
@@ -207,13 +214,6 @@ export function interactive(client, commands, log = () => {}) {
           answering = false;
           waiting = false;
           log(`response [${index}]:\n${cleaned}`);
-          if (typeof currentItem !== 'string' && currentItem.reject?.test(cleaned)) {
-            settled = true;
-            clearTimeout(timer);
-            stream.close();
-            reject(new Error(`interactive command failed: ${currentItem.command}`));
-            return;
-          }
           if (index >= commands.length) {
             settled = true;
             clearTimeout(timer);