@elitedcs/ghl-mcp 3.34.5 → 3.34.7

package/CHANGELOG.md

@@ -1,20 +1,46 @@
 # Changelog
 
-## 3.34.5 — Update-Opportunity actions are now creatable via the builder
-
-- **`update_workflow_actions` can now create `internal_update_opportunity`
-  ("Update Opportunity" / move-to-stage) actions from scratch.** v3.34.4 only
-  guarded against the cryptic "action has a corrupted type" save failure; this
-  release fixes the root cause. The bug: `workflowsActionType: "INTERNAL"` was
-  being placed inside `attributes`, but GHL's deserializer reads that
-  discriminator at the **node** level — a nested one is rejected as corrupted.
-  The builder now normalizes the action to GHL's real node shape
-  (`workflowsActionType` hoisted to the node level; `allowBackward` + per-field
-  `__customInputs__` scaffolding added). Captured from a real UI-built node and
-  **proven against a live builder save**. Just pass `__customInputFields__` with
-  a `pipelineId` and a `pipelineStageId` entry (validated — both required, so it
-  never saves a silent no-op). Round-tripped actions normalize idempotently. Tool
-  + schema docs updated; the v3.34.4 "build it in the UI" guidance is superseded.
+## 3.34.7 — Audit now sees UUID pipeline-stage ids (dead-stage silent failure)
+
+- **`audit_workflows` / `validate_workflow` now catch a dead pipeline STAGE
+  reference inside move/create/update-opportunity actions.** GHL pipeline **stage**
+  ids are hyphenated UUIDs (e.g. `ce81a710-7b63-4324-b5dc-c170ad5b8773`), but the
+  id-shape gate (`ID_SHAPE`) only matched hyphen-free alphanumeric ids. Every
+  action-level stage reference (`internal_update_opportunity`,
+  `internal_create_opportunity`, `create_opportunity`) was therefore silently
+  dropped before validation: a workflow that moved or created an opportunity into a
+  **deleted** stage passed the audit clean. This is exactly the silent-failure class
+  the tool exists to catch, and it affected every account whose pipelines use UUID
+  stages (the GHL norm). `validate_workflow` on such a workflow now reports both the
+  pipeline and the stage reference (previously only the pipeline).
+- **Fix:** `ID_SHAPE` accepts both shapes — `[A-Za-z0-9]{17,}` and the canonical
+  UUID. The broadening cannot cause a false break: display names ("Jane Doe") and
+  standard field names still never match, and anything that cannot be resolved is
+  reported as `unverified`, never `error`. Trigger-condition stage refs were already
+  un-gated and unaffected.
+- Tests: 4 new regression cases (dead UUID stage in each of the three opportunity
+  action shapes must flag; a valid UUID stage must produce zero errors and now be
+  extracted). Full suite 273 pass / 1 skip.
+
+## 3.34.6 — Revert v3.34.5 (internal_update_opportunity save-abort regression)
+
+- **Reverts v3.34.5.** That release made `validateActionChain` throw on *every*
+  `internal_update_opportunity` action — including ones round-tripped from
+  `get_workflow_full` — unless `__customInputFields__` carried both a `pipelineId`
+  and a `pipelineStageId` entry, and it removed v3.34.4's id-based pass-through for
+  already-saved nodes. Because that check runs at the top of `buildActionChain`,
+  one such node aborted the **entire** `update_workflow_actions` save. Re-saving any
+  workflow that already contained an "Update Opportunity" / move-to-stage action
+  could hard-fail. The v3.34.5 normalizer was also not shape-preserving for a real
+  round-tripped node (it dropped extra per-field keys), risking corruption on
+  re-save. An independent (non-Claude) audit confirmed both failure modes.
+- **v3.34.4 is retained** — its merge-tag blank-render audit and the honest
+  Update-Opportunity guard were audited clean. Creating an
+  `internal_update_opportunity` from scratch is guarded again with the clear "build
+  that one step in the GHL UI" message; a round-tripped one passes through untouched.
+- Net effect: restores the proven v3.34.3 / v3.34.4 save behavior. A correct
+  from-scratch builder for Update-Opportunity will be re-attempted separately, with
+  live verification, before any future republish.
 
 ## 3.34.4 — Audit catches blank-render merge tags + honest guard on Update-Opportunity
 

package/dist/index.js

@@ -31,7 +31,7 @@ var require_package = __commonJS({
   "package.json"(exports2, module2) {
     module2.exports = {
       name: "@elitedcs/ghl-mcp",
-      version: "3.34.5",
+      version: "3.34.7",
       mcpName: "io.github.drjerryrelth/ghl-command",
       description: "GoHighLevel MCP Server for Claude. 218 tools \u2014 full CRM, automation, marketing control, account-wide workflow audit, and the only programmatic GHL workflow builder, now multi-tenant across client accounts.",
       main: "dist/index.js",
@@ -1170,30 +1170,6 @@ function normalizeRemoveFromWorkflowAction(action) {
   }
   return { ...action, attributes: next };
 }
-function normalizeInternalUpdateOpportunityAction(action) {
-  if (action.type !== "internal_update_opportunity") return action;
-  const attrIn = action.attributes && typeof action.attributes === "object" ? action.attributes : {};
-  const fieldsIn = Array.isArray(attrIn.__customInputFields__) ? attrIn.__customInputFields__ : [];
-  const __customInputFields__ = fieldsIn.map((raw) => {
-    const f = raw && typeof raw === "object" ? raw : {};
-    return {
-      __customInputs__: f.__customInputs__ && typeof f.__customInputs__ === "object" ? f.__customInputs__ : {},
-      dataType: typeof f.dataType === "string" ? f.dataType : "SINGLE_OPTIONS",
-      filterField: f.filterField,
-      value: f.value,
-      valueFieldType: typeof f.valueFieldType === "string" ? f.valueFieldType : "select"
-    };
-  });
-  const attributes = {
-    ...attrIn,
-    type: "internal_update_opportunity",
-    allowBackward: typeof attrIn.allowBackward === "boolean" ? attrIn.allowBackward : false,
-    __customInputs__: attrIn.__customInputs__ && typeof attrIn.__customInputs__ === "object" ? attrIn.__customInputs__ : {},
-    __customInputFields__
-  };
-  delete attributes.workflowsActionType;
-  return { ...action, workflowsActionType: "INTERNAL", attributes };
-}
 function hasId(action) {
   return typeof action.id === "string" && action.id.length > 0;
 }
@@ -1231,10 +1207,12 @@ function validateActionChain(actions) {
         if (!attr.startAfter) throw new Error(`Wait action "${action.name}" missing required 'startAfter' in attributes.`);
         break;
       case "internal_update_opportunity": {
-        const cif = Array.isArray(attr.__customInputFields__) ? attr.__customInputFields__ : null;
-        if (!cif) throw new Error(`Internal update opportunity action "${action.name}" missing '__customInputFields__' array (needs pipelineId + pipelineStageId entries).`);
-        const hasTarget = (ff) => cif.some((f) => f && f.filterField === ff && typeof f.value === "string" && f.value.length > 0);
-        if (!hasTarget("pipelineId") || !hasTarget("pipelineStageId")) throw new Error(`Internal update opportunity action "${action.name}" needs both a pipelineId and a pipelineStageId entry (each with a value) in '__customInputFields__'. Use get_pipelines to find the IDs.`);
+        if (!hasId(action)) {
+          throw new Error(
+            `Action "${action.name}" (internal_update_opportunity / "Update Opportunity" / move-to-stage) cannot be created via the API yet: GHL's workflow builder rejects a synthesized node with "action has a corrupted type", which silently fails the whole save. Build this one step in the GHL UI (Workflow > add action > Update Opportunity), or pass through an existing one read via get_workflow_full (it keeps its id). Every other action type in this call works.`
+          );
+        }
+        if (!Array.isArray(attr.__customInputFields__)) throw new Error(`Internal update opportunity action "${action.name}" missing '__customInputFields__' array.`);
         break;
       }
       case "remove_from_workflow":
@@ -1855,7 +1833,7 @@ ${errorBody}`
    */
   buildActionChain(actions) {
     validateActionChain(actions);
-    const linked = actions.map(normalizeRemoveFromWorkflowAction).map(normalizeInternalUpdateOpportunityAction).map((action, i) => {
+    const linked = actions.map(normalizeRemoveFromWorkflowAction).map((action, i) => {
       const copy = { ...action };
       if (!copy.id) {
         copy.id = crypto.randomUUID();
@@ -5422,7 +5400,7 @@ function registerWorkflowBuilderTools(server2, client) {
   );
   server2.tool(
     "update_workflow_actions",
-    "Update a workflow's actions (steps), triggers, name, or status. IMPORTANT: Call get_workflow_full first to see the current state before updating. Handles version tracking automatically. Uses the internal builder API (requires Firebase auth). Action types: sms, email, add_contact_tag, remove_contact_tag, wait, webhook, internal_update_opportunity, custom_code, update_contact_field, add_notes, internal_notification, task_notification, remove_from_workflow, add_to_workflow, goto, transition, workflow_goal. NOTE: internal_update_opportunity (GHL's 'Update Opportunity' / move-to-stage action) is creatable \u2014 pass attributes.__customInputFields__ with a pipelineId entry and a pipelineStageId entry (use get_pipelines for the IDs); the builder normalizes it to GHL's node shape (workflowsActionType is set at the node level for you). For if/else, call build_if_else_branch and include its returned nodes; if_else is a node discriminator, not a standalone action. For goal events (exit-on-condition nodes), call build_goal_event to get a correctly-shaped workflow_goal node \u2014 wire it in by setting the prior action's `next` to the goal node's id. Trigger types: all 57 native GHL trigger types have typed validation; any unknown trigger type passes through via a permissive fallback so reads never crash.",
+    "Update a workflow's actions (steps), triggers, name, or status. IMPORTANT: Call get_workflow_full first to see the current state before updating. Handles version tracking automatically. Uses the internal builder API (requires Firebase auth). Action types: sms, email, add_contact_tag, remove_contact_tag, wait, webhook, internal_update_opportunity, custom_code, update_contact_field, add_notes, internal_notification, task_notification, remove_from_workflow, add_to_workflow, goto, transition, workflow_goal. NOTE: internal_update_opportunity (GHL's 'Update Opportunity' / move-to-stage action) cannot be created fresh through this API \u2014 GHL's builder rejects a synthesized node with 'action has a corrupted type' and fails the whole save; add that single step in the GHL UI, or pass through one already read via get_workflow_full (it keeps its node id). For if/else, call build_if_else_branch and include its returned nodes; if_else is a node discriminator, not a standalone action. For goal events (exit-on-condition nodes), call build_goal_event to get a correctly-shaped workflow_goal node \u2014 wire it in by setting the prior action's `next` to the goal node's id. Trigger types: all 57 native GHL trigger types have typed validation; any unknown trigger type passes through via a permissive fallback so reads never crash.",
     {
       workflowId: import_zod33.z.string().describe("The workflow ID to update."),
       name: import_zod33.z.string().optional().describe("New workflow name."),
@@ -8538,7 +8516,7 @@ ${errors.join("\n")}` : "\nNo errors!",
 // src/tools/validators.ts
 var import_zod47 = require("zod");
 var ALL_CATEGORIES = ["pipeline", "stage", "custom_field", "user", "workflow", "form", "calendar", "survey"];
-var ID_SHAPE = /^[A-Za-z0-9]{17,}$/;
+var ID_SHAPE = /^([A-Za-z0-9]{17,}|[0-9a-fA-F]{8}-[0-9a-fA-F]{4}-[0-9a-fA-F]{4}-[0-9a-fA-F]{4}-[0-9a-fA-F]{12})$/;
 function isIdShaped(s) {
   return typeof s === "string" && ID_SHAPE.test(s);
 }

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@elitedcs/ghl-mcp",
-  "version": "3.34.5",
+  "version": "3.34.7",
   "mcpName": "io.github.drjerryrelth/ghl-command",
   "description": "GoHighLevel MCP Server for Claude. 218 tools — full CRM, automation, marketing control, account-wide workflow audit, and the only programmatic GHL workflow builder, now multi-tenant across client accounts.",
   "main": "dist/index.js",

package/templates/action-schemas.json

@@ -165,7 +165,7 @@
       "workflowsActionType": "INTERNAL",
       "type": "internal_update_opportunity"
     },
-    "notes": "CREATABLE (v3.34.5+): pass __customInputFields__ with a pipelineId entry and a pipelineStageId entry; the builder sets workflowsActionType at the NODE level for you. (workflowsActionType must NOT be nested in attributes — GHL rejects a nested one as 'action has a corrupted type'. The builder hoists it automatically; the example here shows it in attributes only for backward-compat input.) Proven against a live builder save 2026-06-14. Use pipeline and stage IDs (not names). Use get_pipelines or list_pipelines_full to find IDs FIRST. CRITICAL: If the pipelineId or stageId don't exist in the target sub-account, GHL silently fails this action AND can kill subsequent actions in the workflow. Always verify IDs exist before deploying."
+    "notes": "CANNOT CREATE FRESH VIA THIS API: GHL's builder rejects a synthesized internal_update_opportunity node with 'action has a corrupted type' and fails the whole save. Build this step in the GHL UI, or round-trip one read via get_workflow_full (it keeps its node id). The shape below is correct for READING / round-tripping. Use pipeline and stage IDs (not names). Use get_pipelines or list_pipelines_full to find IDs FIRST. CRITICAL: If the pipelineId or stageId don't exist in the target sub-account, GHL silently fails this action AND can kill subsequent actions in the workflow. Always verify IDs exist before deploying."
   },
 
   "_if_else_branching": {