@elisra-devops/docgen-data-provider 1.69.0 → 1.69.1

package/src/tests/modules/pipelineDataProvider.test.ts

@@ -262,8 +262,8 @@ describe('PipelinesDataProvider', () => {
         null
       );
       expect(result).toEqual({
-        count: 4, // Note: Current filter logic keeps all runs where result is not 'failed' AND not 'canceled'
-        value: mockResponse.value,
+        count: 2,
+        value: mockResponse.value.filter((r) => r.result !== 'failed' && r.result !== 'canceled'),
       });
     });
 
@@ -704,13 +704,15 @@ describe('PipelinesDataProvider', () => {
                 id: 123,
                 url: 'https://dev.azure.com/org/project/_apis/pipelines/123?revision=1',
               },
+              runId: 789,
             },
           },
         },
       } as unknown as PipelineRun;
 
       const mockBuildResponse = {
-        definition: { id: 456, type: 'build' },
+        id: 789,
+        definition: { id: 123, type: 'build' },
         buildNumber: '20231201.1',
         project: { name: 'project1' },
         repository: { type: 'TfsGit' },
@@ -725,8 +727,8 @@ describe('PipelinesDataProvider', () => {
       expect(result).toHaveLength(1);
       expect((result as any[])[0]).toEqual({
         name: 'myPipeline',
-        buildId: 123,
-        definitionId: 456,
+        buildId: 789,
+        definitionId: 123,
         buildNumber: '20231201.1',
         teamProject: 'project1',
         provider: 'TfsGit',
@@ -743,6 +745,7 @@ describe('PipelinesDataProvider', () => {
                 id: 123,
                 url: 'https://dev.azure.com/org/project/_apis/pipelines/123?revision=1',
               },
+              runId: 789,
             },
           },
         },
@@ -755,12 +758,233 @@ describe('PipelinesDataProvider', () => {
 
       // Assert
       expect(result).toEqual([]);
-      expect(logger.error).toHaveBeenCalled();
+    });
+
+    it('should resolve resource pipeline by buildNumber when runId is missing and version is semantic', async () => {
+      // Arrange
+      const inPipeline = {
+        url: 'https://dev.azure.com/org/project1/_apis/pipelines/10/runs/200',
+        resources: {
+          pipelines: {
+            SOME_PACKAGE: {
+              pipeline: {
+                id: 123,
+                url: 'https://dev.azure.com/org/project1/_apis/pipelines/123?revision=1',
+              },
+              project: { name: 'project1' },
+              source: 'project1-system-package',
+              version: '1.0.56',
+              branch: 'main',
+            },
+          },
+        },
+      } as unknown as PipelineRun;
+
+      const mockListBuildsResponse = {
+        value: [
+          {
+            id: 789,
+          },
+        ],
+      };
+      const mockBuildResponse = {
+        id: 789,
+        definition: { id: 123, type: 'build' },
+        buildNumber: '1.0.56',
+        project: { name: 'project1' },
+        repository: { type: 'TfsGit' },
+      };
+
+      (TFSServices.getItemContent as jest.Mock)
+        .mockResolvedValueOnce(mockListBuildsResponse) // findBuildByDefinitionAndBuildNumber
+        .mockResolvedValueOnce(mockBuildResponse); // getPipelineBuildByBuildId
+
+      // Act
+      const result = await pipelinesDataProvider.getPipelineResourcePipelinesFromObject(inPipeline);
+
+      // Assert
+      expect(result).toHaveLength(1);
+      expect((result as any[])[0]).toEqual({
+        name: 'SOME_PACKAGE',
+        buildId: 789,
+        definitionId: 123,
+        buildNumber: '1.0.56',
+        teamProject: 'project1',
+        provider: 'TfsGit',
+      });
+
+      // Ensure branch normalization was applied in the build search URL
+      expect((TFSServices.getItemContent as jest.Mock).mock.calls[0][0]).toContain('branchName=refs%2Fheads%2Fmain');
+      expect((TFSServices.getItemContent as jest.Mock).mock.calls[0][0]).toContain('buildNumber=1.0.56');
+      expect((TFSServices.getItemContent as jest.Mock).mock.calls[0][0]).toContain('definitions=123');
+    });
+
+    it('should fall back to pipeline run history when buildNumber lookup returns no builds', async () => {
+      // Arrange
+      const inPipeline = {
+        url: 'https://dev.azure.com/org/project1/_apis/pipelines/10/runs/200',
+        resources: {
+          pipelines: {
+            SOME_PACKAGE: {
+              pipeline: {
+                id: 123,
+                url: 'https://dev.azure.com/org/project1/_apis/pipelines/123?revision=1',
+              },
+              project: { name: 'project1' },
+              source: 'project1-system-package',
+              version: '20251109.1',
+              branch: 'main',
+            },
+          },
+        },
+      } as unknown as PipelineRun;
+
+      const mockListBuildsResponseEmpty = { value: [] };
+      const mockRunHistoryResponse = {
+        value: [{ id: 789, name: '20251109.1', result: 'succeeded' }],
+      };
+      const mockBuildResponse = {
+        id: 789,
+        definition: { id: 123, type: 'build' },
+        buildNumber: '20251109.1',
+        project: { name: 'project1' },
+        repository: { type: 'TfsGit' },
+      };
+
+      (TFSServices.getItemContent as jest.Mock)
+        .mockResolvedValueOnce(mockListBuildsResponseEmpty) // findBuildByDefinitionAndBuildNumber
+        .mockResolvedValueOnce(mockListBuildsResponseEmpty) // findBuildByBuildNumber (no definition)
+        .mockResolvedValueOnce(mockRunHistoryResponse) // GetPipelineRunHistory
+        .mockResolvedValueOnce(mockBuildResponse); // getPipelineBuildByBuildId
+
+      // Act
+      const result = await pipelinesDataProvider.getPipelineResourcePipelinesFromObject(inPipeline);
+
+      // Assert
+      expect(result).toHaveLength(1);
+      expect((result as any[])[0]).toEqual({
+        name: 'SOME_PACKAGE',
+        buildId: 789,
+        definitionId: 123,
+        buildNumber: '20251109.1',
+        teamProject: 'project1',
+        provider: 'TfsGit',
+      });
+    });
+
+    it('should fall back to buildNumber-only lookup when definition-based lookup returns no builds', async () => {
+      const inPipeline = {
+        url: 'https://dev.azure.com/org/project1/_apis/pipelines/10/runs/200',
+        resources: {
+          pipelines: {
+            SOME_PACKAGE: {
+              pipeline: {
+                id: 770,
+                url: 'https://dev.azure.com/org/project1/_apis/pipelines/770?revision=1',
+              },
+              project: { name: 'project1' },
+              source: 'project1-system-package',
+              version: '20251109.1',
+              branch: 'main',
+            },
+          },
+        },
+      } as unknown as PipelineRun;
+
+      const mockListBuildsResponseEmpty = { value: [] };
+      const mockListBuildsByNumber = {
+        value: [
+          {
+            id: 789,
+            definition: { id: 123, name: 'project1-system-package' },
+          },
+        ],
+      };
+      const mockBuildResponse = {
+        id: 789,
+        definition: { id: 123, type: 'build' },
+        buildNumber: '20251109.1',
+        project: { name: 'project1' },
+        repository: { type: 'TfsGit' },
+      };
+
+      (TFSServices.getItemContent as jest.Mock)
+        .mockResolvedValueOnce(mockListBuildsResponseEmpty) // findBuildByDefinitionAndBuildNumber
+        .mockResolvedValueOnce(mockListBuildsByNumber) // findBuildByBuildNumber (no definition)
+        .mockResolvedValueOnce(mockBuildResponse); // getPipelineBuildByBuildId
+
+      const result = await pipelinesDataProvider.getPipelineResourcePipelinesFromObject(inPipeline);
+
+      expect(result).toHaveLength(1);
+      expect((result as any[])[0]).toEqual({
+        name: 'SOME_PACKAGE',
+        buildId: 789,
+        definitionId: 123,
+        buildNumber: '20251109.1',
+        teamProject: 'project1',
+        provider: 'TfsGit',
+      });
+
+      // Ensure the second call is the buildNumber-only lookup (no definitions= filter)
+      expect((TFSServices.getItemContent as jest.Mock).mock.calls[1][0]).toContain('buildNumber=20251109.1');
+      expect((TFSServices.getItemContent as jest.Mock).mock.calls[1][0]).not.toContain('definitions=');
+    });
+
+    it('should resolve project name when pipeline resource provides project id (GUID)', async () => {
+      const inPipeline = {
+        url: 'https://dev.azure.com/org/project1/_apis/pipelines/10/runs/200',
+        resources: {
+          pipelines: {
+            SOME_PACKAGE: {
+              pipeline: {
+                id: 123,
+                url: 'https://dev.azure.com/org/1488cb19-7369-4afc-92bf-251d368b85be/_apis/pipelines/123?revision=1',
+              },
+              project: { name: '1488cb19-7369-4afc-92bf-251d368b85be' },
+              source: 'project1-system-package',
+              version: '20251109.1',
+              branch: 'main',
+            },
+          },
+        },
+      } as unknown as PipelineRun;
+
+      const mockProjectResponse = { id: '1488cb19-7369-4afc-92bf-251d368b85be', name: 'Test CMMI' };
+      const mockListBuildsResponse = { value: [{ id: 789 }] };
+      const mockBuildResponse = {
+        id: 789,
+        definition: { id: 123, type: 'build' },
+        buildNumber: '20251109.1',
+        project: { name: 'Test CMMI' },
+        repository: { type: 'TfsGit' },
+      };
+
+      (TFSServices.getItemContent as jest.Mock)
+        .mockResolvedValueOnce(mockProjectResponse) // normalizeProjectName
+        .mockResolvedValueOnce(mockListBuildsResponse) // findBuildByDefinitionAndBuildNumber
+        .mockResolvedValueOnce(mockBuildResponse); // getPipelineBuildByBuildId
+
+      const result = await pipelinesDataProvider.getPipelineResourcePipelinesFromObject(inPipeline);
+
+      expect(result).toHaveLength(1);
+      expect((result as any[])[0]).toEqual({
+        name: 'SOME_PACKAGE',
+        buildId: 789,
+        definitionId: 123,
+        buildNumber: '20251109.1',
+        teamProject: 'Test CMMI',
+        provider: 'TfsGit',
+      });
+
+      // Ensure project-id normalization API was called
+      expect((TFSServices.getItemContent as jest.Mock).mock.calls[0][0]).toContain(
+        `${mockOrgUrl}_apis/projects/1488cb19-7369-4afc-92bf-251d368b85be`
+      );
     });
   });
 
   describe('getPipelineResourceRepositoriesFromObject', () => {
-    it('should return empty map when no repository resources exist', async () => {
+    it('should return empty array when no repository resources exist', async () => {
       // Arrange
       const inPipeline = {
         resources: {},
@@ -774,7 +998,7 @@ describe('PipelinesDataProvider', () => {
       );
 
       // Assert
-      expect(result).toEqual(new Map());
+      expect(result).toEqual([]);
     });
 
     it('should extract repository resources from pipeline object', async () => {