@elevasis/ui 2.68.0 → 2.70.0

package/dist/test-utils/index.d.ts

@@ -154,7 +154,6 @@ interface OrgOsRouteContractSystem {
         path?: string | null;
     } | null;
     enabled?: boolean;
-    devOnly?: boolean;
 }
 type OrgOsRouteContractSystemsDomain = Record<string, OrgOsRouteContractSystem> | {
     systems: readonly OrgOsRouteContractSystem[];
@@ -175,8 +174,17 @@ interface OrgOsUiRouteContractOptions {
     routeTreeSource?: string;
     routePaths?: Iterable<string>;
     mode?: OrgOsUiRouteContractMode;
+    /**
+     * Route paths whose route file — or an ancestor layout route — wraps the page
+     * in an `AccessGuard`. Supply this to enable the `unguarded-beta-route` check.
+     *
+     * Omitted means the beta-guard check does not run. Hiding a System from
+     * navigation (`lifecycle: 'beta'`) does not make its route unreachable, so a
+     * caller that can resolve route files should always pass this.
+     */
+    guardedRoutePaths?: Iterable<string>;
 }
-type OrgOsUiRouteContractIssueKind = 'missing-system' | 'missing-route';
+type OrgOsUiRouteContractIssueKind = 'missing-system' | 'missing-route' | 'unguarded-beta-route';
 interface OrgOsUiRouteContractIssue {
     target: OrgOsUiRouteContractTarget;
     kind: OrgOsUiRouteContractIssueKind;

package/dist/test-utils/index.js

@@ -2,10 +2,10 @@ import { server, handlers } from '../chunk-7XKCG5CT.js';
 export { handlers, server } from '../chunk-7XKCG5CT.js';
 import { mockWorkOSUser, mockUseAuth, mockUnauthenticatedUser, mockAuthenticatedUser, mockAuthLoading, createMockUseAuth } from '../chunk-N7U24M2J.js';
 export { createMockUseAuth, mockAuthLoading, mockAuthenticatedUser, mockUnauthenticatedUser, mockUseAuth, mockWorkOSUser } from '../chunk-N7U24M2J.js';
-import '../chunk-JC5W55J3.js';
-import { ApiClientProvider } from '../chunk-5NRJ2BLQ.js';
+import '../chunk-26BTE3Z4.js';
+import { ApiClientProvider } from '../chunk-VDX6DL7Z.js';
 import '../chunk-DD3CCMCZ.js';
-import '../chunk-L3HFJFYF.js';
+import '../chunk-NM4A63KJ.js';
 import '../chunk-Y6I3IC45.js';
 import '../chunk-6SSQGWK7.js';
 import { ElevasisServiceProvider } from '../chunk-BI5VDO2K.js';
@@ -178,26 +178,33 @@ function ownsOrgOsSystem(ownerSystemId, systemId) {
 function getOrgOsRouteContractSystems(organizationModel) {
   const { systems } = organizationModel;
   const arraySystems = systems.systems;
-  if (Array.isArray(arraySystems)) return arraySystems;
+  if (Array.isArray(arraySystems)) {
+    return arraySystems.map((system) => ({
+      ...system,
+      betaByAncestry: system.lifecycle === "beta"
+    }));
+  }
   const result = [];
-  const visit = (entries, prefix = "") => {
+  const visit = (entries, prefix = "", ancestorBeta = false) => {
     for (const [key, system] of Object.entries(entries)) {
       const id = prefix ? `${prefix}.${key}` : system.id || key;
-      result.push({ ...system, id });
-      if (system.systems) visit(system.systems, id);
-      if (system.subsystems) visit(system.subsystems, id);
+      const betaByAncestry = ancestorBeta || system.lifecycle === "beta";
+      result.push({ ...system, id, betaByAncestry });
+      if (system.systems) visit(system.systems, id, betaByAncestry);
+      if (system.subsystems) visit(system.subsystems, id, betaByAncestry);
     }
   };
   visit(systems);
   return result;
 }
 function collectOrgOsUiRouteContractIssues(options) {
-  const { target, organizationModel, mode = "production" } = options;
+  const { target, organizationModel } = options;
   const routePaths = options.routePaths ?? (options.routeTreeSource ? extractOrgOsRouteTreeFullPaths(options.routeTreeSource) : void 0);
   if (!routePaths) {
     throw new Error("Org OS UI route contract requires either routeTreeSource or routePaths.");
   }
   const normalizedRoutePaths = new Set([...routePaths].map(normalizeOrgOsRoutePath));
+  const normalizedGuardedPaths = options.guardedRoutePaths ? new Set([...options.guardedRoutePaths].map(normalizeOrgOsRoutePath)) : void 0;
   const systems = getOrgOsRouteContractSystems(organizationModel);
   const modelSystemIds = new Set(systems.map((system) => system.id));
   const issues = [];
@@ -215,7 +222,6 @@ function collectOrgOsUiRouteContractIssues(options) {
     const path = system.ui?.path ?? system.path;
     if (!path || system.enabled === false) continue;
     if (system.lifecycle === "archived" || system.lifecycle === "deprecated") continue;
-    if (system.devOnly && mode === "production") continue;
     const ownerSystemId = target.systemIds.find((candidate) => ownsOrgOsSystem(candidate, system.id));
     if (!ownerSystemId) continue;
     checkedPathCount += 1;
@@ -228,6 +234,16 @@ function collectOrgOsUiRouteContractIssues(options) {
         ownerSystemId,
         path: normalizedPath
       });
+      continue;
+    }
+    if (normalizedGuardedPaths && system.betaByAncestry && !normalizedGuardedPaths.has(normalizedPath)) {
+      issues.push({
+        target,
+        kind: "unguarded-beta-route",
+        systemId: system.id,
+        ownerSystemId,
+        path: normalizedPath
+      });
     }
   }
   return { issues, checkedPathCount };
@@ -241,6 +257,19 @@ function formatOrgOsUiRouteContractIssue(issue) {
       `- If it should not ship, remove that SystemModule from ${issue.target.shellSource}.`
     ].join("\n");
   }
+  if (issue.kind === "unguarded-beta-route") {
+    return [
+      `[unguarded-beta-route] System "${issue.systemId}" is lifecycle "beta" (directly or via an ancestor) and routes to "${issue.path}", but neither that route file nor an ancestor layout route wraps it in an AccessGuard.`,
+      `Owner SystemModule: ${issue.ownerSystemId}`,
+      "A beta System is hidden from navigation, which is not the same as unreachable \u2014 the route still answers a direct URL.",
+      "Fix one of:",
+      // Phrased in prose rather than as a guard JSX tag on purpose. The
+      // access-key drift scanner in @repo/core matches that tag shape anywhere
+      // in a file and would read this message as a real runtime access key.
+      `- Wrap the route (or its layout route) in an AccessGuard whose access key is "${issue.systemId}".`,
+      `- Or change the System's lifecycle in ${issue.target.orgModelSource} if it is actually meant to be publicly reachable.`
+    ].join("\n");
+  }
   return [
     `[missing-route] System "${issue.systemId}" points to "${issue.path}", but ${issue.target.routeTreePath} does not contain that path.`,
     `Owner SystemModule: ${issue.ownerSystemId}`,