@elevasis/core 0.37.0 → 0.38.0

package/src/platform/registry/validation.ts

@@ -29,7 +29,8 @@ import type {
   ResourceRelationships,
   ExternalResourceDefinition,
   HumanCheckpointDefinition,
-  ResourceType
+  ResourceType,
+  ApiInterfaceConformanceGap
 } from './types'
 
 // ============================================================================
@@ -612,6 +613,64 @@ function addSystemInterfaceIssue(
   })
 }
 
+/**
+ * Detects systems that are API-backed (have resources with non-empty ontology
+ * bindings) but have not declared `apiInterface` in the Organization Model.
+ *
+ * Broad-by-design — tighten via test-driven counterexample.
+ * See _execution-plan.mdx Decision 1.
+ *
+ * A system is flagged when:
+ *   (a) `system.apiInterface === undefined`, AND
+ *   (b) at least one resource in `organizationModel.resources` has
+ *       `resource.systemPath` matching the system path AND
+ *       `resource.ontology` non-empty (has `actions` and/or `writes` defined).
+ *
+ * Returns `[]` when `organizationModel` is undefined or no gaps are found.
+ * The structured return value drives both CLI warnings and scaffold fill-mode
+ * input payloads without any transformation on the caller side.
+ */
+export function detectMissingApiInterfaceDeclarations(
+  orgName: string,
+  organizationModel: OrganizationModel | undefined
+): ApiInterfaceConformanceGap[] {
+  if (organizationModel === undefined) return []
+
+  // Build a map of system path → resource IDs for resources with non-empty ontology.
+  const apiBoundResourcesBySystemPath = new Map<string, string[]>()
+  for (const resource of Object.values(organizationModel.resources ?? {})) {
+    const ontology = resource.ontology
+    if (ontology === undefined) continue
+    const hasOntologyBindings =
+      (ontology.actions !== undefined && ontology.actions.length > 0) ||
+      (ontology.writes !== undefined && ontology.writes.length > 0)
+    if (!hasOntologyBindings) continue
+    const existing = apiBoundResourcesBySystemPath.get(resource.systemPath)
+    if (existing) {
+      existing.push(resource.id)
+    } else {
+      apiBoundResourcesBySystemPath.set(resource.systemPath, [resource.id])
+    }
+  }
+
+  if (apiBoundResourcesBySystemPath.size === 0) return []
+
+  const gaps: ApiInterfaceConformanceGap[] = []
+
+  for (const { path, system } of listAllSystems(organizationModel)) {
+    if (system.apiInterface !== undefined) continue
+    const resourceIds = apiBoundResourcesBySystemPath.get(path)
+    if (!resourceIds || resourceIds.length === 0) continue
+    gaps.push({
+      systemPath: path,
+      resourceIds,
+      message: `[${orgName}] System '${path}' has ${resourceIds.length} API-backed resource(s) (${resourceIds.join(', ')}) but no apiInterface declaration.`
+    })
+  }
+
+  return gaps
+}
+
 /**
  * Validates every explicitly declared API System Interface by deriving
  * readiness from its scoped resources and ontology bindings.