@elevasis/core 0.26.0 → 0.28.0

package/src/business/acquisition/crm-state-actions.test.ts

@@ -1,153 +1,208 @@
-import { describe, expect, it } from 'vitest'
-// Phase 4 (D8): DEFAULT_ORGANIZATION_MODEL_SALES no longer exported — pipeline data moved to
-// system.content. CRM_PIPELINE_DEFINITION is retained as the Stateful pipeline shape
-// for CRM business logic (separate from the OM content nodes).
-import { CRM_PIPELINE_DEFINITION, LEAD_GEN_PIPELINE_DEFINITIONS } from '../../organization-model/domains/sales'
-import { ActivityEventSchema } from './activity-events'
-import { DealStageSchema, TransitionItemRequestSchema } from './api-schemas'
-import { deriveActions } from './derive-actions'
-import type { DealStage } from './types'
-
-const DEAL_STAGES = [
-  'interested',
-  'proposal',
-  'closing',
-  'closed_won',
-  'closed_lost',
-  'nurturing'
-] as const satisfies readonly DealStage[]
-
-function deal(stageKey: string | null, stateKey: string | null = null): Parameters<typeof deriveActions>[0] {
-  return { stage_key: stageKey, state_key: stateKey } as Parameters<typeof deriveActions>[0]
-}
-
-describe('CRM deal action derivation', () => {
-  it('derives the exact base actions for interested deals', () => {
-    expect(deriveActions(deal('interested'))).toEqual([
-      { key: 'move_to_proposal', label: 'Move to Proposal' },
-      { key: 'move_to_closed_lost', label: 'Close Lost' },
-      { key: 'move_to_nurturing', label: 'Move to Nurturing' }
-    ])
-  })
-
-  it.each([
-    ['discovery_replied', { key: 'send_link', label: 'Send Booking Link' }],
-    ['discovery_link_sent', { key: 'send_nudge', label: 'Send Nudge' }],
-    ['discovery_booking_cancelled', { key: 'rebook', label: 'Rebook' }]
-  ] as const)('adds the expected workflow action for interested/%s', (stateKey, expectedAction) => {
-    const expected = [
-      { key: 'move_to_proposal', label: 'Move to Proposal' },
-      { key: 'move_to_closed_lost', label: 'Close Lost' },
-      { key: 'move_to_nurturing', label: 'Move to Nurturing' },
-      expectedAction
-    ]
-
-    expect(deriveActions(deal('interested', stateKey))).toEqual(expected)
-  })
-
-  it('adds nudge and no-show actions for interested/discovery_nudging', () => {
-    expect(deriveActions(deal('interested', 'discovery_nudging'))).toEqual([
-      { key: 'move_to_proposal', label: 'Move to Proposal' },
-      { key: 'move_to_closed_lost', label: 'Close Lost' },
-      { key: 'move_to_nurturing', label: 'Move to Nurturing' },
-      { key: 'send_nudge', label: 'Send Nudge' },
-      { key: 'mark_no_show', label: 'Mark No-Show' }
-    ])
-  })
-
-  it('derives exact proposal and closing transitions', () => {
-    expect(deriveActions(deal('proposal'))).toEqual([
-      { key: 'move_to_closing', label: 'Move to Closing' },
-      { key: 'move_to_closed_lost', label: 'Close Lost' },
-      { key: 'move_to_nurturing', label: 'Move to Nurturing' }
-    ])
-
-    expect(deriveActions(deal('closing'))).toEqual([
-      { key: 'move_to_closed_won', label: 'Close Won' },
-      { key: 'move_to_closed_lost', label: 'Close Lost' },
-      { key: 'move_to_nurturing', label: 'Move to Nurturing' }
-    ])
-  })
-
-  it.each(['closed_won', 'closed_lost', 'nurturing', 'legacy_stage', null] as const)(
-    'derives no actions for terminal or non-canonical stage %s',
-    (stageKey) => {
-      expect(deriveActions(deal(stageKey))).toEqual([])
-    }
-  )
-})
-
-describe('ActivityEventSchema', () => {
-  const timestamp = '2026-04-27T12:34:56.000Z'
-
-  // Platform events only (8 members). Domain events (reply_received, booking_nudge_sent, etc.)
-  // live in @repo/elevasis-operations as CrmDomainActivityEventSchema.
-  // See Open Decision #5 in crm-action-system.mdx for rationale.
-  it.each([
-    [{ type: 'stage_change', timestamp, stageBefore: 'interested', stageAfter: 'proposal', reason: 'qualified' }],
-    [{ type: 'state_change', timestamp, stateBefore: null, stateAfter: 'discovery_replied' }],
-    [{ type: 'action_taken', timestamp, actionKey: 'send_link', payload: { channel: 'email' } }],
-    [{ type: 'approval_created', timestamp, commandId: 'cmd_123', dealStageBefore: 'proposal' }],
-    [{ type: 'approval_resolved', timestamp, commandId: 'cmd_123', resolution: 'superseded' }],
-    [{ type: 'approval_stale', timestamp, commandId: 'cmd_123', dealStageAfter: 'closing' }],
-    [{ type: 'task_created', timestamp, taskId: 'task_123' }],
-    [{ type: 'deal_created', timestamp }]
-  ])('accepts expected %s events', (event) => {
-    expect(ActivityEventSchema.safeParse(event).success).toBe(true)
-  })
-
-  it.each([
-    [{ type: 'deal_created', timestamp: 'not-a-date' }],
-    [{ type: 'unknown_event', timestamp }],
-    [{ type: 'stage_change', timestamp, stageBefore: 'interested' }],
-    [{ type: 'approval_resolved', timestamp, commandId: 'cmd_123', resolution: 'approved' }],
-    [{ type: 'booking_nudge_sent', timestamp, followupDay: '2' }],
-    [{ type: 'action_taken', timestamp }]
-  ])('rejects malformed event payload %o', (event) => {
-    expect(ActivityEventSchema.safeParse(event).success).toBe(false)
-  })
-})
-
-describe('CRM stage and transition vocabulary contracts', () => {
-  // Phase 4 (D8): DEFAULT_ORGANIZATION_MODEL_SALES.pipelines removed.
-  // CRM_PIPELINE_DEFINITION (StatefulPipelineDefinition) is the retained Stateful-trait
-  // pipeline shape used by CRM business logic. stageKey → DealStageSchema alignment
-  // is now verified against CRM_PIPELINE_DEFINITION.stages[*].stageKey.
-  it('keeps DealStage, DealStageSchema, and CRM_PIPELINE_DEFINITION stages aligned', () => {
-    const crmStageKeys = CRM_PIPELINE_DEFINITION.stages.map((stage) => stage.stageKey)
-
-    expect(crmStageKeys).toEqual([...DEAL_STAGES])
-    expect(DealStageSchema.options).toEqual([...DEAL_STAGES])
-  })
-
-  it('accepts every canonical CRM deal stage in transition requests', () => {
-    for (const stageKey of DEAL_STAGES) {
-      expect(
-        TransitionItemRequestSchema.safeParse({
-          pipelineKey: CRM_PIPELINE_DEFINITION.pipelineKey,
-          stageKey,
-          stateKey: null,
-          expectedUpdatedAt: '2026-04-27T12:34:56.000Z'
-        }).success
-      ).toBe(true)
-    }
-  })
-
-  it('accepts canonical lead-gen stage/state pairs in transition requests', () => {
-    for (const pipelineDefinitions of Object.values(LEAD_GEN_PIPELINE_DEFINITIONS)) {
-      for (const pipeline of pipelineDefinitions) {
-        for (const stage of pipeline.stages) {
-          for (const state of stage.states) {
-            expect(
-              TransitionItemRequestSchema.safeParse({
-                pipelineKey: pipeline.pipelineKey,
-                stageKey: stage.stageKey,
-                stateKey: state.stateKey
-              }).success
-            ).toBe(true)
-          }
-        }
-      }
-    }
-  })
-})
+import { describe, expect, it } from 'vitest'
+import {
+  LEAD_GEN_PIPELINE_DEFINITIONS,
+  type StatefulPipelineDefinition
+} from '../../organization-model/domains/sales'
+import { ActivityEventSchema } from './activity-events'
+import { DealStageSchema, TransitionItemRequestSchema } from './api-schemas'
+import { deriveActions } from './derive-actions'
+import type { DealStage } from './types'
+
+const DEAL_STAGES = [
+  'interested',
+  'proposal',
+  'closing',
+  'closed_won',
+  'closed_lost',
+  'nurturing'
+] as const satisfies readonly DealStage[]
+
+const CRM_PIPELINE_FIXTURE: StatefulPipelineDefinition = {
+  pipelineKey: 'crm',
+  label: 'CRM',
+  entityKey: 'crm.deal',
+  stages: DEAL_STAGES.map((stageKey, index) => ({
+    stageKey,
+    label: stageKey,
+    color: 'gray',
+    states:
+      index === 0
+        ? [
+            { stateKey: 'discovery_replied', label: 'Discovery Replied' },
+            { stateKey: 'discovery_link_sent', label: 'Discovery Link Sent' },
+            { stateKey: 'discovery_nudging', label: 'Discovery Nudging' },
+            { stateKey: 'discovery_booking_cancelled', label: 'Discovery Booking Cancelled' }
+          ]
+        : []
+  }))
+}
+
+const CRM_ACTION_FIXTURE = [
+  {
+    key: 'move_to_proposal',
+    label: 'Move to Proposal',
+    workflowId: 'move_to_proposal-workflow',
+    isAvailableFor: (deal: Parameters<typeof deriveActions>[0]) => deal.stage_key === 'interested'
+  },
+  {
+    key: 'move_to_closing',
+    label: 'Move to Closing',
+    workflowId: 'move_to_closing-workflow',
+    isAvailableFor: (deal: Parameters<typeof deriveActions>[0]) => deal.stage_key === 'proposal'
+  },
+  {
+    key: 'move_to_closed_won',
+    label: 'Close Won',
+    workflowId: 'move_to_closed_won-workflow',
+    isAvailableFor: (deal: Parameters<typeof deriveActions>[0]) => deal.stage_key === 'closing'
+  },
+  {
+    key: 'move_to_closed_lost',
+    label: 'Close Lost',
+    workflowId: 'move_to_closed_lost-workflow',
+    isAvailableFor: (deal: Parameters<typeof deriveActions>[0]) =>
+      deal.stage_key === 'interested' || deal.stage_key === 'proposal' || deal.stage_key === 'closing'
+  },
+  {
+    key: 'move_to_nurturing',
+    label: 'Move to Nurturing',
+    workflowId: 'move_to_nurturing-workflow',
+    isAvailableFor: (deal: Parameters<typeof deriveActions>[0]) =>
+      deal.stage_key === 'interested' || deal.stage_key === 'proposal' || deal.stage_key === 'closing'
+  },
+  {
+    key: 'send_link',
+    label: 'Send Booking Link',
+    workflowId: 'crm-send-booking-link-workflow',
+    isAvailableFor: (deal: Parameters<typeof deriveActions>[0]) =>
+      deal.stage_key === 'interested' && deal.state_key === 'discovery_replied'
+  },
+  {
+    key: 'send_nudge',
+    label: 'Send Nudge',
+    workflowId: 'crm-send-nudge-workflow',
+    isAvailableFor: (deal: Parameters<typeof deriveActions>[0]) =>
+      deal.stage_key === 'interested' &&
+      (deal.state_key === 'discovery_link_sent' || deal.state_key === 'discovery_nudging')
+  },
+  {
+    key: 'mark_no_show',
+    label: 'Mark No-Show',
+    workflowId: 'mark_no_show-workflow',
+    isAvailableFor: (deal: Parameters<typeof deriveActions>[0]) =>
+      deal.stage_key === 'interested' && deal.state_key === 'discovery_nudging'
+  },
+  {
+    key: 'rebook',
+    label: 'Rebook',
+    workflowId: 'crm-rebook-workflow',
+    isAvailableFor: (deal: Parameters<typeof deriveActions>[0]) =>
+      deal.stage_key === 'interested' && deal.state_key === 'discovery_booking_cancelled'
+  }
+]
+
+function deal(stageKey: string | null, stateKey: string | null = null): Parameters<typeof deriveActions>[0] {
+  return { stage_key: stageKey, state_key: stateKey } as Parameters<typeof deriveActions>[0]
+}
+
+describe('CRM deal action derivation', () => {
+  it('derives the exact base actions for interested deals from caller-supplied actions', () => {
+    expect(deriveActions(deal('interested'), CRM_ACTION_FIXTURE)).toEqual([
+      { key: 'move_to_proposal', label: 'Move to Proposal' },
+      { key: 'move_to_closed_lost', label: 'Close Lost' },
+      { key: 'move_to_nurturing', label: 'Move to Nurturing' }
+    ])
+  })
+
+  it('derives no actions unless the caller supplies an action catalog', () => {
+    expect(deriveActions(deal('interested'))).toEqual([])
+  })
+
+  it.each([
+    ['discovery_replied', { key: 'send_link', label: 'Send Booking Link' }],
+    ['discovery_link_sent', { key: 'send_nudge', label: 'Send Nudge' }],
+    ['discovery_booking_cancelled', { key: 'rebook', label: 'Rebook' }]
+  ] as const)('adds the expected workflow action for interested/%s', (stateKey, expectedAction) => {
+    expect(deriveActions(deal('interested', stateKey), CRM_ACTION_FIXTURE)).toContainEqual(expectedAction)
+  })
+
+  it('adds nudge and no-show actions for interested/discovery_nudging', () => {
+    expect(deriveActions(deal('interested', 'discovery_nudging'), CRM_ACTION_FIXTURE)).toEqual([
+      { key: 'move_to_proposal', label: 'Move to Proposal' },
+      { key: 'move_to_closed_lost', label: 'Close Lost' },
+      { key: 'move_to_nurturing', label: 'Move to Nurturing' },
+      { key: 'send_nudge', label: 'Send Nudge' },
+      { key: 'mark_no_show', label: 'Mark No-Show' }
+    ])
+  })
+})
+
+describe('ActivityEventSchema', () => {
+  const timestamp = '2026-04-27T12:34:56.000Z'
+
+  it.each([
+    [{ type: 'stage_change', timestamp, stageBefore: 'interested', stageAfter: 'proposal', reason: 'qualified' }],
+    [{ type: 'state_change', timestamp, stateBefore: null, stateAfter: 'discovery_replied' }],
+    [{ type: 'action_taken', timestamp, actionKey: 'send_link', payload: { channel: 'email' } }],
+    [{ type: 'approval_created', timestamp, commandId: 'cmd_123', dealStageBefore: 'proposal' }],
+    [{ type: 'approval_resolved', timestamp, commandId: 'cmd_123', resolution: 'superseded' }],
+    [{ type: 'approval_stale', timestamp, commandId: 'cmd_123', dealStageAfter: 'closing' }],
+    [{ type: 'task_created', timestamp, taskId: 'task_123' }],
+    [{ type: 'deal_created', timestamp }]
+  ])('accepts expected %s events', (event) => {
+    expect(ActivityEventSchema.safeParse(event).success).toBe(true)
+  })
+
+  it.each([
+    [{ type: 'deal_created', timestamp: 'not-a-date' }],
+    [{ type: 'unknown_event', timestamp }],
+    [{ type: 'stage_change', timestamp, stageBefore: 'interested' }],
+    [{ type: 'approval_resolved', timestamp, commandId: 'cmd_123', resolution: 'approved' }],
+    [{ type: 'booking_nudge_sent', timestamp, followupDay: '2' }],
+    [{ type: 'action_taken', timestamp }]
+  ])('rejects malformed event payload %o', (event) => {
+    expect(ActivityEventSchema.safeParse(event).success).toBe(false)
+  })
+})
+
+describe('CRM stage and transition vocabulary contracts', () => {
+  it('keeps DealStage and DealStageSchema aligned with a caller-owned CRM fixture', () => {
+    const crmStageKeys = CRM_PIPELINE_FIXTURE.stages.map((stage) => stage.stageKey)
+
+    expect(crmStageKeys).toEqual([...DEAL_STAGES])
+    for (const stageKey of crmStageKeys) {
+      expect(DealStageSchema.safeParse(stageKey).success).toBe(true)
+    }
+  })
+
+  it('accepts every fixture CRM deal stage in transition requests', () => {
+    for (const stageKey of DEAL_STAGES) {
+      expect(
+        TransitionItemRequestSchema.safeParse({
+          pipelineKey: CRM_PIPELINE_FIXTURE.pipelineKey,
+          stageKey,
+          stateKey: null,
+          expectedUpdatedAt: '2026-04-27T12:34:56.000Z'
+        }).success
+      ).toBe(true)
+    }
+  })
+
+  it('accepts canonical lead-gen stage/state pairs in transition requests', () => {
+    for (const pipelineDefinitions of Object.values(LEAD_GEN_PIPELINE_DEFINITIONS)) {
+      for (const pipeline of pipelineDefinitions) {
+        for (const stage of pipeline.stages) {
+          for (const state of stage.states) {
+            expect(
+              TransitionItemRequestSchema.safeParse({
+                pipelineKey: pipeline.pipelineKey,
+                stageKey: stage.stageKey,
+                stateKey: state.stateKey
+              }).success
+            ).toBe(true)
+          }
+        }
+      }
+    }
+  })
+})

package/src/business/acquisition/derive-actions.test.ts

@@ -1,7 +1,7 @@
 import { describe, expect, it } from 'vitest'
 import type { AcqDealRow } from './types'
 import type { Action, ActionDef } from './derive-actions'
-import { DEFAULT_CRM_ACTIONS, SendReplyActionPayloadSchema, deriveActions } from './derive-actions'
+import { SendReplyActionPayloadSchema, deriveActions as deriveActionsCore } from './derive-actions'
 
 // ---------------------------------------------------------------------------
 // Fixture builder
@@ -12,7 +12,7 @@ import { DEFAULT_CRM_ACTIONS, SendReplyActionPayloadSchema, deriveActions } from
  * Only stage_key and state_key affect availability logic; all other required
  * columns are filled with safe, inert defaults.
  */
-function makeDeal(
+function makeDeal(
   overrides: Partial<AcqDealRow> & { ownership?: 'us' | 'them' | null; nextAction?: string | null } = {}
 ): AcqDealRow & { ownership?: 'us' | 'them' | null; nextAction?: string | null } {
   return {
@@ -51,7 +51,85 @@ function makeDeal(
     updated_at: '2026-01-01T00:00:00.000Z',
     ...overrides
   }
-}
+}
+
+const DEFAULT_CRM_ACTIONS: ActionDef[] = [
+  {
+    key: 'move_to_proposal',
+    label: 'Move to Proposal',
+    workflowId: 'move_to_proposal-workflow',
+    isAvailableFor: (deal) => deal.stage_key === 'interested'
+  },
+  {
+    key: 'move_to_closing',
+    label: 'Move to Closing',
+    workflowId: 'move_to_closing-workflow',
+    isAvailableFor: (deal) => deal.stage_key === 'proposal'
+  },
+  {
+    key: 'move_to_closed_won',
+    label: 'Close Won',
+    workflowId: 'move_to_closed_won-workflow',
+    isAvailableFor: (deal) => deal.stage_key === 'closing'
+  },
+  {
+    key: 'move_to_closed_lost',
+    label: 'Close Lost',
+    workflowId: 'move_to_closed_lost-workflow',
+    isAvailableFor: (deal) =>
+      deal.stage_key === 'interested' || deal.stage_key === 'proposal' || deal.stage_key === 'closing'
+  },
+  {
+    key: 'move_to_nurturing',
+    label: 'Move to Nurturing',
+    workflowId: 'move_to_nurturing-workflow',
+    isAvailableFor: (deal) =>
+      deal.stage_key === 'interested' || deal.stage_key === 'proposal' || deal.stage_key === 'closing'
+  },
+  {
+    key: 'send_reply',
+    label: 'Send Reply',
+    workflowId: 'crm-send-reply-workflow',
+    payloadSchema: SendReplyActionPayloadSchema,
+    isAvailableFor: (deal) =>
+      deal.stage_key === 'interested' &&
+      deal.nextAction === 'send_reply' &&
+      (deal.state_key === 'discovery_replied' ||
+        deal.state_key === 'discovery_link_sent' ||
+        deal.state_key === 'discovery_nudging')
+  },
+  {
+    key: 'send_link',
+    label: 'Send Booking Link',
+    workflowId: 'crm-send-booking-link-workflow',
+    isAvailableFor: (deal) => deal.stage_key === 'interested' && deal.state_key === 'discovery_replied'
+  },
+  {
+    key: 'send_nudge',
+    label: 'Send Nudge',
+    workflowId: 'crm-send-nudge-workflow',
+    isAvailableFor: (deal) =>
+      deal.stage_key === 'interested' &&
+      (deal.state_key === 'discovery_link_sent' || deal.state_key === 'discovery_nudging')
+  },
+  {
+    key: 'mark_no_show',
+    label: 'Mark No-Show',
+    workflowId: 'mark_no_show-workflow',
+    isAvailableFor: (deal) => deal.stage_key === 'interested' && deal.state_key === 'discovery_nudging'
+  },
+  {
+    key: 'rebook',
+    label: 'Rebook',
+    workflowId: 'crm-rebook-workflow',
+    isAvailableFor: (deal) =>
+      deal.stage_key === 'interested' && deal.state_key === 'discovery_booking_cancelled'
+  }
+]
+
+function deriveActions(deal: Parameters<typeof deriveActionsCore>[0], actions: ActionDef[] = DEFAULT_CRM_ACTIONS): Action[] {
+  return deriveActionsCore(deal, actions)
+}
 
 // ---------------------------------------------------------------------------
 // DEFAULT_CRM_ACTIONS static contract
@@ -321,11 +399,9 @@ describe('deriveActions()', () => {
     expect(deriveActions(makeDeal({ stage_key: 'interested' }), [])).toEqual([])
   })
 
-  it('uses DEFAULT_CRM_ACTIONS when no second argument is provided', () => {
-    const withDefaults = deriveActions(makeDeal({ stage_key: 'proposal' }))
-    const withExplicit = deriveActions(makeDeal({ stage_key: 'proposal' }), DEFAULT_CRM_ACTIONS)
-    expect(withDefaults).toEqual(withExplicit)
-  })
+  it('core deriveActions returns [] when no action catalog is provided', () => {
+    expect(deriveActionsCore(makeDeal({ stage_key: 'proposal' }))).toEqual([])
+  })
 })
 
 // ---------------------------------------------------------------------------
@@ -514,11 +590,12 @@ describe('deriveActions() — multi-state discovery path coverage', () => {
 describe('deriveActions() - ownership-gated reply action', () => {
   it('lead asks us to respond: send_reply is available and ownership is our move', () => {
     const actions = deriveActions(
-      makeDeal({
-        stage_key: 'interested',
-        state_key: 'discovery_replied',
-        activity_log: [{ type: 'reply_received', timestamp: '2026-01-10T10:00:00Z' }]
-      })
+      makeDeal({
+        stage_key: 'interested',
+        state_key: 'discovery_replied',
+        nextAction: 'send_reply',
+        activity_log: [{ type: 'reply_received', timestamp: '2026-01-10T10:00:00Z' }]
+      })
     )
 
     expect(actions).toContainEqual({ key: 'send_reply', label: 'Send Reply', payloadSchema: SendReplyActionPayloadSchema })