@elevasis/core 0.21.0 → 0.23.0

package/src/organization-model/__tests__/defaults.test.ts

@@ -1,25 +1,22 @@
 import { describe, expect, it } from 'vitest'
 import { DEFAULT_ORGANIZATION_MODEL } from '../defaults'
-import { DEFAULT_ORGANIZATION_MODEL_BRANDING } from '../domains/branding'
-import { OrganizationModelBrandingSchema } from '../domains/branding'
-import { DEFAULT_ORGANIZATION_MODEL_SALES } from '../domains/sales'
-import { OrganizationModelSalesSchema } from '../domains/sales'
-import { DEFAULT_ORGANIZATION_MODEL_PROJECTS } from '../domains/projects'
-import { OrganizationModelProjectsSchema } from '../domains/projects'
-import { DEFAULT_ORGANIZATION_MODEL_PROSPECTING } from '../domains/prospecting'
-import { OrganizationModelProspectingSchema } from '../domains/prospecting'
-import { DEFAULT_ORGANIZATION_MODEL_NAVIGATION } from '../domains/navigation'
-import { OrganizationModelNavigationSchema } from '../domains/navigation'
-import { DEFAULT_ORGANIZATION_MODEL_OPERATIONS } from '../domains/operations'
-import { OperationsDomainSchema } from '../domains/operations'
-import { DEFAULT_ORGANIZATION_MODEL_STATUSES } from '../domains/statuses'
-import { StatusesDomainSchema } from '../domains/statuses'
+import { DEFAULT_ORGANIZATION_MODEL_BRANDING, OrganizationModelBrandingSchema } from '../domains/branding'
+import { DEFAULT_ORGANIZATION_MODEL_ENTITIES, EntitiesDomainSchema } from '../domains/entities'
+import { DEFAULT_ORGANIZATION_MODEL_STATUSES, StatusesDomainSchema } from '../domains/statuses'
+import { DEFAULT_ORGANIZATION_MODEL_SYSTEMS, SystemsDomainSchema } from '../domains/systems'
 import { resolveOrganizationModel } from '../resolve'
 import { OrganizationModelSchema } from '../schema'
+import { DEFAULT_ORGANIZATION_MODEL_KNOWLEDGE } from '../defaults'
 
-// All DEFAULT_ORGANIZATION_MODEL* constants and the schemas used to validate them.
-// The composite constant lives in defaults.ts; domain sub-constants live in their
-// respective domain files. All are covered here for roundtrip integrity.
+// Phase 4 (D8): sales, prospecting, projects, navigation top-level OM fields removed.
+// DEFAULT_ORGANIZATION_MODEL_SALES / OrganizationModelSalesSchema,
+// DEFAULT_ORGANIZATION_MODEL_PROJECTS / OrganizationModelProjectsSchema,
+// DEFAULT_ORGANIZATION_MODEL_PROSPECTING / OrganizationModelProspectingSchema,
+// DEFAULT_ORGANIZATION_MODEL_NAVIGATION / OrganizationModelNavigationSchema
+// are no longer exported from their respective domain files.
+// Tests that depended on these exports are skipped with explicit reason comments.
+
+// Only the domain constants and schemas that still exist are covered here.
 const domainCases = [
   {
     name: 'DEFAULT_ORGANIZATION_MODEL_BRANDING',
@@ -27,24 +24,9 @@ const domainCases = [
     schema: OrganizationModelBrandingSchema
   },
   {
-    name: 'DEFAULT_ORGANIZATION_MODEL_SALES',
-    constant: DEFAULT_ORGANIZATION_MODEL_SALES,
-    schema: OrganizationModelSalesSchema
-  },
-  {
-    name: 'DEFAULT_ORGANIZATION_MODEL_PROJECTS',
-    constant: DEFAULT_ORGANIZATION_MODEL_PROJECTS,
-    schema: OrganizationModelProjectsSchema
-  },
-  {
-    name: 'DEFAULT_ORGANIZATION_MODEL_PROSPECTING',
-    constant: DEFAULT_ORGANIZATION_MODEL_PROSPECTING,
-    schema: OrganizationModelProspectingSchema
-  },
-  {
-    name: 'DEFAULT_ORGANIZATION_MODEL_NAVIGATION',
-    constant: DEFAULT_ORGANIZATION_MODEL_NAVIGATION,
-    schema: OrganizationModelNavigationSchema
+    name: 'DEFAULT_ORGANIZATION_MODEL_ENTITIES',
+    constant: DEFAULT_ORGANIZATION_MODEL_ENTITIES,
+    schema: EntitiesDomainSchema
   },
   {
     name: 'DEFAULT_ORGANIZATION_MODEL_STATUSES',
@@ -52,9 +34,9 @@ const domainCases = [
     schema: StatusesDomainSchema
   },
   {
-    name: 'DEFAULT_ORGANIZATION_MODEL_OPERATIONS',
-    constant: DEFAULT_ORGANIZATION_MODEL_OPERATIONS,
-    schema: OperationsDomainSchema
+    name: 'DEFAULT_ORGANIZATION_MODEL_SYSTEMS',
+    constant: DEFAULT_ORGANIZATION_MODEL_SYSTEMS,
+    schema: SystemsDomainSchema
   }
 ] as const
 
@@ -75,17 +57,14 @@ describe('organization-model defaults', () => {
       expect(fromDefault).toEqual(fromUndefined)
     })
 
-    it('keeps Command View enabled but development-only in the default Knowledge navigation', () => {
-      const result = resolveOrganizationModel(undefined)
-      const commandViewFeature = result.features.find((feature) => feature.id === 'knowledge.command-view')
-      const commandViewSurface = DEFAULT_ORGANIZATION_MODEL_NAVIGATION.surfaces.find(
-        (surface) => surface.id === 'knowledge.command-view'
-      )
-
-      expect(commandViewFeature?.enabled).toBe(true)
-      expect(commandViewFeature?.devOnly).toBe(true)
-      expect(commandViewSurface?.enabled).toBe(true)
-      expect(commandViewSurface?.devOnly).toBe(true)
+    // Phase 4 (D8): model.navigation removed. The knowledge.command-view surface tracking
+    // previously used DEFAULT_ORGANIZATION_MODEL_NAVIGATION.surfaces — skipped since that
+    // constant is deleted. The system itself still exists; only the navigation surface
+    // reference is gone from the top-level schema.
+    it.skip('keeps Command View enabled but development-only in the default Knowledge navigation (deferred — Phase 4: navigation domain removed)', () => {
+      // Previously checked DEFAULT_ORGANIZATION_MODEL_NAVIGATION.surfaces.
+      // The command-view system still exists in DEFAULT_ORGANIZATION_MODEL.systems.
+      // Re-enable with a top-level surfaces Record fixture if that assertion is needed.
     })
   })
 
@@ -95,84 +74,71 @@ describe('organization-model defaults', () => {
     })
   })
 
-  describe('DEFAULT_ORGANIZATION_MODEL_BRANDING via resolveOrganizationModel', () => {
-    it('resolving with branding override produces a schema-valid model', () => {
-      const result = resolveOrganizationModel({ branding: DEFAULT_ORGANIZATION_MODEL_BRANDING })
-      expect(() => OrganizationModelSchema.parse(result)).not.toThrow()
-    })
-  })
-
-  describe('DEFAULT_ORGANIZATION_MODEL_SALES via resolveOrganizationModel', () => {
+  // Phase 4 (D8): OrganizationModelSalesSchema, DEFAULT_ORGANIZATION_MODEL_SALES removed.
+  describe.skip('DEFAULT_ORGANIZATION_MODEL_SALES via resolveOrganizationModel (deferred — Phase 4: sales domain removed)', () => {
     it('resolving with sales override produces a schema-valid model', () => {
-      const result = resolveOrganizationModel({ sales: DEFAULT_ORGANIZATION_MODEL_SALES })
-      expect(() => OrganizationModelSchema.parse(result)).not.toThrow()
+      // Previously: resolveOrganizationModel({ sales: DEFAULT_ORGANIZATION_MODEL_SALES })
+      // Sales data now lives in system.content. Use getAllPipelines(model) from migration-helpers.
     })
   })
 
-  describe('DEFAULT_ORGANIZATION_MODEL_PROJECTS via resolveOrganizationModel', () => {
+  // Phase 4 (D8): OrganizationModelProjectsSchema, DEFAULT_ORGANIZATION_MODEL_PROJECTS removed.
+  describe.skip('DEFAULT_ORGANIZATION_MODEL_PROJECTS via resolveOrganizationModel (deferred — Phase 4: projects domain removed)', () => {
     it('resolving with projects override produces a schema-valid model', () => {
-      const result = resolveOrganizationModel({ projects: DEFAULT_ORGANIZATION_MODEL_PROJECTS })
-      expect(() => OrganizationModelSchema.parse(result)).not.toThrow()
+      // Previously: resolveOrganizationModel({ projects: DEFAULT_ORGANIZATION_MODEL_PROJECTS })
+      // Project statuses now live in system.content. Use getAllProjectStatuses(model) from migration-helpers.
     })
   })
 
-  describe('DEFAULT_ORGANIZATION_MODEL_PROSPECTING via resolveOrganizationModel', () => {
+  // Phase 4 (D8): OrganizationModelProspectingSchema, DEFAULT_ORGANIZATION_MODEL_PROSPECTING removed.
+  describe.skip('DEFAULT_ORGANIZATION_MODEL_PROSPECTING via resolveOrganizationModel (deferred — Phase 4: prospecting domain removed)', () => {
     it('resolving with prospecting override produces a schema-valid model', () => {
-      const result = resolveOrganizationModel({ prospecting: DEFAULT_ORGANIZATION_MODEL_PROSPECTING })
-      expect(() => OrganizationModelSchema.parse(result)).not.toThrow()
+      // Previously: resolveOrganizationModel({ prospecting: DEFAULT_ORGANIZATION_MODEL_PROSPECTING })
+      // Prospecting stages/templates now live in system.content. Use getAllProspectingStages() / getAllBuildTemplates().
     })
   })
 
-  describe('DEFAULT_ORGANIZATION_MODEL_NAVIGATION via resolveOrganizationModel', () => {
+  // Phase 4 (D8): OrganizationModelNavigationSchema, DEFAULT_ORGANIZATION_MODEL_NAVIGATION removed.
+  describe.skip('DEFAULT_ORGANIZATION_MODEL_NAVIGATION via resolveOrganizationModel (deferred — Phase 4: navigation domain removed)', () => {
     it('resolving with navigation override produces a schema-valid model', () => {
-      const result = resolveOrganizationModel({ navigation: DEFAULT_ORGANIZATION_MODEL_NAVIGATION })
-      expect(() => OrganizationModelSchema.parse(result)).not.toThrow()
+      // Previously: resolveOrganizationModel({ navigation: DEFAULT_ORGANIZATION_MODEL_NAVIGATION })
+      // Surfaces and navigation groups are now top-level Records on OrganizationModelSchemaBase.
     })
   })
 
-  describe('DEFAULT_ORGANIZATION_MODEL_OPERATIONS via resolveOrganizationModel', () => {
-    it('resolving with operations override produces a schema-valid model', () => {
-      const result = resolveOrganizationModel({ operations: DEFAULT_ORGANIZATION_MODEL_OPERATIONS })
+  describe('DEFAULT_ORGANIZATION_MODEL_BRANDING via resolveOrganizationModel', () => {
+    it('resolving with branding override produces a schema-valid model', () => {
+      const result = resolveOrganizationModel({ branding: DEFAULT_ORGANIZATION_MODEL_BRANDING })
       expect(() => OrganizationModelSchema.parse(result)).not.toThrow()
     })
-
-    it('default operations seed covers all 5 entity categories', () => {
-      expect(DEFAULT_ORGANIZATION_MODEL_OPERATIONS.entries).toHaveLength(5)
-    })
-
-    it('every entry has a non-empty id, label, and semanticClass', () => {
-      for (const entry of DEFAULT_ORGANIZATION_MODEL_OPERATIONS.entries) {
-        expect(entry.id.length).toBeGreaterThan(0)
-        expect(entry.label.length).toBeGreaterThan(0)
-        expect(entry.semanticClass.length).toBeGreaterThan(0)
-      }
-    })
-
-    it('all entry ids are unique', () => {
-      const ids = DEFAULT_ORGANIZATION_MODEL_OPERATIONS.entries.map((e) => e.id)
-      const uniqueIds = new Set(ids)
-      expect(uniqueIds.size).toBe(ids.length)
-    })
   })
 
   describe('DEFAULT_ORGANIZATION_MODEL_STATUSES via resolveOrganizationModel', () => {
-    it('resolving with statuses override produces a schema-valid model', () => {
-      const result = resolveOrganizationModel({ statuses: DEFAULT_ORGANIZATION_MODEL_STATUSES })
-      expect(() => OrganizationModelSchema.parse(result)).not.toThrow()
+    // Phase 4 (D1): statuses top-level field removed from OM schema.
+    // DEFAULT_ORGANIZATION_MODEL_STATUSES is still exported from domains/statuses.ts
+    // (it's used by the UI statuses domain as a semantic registry, not OM-schema-level data).
+    // The resolveOrganizationModel override with { statuses: ... } was silently accepted
+    // before Phase 4 because statuses was an extra field; now statuses is gone from OM entirely.
+    // We keep the data-integrity checks below; the resolveOrganizationModel override test is skipped.
+    it.skip('resolving with statuses override produces a schema-valid model (deferred — Phase 4: statuses field removed from OM schema)', () => {
+      // Previously: resolveOrganizationModel({ statuses: DEFAULT_ORGANIZATION_MODEL_STATUSES })
+      // Status data now lives in system.content via (schema:status-flow) + (schema:status) content nodes.
     })
 
     it('default statuses seed covers all 9 delivery.task values', () => {
-      const taskEntries = DEFAULT_ORGANIZATION_MODEL_STATUSES.entries.filter((e) => e.semanticClass === 'delivery.task')
+      const taskEntries = Object.values(DEFAULT_ORGANIZATION_MODEL_STATUSES).filter(
+        (e) => e.semanticClass === 'delivery.task'
+      )
       expect(taskEntries).toHaveLength(9)
     })
 
     it('default statuses seed covers all 5 queue values', () => {
-      const queueEntries = DEFAULT_ORGANIZATION_MODEL_STATUSES.entries.filter((e) => e.semanticClass === 'queue')
+      const queueEntries = Object.values(DEFAULT_ORGANIZATION_MODEL_STATUSES).filter((e) => e.semanticClass === 'queue')
       expect(queueEntries).toHaveLength(5)
     })
 
     it('every entry has a non-empty id, label, and semanticClass', () => {
-      for (const entry of DEFAULT_ORGANIZATION_MODEL_STATUSES.entries) {
+      for (const entry of Object.values(DEFAULT_ORGANIZATION_MODEL_STATUSES)) {
         expect(entry.id.length).toBeGreaterThan(0)
         expect(entry.label.length).toBeGreaterThan(0)
         expect(entry.semanticClass.length).toBeGreaterThan(0)
@@ -180,9 +146,23 @@ describe('organization-model defaults', () => {
     })
 
     it('all entry ids are unique', () => {
-      const ids = DEFAULT_ORGANIZATION_MODEL_STATUSES.entries.map((e) => e.id)
+      const ids = Object.values(DEFAULT_ORGANIZATION_MODEL_STATUSES).map((e) => e.id)
       const uniqueIds = new Set(ids)
       expect(uniqueIds.size).toBe(ids.length)
     })
   })
+
+  describe('DEFAULT_ORGANIZATION_MODEL_KNOWLEDGE — flat Record (Phase 4 D3)', () => {
+    it('is an empty object (no pre-seeded nodes in generic base)', () => {
+      expect(DEFAULT_ORGANIZATION_MODEL_KNOWLEDGE).toEqual({})
+    })
+
+    it('does not have a .nodes array (old wrapper shape removed)', () => {
+      expect(DEFAULT_ORGANIZATION_MODEL_KNOWLEDGE).not.toHaveProperty('nodes')
+    })
+
+    it('does not have a .version field (moved to domainMetadata.knowledge)', () => {
+      expect(DEFAULT_ORGANIZATION_MODEL_KNOWLEDGE).not.toHaveProperty('version')
+    })
+  })
 })

package/src/organization-model/__tests__/domains/actions.test.ts

@@ -0,0 +1,56 @@
+import { describe, expect, it } from 'vitest'
+import { ActionsDomainSchema, ActionInvocationSchema, DEFAULT_ORGANIZATION_MODEL_ACTIONS } from '../../domains/actions'
+
+describe('actions domain', () => {
+  it('defaults lead-gen action entries with invocation contracts', () => {
+    const domain = ActionsDomainSchema.parse(DEFAULT_ORGANIZATION_MODEL_ACTIONS)
+
+    expect(Object.keys(domain)).toHaveLength(13)
+    expect(domain['lead-gen.company.source']).toMatchObject({
+      id: 'lead-gen.company.source',
+      scope: { domain: 'sales' },
+      lifecycle: 'active'
+    })
+    expect(Object.values(domain).every((action) => action.invocations.length > 0)).toBe(true)
+  })
+
+  it('accepts entity references in affects', () => {
+    expect(() =>
+      ActionsDomainSchema.parse({
+        'crm.deal.update': {
+          id: 'crm.deal.update',
+          order: 10,
+          label: 'Update deal',
+          affects: ['crm.deal']
+        }
+      })
+    ).not.toThrow()
+  })
+
+  it('accepts every invocation kind', () => {
+    expect(() =>
+      ActionInvocationSchema.parse({
+        kind: 'slash-command',
+        command: '/lead-gen source',
+        toolFactory: 'lead-gen-source'
+      })
+    ).not.toThrow()
+    expect(() => ActionInvocationSchema.parse({ kind: 'mcp-tool', server: 'lead-gen', name: 'source' })).not.toThrow()
+    expect(() =>
+      ActionInvocationSchema.parse({
+        kind: 'api-endpoint',
+        method: 'POST',
+        path: '/api/prospecting/source',
+        requestSchema: 'source-request',
+        responseSchema: 'source-response'
+      })
+    ).not.toThrow()
+    expect(() =>
+      ActionInvocationSchema.parse({ kind: 'script-execution', resourceId: 'scripts.lead-gen-source' })
+    ).not.toThrow()
+  })
+
+  it('rejects malformed slash commands', () => {
+    expect(() => ActionInvocationSchema.parse({ kind: 'slash-command', command: 'lead-gen source' })).toThrow()
+  })
+})