@elementor/editor-controls 0.21.0 → 0.24.0

package/package.json

@@ -1,7 +1,7 @@
 {
   "name": "@elementor/editor-controls",
   "description": "This package contains the controls model and utils for the Elementor editor",
-  "version": "0.21.0",
+  "version": "0.24.0",
   "private": false,
   "author": "Elementor Team",
   "homepage": "https://elementor.com/",
@@ -41,9 +41,9 @@
   },
   "dependencies": {
     "@elementor/editor-current-user": "0.3.0",
-    "@elementor/editor-elements": "0.7.0",
+    "@elementor/editor-elements": "0.8.0",
     "@elementor/editor-props": "0.11.1",
-    "@elementor/editor-ui": "0.5.1",
+    "@elementor/editor-ui": "0.7.0",
     "@elementor/env": "0.3.5",
     "@elementor/http": "0.1.4",
     "@elementor/icons": "1.37.0",

package/src/components/repeater.tsx

@@ -48,6 +48,8 @@ type RepeaterProps< T > = {
 	};
 };
 
+const EMPTY_OPEN_ITEM = -1;
+
 export const Repeater = < T, >( {
 	label,
 	itemSettings,
@@ -56,7 +58,7 @@ export const Repeater = < T, >( {
 	values: repeaterValues = [],
 	setValues: setRepeaterValues,
 }: RepeaterProps< Item< T > > ) => {
-	const [ openItem, setOpenItem ] = useState( -1 );
+	const [ openItem, setOpenItem ] = useState( EMPTY_OPEN_ITEM );
 
 	const [ items, setItems ] = useSyncExternalState( {
 		external: repeaterValues,
@@ -166,7 +168,6 @@ export const Repeater = < T, >( {
 						return (
 							<SortableItem id={ key } key={ `sortable-${ key }` }>
 								<RepeaterItem
-									bind={ String( index ) }
 									disabled={ value?.disabled }
 									label={ <itemSettings.Label value={ value } /> }
 									startIcon={ <itemSettings.Icon value={ value } /> }
@@ -174,6 +175,7 @@ export const Repeater = < T, >( {
 									duplicateItem={ () => duplicateRepeaterItem( index ) }
 									toggleDisableItem={ () => toggleDisableRepeaterItem( index ) }
 									openOnMount={ openOnAdd && openItem === key }
+									onOpen={ () => setOpenItem( EMPTY_OPEN_ITEM ) }
 								>
 									{ ( props ) => (
 										<itemSettings.Content { ...props } value={ value } bind={ String( index ) } />
@@ -190,7 +192,6 @@ export const Repeater = < T, >( {
 
 type RepeaterItemProps = {
 	label: React.ReactNode;
-	bind: string;
 	disabled?: boolean;
 	startIcon: UnstableTagProps[ 'startIcon' ];
 	removeItem: () => void;
@@ -198,6 +199,7 @@ type RepeaterItemProps = {
 	toggleDisableItem: () => void;
 	children: ( { anchorEl }: { anchorEl: AnchorEl } ) => React.ReactNode;
 	openOnMount: boolean;
+	onOpen: () => void;
 };
 
 const RepeaterItem = ( {
@@ -209,9 +211,10 @@ const RepeaterItem = ( {
 	duplicateItem,
 	toggleDisableItem,
 	openOnMount,
+	onOpen,
 }: RepeaterItemProps ) => {
 	const [ anchorEl, setAnchorEl ] = useState< AnchorEl >( null );
-	const { popoverState, popoverProps, ref, setRef } = usePopover( openOnMount );
+	const { popoverState, popoverProps, ref, setRef } = usePopover( openOnMount, onOpen );
 
 	const duplicateLabel = __( 'Duplicate', 'elementor' );
 	const toggleLabel = disabled ? __( 'Show', 'elementor' ) : __( 'Hide', 'elementor' );
@@ -247,7 +250,6 @@ const RepeaterItem = ( {
 						</Tooltip>
 					</>
 				}
-				sx={ { backgroundColor: 'background.paper' } }
 			/>
 			<Popover
 				disablePortal
@@ -267,7 +269,7 @@ const RepeaterItem = ( {
 	);
 };
 
-const usePopover = ( openOnMount: boolean ) => {
+const usePopover = ( openOnMount: boolean, onOpen: () => void ) => {
 	const [ ref, setRef ] = useState< HTMLElement | null >( null );
 
 	const popoverState = usePopupState( { variant: 'popover' } );
@@ -277,6 +279,7 @@ const usePopover = ( openOnMount: boolean ) => {
 	useEffect( () => {
 		if ( openOnMount && ref ) {
 			popoverState.open( ref );
+			onOpen?.();
 		}
 		// eslint-disable-next-line react-compiler/react-compiler
 		// eslint-disable-next-line react-hooks/exhaustive-deps

package/src/components/sortable.tsx

@@ -34,16 +34,11 @@ export const SortableItem = ( { id, children }: SortableItemProps ): React.React
 				triggerProps,
 				itemStyle,
 				triggerStyle,
-				isDragOverlay,
 				showDropIndication,
 				dropIndicationStyle,
 			}: UnstableSortableItemRenderProps ) => {
 				return (
-					<StyledListItem
-						{ ...itemProps }
-						style={ itemStyle }
-						sx={ { backgroundColor: isDragOverlay ? 'background.paper' : undefined } }
-					>
+					<StyledListItem { ...itemProps } style={ itemStyle }>
 						<SortableTrigger { ...triggerProps } style={ triggerStyle } />
 						{ children }
 						{ showDropIndication && <StyledDivider style={ dropIndicationStyle } /> }
@@ -72,6 +67,11 @@ const StyledListItem = styled( ListItem )`
 		transform: translate( -75%, -50% );
 	}
 
+	&[aria-describedby=''] > .MuiTag-root {
+		background-color: ${ ( { theme } ) => theme.palette.background.paper };
+		box-shadow: ${ ( { theme } ) => theme.shadows[ 3 ] };
+	}
+
 	&:hover {
 		& .class-item-sortable-trigger {
 			visibility: visible;

package/src/components/text-field-inner-selection.tsx

@@ -58,11 +58,11 @@ export const SelectionEndAdornment = < T extends string >( {
 		<InputAdornment position="end">
 			<Button
 				size="small"
-				color="inherit"
-				sx={ { font: 'inherit', minWidth: 'initial' } }
+				color="secondary"
+				sx={ { font: 'inherit', minWidth: 'initial', textTransform: 'uppercase' } }
 				{ ...bindTrigger( popupState ) }
 			>
-				{ value.toUpperCase() }
+				{ value }
 			</Button>
 
 			<Menu MenuListProps={ { dense: true } } { ...bindMenu( popupState ) }>

package/src/controls/background-control/background-overlay/background-overlay-repeater-control.tsx

@@ -271,7 +271,7 @@ const useImage = ( image: BackgroundImageOverlay ) => {
 	const { data: attachment } = useWpMediaAttachment( imageSrc.id?.value || null );
 
 	if ( imageSrc.id ) {
-		const imageFileTypeExtension = attachment?.subtype ? `.${ attachment.subtype }` : '';
+		const imageFileTypeExtension = getFileExtensionFromFilename( attachment?.filename );
 		imageTitle = `${ attachment?.title }${ imageFileTypeExtension }` || null;
 		imageUrl = attachment?.url || null;
 	} else if ( imageSrc.url ) {
@@ -282,6 +282,17 @@ const useImage = ( image: BackgroundImageOverlay ) => {
 	return { imageTitle, imageUrl };
 };
 
+const getFileExtensionFromFilename = ( filename?: string ) => {
+	if ( ! filename ) {
+		return '';
+	}
+
+	// get the substring after the last . in the filename
+	const extension = filename.substring( filename.lastIndexOf( '.' ) + 1 );
+
+	return `.${ extension }`;
+};
+
 const getGradientValue = ( value: BackgroundOverlayItemPropValue ) => {
 	const gradient = value.value;
 

package/src/controls/font-family-control/font-family-control.tsx

@@ -280,6 +280,8 @@ const StyledMenuList = styled( MenuList )( ( { theme } ) => ( {
 		top: 0,
 		left: 0,
 		width: '100%',
+		display: 'flex',
+		alignItems: 'center',
 	},
 	'& > [role="option"]': {
 		...theme.typography.caption,

package/src/controls/link-control.tsx

@@ -1,6 +1,6 @@
 import * as React from 'react';
-import { useMemo, useState } from 'react';
-import { getAncestorWithAnchorTag, getDescendantWithAnchorTag } from '@elementor/editor-elements';
+import { type PropsWithChildren, useMemo, useState } from 'react';
+import { getLinkInLinkRestriction, type LinkInLinkRestriction, selectElement } from '@elementor/editor-elements';
 import {
 	booleanPropTypeUtil,
 	linkPropTypeUtil,
@@ -9,10 +9,11 @@ import {
 	stringPropTypeUtil,
 	urlPropTypeUtil,
 } from '@elementor/editor-props';
+import { InfoTipCard } from '@elementor/editor-ui';
 import { type HttpResponse, httpService } from '@elementor/http';
-import { MinusIcon, PlusIcon } from '@elementor/icons';
+import { AlertTriangleIcon, MinusIcon, PlusIcon } from '@elementor/icons';
 import { useSessionStorage } from '@elementor/session';
-import { Collapse, Divider, Grid, IconButton, Stack, Switch } from '@elementor/ui';
+import { Box, Collapse, Divider, Grid, IconButton, Infotip, Stack, Switch } from '@elementor/ui';
 import { debounce } from '@elementor/utils';
 import { __ } from '@wordpress/i18n';
 
@@ -49,11 +50,15 @@ type LinkSessionValue = {
 type Response = HttpResponse< { value: FlatOption[] | CategorizedOption[] } >;
 
 const SIZE = 'tiny';
+const learnMoreButton = {
+	label: __( 'Learn More', 'elementor' ),
+	href: 'https://go.elementor.com/element-link-inside-link-infotip',
+};
 
 export const LinkControl = createControl( ( props: Props ) => {
 	const { value, path, setValue, ...propContext } = useBoundProp( linkPropTypeUtil );
 	const [ linkSessionValue, setLinkSessionValue ] = useSessionStorage< LinkSessionValue >( path.join( '/' ) );
-	const [ isEnabled, setIsEnabled ] = useState( !! value );
+	const [ isActive, setIsActive ] = useState( !! value );
 
 	const {
 		allowCustomValues,
@@ -63,20 +68,22 @@ export const LinkControl = createControl( ( props: Props ) => {
 		context: { elementId },
 	} = props || {};
 
+	const [ linkInLinkRestriction, setLinkInLinkRestriction ] = useState( getLinkInLinkRestriction( elementId ) );
 	const [ options, setOptions ] = useState< FlatOption[] | CategorizedOption[] >(
 		generateFirstLoadedOption( value )
 	);
+	const shouldDisableAddingLink = ! isActive && linkInLinkRestriction.shouldRestrict;
 
 	const onEnabledChange = () => {
-		const shouldRestrict = getAncestorWithAnchorTag( elementId ) || getDescendantWithAnchorTag( elementId );
+		setLinkInLinkRestriction( getLinkInLinkRestriction( elementId ) );
 
-		if ( shouldRestrict && ! isEnabled ) {
+		if ( linkInLinkRestriction.shouldRestrict && ! isActive ) {
 			return;
 		}
 
-		setIsEnabled( ( prevState ) => ! prevState );
-		setValue( isEnabled ? null : linkSessionValue?.value ?? null );
-		setLinkSessionValue( { value, meta: { isEnabled: ! isEnabled } } );
+		setIsActive( ( prevState ) => ! prevState );
+		setValue( isActive ? null : linkSessionValue?.value ?? null );
+		setLinkSessionValue( { value, meta: { isEnabled: ! isActive } } );
 	};
 
 	const onOptionChange = ( newValue: number | null ) => {
@@ -145,13 +152,16 @@ export const LinkControl = createControl( ( props: Props ) => {
 					} }
 				>
 					<ControlFormLabel>{ __( 'Link', 'elementor' ) }</ControlFormLabel>
-					<ToggleIconControl
-						enabled={ isEnabled }
-						onIconClick={ onEnabledChange }
-						label={ __( 'Toggle link', 'elementor' ) }
-					/>
+					<ConditionalInfoTip isVisible={ ! isActive } linkInLinkRestriction={ linkInLinkRestriction }>
+						<ToggleIconControl
+							disabled={ shouldDisableAddingLink }
+							active={ isActive }
+							onIconClick={ onEnabledChange }
+							label={ __( 'Toggle link', 'elementor' ) }
+						/>
+					</ConditionalInfoTip>
 				</Stack>
-				<Collapse in={ isEnabled } timeout="auto" unmountOnExit>
+				<Collapse in={ isActive } timeout="auto" unmountOnExit>
 					<Stack gap={ 1.5 }>
 						<PropKeyProvider bind={ 'destination' }>
 							<ControlActions>
@@ -167,7 +177,7 @@ export const LinkControl = createControl( ( props: Props ) => {
 							</ControlActions>
 						</PropKeyProvider>
 						<PropKeyProvider bind={ 'isTargetBlank' }>
-							<SwitchControl />
+							<SwitchControl disabled={ ! value } />
 						</PropKeyProvider>
 					</Stack>
 				</Collapse>
@@ -177,34 +187,43 @@ export const LinkControl = createControl( ( props: Props ) => {
 } );
 
 type ToggleIconControlProps = {
-	enabled: boolean;
+	disabled: boolean;
+	active: boolean;
 	onIconClick: () => void;
 	label?: string;
 };
 
-const ToggleIconControl = ( { enabled, onIconClick, label }: ToggleIconControlProps ) => {
+const ToggleIconControl = ( { disabled, active, onIconClick, label }: ToggleIconControlProps ) => {
 	return (
-		<IconButton size={ SIZE } onClick={ onIconClick } aria-label={ label }>
-			{ enabled ? <MinusIcon fontSize={ SIZE } /> : <PlusIcon fontSize={ SIZE } /> }
+		<IconButton size={ SIZE } onClick={ onIconClick } aria-label={ label } disabled={ disabled }>
+			{ active ? <MinusIcon fontSize={ SIZE } /> : <PlusIcon fontSize={ SIZE } /> }
 		</IconButton>
 	);
 };
 
 // @TODO Should be refactored in ED-16323
-const SwitchControl = () => {
+const SwitchControl = ( { disabled }: { disabled: boolean } ) => {
 	const { value = false, setValue } = useBoundProp( booleanPropTypeUtil );
 
 	const onClick = () => {
 		setValue( ! value );
 	};
 
+	const inputProps = disabled
+		? {
+				style: {
+					opacity: 0,
+				},
+		  }
+		: {};
+
 	return (
 		<Grid container alignItems="center" flexWrap="nowrap" justifyContent="space-between">
 			<Grid item>
 				<ControlFormLabel>{ __( 'Open in a new tab', 'elementor' ) }</ControlFormLabel>
 			</Grid>
 			<Grid item>
-				<Switch checked={ value } onClick={ onClick } />
+				<Switch checked={ value } onClick={ onClick } disabled={ disabled } inputProps={ inputProps } />
 			</Grid>
 		</Grid>
 	);
@@ -248,3 +267,56 @@ function generateFirstLoadedOption( unionValue: LinkPropValue[ 'value' ] | null
 		  ]
 		: [];
 }
+
+interface ConditionalInfoTipType extends PropsWithChildren {
+	linkInLinkRestriction: LinkInLinkRestriction;
+	isVisible: boolean;
+}
+
+const ConditionalInfoTip: React.FC< ConditionalInfoTipType > = ( { linkInLinkRestriction, isVisible, children } ) => {
+	const { shouldRestrict, reason, elementId } = linkInLinkRestriction;
+
+	const handleTakeMeClick = () => {
+		if ( elementId ) {
+			selectElement( elementId );
+		}
+	};
+
+	return shouldRestrict && isVisible ? (
+		<Infotip
+			placement="right"
+			content={
+				<InfoTipCard
+					content={ INFOTIP_CONTENT[ reason ] }
+					svgIcon={ <AlertTriangleIcon /> }
+					learnMoreButton={ learnMoreButton }
+					ctaButton={ {
+						label: __( 'Take me there', 'elementor' ),
+						onClick: handleTakeMeClick,
+					} }
+				/>
+			}
+		>
+			<Box>{ children }</Box>
+		</Infotip>
+	) : (
+		<>{ children }</>
+	);
+};
+
+const INFOTIP_CONTENT = {
+	descendant: (
+		<>
+			{ __( 'To add a link to this container,', 'elementor' ) }
+			<br />
+			{ __( 'first remove the link from the elements inside of it.', 'elementor' ) }
+		</>
+	),
+	ancestor: (
+		<>
+			{ __( 'To add a link to this element,', 'elementor' ) }
+			<br />
+			{ __( 'first remove the link from its parent container.', 'elementor' ) }
+		</>
+	),
+};