@elementor/editor-components 3.35.0-454 → 3.35.0-456

package/package.json

@@ -1,7 +1,7 @@
 {
   "name": "@elementor/editor-components",
   "description": "Elementor editor components",
-  "version": "3.35.0-454",
+  "version": "3.35.0-456",
   "private": false,
   "author": "Elementor Team",
   "homepage": "https://elementor.com/",
@@ -40,30 +40,30 @@
     "dev": "tsup --config=../../tsup.dev.ts"
   },
   "dependencies": {
-    "@elementor/editor": "3.35.0-454",
-    "@elementor/editor-canvas": "3.35.0-454",
-    "@elementor/editor-controls": "3.35.0-454",
-    "@elementor/editor-documents": "3.35.0-454",
-    "@elementor/editor-editing-panel": "3.35.0-454",
-    "@elementor/editor-elements": "3.35.0-454",
-    "@elementor/editor-elements-panel": "3.35.0-454",
-    "@elementor/editor-mcp": "3.35.0-454",
-    "@elementor/editor-panels": "3.35.0-454",
-    "@elementor/editor-props": "3.35.0-454",
-    "@elementor/editor-styles-repository": "3.35.0-454",
-    "@elementor/editor-ui": "3.35.0-454",
-    "@elementor/editor-v1-adapters": "3.35.0-454",
-    "@elementor/http-client": "3.35.0-454",
+    "@elementor/editor": "3.35.0-456",
+    "@elementor/editor-canvas": "3.35.0-456",
+    "@elementor/editor-controls": "3.35.0-456",
+    "@elementor/editor-documents": "3.35.0-456",
+    "@elementor/editor-editing-panel": "3.35.0-456",
+    "@elementor/editor-elements": "3.35.0-456",
+    "@elementor/editor-elements-panel": "3.35.0-456",
+    "@elementor/editor-mcp": "3.35.0-456",
+    "@elementor/editor-panels": "3.35.0-456",
+    "@elementor/editor-props": "3.35.0-456",
+    "@elementor/editor-styles-repository": "3.35.0-456",
+    "@elementor/editor-ui": "3.35.0-456",
+    "@elementor/editor-v1-adapters": "3.35.0-456",
+    "@elementor/http-client": "3.35.0-456",
     "@elementor/icons": "^1.63.0",
-    "@elementor/mixpanel": "3.35.0-454",
-    "@elementor/query": "3.35.0-454",
-    "@elementor/schema": "3.35.0-454",
-    "@elementor/store": "3.35.0-454",
+    "@elementor/mixpanel": "3.35.0-456",
+    "@elementor/query": "3.35.0-456",
+    "@elementor/schema": "3.35.0-456",
+    "@elementor/store": "3.35.0-456",
     "@elementor/ui": "1.36.17",
-    "@elementor/utils": "3.35.0-454",
+    "@elementor/utils": "3.35.0-456",
     "@wordpress/i18n": "^5.13.0",
-    "@elementor/editor-notifications": "3.35.0-454",
-    "@elementor/editor-current-user": "3.35.0-454"
+    "@elementor/editor-notifications": "3.35.0-456",
+    "@elementor/editor-current-user": "3.35.0-456"
   },
   "peerDependencies": {
     "react": "^18.3.1",

package/src/components/errors.ts

@@ -0,0 +1,6 @@
+import { createError } from '@elementor/utils';
+
+export const OverrideControlInnerElementNotFoundError = createError< { componentId: number; elementId: string } >( {
+	code: 'override_control_inner_element_not_found',
+	message: `Component inner element not found for override control. The element may have been deleted without updating the overridable props, or the component has not finished rendering yet.`,
+} );

package/src/components/instance-editing-panel/override-prop-control.tsx

@@ -10,7 +10,7 @@ import {
 	SettingsField,
 	useElement,
 } from '@elementor/editor-editing-panel';
-import { type Control, getElementType } from '@elementor/editor-elements';
+import { type Control, getContainer, getElementType } from '@elementor/editor-elements';
 import { Stack } from '@elementor/ui';
 
 import { useControlsByWidgetType } from '../../hooks/use-controls-by-widget-type';
@@ -35,6 +35,7 @@ import { type OriginPropFields, type OverridableProp } from '../../types';
 import { getPropTypeForComponentOverride } from '../../utils/get-prop-type-for-component-override';
 import { resolveOverridePropValue } from '../../utils/resolve-override-prop-value';
 import { ControlLabel } from '../control-label';
+import { OverrideControlInnerElementNotFoundError } from '../errors';
 
 type Props = {
 	overridableProp: OverridableProp;
@@ -131,6 +132,13 @@ function OverrideControl( { overridableProp, overrides }: Props ) {
 
 	const { elementId, widgetType, elType, propKey } = overridableProp.originPropFields ?? overridableProp;
 
+	const elementContainer = getContainer( elementId );
+	if ( ! elementContainer ) {
+		throw new OverrideControlInnerElementNotFoundError( {
+			context: { componentId: componentInstanceId, elementId },
+		} );
+	}
+
 	const type = elType === 'widget' ? widgetType : elType;
 	const elementType = getElementType( type );
 

package/src/components/overridable-props/overridable-prop-indicator.tsx

@@ -2,7 +2,7 @@ import * as React from 'react';
 import { useBoundProp } from '@elementor/editor-controls';
 import { useElement } from '@elementor/editor-editing-panel';
 import { getWidgetsCache } from '@elementor/editor-elements';
-import { type TransformablePropValue } from '@elementor/editor-props';
+import { type PropType, type TransformablePropValue } from '@elementor/editor-props';
 import { bindPopover, bindTrigger, Popover, Tooltip, usePopupState } from '@elementor/ui';
 import { __ } from '@wordpress/i18n';
 
@@ -16,14 +16,12 @@ import { Indicator } from './indicator';
 import { OverridablePropForm } from './overridable-prop-form';
 import { getOverridableProp } from './utils/get-overridable-prop';
 
-const FORBIDDEN_KEYS = [ '_cssid', 'attributes' ];
-
 export function OverridablePropIndicator() {
-	const { bind } = useBoundProp();
+	const { propType } = useBoundProp();
 	const componentId = useCurrentComponentId();
 	const overridableProps = useOverridableProps( componentId );
 
-	if ( ! isPropAllowed( bind ) || ! componentId || ! overridableProps ) {
+	if ( ! isPropAllowed( propType ) || ! componentId || ! overridableProps ) {
 		return null;
 	}
 
@@ -133,6 +131,6 @@ export function Content( { componentId, overridableProps }: Props ) {
 	);
 }
 
-function isPropAllowed( bind: string ) {
-	return ! FORBIDDEN_KEYS.includes( bind );
+function isPropAllowed( propType: PropType ) {
+	return propType.meta.overridable !== false;
 }