@elementor/editor-canvas 4.5.0-1150 → 4.5.0-1154

package/dist/index.js

@@ -4342,7 +4342,7 @@ function initTabsModelExtensions() {
 }
 
 // src/mcp/canvas-mcp.ts
-var import_editor_props8 = require("@elementor/editor-props");
+var import_editor_props9 = require("@elementor/editor-props");
 
 // src/mcp/resources/available-widgets-resource.ts
 var import_http_client3 = require("@elementor/http-client");
@@ -4714,6 +4714,7 @@ var initGeneralContextResource = (reg) => {
 
 // src/mcp/resources/selected-element-resource.ts
 var import_editor_elements11 = require("@elementor/editor-elements");
+var import_editor_props6 = require("@elementor/editor-props");
 var import_editor_v1_adapters21 = require("@elementor/editor-v1-adapters");
 var SELECTED_ELEMENT_URI = "elementor://context/selected-element";
 var initSelectedElementResource = (reg) => {
@@ -4821,13 +4822,19 @@ function getElementProperties(container, widgetType) {
   if (!settings || typeof settings !== "object") {
     return null;
   }
-  const widgetConfig = widgetType ? (0, import_editor_elements11.getWidgetsCache)()?.[widgetType] : null;
+  const widgetsCache = (0, import_editor_elements11.getWidgetsCache)();
+  const widgetConfig = widgetType ? widgetsCache?.[widgetType] : null;
   const controls = widgetConfig?.controls;
+  const schemaType = widgetType ?? container.model.get("elType") ?? null;
+  const propsSchema = schemaType ? widgetsCache?.[schemaType]?.atomic_props_schema : void 0;
   const filtered = {};
   for (const [key, value] of Object.entries(settings)) {
     if (value === void 0 || value === null || value === "") {
       continue;
     }
+    if (import_editor_props6.Schema.isPropSensitive(propsSchema?.[key])) {
+      continue;
+    }
     const controlDefault = controls?.[key]?.default;
     if (controlDefault !== void 0 && JSON.stringify(value) === JSON.stringify(controlDefault)) {
       continue;
@@ -4861,11 +4868,11 @@ function getElementDisplayName(container) {
 // src/mcp/tools/configure-element/tool.ts
 var import_editor_elements14 = require("@elementor/editor-elements");
 var import_editor_mcp3 = require("@elementor/editor-mcp");
-var import_editor_props7 = require("@elementor/editor-props");
+var import_editor_props8 = require("@elementor/editor-props");
 
 // src/mcp/utils/do-update-element-property.ts
 var import_editor_elements13 = require("@elementor/editor-elements");
-var import_editor_props6 = require("@elementor/editor-props");
+var import_editor_props7 = require("@elementor/editor-props");
 var import_editor_styles4 = require("@elementor/editor-styles");
 var import_editor_v1_adapters23 = require("@elementor/editor-v1-adapters");
 
@@ -5018,7 +5025,7 @@ var UnsupportedPropertyError = class extends Error {
 };
 function resolvePropValue(value, forceKey) {
   const Utils = window.elementorV2.editorVariables.Utils;
-  return import_editor_props6.Schema.adjustLlmPropValueSchema(value, {
+  return import_editor_props7.Schema.adjustLlmPropValueSchema(value, {
     forceKey,
     transformers: {
       ...Utils.globalVariablesLLMResolvers,
@@ -5077,7 +5084,7 @@ var doUpdateElementProperty = (params) => {
       }
       if (propertyRawSchema.kind === "plain") {
         if (typeof propertyMapValue[stylePropName] !== "object") {
-          const propUtil = (0, import_editor_props6.getPropSchemaFromCache)(propertyRawSchema.key);
+          const propUtil = (0, import_editor_props7.getPropSchemaFromCache)(propertyRawSchema.key);
           if (propUtil) {
             const plainValue = propUtil.create(propertyMapValue[stylePropName]);
             propertyMapValue[stylePropName] = plainValue;
@@ -5125,7 +5132,7 @@ var doUpdateElementProperty = (params) => {
   }
   const propKey = elementPropSchema[propertyName].key;
   const value = resolvePropValue(propertyValue, propKey);
-  const { valid, jsonSchema } = import_editor_props6.Schema.validatePropValue(elementPropSchema[propertyName], propertyValue);
+  const { valid, jsonSchema } = import_editor_props7.Schema.validatePropValue(elementPropSchema[propertyName], propertyValue);
   if (!valid) {
     throw new Error(
       `Invalid PropValue for elementId: ${elementId}. PropKey: ${propKey}, PropValue: ${JSON.stringify(
@@ -5372,7 +5379,7 @@ var initConfigureElementTool = (reg) => {
       const toUpdate = Object.entries(propertiesToUpdate);
       const skippedProps = [];
       for (const [propertyName, propertyValue] of toUpdate) {
-        if (!import_editor_props7.Schema.isPropKeyConfigurable(propertyName)) {
+        if (!import_editor_props8.Schema.isPropKeyConfigurable(propertyName, widgetData.atomic_props_schema[propertyName])) {
           throw new Error(`Not allowed to update ${propertyName}`);
         }
         try {
@@ -5633,7 +5640,7 @@ var initGetPageStructureTool = (reg) => {
 
 // src/mcp/canvas-mcp.ts
 var initCanvasMcp = (reg) => {
-  import_editor_props8.Schema.setDynamicTagNamesResolver(getDynamicTagNamesByCategories);
+  import_editor_props9.Schema.setDynamicTagNamesResolver(getDynamicTagNamesByCategories);
   initWidgetsSchemaResource(reg);
   initAvailableWidgetsResource(reg);
   initDocumentStructureResource(reg);
@@ -5829,12 +5836,12 @@ function shouldBlock(sourceElements, targetElements) {
 
 // src/style-commands/paste-style.ts
 var import_editor_elements18 = require("@elementor/editor-elements");
-var import_editor_props10 = require("@elementor/editor-props");
+var import_editor_props11 = require("@elementor/editor-props");
 var import_editor_v1_adapters26 = require("@elementor/editor-v1-adapters");
 
 // src/utils/command-utils.ts
 var import_editor_elements16 = require("@elementor/editor-elements");
-var import_editor_props9 = require("@elementor/editor-props");
+var import_editor_props10 = require("@elementor/editor-props");
 var import_i18n8 = require("@wordpress/i18n");
 function hasAtomicWidgets(args) {
   const { containers = [args.container] } = args;
@@ -5852,7 +5859,7 @@ function getClassesProp(container) {
     return null;
   }
   const [propKey] = Object.entries(propsSchema).find(
-    ([, propType]) => propType.kind === "plain" && propType.key === import_editor_props9.CLASSES_PROP_KEY
+    ([, propType]) => propType.kind === "plain" && propType.key === import_editor_props10.CLASSES_PROP_KEY
   ) ?? [];
   return propKey ?? null;
 }
@@ -6001,8 +6008,8 @@ function pasteClasses(containers, classes) {
       return;
     }
     const classesSetting = (0, import_editor_elements18.getElementSetting)(container.id, classesProp);
-    const currentClasses = import_editor_props10.classesPropTypeUtil.extract(classesSetting) ?? [];
-    const newClasses = import_editor_props10.classesPropTypeUtil.create(Array.from(/* @__PURE__ */ new Set([...classes, ...currentClasses])));
+    const currentClasses = import_editor_props11.classesPropTypeUtil.extract(classesSetting) ?? [];
+    const newClasses = import_editor_props11.classesPropTypeUtil.create(Array.from(/* @__PURE__ */ new Set([...classes, ...currentClasses])));
     (0, import_editor_elements18.updateElementSettings)({
       id: container.id,
       props: { [classesProp]: newClasses }

package/dist/index.mjs

@@ -4312,7 +4312,7 @@ function initTabsModelExtensions() {
 }
 
 // src/mcp/canvas-mcp.ts
-import { Schema as Schema3 } from "@elementor/editor-props";
+import { Schema as Schema4 } from "@elementor/editor-props";
 
 // src/mcp/resources/available-widgets-resource.ts
 import { httpService as httpService3 } from "@elementor/http-client";
@@ -4686,6 +4686,7 @@ var initGeneralContextResource = (reg) => {
 
 // src/mcp/resources/selected-element-resource.ts
 import { getContainer as getContainer3, getSelectedElements, getWidgetsCache as getWidgetsCache3 } from "@elementor/editor-elements";
+import { Schema } from "@elementor/editor-props";
 import {
   __privateListenTo as listenTo4,
   commandEndEvent as commandEndEvent7
@@ -4796,13 +4797,19 @@ function getElementProperties(container, widgetType) {
   if (!settings || typeof settings !== "object") {
     return null;
   }
-  const widgetConfig = widgetType ? getWidgetsCache3()?.[widgetType] : null;
+  const widgetsCache = getWidgetsCache3();
+  const widgetConfig = widgetType ? widgetsCache?.[widgetType] : null;
   const controls = widgetConfig?.controls;
+  const schemaType = widgetType ?? container.model.get("elType") ?? null;
+  const propsSchema = schemaType ? widgetsCache?.[schemaType]?.atomic_props_schema : void 0;
   const filtered = {};
   for (const [key, value] of Object.entries(settings)) {
     if (value === void 0 || value === null || value === "") {
       continue;
     }
+    if (Schema.isPropSensitive(propsSchema?.[key])) {
+      continue;
+    }
     const controlDefault = controls?.[key]?.default;
     if (controlDefault !== void 0 && JSON.stringify(value) === JSON.stringify(controlDefault)) {
       continue;
@@ -4836,7 +4843,7 @@ function getElementDisplayName(container) {
 // src/mcp/tools/configure-element/tool.ts
 import { getContainer as getContainer4, getWidgetsCache as getWidgetsCache6 } from "@elementor/editor-elements";
 import { dispatchMcpStylesAppliedEvent } from "@elementor/editor-mcp";
-import { Schema as Schema2 } from "@elementor/editor-props";
+import { Schema as Schema3 } from "@elementor/editor-props";
 
 // src/mcp/utils/do-update-element-property.ts
 import {
@@ -4846,7 +4853,7 @@ import {
   updateElementSettings,
   updateElementStyle
 } from "@elementor/editor-elements";
-import { getPropSchemaFromCache as getPropSchemaFromCache2, Schema } from "@elementor/editor-props";
+import { getPropSchemaFromCache as getPropSchemaFromCache2, Schema as Schema2 } from "@elementor/editor-props";
 import { getStylesSchema as getStylesSchema2, getVariantByMeta } from "@elementor/editor-styles";
 import { __privateRunCommandSync as runCommandSync2 } from "@elementor/editor-v1-adapters";
 
@@ -4999,7 +5006,7 @@ var UnsupportedPropertyError = class extends Error {
 };
 function resolvePropValue(value, forceKey) {
   const Utils = window.elementorV2.editorVariables.Utils;
-  return Schema.adjustLlmPropValueSchema(value, {
+  return Schema2.adjustLlmPropValueSchema(value, {
     forceKey,
     transformers: {
       ...Utils.globalVariablesLLMResolvers,
@@ -5106,7 +5113,7 @@ var doUpdateElementProperty = (params) => {
   }
   const propKey = elementPropSchema[propertyName].key;
   const value = resolvePropValue(propertyValue, propKey);
-  const { valid, jsonSchema } = Schema.validatePropValue(elementPropSchema[propertyName], propertyValue);
+  const { valid, jsonSchema } = Schema2.validatePropValue(elementPropSchema[propertyName], propertyValue);
   if (!valid) {
     throw new Error(
       `Invalid PropValue for elementId: ${elementId}. PropKey: ${propKey}, PropValue: ${JSON.stringify(
@@ -5353,7 +5360,7 @@ var initConfigureElementTool = (reg) => {
       const toUpdate = Object.entries(propertiesToUpdate);
       const skippedProps = [];
       for (const [propertyName, propertyValue] of toUpdate) {
-        if (!Schema2.isPropKeyConfigurable(propertyName)) {
+        if (!Schema3.isPropKeyConfigurable(propertyName, widgetData.atomic_props_schema[propertyName])) {
           throw new Error(`Not allowed to update ${propertyName}`);
         }
         try {
@@ -5614,7 +5621,7 @@ var initGetPageStructureTool = (reg) => {
 
 // src/mcp/canvas-mcp.ts
 var initCanvasMcp = (reg) => {
-  Schema3.setDynamicTagNamesResolver(getDynamicTagNamesByCategories);
+  Schema4.setDynamicTagNamesResolver(getDynamicTagNamesByCategories);
   initWidgetsSchemaResource(reg);
   initAvailableWidgetsResource(reg);
   initDocumentStructureResource(reg);

package/package.json

@@ -1,7 +1,7 @@
 {
   "name": "@elementor/editor-canvas",
   "description": "Elementor Editor Canvas",
-  "version": "4.5.0-1150",
+  "version": "4.5.0-1154",
   "private": false,
   "author": "Elementor Team",
   "homepage": "https://elementor.com/",
@@ -37,26 +37,26 @@
     "react-dom": "^18.3.1"
   },
   "dependencies": {
-    "@elementor/editor": "4.5.0-1150",
-    "@elementor/editor-controls": "4.5.0-1150",
-    "@elementor/editor-documents": "4.5.0-1150",
-    "@elementor/editor-elements": "4.5.0-1150",
-    "@elementor/editor-interactions": "4.5.0-1150",
-    "@elementor/editor-mcp": "4.5.0-1150",
-    "@elementor/editor-notifications": "4.5.0-1150",
-    "@elementor/editor-props": "4.5.0-1150",
-    "@elementor/editor-responsive": "4.5.0-1150",
-    "@elementor/editor-styles": "4.5.0-1150",
-    "@elementor/editor-styles-repository": "4.5.0-1150",
-    "@elementor/editor-ui": "4.5.0-1150",
-    "@elementor/editor-v1-adapters": "4.5.0-1150",
-    "@elementor/events": "4.5.0-1150",
-    "@elementor/http-client": "4.5.0-1150",
-    "@elementor/schema": "4.5.0-1150",
-    "@elementor/twing": "4.5.0-1150",
+    "@elementor/editor": "4.5.0-1154",
+    "@elementor/editor-controls": "4.5.0-1154",
+    "@elementor/editor-documents": "4.5.0-1154",
+    "@elementor/editor-elements": "4.5.0-1154",
+    "@elementor/editor-interactions": "4.5.0-1154",
+    "@elementor/editor-mcp": "4.5.0-1154",
+    "@elementor/editor-notifications": "4.5.0-1154",
+    "@elementor/editor-props": "4.5.0-1154",
+    "@elementor/editor-responsive": "4.5.0-1154",
+    "@elementor/editor-styles": "4.5.0-1154",
+    "@elementor/editor-styles-repository": "4.5.0-1154",
+    "@elementor/editor-ui": "4.5.0-1154",
+    "@elementor/editor-v1-adapters": "4.5.0-1154",
+    "@elementor/events": "4.5.0-1154",
+    "@elementor/http-client": "4.5.0-1154",
+    "@elementor/schema": "4.5.0-1154",
+    "@elementor/twing": "4.5.0-1154",
     "@elementor/ui": "1.41.4",
-    "@elementor/utils": "4.5.0-1150",
-    "@elementor/wp-media": "4.5.0-1150",
+    "@elementor/utils": "4.5.0-1154",
+    "@elementor/wp-media": "4.5.0-1154",
     "@floating-ui/react": "^0.27.5",
     "@wordpress/i18n": "^5.13.0",
     "dompurify": "^3.2.6"

package/src/mcp/resources/__tests__/selected-element-resource.test.ts

@@ -0,0 +1,106 @@
+import { getContainer, getSelectedElements, getWidgetsCache } from '@elementor/editor-elements';
+
+import { initSelectedElementResource } from '../selected-element-resource';
+
+jest.mock( '@elementor/editor-elements', () => ( {
+	getContainer: jest.fn(),
+	getSelectedElements: jest.fn(),
+	getWidgetsCache: jest.fn(),
+} ) );
+
+jest.mock( '@elementor/editor-v1-adapters', () => ( {
+	__privateListenTo: jest.fn(),
+	commandEndEvent: jest.fn(),
+} ) );
+
+type ResourceHandler = () => Promise< { contents: { text: string }[] } >;
+
+const stringProp = ( meta: Record< string, unknown > = {} ) => ( {
+	kind: 'plain',
+	key: 'string',
+	settings: {},
+	meta,
+} );
+
+const givenSelectedContainer = ( modelProps: Record< string, unknown >, settings: Record< string, unknown > ) => {
+	jest.mocked( getSelectedElements ).mockReturnValue( [ { id: 'el-1' } ] as never );
+	jest.mocked( getContainer ).mockReturnValue( {
+		id: 'el-1',
+		type: modelProps.widgetType ? 'widget' : ( modelProps.elType as string ),
+		model: {
+			get: ( key: string ) => modelProps[ key ],
+			config: { atomic: true },
+		},
+		settings: {
+			toJSON: () => settings,
+		},
+	} as never );
+};
+
+const readProperties = async () => {
+	const resource = jest.fn();
+	initSelectedElementResource( { resource, sendResourceUpdated: jest.fn() } as never );
+
+	const handler = resource.mock.calls[ 0 ][ 3 ] as ResourceHandler;
+	const result = await handler();
+
+	return JSON.parse( result.contents[ 0 ].text ).properties;
+};
+
+describe( 'selected-element-resource', () => {
+	beforeEach( () => {
+		jest.clearAllMocks();
+	} );
+
+	it( 'omits sensitive props of an atomic widget', async () => {
+		// Arrange.
+		jest.mocked( getWidgetsCache ).mockReturnValue( {
+			'e-heading': {
+				atomic_props_schema: {
+					tag: stringProp(),
+					api_key: stringProp( { sensitive: true } ),
+				},
+			},
+		} as never );
+
+		givenSelectedContainer(
+			{ elType: 'widget', widgetType: 'e-heading' },
+			{
+				tag: { $$type: 'string', value: 'h2' },
+				api_key: { $$type: 'string', value: 'secret' },
+			}
+		);
+
+		// Act.
+		const properties = await readProperties();
+
+		// Assert.
+		expect( properties ).toEqual( { tag: { $$type: 'string', value: 'h2' } } );
+	} );
+
+	it( 'omits sensitive props of an atomic element that has no widgetType', async () => {
+		// Arrange.
+		jest.mocked( getWidgetsCache ).mockReturnValue( {
+			'e-form': {
+				atomic_props_schema: {
+					'form-name': stringProp(),
+					'mailchimp-api-key': stringProp( { sensitive: true } ),
+				},
+			},
+		} as never );
+
+		givenSelectedContainer(
+			{ elType: 'e-form' },
+			{
+				'form-name': { $$type: 'string', value: 'Contact' },
+				'mailchimp-api-key': { $$type: 'string', value: 'secret' },
+			}
+		);
+
+		// Act.
+		const properties = await readProperties();
+
+		// Assert.
+		expect( properties ).toEqual( { 'form-name': { $$type: 'string', value: 'Contact' } } );
+	} );
+} );

package/src/mcp/resources/selected-element-resource.ts

@@ -1,5 +1,6 @@
 import { getContainer, getSelectedElements, getWidgetsCache, type V1Element } from '@elementor/editor-elements';
 import { type MCPRegistryEntry } from '@elementor/editor-mcp';
+import { Schema } from '@elementor/editor-props';
 import {
 	__privateListenTo as listenTo,
 	commandEndEvent,
@@ -167,9 +168,14 @@ function getElementProperties(
 		return null;
 	}
 
-	const widgetConfig = widgetType ? getWidgetsCache()?.[ widgetType ] : null;
+	const widgetsCache = getWidgetsCache();
+	const widgetConfig = widgetType ? widgetsCache?.[ widgetType ] : null;
 	const controls = widgetConfig?.controls as Record< string, { default?: unknown } > | undefined;
 
+	// Atomic elements (e.g. e-div-block, e-form) have no widgetType, their config is keyed by elType.
+	const schemaType = widgetType ?? container.model.get( 'elType' ) ?? null;
+	const propsSchema = schemaType ? widgetsCache?.[ schemaType ]?.atomic_props_schema : undefined;
+
 	const filtered: Record< string, unknown > = {};
 
 	for ( const [ key, value ] of Object.entries( settings ) ) {
@@ -177,6 +183,10 @@ function getElementProperties(
 			continue;
 		}
 
+		if ( Schema.isPropSensitive( propsSchema?.[ key ] ) ) {
+			continue;
+		}
+
 		const controlDefault = controls?.[ key ]?.default;
 		if ( controlDefault !== undefined && JSON.stringify( value ) === JSON.stringify( controlDefault ) ) {
 			continue;

package/src/mcp/tools/configure-element/__tests__/tool.test.ts

@@ -13,7 +13,7 @@ jest.mock( '@elementor/editor-mcp', () => ( {
 } ) );
 
 jest.mock( '@elementor/editor-props', () => ( {
-	Schema: { isPropKeyConfigurable: () => true },
+	Schema: { isPropKeyConfigurable: jest.requireActual( '@elementor/editor-props' ).Schema.isPropKeyConfigurable },
 } ) );
 
 jest.mock( '../prompt', () => ( {
@@ -128,3 +128,55 @@ describe( 'configure-element handler unsupported props', () => {
 		).rejects.toThrow( /Invalid PropValue/ );
 	} );
 } );
+
+describe( 'configure-element handler sensitive props', () => {
+	beforeEach( () => {
+		jest.mocked( getWidgetsCache ).mockReturnValue( {
+			[ ELEMENT_TYPE ]: {
+				atomic_props_schema: {
+					title: { key: 'string', kind: 'plain', settings: {}, meta: {} },
+					api_key: { key: 'string', kind: 'plain', settings: {}, meta: { sensitive: true } },
+				},
+			},
+		} as never );
+		jest.mocked( getContainer ).mockReturnValue( {
+			settings: { get: () => ELEMENT_TYPE },
+		} as never );
+		jest.mocked( doUpdateElementProperty ).mockReset();
+	} );
+
+	it( 'rejects a write to a sensitive prop', async () => {
+		// Arrange
+		const handler = getHandler();
+
+		// Act & Assert
+		await expect(
+			handler( {
+				elementId: ELEMENT_ID,
+				elementType: ELEMENT_TYPE,
+				propertiesToChange: { api_key: { $$type: 'string', value: 'secret' } },
+				style: {},
+			} )
+		).rejects.toThrow( 'Not allowed to update api_key' );
+
+		expect( doUpdateElementProperty ).not.toHaveBeenCalled();
+	} );
+
+	it( 'still writes non sensitive props', async () => {
+		// Arrange
+		jest.mocked( doUpdateElementProperty ).mockImplementation( () => undefined );
+		const handler = getHandler();
+
+		// Act
+		const result = await handler( {
+			elementId: ELEMENT_ID,
+			elementType: ELEMENT_TYPE,
+			propertiesToChange: { title: { $$type: 'string', value: 'Hi' } },
+			style: {},
+		} );
+
+		// Assert
+		expect( result.success ).toBe( true );
+		expect( doUpdateElementProperty ).toHaveBeenCalledTimes( 1 );
+	} );
+} );

package/src/mcp/tools/configure-element/tool.ts

@@ -63,7 +63,7 @@ export const initConfigureElementTool = ( reg: MCPRegistryEntry ) => {
 			const toUpdate = Object.entries( propertiesToUpdate );
 			const skippedProps: string[] = [];
 			for ( const [ propertyName, propertyValue ] of toUpdate as [ string, PropValue ][] ) {
-				if ( ! Schema.isPropKeyConfigurable( propertyName ) ) {
+				if ( ! Schema.isPropKeyConfigurable( propertyName, widgetData.atomic_props_schema[ propertyName ] ) ) {
 					throw new Error( `Not allowed to update ${ propertyName }` );
 				}
 				try {