@elementor/editor-audits 4.4.0-1130 → 4.4.0-1131

package/dist/index.js

@@ -392,13 +392,14 @@ function recurse(nodes, parents, visit) {
 }
 
 // src/utils/atomic-image-sources.ts
-var ATOMIC_IMAGE_PROP_KEYS = ["image", "poster"];
-function walkAtomicImageSources(tree, visit) {
+var ATOMIC_CONTENT_IMAGE_PROP_KEYS = ["image"];
+var ATOMIC_IMAGE_PROP_KEYS = [...ATOMIC_CONTENT_IMAGE_PROP_KEYS, "poster"];
+function walkAtomicImageSources(tree, visit, propKeys = ATOMIC_IMAGE_PROP_KEYS) {
   walkElements(tree, (node) => {
     if (node.elType !== "widget") {
       return;
     }
-    for (const key of ATOMIC_IMAGE_PROP_KEYS) {
+    for (const key of propKeys) {
       const media = extractAtomicImageMedia(node.settings[key]);
       if (media) {
         visit({ node, media });
@@ -420,8 +421,9 @@ function extractAtomicImageMedia(imageProp) {
   if (!id && !url) {
     return null;
   }
+  const alt = import_editor_props.stringPropTypeUtil.extract(src.alt) ?? void 0;
   const size = import_editor_props.stringPropTypeUtil.extract(image.size) ?? void 0;
-  return { id, url, size };
+  return { id, url, alt, size };
 }
 
 // src/utils/atomic-background-image-sources.ts
@@ -476,15 +478,6 @@ function walkBackgroundImageSources(tree, visit) {
 
 // src/utils/image-like-sources.ts
 var IMAGE_LIKE_WIDGETS = /* @__PURE__ */ new Set(["image", "image-box", "image-carousel", "gallery", "image-gallery"]);
-function hasPageImages(tree) {
-  let found = false;
-  walkImageLikeSources(tree, ({ media }) => {
-    if (media.id || media.url) {
-      found = true;
-    }
-  });
-  return found;
-}
 function walkImageLikeSources(tree, visit) {
   walkElements(tree, (node) => {
     if (node.elType !== "widget") {
@@ -516,6 +509,14 @@ function collectMediaFromNode(node) {
   return sources;
 }
 
+// src/utils/all-image-sources.ts
+function walkAllImageSources(tree, visit) {
+  walkImageLikeSources(tree, visit);
+  walkBackgroundImageSources(tree, visit);
+  walkAtomicImageSources(tree, visit);
+  walkAtomicBackgroundImageSources(tree, visit);
+}
+
 // src/utils/image-size-key.ts
 function buildImageSizeKey({ id, size }) {
   return `${id}:${size || "full"}`;
@@ -524,15 +525,11 @@ function buildImageSizeKey({ id, size }) {
 // src/utils/page-attachments.ts
 function extractImageSizeRequests(tree) {
   const keys = /* @__PURE__ */ new Set();
-  const collect = (media) => {
+  walkAllImageSources(tree, ({ media }) => {
     if (media.id) {
       keys.add(buildImageSizeKey({ id: media.id, size: media.size }));
     }
-  };
-  walkImageLikeSources(tree, ({ media }) => collect(media));
-  walkBackgroundImageSources(tree, ({ media }) => collect(media));
-  walkAtomicImageSources(tree, ({ media }) => collect(media));
-  walkAtomicBackgroundImageSources(tree, ({ media }) => collect(media));
+  });
   return Array.from(keys).sort();
 }
 
@@ -2293,6 +2290,21 @@ var audit10 = {
 // src/audits/images-alt-text.ts
 var import_i18n29 = require("@wordpress/i18n");
 
+// src/utils/alt-text-image-sources.ts
+function walkAltTextImageSources(tree, visit) {
+  walkImageLikeSources(tree, visit);
+  walkAtomicImageSources(tree, visit, ATOMIC_CONTENT_IMAGE_PROP_KEYS);
+}
+function hasAltTextImages(tree) {
+  let found = false;
+  walkAltTextImageSources(tree, ({ media }) => {
+    if (media.id || media.url) {
+      found = true;
+    }
+  });
+  return found;
+}
+
 // src/utils/image-alt.ts
 function hasMeaningfulAlt(media, pageContext) {
   if (!media.id && !media.url) {
@@ -2319,14 +2331,14 @@ var audit11 = {
   severity: "error",
   weight: 10,
   evaluate: (ctx) => {
-    if (!hasPageImages(ctx.elements.tree)) {
+    if (!hasAltTextImages(ctx.elements.tree)) {
       return { status: "skipped", reason: (0, import_i18n29.__)("No images", "elementor") };
     }
     const isReady = ctx.pageContext.ally_plugin_active;
     const violations = [];
     const failedWidgetIds = /* @__PURE__ */ new Set();
     let missingAltImageCount = 0;
-    walkImageLikeSources(ctx.elements.tree, ({ node, media }) => {
+    walkAltTextImageSources(ctx.elements.tree, ({ node, media }) => {
       if (!isImageSourcePresent(media) || hasMeaningfulAlt(media, ctx.pageContext)) {
         return;
       }
@@ -2378,10 +2390,7 @@ var audit12 = {
       inefficientImageFormatCount++;
       offendingElementIds.add(node.id);
     };
-    walkImageLikeSources(ctx.elements.tree, ({ node, media }) => evaluateSource(node, media));
-    walkBackgroundImageSources(ctx.elements.tree, ({ node, media }) => evaluateSource(node, media));
-    walkAtomicImageSources(ctx.elements.tree, ({ node, media }) => evaluateSource(node, media));
-    walkAtomicBackgroundImageSources(ctx.elements.tree, ({ node, media }) => evaluateSource(node, media));
+    walkAllImageSources(ctx.elements.tree, ({ node, media }) => evaluateSource(node, media));
     if (!hasAnyImage) {
       return { status: "skipped", reason: (0, import_i18n30.__)("No images", "elementor") };
     }
@@ -2431,10 +2440,7 @@ var audit13 = {
       const currentMax = widgetMaxKb.get(node.id) ?? 0;
       widgetMaxKb.set(node.id, Math.max(currentMax, kb));
     };
-    walkImageLikeSources(ctx.elements.tree, ({ node, media }) => evaluateSource(node, media));
-    walkBackgroundImageSources(ctx.elements.tree, ({ node, media }) => evaluateSource(node, media));
-    walkAtomicImageSources(ctx.elements.tree, ({ node, media }) => evaluateSource(node, media));
-    walkAtomicBackgroundImageSources(ctx.elements.tree, ({ node, media }) => evaluateSource(node, media));
+    walkAllImageSources(ctx.elements.tree, ({ node, media }) => evaluateSource(node, media));
     if (!hasAnyImage) {
       return { status: "skipped", reason: (0, import_i18n31.__)("No images", "elementor") };
     }