@elementor/editor-audits 4.4.0-1129 → 4.4.0-1131

package/dist/index.js

@@ -246,16 +246,16 @@ async function requestPageContext(documentId, imageSizeRequests, allowNonceRetry
 
 // src/registry.ts
 var registry = /* @__PURE__ */ new Map();
-function registerAudit(audit26) {
-  registry.set(audit26.id, audit26);
+function registerAudit(audit25) {
+  registry.set(audit25.id, audit25);
 }
 function getRegisteredAudits() {
   return Array.from(registry.values());
 }
 
 // src/utils/is-scored-audit.ts
-function isScoredAudit(audit26) {
-  return audit26.weight > 0;
+function isScoredAudit(audit25) {
+  return audit25.weight > 0;
 }
 
 // src/utils/sort-failed-audits.ts
@@ -316,16 +316,16 @@ function computeReport(documentId, results) {
   const accumulators = Object.fromEntries(
     ALL_CATEGORIES.map((c) => [c, { totalWeight: 0, passedWeight: 0, total: 0, failed: 0 }])
   );
-  for (const { audit: audit26, result } of results) {
+  for (const { audit: audit25, result } of results) {
     if (result.status === "skipped") {
       continue;
     }
-    for (const category of audit26.categories) {
+    for (const category of audit25.categories) {
       const acc = accumulators[category];
       acc.total++;
-      acc.totalWeight += audit26.weight;
+      acc.totalWeight += audit25.weight;
       if (result.status === "pass") {
-        acc.passedWeight += audit26.weight;
+        acc.passedWeight += audit25.weight;
       } else {
         acc.failed++;
       }
@@ -392,13 +392,14 @@ function recurse(nodes, parents, visit) {
 }
 
 // src/utils/atomic-image-sources.ts
-var ATOMIC_IMAGE_PROP_KEYS = ["image", "poster"];
-function walkAtomicImageSources(tree, visit) {
+var ATOMIC_CONTENT_IMAGE_PROP_KEYS = ["image"];
+var ATOMIC_IMAGE_PROP_KEYS = [...ATOMIC_CONTENT_IMAGE_PROP_KEYS, "poster"];
+function walkAtomicImageSources(tree, visit, propKeys = ATOMIC_IMAGE_PROP_KEYS) {
   walkElements(tree, (node) => {
     if (node.elType !== "widget") {
       return;
     }
-    for (const key of ATOMIC_IMAGE_PROP_KEYS) {
+    for (const key of propKeys) {
       const media = extractAtomicImageMedia(node.settings[key]);
       if (media) {
         visit({ node, media });
@@ -420,8 +421,9 @@ function extractAtomicImageMedia(imageProp) {
   if (!id && !url) {
     return null;
   }
+  const alt = import_editor_props.stringPropTypeUtil.extract(src.alt) ?? void 0;
   const size = import_editor_props.stringPropTypeUtil.extract(image.size) ?? void 0;
-  return { id, url, size };
+  return { id, url, alt, size };
 }
 
 // src/utils/atomic-background-image-sources.ts
@@ -476,15 +478,6 @@ function walkBackgroundImageSources(tree, visit) {
 
 // src/utils/image-like-sources.ts
 var IMAGE_LIKE_WIDGETS = /* @__PURE__ */ new Set(["image", "image-box", "image-carousel", "gallery", "image-gallery"]);
-function hasPageImages(tree) {
-  let found = false;
-  walkImageLikeSources(tree, ({ media }) => {
-    if (media.id || media.url) {
-      found = true;
-    }
-  });
-  return found;
-}
 function walkImageLikeSources(tree, visit) {
   walkElements(tree, (node) => {
     if (node.elType !== "widget") {
@@ -516,6 +509,14 @@ function collectMediaFromNode(node) {
   return sources;
 }
 
+// src/utils/all-image-sources.ts
+function walkAllImageSources(tree, visit) {
+  walkImageLikeSources(tree, visit);
+  walkBackgroundImageSources(tree, visit);
+  walkAtomicImageSources(tree, visit);
+  walkAtomicBackgroundImageSources(tree, visit);
+}
+
 // src/utils/image-size-key.ts
 function buildImageSizeKey({ id, size }) {
   return `${id}:${size || "full"}`;
@@ -524,15 +525,11 @@ function buildImageSizeKey({ id, size }) {
 // src/utils/page-attachments.ts
 function extractImageSizeRequests(tree) {
   const keys = /* @__PURE__ */ new Set();
-  const collect = (media) => {
+  walkAllImageSources(tree, ({ media }) => {
     if (media.id) {
       keys.add(buildImageSizeKey({ id: media.id, size: media.size }));
     }
-  };
-  walkImageLikeSources(tree, ({ media }) => collect(media));
-  walkBackgroundImageSources(tree, ({ media }) => collect(media));
-  walkAtomicImageSources(tree, ({ media }) => collect(media));
-  walkAtomicBackgroundImageSources(tree, ({ media }) => collect(media));
+  });
   return Array.from(keys).sort();
 }
 
@@ -641,10 +638,10 @@ async function runPageAudit(documentId) {
   const ctx = { documentId, elements, pageContext, kit, renderedHtml };
   const registered = getRegisteredAudits();
   const auditResults = await Promise.all(
-    registered.map(async (audit26) => {
-      const { evaluate: _evaluate, ...meta } = audit26;
+    registered.map(async (audit25) => {
+      const { evaluate: _evaluate, ...meta } = audit25;
       try {
-        const result = await audit26.evaluate(ctx);
+        const result = await audit25.evaluate(ctx);
         return { audit: meta, result };
       } catch (error) {
         const reason = error instanceof Error ? error.message : "unknown-error";
@@ -1125,9 +1122,9 @@ function ViolationIcon({ violation, widgetIcon }) {
 function SkipReasonTooltip({ reason }) {
   return /* @__PURE__ */ React12.createElement(import_ui11.Tooltip, { title: reason, placement: "top" }, /* @__PURE__ */ React12.createElement(import_ui11.Box, { "aria-label": reason, component: "span", sx: { display: "inline-flex", alignItems: "center" } }, /* @__PURE__ */ React12.createElement(import_icons10.HelpIcon, { fontSize: "small", color: "action" })));
 }
-function StatusIndicator({ audit: audit26, violations }) {
+function StatusIndicator({ audit: audit25, violations }) {
   if (violations) {
-    return /* @__PURE__ */ React12.createElement(React12.Fragment, null, /* @__PURE__ */ React12.createElement(SeverityIcon, { severity: audit26.severity }), isScoredAudit(audit26) && /* @__PURE__ */ React12.createElement(import_ui11.Typography, { variant: "caption", color: "text.secondary", fontWeight: "bold" }, violations.length));
+    return /* @__PURE__ */ React12.createElement(React12.Fragment, null, /* @__PURE__ */ React12.createElement(SeverityIcon, { severity: audit25.severity }), isScoredAudit(audit25) && /* @__PURE__ */ React12.createElement(import_ui11.Typography, { variant: "caption", color: "text.secondary", fontWeight: "bold" }, violations.length));
   }
   return /* @__PURE__ */ React12.createElement(import_icons10.CheckIcon, { fontSize: "small", color: "success" });
 }
@@ -1169,7 +1166,7 @@ function getSharedAngiePrompt(violations) {
   );
   return allShareTheSameFix ? first.angiePrompt : void 0;
 }
-function ViolationRow({ audit: audit26, expanded, onToggleExpand, skipReason, violations }) {
+function ViolationRow({ audit: audit25, expanded, onToggleExpand, skipReason, violations }) {
   const primaryViolation = violations?.[0];
   const isGuidanceFocusable = !!primaryViolation;
   const panelZIndex = (0, import_editor_floating_panels2.useFloatingPanelZIndex)(AUDIT_PANEL_ID);
@@ -1192,8 +1189,8 @@ function ViolationRow({ audit: audit26, expanded, onToggleExpand, skipReason, vi
       },
       onClick: onToggleExpand
     },
-    /* @__PURE__ */ React12.createElement(import_ui11.Typography, { variant: "subtitle2", color: "text.secondary", sx: { flex: 1 } }, audit26.title),
-    !skipReason && /* @__PURE__ */ React12.createElement(StatusIndicator, { audit: audit26, violations })
+    /* @__PURE__ */ React12.createElement(import_ui11.Typography, { variant: "subtitle2", color: "text.secondary", sx: { flex: 1 } }, audit25.title),
+    !skipReason && /* @__PURE__ */ React12.createElement(StatusIndicator, { audit: audit25, violations })
   ), skipReason && /* @__PURE__ */ React12.createElement(SkipReasonTooltip, { reason: skipReason }), /* @__PURE__ */ React12.createElement(
     import_ui11.IconButton,
     {
@@ -1211,7 +1208,7 @@ function ViolationRow({ audit: audit26, expanded, onToggleExpand, skipReason, vi
         }
       }
     )
-  )), /* @__PURE__ */ React12.createElement(import_ui11.Collapse, { in: expanded }, /* @__PURE__ */ React12.createElement(import_ui11.Box, { paddingBlock: 1 }, /* @__PURE__ */ React12.createElement(import_ui11.Tooltip, { title: audit26.fixHint, placement: "top" }, /* @__PURE__ */ React12.createElement(
+  )), /* @__PURE__ */ React12.createElement(import_ui11.Collapse, { in: expanded }, /* @__PURE__ */ React12.createElement(import_ui11.Box, { paddingBlock: 1 }, /* @__PURE__ */ React12.createElement(import_ui11.Tooltip, { title: audit25.fixHint, placement: "top" }, /* @__PURE__ */ React12.createElement(
     import_ui11.Alert,
     {
       severity: "secondary",
@@ -1222,7 +1219,7 @@ function ViolationRow({ audit: audit26, expanded, onToggleExpand, skipReason, vi
       onClick: isGuidanceFocusable ? handleGuidanceClick : void 0,
       onKeyDown: isGuidanceFocusable ? onKeyboardClick(handleGuidanceClick) : void 0
     },
-    /* @__PURE__ */ React12.createElement(import_ui11.Typography, { variant: "caption", component: "p", color: "text.secondary" }, audit26.description),
+    /* @__PURE__ */ React12.createElement(import_ui11.Typography, { variant: "caption", component: "p", color: "text.secondary" }, audit25.description),
     primaryViolation && /* @__PURE__ */ React12.createElement(
       GuidanceAction,
       {
@@ -1340,17 +1337,17 @@ var import_i18n12 = require("@wordpress/i18n");
 var ALL_SEVERITIES = ["error", "warning", "info"];
 function countSeverities(report, category) {
   const counts = { error: 0, warning: 0, info: 0 };
-  for (const { audit: audit26, result } of report.auditResults) {
+  for (const { audit: audit25, result } of report.auditResults) {
     if (result.status !== "fail") {
       continue;
     }
-    if (category && !audit26.categories.includes(category)) {
+    if (category && !audit25.categories.includes(category)) {
       continue;
     }
-    if (!isScoredAudit(audit26)) {
+    if (!isScoredAudit(audit25)) {
       continue;
     }
-    counts[audit26.severity] += result.violations.length;
+    counts[audit25.severity] += result.violations.length;
   }
   return counts;
 }
@@ -1556,7 +1553,7 @@ function SeverityCard({ severity, count }) {
       flex: 1,
       flexDirection: "column",
       gap: 1,
-      bgcolor: "grey.50",
+      bgcolor: "action.hover",
       borderRadius: 1.5,
       px: 1.5,
       py: 1
@@ -2293,6 +2290,21 @@ var audit10 = {
 // src/audits/images-alt-text.ts
 var import_i18n29 = require("@wordpress/i18n");
 
+// src/utils/alt-text-image-sources.ts
+function walkAltTextImageSources(tree, visit) {
+  walkImageLikeSources(tree, visit);
+  walkAtomicImageSources(tree, visit, ATOMIC_CONTENT_IMAGE_PROP_KEYS);
+}
+function hasAltTextImages(tree) {
+  let found = false;
+  walkAltTextImageSources(tree, ({ media }) => {
+    if (media.id || media.url) {
+      found = true;
+    }
+  });
+  return found;
+}
+
 // src/utils/image-alt.ts
 function hasMeaningfulAlt(media, pageContext) {
   if (!media.id && !media.url) {
@@ -2319,14 +2331,14 @@ var audit11 = {
   severity: "error",
   weight: 10,
   evaluate: (ctx) => {
-    if (!hasPageImages(ctx.elements.tree)) {
+    if (!hasAltTextImages(ctx.elements.tree)) {
       return { status: "skipped", reason: (0, import_i18n29.__)("No images", "elementor") };
     }
     const isReady = ctx.pageContext.ally_plugin_active;
     const violations = [];
     const failedWidgetIds = /* @__PURE__ */ new Set();
     let missingAltImageCount = 0;
-    walkImageLikeSources(ctx.elements.tree, ({ node, media }) => {
+    walkAltTextImageSources(ctx.elements.tree, ({ node, media }) => {
       if (!isImageSourcePresent(media) || hasMeaningfulAlt(media, ctx.pageContext)) {
         return;
       }
@@ -2378,10 +2390,7 @@ var audit12 = {
       inefficientImageFormatCount++;
       offendingElementIds.add(node.id);
     };
-    walkImageLikeSources(ctx.elements.tree, ({ node, media }) => evaluateSource(node, media));
-    walkBackgroundImageSources(ctx.elements.tree, ({ node, media }) => evaluateSource(node, media));
-    walkAtomicImageSources(ctx.elements.tree, ({ node, media }) => evaluateSource(node, media));
-    walkAtomicBackgroundImageSources(ctx.elements.tree, ({ node, media }) => evaluateSource(node, media));
+    walkAllImageSources(ctx.elements.tree, ({ node, media }) => evaluateSource(node, media));
     if (!hasAnyImage) {
       return { status: "skipped", reason: (0, import_i18n30.__)("No images", "elementor") };
     }
@@ -2431,10 +2440,7 @@ var audit13 = {
       const currentMax = widgetMaxKb.get(node.id) ?? 0;
       widgetMaxKb.set(node.id, Math.max(currentMax, kb));
     };
-    walkImageLikeSources(ctx.elements.tree, ({ node, media }) => evaluateSource(node, media));
-    walkBackgroundImageSources(ctx.elements.tree, ({ node, media }) => evaluateSource(node, media));
-    walkAtomicImageSources(ctx.elements.tree, ({ node, media }) => evaluateSource(node, media));
-    walkAtomicBackgroundImageSources(ctx.elements.tree, ({ node, media }) => evaluateSource(node, media));
+    walkAllImageSources(ctx.elements.tree, ({ node, media }) => evaluateSource(node, media));
     if (!hasAnyImage) {
       return { status: "skipped", reason: (0, import_i18n31.__)("No images", "elementor") };
     }
@@ -2982,50 +2988,6 @@ var audit24 = {
   }
 };
 
-// src/audits/too-many-widgets.ts
-var import_editor_elements9 = require("@elementor/editor-elements");
-var import_i18n43 = require("@wordpress/i18n");
-var WIDGET_COUNT_THRESHOLD = 100;
-function isCountableWidget(node, widgetsCache) {
-  if (node.elType === "widget") {
-    return true;
-  }
-  return !!widgetsCache?.[node.elType]?.meta?.is_compound;
-}
-var audit25 = {
-  id: "audits/too-many-widgets",
-  title: (0, import_i18n43.__)("Too many widgets", "elementor"),
-  description: (0, import_i18n43.__)("Excessive DOM size caused by too many widgets degrades rendering performance.", "elementor"),
-  fixHint: (0, import_i18n43.__)("Reduce the number of widgets on the page by removing or combining elements.", "elementor"),
-  categories: ["best-practices", "performance"],
-  severity: "warning",
-  weight: 5,
-  evaluate: (ctx) => {
-    if (ctx.elements.tree.length === 0) {
-      return { status: "skipped", reason: (0, import_i18n43.__)("No elements", "elementor") };
-    }
-    const widgetsCache = (0, import_editor_elements9.getWidgetsCache)();
-    let widgetCount = 0;
-    walkElements(ctx.elements.tree, (node) => {
-      if (isCountableWidget(node, widgetsCache)) {
-        widgetCount++;
-      }
-    });
-    if (widgetCount <= WIDGET_COUNT_THRESHOLD) {
-      return { status: "pass" };
-    }
-    return {
-      status: "fail",
-      violations: [
-        {
-          auditId: audit25.id,
-          label: (0, import_i18n43.__)("Page has too many widgets.", "elementor")
-        }
-      ]
-    };
-  }
-};
-
 // src/register-audits.ts
 var AUDITS = [
   audit17,
@@ -3033,7 +2995,6 @@ var AUDITS = [
   audit16,
   audit10,
   audit7,
-  audit25,
   audit23,
   audit5,
   audit14,
@@ -3055,8 +3016,8 @@ var AUDITS = [
   audit8
 ];
 function registerAllAudits() {
-  for (const audit26 of AUDITS) {
-    registerAudit(audit26);
+  for (const audit25 of AUDITS) {
+    registerAudit(audit25);
   }
 }