@electerm/electerm-react 5.5.6 → 5.5.15

package/client/components/theme/theme-form.jsx

@@ -1,5 +1,5 @@
 import { useRef, useState } from 'react'
-import { Button, Input, Form, Tabs, Flex } from 'antd'
+import { Button, Input, Form, Flex } from 'antd'
 import {
   BgColorsOutlined,
   FontSizeOutlined,
@@ -19,10 +19,11 @@ import generate from '../../common/uid'
 import { isAIDisabled } from '../../common/ai-feature'
 import Link from '../common/external-link'
 import InputAutoFocus from '../common/input-auto-focus'
+import ResponsiveTabs from '../common/responsive-tabs'
 import ThemePicker from './theme-editor'
 import ThemeAiEditor from './theme-ai-editor'
 import Upload from '../common/upload'
-// import './theme-form.styl'
+import './theme-form.styl'
 
 const { TextArea } = Input
 const FormItem = Form.Item
@@ -155,6 +156,7 @@ export default function ThemeForm (props) {
         <FormItem>
           <span className='mg1r'>src:</span>
           <Link
+            className='wordbreak'
             to={url}
           >{url}
           </Link>
@@ -277,34 +279,29 @@ export default function ThemeForm (props) {
     themeText: txt,
     disabled
   }
+  // icon + label, the label text is hidden by css on narrow screens so the
+  // three editor tabs always fit, the title keeps it discoverable
+  function renderTabLabel (icon, text) {
+    return (
+      <span className='theme-editor-tab' title={text}>
+        {icon}
+        <span className='theme-editor-tab-text'>{text}</span>
+      </span>
+    )
+  }
   const tabItems = [
     {
       key: 'theme-editor-color-picker',
-      label: (
-        <span>
-          <BgColorsOutlined className='mg1r' />
-          {e('editWithColorPicker')}
-        </span>
-      )
+      label: renderTabLabel(<BgColorsOutlined className='mg1r' />, e('editWithColorPicker'))
     },
     {
       key: 'theme-editor-txt',
-      label: (
-        <span>
-          <FontSizeOutlined className='mg1r' />
-          {e('editWithTextEditor')}
-        </span>
-      )
+      label: renderTabLabel(<FontSizeOutlined className='mg1r' />, e('editWithTextEditor'))
     },
     ...(!isAIDisabled()
       ? [{
           key: 'theme-editor-ai',
-          label: (
-            <span>
-              <RobotOutlined className='mg1r' />
-              AI
-            </span>
-          )
+          label: renderTabLabel(<RobotOutlined className='mg1r' />, 'AI')
         }]
       : [])
   ]
@@ -365,7 +362,7 @@ export default function ThemeForm (props) {
             </Button>
           </Upload>
         </Flex>
-        <Tabs {...tabsProps} />
+        <ResponsiveTabs {...tabsProps} />
         {
           editor === 'theme-editor-txt'
             ? renderTxt()

package/client/components/theme/theme-form.styl

@@ -1,10 +1,8 @@
-.theme-editor-txt
-  .editor-u-textarea
-    display block !important
-  .editor-u-picker
-    display none !important
-.theme-editor-color-picker
-  .editor-u-textarea
-    display none !important
-  .editor-u-picker
-    display block !important
+// setting panel > UI themes > theme form
+//
+// The three editor tabs need ~395px for their translated labels ("Edit with
+// color picker" / "Edit with text editor" / "AI") while a 320px phone leaves
+// the panel only ~257px. Below the app's mobile breakpoint (600px, see
+// constants.js) ResponsiveTabs replaces the bar with a single "current tab +
+// dropdown" selector (common/responsive-tabs.jsx), so the labels stay readable
+// everywhere instead of being collapsed to icons.

package/client/components/vnc/vnc-session.jsx

@@ -7,7 +7,6 @@ import {
   statusMap
 } from '../../common/constants'
 import {
-  Spin,
   Select
 } from 'antd'
 import {
@@ -18,6 +17,7 @@ import Modal from '../common/modal'
 import { copy, readClipboard } from '../../common/clipboard'
 import VncForm from './vnc-form'
 import RemoteFloatControl from '../common/remote-float-control'
+import RemoteSessionShell from '../common/remote-session-shell'
 import './vnc.styl'
 
 // noVNC module imports — loaded dynamically
@@ -71,23 +71,35 @@ export default class VncSession extends PureComponent {
     })
   }
 
-  getScreenSize = () => {
-    const { screens, currentScreen } = this.state
-    const currentScreenData = screens.find(s => s.id === currentScreen)
-    return {
-      remoteWidth: currentScreenData ? currentScreenData.width : null,
-      remoteHeight: currentScreenData ? currentScreenData.height : null
+  // fullscreen always fills the screen, the per tab setting only applies
+  // windowed; the switch is not reachable in fullscreen anyway
+  getFit = () => {
+    if (this.props.fullscreen) {
+      return true
     }
+    const { scaleViewport = true } = this.props.tab
+    return !!scaleViewport
   }
 
+  // viewport box measured by the shell, used as the size hint for the server.
+  // Falls back to the layout props before the first measurement.
   calcCanvasSize = () => {
-    const { width, height } = this.props
+    const { width, height } = this.viewSize || {}
+    if (width && height) {
+      return { width, height }
+    }
+    const { width: w, height: h } = this.props
     return {
-      width: width - 10,
-      height: height - 80
+      width: w - 10,
+      height: h - 80
     }
   }
 
+  handleViewportResize = (width, height) => {
+    this.viewSize = { width, height }
+    this.updateViewLayout()
+  }
+
   buildWsUrl = (port, type = 'vnc', extra = '') => {
     const { host, tokenElecterm } = this.props.config
     const { id } = this.props.tab
@@ -127,30 +139,6 @@ export default class VncSession extends PureComponent {
     }
   }
 
-  renderControl = () => {
-    const contrlProps = this.getControlProps({
-      fixedPosition: false,
-      showExitFullscreen: false,
-      className: 'mg1l'
-    })
-    return (
-      <div className='pd1 fix session-v-info'>
-        <div className='fleft'>
-          <ReloadOutlined
-            onClick={this.handleReInit}
-            className='mg2r mg1l pointer'
-          />
-          {this.renderScreensSelect()}
-          {this.renderInfo()}
-        </div>
-        <div className='fright'>
-          {this.props.fullscreenIcon()}
-          <RemoteFloatControl {...contrlProps} />
-        </div>
-      </div>
-    )
-  }
-
   renderScreensSelect = () => {
     const {
       screens,
@@ -232,8 +220,9 @@ export default class VncSession extends PureComponent {
 
     const { width, height } = this.calcCanvasSize()
     const wsUrl = this.buildWsUrl(port, 'vnc', `&width=${width}&height=${height}`)
-    // When scaleViewport is false, we don't set fixed dimensions on the canvas
-    // so it can render at the actual remote screen size
+    // noVNC sizes its own canvas (`_screen` fills whatever box it is mounted
+    // into, the canvas is centered in it), so scaling is entirely driven by
+    // `scaleViewport` plus the size of the mount node.
     const vncOpts = {
       clipViewport,
       scaleViewport,
@@ -241,13 +230,6 @@ export default class VncSession extends PureComponent {
       qualityLevel, // JPEG quality 0-9, lower = faster
       compressionLevel, // Compression 0-9, lower = faster
       shared, // Allow shared connections
-      style: scaleViewport
-        ? {
-            width: width + 'px',
-            height: height + 'px',
-            overflow: 'hidden'
-          }
-        : {},
       credentials: {}
     }
     if (username) {
@@ -378,7 +360,7 @@ export default class VncSession extends PureComponent {
     for (const event of events) {
       rfb.addEventListener(event, this[`on${window.capitalizeFirstLetter(event)}`])
     }
-    rfb.scaleViewport = scaleViewport
+    rfb.scaleViewport = this.getFit()
     rfb.clipViewport = clipViewport
     rfb.qualityLevel = qualityLevel
     rfb.compressionLevel = compressionLevel
@@ -550,9 +532,10 @@ export default class VncSession extends PureComponent {
   }
 
   componentDidUpdate (prevProps, prevState) {
+    // viewport size changes are reported by the shell, the layout props are
+    // stale in fullscreen so they are not used here
     if (
-      prevProps.width !== this.props.width ||
-      prevProps.height !== this.props.height ||
+      prevProps.fullscreen !== this.props.fullscreen ||
       prevState.currentScreen !== this.state.currentScreen
     ) {
       this.updateViewLayout()
@@ -561,24 +544,25 @@ export default class VncSession extends PureComponent {
 
   updateViewLayout = () => {
     const { currentScreen, screens } = this.state
-    const { scaleViewport = true, clipViewport = false } = this.props.tab
+    const { clipViewport = false } = this.props.tab
     const container = this.domRef.current ? this.domRef.current.firstElementChild : null
 
     if (!this.rfb || !container) {
       return
     }
 
-    // Force re-apply scaleViewport to trigger autoscale logic (if enabled)
-    // or reset to 1.0 (if disabled)
-    this.rfb.scaleViewport = scaleViewport
+    // keep noVNC scaling in sync with our fit state, then re-run autoscale so
+    // our patched single screen logic sees the new viewport size
+    const fit = this.getFit()
+    this.rfb.scaleViewport = fit
     this.rfb.clipViewport = clipViewport
 
-    // Explicitly trigger autoscale to ensure our patched logic runs
-    if (scaleViewport && this.rfb._display) {
+    if (fit && this.rfb._display) {
       this.rfb._display.autoscale(container.clientWidth, container.clientHeight)
     }
 
     // Handle scrolling to the selected screen
+    clearTimeout(this.timer)
     this.timer = setTimeout(() => {
       if (currentScreen === 'all') {
         container.scrollTo(0, 0)
@@ -653,61 +637,45 @@ export default class VncSession extends PureComponent {
   }
 
   render () {
-    const { width: w, height: h } = this.props
     const { loading } = this.state
-    const { remoteWidth, remoteHeight } = this.getScreenSize()
-    const { scaleViewport = true } = this.props.tab
-    // When not in scale mode, we need a wrapper with container size,
-    // and the inner div should have remote screen size to show scrollbars
-    const isScaled = scaleViewport
-
-    const {
-      width: innerWidth,
-      height: innerHeight
-    } = this.calcCanvasSize()
-    const wrapperStyle = {
-      width: innerWidth + 'px',
-      height: innerHeight + 'px',
-      overflow: isScaled ? 'hidden' : 'auto'
-    }
-    const remoteStyle = {
-      width: isScaled ? '100%' : remoteWidth + 'px',
-      height: isScaled ? '100%' : remoteHeight + 'px',
-      overflow: 'hidden'
-    }
-    const divProps = {
-      style: remoteStyle,
-      className: 'vnc-session-wrap session-v-wrap'
-    }
-    const contrlProps = this.getControlProps()
-    const sessProps = {
-      className: 'vnc-session-wrap',
-      style: {
-        width: w + 'px',
-        height: h + 'px'
-      }
-    }
+    const floatProps = this.getControlProps()
+    const inlineProps = this.getControlProps({
+      fixedPosition: false,
+      showExitFullscreen: false,
+      className: 'mg1l'
+    })
+    const controlLeft = (
+      <>
+        <ReloadOutlined
+          onClick={this.handleReInit}
+          className='mg2r mg1l pointer'
+        />
+        {this.renderScreensSelect()}
+        {this.renderInfo()}
+      </>
+    )
+    const controlRight = (
+      <>
+        {this.props.fullscreenIcon()}
+        <RemoteFloatControl {...inlineProps} />
+      </>
+    )
     return (
-      <Spin spinning={loading}>
+      <RemoteSessionShell
+        loading={loading}
+        fit={this.getFit()}
+        wrapClassName='vnc-session-wrap'
+        onViewportResize={this.handleViewportResize}
+        controlLeft={controlLeft}
+        controlRight={controlRight}
+        floatControl={<RemoteFloatControl {...floatProps} />}
+        overlay={this.renderConfirm()}
+      >
         <div
-          {...sessProps}
-        >
-          {this.renderControl()}
-          <RemoteFloatControl
-            {...contrlProps}
-          />
-          <div
-            style={wrapperStyle}
-            className='vnc-scroll-wrapper'
-          >
-            <div
-              {...divProps}
-              ref={this.domRef}
-            />
-          </div>
-          {this.renderConfirm()}
-        </div>
-      </Spin>
+          className='remote-session-fill vnc-session-mount'
+          ref={this.domRef}
+        />
+      </RemoteSessionShell>
     )
   }
 }

package/client/components/vnc/vnc.styl

@@ -1,17 +1,26 @@
+// VNC only styling — the session layout (control bar, viewport, fit mode)
+// lives in the shared remote session shell: common/remote-session-shell.styl
 .vnc-session-wrap
-  display: flex
-  flex-direction: column
-  justify-content: center
-  align-items: center
-  .session-v-info
-    position: absolute
-    top: 0
-    left: 0
-    width: 100%
-  &.scale-viewport
-    .rdp-scroll-wrapper canvas
-      width: 100% !important
-      height: 100% !important
-      object-fit: contain
-  > div
-    background: transparent !important
+  .vnc-session-mount
+    // noVNC mounts its own screen element in here and sizes its canvas
+    // against this box, so it has to keep a definite size
+    width 100%
+    height 100%
+    // noVNC's screen element carries no class of its own: letterbox area
+    // follows the app theme instead of noVNC's own background
+    > div
+      background transparent !important
+      // scrolled when fit is off and the remote screen is bigger than
+      // the window
+      &::-webkit-scrollbar
+        width 16px
+        height 16px
+        background var(--main-darker)
+      &::-webkit-scrollbar-track
+        background var(--main-darker)
+        box-shadow inset 0 0 5px var(--main-darker)
+      &::-webkit-scrollbar-thumb
+        background var(--primary)
+        border-radius 0
+      &::-webkit-scrollbar-corner
+        background var(--main-darker)

package/client/css/mobile.styl

@@ -170,18 +170,31 @@
   .upgrade-panel
     max-width calc(100vw - 20px)
 
-  // ---- 9. Terminal touch support: prevent the browser's native long-press
-  //        callout (iOS "Copy/Look Up" menu) and text-selection gesture from
-  //        interfering with xterm's own touch handling and our custom
-  //        long-press context-menu detection. xterm.js already sets
-  //        user-select:none on .xterm; we additionally suppress the iOS
-  //        callout and set touch-action so the browser does not compete with
-  //        xterm for touch gesture interpretation.
+// ---------------------------------------------------------------------------
+// Terminal touch selection (behaviour in mixins/term-touch.js).
+//
+// Scoped to is-touch-device on top of the narrow-window is-mobile case: a
+// tablet held in landscape is wider than the 600px mobile breakpoint but is
+// still touch-primary and needs the same suppression, while store.isTouchDevice
+// keeps it off for anything mouse-driven (it follows the input in use — see
+// main.jsx).
+//
+// - the browser's native long-press callout (iOS "Copy/Look Up" menu) and its
+//   own text-selection gesture would fight xterm for the touch stream and
+//   swallow the long press that starts a selection;
+// - xterm already sets user-select:none on .xterm; touch-action:none stops the
+//   browser scrolling/zooming the page out from under a selection drag, since
+//   xterm does its own scrolling from gesture events.
+// ---------------------------------------------------------------------------
+.is-mobile,
+.is-touch-device
   .term-wrap
     -webkit-touch-callout none
     -webkit-tap-highlight-color transparent
     .xterm
       -webkit-touch-callout none
+      -webkit-user-select none
+      user-select none
       touch-action none
 
 // ---------------------------------------------------------------------------

package/client/store/setting.js

@@ -111,6 +111,10 @@ export default Store => {
       })
       store.setSettingItem(settingList().find(d => d.id === settingSyncId))
       store.openSettingModal()
+      // on mobile, jump straight to the sync form instead of the menu list
+      if (store.isMobile) {
+        store.settingMobileView = 'content'
+      }
     })
   }
 

package/client/store/tab.js

@@ -17,10 +17,10 @@ import generate from '../common/id-with-stamp'
 import uid from '../common/uid'
 import newTerm, { updateCount } from '../common/new-terminal.js'
 import { action } from 'manate'
-import { shouldCaptureSshReloadState } from '../components/terminal/ssh-reload-state.js'
+import { shouldCaptureTerminalReloadState } from '../components/terminal/ssh-reload-state.js'
 
 function captureSshSessionState (tab, config) {
-  return shouldCaptureSshReloadState(tab, config)
+  return shouldCaptureTerminalReloadState(tab, config)
     ? refs.get(`term-${tab.id}`)?.getReloadState?.()
     : undefined
 }
@@ -103,8 +103,9 @@ export default Store => {
     const oldTab = tabs[index]
     const oldBatch = oldTab.batch
 
-    // Reload state is captured only for an SSH refresh/reconnect. Closing a
-    // tab goes through removeTabs and never reaches this code path.
+    // Reload state is captured only for a shell terminal refresh/reconnect
+    // (ssh, local, telnet, serial). Closing a tab goes through removeTabs
+    // and never reaches this code path.
     const reloadState = captureSshSessionState(oldTab, store.config)
 
     // Create copy of old tab with new ID

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@electerm/electerm-react",
-  "version": "5.5.6",
+  "version": "5.5.15",
   "description": "react components src for electerm",
   "main": "./client/components/main/main.jsx",
   "license": "MIT",