@elasticias/screens 1.0.27 → 1.0.28

package/fesm2022/elasticias-screens.mjs

@@ -637,26 +637,45 @@ class AbstractDetailScreenComponent extends AbstractScreenComponent {
     print() {
         // Override in subclass to implement print functionality
     }
+    /**
+     * Name of the record being deleted, so the confirmation can say what
+     * it is about to destroy rather than asking about "this item".
+     * Override in the screen and return whatever a user recognises the
+     * record by — `return this.entity?.name;` is the usual body.
+     */
+    getDeleteConfirmName() {
+        return undefined;
+    }
     delete() {
-        if (!this.entityId)
-            return this.toastService.showError('Item [id] is undefined!');
-        this.confirmDialogService.confirm('Êtes-vous sûr de vouloir supprimer ?', () => this.serviceInstance.delete(this.entityId).subscribe({
-            next: (result) => {
-                if (result && result.errors && result.errors.length > 0) {
-                    this.handleErrors(result.errors);
-                }
-                else {
-                    this.toastService.showSuccess();
-                    this.navigateBack();
-                }
-            },
-            error: () => {
-                // Errors handled by global error handler
-            },
-        }), () => {
-            // User cancelled deletion
+        if (!this.entityId) {
+            this.recordNotFound();
+            return;
+        }
+        this.confirmDialogService.confirm({
+            intent: 'delete',
+            name: this.getDeleteConfirmName(),
+            accept: () => this.serviceInstance.delete(this.entityId).subscribe({
+                next: (result) => {
+                    if (result && result.errors && result.errors.length > 0) {
+                        this.handleErrors(result.errors);
+                    }
+                    else {
+                        this.toastService.showSuccess();
+                        this.navigateBack();
+                    }
+                },
+                error: () => {
+                    // Errors handled by global error handler
+                },
+            }),
         });
     }
+    /** The screen has no record id — it was removed by someone else, or the
+     *  route is stale. Say that, rather than the internal
+     *  "Item [id] is undefined!" this used to ship to end users. */
+    recordNotFound() {
+        this.toastService.show({ severity: 'error', textKey: 'ef_error_record_not_found' });
+    }
     navigateBack() {
         const currentUrl = this.router.url.split('?')[0];
         const detailsIndex = currentUrl.indexOf('/details');
@@ -893,34 +912,59 @@ class AbstractSearchScreenComponent extends AbstractScreenComponent {
     }
     edit(id) {
         if (!id) {
-            this.toastService.showError('Item [id] is undefined !');
+            this.recordNotFound();
             return;
         }
         this.router.navigate([this.currentUrl.concat('/details/'), id]);
     }
+    /**
+     * Name of the row being deleted, so the confirmation can say what it
+     * is about to destroy rather than asking about "this item". Override
+     * in the screen — look the row up in the loaded results and return
+     * whatever a user would recognise it by.
+     *
+     * ```ts
+     * protected override getDeleteConfirmName(id: any) {
+     *   return this.searchEntity.items?.find((r: any) => r.id === id)?.name;
+     * }
+     * ```
+     */
+    getDeleteConfirmName(_id) {
+        return undefined;
+    }
     delete(id) {
-        if (!id)
-            return this.toastService.showError('Item [id] is undefined!');
-        this.confirmDialogService.confirm('Êtes-vous sûr de vouloir supprimer ?', () => this.serviceInstance.delete(id).subscribe({
-            next: (result) => {
-                if (result && result.errors && result.errors.length > 0) {
-                    this.handleErrors(result.errors);
-                }
-                else {
-                    this.search();
-                    this.toastService.showSuccess();
-                }
-            },
-            error: () => {
-                // Errors handled by global error handler
-            },
-        }), () => {
-            // User cancelled deletion
+        if (!id) {
+            this.recordNotFound();
+            return;
+        }
+        this.confirmDialogService.confirm({
+            intent: 'delete',
+            name: this.getDeleteConfirmName(id),
+            accept: () => this.serviceInstance.delete(id).subscribe({
+                next: (result) => {
+                    if (result && result.errors && result.errors.length > 0) {
+                        this.handleErrors(result.errors);
+                    }
+                    else {
+                        this.search();
+                        this.toastService.showSuccess();
+                    }
+                },
+                error: () => {
+                    // Errors handled by global error handler
+                },
+            }),
         });
     }
+    /** The row the user acted on carries no id — it was removed by someone
+     *  else, or the list is stale. Say that, rather than the internal
+     *  "Item [id] is undefined!" this used to ship to end users. */
+    recordNotFound() {
+        this.toastService.show({ severity: 'error', textKey: 'ef_error_record_not_found' });
+    }
     duplicate(id) {
         if (!id) {
-            this.toastService.showError('Item [id] is undefined !');
+            this.recordNotFound();
             return;
         }
         this.router.navigate([this.currentUrl.concat('/details/'), id], { queryParams: { mode: 'duplicate' } });
@@ -1327,6 +1371,15 @@ class AbstractSearchScreenV2 extends AbstractScreenComponent {
         const cfg = this.getConfig();
         const hasDynamicRefs = (cfg?.SEARCH_REFERENTIALS_KEYS?.length ?? 0) > 0;
         const hasStaticLists = (cfg?.SEARCH_STATIC_LISTS?.length ?? 0) > 0;
+        // Busy from the first frame, not from the first request.
+        //
+        // A screen with referentials waits for them before it searches at all, and
+        // `loading` used to stay false for that entire window — so the table spent
+        // it showing "nothing here yet" to someone whose data was still being
+        // fetched. Six of the twelve list screens take that branch, including the
+        // one where this was measured at 910ms. `search()` sets the same flag
+        // again when it finally runs, so setting it here is idempotent.
+        this.loading.set(true);
         if (hasDynamicRefs || hasStaticLists) {
             if (hasDynamicRefs)
                 this.initializeReferenceKeys(cfg.SEARCH_REFERENTIALS_KEYS);
@@ -1648,35 +1701,60 @@ class AbstractSearchScreenV2 extends AbstractScreenComponent {
     }
     edit(id) {
         if (!id) {
-            this.toastService.showError('Item [id] is undefined !');
+            this.recordNotFound();
             return;
         }
         this.router.navigate([`${this.resolveListUrl()}/details`, id]);
     }
+    /**
+     * Name of the row being deleted, so the confirmation can say what it
+     * is about to destroy — "Delete ANDALOCY PARFUMS?" rather than
+     * "Delete?". Override in the screen; returning `undefined` keeps the
+     * generic message, which still reads correctly.
+     *
+     * ```ts
+     * protected override getDeleteConfirmName(id: any) {
+     *   return this.items().find(r => r.id === id)?.name;
+     * }
+     * ```
+     */
+    getDeleteConfirmName(_id) {
+        return undefined;
+    }
     delete(id) {
         if (!id) {
-            this.toastService.showError('Item [id] is undefined!');
+            this.recordNotFound();
             return;
         }
-        this.confirmDialogService.confirm('Êtes-vous sûr de vouloir supprimer ?', () => this.serviceInstance.delete(id).subscribe({
-            next: (result) => {
-                if (result?.errors?.length) {
-                    this.handleErrors(result.errors);
-                }
-                else {
-                    this.search();
-                    this.toastService.showSuccess();
-                }
-            },
-            // The HTTP error interceptor surfaces the message (toast). Swallow
-            // here so a rejected delete (e.g. a 422 business-rule violation)
-            // doesn't bubble up as an unhandled error.
-            error: () => undefined,
-        }), () => undefined);
+        this.confirmDialogService.confirm({
+            intent: 'delete',
+            name: this.getDeleteConfirmName(id),
+            accept: () => this.serviceInstance.delete(id).subscribe({
+                next: (result) => {
+                    if (result?.errors?.length) {
+                        this.handleErrors(result.errors);
+                    }
+                    else {
+                        this.search();
+                        this.toastService.showSuccess();
+                    }
+                },
+                // The HTTP error interceptor surfaces the message (toast). Swallow
+                // here so a rejected delete (e.g. a 422 business-rule violation)
+                // doesn't bubble up as an unhandled error.
+                error: () => undefined,
+            }),
+        });
+    }
+    /** The row the user acted on carries no id — it was removed by someone
+     *  else, or the list is stale. Say that, rather than the internal
+     *  "Item [id] is undefined!" this used to ship to end users. */
+    recordNotFound() {
+        this.toastService.show({ severity: 'error', textKey: 'ef_error_record_not_found' });
     }
     duplicate(id) {
         if (!id) {
-            this.toastService.showError('Item [id] is undefined !');
+            this.recordNotFound();
             return;
         }
         this.router.navigate([`${this.resolveListUrl()}/details`, id], {
@@ -1954,27 +2032,52 @@ class AbstractDetailScreenV2 extends AbstractScreenComponent {
     /**
      * Soft-delete-then-navigate-back. Confirms with the user first.
      */
+    /**
+     * Name of the record being deleted, so the confirmation can say what
+     * it is about to destroy — "Delete ANDALOCY PARFUMS?" rather than
+     * "Delete?". Override in the screen; returning `undefined` keeps the
+     * generic message, which still reads correctly.
+     *
+     * ```ts
+     * protected override getDeleteConfirmName() {
+     *   return this.entity()?.name;
+     * }
+     * ```
+     */
+    getDeleteConfirmName() {
+        return undefined;
+    }
     delete() {
         const id = this.entityId();
         if (!id) {
-            this.toastService.showError('Item [id] is undefined!');
+            this.recordNotFound();
             return;
         }
-        this.confirmDialogService.confirm('Êtes-vous sûr de vouloir supprimer ?', () => this.serviceInstance.delete(id).subscribe({
-            next: (result) => {
-                if (result?.errors?.length) {
-                    this.handleErrors(result.errors);
-                }
-                else {
-                    this.toastService.showSuccess();
-                    this.navigateBack();
-                }
-            },
-            // The HTTP error interceptor surfaces the message (toast).
-            // Swallow here so a rejected delete (e.g. a 422 business-rule
-            // violation) doesn't bubble up as an unhandled error.
-            error: () => undefined,
-        }), () => undefined);
+        this.confirmDialogService.confirm({
+            intent: 'delete',
+            name: this.getDeleteConfirmName(),
+            accept: () => this.serviceInstance.delete(id).subscribe({
+                next: (result) => {
+                    if (result?.errors?.length) {
+                        this.handleErrors(result.errors);
+                    }
+                    else {
+                        this.toastService.showSuccess();
+                        this.navigateBack();
+                    }
+                },
+                // The HTTP error interceptor surfaces the message (toast).
+                // Swallow here so a rejected delete (e.g. a 422 business-rule
+                // violation) doesn't bubble up as an unhandled error.
+                error: () => undefined,
+            }),
+        });
+    }
+    /** The screen has no record id — it was removed by someone else, or
+     *  the route is stale. Say that, rather than the internal
+     *  "Item [id] is undefined!" this used to ship to end users. */
+    recordNotFound() {
+        this.toastService.show({ severity: 'error', textKey: 'ef_error_record_not_found' });
     }
     /** Navigate to `/details/:id?mode=duplicate` so the abstract can
      *  reload the source entity, treat it as a template, and persist