@elastic/eui 91.0.0 → 91.2.0

package/es/components/datagrid/body/data_grid_cell_actions.js

@@ -23,14 +23,12 @@ import { EuiButtonIcon } from '../../button/button_icon';
 import { EuiButtonEmpty } from '../../button/button_empty';
 import { EuiFlexGroup, EuiFlexItem } from '../../flex';
 import { EuiPopoverFooter } from '../../popover';
-import classNames from 'classnames';
 import { jsx as ___EmotionJSX } from "@emotion/react";
 export var EuiDataGridCellActions = function EuiDataGridCellActions(_ref) {
   var onExpandClick = _ref.onExpandClick,
     column = _ref.column,
     rowIndex = _ref.rowIndex,
-    colIndex = _ref.colIndex,
-    cellHeightType = _ref.cellHeightType;
+    colIndex = _ref.colIndex;
   // Note: The cell expand button/expansion popover is *always* rendered if
   // column.cellActions is present (regardless of column.isExpandable).
   // This is because cell actions are not otherwise accessible to keyboard
@@ -41,11 +39,11 @@ export var EuiDataGridCellActions = function EuiDataGridCellActions(_ref) {
     default: "Click or hit enter to interact with cell content"
   }, function (expandButtonTitle) {
     return ___EmotionJSX(EuiButtonIcon, {
-      display: "fill",
-      className: "euiDataGridRowCell__actionButtonIcon",
+      className: "euiDataGridRowCell__actionButtonIcon euiDataGridRowCell__expandCell",
       "data-test-subj": "euiDataGridCellExpandButton",
+      display: "fill",
       color: "primary",
-      iconSize: "s",
+      iconSize: "m",
       iconType: "expandMini",
       "aria-hidden": true,
       onClick: onExpandClick,
@@ -57,8 +55,13 @@ export var EuiDataGridCellActions = function EuiDataGridCellActions(_ref) {
     var ButtonComponent = function ButtonComponent(props) {
       return ___EmotionJSX(EuiButtonIcon, _extends({}, props, {
         "aria-hidden": true,
-        className: "euiDataGridRowCell__actionButtonIcon",
-        iconSize: "s"
+        className: "euiDataGridRowCell__actionButtonIcon"
+        // Don't allow consumers to override sizes or colors for cell actions on hover/focus
+        ,
+        size: "xs",
+        iconSize: "s",
+        display: "fill",
+        color: "primary"
       }));
     };
     var _getVisibleCellAction = getVisibleCellActions(column === null || column === void 0 ? void 0 : column.cellActions, column === null || column === void 0 ? void 0 : column.visibleCellActions),
@@ -77,11 +80,8 @@ export var EuiDataGridCellActions = function EuiDataGridCellActions(_ref) {
       });
     });
   }, [column, colIndex, rowIndex]);
-  var classes = classNames('euiDataGridRowCell__actions', {
-    'euiDataGridRowCell__actions--overlay': cellHeightType !== 'default'
-  });
   return ___EmotionJSX("div", {
-    className: classes
+    className: "euiDataGridRowCell__actions"
   }, [].concat(_toConsumableArray(additionalButtons), [expandButton]));
 };
 export var EuiDataGridCellPopoverActions = function EuiDataGridCellPopoverActions(_ref2) {

package/es/components/datagrid/body/data_grid_cell_popover.js

@@ -32,6 +32,7 @@ export var DataGridCellPopoverContext = /*#__PURE__*/createContext({
   openCellPopover: function openCellPopover() {},
   closeCellPopover: function closeCellPopover() {},
   setPopoverAnchor: function setPopoverAnchor() {},
+  setPopoverAnchorPosition: function setPopoverAnchorPosition() {},
   setPopoverContent: function setPopoverContent() {},
   setCellPopoverProps: function setCellPopoverProps() {}
 });
@@ -54,15 +55,19 @@ export var useCellPopover = function useCellPopover() {
     _useState6 = _slicedToArray(_useState5, 2),
     popoverAnchor = _useState6[0],
     setPopoverAnchor = _useState6[1];
-  var _useState7 = useState(),
+  var _useState7 = useState('downLeft'),
     _useState8 = _slicedToArray(_useState7, 2),
-    popoverContent = _useState8[0],
-    setPopoverContent = _useState8[1];
-  // Allow customization of most (not all) popover props by consumers
-  var _useState9 = useState({}),
+    popoverAnchorPosition = _useState8[0],
+    setPopoverAnchorPosition = _useState8[1];
+  var _useState9 = useState(),
     _useState10 = _slicedToArray(_useState9, 2),
-    cellPopoverProps = _useState10[0],
-    setCellPopoverProps = _useState10[1];
+    popoverContent = _useState10[0],
+    setPopoverContent = _useState10[1];
+  // Allow customization of most (not all) popover props by consumers
+  var _useState11 = useState({}),
+    _useState12 = _slicedToArray(_useState11, 2),
+    cellPopoverProps = _useState12[0],
+    setCellPopoverProps = _useState12[1];
   var closeCellPopover = useCallback(function () {
     return setPopoverIsOpen(false);
   }, []);
@@ -89,29 +94,57 @@ export var useCellPopover = function useCellPopover() {
     openCellPopover: openCellPopover,
     cellLocation: cellLocation,
     setPopoverAnchor: setPopoverAnchor,
+    setPopoverAnchorPosition: setPopoverAnchorPosition,
     setPopoverContent: setPopoverContent,
     setCellPopoverProps: setCellPopoverProps
   };
 
+  // Override the default EuiPopover `onClickOutside` behavior, since the toggling
+  // popover button isn't actually the DOM node we pass to `button`. Otherwise,
+  // clicking the expansion cell action triggers an outside click
+  var onClickOutside = useCallback(function (event) {
+    var _popoverAnchor$parent, _popoverAnchor$parent2;
+    var cellActions = popoverAnchor === null || popoverAnchor === void 0 ? void 0 : (_popoverAnchor$parent = popoverAnchor.parentElement) === null || _popoverAnchor$parent === void 0 ? void 0 : (_popoverAnchor$parent2 = _popoverAnchor$parent.parentElement) === null || _popoverAnchor$parent2 === void 0 ? void 0 : _popoverAnchor$parent2.previousElementSibling;
+    if (!(cellActions !== null && cellActions !== void 0 && cellActions.contains(event.target))) {
+      closeCellPopover();
+    }
+  }, [popoverAnchor, closeCellPopover]);
+
   // Note that this popover is rendered once at the top grid level, rather than one popover per cell
   var cellPopover = popoverIsOpen && popoverAnchor && ___EmotionJSX(EuiWrappingPopover, _extends({
     isOpen: popoverIsOpen,
     display: "block",
     hasArrow: false,
-    panelPaddingSize: "s"
+    panelPaddingSize: "s",
+    anchorPosition: popoverAnchorPosition,
+    repositionToCrossAxis: false
   }, cellPopoverProps, {
+    focusTrapProps: {
+      onClickOutside: onClickOutside,
+      clickOutsideDisables: false
+    },
     panelProps: _objectSpread({
       'data-test-subj': 'euiDataGridExpansionPopover'
     }, cellPopoverProps.panelProps || {}),
     panelClassName: classNames('euiDataGridRowCell__popover', cellPopoverProps.panelClassName, (_cellPopoverProps$pan = cellPopoverProps.panelProps) === null || _cellPopoverProps$pan === void 0 ? void 0 : _cellPopoverProps$pan.className),
+    panelStyle: {
+      maxInlineSize: "min(75vw, max(".concat(popoverAnchor.parentElement.offsetWidth, "px, 400px))"),
+      maxBlockSize: '50vh'
+    },
     onKeyDown: function onKeyDown(event) {
       if (event.key === keys.F2 || event.key === keys.ESCAPE) {
+        var _popoverAnchor$parent3, _popoverAnchor$parent4;
         event.preventDefault();
         event.stopPropagation();
         closeCellPopover();
-        // Ensure focus is returned to the parent cell
+        var cell = (_popoverAnchor$parent3 = popoverAnchor.parentElement) === null || _popoverAnchor$parent3 === void 0 ? void 0 : (_popoverAnchor$parent4 = _popoverAnchor$parent3.parentElement) === null || _popoverAnchor$parent4 === void 0 ? void 0 : _popoverAnchor$parent4.parentElement;
+
+        // Prevent cell animation flash while focus is being shifted between popover and cell
+        cell === null || cell === void 0 ? void 0 : cell.setAttribute('data-keyboard-closing', 'true');
+        // Ensure focus is returned to the parent cell, and remove animation stopgap
         requestAnimationFrame(function () {
-          return popoverAnchor.parentElement.focus();
+          popoverAnchor.parentElement.focus();
+          cell === null || cell === void 0 ? void 0 : cell.removeAttribute('data-keyboard-closing');
         });
       }
     },