@elastic/eui 91.0.0 → 91.1.0

package/optimize/lib/components/form/range/range.a11y.js

@@ -55,15 +55,13 @@ describe('Single EuiRange', function () {
   });
   describe('Keyboard accessibility check', function () {
     it('has zero violations when the range slider is increased', function () {
-      cy.realPress('Tab');
-      cy.get('input#cy-range-single').should('have.focus');
+      cy.get('input#cy-range-single').focus();
       cy.repeatRealPress('ArrowRight', 10);
       cy.get('output.euiRangeTooltip__value').contains('100 - 110');
       cy.checkAxe();
     });
     it('has zero violations when the range slider is decreased', function () {
-      cy.realPress('Tab');
-      cy.get('input#cy-range-single').should('have.focus');
+      cy.get('input#cy-range-single').focus();
       cy.repeatRealPress('ArrowLeft', 10);
       cy.get('output.euiRangeTooltip__value').contains('100 - 100');
       cy.checkAxe();
@@ -102,8 +100,7 @@ describe('Dual EuiRange', function () {
   });
   describe('Keyboard accessibility check', function () {
     it('has zero violations when the range sliders are adjusted', function () {
-      cy.realPress('Tab');
-      cy.get('div[role="slider"]').first().should('have.focus');
+      cy.get('div[role="slider"]').first().focus();
       cy.repeatRealPress('ArrowLeft', 3);
       cy.get('div[role="slider"]').first().invoke('attr', 'aria-valuenow').should('eq', '70');
       cy.realPress('Tab');
@@ -144,8 +141,7 @@ describe('Highlight Area EuiRange', function () {
   });
   describe('Keyboard accessibility check', function () {
     it('has zero violations when the highlight area is adjusted using arrow keys', function () {
-      cy.realPress('Tab');
-      cy.get('div[role="slider"]').first().should('have.focus');
+      cy.get('div[role="slider"]').first().focus();
       cy.repeatRealPress('ArrowLeft', 3);
       cy.get('div[role="slider"]').first().invoke('attr', 'aria-valuetext').should('eq', '37, 57');
       cy.checkAxe();
@@ -190,8 +186,7 @@ describe('Highlight Area EuiRange', function () {
     });
     describe('Keyboard accessibility check', function () {
       it('updates the range value using arrow keys with input[type="number"]', function () {
-        cy.realPress('Tab');
-        cy.get('input#cy-range-in-dropdown').should('have.focus');
+        cy.get('input#cy-range-in-dropdown').focus();
         cy.repeatRealPress('ArrowUp', 10);
         cy.get('input[type="range"]').first().invoke('attr', 'value').should('eq', '30');
         cy.checkAxe();

package/optimize/lib/components/form/super_select/super_select.js

@@ -222,6 +222,7 @@ var EuiSuperSelect = /*#__PURE__*/function (_Component) {
           dropdownDisplay = option.dropdownDisplay,
           inputDisplay = option.inputDisplay,
           optionRest = (0, _objectWithoutProperties2.default)(option, _excluded2);
+        if (value == null) return;
         return (0, _react2.jsx)(_context_menu.EuiContextMenuItem, (0, _extends2.default)({
           key: index,
           className: itemClasses,
@@ -235,7 +236,7 @@ var EuiSuperSelect = /*#__PURE__*/function (_Component) {
             return _this2.setItemNode(node, index);
           },
           role: "option",
-          id: value,
+          id: String(value),
           "aria-selected": valueOfSelected === value
         }, optionRest), dropdownDisplay || inputDisplay);
       });
@@ -261,7 +262,7 @@ var EuiSuperSelect = /*#__PURE__*/function (_Component) {
           "aria-describedby": _this2.describedById,
           className: "euiSuperSelect__listbox",
           role: "listbox",
-          "aria-activedescendant": valueOfSelected,
+          "aria-activedescendant": valueOfSelected != null ? String(valueOfSelected) : undefined,
           tabIndex: 0
         }, items);
       }));

package/optimize/lib/components/form/super_select/super_select_control.js

@@ -28,8 +28,7 @@ var EuiSuperSelectControl = function EuiSuperSelectControl(props) {
   var _useFormContext = (0, _eui_form_context.useFormContext)(),
     defaultFullWidth = _useFormContext.defaultFullWidth;
   var className = props.className,
-    _props$options = props.options,
-    options = _props$options === void 0 ? [] : _props$options,
+    options = props.options,
     id = props.id,
     name = props.name,
     _props$fullWidth = props.fullWidth,
@@ -60,27 +59,21 @@ var EuiSuperSelectControl = function EuiSuperSelectControl(props) {
     'euiSuperSelectControl-isLoading': isLoading,
     'euiSuperSelectControl-isInvalid': isInvalid
   }, className);
-
-  // React HTML input can not have both value and defaultValue properties.
-  // https://reactjs.org/docs/uncontrolled-components.html#default-values
-  var selectDefaultValue;
-  if (value == null) {
-    selectDefaultValue = defaultValue || '';
-  }
-  var selectedValue;
-  if (value) {
-    var selectedOption = options.find(function (option) {
-      return option.value === value;
-    });
-    selectedValue = selectedOption ? selectedOption.inputDisplay : selectedValue;
-  }
+  var inputValue = value != null ? value : defaultValue;
+  var selectedValue = (0, _react.useMemo)(function () {
+    if (inputValue != null) {
+      var selectedOption = options === null || options === void 0 ? void 0 : options.find(function (option) {
+        return option.value === inputValue;
+      });
+      return selectedOption ? selectedOption.inputDisplay : undefined;
+    }
+  }, [inputValue, options]);
   var showPlaceholder = !!placeholder && !selectedValue;
-  return (0, _react2.jsx)(_react.Fragment, null, (0, _react2.jsx)("input", {
+  return (0, _react2.jsx)(_react.default.Fragment, null, (0, _react2.jsx)("input", {
     type: "hidden",
     id: id,
     name: name,
-    defaultValue: selectDefaultValue,
-    value: value,
+    value: String(inputValue !== null && inputValue !== void 0 ? inputValue : ''),
     readOnly: readOnly
   }), (0, _react2.jsx)(_form_control_layout.EuiFormControlLayout, {
     isDropdown: true,

package/optimize/lib/components/header/header.a11y.js

@@ -333,7 +333,7 @@ describe('EuiHeader', function () {
       cy.checkAxe();
     });
     it('has zero violations when a hidden breadcrumb is expanded', function () {
-      cy.get('button[aria-label="See collapsed breadcrumbs"]').realClick();
+      cy.get('button[title="See collapsed breadcrumbs"]').realClick();
       cy.get('a[data-test-subj="cy-breadcrumb-hidden"]').should('exist');
       cy.checkAxe();
     });

package/optimize/lib/components/image/image.a11y.js

@@ -45,8 +45,7 @@ describe('EuiImage', function () {
       cy.checkAxe();
     });
     it('has zero violations on keyboard interaction', function () {
-      cy.realPress('Tab');
-      cy.get('button[data-test-subj="activateFullScreenButton"]').should('have.focus');
+      cy.get('button[data-test-subj="activateFullScreenButton"]').focus();
       cy.realPress('Enter');
       cy.get('button[data-test-subj="deactivateFullScreenButton"]').should('exist');
       cy.get('button[data-test-subj="deactivateFullScreenButton"]').should('have.focus');

package/optimize/lib/components/key_pad_menu/key_pad_menu.a11y.js

@@ -133,20 +133,20 @@ describe('EuiKeyPadMenu', function () {
     });
     it('has zero violations on item click', function () {
       cy.get('a[data-test-subj="cy-keypad-link-2"]').realClick();
-      cy.get('a[data-test-subj="cy-keypad-link-2"]').should('have.class', 'euiKeyPadMenuItem-isSelected');
+      cy.get('a[data-test-subj="cy-keypad-link-2"]').should('have.attr', 'aria-current', 'true');
       cy.checkAxe();
     });
     it('has zero violations on item keypress', function () {
       cy.repeatRealPress('Tab', 3);
       cy.get('button[data-test-subj="cy-keypad-button-3"]').should('have.focus');
       cy.realPress('Space');
-      cy.get('button[data-test-subj="cy-keypad-button-3"]').should('have.class', 'euiKeyPadMenuItem-isSelected');
+      cy.get('button[data-test-subj="cy-keypad-button-3"]').should('have.attr', 'aria-pressed', 'true');
       cy.checkAxe();
       cy.realPress(['Shift', 'Tab']);
-      cy.get('button[data-test-subj="cy-keypad-button-2"]').should('have.focus');
+      cy.get('button[data-test-subj="cy-keypad-button-2"]').should('have.attr', 'aria-pressed', 'false');
       cy.realPress('Space');
-      cy.get('button[data-test-subj="cy-keypad-button-2"]').should('have.class', 'euiKeyPadMenuItem-isSelected');
-      cy.get('button[data-test-subj="cy-keypad-button-3"]').should('not.have.class', 'euiKeyPadMenuItem-isSelected');
+      cy.get('button[data-test-subj="cy-keypad-button-2"]').invoke('attr', 'aria-pressed').should('equal', 'true');
+      cy.get('button[data-test-subj="cy-keypad-button-3"]').invoke('attr', 'aria-pressed').should('equal', 'false');
       cy.checkAxe();
     });
   });

package/optimize/lib/components/link/external_link_icon.js

@@ -0,0 +1,47 @@
+"use strict";
+
+var _interopRequireDefault = require("@babel/runtime/helpers/interopRequireDefault");
+Object.defineProperty(exports, "__esModule", {
+  value: true
+});
+exports.EuiExternalLinkIcon = void 0;
+var _extends2 = _interopRequireDefault(require("@babel/runtime/helpers/extends"));
+var _objectWithoutProperties2 = _interopRequireDefault(require("@babel/runtime/helpers/objectWithoutProperties"));
+var _react = _interopRequireDefault(require("react"));
+var _services = require("../../services");
+var _global_styling = require("../../global_styling");
+var _icon = require("../icon");
+var _i18n = require("../i18n");
+var _accessibility = require("../accessibility");
+var _react2 = require("@emotion/react");
+var _excluded = ["target", "external"];
+/*
+ * Copyright Elasticsearch B.V. and/or licensed to Elasticsearch B.V. under one
+ * or more contributor license agreements. Licensed under the Elastic License
+ * 2.0 and the Server Side Public License, v 1; you may not use this file except
+ * in compliance with, at your election, the Elastic License 2.0 or the Server
+ * Side Public License, v 1.
+ */
+/**
+ * DRY util for indicating external links both via icon and to
+ * screen readers. Used internally by at EuiLink and EuiListGroupItem
+ */
+var EuiExternalLinkIcon = function EuiExternalLinkIcon(_ref) {
+  var target = _ref.target,
+    external = _ref.external,
+    rest = (0, _objectWithoutProperties2.default)(_ref, _excluded);
+  var _useEuiTheme = (0, _services.useEuiTheme)(),
+    euiTheme = _useEuiTheme.euiTheme;
+  var showExternalLinkIcon = target === '_blank' && external !== false || external === true;
+  var iconAriaLabel = (0, _i18n.useEuiI18n)('euiExternalLinkIcon.ariaLabel', 'External link');
+  return (0, _react2.jsx)(_react.default.Fragment, null, showExternalLinkIcon && (0, _react2.jsx)(_icon.EuiIcon, (0, _extends2.default)({
+    css: (0, _global_styling.logicalStyle)('margin-left', euiTheme.size.xs),
+    "aria-label": iconAriaLabel,
+    size: "s",
+    type: "popout"
+  }, rest)), target === '_blank' && (0, _react2.jsx)(_accessibility.EuiScreenReaderOnly, null, (0, _react2.jsx)("span", null, (0, _react2.jsx)(_i18n.EuiI18n, {
+    token: "euiExternalLinkIcon.newTarget.screenReaderOnlyText",
+    default: "(opens in a new tab or window)"
+  }))));
+};
+exports.EuiExternalLinkIcon = EuiExternalLinkIcon;

package/optimize/lib/components/link/link.js

@@ -12,11 +12,9 @@ var _objectWithoutProperties2 = _interopRequireDefault(require("@babel/runtime/h
 var _react = _interopRequireWildcard(require("react"));
 var _classnames = _interopRequireDefault(require("classnames"));
 var _services = require("../../services");
-var _link = require("./link.styles");
-var _icon = require("../icon");
-var _i18n = require("../i18n");
-var _accessibility = require("../accessibility");
 var _href_validator = require("../../services/security/href_validator");
+var _external_link_icon = require("./external_link_icon");
+var _link = require("./link.styles");
 var _react2 = require("@emotion/react");
 var _excluded = ["children", "color", "className", "href", "external", "target", "rel", "type", "onClick", "disabled"];
 /*
@@ -49,22 +47,8 @@ var EuiLink = /*#__PURE__*/(0, _react.forwardRef)(function (_ref, ref) {
   var euiTheme = (0, _services.useEuiTheme)();
   var styles = (0, _link.euiLinkStyles)(euiTheme);
   var cssStyles = [styles.euiLink];
-  var cssScreenReaderTextStyles = [styles.euiLink__screenReaderText];
-  var cssExternalLinkIconStyles = [styles.euiLink__externalIcon];
   var isHrefValid = !href || (0, _href_validator.validateHref)(href);
   var disabled = _disabled || !isHrefValid;
-  var newTargetScreenreaderText = (0, _react2.jsx)(_accessibility.EuiScreenReaderOnly, {
-    css: cssScreenReaderTextStyles
-  }, (0, _react2.jsx)("span", null, (0, _react2.jsx)(_i18n.EuiI18n, {
-    token: "euiLink.newTarget.screenReaderOnlyText",
-    default: "(opens in a new tab or window)"
-  })));
-  var externalLinkIcon = (0, _react2.jsx)(_icon.EuiIcon, {
-    "aria-label": (0, _i18n.useEuiI18n)('euiLink.external.ariaLabel', 'External link'),
-    size: "s",
-    css: cssExternalLinkIconStyles,
-    type: "popout"
-  });
   if (href === undefined || !isHrefValid) {
     var buttonProps = _objectSpread({
       className: (0, _classnames.default)('euiLink', className),
@@ -90,10 +74,12 @@ var EuiLink = /*#__PURE__*/(0, _react.forwardRef)(function (_ref, ref) {
     rel: secureRel,
     onClick: onClick
   }, rest);
-  var showExternalLinkIcon = target === '_blank' && external !== false || external === true;
   return (0, _react2.jsx)("a", (0, _extends2.default)({
     ref: ref
-  }, anchorProps), children, showExternalLinkIcon && externalLinkIcon, target === '_blank' && newTargetScreenreaderText);
+  }, anchorProps), children, (0, _react2.jsx)(_external_link_icon.EuiExternalLinkIcon, {
+    external: external,
+    target: target
+  }));
 });
 exports.EuiLink = EuiLink;
 EuiLink.displayName = 'EuiLink';

package/optimize/lib/components/link/link.styles.js

@@ -50,10 +50,7 @@ var euiLinkStyles = function euiLinkStyles(euiThemeContext) {
     danger: /*#__PURE__*/(0, _react.css)(_colorCSS(euiTheme.colors.dangerText), ";label:danger;"),
     warning: /*#__PURE__*/(0, _react.css)(_colorCSS(euiTheme.colors.warningText), ";label:warning;"),
     ghost: /*#__PURE__*/(0, _react.css)(_colorCSS(euiTheme.colors.ghost), ";label:ghost;"),
-    text: /*#__PURE__*/(0, _react.css)(_colorCSS(euiTheme.colors.text), ";label:text;"),
-    // Children
-    euiLink__screenReaderText: /*#__PURE__*/(0, _react.css)((0, _global_styling.logicalCSS)('left', '0px'), ";;label:euiLink__screenReaderText;"),
-    euiLink__externalIcon: /*#__PURE__*/(0, _react.css)((0, _global_styling.logicalCSS)('margin-left', euiTheme.size.xs), ";;label:euiLink__externalIcon;")
+    text: /*#__PURE__*/(0, _react.css)(_colorCSS(euiTheme.colors.text), ";label:text;")
   };
 };
 exports.euiLinkStyles = euiLinkStyles;

package/optimize/lib/components/list_group/list_group_item.js

@@ -18,9 +18,10 @@ var _inner_text = require("../inner_text");
 var _list_group_item_extra_action = require("./list_group_item_extra_action");
 var _services = require("../../services");
 var _href_validator = require("../../services/security/href_validator");
+var _external_link_icon = require("../link/external_link_icon");
 var _list_group_item = require("./list_group_item.styles");
 var _react2 = require("@emotion/react");
-var _excluded = ["label", "isActive", "isDisabled", "href", "target", "rel", "className", "css", "style", "iconType", "icon", "iconProps", "extraAction", "onClick", "size", "color", "showToolTip", "wrapText", "buttonRef", "toolTipText", "toolTipProps"],
+var _excluded = ["label", "isActive", "isDisabled", "href", "rel", "target", "external", "className", "css", "style", "iconType", "icon", "iconProps", "extraAction", "onClick", "size", "color", "showToolTip", "wrapText", "buttonRef", "toolTipText", "toolTipProps"],
   _excluded2 = ["iconType", "alwaysShow", "isDisabled"];
 /*
  * Copyright Elasticsearch B.V. and/or licensed to Elasticsearch B.V. under one
@@ -44,8 +45,9 @@ var EuiListGroupItem = function EuiListGroupItem(_ref) {
     _ref$isDisabled = _ref.isDisabled,
     _isDisabled = _ref$isDisabled === void 0 ? false : _ref$isDisabled,
     href = _ref.href,
-    target = _ref.target,
     rel = _ref.rel,
+    target = _ref.target,
+    external = _ref.external,
     className = _ref.className,
     customCss = _ref.css,
     style = _ref.style,
@@ -145,7 +147,10 @@ var EuiListGroupItem = function EuiListGroupItem(_ref) {
         target: target
       }),
       onClick: onClick
-    }, rest), iconNode, labelContent);
+    }, rest), iconNode, labelContent, (0, _react2.jsx)(_external_link_icon.EuiExternalLinkIcon, {
+      external: external,
+      target: target
+    }));
   } else if (href && isDisabled || onClick) {
     itemContent = (0, _react2.jsx)("button", (0, _extends2.default)({
       type: "button",

package/optimize/lib/components/list_group/list_group_item.styles.js

@@ -72,7 +72,8 @@ var euiListGroupItemInnerStyles = function euiListGroupItemInnerStyles(euiThemeC
     // Variants
     isDisabled: /*#__PURE__*/(0, _react.css)("cursor:not-allowed;&,&:hover,&:focus{color:", (0, _button.euiButtonColor)(euiThemeContext, 'disabled').color, ";cursor:not-allowed;background-color:transparent;text-decoration:none;};label:isDisabled;"),
     isActive: /*#__PURE__*/(0, _react.css)(";label:isActive;"),
-    isClickable: _ref
+    isClickable: _ref,
+    externalIcon: /*#__PURE__*/(0, _react.css)((0, _global_styling.logicalCSS)('margin-left', euiTheme.size.xs), ";;label:externalIcon;")
   };
 };
 exports.euiListGroupItemInnerStyles = euiListGroupItemInnerStyles;

package/optimize/lib/components/notification/notification_event.a11y.js

@@ -93,8 +93,7 @@ describe('EuiNotificationEvent', function () {
   });
   describe('Keyboard accessibility', function () {
     it('has zero violations when the popover is opened by keyboard', function () {
-      cy.repeatRealPress('Tab');
-      cy.get('button[data-test-subj="cy-eui-notification-1-notificationEventMetaButton"]').should('have.focus');
+      cy.get('button[data-test-subj="cy-eui-notification-1-notificationEventMetaButton"]').focus();
       cy.realPress('Enter');
       cy.get('div.euiPopover__panel').should('exist');
       cy.checkAxe();

package/optimize/lib/components/popover/popover.js

@@ -209,9 +209,12 @@ var EuiPopover = /*#__PURE__*/function (_Component) {
           anchor: _this.button,
           popover: _this.panel,
           offset: _this.props.attachToAnchor ? offset : _this.props.hasArrow ? 16 + offset : 8 + offset,
-          arrowConfig: {
+          arrowConfig: _this.props.hasArrow ? {
             arrowWidth: 24,
             arrowBuffer: 10
+          } : {
+            arrowWidth: 0,
+            arrowBuffer: 0
           },
           returnBoundingBox: _this.props.attachToAnchor,
           allowCrossAxis: _this.props.repositionToCrossAxis,

package/optimize/lib/components/resizable_container/resizable_container.a11y.js

@@ -52,22 +52,19 @@ describe('Horizontal EuiResizableContainer', function () {
   });
   describe('Keyboard accessibility check', function () {
     it('has zero violations when first panel is scrolled vertically', function () {
-      cy.realPress('Tab');
-      cy.get('div.euiPanel').first().should('have.focus');
+      cy.get('div.euiPanel').first().focus();
       cy.realPress('End');
       cy.get('a[data-test-subj="hello-world-link"]').should('be.visible');
       cy.checkAxe();
     });
     it('has zero violations when second panel is scrolled vertically', function () {
-      cy.repeatRealPress('Tab', 4);
-      cy.get('div.euiPanel').last().should('have.focus');
+      cy.get('div.euiPanel').last().focus();
       cy.realPress('End');
       cy.realPress('Home');
       cy.checkAxe();
     });
     it('has zero violations when the horizontal panels are resized', function () {
-      cy.repeatRealPress('Tab', 3);
-      cy.get('button.euiResizableButton').should('have.focus');
+      cy.get('button.euiResizableButton').focus();
       cy.repeatRealPress('ArrowRight', 10);
       cy.checkAxe();
     });
@@ -102,8 +99,7 @@ describe('Vertical EuiResizableContainer', function () {
       cy.checkAxe();
     });
     it('has zero violations when the vertical panels are resized', function () {
-      cy.repeatRealPress('Tab');
-      cy.get('button.euiResizableButton').should('have.focus');
+      cy.get('button.euiResizableButton').focus();
       cy.repeatRealPress('ArrowDown', 10);
       cy.checkAxe();
     });

package/optimize/lib/components/search_bar/search_bar.a11y.js

@@ -183,8 +183,7 @@ describe('EuiSearchBar', function () {
   });
   describe('Keyboard accessibility', function () {
     it('has zero violations after a full-text search', function () {
-      cy.realPress('Tab');
-      cy.get('input[type="search"]').should('have.focus');
+      cy.get('input[type="search"]').focus();
       cy.get('input[type="search"]').type('watch');
       cy.realPress('Enter');
       cy.get('table.euiTable tbody').find('tr').should('have.length', 1);
@@ -196,8 +195,7 @@ describe('EuiSearchBar', function () {
       cy.checkAxe();
     });
     it('has zero violations after filtering on Open items', function () {
-      cy.repeatRealPress('Tab');
-      cy.get('button.euiButtonEmpty').first().should('have.focus');
+      cy.get('button.euiButtonEmpty').first().focus();
       cy.realPress('Enter');
       cy.get('table.euiTable tbody').find('tr').should('have.length', 3);
       cy.checkAxe();
@@ -208,8 +206,7 @@ describe('EuiSearchBar', function () {
       cy.checkAxe();
     });
     it('has zero violations after filtering by Tags', function () {
-      cy.repeatRealPress('Tab', 4);
-      cy.get('button.euiButtonEmpty').last().should('have.focus');
+      cy.get('button.euiButtonEmpty').last().focus();
       cy.realPress('Enter');
       cy.realPress('Tab');
       cy.realPress('ArrowDown');