@elastic/eui 90.0.0 → 91.1.0

package/lib/components/facet/facet_button.js

@@ -129,7 +129,7 @@ EuiFacetButton.propTypes = {
      * Adds a notification indicator for displaying the quantity provided
      */
   quantity: _propTypes.default.number,
-  element: _propTypes.default.oneOf(["a", "button", "span", "label"]),
+  element: _propTypes.default.oneOf(["a", "button", "span"]),
   size: _propTypes.default.any,
   /**
      * Extends the button to 100% width
@@ -158,16 +158,18 @@ EuiFacetButton.propTypes = {
      */
   iconSide: _propTypes.default.oneOfType([_propTypes.default.any.isRequired, _propTypes.default.oneOf([undefined])]),
   /**
-     * Object of props passed to the <span/> wrapping the content's text/children only (not icon)
+     * Object of props passed to the `<span>` wrapping the content's text/children only (not icon)
+     *
+     * This span wrapper can be removed by passing `textProps={false}`.
      */
-  textProps: _propTypes.default.shape({
+  textProps: _propTypes.default.oneOfType([_propTypes.default.shape({
     className: _propTypes.default.string,
     "aria-label": _propTypes.default.string,
     "data-test-subj": _propTypes.default.string,
     css: _propTypes.default.any,
     ref: _propTypes.default.any,
     "data-text": _propTypes.default.string
-  }),
+  }).isRequired, _propTypes.default.oneOf([false])]),
   iconSize: _propTypes.default.any,
   className: _propTypes.default.string,
   "aria-label": _propTypes.default.string,

package/lib/components/filter_group/filter_button.js

@@ -85,7 +85,7 @@ var EuiFilterButton = function EuiFilterButton(_ref) {
   });
   var buttonTextClassNames = (0, _classnames.default)('euiFilterButton__text', {
     'euiFilterButton__text-hasNotification': showBadge
-  }, textProps === null || textProps === void 0 ? void 0 : textProps.className);
+  }, textProps && textProps.className);
   var badgeContent = showBadge && (0, _react2.jsx)(_badge.EuiNotificationBadge, {
     className: "euiFilterButton__notification",
     css: [notificationStyles.euiFilterButton__notification, isDisabled && notificationStyles.disabled, ";label:badgeContent;"],
@@ -115,7 +115,7 @@ var EuiFilterButton = function EuiFilterButton(_ref) {
     type: type,
     textProps: _objectSpread(_objectSpread({}, textProps), {}, {
       className: buttonTextClassNames,
-      css: [textStyles.euiFilterButton__text, showBadge && textStyles.hasNotification, textProps === null || textProps === void 0 ? void 0 : textProps.css]
+      css: [textStyles.euiFilterButton__text, showBadge && textStyles.hasNotification, textProps && textProps.css]
     }),
     contentProps: _objectSpread(_objectSpread({}, contentProps), {}, {
       css: [contentStyles.euiFilterButton__content, iconType && contentStyles.hasIcon, contentProps === null || contentProps === void 0 ? void 0 : contentProps.css]

package/lib/components/filter_group/filter_group.styles.js

@@ -32,7 +32,7 @@ var euiFilterGroupStyles = function euiFilterGroupStyles(euiThemeContext) {
     controlCompressedBorderRadius = _euiFormVariables.controlCompressedBorderRadius,
     controlCompressedHeight = _euiFormVariables.controlCompressedHeight;
   return {
-    euiFilterGroup: /*#__PURE__*/(0, _react.css)("display:inline-flex;", (0, _global_styling.logicalCSS)('max-width', '100%'), " overflow:hidden;background-color:", backgroundColor, ";box-shadow:inset 0 0 0 ", euiTheme.border.width.thin, " ", borderColor, ";>*:not(.euiFilterButton){", (0, _filter_button.euiFilterButtonDisplay)(euiThemeContext), ";}.euiPopover__anchor{display:block;.euiFilterButton{", (0, _global_styling.logicalCSS)('width', '100%'), ";}}", (0, _global_styling.euiBreakpoint)(euiThemeContext, ['xs', 's']), "{flex-wrap:wrap;}", (0, _global_styling.euiBreakpoint)(euiThemeContext, ['xs']), "{display:flex;.euiFilterButton{flex-grow:1;}};label:euiFilterGroup;"),
+    euiFilterGroup: /*#__PURE__*/(0, _react.css)("display:inline-flex;", (0, _global_styling.logicalCSS)('max-width', '100%'), " overflow:hidden;background-color:", backgroundColor, ";box-shadow:inset 0 0 0 ", euiTheme.border.width.thin, " ", borderColor, ";>*:not(.euiFilterButton){", (0, _filter_button.euiFilterButtonDisplay)(euiThemeContext), ";}.euiPopover>.euiFilterButton{", (0, _global_styling.logicalCSS)('width', '100%'), ";}", (0, _global_styling.euiBreakpoint)(euiThemeContext, ['xs', 's']), "{flex-wrap:wrap;}", (0, _global_styling.euiBreakpoint)(euiThemeContext, ['xs']), "{display:flex;.euiFilterButton{flex-grow:1;}};label:euiFilterGroup;"),
     fullWidth: _ref,
     uncompressed: /*#__PURE__*/(0, _react.css)("border-radius:", controlBorderRadius, ";", buttonChildrenBorderRadii(controlBorderRadius), ";;label:uncompressed;"),
     compressed: /*#__PURE__*/(0, _react.css)("border-radius:", controlCompressedBorderRadius, ";", buttonChildrenBorderRadii(controlCompressedBorderRadius), " .euiFilterButton{", (0, _global_styling.logicalCSS)('height', controlCompressedHeight), ";};label:compressed;"),

package/lib/components/focus_trap/focus_trap.a11y.js

@@ -108,12 +108,12 @@ describe('EuiFocusTrap', function () {
   });
   describe('Accessibility checks for keyboard navigation', function () {
     it('allows the button outside the FocusTrap to receive focus', function () {
-      cy.repeatRealPress('Tab', 5);
-      cy.get('button[data-test-subj="cy-external-button"]').should('have.focus');
+      cy.get('button[data-test-subj="cy-external-button"]').focus();
       cy.checkAxe();
     });
     it('prevents the button outside the FocusTrap from receiving focus', function () {
-      cy.repeatRealPress('Tab', 4);
+      cy.get('input[data-test-subj="cy-input-one"]').focus();
+      cy.repeatRealPress('Tab', 3);
       cy.realPress('Enter');
       cy.realPress('Tab');
       cy.get('input[data-test-subj="cy-input-one"]').should('have.focus');

package/lib/components/form/range/range.a11y.js

@@ -55,15 +55,13 @@ describe('Single EuiRange', function () {
   });
   describe('Keyboard accessibility check', function () {
     it('has zero violations when the range slider is increased', function () {
-      cy.realPress('Tab');
-      cy.get('input#cy-range-single').should('have.focus');
+      cy.get('input#cy-range-single').focus();
       cy.repeatRealPress('ArrowRight', 10);
       cy.get('output.euiRangeTooltip__value').contains('100 - 110');
       cy.checkAxe();
     });
     it('has zero violations when the range slider is decreased', function () {
-      cy.realPress('Tab');
-      cy.get('input#cy-range-single').should('have.focus');
+      cy.get('input#cy-range-single').focus();
       cy.repeatRealPress('ArrowLeft', 10);
       cy.get('output.euiRangeTooltip__value').contains('100 - 100');
       cy.checkAxe();
@@ -102,8 +100,7 @@ describe('Dual EuiRange', function () {
   });
   describe('Keyboard accessibility check', function () {
     it('has zero violations when the range sliders are adjusted', function () {
-      cy.realPress('Tab');
-      cy.get('div[role="slider"]').first().should('have.focus');
+      cy.get('div[role="slider"]').first().focus();
       cy.repeatRealPress('ArrowLeft', 3);
       cy.get('div[role="slider"]').first().invoke('attr', 'aria-valuenow').should('eq', '70');
       cy.realPress('Tab');
@@ -144,8 +141,7 @@ describe('Highlight Area EuiRange', function () {
   });
   describe('Keyboard accessibility check', function () {
     it('has zero violations when the highlight area is adjusted using arrow keys', function () {
-      cy.realPress('Tab');
-      cy.get('div[role="slider"]').first().should('have.focus');
+      cy.get('div[role="slider"]').first().focus();
       cy.repeatRealPress('ArrowLeft', 3);
       cy.get('div[role="slider"]').first().invoke('attr', 'aria-valuetext').should('eq', '37, 57');
       cy.checkAxe();
@@ -190,8 +186,7 @@ describe('Highlight Area EuiRange', function () {
     });
     describe('Keyboard accessibility check', function () {
       it('updates the range value using arrow keys with input[type="number"]', function () {
-        cy.realPress('Tab');
-        cy.get('input#cy-range-in-dropdown').should('have.focus');
+        cy.get('input#cy-range-in-dropdown').focus();
         cy.repeatRealPress('ArrowUp', 10);
         cy.get('input[type="range"]').first().invoke('attr', 'value').should('eq', '30');
         cy.checkAxe();

package/lib/components/form/super_select/super_select.js

@@ -228,6 +228,7 @@ var EuiSuperSelect = /*#__PURE__*/function (_Component) {
           dropdownDisplay = option.dropdownDisplay,
           inputDisplay = option.inputDisplay,
           optionRest = _objectWithoutProperties(option, _excluded2);
+        if (value == null) return;
         return (0, _react2.jsx)(_context_menu.EuiContextMenuItem, _extends({
           key: index,
           className: itemClasses,
@@ -241,7 +242,7 @@ var EuiSuperSelect = /*#__PURE__*/function (_Component) {
             return _this2.setItemNode(node, index);
           },
           role: "option",
-          id: value,
+          id: String(value),
           "aria-selected": valueOfSelected === value
         }, optionRest), dropdownDisplay || inputDisplay);
       });
@@ -267,7 +268,7 @@ var EuiSuperSelect = /*#__PURE__*/function (_Component) {
           "aria-describedby": _this2.describedById,
           className: "euiSuperSelect__listbox",
           role: "listbox",
-          "aria-activedescendant": valueOfSelected,
+          "aria-activedescendant": valueOfSelected != null ? String(valueOfSelected) : undefined,
           tabIndex: 0
         }, items);
       }));

package/lib/components/form/super_select/super_select_control.js

@@ -29,8 +29,7 @@ var EuiSuperSelectControl = function EuiSuperSelectControl(props) {
   var _useFormContext = (0, _eui_form_context.useFormContext)(),
     defaultFullWidth = _useFormContext.defaultFullWidth;
   var className = props.className,
-    _props$options = props.options,
-    options = _props$options === void 0 ? [] : _props$options,
+    options = props.options,
     id = props.id,
     name = props.name,
     _props$fullWidth = props.fullWidth,
@@ -61,27 +60,21 @@ var EuiSuperSelectControl = function EuiSuperSelectControl(props) {
     'euiSuperSelectControl-isLoading': isLoading,
     'euiSuperSelectControl-isInvalid': isInvalid
   }, className);
-
-  // React HTML input can not have both value and defaultValue properties.
-  // https://reactjs.org/docs/uncontrolled-components.html#default-values
-  var selectDefaultValue;
-  if (value == null) {
-    selectDefaultValue = defaultValue || '';
-  }
-  var selectedValue;
-  if (value) {
-    var selectedOption = options.find(function (option) {
-      return option.value === value;
-    });
-    selectedValue = selectedOption ? selectedOption.inputDisplay : selectedValue;
-  }
+  var inputValue = value != null ? value : defaultValue;
+  var selectedValue = (0, _react.useMemo)(function () {
+    if (inputValue != null) {
+      var selectedOption = options === null || options === void 0 ? void 0 : options.find(function (option) {
+        return option.value === inputValue;
+      });
+      return selectedOption ? selectedOption.inputDisplay : undefined;
+    }
+  }, [inputValue, options]);
   var showPlaceholder = !!placeholder && !selectedValue;
-  return (0, _react2.jsx)(_react.Fragment, null, (0, _react2.jsx)("input", {
+  return (0, _react2.jsx)(_react.default.Fragment, null, (0, _react2.jsx)("input", {
     type: "hidden",
     id: id,
     name: name,
-    defaultValue: selectDefaultValue,
-    value: value,
+    value: String(inputValue !== null && inputValue !== void 0 ? inputValue : ''),
     readOnly: readOnly
   }), (0, _react2.jsx)(_form_control_layout.EuiFormControlLayout, {
     isDropdown: true,

package/lib/components/header/header.a11y.js

@@ -333,7 +333,7 @@ describe('EuiHeader', function () {
       cy.checkAxe();
     });
     it('has zero violations when a hidden breadcrumb is expanded', function () {
-      cy.get('button[aria-label="See collapsed breadcrumbs"]').realClick();
+      cy.get('button[title="See collapsed breadcrumbs"]').realClick();
       cy.get('a[data-test-subj="cy-breadcrumb-hidden"]').should('exist');
       cy.checkAxe();
     });

package/lib/components/header/header_links/header_link.js

@@ -84,10 +84,10 @@ EuiHeaderLink.propTypes = {
   type: _propTypes.default.oneOf(["button", "submit"]),
   buttonRef: _propTypes.default.any,
   /**
-     * Object of props passed to the <span/> wrapping the button's content
+     * Object of props passed to the `<span>` wrapping the button's content
      */
   /**
-     * Object of props passed to the <span/> wrapping the button's content
+     * Object of props passed to the `<span>` wrapping the button's content
      */
   contentProps: _propTypes.default.shape({
     className: _propTypes.default.string,
@@ -104,16 +104,18 @@ EuiHeaderLink.propTypes = {
      */
   iconSide: _propTypes.default.oneOfType([_propTypes.default.any.isRequired, _propTypes.default.oneOf([undefined])]),
   /**
-     * Object of props passed to the <span/> wrapping the content's text/children only (not icon)
+     * Object of props passed to the `<span>` wrapping the content's text/children only (not icon)
+     *
+     * This span wrapper can be removed by passing `textProps={false}`.
      */
-  textProps: _propTypes.default.shape({
+  textProps: _propTypes.default.oneOfType([_propTypes.default.shape({
     className: _propTypes.default.string,
     "aria-label": _propTypes.default.string,
     "data-test-subj": _propTypes.default.string,
     css: _propTypes.default.any,
     ref: _propTypes.default.any,
     "data-text": _propTypes.default.string
-  }),
+  }).isRequired, _propTypes.default.oneOf([false])]),
   iconSize: _propTypes.default.any,
   className: _propTypes.default.string,
   "aria-label": _propTypes.default.string,

package/lib/components/header/header_section/header_section_item_button.js

@@ -227,10 +227,10 @@ EuiHeaderSectionItemButton.propTypes = {
   type: _propTypes.default.oneOf(["button", "submit"]),
   buttonRef: _propTypes.default.any,
   /**
-     * Object of props passed to the <span/> wrapping the button's content
+     * Object of props passed to the `<span>` wrapping the button's content
      */
   /**
-     * Object of props passed to the <span/> wrapping the button's content
+     * Object of props passed to the `<span>` wrapping the button's content
      */
   contentProps: _propTypes.default.shape({
     className: _propTypes.default.string,
@@ -247,16 +247,18 @@ EuiHeaderSectionItemButton.propTypes = {
      */
   iconSide: _propTypes.default.oneOfType([_propTypes.default.any.isRequired, _propTypes.default.oneOf([undefined])]),
   /**
-     * Object of props passed to the <span/> wrapping the content's text/children only (not icon)
+     * Object of props passed to the `<span>` wrapping the content's text/children only (not icon)
+     *
+     * This span wrapper can be removed by passing `textProps={false}`.
      */
-  textProps: _propTypes.default.shape({
+  textProps: _propTypes.default.oneOfType([_propTypes.default.shape({
     className: _propTypes.default.string,
     "aria-label": _propTypes.default.string,
     "data-test-subj": _propTypes.default.string,
     css: _propTypes.default.any,
     ref: _propTypes.default.any,
     "data-text": _propTypes.default.string
-  }),
+  }).isRequired, _propTypes.default.oneOf([false])]),
   iconSize: _propTypes.default.any,
   className: _propTypes.default.string,
   "aria-label": _propTypes.default.string,

package/lib/components/i18n/i18n.js

@@ -83,6 +83,7 @@ var EuiI18n = function EuiI18n(props) {
           i18nMapping: mapping,
           i18nMappingFunc: mappingFunc,
           valueDefault: props.defaults[idx],
+          values: props.values,
           render: render
         });
       }));

package/lib/components/image/image.a11y.js

@@ -45,8 +45,7 @@ describe('EuiImage', function () {
       cy.checkAxe();
     });
     it('has zero violations on keyboard interaction', function () {
-      cy.realPress('Tab');
-      cy.get('button[data-test-subj="activateFullScreenButton"]').should('have.focus');
+      cy.get('button[data-test-subj="activateFullScreenButton"]').focus();
       cy.realPress('Enter');
       cy.get('button[data-test-subj="deactivateFullScreenButton"]').should('exist');
       cy.get('button[data-test-subj="deactivateFullScreenButton"]').should('have.focus');

package/lib/components/key_pad_menu/key_pad_menu.a11y.js

@@ -133,20 +133,20 @@ describe('EuiKeyPadMenu', function () {
     });
     it('has zero violations on item click', function () {
       cy.get('a[data-test-subj="cy-keypad-link-2"]').realClick();
-      cy.get('a[data-test-subj="cy-keypad-link-2"]').should('have.class', 'euiKeyPadMenuItem-isSelected');
+      cy.get('a[data-test-subj="cy-keypad-link-2"]').should('have.attr', 'aria-current', 'true');
       cy.checkAxe();
     });
     it('has zero violations on item keypress', function () {
       cy.repeatRealPress('Tab', 3);
       cy.get('button[data-test-subj="cy-keypad-button-3"]').should('have.focus');
       cy.realPress('Space');
-      cy.get('button[data-test-subj="cy-keypad-button-3"]').should('have.class', 'euiKeyPadMenuItem-isSelected');
+      cy.get('button[data-test-subj="cy-keypad-button-3"]').should('have.attr', 'aria-pressed', 'true');
       cy.checkAxe();
       cy.realPress(['Shift', 'Tab']);
-      cy.get('button[data-test-subj="cy-keypad-button-2"]').should('have.focus');
+      cy.get('button[data-test-subj="cy-keypad-button-2"]').should('have.attr', 'aria-pressed', 'false');
       cy.realPress('Space');
-      cy.get('button[data-test-subj="cy-keypad-button-2"]').should('have.class', 'euiKeyPadMenuItem-isSelected');
-      cy.get('button[data-test-subj="cy-keypad-button-3"]').should('not.have.class', 'euiKeyPadMenuItem-isSelected');
+      cy.get('button[data-test-subj="cy-keypad-button-2"]').invoke('attr', 'aria-pressed').should('equal', 'true');
+      cy.get('button[data-test-subj="cy-keypad-button-3"]').invoke('attr', 'aria-pressed').should('equal', 'false');
       cy.checkAxe();
     });
   });

package/lib/components/link/external_link_icon.js

@@ -0,0 +1,57 @@
+"use strict";
+
+Object.defineProperty(exports, "__esModule", {
+  value: true
+});
+exports.EuiExternalLinkIcon = void 0;
+var _react = _interopRequireDefault(require("react"));
+var _propTypes = _interopRequireDefault(require("prop-types"));
+var _services = require("../../services");
+var _global_styling = require("../../global_styling");
+var _icon = require("../icon");
+var _i18n = require("../i18n");
+var _accessibility = require("../accessibility");
+var _react2 = require("@emotion/react");
+var _excluded = ["target", "external"];
+/*
+ * Copyright Elasticsearch B.V. and/or licensed to Elasticsearch B.V. under one
+ * or more contributor license agreements. Licensed under the Elastic License
+ * 2.0 and the Server Side Public License, v 1; you may not use this file except
+ * in compliance with, at your election, the Elastic License 2.0 or the Server
+ * Side Public License, v 1.
+ */
+/**
+ * DRY util for indicating external links both via icon and to
+ * screen readers. Used internally by at EuiLink and EuiListGroupItem
+ */
+function _interopRequireDefault(obj) { return obj && obj.__esModule ? obj : { default: obj }; }
+function _extends() { _extends = Object.assign ? Object.assign.bind() : function (target) { for (var i = 1; i < arguments.length; i++) { var source = arguments[i]; for (var key in source) { if (Object.prototype.hasOwnProperty.call(source, key)) { target[key] = source[key]; } } } return target; }; return _extends.apply(this, arguments); }
+function _objectWithoutProperties(source, excluded) { if (source == null) return {}; var target = _objectWithoutPropertiesLoose(source, excluded); var key, i; if (Object.getOwnPropertySymbols) { var sourceSymbolKeys = Object.getOwnPropertySymbols(source); for (i = 0; i < sourceSymbolKeys.length; i++) { key = sourceSymbolKeys[i]; if (excluded.indexOf(key) >= 0) continue; if (!Object.prototype.propertyIsEnumerable.call(source, key)) continue; target[key] = source[key]; } } return target; }
+function _objectWithoutPropertiesLoose(source, excluded) { if (source == null) return {}; var target = {}; var sourceKeys = Object.keys(source); var key, i; for (i = 0; i < sourceKeys.length; i++) { key = sourceKeys[i]; if (excluded.indexOf(key) >= 0) continue; target[key] = source[key]; } return target; }
+var EuiExternalLinkIcon = function EuiExternalLinkIcon(_ref) {
+  var target = _ref.target,
+    external = _ref.external,
+    rest = _objectWithoutProperties(_ref, _excluded);
+  var _useEuiTheme = (0, _services.useEuiTheme)(),
+    euiTheme = _useEuiTheme.euiTheme;
+  var showExternalLinkIcon = target === '_blank' && external !== false || external === true;
+  var iconAriaLabel = (0, _i18n.useEuiI18n)('euiExternalLinkIcon.ariaLabel', 'External link');
+  return (0, _react2.jsx)(_react.default.Fragment, null, showExternalLinkIcon && (0, _react2.jsx)(_icon.EuiIcon, _extends({
+    css: (0, _global_styling.logicalStyle)('margin-left', euiTheme.size.xs),
+    "aria-label": iconAriaLabel,
+    size: "s",
+    type: "popout"
+  }, rest)), target === '_blank' && (0, _react2.jsx)(_accessibility.EuiScreenReaderOnly, null, (0, _react2.jsx)("span", null, (0, _react2.jsx)(_i18n.EuiI18n, {
+    token: "euiExternalLinkIcon.newTarget.screenReaderOnlyText",
+    default: "(opens in a new tab or window)"
+  }))));
+};
+exports.EuiExternalLinkIcon = EuiExternalLinkIcon;
+EuiExternalLinkIcon.propTypes = {
+  target: _propTypes.default.any,
+  /**
+     * Set to true to show an icon indicating that it is an external link;
+     * Defaults to true if `target="_blank"`
+     */
+  external: _propTypes.default.bool
+};

package/lib/components/link/link.js

@@ -9,11 +9,9 @@ var _react = _interopRequireWildcard(require("react"));
 var _propTypes = _interopRequireDefault(require("prop-types"));
 var _classnames = _interopRequireDefault(require("classnames"));
 var _services = require("../../services");
-var _link = require("./link.styles");
-var _icon = require("../icon");
-var _i18n = require("../i18n");
-var _accessibility = require("../accessibility");
 var _href_validator = require("../../services/security/href_validator");
+var _external_link_icon = require("./external_link_icon");
+var _link = require("./link.styles");
 var _react2 = require("@emotion/react");
 var _excluded = ["children", "color", "className", "href", "external", "target", "rel", "type", "onClick", "disabled"];
 /*
@@ -53,22 +51,8 @@ var EuiLink = /*#__PURE__*/(0, _react.forwardRef)(function (_ref, ref) {
   var euiTheme = (0, _services.useEuiTheme)();
   var styles = (0, _link.euiLinkStyles)(euiTheme);
   var cssStyles = [styles.euiLink];
-  var cssScreenReaderTextStyles = [styles.euiLink__screenReaderText];
-  var cssExternalLinkIconStyles = [styles.euiLink__externalIcon];
   var isHrefValid = !href || (0, _href_validator.validateHref)(href);
   var disabled = _disabled || !isHrefValid;
-  var newTargetScreenreaderText = (0, _react2.jsx)(_accessibility.EuiScreenReaderOnly, {
-    css: cssScreenReaderTextStyles
-  }, (0, _react2.jsx)("span", null, (0, _react2.jsx)(_i18n.EuiI18n, {
-    token: "euiLink.newTarget.screenReaderOnlyText",
-    default: "(opens in a new tab or window)"
-  })));
-  var externalLinkIcon = (0, _react2.jsx)(_icon.EuiIcon, {
-    "aria-label": (0, _i18n.useEuiI18n)('euiLink.external.ariaLabel', 'External link'),
-    size: "s",
-    css: cssExternalLinkIconStyles,
-    type: "popout"
-  });
   if (href === undefined || !isHrefValid) {
     var buttonProps = _objectSpread({
       className: (0, _classnames.default)('euiLink', className),
@@ -94,10 +78,12 @@ var EuiLink = /*#__PURE__*/(0, _react.forwardRef)(function (_ref, ref) {
     rel: secureRel,
     onClick: onClick
   }, rest);
-  var showExternalLinkIcon = target === '_blank' && external !== false || external === true;
   return (0, _react2.jsx)("a", _extends({
     ref: ref
-  }, anchorProps), children, showExternalLinkIcon && externalLinkIcon, target === '_blank' && newTargetScreenreaderText);
+  }, anchorProps), children, (0, _react2.jsx)(_external_link_icon.EuiExternalLinkIcon, {
+    external: external,
+    target: target
+  }));
 });
 exports.EuiLink = EuiLink;
 EuiLink.propTypes = {

package/lib/components/link/link.styles.js

@@ -50,10 +50,7 @@ var euiLinkStyles = function euiLinkStyles(euiThemeContext) {
     danger: /*#__PURE__*/(0, _react.css)(_colorCSS(euiTheme.colors.dangerText), ";label:danger;"),
     warning: /*#__PURE__*/(0, _react.css)(_colorCSS(euiTheme.colors.warningText), ";label:warning;"),
     ghost: /*#__PURE__*/(0, _react.css)(_colorCSS(euiTheme.colors.ghost), ";label:ghost;"),
-    text: /*#__PURE__*/(0, _react.css)(_colorCSS(euiTheme.colors.text), ";label:text;"),
-    // Children
-    euiLink__screenReaderText: /*#__PURE__*/(0, _react.css)((0, _global_styling.logicalCSS)('left', '0px'), ";;label:euiLink__screenReaderText;"),
-    euiLink__externalIcon: /*#__PURE__*/(0, _react.css)((0, _global_styling.logicalCSS)('margin-left', euiTheme.size.xs), ";;label:euiLink__externalIcon;")
+    text: /*#__PURE__*/(0, _react.css)(_colorCSS(euiTheme.colors.text), ";label:text;")
   };
 };
 exports.euiLinkStyles = euiLinkStyles;

package/lib/components/list_group/list_group.js

@@ -149,8 +149,13 @@ EuiListGroup.propTypes = {
          * While permitted, `href` and `onClick` should not be used together in most cases and may create problems.
          */
     href: _propTypes.default.string,
-    target: _propTypes.default.string,
     rel: _propTypes.default.string,
+    target: _propTypes.default.string,
+    /**
+         * Set to true to show an icon indicating that it is an external link;
+         * Defaults to true if `target="_blank"`
+         */
+    external: _propTypes.default.bool,
     /**
          * Adds `EuiIcon` of `EuiIcon.type`
          */

package/lib/components/list_group/list_group_item.js

@@ -14,9 +14,10 @@ var _inner_text = require("../inner_text");
 var _list_group_item_extra_action = require("./list_group_item_extra_action");
 var _services = require("../../services");
 var _href_validator = require("../../services/security/href_validator");
+var _external_link_icon = require("../link/external_link_icon");
 var _list_group_item = require("./list_group_item.styles");
 var _react2 = require("@emotion/react");
-var _excluded = ["label", "isActive", "isDisabled", "href", "target", "rel", "className", "css", "style", "iconType", "icon", "iconProps", "extraAction", "onClick", "size", "color", "showToolTip", "wrapText", "buttonRef", "toolTipText", "toolTipProps"],
+var _excluded = ["label", "isActive", "isDisabled", "href", "rel", "target", "external", "className", "css", "style", "iconType", "icon", "iconProps", "extraAction", "onClick", "size", "color", "showToolTip", "wrapText", "buttonRef", "toolTipText", "toolTipProps"],
   _excluded2 = ["iconType", "alwaysShow", "isDisabled"];
 /*
  * Copyright Elasticsearch B.V. and/or licensed to Elasticsearch B.V. under one
@@ -53,8 +54,9 @@ var EuiListGroupItem = function EuiListGroupItem(_ref) {
     _ref$isDisabled = _ref.isDisabled,
     _isDisabled = _ref$isDisabled === void 0 ? false : _ref$isDisabled,
     href = _ref.href,
-    target = _ref.target,
     rel = _ref.rel,
+    target = _ref.target,
+    external = _ref.external,
     className = _ref.className,
     customCss = _ref.css,
     style = _ref.style,
@@ -154,7 +156,10 @@ var EuiListGroupItem = function EuiListGroupItem(_ref) {
         target: target
       }),
       onClick: onClick
-    }, rest), iconNode, labelContent);
+    }, rest), iconNode, labelContent, (0, _react2.jsx)(_external_link_icon.EuiExternalLinkIcon, {
+      external: external,
+      target: target
+    }));
   } else if (href && isDisabled || onClick) {
     itemContent = (0, _react2.jsx)("button", _extends({
       type: "button",
@@ -234,8 +239,13 @@ EuiListGroupItem.propTypes = {
        * While permitted, `href` and `onClick` should not be used together in most cases and may create problems.
        */
   href: _propTypes.default.string,
-  target: _propTypes.default.string,
   rel: _propTypes.default.string,
+  target: _propTypes.default.string,
+  /**
+       * Set to true to show an icon indicating that it is an external link;
+       * Defaults to true if `target="_blank"`
+       */
+  external: _propTypes.default.bool,
   /**
        * Adds `EuiIcon` of `EuiIcon.type`
        */

package/lib/components/list_group/list_group_item.styles.js

@@ -72,7 +72,8 @@ var euiListGroupItemInnerStyles = function euiListGroupItemInnerStyles(euiThemeC
     // Variants
     isDisabled: /*#__PURE__*/(0, _react.css)("cursor:not-allowed;&,&:hover,&:focus{color:", (0, _button.euiButtonColor)(euiThemeContext, 'disabled').color, ";cursor:not-allowed;background-color:transparent;text-decoration:none;};label:isDisabled;"),
     isActive: /*#__PURE__*/(0, _react.css)(";label:isActive;"),
-    isClickable: _ref
+    isClickable: _ref,
+    externalIcon: /*#__PURE__*/(0, _react.css)((0, _global_styling.logicalCSS)('margin-left', euiTheme.size.xs), ";;label:externalIcon;")
   };
 };
 exports.euiListGroupItemInnerStyles = euiListGroupItemInnerStyles;

package/lib/components/list_group/pinnable_list_group/pinnable_list_group.js

@@ -145,8 +145,13 @@ EuiPinnableListGroup.propTypes = {
          * While permitted, `href` and `onClick` should not be used together in most cases and may create problems.
          */
     href: _propTypes.default.string,
-    target: _propTypes.default.string,
     rel: _propTypes.default.string,
+    target: _propTypes.default.string,
+    /**
+         * Set to true to show an icon indicating that it is an external link;
+         * Defaults to true if `target="_blank"`
+         */
+    external: _propTypes.default.bool,
     /**
          * Adds `EuiIcon` of `EuiIcon.type`
          */
@@ -276,8 +281,13 @@ EuiPinnableListGroup.propTypes = {
          * While permitted, `href` and `onClick` should not be used together in most cases and may create problems.
          */
     href: _propTypes.default.string,
-    target: _propTypes.default.string,
     rel: _propTypes.default.string,
+    target: _propTypes.default.string,
+    /**
+         * Set to true to show an icon indicating that it is an external link;
+         * Defaults to true if `target="_blank"`
+         */
+    external: _propTypes.default.bool,
     /**
          * Adds `EuiIcon` of `EuiIcon.type`
          */

package/lib/components/notification/notification_event.a11y.js

@@ -93,8 +93,7 @@ describe('EuiNotificationEvent', function () {
   });
   describe('Keyboard accessibility', function () {
     it('has zero violations when the popover is opened by keyboard', function () {
-      cy.repeatRealPress('Tab');
-      cy.get('button[data-test-subj="cy-eui-notification-1-notificationEventMetaButton"]').should('have.focus');
+      cy.get('button[data-test-subj="cy-eui-notification-1-notificationEventMetaButton"]').focus();
       cy.realPress('Enter');
       cy.get('div.euiPopover__panel').should('exist');
       cy.checkAxe();

package/lib/components/notification/notification_event.js

@@ -236,10 +236,10 @@ EuiNotificationEvent.propTypes = {
     type: _propTypes.default.oneOf(["button", "submit"]),
     buttonRef: _propTypes.default.any,
     /**
-       * Object of props passed to the <span/> wrapping the button's content
+       * Object of props passed to the `<span>` wrapping the button's content
        */
     /**
-       * Object of props passed to the <span/> wrapping the button's content
+       * Object of props passed to the `<span>` wrapping the button's content
        */
     contentProps: _propTypes.default.shape({
       className: _propTypes.default.string,
@@ -256,16 +256,18 @@ EuiNotificationEvent.propTypes = {
        */
     iconSide: _propTypes.default.oneOfType([_propTypes.default.any.isRequired, _propTypes.default.oneOf([undefined])]),
     /**
-       * Object of props passed to the <span/> wrapping the content's text/children only (not icon)
+       * Object of props passed to the `<span>` wrapping the content's text/children only (not icon)
+       *
+       * This span wrapper can be removed by passing `textProps={false}`.
        */
-    textProps: _propTypes.default.shape({
+    textProps: _propTypes.default.oneOfType([_propTypes.default.shape({
       className: _propTypes.default.string,
       "aria-label": _propTypes.default.string,
       "data-test-subj": _propTypes.default.string,
       css: _propTypes.default.any,
       ref: _propTypes.default.any,
       "data-text": _propTypes.default.string
-    }),
+    }).isRequired, _propTypes.default.oneOf([false])]),
     iconSize: _propTypes.default.any,
     className: _propTypes.default.string,
     "aria-label": _propTypes.default.string,

package/lib/components/popover/input_popover.js

@@ -187,7 +187,7 @@ var EuiInputPopover = function EuiInputPopover(_ref) {
     css: /*#__PURE__*/(0, _react2.css)(fullWidth ? undefined : (0, _global_styling.logicalCSS)('max-width', form.maxWidth), ";label:EuiInputPopover;"),
     display: display,
     button: input,
-    buttonRef: inputRef,
+    popoverRef: inputRef,
     panelRef: panelRef,
     ref: popoverClassRef,
     closePopover: closePopover,