@elastic/eui 115.0.0 → 116.0.0

package/lib/components/collapsible_nav_beta/_kibana_solution/collapsible_nav_kibana_solution.js

@@ -74,7 +74,6 @@ var KibanaCollapsibleNavSolution = exports.KibanaCollapsibleNavSolution = functi
   var solutionSolutionSwitcherAriaLabel = (0, _i18n.useEuiI18n)('euiCollapsibleNavKibanaSolution.switcherAriaLabel', ' - click to switch to another solution');
   var solutionSolutionGroupLabel = (0, _i18n.useEuiI18n)('euiCollapsibleNavKibanaSolution.groupLabel', 'Navigate to solution');
   var closeSolutionPopover = (0, _react.useCallback)(function (event) {
-    var _childItem$firstEleme;
     // Allow child items to stop the popover from being closed
     if (event.isPropagationStopped()) return;
     // Only listen for clicks on child items - currentTarget is the parent <ul>
@@ -83,7 +82,7 @@ var KibanaCollapsibleNavSolution = exports.KibanaCollapsibleNavSolution = functi
     // Only close the popover if the item is a clickable link or button
     var target = event.target;
     var childItem = target.closest('.euiListGroupItem');
-    if (['A', 'BUTTON'].includes((childItem === null || childItem === void 0 || (_childItem$firstEleme = childItem.firstElementChild) === null || _childItem$firstEleme === void 0 ? void 0 : _childItem$firstEleme.tagName) || '')) {
+    if (['A', 'BUTTON'].includes((childItem === null || childItem === void 0 ? void 0 : childItem.tagName) || '')) {
       setIsSolutionSwitcherOpen(false);
     }
   }, []);
@@ -96,12 +95,10 @@ var KibanaCollapsibleNavSolution = exports.KibanaCollapsibleNavSolution = functi
       "data-test-subj": "kibanaSolutionSwitcherList",
       "aria-label": solutionSolutionGroupLabel,
       listItems: primaryItems,
-      size: "s",
       bordered: true,
       onClick: closeSolutionPopover
     }), secondaryItems.length > 0 && (0, _react2.jsx)(_react.default.Fragment, null, (0, _react2.jsx)(_list_group.EuiListGroup, {
       listItems: secondaryItems,
-      size: "s",
       css: styles.euiCollapsibleNavKibanaSolution__secondaryItems,
       onClick: closeSolutionPopover
     })));
@@ -182,22 +179,28 @@ KibanaCollapsibleNavSolution.propTypes = {
     "data-test-subj": _propTypes.default.string,
     css: _propTypes.default.any,
     /**
-         * Size of the label text
-         */
-    size: _propTypes.default.any,
+       * Controls the disabled behavior via the native `disabled` attribute.
+       */
+    isDisabled: _propTypes.default.bool,
+    /**
+       * NOTE: Beta feature, may be changed or removed in the future
+       *
+       * Changes the native `disabled` attribute to `aria-disabled` to preserve focusability.
+       * This results in a semantically disabled button without the default browser handling of the disabled state.
+       *
+       * Use e.g. when a disabled button should have a tooltip.
+       */
+    hasAriaDisabled: _propTypes.default.bool,
     /**
          * By default the item will get the color `text`.
          * You can customize the color of the item by passing a color name.
+         * @default 'text'
          */
     color: _propTypes.default.any,
     /**
          * Apply styles indicating an item is active
          */
     isActive: _propTypes.default.bool,
-    /**
-         * Apply styles indicating an item is disabled
-         */
-    isDisabled: _propTypes.default.bool,
     /**
          * Make the list item label a link.
          * While permitted, `href` and `onClick` should not be used together in most cases and may create problems.

package/lib/components/color_picker/color_palette_picker/color_palette_picker.js

@@ -100,7 +100,6 @@ var EuiColorPalettePicker = exports.EuiColorPalettePicker = function EuiColorPal
     options: paletteOptions,
     valueOfSelected: valueOfSelected,
     onChange: onChange,
-    hasDividers: true,
     isInvalid: isInvalid,
     compressed: compressed,
     disabled: disabled,

package/lib/components/combo_box/combo_box.a11y.js

@@ -88,7 +88,7 @@ describe('EuiComboBox', function () {
           rowHeight: rowHeight
         }));
         cy.get('input[data-test-subj="comboBoxSearchInput"]').realClick();
-        cy.get('button[data-test-subj="titanOption"]').should('exist');
+        cy.get('[data-test-subj="titanOption"]').should('exist');
         cy.checkAxe();
       });
       it('has zero violations after keyboard interaction', function () {
@@ -97,7 +97,7 @@ describe('EuiComboBox', function () {
         }));
         cy.realPress('Tab');
         cy.get('input[data-test-subj="comboBoxSearchInput"]').should('have.focus');
-        cy.get('button[data-test-subj="titanOption"]').should('exist');
+        cy.get('[data-test-subj="titanOption"]').should('exist');
         cy.repeatRealPress('ArrowDown');
         cy.realPress('Enter');
         cy.repeatRealPress('ArrowDown');
@@ -123,14 +123,14 @@ describe('EuiComboBox', function () {
         }));
         cy.realPress('Tab');
         cy.get('input[data-test-subj="comboBoxSearchInput"]').should('have.focus');
-        cy.get('button[data-test-subj="titanOption"]').should('exist');
+        cy.get('[data-test-subj="titanOption"]').should('exist');
         cy.realPress('ArrowDown');
         cy.realPress('ArrowDown');
         cy.realPress('ArrowDown');
         cy.get('input[data-test-subj="comboBoxSearchInput"]').invoke('attr', 'aria-activedescendant').should('include', 'option-2');
         cy.realPress('Enter');
         cy.realPress('ArrowDown');
-        cy.get('input[data-test-subj="comboBoxSearchInput"]').invoke('attr', 'aria-activedescendant').should('include', 'option-3');
+        cy.get('input[data-test-subj="comboBoxSearchInput"]').invoke('attr', 'aria-activedescendant').should('include', 'option-4');
       });
       it('sets the correct aria-activedescendant id with custom option ids', function () {
         cy.realMount((0, _react2.jsx)(ComboBox, {
@@ -160,7 +160,7 @@ describe('EuiComboBox', function () {
         cy.get('input[data-test-subj="comboBoxSearchInput"]').should('exist');
         cy.realPress('Tab');
         cy.get('input[data-test-subj="comboBoxSearchInput"]').should('have.focus');
-        cy.get('button[data-test-subj="titanOption"]').should('exist');
+        cy.get('[data-test-subj="titanOption"]').should('exist');
         cy.realPress('ArrowDown');
         cy.realPress('ArrowDown');
         cy.realPress('ArrowDown');

package/lib/components/combo_box/combo_box.js

@@ -17,7 +17,7 @@ var _combo_box_input = require("./combo_box_input/combo_box_input");
 var _combo_box_options_list = require("./combo_box_options_list");
 var _combo_box = require("./combo_box.styles");
 var _react2 = require("@emotion/react");
-var _excluded = ["data-test-subj", "async", "className", "compressed", "customOptionText", "fullWidth", "id", "inputRef", "isCaseSensitive", "isClearable", "isDisabled", "isInvalid", "isLoading", "noSuggestions", "onBlur", "onChange", "onCreateOption", "onSearchChange", "options", "placeholder", "renderOption", "rowHeight", "selectedOptions", "singleSelection", "prepend", "sortMatchesBy", "delimiter", "append", "autoFocus", "truncationProps", "inputPopoverProps", "optionMatcher", "aria-label", "aria-labelledby", "aria-describedby"];
+var _excluded = ["data-test-subj", "async", "className", "compressed", "customOptionText", "fullWidth", "id", "inputRef", "isCaseSensitive", "isClearable", "isDisabled", "isInvalid", "isLoading", "noSuggestions", "onBlur", "onChange", "onCreateOption", "onSearchChange", "options", "placeholder", "renderOption", "rowHeight", "selectedOptions", "singleSelection", "prepend", "sortMatchesBy", "delimiter", "append", "autoFocus", "onFocusBadge", "truncationProps", "inputPopoverProps", "optionMatcher", "aria-label", "aria-labelledby", "aria-describedby"];
 function _interopRequireDefault(e) { return e && e.__esModule ? e : { default: e }; }
 function _getRequireWildcardCache(e) { if ("function" != typeof WeakMap) return null; var r = new WeakMap(), t = new WeakMap(); return (_getRequireWildcardCache = function _getRequireWildcardCache(e) { return e ? t : r; })(e); }
 function _interopRequireWildcard(e, r) { if (!r && e && e.__esModule) return e; if (null === e || "object" != _typeof(e) && "function" != typeof e) return { default: e }; var t = _getRequireWildcardCache(r); if (t && t.has(e)) return t.get(e); var n = { __proto__: null }, a = Object.defineProperty && Object.getOwnPropertyDescriptor; for (var u in e) if ("default" !== u && {}.hasOwnProperty.call(e, u)) { var i = a ? Object.getOwnPropertyDescriptor(e, u) : null; i && (i.get || i.set) ? Object.defineProperty(n, u, i) : n[u] = e[u]; } return n.default = e, t && t.set(e, n), n; }
@@ -105,6 +105,9 @@ var EuiComboBox = exports.EuiComboBox = /*#__PURE__*/function (_Component) {
       _this.listRefInstance = ref;
     });
     _defineProperty(_this, "setListOptionRefs", function (node, index) {
+      var current = _this.state.listOptionRefs[index];
+      // Skip updating if the ref is null (on cleanup) or didn't change
+      if (node === null || node === current) return;
       _this.setState(function (_ref) {
         var listOptionRefs = _ref.listOptionRefs;
         var _listOptionRefs = listOptionRefs;
@@ -125,41 +128,32 @@ var EuiComboBox = exports.EuiComboBox = /*#__PURE__*/function (_Component) {
         isListOpen: false
       });
     });
-    _defineProperty(_this, "incrementActiveOptionIndex", function (amount) {
-      // If there are no options available, do nothing.
-      if (!_this.state.matchingOptions.length) {
-        return;
+    _defineProperty(_this, "findNextSelectableOptionIndex", function (options, startIndex) {
+      var direction = arguments.length > 2 && arguments[2] !== undefined ? arguments[2] : 1;
+      if (!options.length) return -1;
+      var index = startIndex;
+      for (var count = 0; count < options.length; count++) {
+        var option = options[index];
+        if (!option.isGroupLabelOption && !option.disabled) {
+          return index;
+        }
+        index = (index + direction + options.length) % options.length;
       }
+      return -1; // the remaining options can't be selected (group labels or disabled)
+    });
+    _defineProperty(_this, "incrementActiveOptionIndex", function (amount) {
+      if (!_this.state.matchingOptions.length) return;
       _this.setState(function (_ref2) {
         var activeOptionIndex = _ref2.activeOptionIndex,
           matchingOptions = _ref2.matchingOptions;
-        var nextActiveOptionIndex;
-        if (activeOptionIndex < 0) {
-          // If this is the beginning of the user's keyboard navigation of the menu, then we'll focus
-          // either the first or last item.
-          nextActiveOptionIndex = amount < 0 ? matchingOptions.length - 1 : 0;
-        } else {
-          nextActiveOptionIndex = activeOptionIndex + amount;
-          if (nextActiveOptionIndex < 0) {
-            nextActiveOptionIndex = matchingOptions.length - 1;
-          } else if (nextActiveOptionIndex === matchingOptions.length) {
-            nextActiveOptionIndex = 0;
-          }
-        }
-
-        // Group titles are included in option list but are not selectable
-        // Skip group title options
         var direction = amount > 0 ? 1 : -1;
-        while (matchingOptions[nextActiveOptionIndex].isGroupLabelOption) {
-          nextActiveOptionIndex = nextActiveOptionIndex + direction;
-          if (nextActiveOptionIndex < 0) {
-            nextActiveOptionIndex = matchingOptions.length - 1;
-          } else if (nextActiveOptionIndex === matchingOptions.length) {
-            nextActiveOptionIndex = 0;
-          }
-        }
+        var startIndex = activeOptionIndex < 0 ?
+        // Inintial interaction: jump to first or last item
+        amount < 0 ? matchingOptions.length - 1 : 0 :
+        // Advance by amount, wrapping around
+        (activeOptionIndex + amount + matchingOptions.length) % matchingOptions.length;
         return {
-          activeOptionIndex: nextActiveOptionIndex
+          activeOptionIndex: _this.findNextSelectableOptionIndex(matchingOptions, startIndex, direction)
         };
       });
     });
@@ -377,27 +371,36 @@ var EuiComboBox = exports.EuiComboBox = /*#__PURE__*/function (_Component) {
         onChange = _this$props7.onChange,
         selectedOptions = _this$props7.selectedOptions,
         singleSelectionProp = _this$props7.singleSelection;
+      var _this$state2 = _this.state,
+        matchingOptions = _this$state2.matchingOptions,
+        listOptionRefs = _this$state2.listOptionRefs;
       var singleSelection = Boolean(singleSelectionProp);
       var changeOptions = singleSelection ? [addedOption] : selectedOptions.concat(addedOption);
       onChange === null || onChange === void 0 || onChange(changeOptions);
       _this.clearSearchValue();
-      _this.clearActiveOption();
-      if (!isContainerBlur) {
-        var _this$searchInputRefI2;
-        (_this$searchInputRefI2 = _this.searchInputRefInstance) === null || _this$searchInputRefI2 === void 0 || _this$searchInputRefI2.focus();
-      }
       if (singleSelection) {
+        // List closes after single selection; return focus to the input
+        _this.clearActiveOption();
+        if (!isContainerBlur) {
+          var _this$searchInputRefI2;
+          (_this$searchInputRefI2 = _this.searchInputRefInstance) === null || _this$searchInputRefI2 === void 0 || _this$searchInputRefI2.focus();
+        }
         requestAnimationFrame(function () {
           return _this.closeList();
         });
+      } else if (isContainerBlur) {
+        // User tabbed away. `onContainerBlur` will close the list. We're only cleaning up state
+        _this.clearActiveOption();
       } else {
-        _this.setState(function (_ref4) {
-          var listOptionRefs = _ref4.listOptionRefs,
-            matchingOptions = _ref4.matchingOptions;
-          return {
-            listOptionRefs: listOptionRefs.slice(0, matchingOptions.length - 1),
-            activeOptionIndex: matchingOptions.indexOf(addedOption)
-          };
+        var currentIndex = matchingOptions.indexOf(addedOption);
+        var nextOptions = matchingOptions.filter(function (option) {
+          return option !== addedOption;
+        });
+        _this.setState({
+          listOptionRefs: listOptionRefs.slice(0, matchingOptions.length - 1),
+          activeOptionIndex: _this.findNextSelectableOptionIndex(nextOptions, Math.min(currentIndex, nextOptions.length - 1)
+          // direction defaults to 1 (forward)
+          )
         });
       }
     });
@@ -505,6 +508,7 @@ var EuiComboBox = exports.EuiComboBox = /*#__PURE__*/function (_Component) {
         delimiter = _this$props11.delimiter,
         append = _this$props11.append,
         autoFocus = _this$props11.autoFocus,
+        onFocusBadge = _this$props11.onFocusBadge,
         truncationProps = _this$props11.truncationProps,
         inputPopoverProps = _this$props11.inputPopoverProps,
         optionMatcher = _this$props11.optionMatcher,
@@ -512,12 +516,12 @@ var EuiComboBox = exports.EuiComboBox = /*#__PURE__*/function (_Component) {
         ariaLabelledby = _this$props11['aria-labelledby'],
         ariaDescribedby = _this$props11['aria-describedby'],
         rest = _objectWithoutProperties(_this$props11, _excluded);
-      var _this$state2 = this.state,
-        activeOptionIndex = _this$state2.activeOptionIndex,
-        hasFocus = _this$state2.hasFocus,
-        isListOpen = _this$state2.isListOpen,
-        searchValue = _this$state2.searchValue,
-        matchingOptions = _this$state2.matchingOptions;
+      var _this$state3 = this.state,
+        activeOptionIndex = _this$state3.activeOptionIndex,
+        hasFocus = _this$state3.hasFocus,
+        isListOpen = _this$state3.isListOpen,
+        searchValue = _this$state3.searchValue,
+        matchingOptions = _this$state3.matchingOptions;
 
       // Make sure we have a valid ID if users don't pass one as a prop
       var inputId = id !== null && id !== void 0 ? id : this.rootId('_eui-combobox-id');
@@ -568,7 +572,8 @@ var EuiComboBox = exports.EuiComboBox = /*#__PURE__*/function (_Component) {
             delimiter: delimiter,
             getSelectedOptionForSearchValue: _matching_options.getSelectedOptionForSearchValue,
             listboxAriaLabel: listboxAriaLabel,
-            truncationProps: truncationProps
+            truncationProps: truncationProps,
+            onFocusBadge: onFocusBadge
           });
         });
       }
@@ -593,11 +598,11 @@ var EuiComboBox = exports.EuiComboBox = /*#__PURE__*/function (_Component) {
             ref: _this2.comboBoxRefCallback
           }), (0, _react2.jsx)(_popover.EuiInputPopover, _extends({
             fullWidth: fullWidth,
-            panelPaddingSize: "none",
+            panelPaddingSize: "s",
             disableFocusTrap: true,
             closeOnScroll: true
           }, inputPopoverProps, {
-            isOpen: isListOpen,
+            isOpen: isListOpen && !noSuggestions,
             closePopover: _this2.closeList
             /* we don't want content changes to be announced via aria-live 
             because ComboBox uses a virtualized list that updates itself
@@ -605,7 +610,10 @@ var EuiComboBox = exports.EuiComboBox = /*#__PURE__*/function (_Component) {
             "aria-live": "off",
             input: (0, _react2.jsx)(_combo_box_input.EuiComboBoxInput, {
               compressed: compressed,
-              focusedOptionId: _this2.hasActiveOption() ? (_this2$state$listOpti = (_this2$state$listOpti2 = _this2.state.listOptionRefs[_this2.state.activeOptionIndex]) === null || _this2$state$listOpti2 === void 0 ? void 0 : _this2$state$listOpti2.id) !== null && _this2$state$listOpti !== void 0 ? _this2$state$listOpti : _this2.rootId("_option-".concat(_this2.state.activeOptionIndex)) : undefined,
+              focusedOptionId: _this2.hasActiveOption() ? (_this2$state$listOpti = (_this2$state$listOpti2 = _this2.state.listOptionRefs[_this2.state.activeOptionIndex]) === null || _this2$state$listOpti2 === void 0 ? void 0 : _this2$state$listOpti2.id) !== null && _this2$state$listOpti !== void 0 ? _this2$state$listOpti :
+              // uses the original `options` array to ensure a stable `id`, otherwise `aria-activedescendant`
+              // loses focus on selecting an option (due to actively removing it from the list)
+              _this2.rootId("_option-".concat(_this2.props.options.indexOf(matchingOptions[activeOptionIndex]))) : undefined,
               fullWidth: fullWidth,
               hasSelectedOptions: selectedOptions.length > 0,
               id: inputId,
@@ -795,7 +803,7 @@ EuiComboBox.propTypes = {
   "aria-labelledby": _propTypes.default.string,
   /**
      * By default, EuiComboBox will truncate option labels at the end of
-     * the string. You can use pass in a custom truncation configuration that
+     * the string. You can pass in a custom truncation configuration that
      * accepts any [EuiTextTruncate](/#/utilities/text-truncation) prop,
      * except for `text` and `children`.
      *