@el4cteo/rbx-studio-mcp 0.7.8 → 0.8.2

package/plugin/src/handlers/Device.luau

@@ -130,29 +130,21 @@ end
 	`poor` is deliberately harsh -- crowded stadium wifi, a phone on one bar --
 	because the failures worth finding only appear at the far end.
 
-	Loss is the percentage of packets thrown away, and it is the field that finds
-	the interesting bugs: latency makes a game feel slow, loss makes it behave
-	wrongly.
+	Loss is the percentage of packets thrown away. Roblox caps it at 0.5%, so
+	the presets climb to that ceiling rather than to real-world figures the
+	engine would clamp anyway.
 ]]
 local PRESETS: { [string]: { latency: number, jitter: number, loss: number } } = {
 	clear = { latency = 0, jitter = 0, loss = 0 },
 	wifi = { latency = 15, jitter = 5, loss = 0 },
-	["4g"] = { latency = 60, jitter = 15, loss = 0.5 },
-	["3g"] = { latency = 150, jitter = 40, loss = 2 },
-	poor = { latency = 400, jitter = 120, loss = 8 },
+	["4g"] = { latency = 60, jitter = 15, loss = 0.1 },
+	["3g"] = { latency = 150, jitter = 40, loss = 0.3 },
+	poor = { latency = 400, jitter = 120, loss = 0.5 },
 }
 
---[[
-	Percent in, fraction out.
-
-	`InboundNetworkLossPercent` does not take a percentage: it takes a fraction
-	and clamps at 0.5. Writing 2 for "2% loss" succeeds, lands at 0.5, and
-	degrades half the traffic -- a hundred times what was asked for, with no
-	error anywhere. Every caller of this file speaks percent, so the conversion
-	is here and only here.
-]]
-local function lossFraction(percent: number): number
-	return math.clamp(percent, 0, Emulation.LOSS_LIMIT_PERCENT) / 100
+-- Percent in, percent out: the property takes a percentage, capped at 0.5.
+local function lossPercent(percent: number): number
+	return math.clamp(percent, 0, Emulation.LOSS_LIMIT_PERCENT)
 end
 
 local function presetNames(): string
@@ -180,6 +172,19 @@ local function apply(service: any, property: string, value: number, refused: { s
 	end
 end
 
+--[[
+	Takes the memory cap off by writing the machine's real memory back. 0 is
+	not "no cap" to the engine -- it is a device with no memory -- so nothing
+	here writes it.
+]]
+local function uncapMemory(service: any, refused: { string })
+	local real = Emulation.machineMemory()
+	if real ~= nil then
+		apply(service, "EmulatedTotalMemoryInMB", real, refused)
+	end
+	Emulation.setMemoryCap(nil)
+end
+
 --[[
 	Degrades the connection on purpose.
 
@@ -224,9 +229,8 @@ function Device.network(params: { [string]: any }): { [string]: any }
 		latency, jitter, loss = preset.latency, preset.jitter, preset.loss
 		-- "clear" is a whole-connection word, so it takes the memory cap with
 		-- it. Any other preset says nothing about memory and leaves it alone.
-		if name == "clear" then
-			apply(service, "EmulatedTotalMemoryInMB", 0, {})
-			Emulation.setMemoryCap(nil)
+		if name == "clear" and Emulation.memoryCap() ~= nil then
+			uncapMemory(service, {})
 		end
 	end
 
@@ -311,17 +315,21 @@ function Device.network(params: { [string]: any }): { [string]: any }
 		end
 	end
 	if loss ~= nil then
-		local fraction = lossFraction(loss)
+		local percent = lossPercent(loss)
 		if inbound then
-			apply(service, "InboundNetworkLossPercent", fraction, refused)
+			apply(service, "InboundNetworkLossPercent", percent, refused)
 		end
 		if outbound then
-			apply(service, "OutboundNetworkLossPercent", fraction, refused)
+			apply(service, "OutboundNetworkLossPercent", percent, refused)
 		end
 	end
 	if memory ~= nil then
-		apply(service, "EmulatedTotalMemoryInMB", memory, refused)
-		Emulation.setMemoryCap(memory)
+		if memory > 0 then
+			apply(service, "EmulatedTotalMemoryInMB", memory, refused)
+			Emulation.setMemoryCap(memory)
+		else
+			uncapMemory(service, refused)
+		end
 	end
 
 	local state = Emulation.network()
@@ -358,8 +366,11 @@ function Device.stop(_params: { [string]: any }): { [string]: any }
 		apply(service, "OutboundNetworkMinDelayMs", 0, ignored)
 		apply(service, "OutboundNetworkJitterMs", 0, ignored)
 		apply(service, "OutboundNetworkLossPercent", 0, ignored)
-		apply(service, "EmulatedTotalMemoryInMB", 0, ignored)
-		Emulation.setMemoryCap(nil)
+		-- Only a cap this plugin set is undone. Studio's own simulator restores
+		-- its value when it stops, and writing over that is what left 0 behind.
+		if Emulation.memoryCap() ~= nil then
+			uncapMemory(service, ignored)
+		end
 	end
 
 	--[[

package/plugin/src/handlers/Generate.luau

@@ -25,6 +25,7 @@
 ]]
 
 local Dispatch = require(script.Parent.Parent.Dispatch)
+local Serialize = require(script.Parent.Parent.Serialize)
 local Paths = require(script.Parent.Parent.Paths)
 local Undo = require(script.Parent.Parent.Undo)
 
@@ -89,15 +90,17 @@ local function carryLook(source: MeshPart, model: Model)
 	end
 end
 
+-- Absent is nil; present but malformed fails, rather than being taken as absent
+-- and quietly replaced by a default the caller never asked for.
 local function parseVector(text: any): Vector3?
-	if typeof(text) ~= "string" or text == "" then
+	if text == nil or text == "" then
 		return nil
 	end
-	local x, y, z = string.match(text, "^%s*(-?[%d%.]+)%s*,%s*(-?[%d%.]+)%s*,%s*(-?[%d%.]+)%s*$")
-	if x == nil then
-		return nil
+	local ok, value = Serialize.parse(text, "Vector3")
+	if not ok then
+		Dispatch.fail("BAD_PARAMS", string.format("%q is not an \"x, y, z\" vector.", tostring(text)))
 	end
-	return Vector3.new(tonumber(x) :: number, tonumber(y) :: number, tonumber(z) :: number)
+	return value :: Vector3
 end
 
 local function service(): any

package/plugin/src/handlers/Geometry.luau

@@ -56,15 +56,17 @@ local function carryAppearance(source: BasePart, target: BasePart)
 	end
 end
 
+-- Absent is nil; present but malformed fails, rather than being taken as absent
+-- and quietly replaced by a default the caller never asked for.
 local function parseVector(text: any): Vector3?
-	if typeof(text) ~= "string" or text == "" then
+	if text == nil or text == "" then
 		return nil
 	end
-	local x, y, z = string.match(text, "^%s*(-?[%d%.]+)%s*,%s*(-?[%d%.]+)%s*,%s*(-?[%d%.]+)%s*$")
-	if x == nil then
-		return nil
+	local ok, value = Serialize.parse(text, "Vector3")
+	if not ok then
+		Dispatch.fail("BAD_PARAMS", string.format("%q is not an \"x, y, z\" vector.", tostring(text)))
 	end
-	return Vector3.new(tonumber(x) :: number, tonumber(y) :: number, tonumber(z) :: number)
+	return value :: Vector3
 end
 
 local function resolveParts(paths: any, what: string): { BasePart }

package/plugin/src/handlers/Perf.luau

@@ -150,6 +150,7 @@ function Perf.console(params: { [string]: any }): { [string]: any }
 			timestamp = item.timestamp,
 			stack = item.stack,
 			source = item.source,
+			context = item.context,
 		})
 	end
 

package/plugin/src/handlers/Playtest.luau

@@ -68,8 +68,12 @@ end
 
 local function state(): { [string]: any }
 	local players = {}
-	for _, player in game:GetService("Players"):GetPlayers() do
-		table.insert(players, { name = player.Name, userId = player.UserId })
+	-- Only while a test runs: straight after `stop` the editor still lists the
+	-- departing player for a moment, and the reply said one was present.
+	if RunService:IsRunning() then
+		for _, player in game:GetService("Players"):GetPlayers() do
+			table.insert(players, { name = player.Name, userId = player.UserId })
+		end
 	end
 	return {
 		playtestsAllowed = Playtest.isAllowed(),
@@ -121,13 +125,46 @@ end
 
 function Playtest.control(params: { [string]: any }): { [string]: any }
 	local op = params.op
-	if op == "play" or op == "run" or op == "multiplayer" then requireAllowed() end
+	if op == "play" or op == "run" or op == "multiplayer" or op == "addPlayers" then requireAllowed() end
 	local before = state()
 
 	if op == "state" then
 		return { changed = false, state = before }
 	end
 
+	--[[
+		More players joining a test already running: staggered joins, lobby
+		fill-up, the race a second player hits that the first never does.
+
+		Served by the playtest's server session, the only place AddPlayers may be
+		called from; the MCP server routes it there. Returns straight away --
+		new clients take seconds to load, and the caller polls `state` for them.
+	]]
+	if op == "addPlayers" then
+		if RunService:IsEdit() or not RunService:IsServer() then
+			Dispatch.fail(
+				"NOT_RUNNING",
+				"Players can only be added from the server of a running test.",
+				"Start one with `playtest op=\"multiplayer\"` first."
+			)
+		end
+		local count = tonumber(params.players) or 1
+		if count < 1 or count > 8 then
+			Dispatch.fail("BAD_PARAMS", "players must be between 1 and 8.")
+		end
+		local ok, err = pcall(function()
+			service():AddPlayers(count)
+		end)
+		if not ok then
+			Dispatch.fail(
+				"ADD_PLAYERS_FAILED",
+				string.format("Studio refused to add players: %s", tostring(err)),
+				"AddPlayers works in a multiplayer test only, not in Play or Run."
+			)
+		end
+		return { changed = true, state = before }
+	end
+
 	--[[
 		Ending a test has to happen inside it.
 

package/plugin/src/handlers/Terrain.luau

@@ -319,43 +319,28 @@ end
 	What is there, without reading a voxel.
 
 	`CountCells` is the cheap answer to "does this place even use terrain",
-	which is the question worth asking before any of the above. The bounding box
-	tells an agent where to aim without guessing at the origin.
+	which is the question worth asking before any of the above.
 ]]
 function Terrain.stats(_params: { [string]: any }): { [string]: any }
 	local field = terrain()
 
 	--[[
-		Formatted here rather than through `Serialize.value`.
-
-		`MaxExtents` is a Region3int16 and its corners are Vector3int16, which is
-		a type `Serialize.value` has no case for -- it would have fallen through
-		to the generic tail and reported whatever `tostring` makes of it. The
-		extents are also in VOXELS, not studs, which is the sort of unit
-		confusion that produces a fill a thousand studs from where it was meant,
-		so they are converted and named for what they are.
-	]]
-	--[[
-		`MaxExtents` is deliberately not reported.
+		No bounds, and no limit.
 
-		It reads like the bounding box of the terrain that exists, and it is
-		not: it is the fixed limit of where terrain is allowed to go, and it
-		answers -32000, -32000, -32000 to 32000, 32000, 32000 on an empty place
-		and on a full one alike. Reporting it as "where the terrain sits" was a
-		misreading of the name -- checked against a place with 2220 cells in a
-		160-stud patch, which returned exactly the same numbers as one with
-		none.
+		`MaxExtents` reads like the bounding box of the terrain that exists and is
+		not: it answers -32000..32000 on an empty place and a full one alike. Nor
+		is it a limit in studs -- a fill at 140,000 studs out still landed -- so
+		the `limitStuds = 32000` this used to report was wrong as well.
 
 		There is no engine call for the occupied box, and finding it means
 		reading every voxel in the world, which is far too expensive for a
-		question meant to be cheap. `cells` already answers the one that
-		matters: whether this place uses terrain at all.
+		question meant to be cheap. `cells` answers the one that matters.
 	]]
 	return {
 		cells = field:CountCells(),
 		waterColor = Serialize.value(field.WaterColor),
-		waterWaveSize = field.WaterWaveSize,
-		limitStuds = 32000,
+		-- Through Serialize so a float32 reads 0.15, not 0.15000000596046448.
+		waterWaveSize = Serialize.value(field.WaterWaveSize),
 	}
 end
 

package/plugin/src/handlers/Viewport.luau

@@ -92,7 +92,7 @@ function Viewport.raycast(params: { [string]: any }): { [string]: any }
 		position = Serialize.value(cast.Position),
 		normal = Serialize.value(cast.Normal),
 		distance = math.floor(cast.Distance * 1000 + 0.5) / 1000,
-		material = Serialize.value(cast.Material),
+		material = cast.Material.Name,
 	}
 end
 
@@ -287,9 +287,9 @@ function Viewport.camera(params: { [string]: any }): { [string]: any }
 	end
 
 	return {
-		position = tostring(view.CFrame.Position),
-		lookVector = tostring(view.CFrame.LookVector),
-		fieldOfView = view.FieldOfView,
+		position = Serialize.value(view.CFrame.Position),
+		lookVector = Serialize.value(view.CFrame.LookVector),
+		fieldOfView = Serialize.value(view.FieldOfView),
 	}
 end
 

package/plugin/src/handlers/World.luau

@@ -213,6 +213,19 @@ function World.collision(params: { [string]: any }): { [string]: any }
 		if typeof(paths) ~= "table" or #(paths :: { any }) == 0 then
 			Dispatch.fail("BAD_PARAMS", "assign needs a `paths` array.")
 		end
+		-- The engine takes any string here, registered or not, and a part in an
+		-- unregistered group collides as Default: a typo that changes nothing
+		-- and reports success. Measured, so refused up front.
+		local okRegistered, registered = pcall(function()
+			return world:IsCollisionGroupRegistered(name)
+		end)
+		if okRegistered and registered == false then
+			Dispatch.fail(
+				"NO_SUCH_GROUP",
+				string.format("No collision group %q is registered in %s.", name, Paths.of(world)),
+				'Create it first with action="create", or check the name with action="list".'
+			)
+		end
 		local assigned: { string } = {}
 		local _, undoable = Undo.record("MCPCollision", "MCP collision group", function()
 			for _, path in paths :: { string } do
@@ -228,7 +241,10 @@ function World.collision(params: { [string]: any }): { [string]: any }
 				end
 			end
 		end)
-		return { group = name, assigned = #assigned, parts = assigned, undoable = undoable, world = Paths.of(world) }
+		-- A model can hold thousands of parts; the count is the answer and a
+		-- sample of names is enough to see it landed where intended.
+		local sample = if #assigned > 20 then table.move(assigned, 1, 20, 1, {}) else assigned
+		return { group = name, assigned = #assigned, parts = sample, undoable = undoable, world = Paths.of(world) }
 	end
 
 	if action == "remove" then

package/plugin/src/init.server.luau

@@ -42,7 +42,6 @@ local Viewport = require(script.handlers.Viewport)
 local Input = require(script.handlers.Input)
 local Device = require(script.handlers.Device)
 local Data = require(script.handlers.Data)
-local Anim = require(script.handlers.Anim)
 local Api = require(script.handlers.Api)
 local Scripts = require(script.handlers.Scripts)
 local Session = require(script.handlers.Session)
@@ -197,7 +196,6 @@ Scripts.register()
 Input.register()
 Device.register()
 Data.register()
-Anim.register()
 Api.register()
 
 --[[