@el4cteo/rbx-studio-mcp 0.6.8 → 0.7.1

package/plugin/src/Config.luau

@@ -1,65 +1,65 @@
---!strict
---[[
-	Connection settings for the Studio MCP plugin.
-
-	The port must match the one the Node server was started with (`--port`, or
-	the ROBLOX_STUDIO_MCP_PORT environment variable). It is stored as a plugin
-	setting so a user running on a non-default port only has to set it once.
-]]
-
-local Config = {}
-
-Config.PLUGIN_VERSION = "0.6.8"
-
--- Fingerprint of plugin/src, stamped in by scripts/build-plugin.mjs. The server
--- computes the same hash from its own copy of the sources and compares, so a
--- plugin left running from an older build is reported rather than silently
--- answering with stale handlers. Stays "dev" when the tree is loaded unbuilt.
-Config.BUILD_ID = "dev"
-Config.PROTOCOL_VERSION = 1
-Config.DEFAULT_PORT = 44755
-
--- Header the bridge requires on every request. A web page cannot set it
--- cross-origin without a preflight the bridge never answers, which is what
--- keeps a malicious site from driving Studio through the loopback port.
-Config.CLIENT_HEADER = "x-roblox-studio-mcp"
-
--- How long to wait before retrying after the stream drops. Studio closes SSE
--- connections at the 30 minute mark, so reconnects are routine, not exceptional.
-Config.RECONNECT_DELAY = 1
-Config.MAX_RECONNECT_DELAY = 30
-
--- How long a connection has to last before it counts as having worked, rather
--- than as one more failure to back off from. Comfortably longer than a failed
--- handshake against a dead port, which resolves in milliseconds, and far shorter
--- than any connection that carried a single command.
-Config.HEALTHY_CONNECTION = 10
-
--- How long a healthy long-poll session runs before standing aside so streaming
--- can be tried again. Long enough that a Studio which genuinely cannot stream
--- is not reconnecting constantly, short enough that a session downgraded by one
--- unlucky attempt does not spend the rest of its life slower than it should be.
-Config.RESTREAM_INTERVAL = 60
-
-local port: number? = nil
-
-function Config.setPort(value: number)
-	port = value
-end
-
-function Config.getPort(): number
-	return port or Config.DEFAULT_PORT
-end
-
-function Config.baseUrl(): string
-	return string.format("http://127.0.0.1:%d", Config.getPort())
-end
-
-function Config.headers(): { [string]: string }
-	return {
-		[Config.CLIENT_HEADER] = tostring(Config.PROTOCOL_VERSION),
-		["Content-Type"] = "application/json",
-	}
-end
-
-return Config
+--!strict
+--[[
+	Connection settings for the Studio MCP plugin.
+
+	The port must match the one the Node server was started with (`--port`, or
+	the ROBLOX_STUDIO_MCP_PORT environment variable). It is stored as a plugin
+	setting so a user running on a non-default port only has to set it once.
+]]
+
+local Config = {}
+
+Config.PLUGIN_VERSION = "0.7.1"
+
+-- Fingerprint of plugin/src, stamped in by scripts/build-plugin.mjs. The server
+-- computes the same hash from its own copy of the sources and compares, so a
+-- plugin left running from an older build is reported rather than silently
+-- answering with stale handlers. Stays "dev" when the tree is loaded unbuilt.
+Config.BUILD_ID = "dev"
+Config.PROTOCOL_VERSION = 1
+Config.DEFAULT_PORT = 44755
+
+-- Header the bridge requires on every request. A web page cannot set it
+-- cross-origin without a preflight the bridge never answers, which is what
+-- keeps a malicious site from driving Studio through the loopback port.
+Config.CLIENT_HEADER = "x-roblox-studio-mcp"
+
+-- How long to wait before retrying after the stream drops. Studio closes SSE
+-- connections at the 30 minute mark, so reconnects are routine, not exceptional.
+Config.RECONNECT_DELAY = 1
+Config.MAX_RECONNECT_DELAY = 30
+
+-- How long a connection has to last before it counts as having worked, rather
+-- than as one more failure to back off from. Comfortably longer than a failed
+-- handshake against a dead port, which resolves in milliseconds, and far shorter
+-- than any connection that carried a single command.
+Config.HEALTHY_CONNECTION = 10
+
+-- How long a healthy long-poll session runs before standing aside so streaming
+-- can be tried again. Long enough that a Studio which genuinely cannot stream
+-- is not reconnecting constantly, short enough that a session downgraded by one
+-- unlucky attempt does not spend the rest of its life slower than it should be.
+Config.RESTREAM_INTERVAL = 60
+
+local port: number? = nil
+
+function Config.setPort(value: number)
+	port = value
+end
+
+function Config.getPort(): number
+	return port or Config.DEFAULT_PORT
+end
+
+function Config.baseUrl(): string
+	return string.format("http://127.0.0.1:%d", Config.getPort())
+end
+
+function Config.headers(): { [string]: string }
+	return {
+		[Config.CLIENT_HEADER] = tostring(Config.PROTOCOL_VERSION),
+		["Content-Type"] = "application/json",
+	}
+end
+
+return Config

package/plugin/src/Serialize.luau

@@ -60,6 +60,16 @@ function Serialize.value(value: any): any
 		return value
 	end
 	if kind == "number" then
+		-- JSON has no inf or nan, and HttpService:JSONEncode turns them into a
+		-- `{"m":null,"t":"numeric","v":"inf"}` object nobody asked for. Written as
+		-- text instead, in the same words `modify` accepts back.
+		if value ~= value then
+			return "nan"
+		elseif value == math.huge then
+			return "inf"
+		elseif value == -math.huge then
+			return "-inf"
+		end
 		-- Kept numeric so the agent can do arithmetic without parsing.
 		return math.round(value * 10 ^ PRECISION) / 10 ^ PRECISION
 	end

package/plugin/src/TextEdit.luau

@@ -98,7 +98,7 @@ function TextEdit.validate(edit: Edit, position: number)
 	if typeof(edit.path) ~= "string" or edit.path == "" then
 		Dispatch.fail(
 			"BAD_PARAMS",
-			string.format("edits[%d] has no `path`.", position),
+			string.format("edits[%d] has no `path`.", position - 1),
 			'Every edit needs the path of the script to change, e.g. "ServerScriptService.Main".'
 		)
 	end
@@ -117,7 +117,7 @@ function TextEdit.validate(edit: Edit, position: number)
 	if modes == 0 then
 		Dispatch.fail(
 			"BAD_PARAMS",
-			string.format("edits[%d] (%s) says what to edit but not how.", position, edit.path),
+			string.format("edits[%d] (%s) says what to edit but not how.", position - 1, edit.path),
 			"Give exactly one of: `find` + `replace`, `startLine` (+ `endLine`) + "
 				.. "`replacement`, or `source` to replace the whole script."
 		)
@@ -125,7 +125,7 @@ function TextEdit.validate(edit: Edit, position: number)
 	if modes > 1 then
 		Dispatch.fail(
 			"BAD_PARAMS",
-			string.format("edits[%d] (%s) combines more than one edit mode.", position, edit.path),
+			string.format("edits[%d] (%s) combines more than one edit mode.", position - 1, edit.path),
 			"Use `find`, `startLine` or `source` -- one per edit. Send several entries "
 				.. "in the array if you need several changes."
 		)
@@ -135,13 +135,13 @@ function TextEdit.validate(edit: Edit, position: number)
 		if edit.find == "" then
 			Dispatch.fail(
 				"BAD_PARAMS",
-				string.format("edits[%d] (%s) has an empty `find`.", position, edit.path)
+				string.format("edits[%d] (%s) has an empty `find`.", position - 1, edit.path)
 			)
 		end
 		if typeof(edit.replace) ~= "string" then
 			Dispatch.fail(
 				"BAD_PARAMS",
-				string.format("edits[%d] (%s) has `find` but no `replace`.", position, edit.path),
+				string.format("edits[%d] (%s) has `find` but no `replace`.", position - 1, edit.path),
 				"Pass an empty `replace` to delete the matched text."
 			)
 		end
@@ -149,7 +149,7 @@ function TextEdit.validate(edit: Edit, position: number)
 		if typeof(edit.replacement) ~= "string" then
 			Dispatch.fail(
 				"BAD_PARAMS",
-				string.format("edits[%d] (%s) has `startLine` but no `replacement`.", position, edit.path),
+				string.format("edits[%d] (%s) has `startLine` but no `replacement`.", position - 1, edit.path),
 				"Pass an empty `replacement` to delete those lines."
 			)
 		end