@el4cteo/rbx-studio-mcp 0.6.0 → 0.6.5

This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
Files changed (48) hide show
  1. package/README.md +4 -4
  2. package/dist/index.js +4 -0
  3. package/dist/index.js.map +1 -1
  4. package/dist/tools/anim.js +159 -0
  5. package/dist/tools/anim.js.map +1 -0
  6. package/dist/tools/character.js +95 -5
  7. package/dist/tools/character.js.map +1 -1
  8. package/dist/tools/data.js +173 -0
  9. package/dist/tools/data.js.map +1 -0
  10. package/dist/tools/device.js +77 -7
  11. package/dist/tools/device.js.map +1 -1
  12. package/dist/tools/discover.js +80 -4
  13. package/dist/tools/discover.js.map +1 -1
  14. package/dist/tools/exec.js +48 -1
  15. package/dist/tools/exec.js.map +1 -1
  16. package/dist/tools/input.js +35 -9
  17. package/dist/tools/input.js.map +1 -1
  18. package/dist/tools/perf.js +74 -7
  19. package/dist/tools/perf.js.map +1 -1
  20. package/dist/tools/scripts.js +51 -3
  21. package/dist/tools/scripts.js.map +1 -1
  22. package/dist/tools/world.js +317 -44
  23. package/dist/tools/world.js.map +1 -1
  24. package/package.json +74 -74
  25. package/plugin/src/Commands.luau +622 -562
  26. package/plugin/src/Config.luau +65 -65
  27. package/plugin/src/Console.luau +1909 -1843
  28. package/plugin/src/Emulation.luau +172 -0
  29. package/plugin/src/Phrase.luau +164 -16
  30. package/plugin/src/Png.luau +8 -4
  31. package/plugin/src/Serialize.luau +499 -327
  32. package/plugin/src/Undo.luau +94 -6
  33. package/plugin/src/handlers/Anim.luau +897 -0
  34. package/plugin/src/handlers/Assets.luau +587 -352
  35. package/plugin/src/handlers/Capture.luau +155 -20
  36. package/plugin/src/handlers/Character.luau +823 -361
  37. package/plugin/src/handlers/Data.luau +539 -0
  38. package/plugin/src/handlers/Device.luau +394 -139
  39. package/plugin/src/handlers/Discover.luau +685 -363
  40. package/plugin/src/handlers/Geometry.luau +127 -0
  41. package/plugin/src/handlers/Perf.luau +227 -0
  42. package/plugin/src/handlers/Scripts.luau +673 -539
  43. package/plugin/src/handlers/Session.luau +3 -0
  44. package/plugin/src/handlers/Viewport.luau +268 -0
  45. package/plugin/src/handlers/World.luau +89 -15
  46. package/plugin/src/init.server.luau +879 -832
  47. package/scripts/build-plugin.mjs +20 -0
  48. package/scripts/check-plugin.mjs +171 -124
@@ -1,832 +1,879 @@
1
- --!strict
2
- --[[
3
- rbx-studio -- plugin entry point.
4
-
5
- Owns the toolbar UI, this window's Studio identity, and the command loop.
6
- Handlers do the actual work; this file only wires them to the transport and
7
- reports what is happening to the console widget.
8
- ]]
9
-
10
- local HttpService = game:GetService("HttpService")
11
- local RunService = game:GetService("RunService")
12
- local Selection = game:GetService("Selection")
13
-
14
- local Commands = require(script.Commands)
15
- local Config = require(script.Config)
16
- local Console = require(script.Console)
17
- local Dispatch = require(script.Dispatch)
18
- local History = require(script.History)
19
- local LogBuffer = require(script.LogBuffer)
20
- local Mirror = require(script.Mirror)
21
- local Phrase = require(script.Phrase)
22
- local ScriptEdit = require(script.ScriptEdit)
23
- local Themes = require(script.Themes)
24
- local Transport = require(script.Transport)
25
- local Debug = require(script.handlers.Debug)
26
- local Assets = require(script.handlers.Assets)
27
- local Capture = require(script.handlers.Capture)
28
- local Character = require(script.handlers.Character)
29
- local Geometry = require(script.handlers.Geometry)
30
- local Generate = require(script.handlers.Generate)
31
- local Terrain = require(script.handlers.Terrain)
32
- local World = require(script.handlers.World)
33
- local Discover = require(script.handlers.Discover)
34
- local Exec = require(script.handlers.Exec)
35
- local Instances = require(script.handlers.Instances)
36
- local Perf = require(script.handlers.Perf)
37
- local Playtest = require(script.handlers.Playtest)
38
- local Viewport = require(script.handlers.Viewport)
39
- local Input = require(script.handlers.Input)
40
- local Device = require(script.handlers.Device)
41
- local Api = require(script.handlers.Api)
42
- local Scripts = require(script.handlers.Scripts)
43
- local Session = require(script.handlers.Session)
44
-
45
- local SETTING_PORT = "port"
46
- local SETTING_AUTOCONNECT = "autoConnect"
47
- local SETTING_FORCE_POLL = "forcePoll"
48
- local SETTING_THEME = "theme"
49
- local SETTING_WIDGET_OPEN = "widgetOpen"
50
- local SETTING_WIDGET_SIZE = "widgetSize"
51
- local SETTING_WIDGET_TRACE = "widgetTrace"
52
-
53
- -- Enough to cover a close and the launch after it, without growing forever.
54
- local TRACE_LIMIT = 24
55
-
56
-
57
- --[[
58
- A fresh id per plugin load, which in practice means one per Studio window.
59
-
60
- This was originally persisted with `plugin:SetSetting`, on the reasoning that a
61
- stable id keeps reconnects mapping to the same session. That is wrong as soon
62
- as the user opens a second window: plugin settings live in one file shared by
63
- every Studio process, so both windows announce the same id, and the server
64
- treats the second connection as the first one reconnecting -- closing the
65
- original stream and making it impossible to address the two places separately.
66
-
67
- Held in memory instead. A reconnect within one load (the SSE stream hits its
68
- 30-minute cap) reuses this id, and `plugin.Unloading` detaches cleanly on
69
- reload, so ghost entries do not accumulate.
70
- ]]
71
- local SESSION_ID = HttpService:GenerateGUID(false)
72
-
73
- local function studioId(): string
74
- return SESSION_ID
75
- end
76
-
77
- --[[
78
- Whether this copy of the plugin can reach the bridge at all.
79
-
80
- Pressing Play loads the plugin into the playtest's DataModels as well as the
81
- editor's, and HttpService refuses every request from a client one: "Http
82
- requests can only be executed by game server". The transport read that as a
83
- dropped connection and retried forever, filling the console with red while
84
- nothing was actually wrong.
85
-
86
- The editor session and the play session's server can both connect and are
87
- worth connecting -- addressing a running server is useful. The client half
88
- simply says so once and stops.
89
- ]]
90
- local function canConnect(): (boolean, string?)
91
- if RunService:IsEdit() or RunService:IsServer() then
92
- return true, nil
93
- end
94
- --[[
95
- The wording names the fix, because the symptom is indistinguishable
96
- from a broken server: a user watching this window during a playtest
97
- sees a console that logs nothing while tools plainly work, and has no
98
- way to guess that the activity is in a different view of the same
99
- Studio. Reported once here and again as the strip's caption, since
100
- one line scrolled off the top is easy to miss.
101
- ]]
102
- return false,
103
- "client view of a playtest -- Studio forbids client sessions from making HTTP "
104
- .. "requests, so this panel cannot reach the bridge itself. It is MIRRORING "
105
- .. "the playtest's server session instead, so the log and the strip below "
106
- .. "are live. Switch to the Server view (Test tab, Current: Server) for the "
107
- .. "session that is actually connected."
108
- end
109
-
110
- -- First thing, before any handler or the transport can log: the buffer only
111
- -- holds what was printed after it subscribed, so every line ahead of this call
112
- -- is unrecoverable. This runs even in a client session that will never connect,
113
- -- since the console tool reads it and connectivity is a separate question.
114
- LogBuffer.start()
115
-
116
- local storedPort = plugin:GetSetting(SETTING_PORT)
117
- if typeof(storedPort) == "number" then
118
- Config.setPort(storedPort)
119
- end
120
-
121
- Transport.setForcePoll(plugin:GetSetting(SETTING_FORCE_POLL) == true)
122
-
123
- --[[
124
- The console's colour preset, restored before anything is drawn.
125
-
126
- Applied here rather than after mounting so the panel is built in the right
127
- palette from the start -- restoring it afterwards would flash the default
128
- theme for a frame on every Studio launch. An unknown id (a preset renamed,
129
- or a setting written by a newer build) falls back to the default rather than
130
- failing, which is `Themes.get`'s job.
131
- ]]
132
- local storedTheme = plugin:GetSetting(SETTING_THEME)
133
- if typeof(storedTheme) == "string" then
134
- Themes.use(storedTheme)
135
- end
136
-
137
- --[[
138
- Whether the restore above still has to be pushed into the console.
139
-
140
- `Themes.use` moves the ACTIVE ID, and anything that reads the palette live
141
- picks the change up for free -- which is why the prism cell came back on the
142
- saved preset. `Console` does not read it live: it caches the palette in an
143
- upvalue at module load, deliberately, so that forty read sites stay plain
144
- field accesses. Module load happens at the `require` above, which is BEFORE
145
- this line, so the cache held the default while the id said otherwise, and a
146
- reload came back as the saved prism drawn in the default's colours.
147
-
148
- It cannot simply be applied here either -- the console is not mounted yet.
149
- So it is remembered and applied the moment it can be, right after mounting.
150
- ]]
151
- local themeNeedsApplying = typeof(storedTheme) == "string" and Themes.activeId() == storedTheme
152
-
153
- Session.register()
154
- Discover.register()
155
- Debug.register()
156
- Instances.register()
157
- Perf.register(plugin)
158
- Playtest.register()
159
- Capture.register()
160
- Assets.register()
161
- Character.register()
162
- Geometry.register()
163
- Generate.register()
164
- Terrain.register()
165
- World.register()
166
- Exec.register()
167
- Viewport.register()
168
- Scripts.register()
169
- Input.register()
170
- Device.register()
171
- Api.register()
172
-
173
- --[[
174
- The toolbar button.
175
-
176
- The icon has to be an uploaded asset: `CreateButton` takes a content string,
177
- and the only ones Studio resolves are `rbxassetid://` for uploaded images and
178
- `rbxasset://` for files that ship inside Studio itself. A path to something in
179
- this repository is not one of them, which is why the mark in `assets/` has to
180
- go through an upload before it can appear here.
181
-
182
- It used to borrow `textures/ui/common/robux.png` -- a Robux coin, sitting in
183
- the toolbar next to a plugin that has nothing to do with purchases.
184
- ]]
185
- local toolbar = plugin:CreateToolbar("rbx-studio")
186
- local button = toolbar:CreateButton(
187
- "rbx-studio",
188
- "Show the rbx-studio console",
189
- "rbxassetid://125390773465346"
190
- )
191
- button.ClickableWhenViewportHidden = true
192
-
193
- --[[
194
- The panel, opened and sized the way the user last left it -- in EVERY
195
- DataModel, which is the whole point.
196
-
197
- Pressing Play loads this plugin again into the playtest's DataModels, and a
198
- dock widget belongs to the DataModel that created it: the editor's is hidden
199
- along with the editor's view, and the playtest's is a brand new widget that
200
- Studio brings up closed and at the default size. So the panel vanished on
201
- every playtest and came back, when the user re-opened it from the toolbar,
202
- as a 560x320 float with whatever size they had chosen thrown away.
203
-
204
- Studio's own restore does not cross that boundary, so the preference is kept
205
- here instead and passed in as the INITIAL state, with `overrideEnabledRestore`
206
- set so it is honoured rather than second-guessed. Written only from the
207
- editor session -- see below -- so a playtest starting or ending can never
208
- record a decision the user did not make.
209
- ]]
210
- local storedOpen = plugin:GetSetting(SETTING_WIDGET_OPEN)
211
- local wantOpen = if typeof(storedOpen) == "boolean" then storedOpen else true
212
-
213
- local floatWidth, floatHeight = 560, 320
214
- local storedSize = plugin:GetSetting(SETTING_WIDGET_SIZE)
215
- if typeof(storedSize) == "table" then
216
- local saved = storedSize :: { [string]: any }
217
- local x, y = tonumber(saved.x), tonumber(saved.y)
218
- -- Guarded against nonsense: a zero or absurd size saved from a docked or
219
- -- mid-teardown widget would otherwise be unrecoverable without clearing
220
- -- settings by hand.
221
- if x ~= nil and y ~= nil and x >= 360 and y >= 200 and x <= 4000 and y <= 4000 then
222
- floatWidth, floatHeight = math.floor(x), math.floor(y)
223
- end
224
- end
225
-
226
- local widget = plugin:CreateDockWidgetPluginGuiAsync(
227
- "StudioMCP_Console",
228
- DockWidgetPluginGuiInfo.new(
229
- Enum.InitialDockState.Float,
230
- wantOpen,
231
- -- Override Studio's own enabled-restore: ours is the one that survives
232
- -- the hop into a playtest DataModel, and two restores disagreeing is
233
- -- what produced a panel that was open in the editor and closed in play.
234
- true,
235
- floatWidth,
236
- floatHeight,
237
- 360,
238
- 200
239
- )
240
- )
241
- widget.Title = "rbx-studio"
242
-
243
- --[[
244
- Remember what the user does with the panel, from the editor only.
245
-
246
- The editor session is the one whose Enabled and size changes are actually
247
- the user's: a playtest DataModel's widget is created, shown and destroyed by
248
- Studio around the test, and letting those transitions write would persist a
249
- "closed" the user never asked for -- reintroducing the bug through the back
250
- door.
251
- ]]
252
- --[[
253
- Whether the panel is being closed BY THE USER, as opposed to by Studio.
254
-
255
- Set only for the moment the toolbar button toggles the widget, which is the
256
- one close this plugin can attribute with certainty.
257
- ]]
258
- local closingByHand = false
259
-
260
- --[[
261
- A breadcrumb trail across sessions, so this stops being guesswork.
262
-
263
- Two fixes for "the panel does not open any more" were shipped on inference
264
- rather than observation, and this is what finally settled it. Closing a place
265
- traces as:
266
-
267
- load open=true / enabled=false / plugin.Unloading / widget.Destroying
268
-
269
- all within the same second. So both teardown signals DO fire, and promptly --
270
- the opposite of what the second fix was written to work around.
271
-
272
- The reason that fix looked like it failed is duller and worth remembering: a
273
- `false` written by an older build is sticky. Nothing writes `true` again
274
- until the panel is opened by hand, so a stored close outlives the bug that
275
- stored it and makes the next fix look broken too.
276
-
277
- The trail is kept because this bug has now been misdiagnosed twice, and
278
- twenty-four rows is a cheap price for never having to guess at it again. It
279
- also shows the X could be honoured through Unloading -- deliberately not
280
- done, since attribution cannot regress and inference has twice.
281
- ]]
282
- local function trace(what: string)
283
- local ok, existing = pcall(function()
284
- return plugin:GetSetting(SETTING_WIDGET_TRACE)
285
- end)
286
- local rows: { string } = if ok and typeof(existing) == "table" then existing :: { string } else {}
287
- table.insert(rows, string.format("%d %s", os.time(), what))
288
- while #rows > TRACE_LIMIT do
289
- table.remove(rows, 1)
290
- end
291
- pcall(function()
292
- plugin:SetSetting(SETTING_WIDGET_TRACE, rows)
293
- end)
294
- end
295
-
296
- if RunService:IsEdit() then
297
- trace(string.format("load open=%s", tostring(storedOpen)))
298
-
299
- plugin.Unloading:Connect(function()
300
- trace("plugin.Unloading")
301
- end)
302
- widget.Destroying:Connect(function()
303
- trace("widget.Destroying")
304
- end)
305
-
306
- --[[
307
- Only a close this plugin performed is remembered.
308
-
309
- Opening is recorded at once -- nothing but a user opens a panel, so a
310
- `true` is always genuine. A `false` is the dangerous one, because Studio
311
- disables the widget while tearing a place down and that is
312
- indistinguishable, from in here, from the user clicking the X. Guessing
313
- wrong writes a close nobody performed, and once `false` is stored the
314
- panel never opens again until it is opened by hand -- which is exactly
315
- the bug people report, twice now after a "fix".
316
-
317
- So the guessing is over. The toolbar button is the one close this code
318
- performs itself, and it is the only one written down. Closing the panel
319
- with the X is not persisted, so it will be back on the next launch.
320
- That is a deliberate trade: a panel that reappears when you did not want
321
- it is a small annoyance, and a panel that never appears again reads as a
322
- broken plugin.
323
-
324
- The trace above is what would let the X be honoured too -- if it shows a
325
- teardown signal that reliably beats the disable, this can use it.
326
- ]]
327
- widget:GetPropertyChangedSignal("Enabled"):Connect(function()
328
- if widget.Enabled then
329
- trace("enabled=true -> save true")
330
- plugin:SetSetting(SETTING_WIDGET_OPEN, true)
331
- return
332
- end
333
- if closingByHand then
334
- trace("enabled=false byHand -> save false")
335
- plugin:SetSetting(SETTING_WIDGET_OPEN, false)
336
- return
337
- end
338
- -- Studio's doing, or the X. Either way, not written down.
339
- trace("enabled=false ignored")
340
- end)
341
-
342
- -- Only a real, sane size, and only while the panel is up: a hidden or
343
- -- collapsing widget reports sizes that are not a choice.
344
- local function persistSize(): boolean
345
- local size = widget.AbsoluteSize
346
- if unloading or not widget.Enabled or size.X < 360 or size.Y < 200 then
347
- return false
348
- end
349
- plugin:SetSetting(SETTING_WIDGET_SIZE, { x = math.floor(size.X), y = math.floor(size.Y) })
350
- return true
351
- end
352
-
353
- widget:GetPropertyChangedSignal("AbsoluteSize"):Connect(persistSize)
354
-
355
- --[[
356
- Seed from the size Studio has already restored, rather than waiting for
357
- a resize that may never come.
358
-
359
- Without this the setting stays empty until the user happens to drag the
360
- panel's edge, so the first playtest inherits the 560x320 default and the
361
- window visibly shrinks -- which is the same complaint as it vanishing,
362
- one step later. Studio settles the geometry a few frames after the widget
363
- is created and fires no change event for it, so it is polled briefly and
364
- then left alone.
365
- ]]
366
- task.defer(function()
367
- for _ = 1, 40 do
368
- if persistSize() then
369
- return
370
- end
371
- task.wait(0.1)
372
- end
373
- end)
374
- end
375
-
376
- local currentStatus: Transport.Status = "disconnected"
377
-
378
- local function refreshMeta()
379
- Console.setStatus(
380
- currentStatus,
381
- string.format(
382
- "127.0.0.1:%d %s build %s",
383
- Config.getPort(),
384
- Transport.getMode(),
385
- Config.BUILD_ID
386
- )
387
- )
388
- button:SetActive(currentStatus == "connected")
389
- end
390
-
391
- local connect: () -> ()
392
-
393
- Console.mount(widget, {
394
- onReconnect = function()
395
- Console.log("info", "reconnect requested")
396
- Transport.stop()
397
- task.wait(0.2)
398
- connect()
399
- end,
400
- onClear = function()
401
- Console.clear()
402
- end,
403
- onTheme = function(id)
404
- plugin:SetSetting(SETTING_THEME, id)
405
- Console.log("dim", string.format("theme: %s", id))
406
- end,
407
- onSubmit = function(line)
408
- Commands.run(line)
409
- end,
410
- onComplete = function(prefix)
411
- return Commands.complete(prefix)
412
- end,
413
- onSuggest = function(prefix)
414
- return Commands.suggest(prefix)
415
- end,
416
- })
417
-
418
- --[[
419
- What the command line cannot reach on its own.
420
-
421
- `plugin:SetSetting` is unavailable inside a ModuleScript, and the transport's
422
- lifecycle lives here rather than in the console, so the handful of commands
423
- that need either are handed a function instead of a dependency.
424
- ]]
425
- Commands.setup({
426
- reconnect = function()
427
- Console.log("info", "reconnect requested")
428
- Transport.stop()
429
- task.wait(0.2)
430
- connect()
431
- end,
432
- savePort = function(value)
433
- plugin:SetSetting(SETTING_PORT, value)
434
- end,
435
- saveTheme = function(id)
436
- plugin:SetSetting(SETTING_THEME, id)
437
- end,
438
- status = function()
439
- return currentStatus
440
- end,
441
- studioId = studioId,
442
- })
443
-
444
- -- The saved preset, now that there is something to paint. Done immediately
445
- -- after mounting and before the first line is logged, so nothing is ever drawn
446
- -- in the wrong palette.
447
- if themeNeedsApplying then
448
- Console.applyTheme()
449
- end
450
-
451
- --[[
452
- Keeps the prompt row showing what Studio has selected.
453
-
454
- `Selection.SelectionChanged` is the event the panel was missing. Everything
455
- about the selection was previously available only on demand, through
456
- `studio_status`, which answers an agent's question but not the user's: they
457
- are the one typing "make this bigger", and the word is only safe to type if
458
- they can see what it means without leaving the panel.
459
-
460
- Debounced through a generation counter rather than a timer handle, the same
461
- way `recordCall` schedules its summary. Drag-selecting a group in the
462
- viewport fires this once per instance added -- dozens of times in a second
463
- -- and re-rendering a label on every one of them is work nobody sees.
464
- ]]
465
- local selectionGeneration = 0
466
-
467
- local function describeSelection(): string
468
- local picked = Selection:Get()
469
- if #picked == 0 then
470
- return ""
471
- end
472
- if #picked == 1 then
473
- -- The name alone. The class is in the Properties panel and the path is
474
- -- in the Explorer; what this line is for is confirming WHICH thing.
475
- return string.format("\u{25A3} %s", picked[1].Name)
476
- end
477
- return string.format("\u{25A3} %d selected", #picked)
478
- end
479
-
480
- local function watchSelection()
481
- Selection.SelectionChanged:Connect(function()
482
- selectionGeneration += 1
483
- local mine = selectionGeneration
484
- task.delay(0.12, function()
485
- if selectionGeneration ~= mine then
486
- return
487
- end
488
- -- Guarded: an instance can be destroyed between the event and this
489
- -- running, and reading `.Name` on it throws.
490
- local ok, text = pcall(describeSelection)
491
- Console.setSelection(if ok then text else "")
492
- end)
493
- end)
494
- Console.setSelection(describeSelection())
495
- end
496
-
497
- -- Only in the editor. A playtest session has its own Selection service that
498
- -- nobody is clicking in, and the client view cannot reach the panel at all.
499
- if RunService:IsEdit() then
500
- watchSelection()
501
- end
502
-
503
- --[[
504
- The log, picked up where the last copy of this plugin left it.
505
-
506
- Restored before the banner below rather than after it, so the carried rows
507
- read as what they are -- what was on screen a moment ago -- with this
508
- session's first line underneath them instead of buried in the middle.
509
-
510
- Every session reads; only the editor writes. See `History` for why.
511
- ]]
512
- History.attach(plugin, Console.snapshot)
513
- local carried = History.restore()
514
- if #carried > 0 then
515
- Console.restore(carried)
516
- Console.log(
517
- "dim",
518
- string.format("carried %d line%s over", #carried, if #carried == 1 then "" else "s"),
519
- if RunService:IsEdit() then "from the last session" else "from the editor"
520
- )
521
- end
522
-
523
- if RunService:IsEdit() then
524
- History.start()
525
- plugin.Unloading:Connect(function()
526
- History.stop()
527
- -- The loop cannot save what happens after it has stopped, and closing
528
- -- Studio is exactly when the last few rows matter most.
529
- History.flush()
530
- end)
531
- end
532
-
533
- --[[
534
- The playtest halves, joined.
535
-
536
- The server half can reach the bridge and sees every command; the client half
537
- is the one Studio actually shows during a playtest and can reach nothing. So
538
- the server relays its console events and the client replays them, which is
539
- the only way the panel in front of the user reacts to the work being done.
540
-
541
- Note which side sets the observer: only the SERVER. The client replays
542
- events through the same `Console` functions, and if it were also observing
543
- it would echo each one straight back into the channel.
544
- ]]
545
- if RunService:IsEdit() then
546
- -- The only observer the edit session needs: every logged row marks the
547
- -- stored copy stale, and the save loop above decides when to write it.
548
- Console.setObserver(function()
549
- History.touch()
550
- end)
551
- elseif Mirror.isPlaytestServer() then
552
- Mirror.startServer()
553
- Console.setObserver(function(kind, arguments)
554
- Mirror.send(kind, arguments)
555
- end)
556
- -- The channel itself stays shut until `onStatus` reports the connection;
557
- -- see `Mirror.open`.
558
- elseif Mirror.isPlaytestClient() then
559
- Console.setMirroring(true)
560
- Mirror.startClient(function(kind, arguments)
561
- if kind == "log" then
562
- local level, message, detail = arguments[1], arguments[2], arguments[3]
563
- if typeof(level) == "string" and typeof(message) == "string" then
564
- Console.log(
565
- level :: any,
566
- message,
567
- if typeof(detail) == "string" then detail else nil
568
- )
569
- end
570
- elseif kind == "beginCall" then
571
- local title, callKind = arguments[1], arguments[2]
572
- if typeof(title) == "string" and typeof(callKind) == "string" then
573
- Console.beginCall(title, callKind)
574
- end
575
- elseif kind == "recordCall" then
576
- local ok, milliseconds = arguments[1], arguments[2]
577
- if typeof(ok) == "boolean" and typeof(milliseconds) == "number" then
578
- Console.recordCall(ok, milliseconds)
579
- end
580
- end
581
- end)
582
- end
583
-
584
- Console.log("info", string.format("rbx-studio v%s", Config.PLUGIN_VERSION), "build " .. Config.BUILD_ID)
585
- Console.log("dim", string.format("place: %s (%d)", game.Name, game.PlaceId))
586
-
587
- local function onStatus(status: Transport.Status, detail: string?)
588
- local previous = currentStatus
589
- currentStatus = status
590
- refreshMeta()
591
-
592
- -- Only narrate transitions. The transport re-reports its state on every
593
- -- reconnect attempt, and echoing an unchanged status would bury real events.
594
- if status == previous and detail == nil then
595
- return
596
- end
597
-
598
- if status == "connected" then
599
- Console.log(
600
- "ok",
601
- string.format("connected to 127.0.0.1:%d", Config.getPort()),
602
- if detail then "(" .. detail .. ")" else nil
603
- )
604
- -- After the row, not before it: this session's own arrival is not news
605
- -- to the client view, which announced its own a moment ago.
606
- Mirror.open()
607
- elseif status == "connecting" then
608
- Console.log("dim", string.format("connecting to 127.0.0.1:%d...", Config.getPort()))
609
- else
610
- Console.log("error", "disconnected", detail)
611
- end
612
- end
613
-
614
- --[[
615
- Runs each command on its own task. Handlers may yield -- `UpdateSourceAsync`
616
- and any `*Async` call does -- and serialising them would let one slow edit
617
- stall every other request on the stream.
618
- ]]
619
- local function onCommand(id: string, op: string, params: { [string]: any }?)
620
- task.spawn(function()
621
- local startedAt = os.clock()
622
- --[[
623
- Named for what it does, not for how it travels. `script.edit` on
624
- ServerScriptService.Systems.KillBrick reads as "Edit KillBrick",
625
- which is the thing someone watching actually wants to know; the wire
626
- name is kept alongside so the log still maps onto the protocol when
627
- something needs debugging.
628
- ]]
629
- local title = Phrase.of(op, params)
630
- --[[
631
- Announced synchronously, unlike the logging below.
632
-
633
- Deferring this looked like free latency and was not. `beginCall` sets
634
- two labels and some fields -- it never touches the RichText log, which
635
- is where the cost actually is -- and deferring it let a call that
636
- finished inside one frame record its result before the call had been
637
- announced, so the bar on the trace lost the name it was supposed to
638
- carry. A microsecond is not worth an ordering hazard.
639
- ]]
640
- Console.beginCall(title, Phrase.kindOf(op))
641
-
642
- local result = Dispatch.invoke(id, op, params)
643
- local milliseconds = (os.clock() - startedAt) * 1000
644
-
645
- --[[
646
- The answer goes out before the console hears about it.
647
-
648
- This used to be the last line of the function, which put a
649
- `table.concat` of three hundred strings, a RichText relayout of the
650
- whole log, two `Instance.new` calls and a forty-bar relayout in front
651
- of the reply on its way back to the agent. None of that is work the
652
- caller asked for, and all of it was being billed to the round trip
653
- this project measures. Drawing happens below, on time the agent is no
654
- longer waiting for.
655
- ]]
656
- Transport.sendResult(result)
657
-
658
- local elapsed = string.format("%.0fms", milliseconds)
659
- Console.recordCall(result.ok, milliseconds)
660
-
661
- if result.ok then
662
- Console.log("reply", title, elapsed)
663
- else
664
- local err = result.error
665
- Console.log(
666
- "error",
667
- string.format("%s failed: %s", title, if err then err.code else "unknown"),
668
- elapsed
669
- )
670
- if err and err.message then
671
- Console.log("dim", " " .. err.message)
672
- end
673
- end
674
- end)
675
- end
676
-
677
- --[[
678
- Where a peer's call ran, in the width the detail column has.
679
-
680
- The latency already lives there and only about fourteen characters fit
681
- beside a message, so this is two letters and a space rather than "playtest
682
- server". Which half of a playtest it was does not matter to someone reading
683
- the editor's log afterwards; that it was not the editor does.
684
- ]]
685
- local function peerTag(from: any): string
686
- if typeof(from) ~= "string" then
687
- return "peer"
688
- end
689
- return if from == "edit" then "edit" else "play"
690
- end
691
-
692
- --[[
693
- Bridge news that is not a command.
694
-
695
- Kept deliberately narrow: an unknown event is ignored rather than logged,
696
- because a newer server talking to an older plugin is a supported situation
697
- and "unknown event" rows would be the only symptom of it working correctly.
698
- ]]
699
- local function onEvent(event: { [string]: any })
700
- if event.event == "clients" and typeof(event.count) == "number" then
701
- Console.setClients(event.count, if typeof(event.list) == "table" then event.list else nil)
702
- elseif event.event == "agent" and event.state == "finished" then
703
- Console.agentFinished()
704
- elseif event.event == "console" and typeof(event.message) == "string" then
705
- --[[
706
- A line from an agent the panel itself started.
707
-
708
- Pushed rather than returned because a run lasts minutes: the request
709
- that started it answered immediately with "started", and everything
710
- after that has to arrive on the stream the plugin already holds open.
711
- ]]
712
- Console.log(
713
- (if typeof(event.level) == "string" then event.level else "dim") :: any,
714
- event.message,
715
- if typeof(event.detail) == "string" then event.detail else nil
716
- )
717
- elseif event.event == "agent-run" then
718
- Console.setPromptBusy(event.state == "running")
719
- elseif event.event == "peer" and typeof(event.op) == "string" then
720
- --[[
721
- A command another session on this place just finished.
722
-
723
- Logged as if it had run here, because as far as the user is concerned
724
- it did: they pressed Play, watched the agent work, pressed Stop, and
725
- the panel that comes back is this one. Without this it comes back with
726
- a hole in it exactly the length of the playtest.
727
-
728
- The prism is bumped too -- `beginCall` then `recordCall`, back to
729
- back -- so the trace carries a bar for the call and the session
730
- counters count it. Nothing here reaches the transport, so a peer row
731
- can never be announced onwards and two sessions cannot echo forever.
732
- ]]
733
- local params = if typeof(event.params) == "table" then event.params else nil
734
- local title = Phrase.of(event.op, params)
735
- local milliseconds = if typeof(event.ms) == "number" then event.ms else 0
736
- local ok = event.ok == true
737
- local detail = string.format("%s %.0fms", peerTag(event.from), milliseconds)
738
-
739
- Console.beginCall(title, Phrase.kindOf(event.op))
740
- Console.recordCall(ok, milliseconds)
741
- if ok then
742
- Console.log("reply", title, detail)
743
- else
744
- Console.log("error", string.format("%s failed", title), detail)
745
- end
746
- end
747
- end
748
-
749
- function connect()
750
- local allowed, reason = canConnect()
751
- if not allowed then
752
- -- Reported as standby rather than an error: nothing failed, and this
753
- -- session was never going to connect.
754
- currentStatus = "disconnected"
755
- Console.log("dim", "mirroring", reason)
756
- Console.setStatus(
757
- "mirroring",
758
- string.format("%s build %s", "client view", Config.BUILD_ID)
759
- )
760
- Console.setCaption("mirroring the playtest server")
761
- return
762
- end
763
- Transport.start(studioId(), { onCommand = onCommand, onStatus = onStatus, onEvent = onEvent })
764
- plugin:SetSetting(SETTING_AUTOCONNECT, true)
765
- end
766
-
767
- button.Click:Connect(function()
768
- -- Flagged around the toggle so the Enabled handler knows this close is the
769
- -- user's, and is safe to remember. See closingByHand.
770
- closingByHand = widget.Enabled
771
- widget.Enabled = not widget.Enabled
772
- closingByHand = false
773
- end)
774
-
775
- plugin.Unloading:Connect(function()
776
- Transport.stop()
777
- end)
778
-
779
- --[[
780
- Switches this session between the push and long-poll transports.
781
-
782
- Registered here rather than in a handler module because it is the only
783
- command that has to reach back into the plugin object and the connection
784
- loop, both of which live in this file -- and registered THIS far down the
785
- file on purpose: `connect` is a forward-declared local, so a closure written
786
- above its declaration captures the global of that name instead, which is nil.
787
- That cost a session. The plugin loaded and connected perfectly, and then died
788
- the first time somebody asked it to switch transport.
789
-
790
- The reply is sent before the reconnect, and the reconnect is deferred:
791
- tearing the stream down inside the handler would strand the answer to the
792
- very call that asked for the switch, which is a confusing way to succeed.
793
- ]]
794
- Dispatch.registerAll("studio", {
795
- transport = function(params: { [string]: any }): { [string]: any }
796
- local requested = params.mode
797
- if requested ~= nil and requested ~= "sse" and requested ~= "poll" then
798
- Dispatch.fail("BAD_PARAMS", 'transport mode must be "sse" or "poll".')
799
- end
800
- if requested == nil then
801
- return { mode = Transport.getMode(), forcePoll = Transport.getForcePoll(), changed = false }
802
- end
803
-
804
- local wantPoll = requested == "poll"
805
- if Transport.getMode() == requested and Transport.getForcePoll() == wantPoll then
806
- return { mode = Transport.getMode(), forcePoll = wantPoll, changed = false }
807
- end
808
-
809
- Transport.setForcePoll(wantPoll)
810
- plugin:SetSetting(SETTING_FORCE_POLL, wantPoll)
811
- task.defer(function()
812
- Transport.stop()
813
- task.wait(0.1)
814
- connect()
815
- end)
816
- return {
817
- mode = requested,
818
- forcePoll = wantPoll,
819
- changed = true,
820
- note = "Reconnecting on the new transport; the next call will use it.",
821
- }
822
- end,
823
- })
824
-
825
- refreshMeta()
826
-
827
- -- Connect on load unless the user explicitly disconnected last session.
828
- if plugin:GetSetting(SETTING_AUTOCONNECT) ~= false then
829
- connect()
830
- else
831
- Console.log("warn", "auto-connect disabled — press reconnect to start")
832
- end
1
+ --!strict
2
+ --[[
3
+ rbx-studio -- plugin entry point.
4
+
5
+ Owns the toolbar UI, this window's Studio identity, and the command loop.
6
+ Handlers do the actual work; this file only wires them to the transport and
7
+ reports what is happening to the console widget.
8
+ ]]
9
+
10
+ local HttpService = game:GetService("HttpService")
11
+ local RunService = game:GetService("RunService")
12
+ local Selection = game:GetService("Selection")
13
+
14
+ local Commands = require(script.Commands)
15
+ local Config = require(script.Config)
16
+ local Console = require(script.Console)
17
+ local Dispatch = require(script.Dispatch)
18
+ local History = require(script.History)
19
+ local LogBuffer = require(script.LogBuffer)
20
+ local Mirror = require(script.Mirror)
21
+ local Phrase = require(script.Phrase)
22
+ local ScriptEdit = require(script.ScriptEdit)
23
+ local Themes = require(script.Themes)
24
+ local Transport = require(script.Transport)
25
+ local Debug = require(script.handlers.Debug)
26
+ local Assets = require(script.handlers.Assets)
27
+ local Capture = require(script.handlers.Capture)
28
+ local Character = require(script.handlers.Character)
29
+ local Geometry = require(script.handlers.Geometry)
30
+ local Generate = require(script.handlers.Generate)
31
+ local Terrain = require(script.handlers.Terrain)
32
+ local World = require(script.handlers.World)
33
+ local Discover = require(script.handlers.Discover)
34
+ local Exec = require(script.handlers.Exec)
35
+ local Instances = require(script.handlers.Instances)
36
+ local Perf = require(script.handlers.Perf)
37
+ local Playtest = require(script.handlers.Playtest)
38
+ local Viewport = require(script.handlers.Viewport)
39
+ local Input = require(script.handlers.Input)
40
+ local Device = require(script.handlers.Device)
41
+ local Data = require(script.handlers.Data)
42
+ local Anim = require(script.handlers.Anim)
43
+ local Api = require(script.handlers.Api)
44
+ local Scripts = require(script.handlers.Scripts)
45
+ local Session = require(script.handlers.Session)
46
+
47
+ local SETTING_PORT = "port"
48
+ local SETTING_AUTOCONNECT = "autoConnect"
49
+ local SETTING_FORCE_POLL = "forcePoll"
50
+ local SETTING_THEME = "theme"
51
+ local SETTING_WIDGET_OPEN = "widgetOpen"
52
+ --[[
53
+ Whether the panel is allowed to come up on its own at all.
54
+
55
+ Separate from `widgetOpen`, which is where the user last left it. That one
56
+ answers "was it open?"; this one answers "may it open itself?", and they are
57
+ different questions -- someone who wants the panel there when they ask for it
58
+ and nowhere else has no way to say so with a single remembered flag, because
59
+ opening it once would arm it for every load afterwards.
60
+
61
+ Off means the toolbar button is the only thing that opens it: not a place
62
+ being opened, not a Studio launch, not pressing Play. Set by `autoopen off`.
63
+ ]]
64
+ local SETTING_AUTO_OPEN = "autoOpen"
65
+ local SETTING_WIDGET_SIZE = "widgetSize"
66
+ local SETTING_WIDGET_TRACE = "widgetTrace"
67
+
68
+ -- Enough to cover a close and the launch after it, without growing forever.
69
+ local TRACE_LIMIT = 24
70
+
71
+
72
+ --[[
73
+ A fresh id per plugin load, which in practice means one per Studio window.
74
+
75
+ This was originally persisted with `plugin:SetSetting`, on the reasoning that a
76
+ stable id keeps reconnects mapping to the same session. That is wrong as soon
77
+ as the user opens a second window: plugin settings live in one file shared by
78
+ every Studio process, so both windows announce the same id, and the server
79
+ treats the second connection as the first one reconnecting -- closing the
80
+ original stream and making it impossible to address the two places separately.
81
+
82
+ Held in memory instead. A reconnect within one load (the SSE stream hits its
83
+ 30-minute cap) reuses this id, and `plugin.Unloading` detaches cleanly on
84
+ reload, so ghost entries do not accumulate.
85
+ ]]
86
+ local SESSION_ID = HttpService:GenerateGUID(false)
87
+
88
+ local function studioId(): string
89
+ return SESSION_ID
90
+ end
91
+
92
+ --[[
93
+ Whether this copy of the plugin can reach the bridge at all.
94
+
95
+ Pressing Play loads the plugin into the playtest's DataModels as well as the
96
+ editor's, and HttpService refuses every request from a client one: "Http
97
+ requests can only be executed by game server". The transport read that as a
98
+ dropped connection and retried forever, filling the console with red while
99
+ nothing was actually wrong.
100
+
101
+ The editor session and the play session's server can both connect and are
102
+ worth connecting -- addressing a running server is useful. The client half
103
+ simply says so once and stops.
104
+ ]]
105
+ local function canConnect(): (boolean, string?)
106
+ if RunService:IsEdit() or RunService:IsServer() then
107
+ return true, nil
108
+ end
109
+ --[[
110
+ The wording names the fix, because the symptom is indistinguishable
111
+ from a broken server: a user watching this window during a playtest
112
+ sees a console that logs nothing while tools plainly work, and has no
113
+ way to guess that the activity is in a different view of the same
114
+ Studio. Reported once here and again as the strip's caption, since
115
+ one line scrolled off the top is easy to miss.
116
+ ]]
117
+ return false,
118
+ "client view of a playtest -- Studio forbids client sessions from making HTTP "
119
+ .. "requests, so this panel cannot reach the bridge itself. It is MIRRORING "
120
+ .. "the playtest's server session instead, so the log and the strip below "
121
+ .. "are live. Switch to the Server view (Test tab, Current: Server) for the "
122
+ .. "session that is actually connected."
123
+ end
124
+
125
+ -- First thing, before any handler or the transport can log: the buffer only
126
+ -- holds what was printed after it subscribed, so every line ahead of this call
127
+ -- is unrecoverable. This runs even in a client session that will never connect,
128
+ -- since the console tool reads it and connectivity is a separate question.
129
+ LogBuffer.start()
130
+
131
+ local storedPort = plugin:GetSetting(SETTING_PORT)
132
+ if typeof(storedPort) == "number" then
133
+ Config.setPort(storedPort)
134
+ end
135
+
136
+ Transport.setForcePoll(plugin:GetSetting(SETTING_FORCE_POLL) == true)
137
+
138
+ --[[
139
+ The console's colour preset, restored before anything is drawn.
140
+
141
+ Applied here rather than after mounting so the panel is built in the right
142
+ palette from the start -- restoring it afterwards would flash the default
143
+ theme for a frame on every Studio launch. An unknown id (a preset renamed,
144
+ or a setting written by a newer build) falls back to the default rather than
145
+ failing, which is `Themes.get`'s job.
146
+ ]]
147
+ local storedTheme = plugin:GetSetting(SETTING_THEME)
148
+ if typeof(storedTheme) == "string" then
149
+ Themes.use(storedTheme)
150
+ end
151
+
152
+ --[[
153
+ Whether the restore above still has to be pushed into the console.
154
+
155
+ `Themes.use` moves the ACTIVE ID, and anything that reads the palette live
156
+ picks the change up for free -- which is why the prism cell came back on the
157
+ saved preset. `Console` does not read it live: it caches the palette in an
158
+ upvalue at module load, deliberately, so that forty read sites stay plain
159
+ field accesses. Module load happens at the `require` above, which is BEFORE
160
+ this line, so the cache held the default while the id said otherwise, and a
161
+ reload came back as the saved prism drawn in the default's colours.
162
+
163
+ It cannot simply be applied here either -- the console is not mounted yet.
164
+ So it is remembered and applied the moment it can be, right after mounting.
165
+ ]]
166
+ local themeNeedsApplying = typeof(storedTheme) == "string" and Themes.activeId() == storedTheme
167
+
168
+ Session.register()
169
+ Discover.register()
170
+ Debug.register()
171
+ Instances.register()
172
+ Perf.register(plugin)
173
+ Playtest.register()
174
+ Capture.register()
175
+ Assets.register()
176
+ Character.register()
177
+ Geometry.register()
178
+ Generate.register()
179
+ Terrain.register()
180
+ World.register()
181
+ Exec.register()
182
+ Viewport.register()
183
+ Scripts.register()
184
+ Input.register()
185
+ Device.register()
186
+ Data.register()
187
+ Anim.register()
188
+ Api.register()
189
+
190
+ --[[
191
+ The toolbar button.
192
+
193
+ The icon has to be an uploaded asset: `CreateButton` takes a content string,
194
+ and the only ones Studio resolves are `rbxassetid://` for uploaded images and
195
+ `rbxasset://` for files that ship inside Studio itself. A path to something in
196
+ this repository is not one of them, which is why the mark in `assets/` has to
197
+ go through an upload before it can appear here.
198
+
199
+ It used to borrow `textures/ui/common/robux.png` -- a Robux coin, sitting in
200
+ the toolbar next to a plugin that has nothing to do with purchases.
201
+ ]]
202
+ local toolbar = plugin:CreateToolbar("rbx-studio")
203
+ local button = toolbar:CreateButton(
204
+ "rbx-studio",
205
+ "Show the rbx-studio console",
206
+ "rbxassetid://125390773465346"
207
+ )
208
+ button.ClickableWhenViewportHidden = true
209
+
210
+ --[[
211
+ The panel, opened and sized the way the user last left it -- in EVERY
212
+ DataModel, which is the whole point.
213
+
214
+ Pressing Play loads this plugin again into the playtest's DataModels, and a
215
+ dock widget belongs to the DataModel that created it: the editor's is hidden
216
+ along with the editor's view, and the playtest's is a brand new widget that
217
+ Studio brings up closed and at the default size. So the panel vanished on
218
+ every playtest and came back, when the user re-opened it from the toolbar,
219
+ as a 560x320 float with whatever size they had chosen thrown away.
220
+
221
+ Studio's own restore does not cross that boundary, so the preference is kept
222
+ here instead and passed in as the INITIAL state, with `overrideEnabledRestore`
223
+ set so it is honoured rather than second-guessed. Written only from the
224
+ editor session -- see below -- so a playtest starting or ending can never
225
+ record a decision the user did not make.
226
+ ]]
227
+ local storedOpen = plugin:GetSetting(SETTING_WIDGET_OPEN)
228
+ local wantOpen = if typeof(storedOpen) == "boolean" then storedOpen else true
229
+
230
+ --[[
231
+ `autoopen off` means this load does not put the panel on screen.
232
+
233
+ Every DataModel, deliberately. The first version of this only covered the
234
+ playtest, on the reading that a window over the game view was the complaint
235
+ -- but a panel that reappears every time a place is opened is the same
236
+ complaint arriving through the other door, and one switch for "open yourself"
237
+ is easier to hold in your head than two.
238
+
239
+ Read here rather than acted on later because a dock widget's initial state is
240
+ fixed when it is created: bringing it up and hiding it again would flash a
241
+ window on screen, which is the thing being asked for less of. `widgetOpen` is
242
+ left exactly as it was, so turning this back on restores the panel to however
243
+ it was last left rather than to a default.
244
+ ]]
245
+ local storedAutoOpen = plugin:GetSetting(SETTING_AUTO_OPEN)
246
+ local autoOpen = if typeof(storedAutoOpen) == "boolean" then storedAutoOpen else true
247
+ if not autoOpen then
248
+ wantOpen = false
249
+ end
250
+
251
+ local floatWidth, floatHeight = 560, 320
252
+ local storedSize = plugin:GetSetting(SETTING_WIDGET_SIZE)
253
+ if typeof(storedSize) == "table" then
254
+ local saved = storedSize :: { [string]: any }
255
+ local x, y = tonumber(saved.x), tonumber(saved.y)
256
+ -- Guarded against nonsense: a zero or absurd size saved from a docked or
257
+ -- mid-teardown widget would otherwise be unrecoverable without clearing
258
+ -- settings by hand.
259
+ if x ~= nil and y ~= nil and x >= 360 and y >= 200 and x <= 4000 and y <= 4000 then
260
+ floatWidth, floatHeight = math.floor(x), math.floor(y)
261
+ end
262
+ end
263
+
264
+ local widget = plugin:CreateDockWidgetPluginGuiAsync(
265
+ "StudioMCP_Console",
266
+ DockWidgetPluginGuiInfo.new(
267
+ Enum.InitialDockState.Float,
268
+ wantOpen,
269
+ -- Override Studio's own enabled-restore: ours is the one that survives
270
+ -- the hop into a playtest DataModel, and two restores disagreeing is
271
+ -- what produced a panel that was open in the editor and closed in play.
272
+ true,
273
+ floatWidth,
274
+ floatHeight,
275
+ 360,
276
+ 200
277
+ )
278
+ )
279
+ widget.Title = "rbx-studio"
280
+
281
+ --[[
282
+ Remember what the user does with the panel, from the editor only.
283
+
284
+ The editor session is the one whose Enabled and size changes are actually
285
+ the user's: a playtest DataModel's widget is created, shown and destroyed by
286
+ Studio around the test, and letting those transitions write would persist a
287
+ "closed" the user never asked for -- reintroducing the bug through the back
288
+ door.
289
+ ]]
290
+ --[[
291
+ Whether the panel is being closed BY THE USER, as opposed to by Studio.
292
+
293
+ Set only for the moment the toolbar button toggles the widget, which is the
294
+ one close this plugin can attribute with certainty.
295
+ ]]
296
+ local closingByHand = false
297
+
298
+ --[[
299
+ A breadcrumb trail across sessions, so this stops being guesswork.
300
+
301
+ Two fixes for "the panel does not open any more" were shipped on inference
302
+ rather than observation, and this is what finally settled it. Closing a place
303
+ traces as:
304
+
305
+ load open=true / enabled=false / plugin.Unloading / widget.Destroying
306
+
307
+ all within the same second. So both teardown signals DO fire, and promptly --
308
+ the opposite of what the second fix was written to work around.
309
+
310
+ The reason that fix looked like it failed is duller and worth remembering: a
311
+ `false` written by an older build is sticky. Nothing writes `true` again
312
+ until the panel is opened by hand, so a stored close outlives the bug that
313
+ stored it and makes the next fix look broken too.
314
+
315
+ The trail is kept because this bug has now been misdiagnosed twice, and
316
+ twenty-four rows is a cheap price for never having to guess at it again. It
317
+ also shows the X could be honoured through Unloading -- deliberately not
318
+ done, since attribution cannot regress and inference has twice.
319
+ ]]
320
+ local function trace(what: string)
321
+ local ok, existing = pcall(function()
322
+ return plugin:GetSetting(SETTING_WIDGET_TRACE)
323
+ end)
324
+ local rows: { string } = if ok and typeof(existing) == "table" then existing :: { string } else {}
325
+ table.insert(rows, string.format("%d %s", os.time(), what))
326
+ while #rows > TRACE_LIMIT do
327
+ table.remove(rows, 1)
328
+ end
329
+ pcall(function()
330
+ plugin:SetSetting(SETTING_WIDGET_TRACE, rows)
331
+ end)
332
+ end
333
+
334
+ if RunService:IsEdit() then
335
+ trace(string.format("load open=%s", tostring(storedOpen)))
336
+
337
+ plugin.Unloading:Connect(function()
338
+ trace("plugin.Unloading")
339
+ end)
340
+ widget.Destroying:Connect(function()
341
+ trace("widget.Destroying")
342
+ end)
343
+
344
+ --[[
345
+ Only a close this plugin performed is remembered.
346
+
347
+ Opening is recorded at once -- nothing but a user opens a panel, so a
348
+ `true` is always genuine. A `false` is the dangerous one, because Studio
349
+ disables the widget while tearing a place down and that is
350
+ indistinguishable, from in here, from the user clicking the X. Guessing
351
+ wrong writes a close nobody performed, and once `false` is stored the
352
+ panel never opens again until it is opened by hand -- which is exactly
353
+ the bug people report, twice now after a "fix".
354
+
355
+ So the guessing is over. The toolbar button is the one close this code
356
+ performs itself, and it is the only one written down. Closing the panel
357
+ with the X is not persisted, so it will be back on the next launch.
358
+ That is a deliberate trade: a panel that reappears when you did not want
359
+ it is a small annoyance, and a panel that never appears again reads as a
360
+ broken plugin.
361
+
362
+ The trace above is what would let the X be honoured too -- if it shows a
363
+ teardown signal that reliably beats the disable, this can use it.
364
+ ]]
365
+ widget:GetPropertyChangedSignal("Enabled"):Connect(function()
366
+ if widget.Enabled then
367
+ trace("enabled=true -> save true")
368
+ plugin:SetSetting(SETTING_WIDGET_OPEN, true)
369
+ return
370
+ end
371
+ if closingByHand then
372
+ trace("enabled=false byHand -> save false")
373
+ plugin:SetSetting(SETTING_WIDGET_OPEN, false)
374
+ return
375
+ end
376
+ -- Studio's doing, or the X. Either way, not written down.
377
+ trace("enabled=false ignored")
378
+ end)
379
+
380
+ -- Only a real, sane size, and only while the panel is up: a hidden or
381
+ -- collapsing widget reports sizes that are not a choice.
382
+ local function persistSize(): boolean
383
+ local size = widget.AbsoluteSize
384
+ if unloading or not widget.Enabled or size.X < 360 or size.Y < 200 then
385
+ return false
386
+ end
387
+ plugin:SetSetting(SETTING_WIDGET_SIZE, { x = math.floor(size.X), y = math.floor(size.Y) })
388
+ return true
389
+ end
390
+
391
+ widget:GetPropertyChangedSignal("AbsoluteSize"):Connect(persistSize)
392
+
393
+ --[[
394
+ Seed from the size Studio has already restored, rather than waiting for
395
+ a resize that may never come.
396
+
397
+ Without this the setting stays empty until the user happens to drag the
398
+ panel's edge, so the first playtest inherits the 560x320 default and the
399
+ window visibly shrinks -- which is the same complaint as it vanishing,
400
+ one step later. Studio settles the geometry a few frames after the widget
401
+ is created and fires no change event for it, so it is polled briefly and
402
+ then left alone.
403
+ ]]
404
+ task.defer(function()
405
+ for _ = 1, 40 do
406
+ if persistSize() then
407
+ return
408
+ end
409
+ task.wait(0.1)
410
+ end
411
+ end)
412
+ end
413
+
414
+ local currentStatus: Transport.Status = "disconnected"
415
+
416
+ local function refreshMeta()
417
+ Console.setStatus(
418
+ currentStatus,
419
+ string.format(
420
+ "127.0.0.1:%d %s build %s",
421
+ Config.getPort(),
422
+ Transport.getMode(),
423
+ Config.BUILD_ID
424
+ )
425
+ )
426
+ button:SetActive(currentStatus == "connected")
427
+ end
428
+
429
+ local connect: () -> ()
430
+
431
+ Console.mount(widget, {
432
+ onReconnect = function()
433
+ Console.log("info", "reconnect requested")
434
+ Transport.stop()
435
+ task.wait(0.2)
436
+ connect()
437
+ end,
438
+ onClear = function()
439
+ Console.clear()
440
+ end,
441
+ onTheme = function(id)
442
+ plugin:SetSetting(SETTING_THEME, id)
443
+ Console.log("dim", string.format("theme: %s", id))
444
+ end,
445
+ onSubmit = function(line)
446
+ Commands.run(line)
447
+ end,
448
+ onComplete = function(prefix)
449
+ return Commands.complete(prefix)
450
+ end,
451
+ onSuggest = function(prefix)
452
+ return Commands.suggest(prefix)
453
+ end,
454
+ })
455
+
456
+ --[[
457
+ What the command line cannot reach on its own.
458
+
459
+ `plugin:SetSetting` is unavailable inside a ModuleScript, and the transport's
460
+ lifecycle lives here rather than in the console, so the handful of commands
461
+ that need either are handed a function instead of a dependency.
462
+ ]]
463
+ Commands.setup({
464
+ reconnect = function()
465
+ Console.log("info", "reconnect requested")
466
+ Transport.stop()
467
+ task.wait(0.2)
468
+ connect()
469
+ end,
470
+ savePort = function(value)
471
+ plugin:SetSetting(SETTING_PORT, value)
472
+ end,
473
+ saveTheme = function(id)
474
+ plugin:SetSetting(SETTING_THEME, id)
475
+ end,
476
+ autoOpen = function()
477
+ return autoOpen
478
+ end,
479
+ saveAutoOpen = function(value)
480
+ -- The live copy moves too, so `autoopen` with no argument reports what
481
+ -- was just set rather than what the session started with.
482
+ autoOpen = value
483
+ plugin:SetSetting(SETTING_AUTO_OPEN, value)
484
+ end,
485
+ status = function()
486
+ return currentStatus
487
+ end,
488
+ studioId = studioId,
489
+ })
490
+
491
+ -- The saved preset, now that there is something to paint. Done immediately
492
+ -- after mounting and before the first line is logged, so nothing is ever drawn
493
+ -- in the wrong palette.
494
+ if themeNeedsApplying then
495
+ Console.applyTheme()
496
+ end
497
+
498
+ --[[
499
+ Keeps the prompt row showing what Studio has selected.
500
+
501
+ `Selection.SelectionChanged` is the event the panel was missing. Everything
502
+ about the selection was previously available only on demand, through
503
+ `studio_status`, which answers an agent's question but not the user's: they
504
+ are the one typing "make this bigger", and the word is only safe to type if
505
+ they can see what it means without leaving the panel.
506
+
507
+ Debounced through a generation counter rather than a timer handle, the same
508
+ way `recordCall` schedules its summary. Drag-selecting a group in the
509
+ viewport fires this once per instance added -- dozens of times in a second
510
+ -- and re-rendering a label on every one of them is work nobody sees.
511
+ ]]
512
+ local selectionGeneration = 0
513
+
514
+ local function describeSelection(): string
515
+ local picked = Selection:Get()
516
+ if #picked == 0 then
517
+ return ""
518
+ end
519
+ if #picked == 1 then
520
+ -- The name alone. The class is in the Properties panel and the path is
521
+ -- in the Explorer; what this line is for is confirming WHICH thing.
522
+ return string.format("\u{25A3} %s", picked[1].Name)
523
+ end
524
+ return string.format("\u{25A3} %d selected", #picked)
525
+ end
526
+
527
+ local function watchSelection()
528
+ Selection.SelectionChanged:Connect(function()
529
+ selectionGeneration += 1
530
+ local mine = selectionGeneration
531
+ task.delay(0.12, function()
532
+ if selectionGeneration ~= mine then
533
+ return
534
+ end
535
+ -- Guarded: an instance can be destroyed between the event and this
536
+ -- running, and reading `.Name` on it throws.
537
+ local ok, text = pcall(describeSelection)
538
+ Console.setSelection(if ok then text else "")
539
+ end)
540
+ end)
541
+ Console.setSelection(describeSelection())
542
+ end
543
+
544
+ -- Only in the editor. A playtest session has its own Selection service that
545
+ -- nobody is clicking in, and the client view cannot reach the panel at all.
546
+ if RunService:IsEdit() then
547
+ watchSelection()
548
+ end
549
+
550
+ --[[
551
+ The log, picked up where the last copy of this plugin left it.
552
+
553
+ Restored before the banner below rather than after it, so the carried rows
554
+ read as what they are -- what was on screen a moment ago -- with this
555
+ session's first line underneath them instead of buried in the middle.
556
+
557
+ Every session reads; only the editor writes. See `History` for why.
558
+ ]]
559
+ History.attach(plugin, Console.snapshot)
560
+ local carried = History.restore()
561
+ if #carried > 0 then
562
+ Console.restore(carried)
563
+ Console.log(
564
+ "dim",
565
+ string.format("carried %d line%s over", #carried, if #carried == 1 then "" else "s"),
566
+ if RunService:IsEdit() then "from the last session" else "from the editor"
567
+ )
568
+ end
569
+
570
+ if RunService:IsEdit() then
571
+ History.start()
572
+ plugin.Unloading:Connect(function()
573
+ History.stop()
574
+ -- The loop cannot save what happens after it has stopped, and closing
575
+ -- Studio is exactly when the last few rows matter most.
576
+ History.flush()
577
+ end)
578
+ end
579
+
580
+ --[[
581
+ The playtest halves, joined.
582
+
583
+ The server half can reach the bridge and sees every command; the client half
584
+ is the one Studio actually shows during a playtest and can reach nothing. So
585
+ the server relays its console events and the client replays them, which is
586
+ the only way the panel in front of the user reacts to the work being done.
587
+
588
+ Note which side sets the observer: only the SERVER. The client replays
589
+ events through the same `Console` functions, and if it were also observing
590
+ it would echo each one straight back into the channel.
591
+ ]]
592
+ if RunService:IsEdit() then
593
+ -- The only observer the edit session needs: every logged row marks the
594
+ -- stored copy stale, and the save loop above decides when to write it.
595
+ Console.setObserver(function()
596
+ History.touch()
597
+ end)
598
+ elseif Mirror.isPlaytestServer() then
599
+ Mirror.startServer()
600
+ Console.setObserver(function(kind, arguments)
601
+ Mirror.send(kind, arguments)
602
+ end)
603
+ -- The channel itself stays shut until `onStatus` reports the connection;
604
+ -- see `Mirror.open`.
605
+ elseif Mirror.isPlaytestClient() then
606
+ Console.setMirroring(true)
607
+ Mirror.startClient(function(kind, arguments)
608
+ if kind == "log" then
609
+ local level, message, detail = arguments[1], arguments[2], arguments[3]
610
+ if typeof(level) == "string" and typeof(message) == "string" then
611
+ Console.log(
612
+ level :: any,
613
+ message,
614
+ if typeof(detail) == "string" then detail else nil
615
+ )
616
+ end
617
+ elseif kind == "beginCall" then
618
+ local title, callKind = arguments[1], arguments[2]
619
+ if typeof(title) == "string" and typeof(callKind) == "string" then
620
+ Console.beginCall(title, callKind)
621
+ end
622
+ elseif kind == "recordCall" then
623
+ local ok, milliseconds = arguments[1], arguments[2]
624
+ if typeof(ok) == "boolean" and typeof(milliseconds) == "number" then
625
+ Console.recordCall(ok, milliseconds)
626
+ end
627
+ end
628
+ end)
629
+ end
630
+
631
+ Console.log("info", string.format("rbx-studio v%s", Config.PLUGIN_VERSION), "build " .. Config.BUILD_ID)
632
+ Console.log("dim", string.format("place: %s (%d)", game.Name, game.PlaceId))
633
+
634
+ local function onStatus(status: Transport.Status, detail: string?)
635
+ local previous = currentStatus
636
+ currentStatus = status
637
+ refreshMeta()
638
+
639
+ -- Only narrate transitions. The transport re-reports its state on every
640
+ -- reconnect attempt, and echoing an unchanged status would bury real events.
641
+ if status == previous and detail == nil then
642
+ return
643
+ end
644
+
645
+ if status == "connected" then
646
+ Console.log(
647
+ "ok",
648
+ string.format("connected to 127.0.0.1:%d", Config.getPort()),
649
+ if detail then "(" .. detail .. ")" else nil
650
+ )
651
+ -- After the row, not before it: this session's own arrival is not news
652
+ -- to the client view, which announced its own a moment ago.
653
+ Mirror.open()
654
+ elseif status == "connecting" then
655
+ Console.log("dim", string.format("connecting to 127.0.0.1:%d...", Config.getPort()))
656
+ else
657
+ Console.log("error", "disconnected", detail)
658
+ end
659
+ end
660
+
661
+ --[[
662
+ Runs each command on its own task. Handlers may yield -- `UpdateSourceAsync`
663
+ and any `*Async` call does -- and serialising them would let one slow edit
664
+ stall every other request on the stream.
665
+ ]]
666
+ local function onCommand(id: string, op: string, params: { [string]: any }?)
667
+ task.spawn(function()
668
+ local startedAt = os.clock()
669
+ --[[
670
+ Named for what it does, not for how it travels. `script.edit` on
671
+ ServerScriptService.Systems.KillBrick reads as "Edit KillBrick",
672
+ which is the thing someone watching actually wants to know; the wire
673
+ name is kept alongside so the log still maps onto the protocol when
674
+ something needs debugging.
675
+ ]]
676
+ local title = Phrase.of(op, params)
677
+ --[[
678
+ Announced synchronously, unlike the logging below.
679
+
680
+ Deferring this looked like free latency and was not. `beginCall` sets
681
+ two labels and some fields -- it never touches the RichText log, which
682
+ is where the cost actually is -- and deferring it let a call that
683
+ finished inside one frame record its result before the call had been
684
+ announced, so the bar on the trace lost the name it was supposed to
685
+ carry. A microsecond is not worth an ordering hazard.
686
+ ]]
687
+ Console.beginCall(title, Phrase.kindOf(op))
688
+
689
+ local result = Dispatch.invoke(id, op, params)
690
+ local milliseconds = (os.clock() - startedAt) * 1000
691
+
692
+ --[[
693
+ The answer goes out before the console hears about it.
694
+
695
+ This used to be the last line of the function, which put a
696
+ `table.concat` of three hundred strings, a RichText relayout of the
697
+ whole log, two `Instance.new` calls and a forty-bar relayout in front
698
+ of the reply on its way back to the agent. None of that is work the
699
+ caller asked for, and all of it was being billed to the round trip
700
+ this project measures. Drawing happens below, on time the agent is no
701
+ longer waiting for.
702
+ ]]
703
+ Transport.sendResult(result)
704
+
705
+ local elapsed = Console.durationText(milliseconds)
706
+ Console.recordCall(result.ok, milliseconds)
707
+
708
+ if result.ok then
709
+ Console.log("reply", title, elapsed)
710
+ else
711
+ local err = result.error
712
+ Console.log(
713
+ "error",
714
+ string.format("%s failed: %s", title, if err then err.code else "unknown"),
715
+ elapsed
716
+ )
717
+ if err and err.message then
718
+ Console.log("dim", " " .. err.message)
719
+ end
720
+ end
721
+ end)
722
+ end
723
+
724
+ --[[
725
+ Where a peer's call ran, in the width the detail column has.
726
+
727
+ The latency already lives there and only about fourteen characters fit
728
+ beside a message, so this is two letters and a space rather than "playtest
729
+ server". Which half of a playtest it was does not matter to someone reading
730
+ the editor's log afterwards; that it was not the editor does.
731
+ ]]
732
+ local function peerTag(from: any): string
733
+ if typeof(from) ~= "string" then
734
+ return "peer"
735
+ end
736
+ return if from == "edit" then "edit" else "play"
737
+ end
738
+
739
+ --[[
740
+ Bridge news that is not a command.
741
+
742
+ Kept deliberately narrow: an unknown event is ignored rather than logged,
743
+ because a newer server talking to an older plugin is a supported situation
744
+ and "unknown event" rows would be the only symptom of it working correctly.
745
+ ]]
746
+ local function onEvent(event: { [string]: any })
747
+ if event.event == "clients" and typeof(event.count) == "number" then
748
+ Console.setClients(event.count, if typeof(event.list) == "table" then event.list else nil)
749
+ elseif event.event == "agent" and event.state == "finished" then
750
+ Console.agentFinished()
751
+ elseif event.event == "console" and typeof(event.message) == "string" then
752
+ --[[
753
+ A line from an agent the panel itself started.
754
+
755
+ Pushed rather than returned because a run lasts minutes: the request
756
+ that started it answered immediately with "started", and everything
757
+ after that has to arrive on the stream the plugin already holds open.
758
+ ]]
759
+ Console.log(
760
+ (if typeof(event.level) == "string" then event.level else "dim") :: any,
761
+ event.message,
762
+ if typeof(event.detail) == "string" then event.detail else nil
763
+ )
764
+ elseif event.event == "agent-run" then
765
+ Console.setPromptBusy(event.state == "running")
766
+ elseif event.event == "peer" and typeof(event.op) == "string" then
767
+ --[[
768
+ A command another session on this place just finished.
769
+
770
+ Logged as if it had run here, because as far as the user is concerned
771
+ it did: they pressed Play, watched the agent work, pressed Stop, and
772
+ the panel that comes back is this one. Without this it comes back with
773
+ a hole in it exactly the length of the playtest.
774
+
775
+ The prism is bumped too -- `beginCall` then `recordCall`, back to
776
+ back -- so the trace carries a bar for the call and the session
777
+ counters count it. Nothing here reaches the transport, so a peer row
778
+ can never be announced onwards and two sessions cannot echo forever.
779
+ ]]
780
+ local params = if typeof(event.params) == "table" then event.params else nil
781
+ local title = Phrase.of(event.op, params)
782
+ local milliseconds = if typeof(event.ms) == "number" then event.ms else 0
783
+ local ok = event.ok == true
784
+ local detail = string.format("%s %.0fms", peerTag(event.from), milliseconds)
785
+
786
+ Console.beginCall(title, Phrase.kindOf(event.op))
787
+ Console.recordCall(ok, milliseconds)
788
+ if ok then
789
+ Console.log("reply", title, detail)
790
+ else
791
+ Console.log("error", string.format("%s failed", title), detail)
792
+ end
793
+ end
794
+ end
795
+
796
+ function connect()
797
+ local allowed, reason = canConnect()
798
+ if not allowed then
799
+ -- Reported as standby rather than an error: nothing failed, and this
800
+ -- session was never going to connect.
801
+ currentStatus = "disconnected"
802
+ Console.log("dim", "mirroring", reason)
803
+ Console.setStatus(
804
+ "mirroring",
805
+ string.format("%s build %s", "client view", Config.BUILD_ID)
806
+ )
807
+ Console.setCaption("mirroring the playtest server")
808
+ return
809
+ end
810
+ Transport.start(studioId(), { onCommand = onCommand, onStatus = onStatus, onEvent = onEvent })
811
+ plugin:SetSetting(SETTING_AUTOCONNECT, true)
812
+ end
813
+
814
+ button.Click:Connect(function()
815
+ -- Flagged around the toggle so the Enabled handler knows this close is the
816
+ -- user's, and is safe to remember. See closingByHand.
817
+ closingByHand = widget.Enabled
818
+ widget.Enabled = not widget.Enabled
819
+ closingByHand = false
820
+ end)
821
+
822
+ plugin.Unloading:Connect(function()
823
+ Transport.stop()
824
+ end)
825
+
826
+ --[[
827
+ Switches this session between the push and long-poll transports.
828
+
829
+ Registered here rather than in a handler module because it is the only
830
+ command that has to reach back into the plugin object and the connection
831
+ loop, both of which live in this file -- and registered THIS far down the
832
+ file on purpose: `connect` is a forward-declared local, so a closure written
833
+ above its declaration captures the global of that name instead, which is nil.
834
+ That cost a session. The plugin loaded and connected perfectly, and then died
835
+ the first time somebody asked it to switch transport.
836
+
837
+ The reply is sent before the reconnect, and the reconnect is deferred:
838
+ tearing the stream down inside the handler would strand the answer to the
839
+ very call that asked for the switch, which is a confusing way to succeed.
840
+ ]]
841
+ Dispatch.registerAll("studio", {
842
+ transport = function(params: { [string]: any }): { [string]: any }
843
+ local requested = params.mode
844
+ if requested ~= nil and requested ~= "sse" and requested ~= "poll" then
845
+ Dispatch.fail("BAD_PARAMS", 'transport mode must be "sse" or "poll".')
846
+ end
847
+ if requested == nil then
848
+ return { mode = Transport.getMode(), forcePoll = Transport.getForcePoll(), changed = false }
849
+ end
850
+
851
+ local wantPoll = requested == "poll"
852
+ if Transport.getMode() == requested and Transport.getForcePoll() == wantPoll then
853
+ return { mode = Transport.getMode(), forcePoll = wantPoll, changed = false }
854
+ end
855
+
856
+ Transport.setForcePoll(wantPoll)
857
+ plugin:SetSetting(SETTING_FORCE_POLL, wantPoll)
858
+ task.defer(function()
859
+ Transport.stop()
860
+ task.wait(0.1)
861
+ connect()
862
+ end)
863
+ return {
864
+ mode = requested,
865
+ forcePoll = wantPoll,
866
+ changed = true,
867
+ note = "Reconnecting on the new transport; the next call will use it.",
868
+ }
869
+ end,
870
+ })
871
+
872
+ refreshMeta()
873
+
874
+ -- Connect on load unless the user explicitly disconnected last session.
875
+ if plugin:GetSetting(SETTING_AUTOCONNECT) ~= false then
876
+ connect()
877
+ else
878
+ Console.log("warn", "auto-connect disabled — press reconnect to start")
879
+ end