@el4cteo/rbx-studio-mcp 0.1.5 → 0.2.0

package/plugin/src/handlers/Debug.luau

@@ -84,6 +84,35 @@ local overflow = 0
 local installed = false
 local installError: string? = nil
 
+--[[
+	Which lines currently carry a breakpoint, per script.
+
+	`ScriptDebuggerService` exposes no way to list what is set -- `AddBreakpoint`
+	and `RemoveBreakpoint` are the whole surface, one line at a time -- so
+	"clear every breakpoint in this script" needs its own record of what this
+	module put there, or it cannot be done at all without either the caller
+	naming every line back or this file falling back to `ClearBreakpoints()`,
+	which takes the whole session's breakpoints with it, including ones set by
+	someone else sharing this Studio.
+]]
+local trackedBreakpoints: { [Instance]: { [number]: boolean } } = {}
+
+local function track(target: Instance, line: number)
+	local lines = trackedBreakpoints[target]
+	if lines == nil then
+		lines = {}
+		trackedBreakpoints[target] = lines
+	end
+	lines[line] = true
+end
+
+local function untrack(target: Instance, line: number)
+	local lines = trackedBreakpoints[target]
+	if lines then
+		lines[line] = nil
+	end
+end
+
 --[[
 	Flattens whatever the service hands back.
 
@@ -309,6 +338,7 @@ function Debug.set(params: { [string]: any }): { [string]: any }
 		end)
 
 		if ok then
+			track(target, descriptor.Line)
 			table.insert(added, {
 				path = Paths.of(target),
 				line = descriptor.Line,
@@ -362,13 +392,39 @@ function Debug.clear(params: { [string]: any }): { [string]: any }
 	if typeof(path) == "string" and path ~= "" then
 		local target = Paths.resolve(path)
 		local line = tonumber(params.line)
-		if line == nil then
-			Dispatch.fail("BAD_PARAMS", "removing one breakpoint needs a `line`.")
+
+		if line ~= nil then
+			local ok, removed = pcall(function()
+				return service:RemoveBreakpoint(target, line)
+			end)
+			untrack(target, line)
+			return { removed = ok and removed == true, path = Paths.of(target), line = line }
 		end
-		local ok, removed = pcall(function()
-			return service:RemoveBreakpoint(target, line)
-		end)
-		return { removed = ok and removed == true, path = Paths.of(target), line = line }
+
+		--[[
+			`path` alone, no `line`: every breakpoint this module put in that
+			script. `ScriptDebuggerService` has no "list breakpoints in this
+			script" of its own -- only `AddBreakpoint`/`RemoveBreakpoint`, one
+			line at a time -- so `trackedBreakpoints` is what makes this
+			possible at all, and it is also the reason it can only remove what
+			this session set: a breakpoint another client or the user placed
+			by hand was never tracked here, and this cannot see it to touch it.
+		]]
+		local lines = trackedBreakpoints[target]
+		local removedLines: { number } = {}
+		if lines then
+			for lineNumber in lines do
+				local ok = pcall(function()
+					service:RemoveBreakpoint(target, lineNumber)
+				end)
+				if ok then
+					table.insert(removedLines, lineNumber)
+				end
+			end
+			trackedBreakpoints[target] = nil
+		end
+		table.sort(removedLines)
+		return { removed = #removedLines > 0, path = Paths.of(target), lines = removedLines }
 	end
 
 	local ok, err = pcall(function()
@@ -377,6 +433,7 @@ function Debug.clear(params: { [string]: any }): { [string]: any }
 	if not ok then
 		Dispatch.fail("REFUSED", string.format("ClearBreakpoints refused: %s", tostring(err)))
 	end
+	table.clear(trackedBreakpoints)
 	return { cleared = true }
 end
 

package/plugin/src/handlers/Geometry.luau

@@ -138,7 +138,6 @@ function Geometry.combine(params: { [string]: any }): { [string]: any }
 				then (if #produced == 1 then params.name else string.format("%s%d", params.name, index))
 				else subject.Name
 			part.Parent = parent
-			table.insert(created, Paths.of(part))
 		end
 
 		-- Removing the inputs is opt-in, and only once the results exist: an
@@ -150,6 +149,26 @@ function Geometry.combine(params: { [string]: any }): { [string]: any }
 				part:Destroy()
 			end
 		end
+
+		--[[
+			Paths for the produced parts are read only now, after the originals
+			are gone rather than in the loop above that named and parented them.
+
+			A result keeps the subject's name by default, so for the entire
+			window before the destroy above runs, the new part and the subject
+			it was built from are two same-named siblings in the same parent --
+			and Paths.of correctly, but uselessly, disambiguates that with a
+			`[2]` suffix that stops being true the instant the destroy runs a
+			few lines later. The caller reads this path after the call returns,
+			by which point the disambiguation was already wrong. Reading it here
+			instead describes where the part actually is once nothing further
+			in this function is going to move or remove anything -- correct
+			whether or not `keepOriginals` left a real, permanent collision for
+			it to still be disambiguating.
+		]]
+		for _, part in produced do
+			table.insert(created, Paths.of(part))
+		end
 	end)
 
 	return { created = created, removed = removed, undoable = undoable }

package/plugin/src/handlers/World.luau

@@ -147,6 +147,25 @@ function World.collision(params: { [string]: any }): { [string]: any }
 		return { group = name, assigned = #assigned, parts = assigned, undoable = undoable }
 	end
 
+	if action == "remove" then
+		--[[
+			Registering a group is one line and nothing here undid it: create,
+			assign and collidable all had a way back through the ordinary undo
+			stack, and this did not, because nothing called it at all. Over a
+			session that experiments -- try a group, decide against it -- that
+			leaves the place permanently carrying a group nobody wants, with no
+			way to remove it short of `execute_luau`. `UnregisterCollisionGroup`
+			has existed the whole time; it was just never wired up.
+		]]
+		local ok, err = pcall(function()
+			PhysicsService:UnregisterCollisionGroup(name)
+		end)
+		if not ok then
+			Dispatch.fail("COLLISION_FAILED", string.format("Could not remove %q: %s", name, tostring(err)))
+		end
+		return { group = name, removed = true }
+	end
+
 	if action == "collidable" then
 		local other = params.with
 		if typeof(other) ~= "string" or other == "" then

package/scripts/test-bridge.mjs

@@ -20,6 +20,7 @@ const identity = (studioId, placeId) => ({
   placeId,
   pluginVersion: "test",
   buildId: "test",
+  protocolVersion: 1,
   transport: "poll",
   context: "edit",
 });