@eip-1193/jsonrpc-provider 0.5.0 → 0.6.0

package/dist/index.cjs

@@ -70,7 +70,7 @@ function ethereum_request(endpoint, req) {
       }
       let hasError = false;
       for (const response3 of jsonArray) {
-        if (response3.error || !response3.result) {
+        if (response3.error || !("result" in response3)) {
           hasError = true;
         }
       }
@@ -106,8 +106,11 @@ function ethereum_request(endpoint, req) {
     } catch (parsingError) {
       throw new JSONRPCError("Failed To parse response json", parsingError);
     }
-    if (json.error || !json.result) {
-      throw json.error || { code: 5e3, message: "No Result" };
+    if (json.error) {
+      throw json.error;
+    }
+    if (!("result" in json)) {
+      throw { code: 5e3, message: "No Result" };
     }
     return json.result;
   });

package/dist/index.mjs

@@ -68,7 +68,7 @@ function ethereum_request(endpoint, req) {
       }
       let hasError = false;
       for (const response3 of jsonArray) {
-        if (response3.error || !response3.result) {
+        if (response3.error || !("result" in response3)) {
           hasError = true;
         }
       }
@@ -104,8 +104,11 @@ function ethereum_request(endpoint, req) {
     } catch (parsingError) {
       throw new JSONRPCError("Failed To parse response json", parsingError);
     }
-    if (json.error || !json.result) {
-      throw json.error || { code: 5e3, message: "No Result" };
+    if (json.error) {
+      throw json.error;
+    }
+    if (!("result" in json)) {
+      throw { code: 5e3, message: "No Result" };
     }
     return json.result;
   });

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@eip-1193/jsonrpc-provider",
-  "version": "0.5.0",
+  "version": "0.6.0",
   "keywords": [
     "eip-1193",
     "ethereum",
@@ -59,7 +59,8 @@
     "build": "pkgroll",
     "dev": "pkgroll --watch",
     "format:check": "prettier --check .",
+    "test": "pnpm build && node --test test/*.test.mjs",
     "format": "prettier --write .",
-    "release:ci": "pnpm format:check && pnpm build && pnpm changeset publish"
+    "release:ci": "pnpm format:check && pnpm test && pnpm changeset publish"
   }
 }

package/src/JSONRPCHTTPProvider.ts

@@ -59,7 +59,9 @@ export async function ethereum_request<U extends any, T>(
 
 		let hasError = false;
 		for (const response of jsonArray) {
-			if (response.error || !response.result) {
+			// `null`, `false` and `0` are valid results (a pending receipt, `eth_syncing`,
+			//  `hardhat_impersonateAccount`): only an error, or a missing `result` member, is a failure.
+			if (response.error || !('result' in response)) {
 				hasError = true;
 			}
 		}
@@ -99,10 +101,17 @@ export async function ethereum_request<U extends any, T>(
 		throw new JSONRPCError('Failed To parse response json', parsingError);
 	}
 
-	if (json.error || !json.result) {
-		throw json.error || {code: 5000, message: 'No Result'};
+	if (json.error) {
+		throw json.error;
 	}
-	return json.result;
+	// A JSON-RPC response carries EITHER `error` OR `result`, and `result` may legitimately be
+	//  `null` or `false` (a pending `eth_getTransactionReceipt`, `eth_syncing`, and
+	//  `hardhat_impersonateAccount`, which anvil and hardhat answer with `null`). Only a response
+	//  with neither member is malformed.
+	if (!('result' in json)) {
+		throw {code: 5000, message: 'No Result'};
+	}
+	return json.result as T;
 }
 
 export class JSONRPCHTTPProvider implements EIP1193HttpNodeProvider {