@eik/core 2.1.75 → 2.1.77

package/CHANGELOG.md

@@ -1,3 +1,17 @@
+## [2.1.77](https://github.com/eik-lib/core/compare/v2.1.76...v2.1.77) (2026-08-17)
+
+
+### Bug Fixes
+
+* propagate sink errors in versions.get as 502 rather than 404 ([#636](https://github.com/eik-lib/core/issues/636)) ([21b8619](https://github.com/eik-lib/core/commit/21b8619eeff9150914adcfa2ae6a233e2c10ec60))
+
+## [2.1.76](https://github.com/eik-lib/core/compare/v2.1.75...v2.1.76) (2026-08-14)
+
+
+### Bug Fixes
+
+* propagate sink errors in _readVersions rather than silently resetting version history ([#635](https://github.com/eik-lib/core/issues/635)) ([b248bb7](https://github.com/eik-lib/core/commit/b248bb7b644ccd8fb7116157c44917b1ccf7990e))
+
 ## [2.1.75](https://github.com/eik-lib/core/compare/v2.1.74...v2.1.75) (2026-08-14)
 
 

package/lib/handlers/map.put.js

@@ -172,25 +172,32 @@ const MapPut = class MapPut {
 
 	/**
 	 * @param {any} incoming
+	 * @returns {Promise<InstanceType<typeof Versions>>}
 	 */
 	async _readVersions(incoming) {
 		const path = createFilePathToVersion(incoming);
-		let versions;
+
+		if (!this._sink) throw new Error("No sink configured");
+
 		try {
-			const obj = await readJSON(this._sink, path);
-			versions = new Versions(obj);
-			this._log.info(
-				`map:put - Successfully read version meta file from sink - Pathname: ${path}`,
-			);
-			// eslint-disable-next-line no-unused-vars
-		} catch (error) {
-			// File does not exist, its probably a new package
-			versions = new Versions(incoming);
+			await this._sink.exist(path);
+		} catch {
+			// File does not exist — this is a new import map.
 			this._log.info(
 				`map:put - Version meta file did not exist in sink - Create new - Pathname: ${path}`,
 			);
+			return new Versions(incoming);
 		}
-		return versions;
+
+		// File exists. Any failure here must propagate rather than be
+		// swallowed — silently falling back to an empty Versions object
+		// would cause _writeVersions to overwrite the index and erase the
+		// entire version history.
+		const obj = await readJSON(this._sink, path);
+		this._log.info(
+			`map:put - Successfully read version meta file from sink - Pathname: ${path}`,
+		);
+		return new Versions(obj);
 	}
 
 	/**
@@ -251,7 +258,11 @@ const MapPut = class MapPut {
 			org,
 		});
 
-		const versions = await this._readVersions(incoming);
+		const versions = await this._readVersions(incoming).catch(() => {
+			const e = new HttpError.BadGateway();
+			end({ labels: { success: false, status: e.status, type: "map" } });
+			throw e;
+		});
 
 		if (!versions.check(pVersion)) {
 			this._log.info(

package/lib/handlers/pkg.put.js

@@ -138,25 +138,32 @@ const PkgPut = class PkgPut {
 
 	/**
 	 * @param {any} incoming
+	 * @returns {Promise<InstanceType<typeof Versions>>}
 	 */
 	async _readVersions(incoming) {
 		const path = createFilePathToVersion(incoming);
-		let versions;
+
+		if (!this._sink) throw new Error("No sink configured");
+
 		try {
-			const obj = await readJSON(this._sink, path);
-			versions = new Versions(obj);
-			this._log.info(
-				`pkg:put - Successfully read version meta file from sink - Pathname: ${path}`,
-			);
-			// eslint-disable-next-line no-unused-vars
-		} catch (error) {
-			// File does not exist, its probably a new package
-			versions = new Versions(incoming);
+			await this._sink.exist(path);
+		} catch {
+			// File does not exist — this is a new package.
 			this._log.info(
 				`pkg:put - Version meta file did not exist in sink - Create new - Pathname: ${path}`,
 			);
+			return new Versions(incoming);
 		}
-		return versions;
+
+		// File exists. Any failure here (GCS error, corrupt JSON, network
+		// timeout) must propagate rather than be swallowed — silently falling
+		// back to an empty Versions object would cause _writeVersions to
+		// overwrite the index and erase the entire version history.
+		const obj = await readJSON(this._sink, path);
+		this._log.info(
+			`pkg:put - Successfully read version meta file from sink - Pathname: ${path}`,
+		);
+		return new Versions(obj);
 	}
 
 	/**
@@ -251,7 +258,12 @@ const PkgPut = class PkgPut {
 			throw e;
 		}
 
-		const versions = await this._readVersions(incoming);
+		const versions = await this._readVersions(incoming).catch(() => {
+			const e = new HttpError.BadGateway();
+			end({ labels: { success: false, status: e.status, type } });
+			throw e;
+		});
+
 		const { pkg, eikJson } = await this._parser(incoming);
 		versions.setVersion(pVersion, pkg.integrity);
 

package/lib/handlers/versions.get.js

@@ -81,57 +81,83 @@ const VersionsGet = class VersionsGet {
 		}
 		const path = createFilePathToVersion({ org, type, name: pName });
 
-		try {
-			const file = await (this._sink && this._sink.read(path));
-			const outgoing = new HttpOutgoing();
-			outgoing.cacheControl = this._cacheControl;
-			outgoing.mimeType = "application/json";
-
-			if (this._etag) {
-				outgoing.etag = file.etag;
-			}
-
-			if (this._etag && req.headers["if-none-match"] === file.etag) {
-				outgoing.statusCode = 304;
-				file.stream.destroy();
-			} else {
-				outgoing.statusCode = 200;
-				outgoing.stream = file.stream;
-
-				const outgoingStream = outgoing.stream;
-				if (outgoingStream) {
-					outgoingStream.on(
-						"error",
-						(/** @type {NodeJS.ErrnoException} */ err) => {
-							// ERR_STREAM_PREMATURE_CLOSE means the client closed the
-							// connection before the transfer finished. This is normal
-							// browser behaviour (navigation, cancelled requests, etc.)
-							// and not a server-side error worth alerting on.
-							if (err.code === "ERR_STREAM_PREMATURE_CLOSE") {
-								this._log.debug(`pkg:latest - File stream error - ${err}`);
-							} else {
-								this._log.info(`pkg:latest - File stream error - ${err}`);
-							}
-							end({ labels: { success: false, status: 503, type } });
-						},
-					);
-
-					outgoingStream.on("end", () => {
-						end({ labels: { status: outgoing.statusCode, type } });
-					});
-				}
-			}
+		if (!this._sink) {
+			const e = new HttpError.NotFound();
+			end({ labels: { success: false, status: e.status, type } });
+			throw e;
+		}
 
-			this._log.debug(`pkg:latest - Package log found - Pathname: ${path}`);
+		// Check existence first to distinguish a genuinely missing package
+		// from a transient infrastructure error. Without this distinction,
+		// any GCS or network failure would surface as 404, which callers
+		// may misinterpret as "package does not exist".
+		try {
+			await this._sink.exist(path);
+		} catch {
+			this._log.debug(
+				`pkg:latest - Package versions not found - Pathname: ${path}`,
+			);
+			const e = new HttpError.NotFound();
+			end({ labels: { success: false, status: e.status, type } });
+			throw e;
+		}
 
-			return outgoing;
-			// eslint-disable-next-line no-unused-vars
+		// File exists — any read failure here is an infrastructure error.
+		let file;
+		try {
+			file = await this._sink.read(path);
 		} catch (error) {
-			this._log.debug(`pkg:latest - Package log found - Pathname: ${path}`);
-			const e = new HttpError.NotFound();
+			this._log.error(
+				`pkg:latest - Failed to read package versions from sink - Pathname: ${path}`,
+			);
+			this._log.trace(error);
+			const e = new HttpError.BadGateway();
 			end({ labels: { success: false, status: e.status, type } });
 			throw e;
 		}
+
+		const outgoing = new HttpOutgoing();
+		outgoing.cacheControl = this._cacheControl;
+		outgoing.mimeType = "application/json";
+
+		if (this._etag) {
+			outgoing.etag = file.etag;
+		}
+
+		if (this._etag && req.headers["if-none-match"] === file.etag) {
+			outgoing.statusCode = 304;
+			file.stream.destroy();
+		} else {
+			outgoing.statusCode = 200;
+			outgoing.stream = file.stream;
+
+			const outgoingStream = outgoing.stream;
+			if (outgoingStream) {
+				outgoingStream.on(
+					"error",
+					(/** @type {NodeJS.ErrnoException} */ err) => {
+						// ERR_STREAM_PREMATURE_CLOSE means the client closed the
+						// connection before the transfer finished. This is normal
+						// browser behaviour (navigation, cancelled requests, etc.)
+						// and not a server-side error worth alerting on.
+						if (err.code === "ERR_STREAM_PREMATURE_CLOSE") {
+							this._log.debug(`pkg:latest - File stream error - ${err}`);
+						} else {
+							this._log.info(`pkg:latest - File stream error - ${err}`);
+						}
+						end({ labels: { success: false, status: 503, type } });
+					},
+				);
+
+				outgoingStream.on("end", () => {
+					end({ labels: { status: outgoing.statusCode, type } });
+				});
+			}
+		}
+
+		this._log.debug(`pkg:latest - Package versions found - Pathname: ${path}`);
+
+		return outgoing;
 	}
 };
 export default VersionsGet;

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@eik/core",
-  "version": "2.1.75",
+  "version": "2.1.77",
   "description": "Core server package",
   "main": "lib/main.js",
   "types": "./types/main.d.ts",

package/types/handlers/map.put.d.ts

@@ -42,27 +42,9 @@ declare const MapPut: {
         }): Promise<string>;
         /**
          * @param {any} incoming
+         * @returns {Promise<InstanceType<typeof Versions>>}
          */
-        _readVersions(incoming: any): Promise<{
-            _versions: Map<any, any>;
-            _type: string;
-            _name: string;
-            _org: string;
-            get versions(): [any, any][];
-            get type(): string;
-            get name(): string;
-            get org(): string;
-            setVersion(version: string, integrity: string): void;
-            getVersion(major: number): any;
-            check(version: string): boolean;
-            toJSON(): {
-                versions: [any, any][];
-                type: string;
-                name: string;
-                org: string;
-            };
-            get [Symbol.toStringTag](): string;
-        }>;
+        _readVersions(incoming: any): Promise<InstanceType<typeof Versions>>;
         /**
          * @param {any} incoming
          * @param {any} versions
@@ -102,3 +84,4 @@ declare const MapPut: {
 };
 import abslog from "abslog";
 import Metrics from "@metrics/client";
+import Versions from "../classes/versions.js";

package/types/handlers/pkg.put.d.ts

@@ -78,27 +78,9 @@ declare const PkgPut: {
         _writeEikJson(incoming: any, capturedEikJson: Record<string, any> | null): Promise<void>;
         /**
          * @param {any} incoming
+         * @returns {Promise<InstanceType<typeof Versions>>}
          */
-        _readVersions(incoming: any): Promise<{
-            _versions: Map<any, any>;
-            _type: string;
-            _name: string;
-            _org: string;
-            get versions(): [any, any][];
-            get type(): string;
-            get name(): string;
-            get org(): string;
-            setVersion(version: string, integrity: string): void;
-            getVersion(major: number): any;
-            check(version: string): boolean;
-            toJSON(): {
-                versions: [any, any][];
-                type: string;
-                name: string;
-                org: string;
-            };
-            get [Symbol.toStringTag](): string;
-        }>;
+        _readVersions(incoming: any): Promise<InstanceType<typeof Versions>>;
         /**
          * @param {any} incoming
          */
@@ -143,3 +125,4 @@ declare const PkgPut: {
 };
 import abslog from "abslog";
 import Metrics from "@metrics/client";
+import Versions from "../classes/versions.js";