@eik/common 4.1.0 → 4.1.1

package/CHANGELOG.md

@@ -1,3 +1,10 @@
+## [4.1.1](https://github.com/eik-lib/common/compare/v4.1.0...v4.1.1) (2024-08-16)
+
+
+### Bug Fixes
+
+* windows support ([#303](https://github.com/eik-lib/common/issues/303)) ([4e6a307](https://github.com/eik-lib/common/commit/4e6a3078861a0a03b7275bfb5b2875adda1f2c2e))
+
 # [4.1.0](https://github.com/eik-lib/common/compare/v4.0.9...v4.1.0) (2024-08-14)
 
 

package/lib/classes/eik-config.js

@@ -8,7 +8,7 @@ import SingleDestMultipleSourcesError from './single-dest-multiple-source-error.
 import FileMapping from './file-mapping.js';
 import RemoteFileLocation from './remote-file-location.js';
 import schemas from '../schemas/index.js';
-import { removeTrailingSlash } from '../helpers/path-slashes.js';
+import { removeTrailingSlash, ensurePosix } from '../helpers/path-slashes.js';
 import typeSlug from '../helpers/type-slug.js';
 import resolveFiles from '../helpers/resolve-files.js';
 
@@ -152,13 +152,11 @@ export default class EikConfig {
                 const shouldMapFilename = extname(destination);
                 const relativePathname = shouldMapFilename
                     ? destination
-                    : join(destination, localFile.relative);
-                const packagePathname = join(
-                    // @ts-ignore
-                    typeSlug(this.type),
-                    this.name,
-                    this.version,
+                    : ensurePosix(join(destination, localFile.relative));
+                const packagePathname = ensurePosix(
+                    join(typeSlug(this.type), this.name, this.version),
                 );
+
                 const remoteDestination = new RemoteFileLocation(
                     relativePathname,
                     packagePathname,

package/lib/classes/local-file-location.js

@@ -5,6 +5,7 @@ import assert from 'node:assert';
 import { join, extname, isAbsolute } from 'node:path';
 // @ts-ignore
 import mime from 'mime-types';
+import { ensurePosix } from '../helpers/path-slashes.js';
 
 /**
  * Class containing information about a local file
@@ -20,7 +21,10 @@ class LocalFileLocation {
             typeof basePath === 'string',
             '"basePath" must be of type "string"',
         );
-        assert(!isAbsolute(path), '"path" must be a relative path');
+        assert(
+            !isAbsolute(path),
+            `"path" must be a relative path, got ${path}`,
+        );
 
         /**
          * @type {string} path to file on disk relative to this.basePath
@@ -36,7 +40,7 @@ class LocalFileLocation {
          * @type {string} absolute path to file on disk,
          * this is a concatentation of this.basePath and this.relative
          */
-        this.absolute = join(basePath, path);
+        this.absolute = ensurePosix(join(basePath, path));
 
         /**
          * @type {string} file extension with "." character included. (eg. ".json")

package/lib/classes/resolved-files.js

@@ -46,7 +46,9 @@ class ResolvedFiles {
     *[Symbol.iterator]() {
         for (const file of this[originalFiles]) {
             const relative = removeTrailingSlash(
-                removeLeadingSlash(file.replace(this.basePath, '')),
+                removeLeadingSlash(
+                    file.replace(/\\/g, '/').replace(this.basePath, ''),
+                ),
             );
             yield new LocalFileLocation(relative, this.basePath);
         }

package/lib/helpers/path-slashes.js

@@ -1,3 +1,6 @@
+import { sep } from 'path';
+import { platform } from 'os';
+
 /**
  * Add a trailing slash to a path if necessary
  *
@@ -5,7 +8,7 @@
  *
  * @returns {string}
  */
-const addTrailingSlash = (val) => (val.endsWith('/') ? val : `${val}/`);
+export const addTrailingSlash = (val) => (val.endsWith('/') ? val : `${val}/`);
 
 /**
  * Remove a trailing slash from a path if necessary
@@ -14,17 +17,21 @@ const addTrailingSlash = (val) => (val.endsWith('/') ? val : `${val}/`);
  *
  * @returns {string}
  */
-const removeTrailingSlash = (val) =>
-    val.endsWith('/') ? val.substr(0, val.length - 1) : val;
+export const removeTrailingSlash = (val) =>
+    // this is also used to trim from config files, which may now always use the OS's sep value. Look for both.
+    val.endsWith('/') || val.endsWith('\\')
+        ? val.substr(0, val.length - 1)
+        : val;
 
 /**
- * Add a leading slash to a path if necessary
+ * Add a leading slash to a path if necessary, but not on Windows
  *
  * @param {string} val
  *
  * @returns {string}
  */
-const addLeadingSlash = (val) => (val.startsWith('/') ? val : `/${val}`);
+export const addLeadingSlash = (val) =>
+    val.startsWith('/') || platform() === 'win32' ? val : `/${val}`;
 
 /**
  * Remove a leading slash from a path if necessary
@@ -33,11 +40,19 @@ const addLeadingSlash = (val) => (val.startsWith('/') ? val : `/${val}`);
  *
  * @returns {string}
  */
-const removeLeadingSlash = (val) => (val.startsWith('/') ? val.substr(1) : val);
+export const removeLeadingSlash = (val) =>
+    val.startsWith('/') || val.startsWith('\\') ? val.substr(1) : val;
+
+/**
+ * Replaces a path string's separators (/ or \) with the current OS's sep value from node:path.
+ * @param {string} val
+ * @returns {string}
+ */
+export const ensureOsSep = (val) => val.replace(/\/\\/g, sep);
 
-export {
-    addTrailingSlash,
-    removeTrailingSlash,
-    addLeadingSlash,
-    removeLeadingSlash,
-};
+/**
+ * Replaces any backslash with a forward slash.
+ * @param {string} val
+ * @returns {string}
+ */
+export const ensurePosix = (val) => val.replace(/\\/g, '/');

package/lib/helpers/resolve-files.js

@@ -5,6 +5,8 @@ import {
     removeTrailingSlash,
     addLeadingSlash,
     removeLeadingSlash,
+    ensureOsSep,
+    ensurePosix,
 } from './path-slashes.js';
 import ResolvedFiles from '../classes/resolved-files.js';
 
@@ -23,6 +25,7 @@ const pathUntilGlob = (path) => {
         if (isGlob(segment)) break;
         segmentsToKeep.push(segment);
     }
+
     return addLeadingSlash(normalize(segmentsToKeep.join(sep)));
 };
 
@@ -37,13 +40,24 @@ const pathUntilGlob = (path) => {
 const resolveFiles = async (files, cwd) =>
     Promise.all(
         Object.entries(files).map(async (definition) => {
-            const [, source] = definition;
+            let [, source] = definition;
+
+            // The config may not always match the OS's separator.
+            // Convert the input to OS-specific if necessary.
+            // We convert back to always using forward slashes for glob,
+            // but for calculating the paths relative to cwd we'd like
+            // these to be OS-specific for now.
+            source = ensureOsSep(source);
+
             // normalise to absolute path
             let pattern = isAbsolute(source) ? source : join(cwd, source);
 
             // append glob if folder
-            if (extname(pattern) === '' && isGlob(pattern) === false) {
-                pattern = join(pattern, '/**/*');
+            if (
+                extname(pattern) === '' &&
+                isGlob(ensurePosix(pattern)) === false
+            ) {
+                pattern = `${pattern}${sep}**${sep}*`;
             }
 
             // trim off any glob
@@ -56,6 +70,11 @@ const resolveFiles = async (files, cwd) =>
                 );
             }
 
+            // convert glob pattern to forward slash separators
+            // https://www.npmjs.com/package/glob#windows
+            basePath = ensurePosix(basePath);
+            pattern = ensurePosix(pattern);
+
             // process glob pattern into a list of existing files
             const resolvedFiles = await glob(pattern, {
                 cwd: basePath,

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@eik/common",
-  "version": "4.1.0",
+  "version": "4.1.1",
   "description": "Common utilities for Eik modules",
   "main": "lib/index.js",
   "types": "types/index.d.ts",

package/types/helpers/path-slashes.d.ts

@@ -1,32 +1,6 @@
-/**
- * Add a trailing slash to a path if necessary
- *
- * @param {string} val
- *
- * @returns {string}
- */
 export function addTrailingSlash(val: string): string;
-/**
- * Remove a trailing slash from a path if necessary
- *
- * @param {string} val
- *
- * @returns {string}
- */
 export function removeTrailingSlash(val: string): string;
-/**
- * Add a leading slash to a path if necessary
- *
- * @param {string} val
- *
- * @returns {string}
- */
 export function addLeadingSlash(val: string): string;
-/**
- * Remove a leading slash from a path if necessary
- *
- * @param {string} val
- *
- * @returns {string}
- */
 export function removeLeadingSlash(val: string): string;
+export function ensureOsSep(val: string): string;
+export function ensurePosix(val: string): string;