@egy186/eslint-config 0.64.0 → 0.68.0

package/base.js

@@ -8,34 +8,31 @@ module.exports = {
   reportUnusedDisableDirectives: true,
   rules: {
     ...{
-      // Possible Errors
+      // Possible Problems
+      'array-callback-return': ['error', { checkForEach: true }],
+      'constructor-super': 'error',
       'for-direction': 'error',
       'getter-return': 'error',
       'no-async-promise-executor': 'error',
       'no-await-in-loop': 'error',
+      'no-class-assign': 'error',
       'no-compare-neg-zero': 'error',
       'no-cond-assign': ['error', 'always'],
-      'no-console': 'warn',
+      'no-const-assign': 'error',
       'no-constant-condition': 'error',
+      'no-constructor-return': 'error',
       'no-control-regex': 'error',
       'no-debugger': 'error',
       'no-dupe-args': 'error',
+      'no-dupe-class-members': 'error',
       'no-dupe-else-if': 'error',
       'no-dupe-keys': 'error',
       'no-duplicate-case': 'error',
-      'no-empty': 'error',
+      'no-duplicate-imports': 'error',
       'no-empty-character-class': 'error',
+      'no-empty-pattern': 'error',
       'no-ex-assign': 'error',
-      'no-extra-boolean-cast': 'error',
-      'no-extra-parens': [
-        'error',
-        'all',
-        {
-          ignoreJSX: 'multi-line',
-          nestedBinaryExpressions: false
-        }
-      ],
-      'no-extra-semi': 'error',
+      'no-fallthrough': 'error',
       'no-func-assign': 'error',
       'no-import-assign': 'error',
       'no-inner-declarations': 'error',
@@ -43,135 +40,193 @@ module.exports = {
       'no-irregular-whitespace': 'error',
       'no-loss-of-precision': 'error',
       'no-misleading-character-class': 'error',
+      'no-new-symbol': 'error',
       'no-obj-calls': 'error',
       'no-promise-executor-return': 'error',
       'no-prototype-builtins': 'error',
-      'no-regex-spaces': 'error',
+      'no-self-assign': 'error',
+      'no-self-compare': 'error',
       'no-setter-return': 'error',
       'no-sparse-arrays': 'error',
       'no-template-curly-in-string': 'error',
+      'no-this-before-super': 'error',
+      'no-undef': 'error',
       'no-unexpected-multiline': 'error',
+      'no-unmodified-loop-condition': 'error',
       'no-unreachable': 'error',
       'no-unreachable-loop': 'error',
       'no-unsafe-finally': 'error',
       'no-unsafe-negation': 'error',
       'no-unsafe-optional-chaining': ['error', { disallowArithmeticOperators: true }],
       'no-unused-private-class-members': 'error',
+      'no-unused-vars': [
+        'error',
+        {
+          args: 'after-used',
+          caughtErrors: 'all',
+          vars: 'all'
+        }
+      ],
+      'no-use-before-define': 'error',
       'no-useless-backreference': 'error',
       'require-atomic-updates': 'error',
       'use-isnan': 'error',
       'valid-typeof': 'error'
     },
     ...{
-      // Best Practices
+      // Suggestions
       'accessor-pairs': 'error',
-      'array-callback-return': ['error', { checkForEach: true }],
+      'arrow-body-style': ['error', 'as-needed'],
       'block-scoped-var': 'error',
+      camelcase: ['error', { properties: 'never' }],
+      'capitalized-comments': 'error',
       'class-methods-use-this': 'error',
       complexity: ['warn', 12],
       'consistent-return': 'error',
+      'consistent-this': 'error',
       curly: ['error', 'all'],
       'default-case': 'error',
       'default-case-last': 'error',
       'default-param-last': 'error',
-      'dot-location': ['error', 'property'],
       'dot-notation': 'error',
       eqeqeq: 'error',
+      'func-name-matching': 'error',
+      'func-names': ['error', 'as-needed'],
+      'func-style': ['error', 'expression'],
       'grouped-accessor-pairs': ['error', 'getBeforeSet'],
       'guard-for-in': 'error',
+      'id-denylist': 'off',
+      'id-length': 'off',
+      'id-match': 'off',
+      'init-declarations': 'error',
       'max-classes-per-file': 'error',
+      'max-depth': 'error',
+      'max-lines': 'warn',
+      'max-lines-per-function': 'warn',
+      'max-nested-callbacks': 'error',
+      'max-params': 'off',
+      'max-statements': 'warn',
+      'multiline-comment-style': 'error',
+      'new-cap': 'error',
       'no-alert': 'error',
+      'no-array-constructor': 'error',
+      'no-bitwise': 'off',
       'no-caller': 'error',
       'no-case-declarations': 'error',
-      'no-constructor-return': 'error',
+      'no-confusing-arrow': ['error', { allowParens: false }],
+      'no-console': 'warn',
+      'no-continue': 'off',
+      'no-delete-var': 'error',
       'no-div-regex': 'error',
       'no-else-return': 'error',
+      'no-empty': 'error',
       'no-empty-function': 'error',
-      'no-empty-pattern': 'error',
       'no-eq-null': 'error',
       'no-eval': 'error',
       'no-extend-native': 'error',
       'no-extra-bind': 'error',
+      'no-extra-boolean-cast': 'error',
       'no-extra-label': 'off',
-      'no-fallthrough': 'error',
+      'no-extra-semi': 'error',
       'no-floating-decimal': 'error',
       'no-global-assign': 'error',
       'no-implicit-coercion': 'error',
       'no-implicit-globals': 'error',
       'no-implied-eval': 'error',
+      'no-inline-comments': 'off',
       'no-invalid-this': 'error',
       'no-iterator': 'error',
+      'no-label-var': 'off',
       'no-labels': 'error',
       'no-lone-blocks': 'error',
+      'no-lonely-if': 'error',
       'no-loop-func': 'error',
       'no-magic-numbers': 'off',
-      'no-multi-spaces': 'error',
+      'no-mixed-operators': 'error',
+      'no-multi-assign': 'error',
       'no-multi-str': 'error',
+      'no-negated-condition': 'error',
+      'no-nested-ternary': 'error',
       'no-new': 'error',
       'no-new-func': 'error',
+      'no-new-object': 'error',
       'no-new-wrappers': 'error',
       'no-nonoctal-decimal-escape': 'error',
       'no-octal': 'error',
       'no-octal-escape': 'error',
       'no-param-reassign': ['error', { props: false }],
+      'no-plusplus': 'off',
       'no-proto': 'error',
       'no-redeclare': 'error',
+      'no-regex-spaces': 'error',
+      'no-restricted-exports': 'off',
+      'no-restricted-globals': 'off',
+      'no-restricted-imports': 'off',
       'no-restricted-properties': 'off',
+      'no-restricted-syntax': 'off',
       'no-return-assign': 'error',
       'no-return-await': 'error',
       'no-script-url': 'error',
-      'no-self-assign': 'error',
-      'no-self-compare': 'error',
       'no-sequences': 'error',
+      'no-shadow': 'error',
+      'no-shadow-restricted-names': 'error',
+      'no-ternary': 'off',
       'no-throw-literal': 'error',
-      'no-unmodified-loop-condition': 'error',
+      'no-undef-init': 'error',
+      'no-undefined': 'off',
+      'no-underscore-dangle': ['error', { allowAfterThis: true }],
+      'no-unneeded-ternary': ['error', { defaultAssignment: false }],
       'no-unused-expressions': ['error', { enforceForJSX: true }],
       'no-unused-labels': 'off',
       'no-useless-call': 'error',
       'no-useless-catch': 'error',
+      'no-useless-computed-key': 'error',
       'no-useless-concat': 'error',
+      'no-useless-constructor': 'error',
       'no-useless-escape': 'error',
+      'no-useless-rename': 'error',
       'no-useless-return': 'error',
+      'no-var': 'error',
       'no-void': 'error',
       'no-warning-comments': 'error',
       'no-with': 'error',
+      'object-shorthand': ['error', 'always'],
+      'one-var': ['error', 'never'],
+      'one-var-declaration-per-line': 'off',
+      'operator-assignment': 'off',
+      'prefer-arrow-callback': 'error',
+      'prefer-const': 'error',
+      'prefer-destructuring': 'error',
+      'prefer-exponentiation-operator': 'error',
       'prefer-named-capture-group': 'error',
+      'prefer-numeric-literals': 'error',
+      'prefer-object-has-own': 'error',
+      'prefer-object-spread': 'error',
       'prefer-promise-reject-errors': 'error',
       'prefer-regex-literals': 'error',
+      'prefer-rest-params': 'error',
+      'prefer-spread': 'error',
+      'prefer-template': 'error',
+      'quote-props': ['error', 'as-needed'],
       radix: 'error',
       'require-await': 'error',
       'require-unicode-regexp': 'error',
-      'vars-on-top': 'error',
-      'wrap-iife': ['error', 'inside'],
-      yoda: 'error'
-    },
-    ...{
-      // Strict Mode
-      strict: ['error', 'safe']
-    },
-    ...{
-      // Variables
-      'init-declarations': 'error',
-      'no-delete-var': 'error',
-      'no-label-var': 'off',
-      'no-restricted-globals': 'off',
-      'no-shadow': 'error',
-      'no-shadow-restricted-names': 'error',
-      'no-undef': 'error',
-      'no-undef-init': 'error',
-      'no-undefined': 'off',
-      'no-unused-vars': [
+      'require-yield': 'error',
+      'sort-imports': 'error',
+      'sort-keys': 'error',
+      'sort-vars': 'error',
+      'spaced-comment': [
         'error',
-        {
-          args: 'after-used',
-          caughtErrors: 'all',
-          vars: 'all'
-        }
+        'always',
+        { block: { balanced: true } }
       ],
-      'no-use-before-define': 'error'
+      strict: ['error', 'safe'],
+      'symbol-description': 'error',
+      'vars-on-top': 'error',
+      yoda: 'error'
     },
     ...{
-      // Stylistic Issues
+      // Layout & Formatting
       'array-bracket-newline': 'error',
       'array-bracket-spacing': ['error', 'never'],
       'array-element-newline': [
@@ -181,14 +236,20 @@ module.exports = {
           multiline: true
         }
       ],
+      'arrow-parens': ['error', 'as-needed'],
+      'arrow-spacing': [
+        'error',
+        {
+          after: true,
+          before: true
+        }
+      ],
       'block-spacing': ['error', 'always'],
       'brace-style': [
         'error',
         '1tbs',
         { allowSingleLine: false }
       ],
-      camelcase: ['error', { properties: 'never' }],
-      'capitalized-comments': 'error',
       'comma-dangle': ['error', 'never'],
       'comma-spacing': [
         'error',
@@ -199,17 +260,12 @@ module.exports = {
       ],
       'comma-style': ['error', 'last'],
       'computed-property-spacing': ['error', 'never'],
-      'consistent-this': 'off',
+      'dot-location': ['error', 'property'],
       'eol-last': 'error',
       'func-call-spacing': ['error', 'never'],
-      'func-name-matching': 'error',
-      'func-names': ['error', 'as-needed'],
-      'func-style': ['error', 'expression'],
       'function-call-argument-newline': ['error', 'consistent'],
       'function-paren-newline': ['error', 'multiline'],
-      'id-denylist': 'off',
-      'id-length': 'off',
-      'id-match': 'off',
+      'generator-star-spacing': ['error', 'after'],
       'implicit-arrow-linebreak': ['error', 'beside'],
       indent: [
         'error',
@@ -238,27 +294,21 @@ module.exports = {
       'linebreak-style': 'error',
       'lines-around-comment': 'off',
       'lines-between-class-members': 'error',
-      'max-depth': 'error',
       'max-len': 'off',
-      'max-lines': 'warn',
-      'max-lines-per-function': 'warn',
-      'max-nested-callbacks': 'error',
-      'max-params': 'off',
-      'max-statements': 'warn',
       'max-statements-per-line': 'error',
-      'multiline-comment-style': 'error',
       'multiline-ternary': ['error', 'always-multiline'],
-      'new-cap': 'error',
       'new-parens': 'error',
       'newline-per-chained-call': 'off',
-      'no-array-constructor': 'error',
-      'no-bitwise': 'off',
-      'no-continue': 'off',
-      'no-inline-comments': 'off',
-      'no-lonely-if': 'error',
-      'no-mixed-operators': 'error',
+      'no-extra-parens': [
+        'error',
+        'all',
+        {
+          ignoreJSX: 'multi-line',
+          nestedBinaryExpressions: false
+        }
+      ],
       'no-mixed-spaces-and-tabs': 'error',
-      'no-multi-assign': 'error',
+      'no-multi-spaces': 'error',
       'no-multiple-empty-lines': [
         'error',
         {
@@ -267,35 +317,22 @@ module.exports = {
           maxEOF: 1
         }
       ],
-      'no-negated-condition': 'error',
-      'no-nested-ternary': 'error',
-      'no-new-object': 'error',
-      'no-plusplus': 'off',
-      'no-restricted-syntax': 'off',
       'no-tabs': 'off',
-      'no-ternary': 'off',
       'no-trailing-spaces': 'error',
-      'no-underscore-dangle': ['error', { allowAfterThis: true }],
-      'no-unneeded-ternary': ['error', { defaultAssignment: false }],
       'no-whitespace-before-property': 'error',
       'nonblock-statement-body-position': 'error',
       'object-curly-newline': ['error', { multiline: true }],
       'object-curly-spacing': ['error', 'always'],
       'object-property-newline': 'error',
-      'one-var': ['error', 'never'],
-      'one-var-declaration-per-line': 'off',
-      'operator-assignment': 'off',
       'operator-linebreak': ['error', 'before'],
       'padded-blocks': ['error', 'never'],
       'padding-line-between-statements': 'error',
-      'prefer-exponentiation-operator': 'error',
-      'prefer-object-spread': 'error',
-      'quote-props': ['error', 'as-needed'],
       quotes: [
         'error',
         'single',
         'avoid-escape'
       ],
+      'rest-spread-spacing': ['error', 'never'],
       semi: ['error', 'always'],
       'semi-spacing': [
         'error',
@@ -305,62 +342,17 @@ module.exports = {
         }
       ],
       'semi-style': ['error', 'last'],
-      'sort-keys': 'error',
-      'sort-vars': 'error',
       'space-before-blocks': 'error',
       'space-before-function-paren': ['error', 'always'],
       'space-in-parens': ['error', 'never'],
       'space-infix-ops': 'error',
       'space-unary-ops': 'error',
-      'spaced-comment': [
-        'error',
-        'always',
-        { block: { balanced: true } }
-      ],
       'switch-colon-spacing': 'error',
+      'template-curly-spacing': ['error', 'never'],
       'template-tag-spacing': ['error', 'never'],
       'unicode-bom': ['error', 'never'],
-      'wrap-regex': 'off'
-    },
-    ...{
-      // ECMAScript 6
-      'arrow-body-style': ['error', 'as-needed'],
-      'arrow-parens': ['error', 'as-needed'],
-      'arrow-spacing': [
-        'error',
-        {
-          after: true,
-          before: true
-        }
-      ],
-      'constructor-super': 'error',
-      'generator-star-spacing': ['error', 'after'],
-      'no-class-assign': 'error',
-      'no-confusing-arrow': ['error', { allowParens: false }],
-      'no-const-assign': 'error',
-      'no-dupe-class-members': 'error',
-      'no-duplicate-imports': 'error',
-      'no-new-symbol': 'error',
-      'no-restricted-exports': 'off',
-      'no-restricted-imports': 'off',
-      'no-this-before-super': 'error',
-      'no-useless-computed-key': 'error',
-      'no-useless-constructor': 'error',
-      'no-useless-rename': 'error',
-      'no-var': 'error',
-      'object-shorthand': ['error', 'always'],
-      'prefer-arrow-callback': 'error',
-      'prefer-const': 'error',
-      'prefer-destructuring': 'error',
-      'prefer-numeric-literals': 'error',
-      'prefer-rest-params': 'error',
-      'prefer-spread': 'error',
-      'prefer-template': 'error',
-      'require-yield': 'error',
-      'rest-spread-spacing': ['error', 'never'],
-      'sort-imports': 'error',
-      'symbol-description': 'error',
-      'template-curly-spacing': ['error', 'never'],
+      'wrap-iife': ['error', 'inside'],
+      'wrap-regex': 'off',
       'yield-star-spacing': [
         'error',
         {

package/jest.js

@@ -0,0 +1,55 @@
+'use strict';
+
+module.exports = {
+  env: { jest: true },
+  plugins: ['jest'],
+  rules: {
+    'jest/consistent-test-it': 'error',
+    'jest/expect-expect': 'error',
+    'jest/max-nested-describe': 'error',
+    'jest/no-alias-methods': 'error',
+    'jest/no-commented-out-tests': 'error',
+    'jest/no-conditional-expect': 'error',
+    'jest/no-deprecated-functions': 'error',
+    'jest/no-disabled-tests': 'error',
+    'jest/no-done-callback': 'error',
+    'jest/no-duplicate-hooks': 'error',
+    'jest/no-export': 'error',
+    'jest/no-focused-tests': 'error',
+    'jest/no-hooks': 'off',
+    'jest/no-identical-title': 'error',
+    'jest/no-if': 'error',
+    'jest/no-interpolation-in-snapshots': 'error',
+    'jest/no-jasmine-globals': 'error',
+    'jest/no-jest-import': 'error',
+    'jest/no-large-snapshots': 'warn',
+    'jest/no-mocks-import': 'error',
+    'jest/no-restricted-matchers': 'off',
+    'jest/no-standalone-expect': 'error',
+    'jest/no-test-prefixes': 'error',
+    'jest/no-test-return-statement': 'error',
+    'jest/prefer-called-with': 'error',
+    'jest/prefer-comparison-matcher': 'error',
+    'jest/prefer-equality-matcher': 'error',
+    'jest/prefer-expect-assertions': ['warn', { onlyFunctionsWithAsyncKeyword: true }],
+    'jest/prefer-expect-resolves': 'error',
+    'jest/prefer-hooks-on-top': 'error',
+    'jest/prefer-lowercase-title': 'error',
+    'jest/prefer-spy-on': 'error',
+    'jest/prefer-strict-equal': 'error',
+    'jest/prefer-to-be': 'error',
+    'jest/prefer-to-contain': 'error',
+    'jest/prefer-to-have-length': 'error',
+    'jest/prefer-todo': 'error',
+    'jest/require-hook': 'error',
+    'jest/require-to-throw-message': 'error',
+    'jest/require-top-level-describe': 'error',
+    'jest/unbound-method': 'error',
+    'jest/valid-describe-callback': 'error',
+    'jest/valid-expect': 'error',
+    'jest/valid-expect-in-promise': 'error',
+    'jest/valid-title': 'error',
+    'max-lines-per-function': 'off',
+    'max-statements': 'off'
+  }
+};

package/package.json

@@ -1,7 +1,7 @@
 {
   "name": "@egy186/eslint-config",
   "description": "Eslint shareable config",
-  "version": "0.64.0",
+  "version": "0.68.0",
   "author": "egy186",
   "bugs": {
     "url": "https://github.com/egy186/eslint-config/issues"
@@ -10,17 +10,18 @@
     "lodash": "^4.17.21"
   },
   "devDependencies": {
-    "@typescript-eslint/eslint-plugin": "~5.3.1",
-    "@typescript-eslint/parser": "~5.3.1",
-    "eslint": "~8.2.0",
-    "eslint-plugin-import": "~2.25.3",
-    "eslint-plugin-jsdoc": "~37.0.3",
+    "@typescript-eslint/eslint-plugin": "~5.10.0",
+    "@typescript-eslint/parser": "~5.10.0",
+    "eslint": "~8.7.0",
+    "eslint-plugin-import": "~2.25.4",
+    "eslint-plugin-jest": "~26.0.0",
+    "eslint-plugin-jsdoc": "~37.6.1",
     "eslint-plugin-node": "~11.1.0",
-    "eslint-plugin-react": "~7.27.0",
+    "eslint-plugin-react": "~7.28.0",
     "eslint-plugin-react-hooks": "~4.3.0",
-    "husky": "^7.0.1",
+    "husky": "^7.0.4",
     "require-dir": "^1.2.0",
-    "typescript": "^4.4.4"
+    "typescript": "^4.5.4"
   },
   "engines": {
     "node": ">=12.22.0"
@@ -29,6 +30,7 @@
     "base.js",
     "browser.js",
     "index.js",
+    "jest.js",
     "jsdoc.js",
     "modules.js",
     "node.js",
@@ -45,8 +47,9 @@
   "peerDependencies": {
     "@typescript-eslint/eslint-plugin": "^5.3.1",
     "@typescript-eslint/parser": "^5.3.1",
-    "eslint": "^8.2.0",
+    "eslint": "^8.5.0",
     "eslint-plugin-import": "^2.25.3",
+    "eslint-plugin-jest": "^26.0.0",
     "eslint-plugin-jsdoc": "^37.0.3",
     "eslint-plugin-node": "^11.1.0",
     "eslint-plugin-react": "^7.27.0",