@egjs/react-flicking 4.10.1 → 4.10.2-beta.0

package/README.md

@@ -42,14 +42,15 @@ npm install --save @egjs/react-flicking
 import Flicking, { MoveEvent, WillChangeEvent } from "@egjs/react-flicking";
 
 <Flicking
-  viewportTag = "div"
-  cameraTag = "div"
-  cameraClass = ""
-  align = "center"
-  onMove = {(e: MoveEvent) => {}}
-  onWillChange = {(e: WillChangeEvent) => {}}
-  horizontal = {true}
-  circular = {true}
+  viewportTag="div"
+  cameraTag="div"
+  cameraClass=""
+  renderOnSameKey={false}
+  align="center"
+  onMove={(e: MoveEvent) => {}}
+  onWillChange={(e: WillChangeEvent) => {}}
+  horizontal={true}
+  circular={true}
 >
   <div>panel 0</div>
   <div>panel 1</div>
@@ -57,6 +58,14 @@ import Flicking, { MoveEvent, WillChangeEvent } from "@egjs/react-flicking";
 </Flicking>
 ```
 
+## ✨ React exclusive options
+- viewportTag: HTML tag for `.flicking-viewport` element. (default: **"div"**)
+- cameraTag: HTML tag for `.flicking-camera` element. (default: **"div"**)
+- cameraClass: `className` for `.flicking-camera` element. (default: **""**)
+- renderOnSameKey: Whether to always render children even they have the same keys (default: **false**)
+  - Flicking doesn't rerender when children have same length & keys for performance by default.
+  - If you have to bypass this behavior, like when you have to update panel's innerHTML without changing the list of child elements, you can either set this option to `true`, or you can call Flicking component's `forceUpdate()`.
+
 ## 📦 Packages
 You can use all plugins just like native @egjs/flicking.
 

package/declaration/Flicking.d.ts

@@ -1,41 +1,41 @@
-import * as React from "react";
-import Component from "@egjs/component";
-import VanillaFlicking, { FlickingOptions } from "@egjs/flicking";
-import { FlickingProps } from "./types";
-import StrictPanel from "./StrictPanel";
-import NonStrictPanel from "./NonStrictPanel";
-declare class Flicking extends React.Component<Partial<FlickingProps & FlickingOptions>> {
-    static defaultProps: FlickingProps;
-    private _vanillaFlicking;
-    private _panels;
-    private _pluginsDiffer;
-    private _jsxDiffer;
-    private _viewportElement;
-    private _diffResult;
-    private _renderEmitter;
-    private _prevProps;
-    get reactPanels(): (StrictPanel | NonStrictPanel | HTMLDivElement)[];
-    get renderEmitter(): Component<{
-        render: void;
-    }>;
-    constructor(props: Partial<FlickingProps & FlickingOptions>);
-    componentDidMount(): void;
-    componentWillUnmount(): void;
-    shouldComponentUpdate(nextProps: Readonly<Partial<FlickingProps & FlickingOptions>>): boolean;
-    beforeRender(): void;
-    componentDidUpdate(): void;
-    render(): JSX.Element;
-    private _createPanelRefs;
-    private _bindEvents;
-    private _checkPlugins;
-    private _hasSameChildren;
-    private _getChildren;
-    private _getViewportSlot;
-    private _unpackFragment;
-    private _getVirtualPanels;
-    private _getPanels;
-    private _isFragment;
-}
-interface Flicking extends React.Component<Partial<FlickingProps & FlickingOptions>>, VanillaFlicking {
-}
-export default Flicking;
+import * as React from "react";
+import Component from "@egjs/component";
+import VanillaFlicking, { FlickingOptions } from "@egjs/flicking";
+import { FlickingProps } from "./types";
+import StrictPanel from "./StrictPanel";
+import NonStrictPanel from "./NonStrictPanel";
+declare class Flicking extends React.Component<Partial<FlickingProps & FlickingOptions>> {
+    static defaultProps: FlickingProps;
+    private _vanillaFlicking;
+    private _panels;
+    private _pluginsDiffer;
+    private _jsxDiffer;
+    private _viewportElement;
+    private _diffResult;
+    private _renderEmitter;
+    private _prevChildren;
+    get reactPanels(): (StrictPanel | NonStrictPanel | HTMLDivElement)[];
+    get renderEmitter(): Component<{
+        render: void;
+    }>;
+    constructor(props: Partial<FlickingProps & FlickingOptions>);
+    componentDidMount(): void;
+    componentWillUnmount(): void;
+    shouldComponentUpdate(nextProps: Readonly<Partial<FlickingProps & FlickingOptions>>): boolean;
+    beforeRender(): void;
+    componentDidUpdate(): void;
+    render(): JSX.Element;
+    private _createPanelRefs;
+    private _bindEvents;
+    private _checkPlugins;
+    private _hasSameChildren;
+    private _getChildren;
+    private _getViewportSlot;
+    private _unpackFragment;
+    private _getVirtualPanels;
+    private _getPanels;
+    private _isFragment;
+}
+interface Flicking extends React.Component<Partial<FlickingProps & FlickingOptions>>, VanillaFlicking {
+}
+export default Flicking;

package/declaration/NonStrictPanel.d.ts

@@ -1,12 +1,12 @@
-import * as React from "react";
-declare class NonStrictPanel extends React.Component<{
-    children?: React.ReactElement;
-}> {
-    private _hide;
-    get nativeElement(): HTMLElement;
-    get rendered(): boolean;
-    render(): JSX.Element | undefined;
-    show(): void;
-    hide(): void;
-}
-export default NonStrictPanel;
+import * as React from "react";
+declare class NonStrictPanel extends React.Component<{
+    children?: React.ReactElement;
+}> {
+    private _hide;
+    get nativeElement(): HTMLElement;
+    get rendered(): boolean;
+    render(): JSX.Element | undefined;
+    show(): void;
+    hide(): void;
+}
+export default NonStrictPanel;

package/declaration/ReactElementProvider.d.ts

@@ -1,12 +1,12 @@
-import { ElementProvider } from "@egjs/flicking";
-import StrictPanel from "./StrictPanel";
-import NonStrictPanel from "./NonStrictPanel";
-declare class ReactElementProvider implements ElementProvider {
-    private _el;
-    get element(): HTMLElement;
-    get rendered(): boolean;
-    constructor(el: StrictPanel | NonStrictPanel);
-    show(): void;
-    hide(): void;
-}
-export default ReactElementProvider;
+import { ElementProvider } from "@egjs/flicking";
+import StrictPanel from "./StrictPanel";
+import NonStrictPanel from "./NonStrictPanel";
+declare class ReactElementProvider implements ElementProvider {
+    private _el;
+    get element(): HTMLElement;
+    get rendered(): boolean;
+    constructor(el: StrictPanel | NonStrictPanel);
+    show(): void;
+    hide(): void;
+}
+export default ReactElementProvider;

package/declaration/ReactRenderer.d.ts

@@ -1,16 +1,16 @@
-import { ExternalRenderer, PanelOptions, RendererOptions } from "@egjs/flicking";
-import ReactFlicking from "./Flicking";
-import StrictPanel from "./StrictPanel";
-import NonStrictPanel from "./NonStrictPanel";
-export interface ReactRendererOptions extends RendererOptions {
-    reactFlicking: ReactFlicking;
-}
-declare class ReactRenderer extends ExternalRenderer {
-    protected _reactFlicking: ReactFlicking;
-    constructor(options: ReactRendererOptions);
-    render(): Promise<void>;
-    forceRenderAllPanels(): Promise<void>;
-    protected _collectPanels(): void;
-    protected _createPanel(externalComponent: StrictPanel | NonStrictPanel | HTMLDivElement, options: PanelOptions): import("@egjs/flicking/declaration/core/panel/Panel").default;
-}
-export default ReactRenderer;
+import { ExternalRenderer, PanelOptions, RendererOptions } from "@egjs/flicking";
+import ReactFlicking from "./Flicking";
+import StrictPanel from "./StrictPanel";
+import NonStrictPanel from "./NonStrictPanel";
+export interface ReactRendererOptions extends RendererOptions {
+    reactFlicking: ReactFlicking;
+}
+declare class ReactRenderer extends ExternalRenderer {
+    protected _reactFlicking: ReactFlicking;
+    constructor(options: ReactRendererOptions);
+    render(): Promise<void>;
+    forceRenderAllPanels(): Promise<void>;
+    protected _collectPanels(): void;
+    protected _createPanel(externalComponent: StrictPanel | NonStrictPanel | HTMLDivElement, options: PanelOptions): import("@egjs/flicking/declaration/core/panel/Panel").default;
+}
+export default ReactRenderer;

package/declaration/StrictPanel.d.ts

@@ -1,14 +1,14 @@
-import * as React from "react";
-declare class StrictPanel extends React.Component<{
-    children?: React.ReactElement;
-}> {
-    private _hide;
-    private _elRef;
-    get nativeElement(): HTMLElement;
-    get rendered(): boolean;
-    render(): JSX.Element;
-    show(): void;
-    hide(): void;
-    private _getElement;
-}
-export default StrictPanel;
+import * as React from "react";
+declare class StrictPanel extends React.Component<{
+    children?: React.ReactElement;
+}> {
+    private _hide;
+    private _elRef;
+    get nativeElement(): HTMLElement;
+    get rendered(): boolean;
+    render(): JSX.Element;
+    show(): void;
+    hide(): void;
+    private _getElement;
+}
+export default StrictPanel;

package/declaration/ViewportSlot.d.ts

@@ -1,5 +1,5 @@
-import React, { ReactNode } from "react";
-declare const ViewportSlot: React.MemoExoticComponent<(props: {
-    children?: ReactNode;
-}) => JSX.Element>;
-export default ViewportSlot;
+import React, { ReactNode } from "react";
+declare const ViewportSlot: React.MemoExoticComponent<(props: {
+    children?: ReactNode;
+}) => JSX.Element>;
+export default ViewportSlot;

package/declaration/consts.d.ts

@@ -1,2 +1,2 @@
-import { FlickingProps } from "./types";
-export declare const DEFAULT_PROPS: FlickingProps;
+import { FlickingProps } from "./types";
+export declare const DEFAULT_PROPS: FlickingProps;

package/declaration/index.d.ts

@@ -1,6 +1,6 @@
-import Flicking from "./Flicking";
-import ViewportSlot from "./ViewportSlot";
-export * from "@egjs/flicking";
-export * from "./types";
-export { ViewportSlot };
-export default Flicking;
+import Flicking from "./Flicking";
+import ViewportSlot from "./ViewportSlot";
+export * from "@egjs/flicking";
+export * from "./types";
+export { ViewportSlot };
+export default Flicking;

package/declaration/index.umd.d.ts

@@ -1,2 +1,2 @@
-import Flicking from "./Flicking";
-export default Flicking;
+import Flicking from "./Flicking";
+export default Flicking;

package/declaration/types.d.ts

@@ -1,31 +1,32 @@
-/// <reference types="react" />
-import ReactFlicking from "./Flicking";
-import { SelectEvent, NeedPanelEvent, VisibleChangeEvent, HoldStartEvent, HoldEndEvent, MoveStartEvent, MoveEvent, MoveEndEvent, WillChangeEvent, ChangedEvent, WillRestoreEvent, RestoredEvent, ReadyEvent, BeforeResizeEvent, AfterResizeEvent, ReachEdgeEvent, PanelChangeEvent, Plugin, Status } from "@egjs/flicking";
-export interface FlickingProps {
-    viewportTag: keyof JSX.IntrinsicElements;
-    cameraTag: keyof JSX.IntrinsicElements;
-    cameraClass: string;
-    plugins: Plugin[];
-    status?: Status;
-    useFindDOMNode: boolean;
-    hideBeforeInit: boolean;
-    firstPanelSize?: string;
-    onReady: (e: ReadyEvent<ReactFlicking>) => any;
-    onBeforeResize: (e: BeforeResizeEvent<ReactFlicking>) => any;
-    onAfterResize: (e: AfterResizeEvent<ReactFlicking>) => any;
-    onHoldStart: (e: HoldStartEvent<ReactFlicking>) => any;
-    onHoldEnd: (e: HoldEndEvent<ReactFlicking>) => any;
-    onMoveStart: (e: MoveStartEvent<ReactFlicking>) => any;
-    onMove: (e: MoveEvent<ReactFlicking>) => any;
-    onMoveEnd: (e: MoveEndEvent<ReactFlicking>) => any;
-    onWillChange: (e: WillChangeEvent<ReactFlicking>) => any;
-    onChanged: (e: ChangedEvent<ReactFlicking>) => any;
-    onWillRestore: (e: WillRestoreEvent<ReactFlicking>) => any;
-    onRestored: (e: RestoredEvent<ReactFlicking>) => any;
-    onSelect: (e: SelectEvent<ReactFlicking>) => any;
-    onNeedPanel: (e: NeedPanelEvent<ReactFlicking>) => any;
-    onVisibleChange: (e: VisibleChangeEvent<ReactFlicking>) => any;
-    onReachEdge: (e: ReachEdgeEvent<ReactFlicking>) => any;
-    onPanelChange: (e: PanelChangeEvent<ReactFlicking>) => any;
-    [key: string]: any;
-}
+/// <reference types="react" />
+import ReactFlicking from "./Flicking";
+import { SelectEvent, NeedPanelEvent, VisibleChangeEvent, HoldStartEvent, HoldEndEvent, MoveStartEvent, MoveEvent, MoveEndEvent, WillChangeEvent, ChangedEvent, WillRestoreEvent, RestoredEvent, ReadyEvent, BeforeResizeEvent, AfterResizeEvent, ReachEdgeEvent, PanelChangeEvent, Plugin, Status } from "@egjs/flicking";
+export interface FlickingProps {
+    viewportTag: keyof JSX.IntrinsicElements;
+    cameraTag: keyof JSX.IntrinsicElements;
+    cameraClass: string;
+    renderOnSameKey: boolean;
+    plugins: Plugin[];
+    status?: Status;
+    useFindDOMNode: boolean;
+    hideBeforeInit: boolean;
+    firstPanelSize?: string;
+    onReady: (e: ReadyEvent<ReactFlicking>) => any;
+    onBeforeResize: (e: BeforeResizeEvent<ReactFlicking>) => any;
+    onAfterResize: (e: AfterResizeEvent<ReactFlicking>) => any;
+    onHoldStart: (e: HoldStartEvent<ReactFlicking>) => any;
+    onHoldEnd: (e: HoldEndEvent<ReactFlicking>) => any;
+    onMoveStart: (e: MoveStartEvent<ReactFlicking>) => any;
+    onMove: (e: MoveEvent<ReactFlicking>) => any;
+    onMoveEnd: (e: MoveEndEvent<ReactFlicking>) => any;
+    onWillChange: (e: WillChangeEvent<ReactFlicking>) => any;
+    onChanged: (e: ChangedEvent<ReactFlicking>) => any;
+    onWillRestore: (e: WillRestoreEvent<ReactFlicking>) => any;
+    onRestored: (e: RestoredEvent<ReactFlicking>) => any;
+    onSelect: (e: SelectEvent<ReactFlicking>) => any;
+    onNeedPanel: (e: NeedPanelEvent<ReactFlicking>) => any;
+    onVisibleChange: (e: VisibleChangeEvent<ReactFlicking>) => any;
+    onReachEdge: (e: ReachEdgeEvent<ReactFlicking>) => any;
+    onPanelChange: (e: PanelChangeEvent<ReactFlicking>) => any;
+    [key: string]: any;
+}

package/dist/flicking.cjs.js

@@ -235,6 +235,7 @@ var DEFAULT_PROPS = {
   viewportTag: "div",
   cameraTag: "div",
   cameraClass: "",
+  renderOnSameKey: false,
   plugins: [],
   useFindDOMNode: false,
   hideBeforeInit: false,
@@ -437,9 +438,9 @@ function (_super) {
   return NonStrictPanel;
 }(React.Component);
 
-/*
- * Copyright (c) 2015 NAVER Corp.
- * egjs projects are licensed under the MIT license
+/*
+ * Copyright (c) 2015 NAVER Corp.
+ * egjs projects are licensed under the MIT license
  */
 var ViewportSlot = React.memo(function (props) {
   return React.createElement(React.Fragment, null, props.children);
@@ -489,8 +490,11 @@ function (_super) {
 
     _this._panels = [];
     _this._renderEmitter = new Component();
-    _this._panels = _this._createPanelRefs(props, _this._getChildren());
-    _this._prevProps = _this.props;
+
+    var children = _this._getChildren();
+
+    _this._panels = _this._createPanelRefs(props, children);
+    _this._prevChildren = children;
     return _this;
   }
 
@@ -532,7 +536,7 @@ function (_super) {
       return panel.key;
     });
     this._pluginsDiffer = new ListDiffer();
-    this._prevProps = this.props;
+    this._prevChildren = children;
 
     this._bindEvents();
 
@@ -553,10 +557,9 @@ function (_super) {
     var vanillaFlicking = this._vanillaFlicking;
     var prevProps = this.props;
     if (!vanillaFlicking || !vanillaFlicking.initialized) return false;
-    if (!this._hasSameChildren(prevProps, nextProps)) return true;
 
-    nextProps.children;
-        var restProps = __rest(nextProps, ["children"]);
+    var children = nextProps.children,
+        restProps = __rest(nextProps, ["children"]);
 
     for (var key in restProps) {
       if (prevProps[key] !== nextProps[key]) {
@@ -564,21 +567,27 @@ function (_super) {
       }
     }
 
+    var prevChildren = this._prevChildren;
+
+    var nextChildren = this._getChildren(children);
+
+    if (nextProps.renderOnSameKey || !this._hasSameChildren(prevChildren, nextChildren)) return true;
     return false;
   };
 
   __proto.beforeRender = function () {
     var vanillaFlicking = this._vanillaFlicking;
-    var nextProps = this.props;
-    var prevProps = this._prevProps; // Ignore updates before init, they will be updated after "ready" event's force update
+    var props = this.props;
+    var prevChildren = this._prevChildren; // Ignore updates before init, they will be updated after "ready" event's force update
 
     if (!vanillaFlicking || !vanillaFlicking.initialized) return;
 
-    if (!this._hasSameChildren(prevProps, nextProps)) {
-      var nextChildren = this._getChildren(nextProps.children);
+    var nextChildren = this._getChildren(props.children);
 
-      this._panels = this._createPanelRefs(nextProps, nextChildren);
+    if (props.renderOnSameKey || !this._hasSameChildren(prevChildren, nextChildren)) {
+      this._panels = this._createPanelRefs(props, nextChildren);
       this._diffResult = this._jsxDiffer.update(nextChildren);
+      this._prevChildren = nextChildren;
     }
   };
 
@@ -641,7 +650,6 @@ function (_super) {
       }
     } : {};
     var panels = !!props.virtual && ((_b = props.panelsPerView) !== null && _b !== void 0 ? _b : -1) > 0 ? this._getVirtualPanels() : this._getPanels();
-    this._prevProps = props;
     return React.createElement(Viewport, __assign({}, attributes, {
       className: viewportClasses.join(" "),
       ref: function (e) {
@@ -708,14 +716,11 @@ function (_super) {
     }));
   };
 
-  __proto._hasSameChildren = function (prevProps, nextProps) {
-    var prevChildren = this._getChildren(prevProps.children);
-
-    var nextChildren = this._getChildren(nextProps.children);
-
-    if (prevChildren.length !== nextChildren.length) return false;
+  __proto._hasSameChildren = function (prevChildren, nextChildren) {
+    if (prevChildren.length !== nextChildren.length || prevChildren.length === 0) return false;
     var same = prevChildren.every(function (child, idx) {
       var nextChild = nextChildren[idx];
+      console.log(child, nextChild);
 
       if (child.key && nextChild.key) {
         return child.key === nextChild.key;
@@ -816,9 +821,9 @@ function (_super) {
   return Flicking;
 }(React.Component);
 
-/*
- * Copyright (c) 2015 NAVER Corp.
- * egjs projects are licensed under the MIT license
+/*
+ * Copyright (c) 2015 NAVER Corp.
+ * egjs projects are licensed under the MIT license
  */
 Flicking.ViewportSlot = ViewportSlot;