@effectionx/process 0.6.2 → 0.7.0

package/test/exec.test.ts

@@ -0,0 +1,481 @@
+import process from "node:process";
+import { beforeEach, describe, it } from "@effectionx/bdd";
+import { type Task, spawn } from "effection";
+import { expect } from "expect";
+
+import {
+  captureError,
+  expectMatch,
+  fetchText,
+  streamClose,
+} from "./helpers.ts";
+
+import { lines } from "@effectionx/stream-helpers";
+import { type Process, type ProcessResult, exec } from "../mod.ts";
+
+const SystemRoot = process.env.SystemRoot;
+
+// Validate SHELL environment variable is set for proper test execution
+if (process.platform === "win32" && !process.env.SHELL) {
+  throw new Error(
+    "SHELL environment variable is required for Windows tests.\n" +
+      "Please set SHELL using one of these commands:\n" +
+      "  PowerShell: $env:SHELL = 'powershell'\n" +
+      "  pwsh: $env:SHELL = 'pwsh'\n" +
+      "  CMD: set SHELL=cmd\n" +
+      "  Git Bash: export SHELL=bash",
+  );
+}
+
+const isBash = () => {
+  // On POSIX systems, SHELL is undefined so default to bash
+  if (process.platform !== "win32") return true;
+
+  // On Windows, SHELL is required and set, check it or fallback to process.env.shell
+  const shell = process.env.SHELL?.toLowerCase();
+  const processShell = process.env.shell;
+
+  return shell === "bash" || processShell?.endsWith("bash.exe");
+};
+
+describe("exec", () => {
+  describe(".join", () => {
+    it("runs successfully to completion", function* () {
+      let result: ProcessResult = yield* exec(
+        "node './fixtures/hello-world.js'",
+        {
+          cwd: import.meta.dirname,
+        },
+      ).join();
+
+      expect(result).toMatchObject({
+        code: 0,
+        stdout: "hello\nworld\n",
+        stderr: "boom\n",
+      });
+    });
+
+    it("runs failed process to completion", function* () {
+      let result: ProcessResult = yield* exec(
+        "node './fixtures/hello-world-failed.js'",
+        {
+          cwd: import.meta.dirname,
+        },
+      ).join();
+
+      expect(result.code).toEqual(37);
+      expect(result.stdout).toEqual("hello world\n");
+      expect(result.stderr).toEqual("boom\n");
+    });
+  });
+
+  describe(".expect", () => {
+    expect.assertions(1);
+    it("runs successfully to completion", function* () {
+      let result: ProcessResult = yield* exec(
+        "node './fixtures/hello-world.js'",
+        {
+          cwd: import.meta.dirname,
+        },
+      ).expect();
+
+      expect(result).toMatchObject({
+        code: 0,
+        stdout: "hello\nworld\n",
+        stderr: "boom\n",
+      });
+    });
+
+    it("throws an error if process fails", function* () {
+      let error: Error = yield* captureError(
+        exec("node './test/fixtures/hello-world-failed.js'").expect(),
+      );
+
+      expect(error.name).toEqual("ExecError");
+    });
+  });
+
+  describe("spawning", () => {
+    describe("a process that fails to start because executable is not found", () => {
+      it("calling join() throws an exception", function* () {
+        let error: unknown;
+        let proc = yield* exec("argle", { arguments: ["bargle"] });
+        try {
+          yield* proc.join();
+        } catch (e) {
+          error = e;
+        }
+        expect(error).toBeInstanceOf(Error);
+      });
+      it("calling expect() throws an exception", function* () {
+        let error: unknown;
+        let proc = yield* exec("argle", { arguments: ["bargle"] });
+        try {
+          yield* proc.expect();
+        } catch (e) {
+          error = e;
+        }
+
+        expect(error).toBeDefined();
+      });
+    });
+  });
+  describe("successfully", () => {
+    let proc: Process;
+    let joinStdout: Task<unknown>;
+    let joinStderr: Task<unknown>;
+
+    beforeEach(function* () {
+      proc = yield* exec(
+        "node --experimental-strip-types './fixtures/echo-server.ts'",
+        {
+          env: {
+            PORT: "29000",
+            PATH: process.env.PATH as string,
+            ...(SystemRoot ? { SystemRoot } : {}),
+          },
+          cwd: import.meta.dirname,
+        },
+      );
+
+      joinStdout = yield* spawn(streamClose(proc.stdout));
+      joinStderr = yield* spawn(streamClose(proc.stderr));
+
+      yield* expectMatch(/listening/, lines()(proc.stdout));
+    });
+
+    describe("when it succeeds", () => {
+      beforeEach(function* () {
+        yield* fetchText("http://localhost:29000", {
+          method: "POST",
+          body: "exit",
+        });
+      });
+
+      it("has a pid", function* () {
+        expect(typeof proc.pid).toBe("number");
+        expect(proc.pid).not.toBeNaN();
+        // make sure it completes
+        yield* proc.join();
+      });
+
+      it("joins successfully", function* () {
+        let status = yield* proc.join();
+        expect(status.code).toEqual(0);
+      });
+
+      it("expects successfully", function* () {
+        let status = yield* proc.expect();
+        expect(status.code).toEqual(0);
+      });
+
+      it("closes stdout and stderr", function* () {
+        expect.assertions(2);
+        yield* proc.expect();
+        expect(yield* joinStdout).toEqual(undefined);
+        expect(yield* joinStderr).toEqual(undefined);
+      });
+    });
+
+    describe("when it fails", () => {
+      let error: Error;
+      beforeEach(function* () {
+        yield* fetchText("http://localhost:29000", {
+          method: "POST",
+          body: "fail",
+        });
+      });
+
+      it("joins successfully", function* () {
+        let status = yield* proc.join();
+        expect(status.code).not.toEqual(0);
+      });
+
+      it("expects unsuccessfully", function* () {
+        try {
+          yield* proc.expect();
+        } catch (e) {
+          error = e as Error;
+        }
+        expect(error).toBeDefined();
+      });
+
+      it("closes stdout and stderr", function* () {
+        expect(yield* joinStdout).toEqual(undefined);
+        expect(yield* joinStderr).toEqual(undefined);
+      });
+    });
+  });
+});
+
+// running shell scripts in windows is not well supported, our windows
+// process stuff sets shell to `false` and so you probably shouldn't do this
+// in windows at all.
+if (process.platform !== "win32") {
+  describe("when the `shell` option is true", () => {
+    it("lets the shell do all of the shellword parsing", function* () {
+      let proc = exec('echo "first" | echo "second"', {
+        shell: true,
+      });
+      let { stdout }: ProcessResult = yield* proc.expect();
+
+      expect(stdout).toEqual("second\n");
+    });
+  });
+}
+
+describe("when the `shell` option is `false`", () => {
+  it("correctly receives literal arguments when shell: false", function* () {
+    // Arguments are passed literally as parsed by shellwords-ts
+    let proc = exec("node ./fixtures/dump-args.js first | echo second", {
+      shell: false,
+      cwd: import.meta.dirname,
+    });
+    let { stdout }: ProcessResult = yield* proc.expect();
+
+    // Node's console.log uses a single LF (\n) line ending.
+    const expected = `${JSON.stringify({
+      args: ["first", "|", "echo", "second"], // Arguments received by Node
+      envVar: undefined,
+    })}\n`;
+
+    expect(stdout).toEqual(expected);
+  });
+
+  it("verifies environment variable handling and literal argument passing", function* () {
+    // Execute the custom script with the literal argument
+    let proc = exec("node ./fixtures/dump-args.js $EFFECTION_TEST_ENV_VAL", {
+      shell: false, // Ensures the argument is passed literally
+      env: {
+        EFFECTION_TEST_ENV_VAL: "boop",
+        PATH: process.env.PATH as string,
+      },
+      cwd: import.meta.dirname,
+    });
+    let { stdout, code }: ProcessResult = yield* proc.expect();
+
+    // The argument is passed literally, and the env var is available in the child process's env.
+    const expected = `${JSON.stringify({
+      args: ["$EFFECTION_TEST_ENV_VAL"], // Argument is passed literally
+      envVar: "boop", // Env variable is read from process.env
+    })}\n`;
+
+    expect(stdout).toEqual(expected);
+    expect(code).toBe(0);
+  });
+});
+
+describe("handles env vars", () => {
+  describe("when the `shell` option is `bash`", () => {
+    let shell = "bash";
+
+    it("can pass in an environment variable", function* () {
+      let proc = exec("node ./fixtures/dump-args.js $EFFECTION_TEST_ENV_VAL", {
+        shell,
+        env: {
+          EFFECTION_TEST_ENV_VAL: "boop",
+          PATH: process.env.PATH as string,
+        },
+        cwd: import.meta.dirname,
+      });
+      let { stdout, code }: ProcessResult = yield* proc.expect();
+
+      const expected = `${JSON.stringify({
+        args: ["boop"],
+        envVar: "boop",
+      })}\n`;
+
+      expect(stdout).toEqual(expected);
+      expect(code).toBe(0);
+    });
+
+    it("can pass in an environment variable with curly brace syntax", function* () {
+      let proc = exec(
+        "node ./fixtures/dump-args.js ${EFFECTION_TEST_ENV_VAL}",
+        {
+          shell,
+          env: {
+            EFFECTION_TEST_ENV_VAL: "boop",
+            PATH: process.env.PATH as string,
+          },
+          cwd: import.meta.dirname,
+        },
+      );
+      let { stdout, code }: ProcessResult = yield* proc.expect();
+
+      const expected = `${JSON.stringify({
+        args: ["boop"],
+        envVar: "boop",
+      })}\n`;
+
+      expect(stdout).toEqual(expected);
+      expect(code).toBe(0);
+    });
+  });
+
+  describe("when the `shell` option is `true`", () => {
+    let shell = true;
+
+    it("can pass in an environment variable", function* () {
+      let proc = exec("node ./fixtures/dump-args.js $EFFECTION_TEST_ENV_VAL", {
+        shell,
+        env: {
+          EFFECTION_TEST_ENV_VAL: "boop",
+          PATH: process.env.PATH as string,
+        },
+        cwd: import.meta.dirname,
+      });
+      let { stdout, code }: ProcessResult = yield* proc.expect();
+
+      // this fails on windows, this shell option doesn't work on windows
+      // due to it generally running through cmd.exe which can't handle this syntax
+      let expected =
+        process.platform !== "win32"
+          ? `${JSON.stringify({ args: ["boop"], envVar: "boop" })}\n`
+          : // note the additional \r that is added
+            `${JSON.stringify({
+              args: ["$EFFECTION_TEST_ENV_VAL"],
+              envVar: "boop",
+            })}\n`;
+
+      expect(stdout).toEqual(expected);
+      expect(code).toBe(0);
+    });
+
+    it("can pass in an environment variable with curly brace syntax", function* () {
+      let proc = exec(
+        "node ./fixtures/dump-args.js ${EFFECTION_TEST_ENV_VAL}",
+        {
+          shell,
+          env: {
+            EFFECTION_TEST_ENV_VAL: "boop",
+            PATH: process.env.PATH as string,
+          },
+          cwd: import.meta.dirname,
+        },
+      );
+      let { stdout, code }: ProcessResult = yield* proc.expect();
+
+      // this fails on windows, this shell option doesn't work on windows
+      // due to it generally running through cmd.exe which can't handle this syntax
+      let expected =
+        process.platform !== "win32"
+          ? `${JSON.stringify({ args: ["boop"], envVar: "boop" })}\n`
+          : // note the additional \r that is added
+            `${JSON.stringify({
+              args: ["${EFFECTION_TEST_ENV_VAL}"],
+              envVar: "boop",
+            })}\n`;
+
+      expect(stdout).toEqual(expected);
+      expect(code).toBe(0);
+    });
+  });
+
+  describe("when the `shell` option is `false`", () => {
+    let shell = false;
+
+    it("can pass in an environment variable", function* () {
+      let proc = exec("node ./fixtures/dump-args.js $EFFECTION_TEST_ENV_VAL", {
+        shell,
+        env: {
+          EFFECTION_TEST_ENV_VAL: "boop",
+          PATH: process.env.PATH as string,
+        },
+        cwd: import.meta.dirname,
+      });
+      let { stdout, code }: ProcessResult = yield* proc.expect();
+
+      const expected = `${JSON.stringify({
+        args: ["$EFFECTION_TEST_ENV_VAL"],
+        envVar: "boop",
+      })}\n`;
+
+      expect(stdout).toEqual(expected);
+      expect(code).toBe(0);
+    });
+
+    it("can pass in an environment variable with curly brace syntax", function* () {
+      let proc = exec(
+        "node ./fixtures/dump-args.js ${EFFECTION_TEST_ENV_VAL}",
+        {
+          shell,
+          env: {
+            EFFECTION_TEST_ENV_VAL: "boop",
+            PATH: process.env.PATH as string,
+          },
+          cwd: import.meta.dirname,
+        },
+      );
+      let { stdout, code }: ProcessResult = yield* proc.expect();
+
+      // Platform behavior differences with shell: false:
+      // - PowerShell/CMD: Preserves quotes around arguments and keeps curly braces: "${EFFECTION_TEST_ENV_VAL}" + CRLF
+      // - Bash (Windows): Normalizes ${VAR} to $VAR during argument processing: $EFFECTION_TEST_ENV_VAL + LF
+      // - Bash (Unix): Keeps curly braces intact: ${EFFECTION_TEST_ENV_VAL} + LF
+      // Note: Shellwords parsing preserves braces on all platforms, but bash execution normalizes them
+      const expected = `${JSON.stringify({
+        args: ["${EFFECTION_TEST_ENV_VAL}"],
+        envVar: "boop",
+      })}\n`;
+
+      expect(stdout).toEqual(expected);
+      expect(code).toBe(0);
+    });
+  });
+
+  if (process.platform === "win32" && isBash()) {
+    describe("when the `shell` option is `process.env.shell` (Windows bash only)", () => {
+      let shell = process.env.shell;
+      // This tests Git Bash on Windows where process.env.shell is set to bash.exe
+
+      it("can pass in an environment variable", function* () {
+        let proc = exec(
+          "node ./fixtures/dump-args.js $EFFECTION_TEST_ENV_VAL",
+          {
+            shell,
+            env: {
+              EFFECTION_TEST_ENV_VAL: "boop",
+              PATH: process.env.PATH as string,
+            },
+            cwd: import.meta.dirname,
+          },
+        );
+        let { stdout, code }: ProcessResult = yield* proc.expect();
+
+        // Windows bash should resolve environment variables
+        const expected = `${JSON.stringify({
+          args: ["boop"],
+          envVar: "boop",
+        })}\n`;
+        expect(stdout).toEqual(expected);
+        expect(code).toBe(0);
+      });
+
+      it("can pass in an environment variable with curly brace syntax", function* () {
+        let proc = exec(
+          "node ./fixtures/dump-args.js ${EFFECTION_TEST_ENV_VAL}",
+          {
+            shell,
+            env: {
+              EFFECTION_TEST_ENV_VAL: "boop",
+              PATH: process.env.PATH as string,
+            },
+            cwd: import.meta.dirname,
+          },
+        );
+        let { stdout, code }: ProcessResult = yield* proc.expect();
+
+        // Windows bash should resolve environment variables with curly brace syntax
+        const expected = `${JSON.stringify({
+          args: ["boop"],
+          envVar: "boop",
+        })}\n`;
+        expect(stdout).toEqual(expected);
+        expect(code).toBe(0);
+      });
+    });
+  }
+
+  // Close the main "handles env vars" describe block
+});

package/test/fixtures/dump-args.js

@@ -0,0 +1,13 @@
+import process from "node:process";
+
+// This script is executed via Node: 'node dump-args.js arg1 arg2 ...'
+// process.argv[0] is the node executable path
+// process.argv[1] is the path to this script (dump-args.js)
+// process.argv[2] and onwards are the arguments passed from your 'exec' call.
+const args = process.argv.slice(2);
+
+// Look up the specific environment variable
+const envVar = process.env.EFFECTION_TEST_ENV_VAL;
+
+// Print a stable, predictable output string with a Unix line ending (\n)
+console.log(JSON.stringify({ args, envVar }));

package/test/fixtures/echo-server.ts

@@ -0,0 +1,49 @@
+import { createServer } from "node:http";
+import process from "node:process";
+
+console.log("starting server");
+
+const port = Number.parseInt(process.env.PORT || "29000");
+
+const server = createServer(async (req, res) => {
+  process.stderr.write("got request\n");
+
+  // Read the entire request body
+  const chunks: Buffer[] = [];
+  for await (const chunk of req) {
+    chunks.push(chunk);
+  }
+  const command = Buffer.concat(chunks).toString();
+
+  // Handle the command asynchronously to allow response to be sent first
+  setTimeout(() => {
+    readCommand(command);
+  }, 100);
+
+  // Echo the request body back
+  res.writeHead(200, { "Content-Type": "text/plain" });
+  res.end(command);
+});
+
+server.listen(port, () => {
+  console.log("listening");
+});
+
+process.on("message", (message: unknown) => {
+  console.log("got message", message);
+  if (process.send) {
+    process.send(message);
+  }
+});
+
+function readCommand(command: string) {
+  if (command.includes("exit")) {
+    console.log("exit(0)");
+    process.exit(0);
+  } else if (command.includes("fail")) {
+    console.log("exit(1)");
+    process.exit(1);
+  }
+}
+
+process.on("exit", () => console.log("exiting..."));

package/test/fixtures/hello-world-failed.js

@@ -0,0 +1,5 @@
+const { process } = globalThis;
+
+process.stdout.write("hello world\n");
+process.stderr.write("boom\n");
+process.exit(37);

package/test/fixtures/hello-world.js

@@ -0,0 +1,5 @@
+const { process } = globalThis;
+
+process.stdout.write("hello\n");
+process.stdout.write("world\n");
+process.stderr.write("boom\n");

package/test/helpers.ts

@@ -0,0 +1,69 @@
+import { type Operation, type Stream, until } from "effection";
+
+export function* captureError(op: Operation<unknown>): Operation<Error> {
+  try {
+    yield* op;
+  } catch (error) {
+    return error as Error;
+  }
+  throw new Error("expected operation to throw an error, but it did not!");
+}
+
+export function expectStreamNotEmpty(
+  stream: Stream<unknown, unknown>,
+): Operation<void> {
+  return {
+    *[Symbol.iterator]() {
+      const subscription = yield* stream;
+      let next = yield* subscription.next();
+      if (next.done) {
+        throw new Error(
+          "Expected the stream to produce at least one value before closing.",
+        );
+      }
+    },
+  };
+}
+
+export function* fetchText(input: RequestInfo | URL, init?: RequestInit) {
+  try {
+    const response = yield* until(globalThis.fetch(input, init));
+    if (!response.ok) {
+      throw new Error(response.statusText);
+    }
+    return {
+      status: response.status,
+      text: yield* until(response.text()),
+    };
+  } catch (e) {
+    throw new Error(`FetchError: ${(e as Error).message}`);
+  }
+}
+
+export function streamClose<TClose>(
+  stream: Stream<unknown, TClose>,
+): () => Operation<TClose> {
+  return function* () {
+    const subscription = yield* stream;
+    let next = yield* subscription.next();
+    while (!next.done) {
+      next = yield* subscription.next();
+    }
+    return next.value;
+  };
+}
+
+export function* expectMatch(pattern: RegExp, stream: Stream<string, unknown>) {
+  const subscription = yield* stream;
+  let next = yield* subscription.next();
+  while (!next.done) {
+    if (pattern.test(next.value)) {
+      return;
+    }
+    next = yield* subscription.next();
+  }
+
+  throw new Error(
+    "Expected the stream to produce at least one value before closing.",
+  );
+}

package/test/output-stream.test.ts

@@ -0,0 +1,73 @@
+// import { expect } from "expect";
+// import { createSignal, each, spawn } from "effection";
+// import { describe, it } from "@effectionx/bdd";
+
+// import { createOutputStream } from "../src/output-stream.ts";
+// import { Buffer } from "node:buffer";
+
+// const b = (value: string) => Buffer.from(value, "utf8");
+
+// describe("createOutputStream", () => {
+//   it("can be created from regular stream", function* () {
+//     const stream = createSignal<Buffer, void>();
+
+//     let ioStream = createOutputStream(stream);
+//     let values: Buffer[] = [];
+
+//     yield* spawn(function* () {
+//       for (const value of yield* each(ioStream)) {
+//         values.push(value);
+//         yield* each.next();
+//       }
+//     });
+
+//     stream.send(b("foo"));
+//     stream.send(b("bar"));
+//     stream.send(b("baz"));
+
+//     expect(values).toEqual([b("foo"), b("bar"), b("baz")]);
+//   });
+// });
+
+// describe("text()", () => {
+//   it("maps output to string", function* () {
+//     const stream = createSignal<Buffer, void>();
+//     let ioStream = createOutputStream(stream);
+//     let values: string[] = [];
+
+//     yield* spawn(function* () {
+//       for (const value of yield* each(ioStream.text())) {
+//         values.push(value);
+//         yield* each.next();
+//       }
+//     });
+
+//     stream.send(b("foo"));
+//     stream.send(b("bar"));
+//     stream.send(b("baz"));
+
+//     expect(values).toEqual(["foo", "bar", "baz"]);
+//   });
+// });
+
+// describe("lines()", () => {
+//   it("combines output into complete lines", function* () {
+//     const stream = createSignal<Buffer, void>();
+//     let ioStream = createOutputStream(stream);
+//     let values: string[] = [];
+
+//     yield* spawn(function* () {
+//       for (const value of yield* each(ioStream.lines())) {
+//         values.push(value);
+//         yield* each.next();
+//       }
+//     });
+
+//     stream.send(b("foo\nhello"));
+//     stream.send(b("world\n"));
+//     stream.send(b("something"));
+//     stream.close();
+
+//     expect(values).toEqual(["foo", "helloworld", "something"]);
+//   });
+// });