@effected/markdown 0.4.0 → 0.4.2

package/MarkdownDocument.js

@@ -115,10 +115,7 @@ const phrasingText = (nodes) => {
 		case "strong":
 		case "delete":
 		case "link":
-		case "linkReference":
-			out += phrasingText(node.children);
-			break;
-		default: break;
+		case "linkReference": out += phrasingText(node.children);
 	}
 	return out;
 };
@@ -340,7 +337,6 @@ var MarkdownDocument = class MarkdownDocument extends Schema.Class("MarkdownDocu
 					});
 					break;
 				}
-				default: break;
 			}
 		});
 		return entries;

package/MarkdownNode.js

@@ -460,7 +460,7 @@ var List = class extends Schema.Class("List")({
 	ordered: Schema.optionalKey(Schema.Boolean),
 	start: Schema.optionalKey(Schema.Number),
 	spread: Schema.optionalKey(Schema.Boolean),
-	children: Schema.Array(Schema.suspend(() => ListItem)),
+	children: Schema.Array(Schema.suspend(() => ListContent)),
 	position: NodePosition,
 	bulletChar: Schema.optionalKey(BulletChar),
 	delimiter: Schema.optionalKey(ListDelimiter)
@@ -499,9 +499,19 @@ var TableCell = class extends Schema.Class("TableCell")({
 * content — the cells in a {@link TableRow}. A one-member union, kept because
 * mdast names the category.
 *
+* A REAL `Schema.Union`, not a bare suspended class reference, and the
+* wrapper is load-bearing: `make` passes an already-constructed class
+* instance through a union member untouched, while a class-typed field
+* re-runs construction on every element of the array. On a 30k-row table
+* that re-construction was 1137ms for the single `Table.make` call against
+* 9ms through the union (measured; the pathological suite's "tables" case is
+* the regression instrument). The `children` fields of `TableRow`, `Table`
+* and `List` point at these category unions for exactly that reason — do not
+* "simplify" them back to the member class.
+*
 * @public
 */
-const RowContent = Schema.suspend(() => TableCell);
+const RowContent = Schema.suspend(() => Schema.Union([TableCell]));
 /**
 * TableRow — one row of a {@link Table}: the labels of the columns if it is
 * the table's first row, a data row otherwise.
@@ -510,17 +520,18 @@ const RowContent = Schema.suspend(() => TableCell);
 */
 var TableRow = class extends Schema.Class("TableRow")({
 	type: Schema.tag("tableRow"),
-	children: Schema.Array(Schema.suspend(() => TableCell)),
+	children: Schema.Array(Schema.suspend(() => RowContent)),
 	position: NodePosition
 }) {};
 /**
 * The union of every node that may appear where mdast expects **table**
 * content — the rows in a {@link Table}. A one-member union, kept because
-* mdast names the category.
+* mdast names the category — and a real `Schema.Union` for the construction
+* pass-through documented on `RowContent`.
 *
 * @public
 */
-const TableContent = Schema.suspend(() => TableRow);
+const TableContent = Schema.suspend(() => Schema.Union([TableRow]));
 /**
 * Table — GFM two-dimensional data.
 *
@@ -534,7 +545,7 @@ const TableContent = Schema.suspend(() => TableRow);
 var Table = class extends Schema.Class("Table")({
 	type: Schema.tag("table"),
 	align: Schema.optionalKey(Schema.Array(Schema.NullOr(TableAlign))),
-	children: Schema.Array(Schema.suspend(() => TableRow)),
+	children: Schema.Array(Schema.suspend(() => TableContent)),
 	position: NodePosition
 }) {};
 /**
@@ -563,11 +574,12 @@ const FlowContent = Schema.suspend(() => Schema.Union([
 /**
 * The union of every node that may appear where mdast expects **list**
 * content. A one-member union, kept because mdast names the category and
-* later dialects widen it.
+* later dialects widen it — and a real `Schema.Union` for the construction
+* pass-through documented on `RowContent`.
 *
 * @public
 */
-const ListContent = Schema.suspend(() => ListItem);
+const ListContent = Schema.suspend(() => Schema.Union([ListItem]));
 /**
 * The frontmatter formats the capture recognizes, keyed by their opening
 * fence: `---` is yaml, `+++` is toml and `---json` is json.

package/index.d.ts

@@ -540,6 +540,16 @@ declare class TableCell extends TableCell_base {}
  * content — the cells in a {@link TableRow}. A one-member union, kept because
  * mdast names the category.
  *
+ * A REAL `Schema.Union`, not a bare suspended class reference, and the
+ * wrapper is load-bearing: `make` passes an already-constructed class
+ * instance through a union member untouched, while a class-typed field
+ * re-runs construction on every element of the array. On a 30k-row table
+ * that re-construction was 1137ms for the single `Table.make` call against
+ * 9ms through the union (measured; the pathological suite's "tables" case is
+ * the regression instrument). The `children` fields of `TableRow`, `Table`
+ * and `List` point at these category unions for exactly that reason — do not
+ * "simplify" them back to the member class.
+ *
  * @public
  */
 declare const RowContent: Schema.Codec<RowContent>;
@@ -564,7 +574,8 @@ declare class TableRow extends TableRow_base {}
 /**
  * The union of every node that may appear where mdast expects **table**
  * content — the rows in a {@link Table}. A one-member union, kept because
- * mdast names the category.
+ * mdast names the category — and a real `Schema.Union` for the construction
+ * pass-through documented on `RowContent`.
  *
  * @public
  */
@@ -615,7 +626,8 @@ type FlowContent = Blockquote | Code | Definition | FootnoteDefinition | Heading
 /**
  * The union of every node that may appear where mdast expects **list**
  * content. A one-member union, kept because mdast names the category and
- * later dialects widen it.
+ * later dialects widen it — and a real `Schema.Union` for the construction
+ * pass-through documented on `RowContent`.
  *
  * @public
  */

package/internal/references.js

@@ -20,6 +20,22 @@ const reLinkLabel = /^\[(?:[^\\[\]]|\\.){0,1000}\]/s;
 * between seconds and minutes.
 */
 const isWhitespaceCode = (code) => code === 32 || code === 9 || code === 10 || code === 11 || code === 12 || code === 13;
+/**
+* The most `(` a bare link destination may hold open at once.
+*
+* cmark's `MAX_LINK_DEST_PARENS` bound in `manual_scan_link_url`, and the
+* limit the spec explicitly sanctions ("Implementations may impose limits on
+* parentheses nesting to avoid performance issues, but at least three levels
+* of nesting should be supported"). Without it the bare-destination walk is
+* the engine's one quadratic: on `"[a](b".repeat(n)` there is no whitespace
+* and no unbalanced `)` to stop at, so every failed inline-link attempt
+* scanned to the end of the subject — O(n) per `]`, O(n^2) overall. With the
+* cap a failed attempt stops at the 33rd `(`, a constant distance, and the
+* pathological suite's "unclosed links B" runs linear. commonmark.js@0.31.2
+* has no such cap and shares the quadratic; the C reference is the authority
+* here.
+*/
+const MAX_LINK_DESTINATION_PARENS = 32;
 const C_BACKSLASH = 92;
 const C_COLON = 58;
 const C_LESSTHAN = 60;
@@ -81,6 +97,7 @@ var ReferenceScanner = class {
 			} else if (code === C_OPEN_PAREN) {
 				this.pos += 1;
 				openParens += 1;
+				if (openParens > MAX_LINK_DESTINATION_PARENS) return;
 			} else if (code === C_CLOSE_PAREN) {
 				if (openParens < 1) break;
 				this.pos += 1;

package/internal/stringify.js

@@ -291,7 +291,6 @@ const serializeInlines = (children, context, state, startsLine, junctionGuard) =
 			case "footnoteReference":
 				out += `[^${escapeLabel(child.label ?? child.identifier)}]`;
 				atLineStart = false;
-				break;
 		}
 		index += 1;
 		unguard(state);

package/package.json

@@ -1,6 +1,6 @@
 {
 	"name": "@effected/markdown",
-	"version": "0.4.0",
+	"version": "0.4.2",
 	"private": false,
 	"description": "CommonMark and GFM markdown parse, edit and transform schemas for Effect",
 	"keywords": [
@@ -39,9 +39,9 @@
 		"./package.json": "./package.json"
 	},
 	"peerDependencies": {
-		"@effected/jsonc": "~0.5.1",
-		"@effected/toml": "~0.3.1",
-		"@effected/yaml": "~0.6.0",
+		"@effected/jsonc": "^0.5.2",
+		"@effected/toml": "^0.3.2",
+		"@effected/yaml": "^0.6.1",
 		"effect": "4.0.0-beta.101"
 	},
 	"peerDependenciesMeta": {