@effected/github 0.6.0 → 0.6.1

package/CheckRun.js

@@ -1,5 +1,6 @@
 import { GitHubClient } from "./GitHubClient.js";
 import { Repo } from "./Repo.js";
+import { numericId } from "./internal/ids.js";
 import { Cause, Context, Effect, Exit, Layer, Ref, Schema } from "effect";
 
 //#region src/CheckRun.ts
@@ -197,7 +198,7 @@ const concludeFor = (name, id, exit, recorded, complete) => {
 	return Exit.isSuccess(exit) ? write : Effect.ignore(write);
 };
 const refOf = (raw) => CheckRunRef.make({
-	id: raw.id,
+	id: numericId(raw.id),
 	name: raw.name,
 	url: raw.html_url ?? "",
 	status: raw.status

package/GitHubApp.js

@@ -1,6 +1,7 @@
 import { GitHubError } from "./GitHubError.js";
 import { GitHubGraphQLError } from "./GraphQL.js";
 import { GitHubClient, makeClientShape } from "./GitHubClient.js";
+import { numericId } from "./internal/ids.js";
 import { Clock, Context, DateTime, Duration, Effect, Layer, Option, Redacted, Ref, Schema, Stream } from "effect";
 import githubAppJwt from "universal-github-app-jwt";
 
@@ -261,7 +262,7 @@ function makeApp(options) {
 	return Effect.sync(() => {
 		const installations = Effect.fn("GitHubApp.installations")(function* (credentials) {
 			return (yield* (yield* asApp(credentials, options)).paginate("GET /app/installations", {}).pipe(Effect.catch(appFailure("installation")))).map((entry) => Installation.make({
-				id: entry.id,
+				id: numericId(entry.id),
 				...entry.account !== null && entry.account !== void 0 && "login" in entry.account ? { account: entry.account.login } : {}
 			}));
 		});
@@ -304,7 +305,7 @@ function makeApp(options) {
 				return AppIdentity.make({
 					slug,
 					name,
-					...Option.isSome(user) ? { userId: user.value.id } : {}
+					...Option.isSome(user) ? { userId: numericId(user.value.id) } : {}
 				});
 			}),
 			installations

package/GitHubIssue.js

@@ -1,6 +1,7 @@
 import { GraphQLDocument } from "./GraphQL.js";
 import { GitHubClient } from "./GitHubClient.js";
 import { Repo } from "./Repo.js";
+import { numericId } from "./internal/ids.js";
 import { CommentRecord } from "./PullRequestComment.js";
 import { Context, Effect, Layer, Schema } from "effect";
 
@@ -212,13 +213,14 @@ const make = (client) => ({
 			repo,
 			number
 		});
-		return (yield* client.request("POST /repos/{owner}/{repo}/issues/{issue_number}/comments", {
+		const created = yield* client.request("POST /repos/{owner}/{repo}/issues/{issue_number}/comments", {
 			owner,
 			repo,
 			issue_number: number,
 			body,
 			headers: API_VERSION_HEADERS
-		})).id;
+		});
+		return numericId(created.id);
 	}),
 	commentOnce: Effect.fn("GitHubIssue.commentOnce")(function* (issueNumber, marker, body) {
 		const { owner, repo } = yield* Repo;
@@ -237,7 +239,7 @@ const make = (client) => ({
 		if (existing !== void 0) return CommentOnceResult.make({
 			wrote: false,
 			comment: CommentRecord.make({
-				id: existing.id,
+				id: numericId(existing.id),
 				body: existing.body ?? "",
 				url: existing.html_url
 			})
@@ -252,7 +254,7 @@ const make = (client) => ({
 		return CommentOnceResult.make({
 			wrote: true,
 			comment: CommentRecord.make({
-				id: created.id,
+				id: numericId(created.id),
 				body: created.body ?? "",
 				url: created.html_url
 			})

package/PullRequestComment.js

@@ -1,5 +1,6 @@
 import { GitHubClient } from "./GitHubClient.js";
 import { Repo } from "./Repo.js";
+import { numericId } from "./internal/ids.js";
 import { Context, Effect, Layer, Option, Schema } from "effect";
 
 //#region src/PullRequestComment.ts
@@ -61,7 +62,7 @@ const unstubbed = (member) => {
 	throw new Error(`PullRequestComment.makeTest: ${member}() was called but not stubbed — pass an override.`);
 };
 const recordOf = (raw) => CommentRecord.make({
-	id: raw.id,
+	id: numericId(raw.id),
 	body: raw.body ?? "",
 	url: raw.html_url
 });

package/internal/ids.js

@@ -0,0 +1,17 @@
+//#region src/internal/ids.ts
+/**
+* Narrows the `number | bigint` resource ids `@octokit/types` v17 declares
+* back to `number`.
+*
+* GitHub's REST payloads arrive through `JSON.parse`, which never produces a
+* bigint, so at runtime the value is always a number today — the union is
+* upstream future-proofing for ids beyond 2^53. If GitHub ever crosses that
+* line, the `id: number` fields on this package's public records have to be
+* redesigned; a runtime coercion here could not paper over it.
+*
+* Leaf module: imports nothing.
+*/
+const numericId = (id) => Number(id);
+
+//#endregion
+export { numericId };

package/package.json

@@ -1,6 +1,6 @@
 {
 	"name": "@effected/github",
-	"version": "0.6.0",
+	"version": "0.6.1",
 	"private": false,
 	"description": "Typed GitHub REST and GraphQL services over the octokit core request surface, with app auth and resource helpers.",
 	"keywords": [
@@ -40,8 +40,8 @@
 	"dependencies": {
 		"@effected/semver": "^0.5.0",
 		"@octokit/core": "^7.0.6",
-		"@octokit/plugin-paginate-rest": "^14.0.0",
-		"@octokit/types": "^16.0.0",
+		"@octokit/plugin-paginate-rest": "^15.0.0",
+		"@octokit/types": "^17.0.0",
 		"blakejs": "1.2.1",
 		"tweetnacl": "1.0.3",
 		"universal-github-app-jwt": "^2.2.2"